commit 5a7882e391835784518f1fced8741d03e7c025d4
author Christian Resell <christian.resell@gmail.com> Fri May 26 21:44:07 2017 +0200
committer Brenden Blanco <bblanco@gmail.com> Tue May 30 08:32:17 2017 -0700
tree ede78806a009c3359fc1b55977b02234b0fd04cb
parent c6c9f0a319bbf49c8bb66a74af5eb240816c6803

bcc_procutils_which: return if snprintf fails or would overflow

src/cc/bcc_proc.c

diff --git a/src/cc/bcc_proc.c b/src/cc/bcc_proc.c
index 5343dbb..b6c6132 100644
--- a/src/cc/bcc_proc.c
+++ b/src/cc/bcc_proc.c
@@ -46,8 +46,10 @@
     const size_t path_len = next - PATH;
 
     if (path_len) {
-      snprintf(buffer, sizeof(buffer), "%.*s/%s",
-	       (int)path_len, PATH, binpath);
+      int ret = snprintf(buffer, sizeof(buffer), "%.*s/%s",
+	                  (int)path_len, PATH, binpath);
+      if (ret < 0 || ret >= sizeof(buffer))
+        return 0;
 
       if (bcc_elf_is_exe(buffer))
         return strdup(buffer);