Remove semicolon at the end of define BPF_STACK_TRACE()
The semicolon is usually added when the macro is used. Update both the
macro definition and all uses.
Signed-off-by: Song Liu <songliubraving@fb.com>
diff --git a/examples/cpp/TCPSendStack.cc b/examples/cpp/TCPSendStack.cc
index fd0b68d..65ba768 100644
--- a/examples/cpp/TCPSendStack.cc
+++ b/examples/cpp/TCPSendStack.cc
@@ -27,7 +27,7 @@
int kernel_stack;
};
-BPF_STACK_TRACE(stack_traces, 10240)
+BPF_STACK_TRACE(stack_traces, 10240);
BPF_HASH(counts, struct stack_key_t, uint64_t);
int on_tcp_send(struct pt_regs *ctx) {
diff --git a/examples/lua/memleak.lua b/examples/lua/memleak.lua
index 27023aa..99c1522 100755
--- a/examples/lua/memleak.lua
+++ b/examples/lua/memleak.lua
@@ -26,7 +26,7 @@
BPF_HASH(sizes, u64);
BPF_HASH(allocs, u64, struct alloc_info_t);
-BPF_STACK_TRACE(stack_traces, 10240)
+BPF_STACK_TRACE(stack_traces, 10240);
int alloc_enter(struct pt_regs *ctx, size_t size)
{
diff --git a/examples/lua/offcputime.lua b/examples/lua/offcputime.lua
index 7875dbb..09c704f 100755
--- a/examples/lua/offcputime.lua
+++ b/examples/lua/offcputime.lua
@@ -27,7 +27,7 @@
};
BPF_HASH(counts, struct key_t);
BPF_HASH(start, u32);
-BPF_STACK_TRACE(stack_traces, 10240)
+BPF_STACK_TRACE(stack_traces, 10240);
int oncpu(struct pt_regs *ctx, struct task_struct *prev) {
u32 pid;
diff --git a/examples/tracing/mallocstacks.py b/examples/tracing/mallocstacks.py
index 36a0a7f..0def220 100644
--- a/examples/tracing/mallocstacks.py
+++ b/examples/tracing/mallocstacks.py
@@ -25,7 +25,7 @@
#include <uapi/linux/ptrace.h>
BPF_HASH(calls, int);
-BPF_STACK_TRACE(stack_traces, 1024)
+BPF_STACK_TRACE(stack_traces, 1024);
int alloc_enter(struct pt_regs *ctx, size_t size) {
int key = stack_traces.get_stackid(ctx,
diff --git a/examples/tracing/stacksnoop.py b/examples/tracing/stacksnoop.py
index e4bbb51..7b3d018 100755
--- a/examples/tracing/stacksnoop.py
+++ b/examples/tracing/stacksnoop.py
@@ -52,7 +52,7 @@
char comm[TASK_COMM_LEN];
};
-BPF_STACK_TRACE(stack_traces, 128)
+BPF_STACK_TRACE(stack_traces, 128);
BPF_PERF_OUTPUT(events);
void trace_stack(struct pt_regs *ctx) {
diff --git a/src/cc/export/helpers.h b/src/cc/export/helpers.h
index 1fa4a64..ad57478 100644
--- a/src/cc/export/helpers.h
+++ b/src/cc/export/helpers.h
@@ -184,7 +184,7 @@
};
#define BPF_STACK_TRACE(_name, _max_entries) \
- BPF_TABLE("stacktrace", int, struct bpf_stacktrace, _name, _max_entries);
+ BPF_TABLE("stacktrace", int, struct bpf_stacktrace, _name, _max_entries)
// packet parsing state machine helpers
#define cursor_advance(_cursor, _len) \
diff --git a/tools/memleak.py b/tools/memleak.py
index 5788e32..791a953 100755
--- a/tools/memleak.py
+++ b/tools/memleak.py
@@ -138,7 +138,7 @@
BPF_HASH(sizes, u64);
BPF_TABLE("hash", u64, struct alloc_info_t, allocs, 1000000);
BPF_HASH(memptrs, u64, u64);
-BPF_STACK_TRACE(stack_traces, 10240)
+BPF_STACK_TRACE(stack_traces, 10240);
BPF_TABLE("hash", u64, struct combined_alloc_info_t, combined_allocs, 10240);
static inline void update_statistics_add(u64 stack_id, u64 sz) {
diff --git a/tools/offcputime.py b/tools/offcputime.py
index 1f47459..fb7e2fd 100755
--- a/tools/offcputime.py
+++ b/tools/offcputime.py
@@ -119,7 +119,7 @@
};
BPF_HASH(counts, struct key_t);
BPF_HASH(start, u32);
-BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE)
+BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE);
int oncpu(struct pt_regs *ctx, struct task_struct *prev) {
u32 pid = prev->pid;
diff --git a/tools/offwaketime.py b/tools/offwaketime.py
index 10b427a..2206f8e 100755
--- a/tools/offwaketime.py
+++ b/tools/offwaketime.py
@@ -125,7 +125,7 @@
};
BPF_HASH(wokeby, u32, struct wokeby_t);
-BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE)
+BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE);
int waker(struct pt_regs *ctx, struct task_struct *p) {
u32 pid = p->pid;
diff --git a/tools/old/profile.py b/tools/old/profile.py
index 7dbc246..04ca13a 100755
--- a/tools/old/profile.py
+++ b/tools/old/profile.py
@@ -139,7 +139,7 @@
};
BPF_HASH(counts, struct key_t);
BPF_HASH(start, u32);
-BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE)
+BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE);
// This code gets a bit complex. Probably not suitable for casual hacking.
diff --git a/tools/profile.py b/tools/profile.py
index 687a162..56a928c 100755
--- a/tools/profile.py
+++ b/tools/profile.py
@@ -127,7 +127,7 @@
};
BPF_HASH(counts, struct key_t);
BPF_HASH(start, u32);
-BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE)
+BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE);
// This code gets a bit complex. Probably not suitable for casual hacking.
diff --git a/tools/stacksnoop.lua b/tools/stacksnoop.lua
index 7dfaf3d..0e0ad97 100755
--- a/tools/stacksnoop.lua
+++ b/tools/stacksnoop.lua
@@ -25,7 +25,7 @@
char comm[TASK_COMM_LEN];
};
-BPF_STACK_TRACE(stack_traces, 128)
+BPF_STACK_TRACE(stack_traces, 128);
BPF_PERF_OUTPUT(events);
void trace_stack(struct pt_regs *ctx) {
diff --git a/tools/wakeuptime.py b/tools/wakeuptime.py
index b242f30..dbc9b1b 100755
--- a/tools/wakeuptime.py
+++ b/tools/wakeuptime.py
@@ -97,7 +97,7 @@
};
BPF_HASH(counts, struct key_t);
BPF_HASH(start, u32);
-BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE)
+BPF_STACK_TRACE(stack_traces, STACK_STORAGE_SIZE);
int offcpu(struct pt_regs *ctx) {
u32 pid = bpf_get_current_pid_tgid();