commit 32b6346c2c923c81369badb95317f05b7a0cb6fc
author Niels Boehm <blubberdiblub@gmail.com> Mon Jun 13 12:25:24 2016 +0200
committer Niels Boehm <blubberdiblub@gmail.com> Mon Jun 13 12:25:24 2016 +0200
tree 61672f31e9c796301b2f3b3c20a94630ffb11fb5
parent 4e62a6f27536171e725902e254102c59d741a2b2

Use and test syntax against None in all_tests.

Comparing against 0 or just testing the truthiness is suboptimal, as you
lose the ability to explicitly set the syntax to CS_OPT_SYNTAX_DEFAULT
or 0.

Also, using None to mean "don't change" or other "here is no value"
interpretations is much more pythonic than the C-idiomatic 0.

bindings/python/test_skipdata.py

diff --git a/bindings/python/test_skipdata.py b/bindings/python/test_skipdata.py
index 0caa20b..3b8dd75 100755
--- a/bindings/python/test_skipdata.py
+++ b/bindings/python/test_skipdata.py
@@ -12,8 +12,8 @@
 RANDOM_CODE = b"\xed\x00\x00\x00\x00\x1a\x5a\x0f\x1f\xff\xc2\x09\x80\x00\x00\x00\x07\xf7\xeb\x2a\xff\xff\x7f\x57\xe3\x01\xff\xff\x7f\x57\xeb\x00\xf0\x00\x00\x24\xb2\x4f\x00\x78"
 
 all_tests = (
-        (CS_ARCH_X86, CS_MODE_32, X86_CODE32, "X86 32 (Intel syntax)", 0),
-        (CS_ARCH_ARM, CS_MODE_ARM, RANDOM_CODE, "Arm", 0),
+        (CS_ARCH_X86, CS_MODE_32, X86_CODE32, "X86 32 (Intel syntax)", None),
+        (CS_ARCH_ARM, CS_MODE_ARM, RANDOM_CODE, "Arm", None),
 )
 
 
@@ -34,7 +34,7 @@
         try:
             md = Cs(arch, mode)
 
-            if syntax != 0:
+            if syntax is not None:
                 md.syntax = syntax
 
             md.skipdata = True