commit 0304c6cb7fd3b2137213858b1e5ae85ef3f4f8e2
author Steve Naroff <snaroff@apple.com> Sat Dec 05 12:23:07 2009 +0000
committer Steve Naroff <snaroff@apple.com> Sat Dec 05 12:23:07 2009 +0000
tree a43fbe16770aef7f8dc484ea5c4c6713c13247d5
parent 0e7049fc6f2cc13d1236630782b702f11f6aaf9f

Remove 'LangOpts' from Diagnostic (added in http://llvm.org/viewvc/llvm-project?view=rev&revision=90642).

Simply use the 'LangOpts' member already present in TextDiagnosticPrinter.

Sorry for the confusion!


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@90664 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/Diagnostic.h

diff --git a/include/clang/Basic/Diagnostic.h b/include/clang/Basic/Diagnostic.h
index b9d1967..b2523f2 100644
--- a/include/clang/Basic/Diagnostic.h
+++ b/include/clang/Basic/Diagnostic.h
@@ -182,7 +182,6 @@
   bool SuppressAllDiagnostics;   // Suppress all diagnostics.
   ExtensionHandling ExtBehavior; // Map extensions onto warnings or errors?
   DiagnosticClient *Client;
-  LangOptions *LangOpts;
 
   /// DiagMappings - Mapping information for diagnostics.  Mapping info is
   /// packed into four bits per diagnostic.  The low three bits are the mapping
@@ -239,9 +238,6 @@
   DiagnosticClient *getClient() { return Client; }
   const DiagnosticClient *getClient() const { return Client; }
 
-  LangOptions *getLangOpts() const { return LangOpts; }
-  void setLangOpts(LangOptions *LOpts) { LangOpts = LOpts; }
-  
   /// pushMappings - Copies the current DiagMappings and pushes the new copy
   /// onto the top of the stack.
   void pushMappings();

lib/Basic/Diagnostic.cpp

diff --git a/lib/Basic/Diagnostic.cpp b/lib/Basic/Diagnostic.cpp
index 1f51791..8d0d813 100644
--- a/lib/Basic/Diagnostic.cpp
+++ b/lib/Basic/Diagnostic.cpp
@@ -210,7 +210,6 @@
   ErrorOccurred = false;
   FatalErrorOccurred = false;
   NumDiagnostics = 0;
-  LangOpts = 0;
   
   NumErrors = 0;
   CustomDiagInfo = 0;

lib/Frontend/TextDiagnosticPrinter.cpp

diff --git a/lib/Frontend/TextDiagnosticPrinter.cpp b/lib/Frontend/TextDiagnosticPrinter.cpp
index eeca97d..f8bb21d 100644
--- a/lib/Frontend/TextDiagnosticPrinter.cpp
+++ b/lib/Frontend/TextDiagnosticPrinter.cpp
@@ -655,9 +655,7 @@
         OS.changeColor(savedColor, true);
       
       // Emit a Visual Studio compatible line number syntax.
-      // This check is a bit paranoid (in case LangOpts isn't set).
-      if (Info.getDiags() && Info.getDiags()->getLangOpts() &&
-          Info.getDiags()->getLangOpts()->Microsoft) {
+      if (LangOpts && LangOpts->Microsoft) {
         OS << PLoc.getFilename() << '(' << LineNo << ')';
         OS << " : ";
       } else {

tools/clang-cc/clang-cc.cpp

diff --git a/tools/clang-cc/clang-cc.cpp b/tools/clang-cc/clang-cc.cpp
index fbc2847..11a4f24 100644
--- a/tools/clang-cc/clang-cc.cpp
+++ b/tools/clang-cc/clang-cc.cpp
@@ -236,8 +236,6 @@
   Clang.createDiagnostics(argc, argv);
   if (!Clang.hasDiagnostics())
     return 1;
-
-  Clang.getDiagnostics().setLangOpts(&Clang.getLangOpts());
   
   // Set an error handler, so that any LLVM backend diagnostics go through our
   // error handler.