commit 0e35b4ecee380c2b4c33d75da6bc2fb6f6bc7df3
author Richard Smith <richard-llvm@metafoo.co.uk> Tue Dec 06 23:25:15 2011 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Tue Dec 06 23:25:15 2011 +0000
tree dbadb1c79b050cb2e31e6b8d5e9e55b5f25c05b9
parent a91efb14cbf6af999dee02d9b611a57c7b52e209

DeadStoresChecker: when whitelisting dead initializations with constants, look
for a foldable constant rather than an IR-level constant. This is still far too
liberal, but is a step in the right direction.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@145990 91177308-0d34-0410-b5e6-96231b3b80d8

lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

diff --git a/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp b/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
index 79c889d..448c750 100644
--- a/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
+++ b/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
@@ -274,7 +274,7 @@
               // If x is EVER assigned a new value later, don't issue
               // a warning.  This is because such initialization can be
               // due to defensive programming.
-              if (E->isConstantInitializer(Ctx, false))
+              if (E->isEvaluatable(Ctx))
                 return;
 
               if (DeclRefExpr *DRE=dyn_cast<DeclRefExpr>(E->IgnoreParenCasts()))