commit 31310a21fb2a9f13950f864f681c86080b05d5b2
author Sebastian Redl <sebastian.redl@getdesigned.at> Mon Feb 01 20:16:42 2010 +0000
committer Sebastian Redl <sebastian.redl@getdesigned.at> Mon Feb 01 20:16:42 2010 +0000
tree 38d3c90c066260cc56b899305d21f9c702b3e74f
parent 21b91a35fb95d7a8b5bdc8634ff8f2231e4d0a1c

In C++, an initializer on a variable doesn't necessarily mean it's the definition. With that in mind, rename getDefinition to getAnyInitializer (to distinguish it from getInit) and reimplement it in terms of isThisDeclarationADefinition. Update all code to use this new function.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@94999 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDeclCXX.cpp

diff --git a/lib/Sema/SemaDeclCXX.cpp b/lib/Sema/SemaDeclCXX.cpp
index bba0e5d..745bd51 100644
--- a/lib/Sema/SemaDeclCXX.cpp
+++ b/lib/Sema/SemaDeclCXX.cpp
@@ -4062,8 +4062,8 @@
                              AbstractVariableType))
     VDecl->setInvalidDecl();
 
-  const VarDecl *Def = 0;
-  if (VDecl->getDefinition(Def)) {
+  const VarDecl *Def;
+  if ((Def = VDecl->getDefinition()) && Def != VDecl) {
     Diag(VDecl->getLocation(), diag::err_redefinition)
     << VDecl->getDeclName();
     Diag(Def->getLocation(), diag::note_previous_definition);