[analyzer] Improve the diagnostic for the self-init checker. Suggestion by Ted!
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@124263 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp b/lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp
index b62d230..2eceb9c 100644
--- a/lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp
+++ b/lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp
@@ -102,8 +102,8 @@
class InitSelfBug : public BugType {
const std::string desc;
public:
- InitSelfBug() : BugType("missing \"self = [{initializer}]\"",
- "missing \"self = [{initializer}]\"") {}
+ InitSelfBug() : BugType("missing \"self = [(super or self) init...]\"",
+ "missing \"self = [(super or self) init...]\"") {}
};
} // end anonymous namespace
@@ -209,7 +209,8 @@
return;
checkForInvalidSelf(E->getBase(), C,
- "Using an ivar before setting 'self' to the result of an initializer");
+ "Instance variable used before setting 'self' to the result of "
+ "'[(super or self) init...]'");
}
void ObjCSelfInitChecker::PreVisitReturnStmt(CheckerContext &C,
@@ -220,7 +221,8 @@
return;
checkForInvalidSelf(S->getRetValue(), C,
- "Returning 'self' before setting it to the result of an initializer");
+ "Returning 'self' before setting it to the result of "
+ "'[(super or self) init...]'");
}
// When a call receives a reference to 'self', [Pre/Post]VisitGenericCall pass