commit 4cc83c2b0aed5ab06081ea3250426c3a7e58df93
author Fariborz Jahanian <fjahanian@apple.com> Wed Aug 15 18:42:26 2012 +0000
committer Fariborz Jahanian <fjahanian@apple.com> Wed Aug 15 18:42:26 2012 +0000
tree 3b53e65ddaa4920f727177b6566d4d8263518d94
parent 9e4abb4aa90c9785dcbaf4e69a320e6a2983b526

Patch to warn about __private_extern__ on tentative definitions
as it does something unexpected (but gcc compatible).
Suggest use of __attribute__((visibility("hidden")))
on declaration instead. // rdar://7703982


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@161972 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDecl.cpp

diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 6526d01..d37fbf5 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -6754,6 +6754,10 @@
                                  diag::err_abstract_type_in_decl,
                                  AbstractVariableType))
         Var->setInvalidDecl();
+      if (!Type->isDependentType() && !Var->isInvalidDecl() &&
+          Var->getStorageClass() == SC_PrivateExtern)
+        Diag(Var->getLocation(), diag::warn_private_extern);
+        
       return;
 
     case VarDecl::TentativeDefinition: