Allow attributes 'objc_ownership_retain' and 'objc_ownership_release' to be
applied to ObjCMethodDecls, not just parameters. This allows one to specific
side-effects on the receiver of a message expression. No checker support yet.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@70505 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp
index 4853028..1e3a7e5 100644
--- a/lib/Sema/SemaDeclAttr.cpp
+++ b/lib/Sema/SemaDeclAttr.cpp
@@ -1559,10 +1559,10 @@
d->addAttr(::new (S.Context) ObjCOwnershipReturnsAttr());
}
-static void HandleObjCOwnershipParmAttr(Decl *d, const AttributeList &Attr,
- Sema &S) {
+static void HandleObjCOwnershipAttr(Decl *d, const AttributeList &Attr,
+ Sema &S, bool attachToMethodDecl = false) {
- if (!isa<ParmVarDecl>(d)) {
+ if (!isa<ParmVarDecl>(d) && (!attachToMethodDecl || !isa<ObjCMethodDecl>(d))){
const char *name;
switch (Attr.getKind()) {
@@ -1582,7 +1582,8 @@
};
S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) << name
- << 4 /* parameter */;
+ << (attachToMethodDecl ? 5 /* parameter or method decl */
+ : 4 /* parameter */);
return;
}
@@ -1643,10 +1644,11 @@
// Checker-specific.
case AttributeList::AT_objc_ownership_cfrelease:
case AttributeList::AT_objc_ownership_cfretain:
+ HandleObjCOwnershipAttr(D, Attr, S); break;
case AttributeList::AT_objc_ownership_make_collectable:
case AttributeList::AT_objc_ownership_release:
case AttributeList::AT_objc_ownership_retain:
- HandleObjCOwnershipParmAttr(D, Attr, S); break;
+ HandleObjCOwnershipAttr(D, Attr, S, true); break;
case AttributeList::AT_objc_ownership_returns:
HandleObjCOwnershipReturnsAttr(D, Attr, S); break;