Diagnose if an implementation implements a forward class
declaration (and avoid issuing bogus error later on).
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@69928 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Sema/SemaDeclObjC.cpp b/lib/Sema/SemaDeclObjC.cpp
index 3c544ed..6702eb9 100644
--- a/lib/Sema/SemaDeclObjC.cpp
+++ b/lib/Sema/SemaDeclObjC.cpp
@@ -623,8 +623,10 @@
} else {
// Is there an interface declaration of this class; if not, warn!
IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
- if (!IDecl)
+ if (!IDecl || IDecl->isForwardDecl()) {
Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
+ IDecl = 0;
+ }
}
// Check that super class name is valid class name
diff --git a/test/SemaObjC/class-impl-1.m b/test/SemaObjC/class-impl-1.m
index 5cd8a75..5a67bef 100644
--- a/test/SemaObjC/class-impl-1.m
+++ b/test/SemaObjC/class-impl-1.m
@@ -31,3 +31,10 @@
@implementation INTF4 @end // expected-warning {{cannot find interface declaration for 'INTF4'}}
+@class INTF5;
+
+@implementation INTF5 { // expected-warning {{cannot find interface declaration for 'INTF5'}}
+ int x;
+}
+@end
+
diff --git a/test/SemaObjC/synchronized.m b/test/SemaObjC/synchronized.m
index e8e668f..7131265 100644
--- a/test/SemaObjC/synchronized.m
+++ b/test/SemaObjC/synchronized.m
@@ -1,6 +1,6 @@
// RUN: clang-cc -fsyntax-only -verify %s
-@class PBXTrackableTaskManager;
+@interface PBXTrackableTaskManager @end
@implementation PBXTrackableTaskManager
- (id) init {}