commit 89a72c56e87128c3e86051131b510335bc0f09e0
author Chris Lattner <sabre@nondot.org> Sun Apr 05 00:59:53 2009 +0000
committer Chris Lattner <sabre@nondot.org> Sun Apr 05 00:59:53 2009 +0000
tree 347d3061039a8dcf711ee59feba84fe27d062008
parent 269498481abb050d2627602ee100ef9370a6fd04

Add a warning for questionable va_args usage.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68435 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp

diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index a43c2c3..a4335ea 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -4726,11 +4726,18 @@
 
   AssignConvertType ConvResult = 
     CheckAssignmentConstraints(VaListType, E->getType());
-  if (ConvResult != Compatible &&
-      ConvResult != CompatiblePointerDiscardsQualifiers)
+  switch (ConvResult) {
+  case Compatible: break;  // Everything good.
+  case CompatiblePointerDiscardsQualifiers:
+    Diag(E->getLocStart(), diag::warn_va_arg_with_qualified_va_list)
+      << E->getType() << E->getSourceRange();
+    break;
+
+  default:
     return ExprError(Diag(E->getLocStart(),
                          diag::err_first_argument_to_va_arg_not_of_type_va_list)
       << E->getType() << E->getSourceRange());
+  }
 
   // FIXME: Check that type is complete/non-abstract
   // FIXME: Warn if a non-POD type is passed in.