[analyzer] Remove bogus assert: in C++11, 'new' can do list-initialization.
Previously, we asserted that whenever 'new' did not include a constructor
call, the type must be a non-record type. In C++11, however, uniform
initialization syntax (braces) allow 'new' to construct records with
list-initialization: "new Point{1, 2}".
Removing this assertion should be perfectly safe; the code here matches
what VisitDeclStmt does for regions allocated on the stack.
<rdar://problem/14403437>
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@186028 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp b/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
index 3f16c62..1342e41 100644
--- a/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
+++ b/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
@@ -431,8 +431,6 @@
if (!isa<CXXConstructExpr>(Init)) {
assert(Bldr.getResults().size() == 1);
Bldr.takeNodes(NewN);
-
- assert(!CNE->getType()->getPointeeCXXRecordDecl());
evalBind(Dst, CNE, NewN, Result, State->getSVal(Init, LCtx),
/*FirstInit=*/IsStandardGlobalOpNewFunction);
}
diff --git a/test/Analysis/new.cpp b/test/Analysis/new.cpp
index 8d3eee9..27cbb08 100644
--- a/test/Analysis/new.cpp
+++ b/test/Analysis/new.cpp
@@ -170,6 +170,16 @@
c->f(0); // no-warning
}
+void testAggregateNew() {
+ struct Point { int x, y; };
+ new Point{1, 2}; // no crash
+
+ Point p;
+ new (&p) Point{1, 2}; // no crash
+ clang_analyzer_eval(p.x == 1); // expected-warning{{TRUE}}
+ clang_analyzer_eval(p.y == 2); // expected-warning{{TRUE}}
+}
+
//--------------------------------
// Incorrectly-modelled behavior
//--------------------------------