Strip paren expressions when trying to diagnose "cast as lvalue"
extension.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@69100 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp
index 08ab544..973e662 100644
--- a/lib/AST/Expr.cpp
+++ b/lib/AST/Expr.cpp
@@ -775,7 +775,7 @@
// lvalue, then this is probably a use of the old-school "cast as lvalue"
// GCC extension. We don't support it, but we want to produce good
// diagnostics when it happens so that the user knows why.
- if (const CStyleCastExpr *CE = dyn_cast<CStyleCastExpr>(this))
+ if (const CStyleCastExpr *CE = dyn_cast<CStyleCastExpr>(IgnoreParens()))
if (CE->getSubExpr()->isLvalue(Ctx) == LV_Valid)
return MLV_LValueCast;
return MLV_InvalidExpression;
diff --git a/test/Sema/exprs.c b/test/Sema/exprs.c
index 9db8c92..617eaa0 100644
--- a/test/Sema/exprs.c
+++ b/test/Sema/exprs.c
@@ -34,6 +34,7 @@
// rdar://6319320
void test5(int *X, float *P) {
(float*)X = P; // expected-error {{assignment to cast is illegal, lvalue casts are not supported}}
+ ((float*)X) = P; // expected-error {{assignment to cast is illegal, lvalue casts are not supported}}
}
void test6() {