commit 962b790e1ba18bd99d084ae5470c4d6e88a80063
author Chris Lattner <sabre@nondot.org> Wed Aug 05 04:56:58 2009 +0000
committer Chris Lattner <sabre@nondot.org> Wed Aug 05 04:56:58 2009 +0000
tree ae3607a9d2bb31d74e46873e62bb334a2a4e0bf9
parent 01ca450a116fea2b6870d67be7ffb17f65ad29af

rdar://7119244 - globals with an explicit section specified don't get
common linkage.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@78158 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CodeGenModule.cpp

diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index 08dc993..95ce3e5 100644
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -883,7 +883,8 @@
   else if (D->hasAttr<WeakAttr>())
     GV->setLinkage(llvm::GlobalVariable::WeakAnyLinkage);
   else if (!CompileOpts.NoCommon &&
-           (!D->hasExternalStorage() && !D->getInit()))
+           !D->hasExternalStorage() && !D->getInit() &&
+           !D->getAttr<SectionAttr>())
     GV->setLinkage(llvm::GlobalVariable::CommonLinkage);
   else
     GV->setLinkage(llvm::GlobalVariable::ExternalLinkage);