commit a5e76935d79d84e3a00a2fbb47651799f5da7fef
author Ryan Flynn <pizza@parseerror.com> Sat Aug 08 19:18:23 2009 +0000
committer Ryan Flynn <pizza@parseerror.com> Sat Aug 08 19:18:23 2009 +0000
tree 08549650519022dd367971312f433d865c1f0c17
parent c915fa76c5429bbc235d8993dc218ad20bc26e3b

PR4700 - remove shift by 0 warning

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@78488 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp

diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index cec1aea..f00ab54 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -4136,16 +4136,7 @@
   llvm::APSInt Right;
   // Check right/shifter operand
   if (rex->isIntegerConstantExpr(Right, Context)) {
-    // Check left/shiftee operand
-    llvm::APSInt Left;
-    if (lex->isIntegerConstantExpr(Left, Context)) {
-      if (Left == 0 && Right != 0)
-        Diag(Loc, diag::warn_op_no_effect)
-          << lex->getSourceRange() << rex->getSourceRange();
-    }
-    if (isCompAssign && Right == 0)
-      Diag(Loc, diag::warn_op_no_effect) << rex->getSourceRange();
-    else if (Right.isNegative())
+    if (Right.isNegative())
       Diag(Loc, diag::warn_shift_negative) << rex->getSourceRange();
     else {
       llvm::APInt LeftBits(Right.getBitWidth(),