commit b349fccc4a6e416483b0b36b4f74e39787c62344
author Daniel Dunbar <daniel@zuster.org> Thu Mar 12 03:42:54 2009 +0000
committer Daniel Dunbar <daniel@zuster.org> Thu Mar 12 03:42:54 2009 +0000
tree 6d060e0040530530ba8e264a8c6d760757e7e1b8
parent d639b42fb139b67abd878364df8707a30029e7b3

Driver: Tweak option naming/def:
 - Use OPT_ prefix for ids.

 - Reference groups and aliases by shortend id (on the theory that
   this is more readable).

 - Rename the special option ids to more protected names.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@66767 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/OptTable.cpp

diff --git a/lib/Driver/OptTable.cpp b/lib/Driver/OptTable.cpp
index db910e1..5caaace 100644
--- a/lib/Driver/OptTable.cpp
+++ b/lib/Driver/OptTable.cpp
@@ -30,12 +30,12 @@
 
 static Info OptionInfos[] = {
   // The InputOption info
-  { "<input>", "", Option::InputClass, 0, 0, 0 },
+  { "<input>", "", Option::InputClass, OPT_INVALID, OPT_INVALID, 0 },
   // The UnknownOption info
-  { "<unknown>", "", Option::UnknownClass, 0, 0, 0 },
+  { "<unknown>", "", Option::UnknownClass, OPT_INVALID, OPT_INVALID, 0 },
   
-#define OPTION(NAME, ID, KIND, GROUP, ALIAS, FLAGS, PARAM) \
-  { NAME, FLAGS, Option::KIND##Class, GROUP, ALIAS, PARAM },
+#define OPTION(NAME, ID, KIND, GROUP, ALIAS, FLAGS, PARAM)              \
+  { NAME, FLAGS, Option::KIND##Class, OPT_##GROUP, OPT_##ALIAS, PARAM },
 #include "clang/Driver/Options.def"
 };
 static const unsigned numOptions = sizeof(OptionInfos) / sizeof(OptionInfos[0]);
@@ -63,7 +63,7 @@
 }
 
 const Option *OptTable::getOption(options::ID id) const {
-  if (id == NotOption)
+  if (id == OPT_INVALID)
     return 0;
 
   assert((unsigned) (id - 1) < numOptions && "Invalid ID.");
@@ -125,9 +125,9 @@
 
   // Anything that doesn't start with '-' is an input.
   if (Str[0] != '-')
-    return new PositionalArg(getOption(InputOpt), Index++);
+    return new PositionalArg(getOption(OPT_INPUT), Index++);
 
-  for (unsigned j = UnknownOpt + 1; j < LastOption; ++j) {
+  for (unsigned j = OPT_UNKNOWN + 1; j < LastOption; ++j) {
     const char *OptName = getOptionName((options::ID) j);
     
     // Arguments are only accepted by options which prefix them.
@@ -136,6 +136,6 @@
         return A;
   }
 
-  return new PositionalArg(getOption(UnknownOpt), Index++);
+  return new PositionalArg(getOption(OPT_UNKNOWN), Index++);
 }
 

lib/Driver/Option.cpp

diff --git a/lib/Driver/Option.cpp b/lib/Driver/Option.cpp
index 7a74d34..7a53009 100644
--- a/lib/Driver/Option.cpp
+++ b/lib/Driver/Option.cpp
@@ -113,7 +113,7 @@
 }
 
 InputOption::InputOption()
-  : Option(Option::InputClass, options::InputOpt, "<input>", 0, 0) {
+  : Option(Option::InputClass, options::OPT_INPUT, "<input>", 0, 0) {
 }
 
 Arg *InputOption::accept(const ArgList &Args, unsigned &Index) const {
@@ -122,7 +122,7 @@
 }
 
 UnknownOption::UnknownOption()
-  : Option(Option::UnknownClass, options::UnknownOpt, "<unknown>", 0, 0) {
+  : Option(Option::UnknownClass, options::OPT_UNKNOWN, "<unknown>", 0, 0) {
 }
 
 Arg *UnknownOption::accept(const ArgList &Args, unsigned &Index) const {