commit b6bead467640e4d05f6a0a90255eebc939f690a2
author Rafael Espindola <rafael.espindola@gmail.com> Fri Mar 29 07:02:31 2013 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Fri Mar 29 07:02:31 2013 +0000
tree 8cb3c0d0dae84b058e73ab63e30d834c43aa4a67
parent 1bfc28c48c1b86a05d2e07b403107ef3da5a0f8e

Don't special case one line extern "C" decls.

We already avoided warning for

extern "C" const char *Version_string = "2.9";

now we also don't produce any warnings for

extern "C" {
  extern const char *Version_string2 = "2.9";
}

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@178333 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDecl.cpp

diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index ab4a17a..1c6bbed 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -7565,6 +7565,7 @@
     }
   } else if (VDecl->isFileVarDecl()) {
     if (VDecl->getStorageClassAsWritten() == SC_Extern &&
+        !VDecl->isExternC() &&
         (!getLangOpts().CPlusPlus ||
          !Context.getBaseElementType(VDecl->getType()).isConstQualified()))
       Diag(VDecl->getLocation(), diag::warn_extern_init);