| //=-- GRExprEngineInternalChecks.cpp - Builtin GRExprEngine Checks---*- C++ -*-= |
| // |
| // The LLVM Compiler Infrastructure |
| // |
| // This file is distributed under the University of Illinois Open Source |
| // License. See LICENSE.TXT for details. |
| // |
| //===----------------------------------------------------------------------===// |
| // |
| // This file defines the BugType classes used by GRExprEngine to report |
| // bugs derived from builtin checks in the path-sensitive engine. |
| // |
| //===----------------------------------------------------------------------===// |
| |
| #include "clang/Analysis/PathSensitive/BugReporter.h" |
| #include "clang/Analysis/PathSensitive/GRExprEngine.h" |
| #include "clang/Analysis/PathSensitive/CheckerVisitor.h" |
| #include "clang/Analysis/PathSensitive/NullDerefChecker.h" |
| #include "clang/Analysis/PathDiagnostic.h" |
| #include "clang/Basic/SourceManager.h" |
| #include "llvm/Support/Compiler.h" |
| #include "llvm/Support/raw_ostream.h" |
| |
| using namespace clang; |
| using namespace clang::bugreporter; |
| |
| //===----------------------------------------------------------------------===// |
| // Utility functions. |
| //===----------------------------------------------------------------------===// |
| |
| template <typename ITERATOR> inline |
| ExplodedNode* GetNode(ITERATOR I) { |
| return *I; |
| } |
| |
| template <> inline |
| ExplodedNode* GetNode(GRExprEngine::undef_arg_iterator I) { |
| return I->first; |
| } |
| |
| //===----------------------------------------------------------------------===// |
| // Bug Descriptions. |
| //===----------------------------------------------------------------------===// |
| namespace clang { |
| class BuiltinBugReport : public RangedBugReport { |
| public: |
| BuiltinBugReport(BugType& bt, const char* desc, |
| ExplodedNode *n) |
| : RangedBugReport(bt, desc, n) {} |
| |
| BuiltinBugReport(BugType& bt, const char *shortDesc, const char *desc, |
| ExplodedNode *n) |
| : RangedBugReport(bt, shortDesc, desc, n) {} |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N); |
| }; |
| |
| void BuiltinBugReport::registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N) { |
| static_cast<BuiltinBug&>(getBugType()).registerInitialVisitors(BRC, N, this); |
| } |
| |
| template <typename ITER> |
| void BuiltinBug::Emit(BugReporter& BR, ITER I, ITER E) { |
| for (; I != E; ++I) BR.EmitReport(new BuiltinBugReport(*this, desc.c_str(), |
| GetNode(I))); |
| } |
| |
| class VISIBILITY_HIDDEN NilReceiverStructRet : public BuiltinBug { |
| public: |
| NilReceiverStructRet(GRExprEngine* eng) : |
| BuiltinBug(eng, "'nil' receiver with struct return type") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::nil_receiver_struct_ret_iterator |
| I=Eng.nil_receiver_struct_ret_begin(), |
| E=Eng.nil_receiver_struct_ret_end(); I!=E; ++I) { |
| |
| std::string sbuf; |
| llvm::raw_string_ostream os(sbuf); |
| PostStmt P = cast<PostStmt>((*I)->getLocation()); |
| const ObjCMessageExpr *ME = cast<ObjCMessageExpr>(P.getStmt()); |
| os << "The receiver in the message expression is 'nil' and results in the" |
| " returned value (of type '" |
| << ME->getType().getAsString() |
| << "') to be garbage or otherwise undefined"; |
| |
| BuiltinBugReport *R = new BuiltinBugReport(*this, os.str().c_str(), *I); |
| R->addRange(ME->getReceiver()->getSourceRange()); |
| BR.EmitReport(R); |
| } |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetReceiverExpr(N), N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN NilReceiverLargerThanVoidPtrRet : public BuiltinBug { |
| public: |
| NilReceiverLargerThanVoidPtrRet(GRExprEngine* eng) : |
| BuiltinBug(eng, |
| "'nil' receiver with return type larger than sizeof(void *)") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::nil_receiver_larger_than_voidptr_ret_iterator |
| I=Eng.nil_receiver_larger_than_voidptr_ret_begin(), |
| E=Eng.nil_receiver_larger_than_voidptr_ret_end(); I!=E; ++I) { |
| |
| std::string sbuf; |
| llvm::raw_string_ostream os(sbuf); |
| PostStmt P = cast<PostStmt>((*I)->getLocation()); |
| const ObjCMessageExpr *ME = cast<ObjCMessageExpr>(P.getStmt()); |
| os << "The receiver in the message expression is 'nil' and results in the" |
| " returned value (of type '" |
| << ME->getType().getAsString() |
| << "' and of size " |
| << Eng.getContext().getTypeSize(ME->getType()) / 8 |
| << " bytes) to be garbage or otherwise undefined"; |
| |
| BuiltinBugReport *R = new BuiltinBugReport(*this, os.str().c_str(), *I); |
| R->addRange(ME->getReceiver()->getSourceRange()); |
| BR.EmitReport(R); |
| } |
| } |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetReceiverExpr(N), N); |
| } |
| }; |
| |
| |
| |
| class VISIBILITY_HIDDEN UndefinedDeref : public BuiltinBug { |
| public: |
| UndefinedDeref() |
| : BuiltinBug(0, "Dereference of undefined pointer value") {} |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetDerefExpr(N), N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN DivZero : public BuiltinBug { |
| public: |
| DivZero(GRExprEngine* eng = 0) |
| : BuiltinBug(eng,"Division by zero") {} |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetDenomExpr(N), N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN UndefResult : public BuiltinBug { |
| public: |
| UndefResult(GRExprEngine* eng) |
| : BuiltinBug(eng,"Undefined or garbage result", |
| "Result of operation is garbage or undefined") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::undef_result_iterator I=Eng.undef_results_begin(), |
| E = Eng.undef_results_end(); I!=E; ++I) { |
| |
| ExplodedNode *N = *I; |
| const Stmt *S = N->getLocationAs<PostStmt>()->getStmt(); |
| BuiltinBugReport *report = NULL; |
| |
| if (const BinaryOperator *B = dyn_cast<BinaryOperator>(S)) { |
| llvm::SmallString<256> sbuf; |
| llvm::raw_svector_ostream OS(sbuf); |
| const GRState *ST = N->getState(); |
| const Expr *Ex = NULL; |
| bool isLeft = true; |
| |
| if (ST->getSVal(B->getLHS()).isUndef()) { |
| Ex = B->getLHS()->IgnoreParenCasts(); |
| isLeft = true; |
| } |
| else if (ST->getSVal(B->getRHS()).isUndef()) { |
| Ex = B->getRHS()->IgnoreParenCasts(); |
| isLeft = false; |
| } |
| |
| if (Ex) { |
| OS << "The " << (isLeft ? "left" : "right") |
| << " operand of '" |
| << BinaryOperator::getOpcodeStr(B->getOpcode()) |
| << "' is a garbage value"; |
| } |
| else { |
| // Neither operand was undefined, but the result is undefined. |
| OS << "The result of the '" |
| << BinaryOperator::getOpcodeStr(B->getOpcode()) |
| << "' expression is undefined"; |
| } |
| |
| // FIXME: Use StringRefs to pass string information. |
| report = new BuiltinBugReport(*this, OS.str().str().c_str(), N); |
| if (Ex) report->addRange(Ex->getSourceRange()); |
| } |
| else { |
| report = new BuiltinBugReport(*this, |
| "Expression evaluates to an uninitialized" |
| " or undefined value", N); |
| } |
| |
| BR.EmitReport(report); |
| } |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| |
| const Stmt *S = N->getLocationAs<StmtPoint>()->getStmt(); |
| const Stmt *X = S; |
| |
| if (const BinaryOperator *B = dyn_cast<BinaryOperator>(S)) { |
| const GRState *ST = N->getState(); |
| if (ST->getSVal(B->getLHS()).isUndef()) |
| X = B->getLHS(); |
| else if (ST->getSVal(B->getRHS()).isUndef()) |
| X = B->getRHS(); |
| } |
| |
| registerTrackNullOrUndefValue(BRC, X, N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN BadCall : public BuiltinBug { |
| public: |
| BadCall(GRExprEngine *eng = 0) |
| : BuiltinBug(eng, "Invalid function call", |
| "Called function pointer is a null or undefined pointer value") {} |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetCalleeExpr(N), N); |
| } |
| }; |
| |
| |
| class VISIBILITY_HIDDEN ArgReport : public BuiltinBugReport { |
| const Stmt *Arg; |
| public: |
| ArgReport(BugType& bt, const char* desc, ExplodedNode *n, |
| const Stmt *arg) |
| : BuiltinBugReport(bt, desc, n), Arg(arg) {} |
| |
| ArgReport(BugType& bt, const char *shortDesc, const char *desc, |
| ExplodedNode *n, const Stmt *arg) |
| : BuiltinBugReport(bt, shortDesc, desc, n), Arg(arg) {} |
| |
| const Stmt *getArg() const { return Arg; } |
| }; |
| |
| class VISIBILITY_HIDDEN BadArg : public BuiltinBug { |
| public: |
| BadArg(GRExprEngine* eng=0) : BuiltinBug(eng,"Uninitialized argument", |
| "Pass-by-value argument in function call is undefined") {} |
| |
| BadArg(GRExprEngine* eng, const char* d) |
| : BuiltinBug(eng,"Uninitialized argument", d) {} |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, static_cast<ArgReport*>(R)->getArg(), |
| N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN BadMsgExprArg : public BadArg { |
| public: |
| BadMsgExprArg(GRExprEngine* eng) |
| : BadArg(eng,"Pass-by-value argument in message expression is undefined"){} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::UndefArgsTy::iterator I=Eng.msg_expr_undef_arg_begin(), |
| E = Eng.msg_expr_undef_arg_end(); I!=E; ++I) { |
| // Generate a report for this bug. |
| ArgReport *report = new ArgReport(*this, desc.c_str(), I->first, |
| I->second); |
| report->addRange(I->second->getSourceRange()); |
| BR.EmitReport(report); |
| } |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN BadReceiver : public BuiltinBug { |
| public: |
| BadReceiver(GRExprEngine* eng) |
| : BuiltinBug(eng,"Uninitialized receiver", |
| "Receiver in message expression is an uninitialized value") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::ErrorNodes::iterator I=Eng.undef_receivers_begin(), |
| End = Eng.undef_receivers_end(); I!=End; ++I) { |
| |
| // Generate a report for this bug. |
| BuiltinBugReport *report = new BuiltinBugReport(*this, desc.c_str(), *I); |
| ExplodedNode* N = *I; |
| const Stmt *S = cast<PostStmt>(N->getLocation()).getStmt(); |
| const Expr* E = cast<ObjCMessageExpr>(S)->getReceiver(); |
| assert (E && "Receiver cannot be NULL"); |
| report->addRange(E->getSourceRange()); |
| BR.EmitReport(report); |
| } |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetReceiverExpr(N), N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN RetStack : public BuiltinBug { |
| public: |
| RetStack(GRExprEngine* eng) |
| : BuiltinBug(eng, "Return of address to stack-allocated memory") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::ret_stackaddr_iterator I=Eng.ret_stackaddr_begin(), |
| End = Eng.ret_stackaddr_end(); I!=End; ++I) { |
| |
| ExplodedNode* N = *I; |
| const Stmt *S = cast<PostStmt>(N->getLocation()).getStmt(); |
| const Expr* E = cast<ReturnStmt>(S)->getRetValue(); |
| assert(E && "Return expression cannot be NULL"); |
| |
| // Get the value associated with E. |
| loc::MemRegionVal V = cast<loc::MemRegionVal>(N->getState()->getSVal(E)); |
| |
| // Generate a report for this bug. |
| std::string buf; |
| llvm::raw_string_ostream os(buf); |
| SourceRange R; |
| |
| // Check if the region is a compound literal. |
| if (const CompoundLiteralRegion* CR = |
| dyn_cast<CompoundLiteralRegion>(V.getRegion())) { |
| |
| const CompoundLiteralExpr* CL = CR->getLiteralExpr(); |
| os << "Address of stack memory associated with a compound literal " |
| "declared on line " |
| << BR.getSourceManager() |
| .getInstantiationLineNumber(CL->getLocStart()) |
| << " returned."; |
| |
| R = CL->getSourceRange(); |
| } |
| else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(V.getRegion())) { |
| const Expr* ARE = AR->getExpr(); |
| SourceLocation L = ARE->getLocStart(); |
| R = ARE->getSourceRange(); |
| |
| os << "Address of stack memory allocated by call to alloca() on line " |
| << BR.getSourceManager().getInstantiationLineNumber(L) |
| << " returned."; |
| } |
| else { |
| os << "Address of stack memory associated with local variable '" |
| << V.getRegion()->getString() << "' returned."; |
| } |
| |
| RangedBugReport *report = new RangedBugReport(*this, os.str().c_str(), N); |
| report->addRange(E->getSourceRange()); |
| if (R.isValid()) report->addRange(R); |
| BR.EmitReport(report); |
| } |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN RetUndef : public BuiltinBug { |
| public: |
| RetUndef(GRExprEngine* eng) : BuiltinBug(eng, "Garbage return value", |
| "Undefined or garbage value returned to caller") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| Emit(BR, Eng.ret_undef_begin(), Eng.ret_undef_end()); |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, GetRetValExpr(N), N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN UndefBranch : public BuiltinBug { |
| struct VISIBILITY_HIDDEN FindUndefExpr { |
| GRStateManager& VM; |
| const GRState* St; |
| |
| FindUndefExpr(GRStateManager& V, const GRState* S) : VM(V), St(S) {} |
| |
| Expr* FindExpr(Expr* Ex) { |
| if (!MatchesCriteria(Ex)) |
| return 0; |
| |
| for (Stmt::child_iterator I=Ex->child_begin(), E=Ex->child_end();I!=E;++I) |
| if (Expr* ExI = dyn_cast_or_null<Expr>(*I)) { |
| Expr* E2 = FindExpr(ExI); |
| if (E2) return E2; |
| } |
| |
| return Ex; |
| } |
| |
| bool MatchesCriteria(Expr* Ex) { return St->getSVal(Ex).isUndef(); } |
| }; |
| |
| public: |
| UndefBranch(GRExprEngine *eng) |
| : BuiltinBug(eng,"Use of garbage value", |
| "Branch condition evaluates to an undefined or garbage value") |
| {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::undef_branch_iterator I=Eng.undef_branches_begin(), |
| E=Eng.undef_branches_end(); I!=E; ++I) { |
| |
| // What's going on here: we want to highlight the subexpression of the |
| // condition that is the most likely source of the "uninitialized |
| // branch condition." We do a recursive walk of the condition's |
| // subexpressions and roughly look for the most nested subexpression |
| // that binds to Undefined. We then highlight that expression's range. |
| BlockEdge B = cast<BlockEdge>((*I)->getLocation()); |
| Expr* Ex = cast<Expr>(B.getSrc()->getTerminatorCondition()); |
| assert (Ex && "Block must have a terminator."); |
| |
| // Get the predecessor node and check if is a PostStmt with the Stmt |
| // being the terminator condition. We want to inspect the state |
| // of that node instead because it will contain main information about |
| // the subexpressions. |
| assert (!(*I)->pred_empty()); |
| |
| // Note: any predecessor will do. They should have identical state, |
| // since all the BlockEdge did was act as an error sink since the value |
| // had to already be undefined. |
| ExplodedNode *N = *(*I)->pred_begin(); |
| ProgramPoint P = N->getLocation(); |
| const GRState* St = (*I)->getState(); |
| |
| if (PostStmt* PS = dyn_cast<PostStmt>(&P)) |
| if (PS->getStmt() == Ex) |
| St = N->getState(); |
| |
| FindUndefExpr FindIt(Eng.getStateManager(), St); |
| Ex = FindIt.FindExpr(Ex); |
| |
| ArgReport *R = new ArgReport(*this, desc.c_str(), *I, Ex); |
| R->addRange(Ex->getSourceRange()); |
| BR.EmitReport(R); |
| } |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, static_cast<ArgReport*>(R)->getArg(), |
| N); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN OutOfBoundMemoryAccess : public BuiltinBug { |
| public: |
| OutOfBoundMemoryAccess(GRExprEngine* eng) |
| : BuiltinBug(eng,"Out-of-bounds memory access", |
| "Load or store into an out-of-bound memory position.") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| Emit(BR, Eng.explicit_oob_memacc_begin(), Eng.explicit_oob_memacc_end()); |
| } |
| }; |
| |
| class VISIBILITY_HIDDEN BadSizeVLA : public BuiltinBug { |
| public: |
| BadSizeVLA(GRExprEngine* eng) : |
| BuiltinBug(eng, "Bad variable-length array (VLA) size") {} |
| |
| void FlushReportsImpl(BugReporter& BR, GRExprEngine& Eng) { |
| for (GRExprEngine::ErrorNodes::iterator |
| I = Eng.ExplicitBadSizedVLA.begin(), |
| E = Eng.ExplicitBadSizedVLA.end(); I!=E; ++I) { |
| |
| // Determine whether this was a 'zero-sized' VLA or a VLA with an |
| // undefined size. |
| ExplodedNode* N = *I; |
| PostStmt PS = cast<PostStmt>(N->getLocation()); |
| const DeclStmt *DS = cast<DeclStmt>(PS.getStmt()); |
| VarDecl* VD = cast<VarDecl>(*DS->decl_begin()); |
| QualType T = Eng.getContext().getCanonicalType(VD->getType()); |
| VariableArrayType* VT = cast<VariableArrayType>(T); |
| Expr* SizeExpr = VT->getSizeExpr(); |
| |
| std::string buf; |
| llvm::raw_string_ostream os(buf); |
| os << "The expression used to specify the number of elements in the " |
| "variable-length array (VLA) '" |
| << VD->getNameAsString() << "' evaluates to "; |
| |
| bool isUndefined = N->getState()->getSVal(SizeExpr).isUndef(); |
| |
| if (isUndefined) |
| os << "an undefined or garbage value."; |
| else |
| os << "0. VLAs with no elements have undefined behavior."; |
| |
| std::string shortBuf; |
| llvm::raw_string_ostream os_short(shortBuf); |
| os_short << "Variable-length array '" << VD->getNameAsString() << "' " |
| << (isUndefined ? "garbage value for array size" |
| : "has zero elements (undefined behavior)"); |
| |
| ArgReport *report = new ArgReport(*this, os_short.str().c_str(), |
| os.str().c_str(), N, SizeExpr); |
| |
| report->addRange(SizeExpr->getSourceRange()); |
| BR.EmitReport(report); |
| } |
| } |
| |
| void registerInitialVisitors(BugReporterContext& BRC, |
| const ExplodedNode* N, |
| BuiltinBugReport *R) { |
| registerTrackNullOrUndefValue(BRC, static_cast<ArgReport*>(R)->getArg(), |
| N); |
| } |
| }; |
| |
| //===----------------------------------------------------------------------===// |
| // __attribute__(nonnull) checking |
| |
| class VISIBILITY_HIDDEN CheckAttrNonNull : |
| public CheckerVisitor<CheckAttrNonNull> { |
| |
| BugType *BT; |
| |
| public: |
| CheckAttrNonNull() : BT(0) {} |
| ~CheckAttrNonNull() {} |
| |
| static void *getTag() { |
| static int x = 0; |
| return &x; |
| } |
| |
| void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE) { |
| const GRState *state = C.getState(); |
| const GRState *originalState = state; |
| |
| // Check if the callee has a 'nonnull' attribute. |
| SVal X = state->getSVal(CE->getCallee()); |
| |
| const FunctionDecl* FD = X.getAsFunctionDecl(); |
| if (!FD) |
| return; |
| |
| const NonNullAttr* Att = FD->getAttr<NonNullAttr>(); |
| if (!Att) |
| return; |
| |
| // Iterate through the arguments of CE and check them for null. |
| unsigned idx = 0; |
| |
| for (CallExpr::const_arg_iterator I=CE->arg_begin(), E=CE->arg_end(); I!=E; |
| ++I, ++idx) { |
| |
| if (!Att->isNonNull(idx)) |
| continue; |
| |
| const SVal &V = state->getSVal(*I); |
| const DefinedSVal *DV = dyn_cast<DefinedSVal>(&V); |
| |
| if (!DV) |
| continue; |
| |
| ConstraintManager &CM = C.getConstraintManager(); |
| const GRState *stateNotNull, *stateNull; |
| llvm::tie(stateNotNull, stateNull) = CM.AssumeDual(state, *DV); |
| |
| if (stateNull && !stateNotNull) { |
| // Generate an error node. Check for a null node in case |
| // we cache out. |
| if (ExplodedNode *errorNode = C.GenerateNode(CE, stateNull, true)) { |
| |
| // Lazily allocate the BugType object if it hasn't already been |
| // created. Ownership is transferred to the BugReporter object once |
| // the BugReport is passed to 'EmitWarning'. |
| if (!BT) |
| BT = new BugType("Argument with 'nonnull' attribute passed null", |
| "API"); |
| |
| EnhancedBugReport *R = |
| new EnhancedBugReport(*BT, |
| "Null pointer passed as an argument to a " |
| "'nonnull' parameter", errorNode); |
| |
| // Highlight the range of the argument that was null. |
| const Expr *arg = *I; |
| R->addRange(arg->getSourceRange()); |
| R->addVisitorCreator(registerTrackNullOrUndefValue, arg); |
| |
| // Emit the bug report. |
| C.EmitReport(R); |
| } |
| |
| // Always return. Either we cached out or we just emitted an error. |
| return; |
| } |
| |
| // If a pointer value passed the check we should assume that it is |
| // indeed not null from this point forward. |
| assert(stateNotNull); |
| state = stateNotNull; |
| } |
| |
| // If we reach here all of the arguments passed the nonnull check. |
| // If 'state' has been updated generated a new node. |
| if (state != originalState) |
| C.addTransition(C.GenerateNode(CE, state)); |
| } |
| }; |
| |
| // Undefined arguments checking. |
| |
| class VISIBILITY_HIDDEN CheckUndefinedArg |
| : public CheckerVisitor<CheckUndefinedArg> { |
| |
| BadArg *BT; |
| |
| public: |
| CheckUndefinedArg() : BT(0) {} |
| ~CheckUndefinedArg() {} |
| |
| static void *getTag() { |
| static int x = 0; |
| return &x; |
| } |
| |
| void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE); |
| }; |
| |
| void CheckUndefinedArg::PreVisitCallExpr(CheckerContext &C, const CallExpr *CE){ |
| for (CallExpr::const_arg_iterator I = CE->arg_begin(), E = CE->arg_end(); |
| I != E; ++I) { |
| if (C.getState()->getSVal(*I).isUndef()) { |
| if (ExplodedNode *ErrorNode = C.GenerateNode(CE, true)) { |
| if (!BT) |
| BT = new BadArg(); |
| // Generate a report for this bug. |
| ArgReport *Report = new ArgReport(*BT, BT->getDescription().c_str(), |
| ErrorNode, *I); |
| Report->addRange((*I)->getSourceRange()); |
| C.EmitReport(Report); |
| } |
| } |
| } |
| } |
| |
| class VISIBILITY_HIDDEN CheckBadCall : public CheckerVisitor<CheckBadCall> { |
| BadCall *BT; |
| |
| public: |
| CheckBadCall() : BT(0) {} |
| ~CheckBadCall() {} |
| |
| static void *getTag() { |
| static int x = 0; |
| return &x; |
| } |
| |
| void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE); |
| }; |
| |
| void CheckBadCall::PreVisitCallExpr(CheckerContext &C, const CallExpr *CE) { |
| const Expr *Callee = CE->getCallee()->IgnoreParens(); |
| SVal L = C.getState()->getSVal(Callee); |
| |
| if (L.isUndef() || isa<loc::ConcreteInt>(L)) { |
| if (ExplodedNode *N = C.GenerateNode(CE, true)) { |
| if (!BT) |
| BT = new BadCall(); |
| C.EmitReport(new BuiltinBugReport(*BT, BT->getDescription().c_str(), N)); |
| } |
| } |
| } |
| |
| class VISIBILITY_HIDDEN CheckDivZero : public CheckerVisitor<CheckDivZero> { |
| DivZero *BT; |
| public: |
| CheckDivZero() : BT(0) {} |
| ~CheckDivZero() {} |
| |
| static void *getTag() { |
| static int x; |
| return &x; |
| } |
| |
| void PreVisitBinaryOperator(CheckerContext &C, const BinaryOperator *B); |
| }; |
| |
| void CheckDivZero::PreVisitBinaryOperator(CheckerContext &C, |
| const BinaryOperator *B) { |
| BinaryOperator::Opcode Op = B->getOpcode(); |
| if (Op != BinaryOperator::Div && |
| Op != BinaryOperator::Rem && |
| Op != BinaryOperator::DivAssign && |
| Op != BinaryOperator::RemAssign) |
| return; |
| |
| if (!B->getRHS()->getType()->isIntegerType() || |
| !B->getRHS()->getType()->isScalarType()) |
| return; |
| |
| SVal Denom = C.getState()->getSVal(B->getRHS()); |
| const DefinedSVal *DV = dyn_cast<DefinedSVal>(&Denom); |
| |
| // Divide-by-undefined handled in the generic checking for uses of |
| // undefined values. |
| if (!DV) |
| return; |
| |
| // Check for divide by zero. |
| ConstraintManager &CM = C.getConstraintManager(); |
| const GRState *stateNotZero, *stateZero; |
| llvm::tie(stateNotZero, stateZero) = CM.AssumeDual(C.getState(), *DV); |
| |
| if (stateZero && !stateNotZero) { |
| if (ExplodedNode *N = C.GenerateNode(B, stateZero, true)) { |
| if (!BT) |
| BT = new DivZero(); |
| |
| C.EmitReport(new BuiltinBugReport(*BT, BT->getDescription().c_str(), N)); |
| } |
| return; |
| } |
| |
| // If we get here, then the denom should not be zero. We abandon the implicit |
| // zero denom case for now. |
| if (stateNotZero != C.getState()) |
| C.addTransition(C.GenerateNode(B, stateNotZero)); |
| } |
| |
| class VISIBILITY_HIDDEN CheckUndefDeref : public Checker { |
| UndefinedDeref *BT; |
| public: |
| CheckUndefDeref() : BT(0) {} |
| |
| ExplodedNode *CheckLocation(const Stmt *S, ExplodedNode *Pred, |
| const GRState *state, SVal V, GRExprEngine &Eng); |
| |
| static void *getTag() { |
| static int x = 0; |
| return &x; |
| } |
| }; |
| |
| ExplodedNode *CheckUndefDeref::CheckLocation(const Stmt *S, ExplodedNode *Pred, |
| const GRState *state, SVal V, |
| GRExprEngine &Eng) { |
| GRStmtNodeBuilder &Builder = Eng.getBuilder(); |
| BugReporter &BR = Eng.getBugReporter(); |
| |
| if (V.isUndef()) { |
| ExplodedNode *N = Builder.generateNode(S, state, Pred, |
| ProgramPoint::PostUndefLocationCheckFailedKind); |
| if (N) { |
| if (!BT) |
| BT = new UndefinedDeref(); |
| |
| N->markAsSink(); |
| BR.EmitReport(new BuiltinBugReport(*BT, BT->getDescription().c_str(), N)); |
| } |
| return 0; |
| } |
| |
| return Pred; |
| } |
| |
| } // end clang namespace |
| |
| //===----------------------------------------------------------------------===// |
| // Check registration. |
| //===----------------------------------------------------------------------===// |
| |
| void GRExprEngine::RegisterInternalChecks() { |
| // Register internal "built-in" BugTypes with the BugReporter. These BugTypes |
| // are different than what probably many checks will do since they don't |
| // create BugReports on-the-fly but instead wait until GRExprEngine finishes |
| // analyzing a function. Generation of BugReport objects is done via a call |
| // to 'FlushReports' from BugReporter. |
| BR.Register(new UndefBranch(this)); |
| BR.Register(new UndefResult(this)); |
| BR.Register(new RetStack(this)); |
| BR.Register(new RetUndef(this)); |
| BR.Register(new BadMsgExprArg(this)); |
| BR.Register(new BadReceiver(this)); |
| BR.Register(new OutOfBoundMemoryAccess(this)); |
| BR.Register(new BadSizeVLA(this)); |
| BR.Register(new NilReceiverStructRet(this)); |
| BR.Register(new NilReceiverLargerThanVoidPtrRet(this)); |
| |
| // The following checks do not need to have their associated BugTypes |
| // explicitly registered with the BugReporter. If they issue any BugReports, |
| // their associated BugType will get registered with the BugReporter |
| // automatically. Note that the check itself is owned by the GRExprEngine |
| // object. |
| registerCheck<CheckAttrNonNull>(new CheckAttrNonNull()); |
| registerCheck<CheckUndefinedArg>(new CheckUndefinedArg()); |
| registerCheck<CheckBadCall>(new CheckBadCall()); |
| registerCheck<CheckDivZero>(new CheckDivZero()); |
| registerCheck<CheckUndefDeref>(new CheckUndefDeref()); |
| registerCheck<NullDerefChecker>(new NullDerefChecker()); |
| } |