Switch BasicStoreManager to use the new CastRegion implementation by default,
and replace the 'clang-cc' option '-analyzer-store=basic-new-cast' with
'-analyzer-store=basic-old-cast'. We'll keep the old CastRegion implementation
around for a little while for regression testing.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@75209 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Analysis/BasicStore.cpp b/lib/Analysis/BasicStore.cpp
index c897b2f..ba1ccf1 100644
--- a/lib/Analysis/BasicStore.cpp
+++ b/lib/Analysis/BasicStore.cpp
@@ -38,7 +38,7 @@
   const MemRegion* SelfRegion;
   
 public:
-  BasicStoreManager(GRStateManager& mgr, bool useNewCastRegion = false)
+  BasicStoreManager(GRStateManager& mgr, bool useNewCastRegion = true)
     : StoreManager(mgr, useNewCastRegion),
       VBFactory(mgr.getAllocator()), 
       SelfRegion(0) {}
@@ -126,8 +126,8 @@
   return new BasicStoreManager(StMgr);
 }
 
-StoreManager* clang::CreateBasicStoreNewCastManager(GRStateManager& StMgr) {
-  return new BasicStoreManager(StMgr, true);
+StoreManager* clang::CreateBasicStoreOldCastManager(GRStateManager& StMgr) {
+  return new BasicStoreManager(StMgr, false);
 }
 
 SVal BasicStoreManager::getLValueVar(const GRState *state, const VarDecl* VD) {