When using -analyzer-output-plist always output a plist file even if it contains no error reports.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@62871 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/Driver/Analyses.def b/Driver/Analyses.def
index 1f702cc..3beaa73 100644
--- a/Driver/Analyses.def
+++ b/Driver/Analyses.def
@@ -56,11 +56,11 @@
 ANALYSIS_STORE(RegionStore, "region", "Use region-based analyzer store")
 
 #ifndef ANALYSIS_DIAGNOSTICS
-#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATEFN)
+#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATEFN, AUTOCREATE)
 #endif
 
-ANALYSIS_DIAGNOSTICS(HTML,  "html",  "Output analysis results using HTML",   CreateHTMLDiagnosticClient)
-ANALYSIS_DIAGNOSTICS(PLIST, "plist", "Output analysis results using Plists", CreatePlistDiagnosticClient)
+ANALYSIS_DIAGNOSTICS(HTML,  "html",  "Output analysis results using HTML",   CreateHTMLDiagnosticClient, false)
+ANALYSIS_DIAGNOSTICS(PLIST, "plist", "Output analysis results using Plists", CreatePlistDiagnosticClient, true)
 
 #undef ANALYSIS
 #undef ANALYSIS_STORE
diff --git a/Driver/AnalysisConsumer.cpp b/Driver/AnalysisConsumer.cpp
index 1ada515..236cc1d 100644
--- a/Driver/AnalysisConsumer.cpp
+++ b/Driver/AnalysisConsumer.cpp
@@ -207,7 +207,7 @@
       if (C.PD.get() == 0 && !C.HTMLDir.empty()) {
         switch (C.DC) {
           default:
-#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATEFN)\
+#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATEFN, AUTOCREATE)\
 case PD_##NAME: C.PD.reset(CREATEFN(C.HTMLDir, C.PP, C.PPF)); break;
 #include "Analyses.def"
         }
@@ -288,6 +288,15 @@
         CreateConstraintMgr = ManagerRegistry::ConstraintMgrCreator;
       else
         CreateConstraintMgr = CreateBasicConstraintManager;
+      
+      // Some DiagnosticClients should be created all the time instead of
+      // lazily.  Create those now.
+      switch (C.DC) {
+        default: break;
+#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATEFN, AUTOCREATE)\
+case PD_##NAME: if (AUTOCREATE) getPathDiagnosticClient(); break;
+#include "Analyses.def"
+      }      
     }
 
   };
diff --git a/Driver/AnalysisConsumer.h b/Driver/AnalysisConsumer.h
index 27c8e6e..1e08240 100644
--- a/Driver/AnalysisConsumer.h
+++ b/Driver/AnalysisConsumer.h
@@ -29,7 +29,7 @@
 };
   
 enum AnalysisDiagClients {
-#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATFN) PD_##NAME,
+#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATFN, AUTOCREAT) PD_##NAME,
 #include "Analyses.def"
 NUM_ANALYSIS_DIAG_CLIENTS
 };
diff --git a/Driver/clang.cpp b/Driver/clang.cpp
index cf58f34..cc3788b 100644
--- a/Driver/clang.cpp
+++ b/Driver/clang.cpp
@@ -239,7 +239,7 @@
 AnalysisDiagOpt(llvm::cl::desc("SCA Output Options:"),
                 llvm::cl::init(PD_HTML),
                 llvm::cl::values(
-#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATFN)\
+#define ANALYSIS_DIAGNOSTICS(NAME, CMDFLAG, DESC, CREATFN, AUTOCREATE)\
 clEnumValN(PD_##NAME, "analyzer-output-" CMDFLAG, DESC),
 #include "Analyses.def"
 clEnumValEnd));