commit d02e232c43b979758810794de24d3f5cde40fe93
author Benjamin Kramer <benny.kra@googlemail.com> Sat Nov 14 12:08:24 2009 +0000
committer Benjamin Kramer <benny.kra@googlemail.com> Sat Nov 14 12:08:24 2009 +0000
tree 32a20b050ba1a7c26828bde07df0f8d8bd7355eb
parent 4fdba99ccce46d577ea1bcd5081843ef95ff5c11

Change *BugReport constructors to take StringRefs.

- Eliminates many calls to std::string.c_str()
- Fixes an invalid read in ReturnStackAddressChecker due to an unsafe call to
  StringRef.data() which doesn't guarantee null-termination.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@88779 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/DivZeroChecker.cpp

diff --git a/lib/Analysis/DivZeroChecker.cpp b/lib/Analysis/DivZeroChecker.cpp
index 5f949fd..a8630f1 100644
--- a/lib/Analysis/DivZeroChecker.cpp
+++ b/lib/Analysis/DivZeroChecker.cpp
@@ -68,7 +68,7 @@
         BT = new BuiltinBug("Division by zero");
 
       EnhancedBugReport *R = 
-        new EnhancedBugReport(*BT, BT->getDescription().c_str(), N);
+        new EnhancedBugReport(*BT, BT->getDescription(), N);
 
       R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue,
                            bugreporter::GetDenomExpr(N));