commit df8b8ea3492a314488ffee72704665b22bc73989
author Fariborz Jahanian <fjahanian@apple.com> Fri Jun 04 16:10:00 2010 +0000
committer Fariborz Jahanian <fjahanian@apple.com> Fri Jun 04 16:10:00 2010 +0000
tree 00186c63fcc5b1f797766a960ab0b48d933bc44f
parent e7d6c2cae6a9b9985db02cfc8bb4e7b714630ed5

For C++ copied in objects, use copy constructors in
setting up block's descriptor. This is on going work to
support c++ specific issues in setting up blocks
various APIs.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@105469 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGBlocks.cpp

diff --git a/lib/CodeGen/CGBlocks.cpp b/lib/CodeGen/CGBlocks.cpp
index 850c77c..5a3e100 100644
--- a/lib/CodeGen/CGBlocks.cpp
+++ b/lib/CodeGen/CGBlocks.cpp
@@ -364,11 +364,28 @@
           E = new (getContext()) DeclRefExpr(const_cast<ValueDecl*>(VD),
                                             VD->getType().getNonReferenceType(),
                                             SourceLocation());
-          if (VD->getType()->isReferenceType())
-            E = new (getContext())
-              UnaryOperator(const_cast<Expr*>(E), UnaryOperator::AddrOf,
-                          getContext().getPointerType(E->getType()),
-                          SourceLocation());
+          if (getContext().getLangOptions().CPlusPlus) {
+            if (VD->getType()->isReferenceType()) {
+              E = new (getContext())
+                UnaryOperator(const_cast<Expr*>(E), UnaryOperator::AddrOf,
+                              getContext().getPointerType(E->getType()),
+                              SourceLocation());
+            } 
+            else {
+              QualType T = E->getType();
+              if (const RecordType *RT = T->getAs<RecordType>()) {
+                CXXRecordDecl *Record = cast<CXXRecordDecl>(RT->getDecl());
+                if (!Record->hasTrivialCopyConstructor()) {
+                  CXXConstructorDecl *D = Record->getCopyConstructor(getContext(),
+                                                                     0);
+                  Expr *Arg = const_cast<Expr*>(E);
+                  E = CXXConstructExpr::Create(getContext(), T, D->getLocation(), 
+                                               D, false, &Arg, 1, false,
+                                               CXXConstructExpr::CK_Complete);
+                }
+              }
+            }
+          }
         }
       }
 
@@ -607,6 +624,10 @@
 
 llvm::Value *CodeGenFunction::GetAddrOfBlockDecl(const ValueDecl *VD,
                                                  bool IsByRef) {
+  llvm::Value *&VE = BlockDeclsValue[VD];
+  if (VE)
+    return VE;
+  
   CharUnits offset = BlockDecls[VD];
   assert(!offset.isZero() && "getting address of unallocated decl");
 
@@ -634,12 +655,12 @@
       V = Builder.CreateLoad(V);
   } else {
     const llvm::Type *Ty = CGM.getTypes().ConvertType(VD->getType());
-
     Ty = llvm::PointerType::get(Ty, 0);
     V = Builder.CreateBitCast(V, Ty);
     if (VD->getType()->isReferenceType())
-      V = Builder.CreateLoad(V, "tmp");
+      V = Builder.CreateLoad(V, "ref.tmp");
   }
+  VE = V;
   return V;
 }
 

lib/CodeGen/CGBlocks.h

diff --git a/lib/CodeGen/CGBlocks.h b/lib/CodeGen/CGBlocks.h
index e9b2bd5..4d92201 100644
--- a/lib/CodeGen/CGBlocks.h
+++ b/lib/CodeGen/CGBlocks.h
@@ -180,6 +180,9 @@
 
   /// BlockDecls - Offsets for all Decls in BlockDeclRefExprs.
   llvm::DenseMap<const Decl*, CharUnits> BlockDecls;
+  
+  /// BlockDeclsValue - llvm::Value for all Decls in BlockDeclRefExprs.
+  llvm::DenseMap<const Decl*, llvm::Value *> BlockDeclsValue;
 
   /// BlockCXXThisOffset - The offset of the C++ 'this' value within
   /// the block structure.