commit edc08821d3f73514291b339db29aca1a17485e39
author Fariborz Jahanian <fjahanian@apple.com> Wed Sep 07 16:24:21 2011 +0000
committer Fariborz Jahanian <fjahanian@apple.com> Wed Sep 07 16:24:21 2011 +0000
tree 4afbd130e65756fb1aa802c0c828cf72a9c7af65
parent 5770bb707db9169c258859a9e7c935f99a32d64c

objc-gc: More sema work for properties declared 'weak'
in GC mode. // rdar://10073896


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@139235 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/DiagnosticSemaKinds.td

diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index e39a2c7..a90849c 100644
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -549,6 +549,9 @@
 def warn_arc_perform_selector_leaks : Warning<
   "performSelector may cause a leak because its selector is unknown">,
   InGroup<DiagGroup<"arc-performSelector-leaks">>;
+def err_gc_weak_property_strong_type : Error<
+  "weak attribute declared on a __strong type property"
+  "in GC mode">;
 
 def error_synthesized_ivar_yet_not_supported : Error<
   "instance variable synthesis not yet supported"

lib/Sema/SemaObjCProperty.cpp

diff --git a/lib/Sema/SemaObjCProperty.cpp b/lib/Sema/SemaObjCProperty.cpp
index 9695b81..9f50dea 100644
--- a/lib/Sema/SemaObjCProperty.cpp
+++ b/lib/Sema/SemaObjCProperty.cpp
@@ -594,12 +594,18 @@
     ObjCPropertyDecl::PropertyAttributeKind kind 
       = property->getPropertyAttributes();
     QualType PropType = Context.getCanonicalType(property->getType());
-    bool PropertyIsGCWeak = (kind & ObjCPropertyDecl::OBJC_PR_weak &&
-                             !getLangOptions().ObjCAutoRefCount &&
-                             getLangOptions().getGCMode() != 
-                             LangOptions::NonGC);
-    if (PropertyIsGCWeak && !PropType.isObjCGCStrong())
-      PropType = Context.getObjCGCQualType(PropType, Qualifiers::Weak);
+    
+    if ((kind & ObjCPropertyDecl::OBJC_PR_weak) &&
+        !getLangOptions().ObjCAutoRefCount &&
+        getLangOptions().getGCMode() != LangOptions::NonGC) {
+      if (PropType.isObjCGCStrong()) {
+          Diag(PropertyLoc,
+               diag::err_gc_weak_property_strong_type);
+          Diag(property->getLocation(), diag::note_property_declare);    
+      }
+      else
+        PropType = Context.getObjCGCQualType(PropType, Qualifiers::Weak);
+    }
     QualType PropertyIvarType = PropType;
     if (PropType->isReferenceType())
       PropertyIvarType = cast<ReferenceType>(PropType)->getPointeeType();
@@ -721,6 +727,7 @@
            getLangOptions().getGCMode() != LangOptions::NonGC)) {
         Diag(PropertyLoc, diag::error_weak_property)
         << property->getDeclName() << Ivar->getDeclName();
+        Diag(Ivar->getLocation(), diag::note_ivar_decl);
         // Fall thru - see previous comment
       }
       // Fall thru - see previous comment

test/SemaObjC/error-property-gc-attr.m

diff --git a/test/SemaObjC/error-property-gc-attr.m b/test/SemaObjC/error-property-gc-attr.m
index 829c082..25fee05 100644
--- a/test/SemaObjC/error-property-gc-attr.m
+++ b/test/SemaObjC/error-property-gc-attr.m
@@ -3,7 +3,7 @@
 
 @interface INTF
 {
-  id IVAR;
+  id IVAR; // expected-note {{ivar is declared here}}
   __weak id II;
   __weak id WID;
   id ID;