Ted Kremenek | 565e465 | 2010-02-05 02:06:54 +0000 | [diff] [blame] | 1 | // RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-experimental-internal-checks -std=gnu99 -analyzer-check-objc-mem -verify %s -analyzer-constraints=basic -analyzer-store=basic |
| 2 | // RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-experimental-internal-checks -std=gnu99 -analyzer-check-objc-mem -verify %s -analyzer-constraints=range -analyzer-store=basic |
| 3 | // RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-experimental-internal-checks -std=gnu99 -analyzer-check-objc-mem -analyzer-store=region -analyzer-constraints=range -analyzer-no-purge-dead -verify %s |
| 4 | // RUN: %clang_cc1 -triple i386-apple-darwin10 -analyze -analyzer-experimental-internal-checks -std=gnu99 -analyzer-check-objc-mem -analyzer-store=region -analyzer-constraints=range -verify %s |
Ted Kremenek | 2f54af4 | 2008-04-02 16:54:39 +0000 | [diff] [blame] | 5 | |
Ted Kremenek | f8add9b | 2009-09-28 23:54:40 +0000 | [diff] [blame] | 6 | typedef unsigned uintptr_t; |
| 7 | |
| 8 | extern void __assert_fail (__const char *__assertion, __const char *__file, |
| 9 | unsigned int __line, __const char *__function) |
| 10 | __attribute__ ((__noreturn__)); |
| 11 | |
| 12 | #define assert(expr) \ |
| 13 | ((expr) ? (void)(0) : __assert_fail (#expr, __FILE__, __LINE__, __func__)) |
Ted Kremenek | 0fe33bc | 2008-04-22 21:10:18 +0000 | [diff] [blame] | 14 | |
Ted Kremenek | 2f54af4 | 2008-04-02 16:54:39 +0000 | [diff] [blame] | 15 | void f1(int *p) { |
| 16 | if (p) *p = 1; |
| 17 | else *p = 0; // expected-warning{{ereference}} |
| 18 | } |
Ted Kremenek | b9ab690 | 2008-04-21 23:44:17 +0000 | [diff] [blame] | 19 | |
| 20 | struct foo_struct { |
| 21 | int x; |
| 22 | }; |
| 23 | |
| 24 | int f2(struct foo_struct* p) { |
| 25 | |
| 26 | if (p) |
| 27 | p->x = 1; |
| 28 | |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 29 | return p->x++; // expected-warning{{Field access results in a dereference of a null pointer (loaded from variable 'p')}} |
Ted Kremenek | b9ab690 | 2008-04-21 23:44:17 +0000 | [diff] [blame] | 30 | } |
Ted Kremenek | 9704eac | 2008-04-22 04:56:55 +0000 | [diff] [blame] | 31 | |
| 32 | int f3(char* x) { |
| 33 | |
| 34 | int i = 2; |
| 35 | |
| 36 | if (x) |
| 37 | return x[i - 1]; |
| 38 | |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 39 | return x[i+1]; // expected-warning{{Dereference of null pointer}} |
Ted Kremenek | 9704eac | 2008-04-22 04:56:55 +0000 | [diff] [blame] | 40 | } |
| 41 | |
Ted Kremenek | e2013f5 | 2008-04-29 23:25:09 +0000 | [diff] [blame] | 42 | int f3_b(char* x) { |
| 43 | |
| 44 | int i = 2; |
| 45 | |
| 46 | if (x) |
| 47 | return x[i - 1]; |
| 48 | |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 49 | return x[i+1]++; // expected-warning{{Dereference of null pointer}} |
Ted Kremenek | e2013f5 | 2008-04-29 23:25:09 +0000 | [diff] [blame] | 50 | } |
| 51 | |
Ted Kremenek | 0fe33bc | 2008-04-22 21:10:18 +0000 | [diff] [blame] | 52 | int f4(int *p) { |
| 53 | |
Daniel Dunbar | 4489fe1 | 2008-08-05 00:07:51 +0000 | [diff] [blame] | 54 | uintptr_t x = (uintptr_t) p; |
Ted Kremenek | 0fe33bc | 2008-04-22 21:10:18 +0000 | [diff] [blame] | 55 | |
| 56 | if (x) |
| 57 | return 1; |
| 58 | |
| 59 | int *q = (int*) x; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 60 | return *q; // expected-warning{{Dereference of null pointer (loaded from variable 'q')}} |
Ted Kremenek | a548846 | 2008-04-22 21:39:21 +0000 | [diff] [blame] | 61 | } |
| 62 | |
Ted Kremenek | e1c2a67 | 2009-01-13 01:04:21 +0000 | [diff] [blame] | 63 | int f4_b() { |
| 64 | short array[2]; |
Douglas Gregor | d4eea83 | 2010-04-09 00:35:39 +0000 | [diff] [blame] | 65 | uintptr_t x = array; // expected-warning{{incompatible pointer to integer conversion}} |
| 66 | short *p = x; // expected-warning{{incompatible integer to pointer conversion}} |
Ted Kremenek | e1c2a67 | 2009-01-13 01:04:21 +0000 | [diff] [blame] | 67 | |
| 68 | // The following branch should be infeasible. |
| 69 | if (!(p = &array[0])) { |
| 70 | p = 0; |
| 71 | *p = 1; // no-warning |
| 72 | } |
| 73 | |
| 74 | if (p) { |
| 75 | *p = 5; // no-warning |
| 76 | p = 0; |
| 77 | } |
Steve Naroff | 2c0ccd0 | 2009-04-30 16:01:26 +0000 | [diff] [blame] | 78 | else return; // expected-warning {{non-void function 'f4_b' should return a value}} |
Ted Kremenek | e1c2a67 | 2009-01-13 01:04:21 +0000 | [diff] [blame] | 79 | |
| 80 | *p += 10; // expected-warning{{Dereference of null pointer}} |
Mike Stump | 339d52a | 2009-07-21 18:51:31 +0000 | [diff] [blame] | 81 | return 0; |
Ted Kremenek | e1c2a67 | 2009-01-13 01:04:21 +0000 | [diff] [blame] | 82 | } |
| 83 | |
| 84 | |
Ted Kremenek | a548846 | 2008-04-22 21:39:21 +0000 | [diff] [blame] | 85 | int f5() { |
| 86 | |
| 87 | char *s = "hello world"; |
| 88 | return s[0]; // no-warning |
| 89 | } |
| 90 | |
Ted Kremenek | 7fb43c1 | 2008-09-01 19:57:52 +0000 | [diff] [blame] | 91 | int bar(int* p, int q) __attribute__((nonnull)); |
Ted Kremenek | 584def7 | 2008-07-22 00:46:16 +0000 | [diff] [blame] | 92 | |
| 93 | int f6(int *p) { |
Ted Kremenek | 7fb43c1 | 2008-09-01 19:57:52 +0000 | [diff] [blame] | 94 | return !p ? bar(p, 1) // expected-warning {{Null pointer passed as an argument to a 'nonnull' parameter}} |
| 95 | : bar(p, 0); // no-warning |
| 96 | } |
Ted Kremenek | 584def7 | 2008-07-22 00:46:16 +0000 | [diff] [blame] | 97 | |
Ted Kremenek | a96ac06 | 2008-12-04 18:35:53 +0000 | [diff] [blame] | 98 | int bar2(int* p, int q) __attribute__((nonnull(1))); |
| 99 | |
| 100 | int f6b(int *p) { |
| 101 | return !p ? bar2(p, 1) // expected-warning {{Null pointer passed as an argument to a 'nonnull' parameter}} |
| 102 | : bar2(p, 0); // no-warning |
| 103 | } |
| 104 | |
Ted Kremenek | 1e10011 | 2008-12-04 19:39:12 +0000 | [diff] [blame] | 105 | int bar3(int*p, int q, int *r) __attribute__((nonnull(1,3))); |
Ted Kremenek | a96ac06 | 2008-12-04 18:35:53 +0000 | [diff] [blame] | 106 | |
Ted Kremenek | 1e10011 | 2008-12-04 19:39:12 +0000 | [diff] [blame] | 107 | int f6c(int *p, int *q) { |
Ted Kremenek | a317e90 | 2008-12-04 19:44:23 +0000 | [diff] [blame] | 108 | return !p ? bar3(q, 2, p) // expected-warning {{Null pointer passed as an argument to a 'nonnull' parameter}} |
| 109 | : bar3(p, 2, q); // no-warning |
Ted Kremenek | 1e10011 | 2008-12-04 19:39:12 +0000 | [diff] [blame] | 110 | } |
Ted Kremenek | a96ac06 | 2008-12-04 18:35:53 +0000 | [diff] [blame] | 111 | |
Mike Stump | f0549e2 | 2009-07-22 22:55:09 +0000 | [diff] [blame] | 112 | void f6d(int *p) { |
Ted Kremenek | c26a8b0 | 2009-07-22 21:46:56 +0000 | [diff] [blame] | 113 | bar(p, 0); |
| 114 | // At this point, 'p' cannot be null. |
| 115 | if (!p) { |
| 116 | int *q = 0; |
| 117 | *q = 0xDEADBEEF; // no-warning |
| 118 | } |
| 119 | } |
| 120 | |
Ted Kremenek | 22bda88 | 2008-07-31 20:31:27 +0000 | [diff] [blame] | 121 | int* qux(); |
| 122 | |
| 123 | int f7(int x) { |
| 124 | |
| 125 | int* p = 0; |
| 126 | |
| 127 | if (0 == x) |
| 128 | p = qux(); |
| 129 | |
| 130 | if (0 == x) |
| 131 | *p = 1; // no-warning |
| 132 | |
| 133 | return x; |
| 134 | } |
| 135 | |
Ted Kremenek | 935022a | 2009-05-02 00:41:02 +0000 | [diff] [blame] | 136 | int* f7b(int *x) { |
| 137 | |
| 138 | int* p = 0; |
| 139 | |
| 140 | if (((void*)0) == x) |
| 141 | p = qux(); |
| 142 | |
| 143 | if (((void*)0) == x) |
| 144 | *p = 1; // no-warning |
| 145 | |
| 146 | return x; |
| 147 | } |
| 148 | |
Ted Kremenek | 1308f57 | 2009-05-04 17:27:32 +0000 | [diff] [blame] | 149 | int* f7c(int *x) { |
| 150 | |
| 151 | int* p = 0; |
| 152 | |
| 153 | if (((void*)0) == x) |
| 154 | p = qux(); |
| 155 | |
| 156 | if (((void*)0) != x) |
| 157 | return x; |
Ted Kremenek | 65d80fd | 2009-05-04 17:53:11 +0000 | [diff] [blame] | 158 | |
| 159 | // If we reach here then 'p' is not null. |
| 160 | *p = 1; // no-warning |
Ted Kremenek | 1308f57 | 2009-05-04 17:27:32 +0000 | [diff] [blame] | 161 | return x; |
| 162 | } |
| 163 | |
| 164 | int* f7c2(int *x) { |
| 165 | |
| 166 | int* p = 0; |
| 167 | |
| 168 | if (((void*)0) == x) |
| 169 | p = qux(); |
| 170 | |
| 171 | if (((void*)0) == x) |
| 172 | return x; |
| 173 | |
| 174 | *p = 1; // expected-warning{{null}} |
| 175 | return x; |
| 176 | } |
| 177 | |
Ted Kremenek | 935022a | 2009-05-02 00:41:02 +0000 | [diff] [blame] | 178 | |
Mike Stump | 339d52a | 2009-07-21 18:51:31 +0000 | [diff] [blame] | 179 | void f8(int *p, int *q) { |
Ted Kremenek | dd463b8 | 2008-08-16 00:45:40 +0000 | [diff] [blame] | 180 | if (!p) |
| 181 | if (p) |
| 182 | *p = 1; // no-warning |
| 183 | |
| 184 | if (q) |
| 185 | if (!q) |
| 186 | *q = 1; // no-warning |
| 187 | } |
Ted Kremenek | 8c3e7fb | 2008-09-16 23:24:45 +0000 | [diff] [blame] | 188 | |
| 189 | int* qux(); |
| 190 | |
Ted Kremenek | 0a41e5a | 2008-09-19 18:00:36 +0000 | [diff] [blame] | 191 | int f9(unsigned len) { |
Ted Kremenek | 8c3e7fb | 2008-09-16 23:24:45 +0000 | [diff] [blame] | 192 | assert (len != 0); |
| 193 | int *p = 0; |
Ted Kremenek | cafd908 | 2008-09-24 06:40:03 +0000 | [diff] [blame] | 194 | unsigned i; |
Ted Kremenek | 8c3e7fb | 2008-09-16 23:24:45 +0000 | [diff] [blame] | 195 | |
Ted Kremenek | cafd908 | 2008-09-24 06:40:03 +0000 | [diff] [blame] | 196 | for (i = 0; i < len; ++i) |
Ted Kremenek | e2b0083 | 2008-09-16 23:25:28 +0000 | [diff] [blame] | 197 | p = qux(i); |
Ted Kremenek | 8c3e7fb | 2008-09-16 23:24:45 +0000 | [diff] [blame] | 198 | |
| 199 | return *p++; // no-warning |
| 200 | } |
Ted Kremenek | f6e5ec4 | 2008-09-17 22:24:13 +0000 | [diff] [blame] | 201 | |
Ted Kremenek | 0a41e5a | 2008-09-19 18:00:36 +0000 | [diff] [blame] | 202 | int f9b(unsigned len) { |
Ted Kremenek | f6e5ec4 | 2008-09-17 22:24:13 +0000 | [diff] [blame] | 203 | assert (len > 0); // note use of '>' |
| 204 | int *p = 0; |
Ted Kremenek | cafd908 | 2008-09-24 06:40:03 +0000 | [diff] [blame] | 205 | unsigned i; |
Ted Kremenek | f6e5ec4 | 2008-09-17 22:24:13 +0000 | [diff] [blame] | 206 | |
Ted Kremenek | cafd908 | 2008-09-24 06:40:03 +0000 | [diff] [blame] | 207 | for (i = 0; i < len; ++i) |
Ted Kremenek | f6e5ec4 | 2008-09-17 22:24:13 +0000 | [diff] [blame] | 208 | p = qux(i); |
| 209 | |
| 210 | return *p++; // no-warning |
| 211 | } |
| 212 | |
Ted Kremenek | 973e72a | 2008-11-15 04:44:13 +0000 | [diff] [blame] | 213 | int* f10(int* p, signed char x, int y) { |
| 214 | // This line tests symbolication with compound assignments where the |
| 215 | // LHS and RHS have different bitwidths. The new symbolic value |
| 216 | // for 'x' should have a bitwidth of 8. |
| 217 | x &= y; |
| 218 | |
| 219 | // This tests that our symbolication worked, and that we correctly test |
| 220 | // x against 0 (with the same bitwidth). |
| 221 | if (!x) { |
Steve Naroff | 2c0ccd0 | 2009-04-30 16:01:26 +0000 | [diff] [blame] | 222 | if (!p) return; // expected-warning {{non-void function 'f10' should return a value}} |
Ted Kremenek | 973e72a | 2008-11-15 04:44:13 +0000 | [diff] [blame] | 223 | *p = 10; |
| 224 | } |
| 225 | else p = 0; |
| 226 | |
| 227 | if (!x) |
| 228 | *p = 5; // no-warning |
| 229 | |
| 230 | return p; |
| 231 | } |
| 232 | |
Ted Kremenek | 73abd13 | 2008-12-03 18:56:12 +0000 | [diff] [blame] | 233 | // Test case from <rdar://problem/6407949> |
| 234 | void f11(unsigned i) { |
| 235 | int *x = 0; |
| 236 | if (i >= 0) { |
| 237 | // always true |
| 238 | } else { |
| 239 | *x = 42; // no-warning |
| 240 | } |
| 241 | } |
| 242 | |
Ted Kremenek | d7ff487 | 2008-12-03 19:06:30 +0000 | [diff] [blame] | 243 | void f11b(unsigned i) { |
| 244 | int *x = 0; |
| 245 | if (i <= ~(unsigned)0) { |
| 246 | // always true |
| 247 | } else { |
| 248 | *x = 42; // no-warning |
| 249 | } |
| 250 | } |
| 251 | |
Ted Kremenek | 72afb37 | 2009-01-17 01:54:16 +0000 | [diff] [blame] | 252 | // Test case for switch statements with weird case arms. |
| 253 | typedef int BOOL, *PBOOL, *LPBOOL; |
| 254 | typedef long LONG_PTR, *PLONG_PTR; |
| 255 | typedef unsigned long ULONG_PTR, *PULONG_PTR; |
| 256 | typedef ULONG_PTR DWORD_PTR, *PDWORD_PTR; |
| 257 | typedef LONG_PTR LRESULT; |
| 258 | typedef struct _F12ITEM *HF12ITEM; |
| 259 | |
| 260 | void f12(HF12ITEM i, char *q) { |
| 261 | char *p = 0; |
| 262 | switch ((DWORD_PTR) i) { |
| 263 | case 0 ... 10: |
| 264 | p = q; |
| 265 | break; |
| 266 | case (DWORD_PTR) ((HF12ITEM) - 65535): |
| 267 | return; |
| 268 | default: |
| 269 | return; |
| 270 | } |
| 271 | |
| 272 | *p = 1; // no-warning |
| 273 | } |
| 274 | |
Ted Kremenek | efcfcc0 | 2009-03-05 02:42:32 +0000 | [diff] [blame] | 275 | // Test handling of translating between integer "pointers" and back. |
| 276 | void f13() { |
| 277 | int *x = 0; |
| 278 | if (((((int) x) << 2) + 1) >> 1) *x = 1; // no-warning |
| 279 | } |
| 280 | |
Ted Kremenek | ac50213 | 2009-08-24 22:56:32 +0000 | [diff] [blame] | 281 | // PR 4759 - Attribute non-null checking by the analyzer was not correctly |
| 282 | // handling pointer values that were undefined. |
| 283 | void pr4759_aux(int *p) __attribute__((nonnull)); |
| 284 | |
| 285 | void pr4759() { |
| 286 | int *p; |
| 287 | pr4759_aux(p); // expected-warning{{undefined}} |
| 288 | } |
| 289 | |
Ted Kremenek | efcfcc0 | 2009-03-05 02:42:32 +0000 | [diff] [blame] | 290 | |