blob: b1cce85f99f1ec9dc826ca476f9342478ad6fbde [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordan Rosef540c542012-07-26 21:39:41 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Jordan Rose615a0922012-09-22 01:24:42 +000029#include "llvm/ADT/StringExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000030#include <climits>
31
Zhongxing Xu589c0f22009-11-12 08:38:56 +000032using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000033using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000034
35namespace {
36
Zhongxing Xu7fb14642009-12-11 00:55:44 +000037class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000038 enum Kind { // Reference to allocated memory.
39 Allocated,
40 // Reference to released/freed memory.
41 Released,
Anna Zaks050cdd72012-06-20 20:57:46 +000042 // The responsibility for freeing resources has transfered from
43 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000044 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000045 const Stmt *S;
46
Zhongxing Xu7fb14642009-12-11 00:55:44 +000047public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000048 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
49
Anna Zaks050cdd72012-06-20 20:57:46 +000050 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000051 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000052 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000053
Anna Zaksc8bb3be2012-02-13 18:05:39 +000054 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000055
56 bool operator==(const RefState &X) const {
57 return K == X.K && S == X.S;
58 }
59
Anna Zaks050cdd72012-06-20 20:57:46 +000060 static RefState getAllocated(const Stmt *s) {
61 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000062 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000063 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000064 static RefState getRelinquished(const Stmt *s) {
65 return RefState(Relinquished, s);
66 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000067
68 void Profile(llvm::FoldingSetNodeID &ID) const {
69 ID.AddInteger(K);
70 ID.AddPointer(S);
71 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000072};
73
Anna Zaks9dc298b2012-09-12 22:57:34 +000074enum ReallocPairKind {
75 RPToBeFreedAfterFailure,
76 // The symbol has been freed when reallocation failed.
77 RPIsFreeOnFailure,
78 // The symbol does not need to be freed after reallocation fails.
79 RPDoNotTrackAfterFailure
80};
81
Anna Zaks55dd9562012-08-24 02:28:20 +000082/// \class ReallocPair
83/// \brief Stores information about the symbol being reallocated by a call to
84/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaks40add292012-02-15 00:11:25 +000085struct ReallocPair {
Anna Zaks55dd9562012-08-24 02:28:20 +000086 // \brief The symbol which realloc reallocated.
Anna Zaks40add292012-02-15 00:11:25 +000087 SymbolRef ReallocatedSym;
Anna Zaks9dc298b2012-09-12 22:57:34 +000088 ReallocPairKind Kind;
Anna Zaks55dd9562012-08-24 02:28:20 +000089
Anna Zaks9dc298b2012-09-12 22:57:34 +000090 ReallocPair(SymbolRef S, ReallocPairKind K) :
91 ReallocatedSym(S), Kind(K) {}
Anna Zaks40add292012-02-15 00:11:25 +000092 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks9dc298b2012-09-12 22:57:34 +000093 ID.AddInteger(Kind);
Anna Zaks40add292012-02-15 00:11:25 +000094 ID.AddPointer(ReallocatedSym);
95 }
96 bool operator==(const ReallocPair &X) const {
97 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks9dc298b2012-09-12 22:57:34 +000098 Kind == X.Kind;
Anna Zaks40add292012-02-15 00:11:25 +000099 }
100};
101
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000102typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
103
Anna Zaksb319e022012-02-08 20:13:28 +0000104class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000105 check::EndPath,
106 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +0000107 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +0000108 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000109 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000110 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000111 check::Location,
112 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000113 eval::Assume,
114 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000115{
Anna Zaksfebdc322012-02-16 22:26:12 +0000116 mutable OwningPtr<BugType> BT_DoubleFree;
117 mutable OwningPtr<BugType> BT_Leak;
118 mutable OwningPtr<BugType> BT_UseFree;
119 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000120 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000121 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
122
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000123public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000124 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000125 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000126
127 /// In pessimistic mode, the checker assumes that it does not know which
128 /// functions might free the memory.
129 struct ChecksFilter {
130 DefaultBool CMallocPessimistic;
131 DefaultBool CMallocOptimistic;
132 };
133
134 ChecksFilter Filter;
135
Anna Zaks66c40402012-02-14 21:55:24 +0000136 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000137 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Jordan Rosede507ea2012-07-02 19:28:04 +0000138 void checkPreObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000139 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000140 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000141 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000142 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000143 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000144 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000145 void checkLocation(SVal l, bool isLoad, const Stmt *S,
146 CheckerContext &C) const;
147 void checkBind(SVal location, SVal val, const Stmt*S,
148 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000149 ProgramStateRef
150 checkRegionChanges(ProgramStateRef state,
151 const StoreManager::InvalidatedSymbols *invalidated,
152 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000153 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +0000154 const CallEvent *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000155 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
156 return true;
157 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000158
Anna Zaks93c5a242012-05-02 00:05:20 +0000159 void printState(raw_ostream &Out, ProgramStateRef State,
160 const char *NL, const char *Sep) const;
161
Zhongxing Xu7b760962009-11-13 07:25:27 +0000162private:
Anna Zaks66c40402012-02-14 21:55:24 +0000163 void initIdentifierInfo(ASTContext &C) const;
164
165 /// Check if this is one of the functions which can allocate/reallocate memory
166 /// pointed to by one of its arguments.
167 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000168 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
169 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000170
Anna Zaks87cb5be2012-02-22 19:24:52 +0000171 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
172 const CallExpr *CE,
173 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000174 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000175 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000176 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000177 return MallocMemAux(C, CE,
178 state->getSVal(SizeEx, C.getLocationContext()),
179 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000180 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000181
Ted Kremenek8bef8232012-01-26 21:29:00 +0000182 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000183 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000184 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000185
Anna Zaks87cb5be2012-02-22 19:24:52 +0000186 /// Update the RefState to reflect the new memory allocation.
187 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
188 const CallExpr *CE,
189 ProgramStateRef state);
190
191 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
192 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000193 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000194 ProgramStateRef state, unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000195 bool Hold,
196 bool &ReleasedAllocated) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000197 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
198 const Expr *ParentExpr,
199 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000200 bool Hold,
201 bool &ReleasedAllocated) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000202
Anna Zaks87cb5be2012-02-22 19:24:52 +0000203 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
204 bool FreesMemOnFailure) const;
205 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000206
Anna Zaks14345182012-05-18 01:16:10 +0000207 ///\brief Check if the memory associated with this symbol was released.
208 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
209
Anna Zaks91c2a112012-02-08 23:16:56 +0000210 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
211 const Stmt *S = 0) const;
212
Anna Zaks66c40402012-02-14 21:55:24 +0000213 /// Check if the function is not known to us. So, for example, we could
214 /// conservatively assume it can free/reallocate it's pointer arguments.
Jordan Rose740d4902012-07-02 19:27:35 +0000215 bool doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000216 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000217
Ted Kremenek9c378f72011-08-12 23:37:29 +0000218 static bool SummarizeValue(raw_ostream &os, SVal V);
219 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000220 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221
Anna Zaksca8e36e2012-02-23 21:38:21 +0000222 /// Find the location of the allocation for Sym on the path leading to the
223 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000224 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
225 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000226
Anna Zaksda046772012-02-11 21:02:40 +0000227 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
228
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000229 /// The bug visitor which allows us to print extra diagnostics along the
230 /// BugReport path. For example, showing the allocation site of the leaked
231 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000232 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000233 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000234 enum NotificationMode {
235 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000236 ReallocationFailed
237 };
238
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000239 // The allocated region symbol tracked by the main analysis.
240 SymbolRef Sym;
241
Anna Zaks88feba02012-05-10 01:37:40 +0000242 // The mode we are in, i.e. what kind of diagnostics will be emitted.
243 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000244
Anna Zaks88feba02012-05-10 01:37:40 +0000245 // A symbol from when the primary region should have been reallocated.
246 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000247
Anna Zaks88feba02012-05-10 01:37:40 +0000248 bool IsLeak;
249
250 public:
251 MallocBugVisitor(SymbolRef S, bool isLeak = false)
252 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000253
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000254 virtual ~MallocBugVisitor() {}
255
256 void Profile(llvm::FoldingSetNodeID &ID) const {
257 static int X = 0;
258 ID.AddPointer(&X);
259 ID.AddPointer(Sym);
260 }
261
Anna Zaksfe571602012-02-16 22:26:07 +0000262 inline bool isAllocated(const RefState *S, const RefState *SPrev,
263 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000264 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000265 return (Stmt && isa<CallExpr>(Stmt) &&
266 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000267 }
268
Anna Zaksfe571602012-02-16 22:26:07 +0000269 inline bool isReleased(const RefState *S, const RefState *SPrev,
270 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000271 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000272 return (Stmt && isa<CallExpr>(Stmt) &&
273 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
274 }
275
Anna Zaks5b7aa342012-06-22 02:04:31 +0000276 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
277 const Stmt *Stmt) {
278 // Did not track -> relinquished. Other state (allocated) -> relinquished.
279 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
280 isa<ObjCPropertyRefExpr>(Stmt)) &&
281 (S && S->isRelinquished()) &&
282 (!SPrev || !SPrev->isRelinquished()));
283 }
284
Anna Zaksfe571602012-02-16 22:26:07 +0000285 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
286 const Stmt *Stmt) {
287 // If the expression is not a call, and the state change is
288 // released -> allocated, it must be the realloc return value
289 // check. If we have to handle more cases here, it might be cleaner just
290 // to track this extra bit in the state itself.
291 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
292 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000293 }
294
295 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
296 const ExplodedNode *PrevN,
297 BugReporterContext &BRC,
298 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000299
300 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
301 const ExplodedNode *EndPathNode,
302 BugReport &BR) {
303 if (!IsLeak)
304 return 0;
305
306 PathDiagnosticLocation L =
307 PathDiagnosticLocation::createEndOfPath(EndPathNode,
308 BRC.getSourceManager());
309 // Do not add the statement itself as a range in case of leak.
310 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
311 }
312
Anna Zaks56a938f2012-03-16 23:24:20 +0000313 private:
314 class StackHintGeneratorForReallocationFailed
315 : public StackHintGeneratorForSymbol {
316 public:
317 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
318 : StackHintGeneratorForSymbol(S, M) {}
319
320 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
Jordan Rose615a0922012-09-22 01:24:42 +0000321 // Printed parameters start at 1, not 0.
322 ++ArgIndex;
323
Anna Zaks56a938f2012-03-16 23:24:20 +0000324 SmallString<200> buf;
325 llvm::raw_svector_ostream os(buf);
326
Jordan Rose615a0922012-09-22 01:24:42 +0000327 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
328 << " parameter failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000329
330 return os.str();
331 }
332
333 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000334 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000335 }
336 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000337 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000339} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000340
Jordan Rose166d5022012-11-02 01:54:06 +0000341REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState)
342REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000343
Anna Zaks4fb54872012-02-11 21:02:35 +0000344namespace {
345class StopTrackingCallback : public SymbolVisitor {
346 ProgramStateRef state;
347public:
348 StopTrackingCallback(ProgramStateRef st) : state(st) {}
349 ProgramStateRef getState() const { return state; }
350
351 bool VisitSymbol(SymbolRef sym) {
352 state = state->remove<RegionState>(sym);
353 return true;
354 }
355};
356} // end anonymous namespace
357
Anna Zaks66c40402012-02-14 21:55:24 +0000358void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000359 if (II_malloc)
360 return;
361 II_malloc = &Ctx.Idents.get("malloc");
362 II_free = &Ctx.Idents.get("free");
363 II_realloc = &Ctx.Idents.get("realloc");
364 II_reallocf = &Ctx.Idents.get("reallocf");
365 II_calloc = &Ctx.Idents.get("calloc");
366 II_valloc = &Ctx.Idents.get("valloc");
367 II_strdup = &Ctx.Idents.get("strdup");
368 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000369}
370
Anna Zaks66c40402012-02-14 21:55:24 +0000371bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000372 if (isFreeFunction(FD, C))
373 return true;
374
375 if (isAllocationFunction(FD, C))
376 return true;
377
378 return false;
379}
380
381bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
382 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000383 if (!FD)
384 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000385
Jordan Rose5ef6e942012-07-10 23:13:01 +0000386 if (FD->getKind() == Decl::Function) {
387 IdentifierInfo *FunI = FD->getIdentifier();
388 initIdentifierInfo(C);
Anna Zaks66c40402012-02-14 21:55:24 +0000389
Jordan Rose5ef6e942012-07-10 23:13:01 +0000390 if (FunI == II_malloc || FunI == II_realloc ||
391 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
392 FunI == II_strdup || FunI == II_strndup)
393 return true;
394 }
Anna Zaks66c40402012-02-14 21:55:24 +0000395
Anna Zaks14345182012-05-18 01:16:10 +0000396 if (Filter.CMallocOptimistic && FD->hasAttrs())
397 for (specific_attr_iterator<OwnershipAttr>
398 i = FD->specific_attr_begin<OwnershipAttr>(),
399 e = FD->specific_attr_end<OwnershipAttr>();
400 i != e; ++i)
401 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
402 return true;
403 return false;
404}
405
406bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
407 if (!FD)
408 return false;
409
Jordan Rose5ef6e942012-07-10 23:13:01 +0000410 if (FD->getKind() == Decl::Function) {
411 IdentifierInfo *FunI = FD->getIdentifier();
412 initIdentifierInfo(C);
Anna Zaks14345182012-05-18 01:16:10 +0000413
Jordan Rose5ef6e942012-07-10 23:13:01 +0000414 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
415 return true;
416 }
Anna Zaks66c40402012-02-14 21:55:24 +0000417
Anna Zaks14345182012-05-18 01:16:10 +0000418 if (Filter.CMallocOptimistic && FD->hasAttrs())
419 for (specific_attr_iterator<OwnershipAttr>
420 i = FD->specific_attr_begin<OwnershipAttr>(),
421 e = FD->specific_attr_end<OwnershipAttr>();
422 i != e; ++i)
423 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
424 (*i)->getOwnKind() == OwnershipAttr::Holds)
425 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000426 return false;
427}
428
Anna Zaksb319e022012-02-08 20:13:28 +0000429void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosec20c7272012-09-20 01:55:32 +0000430 if (C.wasInlined)
431 return;
432
Anna Zaksb319e022012-02-08 20:13:28 +0000433 const FunctionDecl *FD = C.getCalleeDecl(CE);
434 if (!FD)
435 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000436
Anna Zaks87cb5be2012-02-22 19:24:52 +0000437 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000438 bool ReleasedAllocatedMemory = false;
Jordan Rose5ef6e942012-07-10 23:13:01 +0000439
440 if (FD->getKind() == Decl::Function) {
441 initIdentifierInfo(C.getASTContext());
442 IdentifierInfo *FunI = FD->getIdentifier();
443
444 if (FunI == II_malloc || FunI == II_valloc) {
445 if (CE->getNumArgs() < 1)
446 return;
447 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
448 } else if (FunI == II_realloc) {
449 State = ReallocMem(C, CE, false);
450 } else if (FunI == II_reallocf) {
451 State = ReallocMem(C, CE, true);
452 } else if (FunI == II_calloc) {
453 State = CallocMem(C, CE);
454 } else if (FunI == II_free) {
Anna Zaks55dd9562012-08-24 02:28:20 +0000455 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Jordan Rose5ef6e942012-07-10 23:13:01 +0000456 } else if (FunI == II_strdup) {
457 State = MallocUpdateRefState(C, CE, State);
458 } else if (FunI == II_strndup) {
459 State = MallocUpdateRefState(C, CE, State);
460 }
461 }
462
463 if (Filter.CMallocOptimistic) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000464 // Check all the attributes, if there are any.
465 // There can be multiple of these attributes.
466 if (FD->hasAttrs())
467 for (specific_attr_iterator<OwnershipAttr>
468 i = FD->specific_attr_begin<OwnershipAttr>(),
469 e = FD->specific_attr_end<OwnershipAttr>();
470 i != e; ++i) {
471 switch ((*i)->getOwnKind()) {
472 case OwnershipAttr::Returns:
473 State = MallocMemReturnsAttr(C, CE, *i);
474 break;
475 case OwnershipAttr::Takes:
476 case OwnershipAttr::Holds:
477 State = FreeMemAttr(C, CE, *i);
478 break;
479 }
480 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000481 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000482 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000483}
484
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000485static bool isFreeWhenDoneSetToZero(const ObjCMethodCall &Call) {
486 Selector S = Call.getSelector();
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000487 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000488 if (S.getNameForSlot(i).equals("freeWhenDone"))
489 if (Call.getArgSVal(i).isConstant(0))
490 return true;
491
492 return false;
493}
494
Jordan Rosede507ea2012-07-02 19:28:04 +0000495void MallocChecker::checkPreObjCMessage(const ObjCMethodCall &Call,
Jordan Rose740d4902012-07-02 19:27:35 +0000496 CheckerContext &C) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000497 // If the first selector is dataWithBytesNoCopy, assume that the memory will
498 // be released with 'free' by the new object.
499 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
500 // Unless 'freeWhenDone' param set to 0.
501 // TODO: Check that the memory was allocated with malloc.
Anna Zaks55dd9562012-08-24 02:28:20 +0000502 bool ReleasedAllocatedMemory = false;
Jordan Rosede507ea2012-07-02 19:28:04 +0000503 Selector S = Call.getSelector();
Anna Zaks7186dc62012-06-22 22:42:30 +0000504 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
505 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
506 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000507 !isFreeWhenDoneSetToZero(Call)){
Anna Zaks5b7aa342012-06-22 02:04:31 +0000508 unsigned int argIdx = 0;
Jordan Rose740d4902012-07-02 19:27:35 +0000509 C.addTransition(FreeMemAux(C, Call.getArgExpr(argIdx),
Anna Zaks55dd9562012-08-24 02:28:20 +0000510 Call.getOriginExpr(), C.getState(), true,
511 ReleasedAllocatedMemory));
Anna Zaks5b7aa342012-06-22 02:04:31 +0000512 }
513}
514
Anna Zaks87cb5be2012-02-22 19:24:52 +0000515ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
516 const CallExpr *CE,
517 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000518 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000519 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000520
Sean Huntcf807c42010-08-18 23:23:40 +0000521 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000522 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000523 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000524 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000525 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000526}
527
Anna Zaksb319e022012-02-08 20:13:28 +0000528ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000529 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000530 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000531 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000532
533 // Bind the return value to the symbolic value from the heap region.
534 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
535 // side effects other than what we model here.
Ted Kremenek66c486f2012-08-22 06:26:15 +0000536 unsigned Count = C.blockCount();
Anna Zakse17fdb22012-06-07 03:57:32 +0000537 SValBuilder &svalBuilder = C.getSValBuilder();
538 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
539 DefinedSVal RetVal =
540 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
541 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000542
Anna Zaksb16ce452012-02-15 00:11:22 +0000543 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000544 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000545 return 0;
546
Jordy Rose32f26562010-07-04 00:00:41 +0000547 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000548 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000549
Jordy Rose32f26562010-07-04 00:00:41 +0000550 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000551 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000552 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000553 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000554 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000555 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000556 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000557 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
558 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
559 DefinedOrUnknownSVal extentMatchesSize =
560 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000561
Anna Zaks60a1fa42012-02-22 03:14:20 +0000562 state = state->assume(extentMatchesSize, true);
563 assert(state);
564 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000565
Anna Zaks87cb5be2012-02-22 19:24:52 +0000566 return MallocUpdateRefState(C, CE, state);
567}
568
569ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
570 const CallExpr *CE,
571 ProgramStateRef state) {
572 // Get the return value.
573 SVal retVal = state->getSVal(CE, C.getLocationContext());
574
575 // We expect the malloc functions to return a pointer.
576 if (!isa<Loc>(retVal))
577 return 0;
578
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000579 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000580 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000581
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000582 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000583 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000584
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000585}
586
Anna Zaks87cb5be2012-02-22 19:24:52 +0000587ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
588 const CallExpr *CE,
589 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000590 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000591 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000592
Anna Zaksb3d72752012-03-01 22:06:06 +0000593 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000594 bool ReleasedAllocated = false;
Anna Zaksb3d72752012-03-01 22:06:06 +0000595
Sean Huntcf807c42010-08-18 23:23:40 +0000596 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
597 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000598 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
Anna Zaks55dd9562012-08-24 02:28:20 +0000599 Att->getOwnKind() == OwnershipAttr::Holds,
600 ReleasedAllocated);
Anna Zaksb3d72752012-03-01 22:06:06 +0000601 if (StateI)
602 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000603 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000604 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000605}
606
Ted Kremenek8bef8232012-01-26 21:29:00 +0000607ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000608 const CallExpr *CE,
609 ProgramStateRef state,
610 unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000611 bool Hold,
612 bool &ReleasedAllocated) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000613 if (CE->getNumArgs() < (Num + 1))
614 return 0;
615
Anna Zaks55dd9562012-08-24 02:28:20 +0000616 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold, ReleasedAllocated);
Anna Zaks5b7aa342012-06-22 02:04:31 +0000617}
618
619ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
620 const Expr *ArgExpr,
621 const Expr *ParentExpr,
622 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000623 bool Hold,
624 bool &ReleasedAllocated) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000625
Ted Kremenek5eca4822012-01-06 22:09:28 +0000626 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000627 if (!isa<DefinedOrUnknownSVal>(ArgVal))
628 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000629 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
630
631 // Check for null dereferences.
632 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000633 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000634
Anna Zaksb276bd92012-02-14 00:26:13 +0000635 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000636 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000637 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000638 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000639 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000640
Jordy Rose43859f62010-06-07 19:32:37 +0000641 // Unknown values could easily be okay
642 // Undefined values are handled elsewhere
643 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000644 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000645
Jordy Rose43859f62010-06-07 19:32:37 +0000646 const MemRegion *R = ArgVal.getAsRegion();
647
648 // Nonlocs can't be freed, of course.
649 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
650 if (!R) {
651 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000652 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000653 }
654
655 R = R->StripCasts();
656
657 // Blocks might show up as heap data, but should not be free()d
658 if (isa<BlockDataRegion>(R)) {
659 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000660 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000661 }
662
663 const MemSpaceRegion *MS = R->getMemorySpace();
664
665 // Parameters, locals, statics, and globals shouldn't be freed.
666 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
667 // FIXME: at the time this code was written, malloc() regions were
668 // represented by conjured symbols, which are all in UnknownSpaceRegion.
669 // This means that there isn't actually anything from HeapSpaceRegion
670 // that should be freed, even though we allow it here.
671 // Of course, free() can work on memory allocated outside the current
672 // function, so UnknownSpaceRegion is always a possibility.
673 // False negatives are better than false positives.
674
675 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000676 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000677 }
678
679 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
680 // Various cases could lead to non-symbol values here.
681 // For now, ignore them.
682 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000683 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000684
685 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000686 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000687
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000688 // Check double free.
Anna Zaksede875b2012-08-03 18:30:18 +0000689 if (RS && (RS->isReleased() || RS->isRelinquished())) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000690 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000691 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000692 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000693 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000694 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000695 (RS->isReleased() ? "Attempt to free released memory" :
696 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000697 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000698 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000699 R->addVisitor(new MallocBugVisitor(Sym));
Jordan Rose785950e2012-11-02 01:53:40 +0000700 C.emitReport(R);
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000701 }
Anna Zaksb319e022012-02-08 20:13:28 +0000702 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000703 }
704
Anna Zaks55dd9562012-08-24 02:28:20 +0000705 ReleasedAllocated = (RS != 0);
706
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000707 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000708 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000709 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
710 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000711}
712
Ted Kremenek9c378f72011-08-12 23:37:29 +0000713bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000714 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
715 os << "an integer (" << IntVal->getValue() << ")";
716 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
717 os << "a constant address (" << ConstAddr->getValue() << ")";
718 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000719 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000720 else
721 return false;
722
723 return true;
724}
725
Ted Kremenek9c378f72011-08-12 23:37:29 +0000726bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000727 const MemRegion *MR) {
728 switch (MR->getKind()) {
729 case MemRegion::FunctionTextRegionKind: {
Anna Zaks5fc1d0c2012-09-17 19:13:56 +0000730 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Rose43859f62010-06-07 19:32:37 +0000731 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000732 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000733 else
734 os << "the address of a function";
735 return true;
736 }
737 case MemRegion::BlockTextRegionKind:
738 os << "block text";
739 return true;
740 case MemRegion::BlockDataRegionKind:
741 // FIXME: where the block came from?
742 os << "a block";
743 return true;
744 default: {
745 const MemSpaceRegion *MS = MR->getMemorySpace();
746
Anna Zakseb31a762012-01-04 23:54:01 +0000747 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000748 const VarRegion *VR = dyn_cast<VarRegion>(MR);
749 const VarDecl *VD;
750 if (VR)
751 VD = VR->getDecl();
752 else
753 VD = NULL;
754
755 if (VD)
756 os << "the address of the local variable '" << VD->getName() << "'";
757 else
758 os << "the address of a local stack variable";
759 return true;
760 }
Anna Zakseb31a762012-01-04 23:54:01 +0000761
762 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000763 const VarRegion *VR = dyn_cast<VarRegion>(MR);
764 const VarDecl *VD;
765 if (VR)
766 VD = VR->getDecl();
767 else
768 VD = NULL;
769
770 if (VD)
771 os << "the address of the parameter '" << VD->getName() << "'";
772 else
773 os << "the address of a parameter";
774 return true;
775 }
Anna Zakseb31a762012-01-04 23:54:01 +0000776
777 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000778 const VarRegion *VR = dyn_cast<VarRegion>(MR);
779 const VarDecl *VD;
780 if (VR)
781 VD = VR->getDecl();
782 else
783 VD = NULL;
784
785 if (VD) {
786 if (VD->isStaticLocal())
787 os << "the address of the static variable '" << VD->getName() << "'";
788 else
789 os << "the address of the global variable '" << VD->getName() << "'";
790 } else
791 os << "the address of a global variable";
792 return true;
793 }
Anna Zakseb31a762012-01-04 23:54:01 +0000794
795 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000796 }
797 }
798}
799
800void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000801 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000802 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000803 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000804 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000805
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000806 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000807 llvm::raw_svector_ostream os(buf);
808
809 const MemRegion *MR = ArgVal.getAsRegion();
810 if (MR) {
811 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
812 MR = ER->getSuperRegion();
813
814 // Special case for alloca()
815 if (isa<AllocaRegion>(MR))
816 os << "Argument to free() was allocated by alloca(), not malloc()";
817 else {
818 os << "Argument to free() is ";
819 if (SummarizeRegion(os, MR))
820 os << ", which is not memory allocated by malloc()";
821 else
822 os << "not memory allocated by malloc()";
823 }
824 } else {
825 os << "Argument to free() is ";
826 if (SummarizeValue(os, ArgVal))
827 os << ", which is not memory allocated by malloc()";
828 else
829 os << "not memory allocated by malloc()";
830 }
831
Anna Zakse172e8b2011-08-17 23:00:25 +0000832 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000833 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000834 R->addRange(range);
Jordan Rose785950e2012-11-02 01:53:40 +0000835 C.emitReport(R);
Jordy Rose43859f62010-06-07 19:32:37 +0000836 }
837}
838
Anna Zaks87cb5be2012-02-22 19:24:52 +0000839ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
840 const CallExpr *CE,
841 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000842 if (CE->getNumArgs() < 2)
843 return 0;
844
Ted Kremenek8bef8232012-01-26 21:29:00 +0000845 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000846 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000847 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000848 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
849 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000850 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000851 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000852
Ted Kremenek846eabd2010-12-01 21:28:31 +0000853 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000854
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000855 DefinedOrUnknownSVal PtrEQ =
856 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000857
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000858 // Get the size argument. If there is no size arg then give up.
859 const Expr *Arg1 = CE->getArg(1);
860 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000861 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000862
863 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000864 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
865 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000866 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000867 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000868
869 // Compare the size argument to 0.
870 DefinedOrUnknownSVal SizeZero =
871 svalBuilder.evalEQ(state, Arg1Val,
872 svalBuilder.makeIntValWithPtrWidth(0, false));
873
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000874 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
875 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
876 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
877 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
878 // We only assume exceptional states if they are definitely true; if the
879 // state is under-constrained, assume regular realloc behavior.
880 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
881 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
882
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000883 // If the ptr is NULL and the size is not 0, the call is equivalent to
884 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000885 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000886 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000887 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000888 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000889 }
890
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000891 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000892 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000893
Anna Zaks30838b92012-02-13 20:57:07 +0000894 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000895 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000896 SymbolRef FromPtr = arg0Val.getAsSymbol();
897 SVal RetVal = state->getSVal(CE, LCtx);
898 SymbolRef ToPtr = RetVal.getAsSymbol();
899 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000900 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000901
Anna Zaks55dd9562012-08-24 02:28:20 +0000902 bool ReleasedAllocated = false;
903
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000904 // If the size is 0, free the memory.
905 if (SizeIsZero)
Anna Zaks55dd9562012-08-24 02:28:20 +0000906 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
907 false, ReleasedAllocated)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000908 // The semantics of the return value are:
909 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaksede875b2012-08-03 18:30:18 +0000910 // to free() is returned. We just free the input pointer and do not add
911 // any constrains on the output pointer.
Anna Zaks87cb5be2012-02-22 19:24:52 +0000912 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000913 }
914
915 // Default behavior.
Anna Zaks55dd9562012-08-24 02:28:20 +0000916 if (ProgramStateRef stateFree =
917 FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) {
918
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000919 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
920 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000921 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000922 return 0;
Anna Zaks55dd9562012-08-24 02:28:20 +0000923
Anna Zaks9dc298b2012-09-12 22:57:34 +0000924 ReallocPairKind Kind = RPToBeFreedAfterFailure;
925 if (FreesOnFail)
926 Kind = RPIsFreeOnFailure;
927 else if (!ReleasedAllocated)
928 Kind = RPDoNotTrackAfterFailure;
929
Anna Zaks55dd9562012-08-24 02:28:20 +0000930 // Record the info about the reallocated symbol so that we could properly
931 // process failed reallocation.
Anna Zaks40add292012-02-15 00:11:25 +0000932 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks9dc298b2012-09-12 22:57:34 +0000933 ReallocPair(FromPtr, Kind));
Anna Zaks55dd9562012-08-24 02:28:20 +0000934 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksb276bd92012-02-14 00:26:13 +0000935 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000936 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000937 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000938 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000939}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000940
Anna Zaks87cb5be2012-02-22 19:24:52 +0000941ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000942 if (CE->getNumArgs() < 2)
943 return 0;
944
Ted Kremenek8bef8232012-01-26 21:29:00 +0000945 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000946 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000947 const LocationContext *LCtx = C.getLocationContext();
948 SVal count = state->getSVal(CE->getArg(0), LCtx);
949 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000950 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
951 svalBuilder.getContext().getSizeType());
952 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000953
Anna Zaks87cb5be2012-02-22 19:24:52 +0000954 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000955}
956
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000957LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000958MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
959 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000960 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000961 // Walk the ExplodedGraph backwards and find the first node that referred to
962 // the tracked symbol.
963 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000964 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000965
966 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000967 ProgramStateRef State = N->getState();
968 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000969 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000970
971 // Find the most recent expression bound to the symbol in the current
972 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000973 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000974 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
975 SVal Val = State->getSVal(MR);
976 if (Val.getAsLocSymbol() == Sym)
977 ReferenceRegion = MR;
978 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000979 }
980
Anna Zaks7752d292012-02-27 23:40:55 +0000981 // Allocation node, is the last node in the current context in which the
982 // symbol was tracked.
983 if (N->getLocationContext() == LeakContext)
984 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000985 N = N->pred_empty() ? NULL : *(N->pred_begin());
986 }
987
988 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000989 const Stmt *AllocationStmt = 0;
Jordan Rose852aa0d2012-07-10 22:07:52 +0000990 if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&P))
991 AllocationStmt = Exit->getCalleeContext()->getCallSite();
992 else if (StmtPoint *SP = dyn_cast<StmtPoint>(&P))
993 AllocationStmt = SP->getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000994
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000995 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000996}
997
Anna Zaksda046772012-02-11 21:02:40 +0000998void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
999 CheckerContext &C) const {
1000 assert(N);
1001 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +00001002 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +00001003 // Leaks should not be reported if they are post-dominated by a sink:
1004 // (1) Sinks are higher importance bugs.
1005 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1006 // with __noreturn functions such as assert() or exit(). We choose not
1007 // to report leaks on such paths.
1008 BT_Leak->setSuppressOnSink(true);
1009 }
1010
Anna Zaksca8e36e2012-02-23 21:38:21 +00001011 // Most bug reports are cached at the location where they occurred.
1012 // With leaks, we want to unique them by the location where they were
1013 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001014 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001015 const Stmt *AllocStmt = 0;
1016 const MemRegion *Region = 0;
1017 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1018 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001019 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1020 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001021
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001022 SmallString<200> buf;
1023 llvm::raw_svector_ostream os(buf);
1024 os << "Memory is never released; potential leak";
Jordan Rose919e8a12012-08-08 18:23:36 +00001025 if (Region && Region->canPrintPretty()) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001026 os << " of memory pointed to by '";
Jordan Rose919e8a12012-08-08 18:23:36 +00001027 Region->printPretty(os);
Jordan Rose0d53ab42012-08-08 18:23:31 +00001028 os << '\'';
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001029 }
1030
1031 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001032 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001033 R->addVisitor(new MallocBugVisitor(Sym, true));
Jordan Rose785950e2012-11-02 01:53:40 +00001034 C.emitReport(R);
Anna Zaksda046772012-02-11 21:02:40 +00001035}
1036
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001037void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1038 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001039{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001040 if (!SymReaper.hasDeadSymbols())
1041 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001042
Ted Kremenek8bef8232012-01-26 21:29:00 +00001043 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001044 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001045 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001046
Anna Zaksf8c17b72012-02-09 06:48:19 +00001047 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001048 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1049 if (SymReaper.isDead(I->first)) {
Anna Zaks54458702012-10-29 22:51:54 +00001050 if (I->second.isAllocated())
Anna Zaksf8c17b72012-02-09 06:48:19 +00001051 Errors.push_back(I->first);
Jordy Rose90760142010-08-18 04:33:47 +00001052 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001053 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001054
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001055 }
1056 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001057
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001058 // Cleanup the Realloc Pairs Map.
Jordan Rose166d5022012-11-02 01:54:06 +00001059 ReallocPairsTy RP = state->get<ReallocPairs>();
1060 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaks40add292012-02-15 00:11:25 +00001061 if (SymReaper.isDead(I->first) ||
1062 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001063 state = state->remove<ReallocPairs>(I->first);
1064 }
1065 }
1066
Anna Zaksca8e36e2012-02-23 21:38:21 +00001067 // Generate leak node.
Anna Zaks54458702012-10-29 22:51:54 +00001068 ExplodedNode *N = C.getPredecessor();
1069 if (!Errors.empty()) {
1070 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1071 N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001072 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaks54458702012-10-29 22:51:54 +00001073 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Anna Zaksda046772012-02-11 21:02:40 +00001074 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001075 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001076 }
Anna Zaks54458702012-10-29 22:51:54 +00001077
Anna Zaksca8e36e2012-02-23 21:38:21 +00001078 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001079}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001080
Anna Zaksda046772012-02-11 21:02:40 +00001081void MallocChecker::checkEndPath(CheckerContext &C) const {
1082 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001083 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001084
Anna Zaksa19581a2012-02-20 22:25:23 +00001085 // If inside inlined call, skip it.
1086 if (C.getLocationContext()->getParent() != 0)
1087 return;
1088
Jordy Rose09cef092010-08-18 04:26:59 +00001089 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001090 RefState RS = I->second;
1091 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001092 ExplodedNode *N = C.addTransition(state);
1093 if (N)
1094 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001095 }
1096 }
1097}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001098
Anna Zaks66c40402012-02-14 21:55:24 +00001099void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001100 // We will check for double free in the post visit.
1101 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001102 return;
1103
1104 // Check use after free, when a freed pointer is passed to a call.
1105 ProgramStateRef State = C.getState();
1106 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1107 E = CE->arg_end(); I != E; ++I) {
1108 const Expr *A = *I;
1109 if (A->getType().getTypePtr()->isAnyPointerType()) {
1110 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1111 if (!Sym)
1112 continue;
1113 if (checkUseAfterFree(Sym, C, A))
1114 return;
1115 }
1116 }
1117}
1118
Anna Zaks91c2a112012-02-08 23:16:56 +00001119void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1120 const Expr *E = S->getRetValue();
1121 if (!E)
1122 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001123
1124 // Check if we are returning a symbol.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001125 ProgramStateRef State = C.getState();
1126 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001127 SymbolRef Sym = RetVal.getAsSymbol();
1128 if (!Sym)
1129 // If we are returning a field of the allocated struct or an array element,
1130 // the callee could still free the memory.
1131 // TODO: This logic should be a part of generic symbol escape callback.
1132 if (const MemRegion *MR = RetVal.getAsRegion())
1133 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1134 if (const SymbolicRegion *BMR =
1135 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1136 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001137
Anna Zaks0860cd02012-02-11 21:44:39 +00001138 // Check if we are returning freed memory.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001139 if (Sym)
1140 if (checkUseAfterFree(Sym, C, E))
1141 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001142
Jordan Rose0d53ab42012-08-08 18:23:31 +00001143 // If this function body is not inlined, stop tracking any returned symbols.
1144 if (C.getLocationContext()->getParent() == 0) {
1145 State =
1146 State->scanReachableSymbols<StopTrackingCallback>(RetVal).getState();
1147 C.addTransition(State);
1148 }
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001149}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001150
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001151// TODO: Blocks should be either inlined or should call invalidate regions
1152// upon invocation. After that's in place, special casing here will not be
1153// needed.
1154void MallocChecker::checkPostStmt(const BlockExpr *BE,
1155 CheckerContext &C) const {
1156
1157 // Scan the BlockDecRefExprs for any object the retain count checker
1158 // may be tracking.
1159 if (!BE->getBlockDecl()->hasCaptures())
1160 return;
1161
1162 ProgramStateRef state = C.getState();
1163 const BlockDataRegion *R =
1164 cast<BlockDataRegion>(state->getSVal(BE,
1165 C.getLocationContext()).getAsRegion());
1166
1167 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1168 E = R->referenced_vars_end();
1169
1170 if (I == E)
1171 return;
1172
1173 SmallVector<const MemRegion*, 10> Regions;
1174 const LocationContext *LC = C.getLocationContext();
1175 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1176
1177 for ( ; I != E; ++I) {
1178 const VarRegion *VR = *I;
1179 if (VR->getSuperRegion() == R) {
1180 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1181 }
1182 Regions.push_back(VR);
1183 }
1184
1185 state =
1186 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1187 Regions.data() + Regions.size()).getState();
1188 C.addTransition(state);
1189}
1190
Anna Zaks14345182012-05-18 01:16:10 +00001191bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001192 assert(Sym);
1193 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001194 return (RS && RS->isReleased());
1195}
1196
1197bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1198 const Stmt *S) const {
1199 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001200 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001201 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001202 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001203
Anna Zaksfebdc322012-02-16 22:26:12 +00001204 BugReport *R = new BugReport(*BT_UseFree,
1205 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001206 if (S)
1207 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001208 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001209 R->addVisitor(new MallocBugVisitor(Sym));
Jordan Rose785950e2012-11-02 01:53:40 +00001210 C.emitReport(R);
Anna Zaks91c2a112012-02-08 23:16:56 +00001211 return true;
1212 }
1213 }
1214 return false;
1215}
1216
Zhongxing Xuc8023782010-03-10 04:58:55 +00001217// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001218void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1219 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001220 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001221 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001222 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001223}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001224
Anna Zaks4fb54872012-02-11 21:02:35 +00001225//===----------------------------------------------------------------------===//
1226// Check various ways a symbol can be invalidated.
1227// TODO: This logic (the next 3 functions) is copied/similar to the
1228// RetainRelease checker. We might want to factor this out.
1229//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001230
Anna Zaks4fb54872012-02-11 21:02:35 +00001231// Stop tracking symbols when a value escapes as a result of checkBind.
1232// A value escapes in three possible cases:
1233// (1) we are binding to something that is not a memory region.
1234// (2) we are binding to a memregion that does not have stack storage
1235// (3) we are binding to a memregion with stack storage that the store
1236// does not understand.
1237void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1238 CheckerContext &C) const {
1239 // Are we storing to something that causes the value to "escape"?
1240 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001241 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001242
Anna Zaks4fb54872012-02-11 21:02:35 +00001243 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1244 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001245
Anna Zaks4fb54872012-02-11 21:02:35 +00001246 if (!escapes) {
1247 // To test (3), generate a new state with the binding added. If it is
1248 // the same state, then it escapes (since the store cannot represent
1249 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001250 // Do this only if we know that the store is not supposed to generate the
1251 // same state.
1252 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1253 if (StoredVal != val)
1254 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001255 }
1256 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001257
1258 // If our store can represent the binding and we aren't storing to something
1259 // that doesn't have local storage then just return and have the simulation
1260 // state continue as is.
1261 if (!escapes)
1262 return;
1263
1264 // Otherwise, find all symbols referenced by 'val' that we are tracking
1265 // and stop tracking them.
1266 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1267 C.addTransition(state);
1268}
1269
1270// If a symbolic region is assumed to NULL (or another constant), stop tracking
1271// it - assuming that allocation failed on this path.
1272ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1273 SVal Cond,
1274 bool Assumption) const {
1275 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001276 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001277 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001278 ConstraintManager &CMgr = state->getConstraintManager();
1279 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1280 if (AllocFailed.isConstrainedTrue())
Anna Zaks4fb54872012-02-11 21:02:35 +00001281 state = state->remove<RegionState>(I.getKey());
1282 }
1283
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001284 // Realloc returns 0 when reallocation fails, which means that we should
1285 // restore the state of the pointer being reallocated.
Jordan Rose166d5022012-11-02 01:54:06 +00001286 ReallocPairsTy RP = state->get<ReallocPairs>();
1287 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001288 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001289 ConstraintManager &CMgr = state->getConstraintManager();
1290 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
Jordan Rose79a29eb2012-11-01 00:25:15 +00001291 if (!AllocFailed.isConstrainedTrue())
Anna Zaks9dc298b2012-09-12 22:57:34 +00001292 continue;
Jordan Roseec8d4202012-11-01 00:18:27 +00001293
Anna Zaks9dc298b2012-09-12 22:57:34 +00001294 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1295 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
1296 if (RS->isReleased()) {
1297 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaks40add292012-02-15 00:11:25 +00001298 state = state->set<RegionState>(ReallocSym,
Anna Zaks9dc298b2012-09-12 22:57:34 +00001299 RefState::getAllocated(RS->getStmt()));
1300 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
1301 state = state->remove<RegionState>(ReallocSym);
1302 else
1303 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001304 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001305 }
Anna Zaks9dc298b2012-09-12 22:57:34 +00001306 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001307 }
1308
Anna Zaks4fb54872012-02-11 21:02:35 +00001309 return state;
1310}
1311
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001312// Check if the function is known to us. So, for example, we could
Jordan Rose740d4902012-07-02 19:27:35 +00001313// conservatively assume it can free/reallocate its pointer arguments.
Anna Zaks66c40402012-02-14 21:55:24 +00001314// (We assume that the pointers cannot escape through calls to system
1315// functions not handled by this checker.)
Jordan Rose740d4902012-07-02 19:27:35 +00001316bool MallocChecker::doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001317 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001318 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001319
1320 // For now, assume that any C++ call can free memory.
1321 // TODO: If we want to be more optimistic here, we'll need to make sure that
1322 // regions escape to C++ containers. They seem to do that even now, but for
1323 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001324 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001325 return false;
1326
Jordan Rose740d4902012-07-02 19:27:35 +00001327 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001328 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001329 // If it's not a framework call, or if it takes a callback, assume it
1330 // can free memory.
1331 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001332 return false;
1333
Jordan Rose740d4902012-07-02 19:27:35 +00001334 Selector S = Msg->getSelector();
Anna Zaks52a04812012-06-20 23:35:57 +00001335
Jordan Rose740d4902012-07-02 19:27:35 +00001336 // Whitelist the ObjC methods which do free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001337 // - Anything containing 'freeWhenDone' param set to 1.
1338 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001339 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001340 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1341 if (Call->getArgSVal(i).isConstant(1))
1342 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001343 else
1344 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001345 }
1346 }
1347
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001348 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001349 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001350 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
Jordan Rose740d4902012-07-02 19:27:35 +00001351 StringRef FirstSlot = S.getNameForSlot(0);
1352 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001353 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001354
Anna Zaks5f757682012-06-19 05:10:32 +00001355 // If the first selector starts with addPointer, insertPointer,
1356 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1357 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001358 // that the pointers get freed by following the container itself.
1359 if (FirstSlot.startswith("addPointer") ||
1360 FirstSlot.startswith("insertPointer") ||
1361 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001362 return false;
1363 }
1364
Jordan Rose740d4902012-07-02 19:27:35 +00001365 // Otherwise, assume that the method does not free memory.
1366 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001367 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001368 }
1369
Jordan Rose740d4902012-07-02 19:27:35 +00001370 // At this point the only thing left to handle is straight function calls.
1371 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1372 if (!FD)
1373 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001374
Jordan Rose740d4902012-07-02 19:27:35 +00001375 ASTContext &ASTC = State->getStateManager().getContext();
1376
1377 // If it's one of the allocation functions we can reason about, we model
1378 // its behavior explicitly.
1379 if (isMemFunction(FD, ASTC))
1380 return true;
1381
1382 // If it's not a system call, assume it frees memory.
1383 if (!Call->isInSystemHeader())
1384 return false;
1385
1386 // White list the system functions whose arguments escape.
1387 const IdentifierInfo *II = FD->getIdentifier();
1388 if (!II)
1389 return false;
1390 StringRef FName = II->getName();
1391
Jordan Rose740d4902012-07-02 19:27:35 +00001392 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001393 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001394 if (FName.endswith("NoCopy")) {
1395 // Look for the deallocator argument. We know that the memory ownership
1396 // is not transferred only if the deallocator argument is
1397 // 'kCFAllocatorNull'.
1398 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1399 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1400 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1401 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1402 if (DeallocatorName == "kCFAllocatorNull")
1403 return true;
1404 }
1405 }
1406 return false;
1407 }
1408
Jordan Rose740d4902012-07-02 19:27:35 +00001409 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001410 // 'closefn' is specified (and if that function does free memory),
1411 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001412 // Currently, we do not inspect the 'closefn' function (PR12101).
1413 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001414 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1415 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001416
1417 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1418 // these leaks might be intentional when setting the buffer for stdio.
1419 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1420 if (FName == "setbuf" || FName =="setbuffer" ||
1421 FName == "setlinebuf" || FName == "setvbuf") {
1422 if (Call->getNumArgs() >= 1) {
1423 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1424 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1425 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1426 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1427 return false;
1428 }
1429 }
1430
1431 // A bunch of other functions which either take ownership of a pointer or
1432 // wrap the result up in a struct or object, meaning it can be freed later.
1433 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1434 // but the Malloc checker cannot differentiate between them. The right way
1435 // of doing this would be to implement a pointer escapes callback.
1436 if (FName == "CGBitmapContextCreate" ||
1437 FName == "CGBitmapContextCreateWithData" ||
1438 FName == "CVPixelBufferCreateWithBytes" ||
1439 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1440 FName == "OSAtomicEnqueue") {
1441 return false;
1442 }
1443
Jordan Rose85d7e012012-07-02 19:27:51 +00001444 // Handle cases where we know a buffer's /address/ can escape.
1445 // Note that the above checks handle some special cases where we know that
1446 // even though the address escapes, it's still our responsibility to free the
1447 // buffer.
1448 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001449 return false;
1450
1451 // Otherwise, assume that the function does not free memory.
1452 // Most system calls do not free the memory.
1453 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001454}
1455
Anna Zaks4fb54872012-02-11 21:02:35 +00001456// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1457// escapes, when we are tracking p), do not track the symbol as we cannot reason
1458// about it anymore.
1459ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001460MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001461 const StoreManager::InvalidatedSymbols *invalidated,
1462 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001463 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +00001464 const CallEvent *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001465 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001466 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001467 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001468
Anna Zaks66c40402012-02-14 21:55:24 +00001469 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001470 // regions (explicit and implicit) escaped.
1471
1472 // Otherwise, whitelist explicit pointers; we still can track them.
1473 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001474 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1475 E = ExplicitRegions.end(); I != E; ++I) {
1476 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1477 WhitelistedSymbols.insert(R->getSymbol());
1478 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001479 }
1480
1481 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1482 E = invalidated->end(); I!=E; ++I) {
1483 SymbolRef sym = *I;
1484 if (WhitelistedSymbols.count(sym))
1485 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001486 // The symbol escaped. Note, we assume that if the symbol is released,
1487 // passing it out will result in a use after free. We also keep tracking
1488 // relinquished symbols.
1489 if (const RefState *RS = State->get<RegionState>(sym)) {
1490 if (RS->isAllocated())
Anna Zaks431e35c2012-08-09 00:42:24 +00001491 State = State->remove<RegionState>(sym);
Anna Zaks5b7aa342012-06-22 02:04:31 +00001492 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001493 }
Anna Zaks66c40402012-02-14 21:55:24 +00001494 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001495}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001496
Jordy Rose393f98b2012-03-18 07:43:35 +00001497static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1498 ProgramStateRef prevState) {
Jordan Rose166d5022012-11-02 01:54:06 +00001499 ReallocPairsTy currMap = currState->get<ReallocPairs>();
1500 ReallocPairsTy prevMap = prevState->get<ReallocPairs>();
Jordy Rose393f98b2012-03-18 07:43:35 +00001501
Jordan Rose166d5022012-11-02 01:54:06 +00001502 for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end();
Jordy Rose393f98b2012-03-18 07:43:35 +00001503 I != E; ++I) {
1504 SymbolRef sym = I.getKey();
1505 if (!currMap.lookup(sym))
1506 return sym;
1507 }
1508
1509 return NULL;
1510}
1511
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001512PathDiagnosticPiece *
1513MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1514 const ExplodedNode *PrevN,
1515 BugReporterContext &BRC,
1516 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001517 ProgramStateRef state = N->getState();
1518 ProgramStateRef statePrev = PrevN->getState();
1519
1520 const RefState *RS = state->get<RegionState>(Sym);
1521 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksede875b2012-08-03 18:30:18 +00001522 if (!RS)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001523 return 0;
1524
Anna Zaksfe571602012-02-16 22:26:07 +00001525 const Stmt *S = 0;
1526 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001527 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001528
1529 // Retrieve the associated statement.
1530 ProgramPoint ProgLoc = N->getLocation();
Jordan Rose852aa0d2012-07-10 22:07:52 +00001531 if (StmtPoint *SP = dyn_cast<StmtPoint>(&ProgLoc))
1532 S = SP->getStmt();
1533 else if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&ProgLoc))
1534 S = Exit->getCalleeContext()->getCallSite();
Anna Zaksfe571602012-02-16 22:26:07 +00001535 // If an assumption was made on a branch, it should be caught
1536 // here by looking at the state transition.
Jordan Rose852aa0d2012-07-10 22:07:52 +00001537 else if (BlockEdge *Edge = dyn_cast<BlockEdge>(&ProgLoc)) {
1538 const CFGBlock *srcBlk = Edge->getSrc();
Anna Zaksfe571602012-02-16 22:26:07 +00001539 S = srcBlk->getTerminator();
1540 }
1541 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001542 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001543
Jordan Rose28038f32012-07-10 22:07:42 +00001544 // FIXME: We will eventually need to handle non-statement-based events
1545 // (__attribute__((cleanup))).
1546
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001547 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001548 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001549 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001550 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001551 StackHint = new StackHintGeneratorForSymbol(Sym,
1552 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001553 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001554 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001555 StackHint = new StackHintGeneratorForSymbol(Sym,
1556 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001557 } else if (isRelinquished(RS, RSPrev, S)) {
1558 Msg = "Memory ownership is transfered";
1559 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001560 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001561 Mode = ReallocationFailed;
1562 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001563 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001564 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001565
Jordy Roseb000fb52012-03-24 03:15:09 +00001566 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1567 // Is it possible to fail two reallocs WITHOUT testing in between?
1568 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1569 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001570 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001571 FailedReallocSymbol = sym;
1572 }
Anna Zaksfe571602012-02-16 22:26:07 +00001573 }
1574
1575 // We are in a special mode if a reallocation failed later in the path.
1576 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001577 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001578
Jordy Roseb000fb52012-03-24 03:15:09 +00001579 // Is this is the first appearance of the reallocated symbol?
1580 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001581 // We're at the reallocation point.
1582 Msg = "Attempt to reallocate memory";
1583 StackHint = new StackHintGeneratorForSymbol(Sym,
1584 "Returned reallocated memory");
1585 FailedReallocSymbol = NULL;
1586 Mode = Normal;
1587 }
Anna Zaksfe571602012-02-16 22:26:07 +00001588 }
1589
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001590 if (!Msg)
1591 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001592 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001593
1594 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001595 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001596 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001597 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001598}
1599
Anna Zaks93c5a242012-05-02 00:05:20 +00001600void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1601 const char *NL, const char *Sep) const {
1602
1603 RegionStateTy RS = State->get<RegionState>();
1604
1605 if (!RS.isEmpty())
1606 Out << "Has Malloc data" << NL;
1607}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001608
Anna Zaks231361a2012-02-08 23:16:52 +00001609#define REGISTER_CHECKER(name) \
1610void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001611 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001612 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001613}
Anna Zaks231361a2012-02-08 23:16:52 +00001614
1615REGISTER_CHECKER(MallocPessimistic)
1616REGISTER_CHECKER(MallocOptimistic)