blob: dbc33430fb74a148d6ab9fa775aa953c672480d1 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
15#include "Sema.h"
Ted Kremeneke0e53132010-01-28 23:39:18 +000016#include "clang/Analysis/Analyses/PrintfFormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000017#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000018#include "clang/AST/CharUnits.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000019#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000020#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000021#include "clang/AST/ExprObjC.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000022#include "clang/AST/DeclObjC.h"
23#include "clang/AST/StmtCXX.h"
24#include "clang/AST/StmtObjC.h"
Chris Lattner719e6152009-02-18 19:21:10 +000025#include "clang/Lex/LiteralSupport.h"
Chris Lattner59907c42007-08-10 20:18:51 +000026#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000027#include "llvm/ADT/BitVector.h"
28#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000029#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000030#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000031#include "clang/Basic/TargetInfo.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000032#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000033using namespace clang;
34
Chris Lattner60800082009-02-18 17:49:48 +000035/// getLocationOfStringLiteralByte - Return a source location that points to the
36/// specified byte of the specified string literal.
37///
38/// Strings are amazingly complex. They can be formed from multiple tokens and
39/// can have escape sequences in them in addition to the usual trigraph and
40/// escaped newline business. This routine handles this complexity.
41///
42SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
43 unsigned ByteNo) const {
44 assert(!SL->isWide() && "This doesn't work for wide strings yet");
Mike Stump1eb44332009-09-09 15:08:12 +000045
Chris Lattner60800082009-02-18 17:49:48 +000046 // Loop over all of the tokens in this string until we find the one that
47 // contains the byte we're looking for.
48 unsigned TokNo = 0;
49 while (1) {
50 assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
51 SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
Mike Stump1eb44332009-09-09 15:08:12 +000052
Chris Lattner60800082009-02-18 17:49:48 +000053 // Get the spelling of the string so that we can get the data that makes up
54 // the string literal, not the identifier for the macro it is potentially
55 // expanded through.
56 SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
57
58 // Re-lex the token to get its length and original spelling.
59 std::pair<FileID, unsigned> LocInfo =
60 SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
Douglas Gregorf715ca12010-03-16 00:06:06 +000061 bool Invalid = false;
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000062 llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
Douglas Gregorf715ca12010-03-16 00:06:06 +000063 if (Invalid)
Douglas Gregoraea67db2010-03-15 22:54:52 +000064 return StrTokSpellingLoc;
65
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000066 const char *StrData = Buffer.data()+LocInfo.second;
Mike Stump1eb44332009-09-09 15:08:12 +000067
Chris Lattner60800082009-02-18 17:49:48 +000068 // Create a langops struct and enable trigraphs. This is sufficient for
69 // relexing tokens.
70 LangOptions LangOpts;
71 LangOpts.Trigraphs = true;
Mike Stump1eb44332009-09-09 15:08:12 +000072
Chris Lattner60800082009-02-18 17:49:48 +000073 // Create a lexer starting at the beginning of this token.
Benjamin Kramerf6ac97b2010-03-16 14:14:31 +000074 Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
75 Buffer.end());
Chris Lattner60800082009-02-18 17:49:48 +000076 Token TheTok;
77 TheLexer.LexFromRawLexer(TheTok);
Mike Stump1eb44332009-09-09 15:08:12 +000078
Chris Lattner443e53c2009-02-18 19:26:42 +000079 // Use the StringLiteralParser to compute the length of the string in bytes.
Douglas Gregorb90f4b32010-05-26 05:35:51 +000080 StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
Chris Lattner443e53c2009-02-18 19:26:42 +000081 unsigned TokNumBytes = SLP.GetStringLength();
Mike Stump1eb44332009-09-09 15:08:12 +000082
Chris Lattner2197c962009-02-18 18:52:52 +000083 // If the byte is in this token, return the location of the byte.
Chris Lattner60800082009-02-18 17:49:48 +000084 if (ByteNo < TokNumBytes ||
85 (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
Mike Stump1eb44332009-09-09 15:08:12 +000086 unsigned Offset =
Douglas Gregorb90f4b32010-05-26 05:35:51 +000087 StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
88 /*Complain=*/false);
Mike Stump1eb44332009-09-09 15:08:12 +000089
Chris Lattner719e6152009-02-18 19:21:10 +000090 // Now that we know the offset of the token in the spelling, use the
91 // preprocessor to get the offset in the original source.
92 return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
Chris Lattner60800082009-02-18 17:49:48 +000093 }
Mike Stump1eb44332009-09-09 15:08:12 +000094
Chris Lattner60800082009-02-18 17:49:48 +000095 // Move to the next string token.
96 ++TokNo;
97 ByteNo -= TokNumBytes;
98 }
99}
100
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000101/// CheckablePrintfAttr - does a function call have a "printf" attribute
102/// and arguments that merit checking?
103bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
104 if (Format->getType() == "printf") return true;
105 if (Format->getType() == "printf0") {
106 // printf0 allows null "format" string; if so don't check format/args
107 unsigned format_idx = Format->getFormatIdx() - 1;
Sebastian Redl4a2614e2009-11-17 18:02:24 +0000108 // Does the index refer to the implicit object argument?
109 if (isa<CXXMemberCallExpr>(TheCall)) {
110 if (format_idx == 0)
111 return false;
112 --format_idx;
113 }
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000114 if (format_idx < TheCall->getNumArgs()) {
115 Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
Ted Kremenekefaff192010-02-27 01:41:03 +0000116 if (!Format->isNullPointerConstant(Context,
117 Expr::NPC_ValueDependentIsNull))
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000118 return true;
119 }
120 }
121 return false;
122}
Chris Lattner60800082009-02-18 17:49:48 +0000123
Sebastian Redl0eb23302009-01-19 00:08:26 +0000124Action::OwningExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000125Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Sebastian Redl0eb23302009-01-19 00:08:26 +0000126 OwningExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000127
Anders Carlssond406bf02009-08-16 01:56:34 +0000128 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000129 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000130 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000131 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000132 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000133 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000134 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000135 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000136 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000137 if (SemaBuiltinVAStart(TheCall))
138 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000139 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000140 case Builtin::BI__builtin_isgreater:
141 case Builtin::BI__builtin_isgreaterequal:
142 case Builtin::BI__builtin_isless:
143 case Builtin::BI__builtin_islessequal:
144 case Builtin::BI__builtin_islessgreater:
145 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000146 if (SemaBuiltinUnorderedCompare(TheCall))
147 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000148 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000149 case Builtin::BI__builtin_fpclassify:
150 if (SemaBuiltinFPClassification(TheCall, 6))
151 return ExprError();
152 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000153 case Builtin::BI__builtin_isfinite:
154 case Builtin::BI__builtin_isinf:
155 case Builtin::BI__builtin_isinf_sign:
156 case Builtin::BI__builtin_isnan:
157 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000158 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000159 return ExprError();
160 break;
Eli Friedman6cfda232008-05-20 08:23:37 +0000161 case Builtin::BI__builtin_return_address:
Eric Christopher691ebc32010-04-17 02:26:23 +0000162 case Builtin::BI__builtin_frame_address: {
163 llvm::APSInt Result;
164 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000165 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000166 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000167 }
168 case Builtin::BI__builtin_eh_return_data_regno: {
169 llvm::APSInt Result;
170 if (SemaBuiltinConstantArg(TheCall, 0, Result))
Chris Lattner21fb98e2009-09-23 06:06:36 +0000171 return ExprError();
172 break;
Eric Christopher691ebc32010-04-17 02:26:23 +0000173 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000174 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000175 return SemaBuiltinShuffleVector(TheCall);
176 // TheCall will be freed by the smart pointer here, but that's fine, since
177 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000178 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000179 if (SemaBuiltinPrefetch(TheCall))
180 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000181 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000182 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000183 if (SemaBuiltinObjectSize(TheCall))
184 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000185 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000186 case Builtin::BI__builtin_longjmp:
187 if (SemaBuiltinLongjmp(TheCall))
188 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000189 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000190 case Builtin::BI__sync_fetch_and_add:
191 case Builtin::BI__sync_fetch_and_sub:
192 case Builtin::BI__sync_fetch_and_or:
193 case Builtin::BI__sync_fetch_and_and:
194 case Builtin::BI__sync_fetch_and_xor:
195 case Builtin::BI__sync_add_and_fetch:
196 case Builtin::BI__sync_sub_and_fetch:
197 case Builtin::BI__sync_and_and_fetch:
198 case Builtin::BI__sync_or_and_fetch:
199 case Builtin::BI__sync_xor_and_fetch:
200 case Builtin::BI__sync_val_compare_and_swap:
201 case Builtin::BI__sync_bool_compare_and_swap:
202 case Builtin::BI__sync_lock_test_and_set:
203 case Builtin::BI__sync_lock_release:
204 if (SemaBuiltinAtomicOverloaded(TheCall))
205 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000206 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000207 }
208
209 // Since the target specific builtins for each arch overlap, only check those
210 // of the arch we are compiling for.
211 if (BuiltinID >= Builtin::FirstTSBuiltin) {
212 switch (Context.Target.getTriple().getArch()) {
213 case llvm::Triple::arm:
214 case llvm::Triple::thumb:
215 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
216 return ExprError();
217 break;
218 case llvm::Triple::x86:
219 case llvm::Triple::x86_64:
220 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
221 return ExprError();
222 break;
223 default:
224 break;
225 }
226 }
227
228 return move(TheCallResult);
229}
230
231bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
232 switch (BuiltinID) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000233 case X86::BI__builtin_ia32_palignr128:
234 case X86::BI__builtin_ia32_palignr: {
235 llvm::APSInt Result;
236 if (SemaBuiltinConstantArg(TheCall, 2, Result))
Nate Begeman26a31422010-06-08 02:47:44 +0000237 return true;
Eric Christopher691ebc32010-04-17 02:26:23 +0000238 break;
239 }
Anders Carlsson71993dd2007-08-17 05:31:46 +0000240 }
Nate Begeman26a31422010-06-08 02:47:44 +0000241 return false;
242}
Mike Stump1eb44332009-09-09 15:08:12 +0000243
Nate Begeman26a31422010-06-08 02:47:44 +0000244bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000245 llvm::APSInt Result;
246
247 switch (BuiltinID) {
248 case ARM::BI__builtin_neon_vget_lane_i8:
249 case ARM::BI__builtin_neon_vget_lane_i16:
250 case ARM::BI__builtin_neon_vget_lane_i32:
251 case ARM::BI__builtin_neon_vget_lane_f32:
252 case ARM::BI__builtin_neon_vget_lane_i64:
253 case ARM::BI__builtin_neon_vgetq_lane_i8:
254 case ARM::BI__builtin_neon_vgetq_lane_i16:
255 case ARM::BI__builtin_neon_vgetq_lane_i32:
256 case ARM::BI__builtin_neon_vgetq_lane_f32:
257 case ARM::BI__builtin_neon_vgetq_lane_i64:
258 // Check constant-ness first.
259 if (SemaBuiltinConstantArg(TheCall, 1, Result))
260 return true;
261 break;
262 }
263
264 // Now, range check values.
265 //unsigned lower = 0, upper = 0;
266
Nate Begeman26a31422010-06-08 02:47:44 +0000267 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000268}
Daniel Dunbarde454282008-10-02 18:44:07 +0000269
Anders Carlssond406bf02009-08-16 01:56:34 +0000270/// CheckFunctionCall - Check a direct function call for various correctness
271/// and safety properties not strictly enforced by the C type system.
272bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
273 // Get the IdentifierInfo* for the called function.
274 IdentifierInfo *FnInfo = FDecl->getIdentifier();
275
276 // None of the checks below are needed for functions that don't have
277 // simple names (e.g., C++ conversion functions).
278 if (!FnInfo)
279 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000280
Daniel Dunbarde454282008-10-02 18:44:07 +0000281 // FIXME: This mechanism should be abstracted to be less fragile and
282 // more efficient. For example, just map function ids to custom
283 // handlers.
284
Chris Lattner59907c42007-08-10 20:18:51 +0000285 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000286 if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
Ryan Flynn4403a5e2009-08-06 03:00:50 +0000287 if (CheckablePrintfAttr(Format, TheCall)) {
Ted Kremenek3d692df2009-02-27 17:58:43 +0000288 bool HasVAListArg = Format->getFirstArg() == 0;
Douglas Gregor3c385e52009-02-14 18:57:46 +0000289 CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
Ted Kremenek3d692df2009-02-27 17:58:43 +0000290 HasVAListArg ? 0 : Format->getFirstArg() - 1);
Douglas Gregor3c385e52009-02-14 18:57:46 +0000291 }
Chris Lattner59907c42007-08-10 20:18:51 +0000292 }
Mike Stump1eb44332009-09-09 15:08:12 +0000293
294 for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
Anders Carlssond406bf02009-08-16 01:56:34 +0000295 NonNull = NonNull->getNext<NonNullAttr>())
296 CheckNonNullArguments(NonNull, TheCall);
Sebastian Redl0eb23302009-01-19 00:08:26 +0000297
Anders Carlssond406bf02009-08-16 01:56:34 +0000298 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000299}
300
Anders Carlssond406bf02009-08-16 01:56:34 +0000301bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000302 // Printf checking.
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000303 const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000304 if (!Format)
Anders Carlssond406bf02009-08-16 01:56:34 +0000305 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000306
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000307 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
308 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000309 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000310
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000311 QualType Ty = V->getType();
312 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000313 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000314
Anders Carlssond406bf02009-08-16 01:56:34 +0000315 if (!CheckablePrintfAttr(Format, TheCall))
316 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000317
Anders Carlssond406bf02009-08-16 01:56:34 +0000318 bool HasVAListArg = Format->getFirstArg() == 0;
Anders Carlssond406bf02009-08-16 01:56:34 +0000319 CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
320 HasVAListArg ? 0 : Format->getFirstArg() - 1);
321
322 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000323}
324
Chris Lattner5caa3702009-05-08 06:58:22 +0000325/// SemaBuiltinAtomicOverloaded - We have a call to a function like
326/// __sync_fetch_and_add, which is an overloaded function based on the pointer
327/// type of its first argument. The main ActOnCallExpr routines have already
328/// promoted the types of arguments because all of these calls are prototyped as
329/// void(...).
330///
331/// This function goes through and does final semantic checking for these
332/// builtins,
333bool Sema::SemaBuiltinAtomicOverloaded(CallExpr *TheCall) {
334 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
335 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
336
337 // Ensure that we have at least one argument to do type inference from.
338 if (TheCall->getNumArgs() < 1)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000339 return Diag(TheCall->getLocEnd(),
340 diag::err_typecheck_call_too_few_args_at_least)
341 << 0 << 1 << TheCall->getNumArgs()
342 << TheCall->getCallee()->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000343
Chris Lattner5caa3702009-05-08 06:58:22 +0000344 // Inspect the first argument of the atomic builtin. This should always be
345 // a pointer type, whose element is an integral scalar or pointer type.
346 // Because it is a pointer type, we don't have to worry about any implicit
347 // casts here.
348 Expr *FirstArg = TheCall->getArg(0);
349 if (!FirstArg->getType()->isPointerType())
350 return Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
351 << FirstArg->getType() << FirstArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000352
Ted Kremenek6217b802009-07-29 21:53:49 +0000353 QualType ValType = FirstArg->getType()->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000354 if (!ValType->isIntegerType() && !ValType->isPointerType() &&
Chris Lattner5caa3702009-05-08 06:58:22 +0000355 !ValType->isBlockPointerType())
356 return Diag(DRE->getLocStart(),
357 diag::err_atomic_builtin_must_be_pointer_intptr)
358 << FirstArg->getType() << FirstArg->getSourceRange();
359
360 // We need to figure out which concrete builtin this maps onto. For example,
361 // __sync_fetch_and_add with a 2 byte object turns into
362 // __sync_fetch_and_add_2.
363#define BUILTIN_ROW(x) \
364 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
365 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000366
Chris Lattner5caa3702009-05-08 06:58:22 +0000367 static const unsigned BuiltinIndices[][5] = {
368 BUILTIN_ROW(__sync_fetch_and_add),
369 BUILTIN_ROW(__sync_fetch_and_sub),
370 BUILTIN_ROW(__sync_fetch_and_or),
371 BUILTIN_ROW(__sync_fetch_and_and),
372 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000373
Chris Lattner5caa3702009-05-08 06:58:22 +0000374 BUILTIN_ROW(__sync_add_and_fetch),
375 BUILTIN_ROW(__sync_sub_and_fetch),
376 BUILTIN_ROW(__sync_and_and_fetch),
377 BUILTIN_ROW(__sync_or_and_fetch),
378 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000379
Chris Lattner5caa3702009-05-08 06:58:22 +0000380 BUILTIN_ROW(__sync_val_compare_and_swap),
381 BUILTIN_ROW(__sync_bool_compare_and_swap),
382 BUILTIN_ROW(__sync_lock_test_and_set),
383 BUILTIN_ROW(__sync_lock_release)
384 };
Mike Stump1eb44332009-09-09 15:08:12 +0000385#undef BUILTIN_ROW
386
Chris Lattner5caa3702009-05-08 06:58:22 +0000387 // Determine the index of the size.
388 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000389 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000390 case 1: SizeIndex = 0; break;
391 case 2: SizeIndex = 1; break;
392 case 4: SizeIndex = 2; break;
393 case 8: SizeIndex = 3; break;
394 case 16: SizeIndex = 4; break;
395 default:
396 return Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
397 << FirstArg->getType() << FirstArg->getSourceRange();
398 }
Mike Stump1eb44332009-09-09 15:08:12 +0000399
Chris Lattner5caa3702009-05-08 06:58:22 +0000400 // Each of these builtins has one pointer argument, followed by some number of
401 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
402 // that we ignore. Find out which row of BuiltinIndices to read from as well
403 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000404 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000405 unsigned BuiltinIndex, NumFixed = 1;
406 switch (BuiltinID) {
407 default: assert(0 && "Unknown overloaded atomic builtin!");
408 case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
409 case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
410 case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
411 case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
412 case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000413
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000414 case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
415 case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
416 case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
417 case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
418 case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
Mike Stump1eb44332009-09-09 15:08:12 +0000419
Chris Lattner5caa3702009-05-08 06:58:22 +0000420 case Builtin::BI__sync_val_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000421 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +0000422 NumFixed = 2;
423 break;
424 case Builtin::BI__sync_bool_compare_and_swap:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000425 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +0000426 NumFixed = 2;
427 break;
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000428 case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000429 case Builtin::BI__sync_lock_release:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +0000430 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +0000431 NumFixed = 0;
432 break;
433 }
Mike Stump1eb44332009-09-09 15:08:12 +0000434
Chris Lattner5caa3702009-05-08 06:58:22 +0000435 // Now that we know how many fixed arguments we expect, first check that we
436 // have at least that many.
437 if (TheCall->getNumArgs() < 1+NumFixed)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000438 return Diag(TheCall->getLocEnd(),
439 diag::err_typecheck_call_too_few_args_at_least)
440 << 0 << 1+NumFixed << TheCall->getNumArgs()
441 << TheCall->getCallee()->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000442
443
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000444 // Get the decl for the concrete builtin from this, we can tell what the
445 // concrete integer type we should convert to is.
446 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
447 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
448 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +0000449 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000450 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
451 TUScope, false, DRE->getLocStart()));
452 const FunctionProtoType *BuiltinFT =
John McCall183700f2009-09-21 23:43:11 +0000453 NewBuiltinDecl->getType()->getAs<FunctionProtoType>();
Ted Kremenek6217b802009-07-29 21:53:49 +0000454 ValType = BuiltinFT->getArgType(0)->getAs<PointerType>()->getPointeeType();
Mike Stump1eb44332009-09-09 15:08:12 +0000455
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000456 // If the first type needs to be converted (e.g. void** -> int*), do it now.
457 if (BuiltinFT->getArgType(0) != FirstArg->getType()) {
Eli Friedman73c39ab2009-10-20 08:27:19 +0000458 ImpCastExprToType(FirstArg, BuiltinFT->getArgType(0), CastExpr::CK_BitCast);
Chris Lattnere7ac0a92009-05-08 15:36:58 +0000459 TheCall->setArg(0, FirstArg);
460 }
Mike Stump1eb44332009-09-09 15:08:12 +0000461
Chris Lattner5caa3702009-05-08 06:58:22 +0000462 // Next, walk the valid ones promoting to the right type.
463 for (unsigned i = 0; i != NumFixed; ++i) {
464 Expr *Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +0000465
Chris Lattner5caa3702009-05-08 06:58:22 +0000466 // If the argument is an implicit cast, then there was a promotion due to
467 // "...", just remove it now.
468 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
469 Arg = ICE->getSubExpr();
470 ICE->setSubExpr(0);
471 ICE->Destroy(Context);
472 TheCall->setArg(i+1, Arg);
473 }
Mike Stump1eb44332009-09-09 15:08:12 +0000474
Chris Lattner5caa3702009-05-08 06:58:22 +0000475 // GCC does an implicit conversion to the pointer or integer ValType. This
476 // can fail in some cases (1i -> int**), check for this error case now.
Anders Carlssoncdb61972009-08-07 22:21:05 +0000477 CastExpr::CastKind Kind = CastExpr::CK_Unknown;
Anders Carlsson5cf86ba2010-04-24 19:06:50 +0000478 CXXBaseSpecifierArray BasePath;
479 if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
Chris Lattner5caa3702009-05-08 06:58:22 +0000480 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000481
Chris Lattner5caa3702009-05-08 06:58:22 +0000482 // Okay, we have something that *can* be converted to the right type. Check
483 // to see if there is a potentially weird extension going on here. This can
484 // happen when you do an atomic operation on something like an char* and
485 // pass in 42. The 42 gets converted to char. This is even more strange
486 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +0000487 // FIXME: Do this check.
Anders Carlsson80971bd2010-04-24 16:36:20 +0000488 ImpCastExprToType(Arg, ValType, Kind);
Chris Lattner5caa3702009-05-08 06:58:22 +0000489 TheCall->setArg(i+1, Arg);
490 }
Mike Stump1eb44332009-09-09 15:08:12 +0000491
Chris Lattner5caa3702009-05-08 06:58:22 +0000492 // Switch the DeclRefExpr to refer to the new decl.
493 DRE->setDecl(NewBuiltinDecl);
494 DRE->setType(NewBuiltinDecl->getType());
Mike Stump1eb44332009-09-09 15:08:12 +0000495
Chris Lattner5caa3702009-05-08 06:58:22 +0000496 // Set the callee in the CallExpr.
497 // FIXME: This leaks the original parens and implicit casts.
498 Expr *PromotedCall = DRE;
499 UsualUnaryConversions(PromotedCall);
500 TheCall->setCallee(PromotedCall);
Mike Stump1eb44332009-09-09 15:08:12 +0000501
Chris Lattner5caa3702009-05-08 06:58:22 +0000502
503 // Change the result type of the call to match the result type of the decl.
504 TheCall->setType(NewBuiltinDecl->getResultType());
505 return false;
506}
507
508
Chris Lattner69039812009-02-18 06:01:06 +0000509/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +0000510/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +0000511/// FIXME: GCC currently emits the following warning:
Mike Stump1eb44332009-09-09 15:08:12 +0000512/// "warning: input conversion stopped due to an input byte that does not
Steve Narofffd942622009-04-13 20:26:29 +0000513/// belong to the input codeset UTF-8"
514/// Note: It might also make sense to do the UTF-16 conversion here (would
515/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +0000516bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +0000517 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +0000518 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
519
520 if (!Literal || Literal->isWide()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000521 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
522 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000523 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000524 }
Mike Stump1eb44332009-09-09 15:08:12 +0000525
Daniel Dunbarf015b032009-09-22 10:03:52 +0000526 const char *Data = Literal->getStrData();
527 unsigned Length = Literal->getByteLength();
Mike Stump1eb44332009-09-09 15:08:12 +0000528
Daniel Dunbarf015b032009-09-22 10:03:52 +0000529 for (unsigned i = 0; i < Length; ++i) {
530 if (!Data[i]) {
531 Diag(getLocationOfStringLiteralByte(Literal, i),
532 diag::warn_cfstring_literal_contains_nul_character)
533 << Arg->getSourceRange();
534 break;
535 }
536 }
Mike Stump1eb44332009-09-09 15:08:12 +0000537
Anders Carlsson9cdc4d32007-08-17 15:44:17 +0000538 return false;
Chris Lattner59907c42007-08-10 20:18:51 +0000539}
540
Chris Lattnerc27c6652007-12-20 00:05:45 +0000541/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
542/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +0000543bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
544 Expr *Fn = TheCall->getCallee();
545 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +0000546 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000547 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000548 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
549 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +0000550 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000551 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +0000552 return true;
553 }
Eli Friedman56f20ae2008-12-15 22:05:35 +0000554
555 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +0000556 return Diag(TheCall->getLocEnd(),
557 diag::err_typecheck_call_too_few_args_at_least)
558 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +0000559 }
560
Chris Lattnerc27c6652007-12-20 00:05:45 +0000561 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +0000562 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +0000563 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000564 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +0000565 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +0000566 else if (FunctionDecl *FD = getCurFunctionDecl())
567 isVariadic = FD->isVariadic();
568 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000569 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +0000570
Chris Lattnerc27c6652007-12-20 00:05:45 +0000571 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000572 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
573 return true;
574 }
Mike Stump1eb44332009-09-09 15:08:12 +0000575
Chris Lattner30ce3442007-12-19 23:59:04 +0000576 // Verify that the second argument to the builtin is the last argument of the
577 // current function or method.
578 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +0000579 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +0000580
Anders Carlsson88cf2262008-02-11 04:20:54 +0000581 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
582 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000583 // FIXME: This isn't correct for methods (results in bogus warning).
584 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +0000585 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +0000586 if (CurBlock)
587 LastArg = *(CurBlock->TheDecl->param_end()-1);
588 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +0000589 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000590 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +0000591 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +0000592 SecondArgIsLastNamedArgument = PV == LastArg;
593 }
594 }
Mike Stump1eb44332009-09-09 15:08:12 +0000595
Chris Lattner30ce3442007-12-19 23:59:04 +0000596 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +0000597 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +0000598 diag::warn_second_parameter_of_va_start_not_last_named_argument);
599 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +0000600}
Chris Lattner30ce3442007-12-19 23:59:04 +0000601
Chris Lattner1b9a0792007-12-20 00:26:33 +0000602/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
603/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +0000604bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
605 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +0000606 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000607 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +0000608 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +0000609 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000610 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000611 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000612 << SourceRange(TheCall->getArg(2)->getLocStart(),
613 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000614
Chris Lattner925e60d2007-12-28 05:29:59 +0000615 Expr *OrigArg0 = TheCall->getArg(0);
616 Expr *OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +0000617
Chris Lattner1b9a0792007-12-20 00:26:33 +0000618 // Do standard promotions between the two arguments, returning their common
619 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +0000620 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
Daniel Dunbar403bc2b2009-02-19 19:28:43 +0000621
622 // Make sure any conversions are pushed back into the call; this is
623 // type safe since unordered compare builtins are declared as "_Bool
624 // foo(...)".
625 TheCall->setArg(0, OrigArg0);
626 TheCall->setArg(1, OrigArg1);
Mike Stump1eb44332009-09-09 15:08:12 +0000627
Douglas Gregorcde01732009-05-19 22:10:17 +0000628 if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
629 return false;
630
Chris Lattner1b9a0792007-12-20 00:26:33 +0000631 // If the common type isn't a real floating type, then the arguments were
632 // invalid for this operation.
633 if (!Res->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000634 return Diag(OrigArg0->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000635 diag::err_typecheck_call_invalid_ordered_compare)
Chris Lattnerd1625842008-11-24 06:25:27 +0000636 << OrigArg0->getType() << OrigArg1->getType()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000637 << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +0000638
Chris Lattner1b9a0792007-12-20 00:26:33 +0000639 return false;
640}
641
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000642/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
643/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000644/// to check everything. We expect the last argument to be a floating point
645/// value.
646bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
647 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +0000648 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +0000649 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000650 if (TheCall->getNumArgs() > NumArgs)
651 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000652 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +0000653 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000654 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000655 (*(TheCall->arg_end()-1))->getLocEnd());
656
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000657 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +0000658
Eli Friedman9ac6f622009-08-31 20:06:00 +0000659 if (OrigArg->isTypeDependent())
660 return false;
661
Chris Lattner81368fb2010-05-06 05:50:07 +0000662 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +0000663 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +0000664 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +0000665 diag::err_typecheck_call_invalid_unary_fp)
666 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +0000667
Chris Lattner81368fb2010-05-06 05:50:07 +0000668 // If this is an implicit conversion from float -> double, remove it.
669 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
670 Expr *CastArg = Cast->getSubExpr();
671 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
672 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
673 "promotion from float to double is the only expected cast here");
674 Cast->setSubExpr(0);
675 Cast->Destroy(Context);
676 TheCall->setArg(NumArgs-1, CastArg);
677 OrigArg = CastArg;
678 }
679 }
680
Eli Friedman9ac6f622009-08-31 20:06:00 +0000681 return false;
682}
683
Eli Friedmand38617c2008-05-14 19:38:39 +0000684/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
685// This is declared to take (...), so we have to check everything.
Sebastian Redl0eb23302009-01-19 00:08:26 +0000686Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000687 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000688 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +0000689 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +0000690 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +0000691 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000692
Nate Begeman37b6a572010-06-08 00:16:34 +0000693 // Determine which of the following types of shufflevector we're checking:
694 // 1) unary, vector mask: (lhs, mask)
695 // 2) binary, vector mask: (lhs, rhs, mask)
696 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
697 QualType resType = TheCall->getArg(0)->getType();
698 unsigned numElements = 0;
699
Douglas Gregorcde01732009-05-19 22:10:17 +0000700 if (!TheCall->getArg(0)->isTypeDependent() &&
701 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +0000702 QualType LHSType = TheCall->getArg(0)->getType();
703 QualType RHSType = TheCall->getArg(1)->getType();
704
705 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000706 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000707 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000708 TheCall->getArg(1)->getLocEnd());
709 return ExprError();
710 }
Nate Begeman37b6a572010-06-08 00:16:34 +0000711
712 numElements = LHSType->getAs<VectorType>()->getNumElements();
713 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +0000714
Nate Begeman37b6a572010-06-08 00:16:34 +0000715 // Check to see if we have a call with 2 vector arguments, the unary shuffle
716 // with mask. If so, verify that RHS is an integer vector type with the
717 // same number of elts as lhs.
718 if (TheCall->getNumArgs() == 2) {
719 if (!RHSType->isIntegerType() ||
720 RHSType->getAs<VectorType>()->getNumElements() != numElements)
721 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
722 << SourceRange(TheCall->getArg(1)->getLocStart(),
723 TheCall->getArg(1)->getLocEnd());
724 numResElements = numElements;
725 }
726 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000727 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +0000728 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +0000729 TheCall->getArg(1)->getLocEnd());
730 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +0000731 } else if (numElements != numResElements) {
732 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
733 resType = Context.getVectorType(eltType, numResElements, false, false);
Douglas Gregorcde01732009-05-19 22:10:17 +0000734 }
Eli Friedmand38617c2008-05-14 19:38:39 +0000735 }
736
737 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000738 if (TheCall->getArg(i)->isTypeDependent() ||
739 TheCall->getArg(i)->isValueDependent())
740 continue;
741
Nate Begeman37b6a572010-06-08 00:16:34 +0000742 llvm::APSInt Result(32);
743 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
744 return ExprError(Diag(TheCall->getLocStart(),
745 diag::err_shufflevector_nonconstant_argument)
746 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +0000747
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000748 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000749 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000750 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +0000751 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +0000752 }
753
754 llvm::SmallVector<Expr*, 32> exprs;
755
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +0000756 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +0000757 exprs.push_back(TheCall->getArg(i));
758 TheCall->setArg(i, 0);
759 }
760
Nate Begemana88dc302009-08-12 02:10:25 +0000761 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +0000762 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +0000763 TheCall->getCallee()->getLocStart(),
764 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +0000765}
Chris Lattner30ce3442007-12-19 23:59:04 +0000766
Daniel Dunbar4493f792008-07-21 22:59:13 +0000767/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
768// This is declared to take (const void*, ...) and can take two
769// optional constant int args.
770bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000771 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000772
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000773 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +0000774 return Diag(TheCall->getLocEnd(),
775 diag::err_typecheck_call_too_many_args_at_most)
776 << 0 /*function call*/ << 3 << NumArgs
777 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000778
779 // Argument 0 is checked for us and the remaining arguments must be
780 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000781 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +0000782 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +0000783
Eli Friedman9aef7262009-12-04 00:30:06 +0000784 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +0000785 if (SemaBuiltinConstantArg(TheCall, i, Result))
786 return true;
Mike Stump1eb44332009-09-09 15:08:12 +0000787
Daniel Dunbar4493f792008-07-21 22:59:13 +0000788 // FIXME: gcc issues a warning and rewrites these to 0. These
789 // seems especially odd for the third argument since the default
790 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000791 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +0000792 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000793 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000794 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000795 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +0000796 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000797 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +0000798 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +0000799 }
800 }
801
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000802 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +0000803}
804
Eric Christopher691ebc32010-04-17 02:26:23 +0000805/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
806/// TheCall is a constant expression.
807bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
808 llvm::APSInt &Result) {
809 Expr *Arg = TheCall->getArg(ArgNum);
810 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
811 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
812
813 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
814
815 if (!Arg->isIntegerConstantExpr(Result, Context))
816 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +0000817 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +0000818
Chris Lattner21fb98e2009-09-23 06:06:36 +0000819 return false;
820}
821
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000822/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
823/// int type). This simply type checks that type is one of the defined
824/// constants (0-3).
Eric Christopherfee667f2009-12-23 03:49:37 +0000825// For compatability check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000826bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +0000827 llvm::APSInt Result;
828
829 // Check constant-ness first.
830 if (SemaBuiltinConstantArg(TheCall, 1, Result))
831 return true;
832
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000833 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000834 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +0000835 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
836 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000837 }
838
839 return false;
840}
841
Eli Friedman586d6a82009-05-03 06:04:26 +0000842/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +0000843/// This checks that val is a constant 1.
844bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
845 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +0000846 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +0000847
Eric Christopher691ebc32010-04-17 02:26:23 +0000848 // TODO: This is less than ideal. Overload this to take a value.
849 if (SemaBuiltinConstantArg(TheCall, 1, Result))
850 return true;
851
852 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +0000853 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
854 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
855
856 return false;
857}
858
Ted Kremenekd30ef872009-01-12 23:09:09 +0000859// Handle i > 1 ? "x" : "y", recursivelly
Ted Kremenek082d9362009-03-20 21:35:28 +0000860bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
861 bool HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000862 unsigned format_idx, unsigned firstDataArg) {
Douglas Gregorcde01732009-05-19 22:10:17 +0000863 if (E->isTypeDependent() || E->isValueDependent())
864 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000865
866 switch (E->getStmtClass()) {
867 case Stmt::ConditionalOperatorClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000868 const ConditionalOperator *C = cast<ConditionalOperator>(E);
Chris Lattner813b70d2009-12-22 06:00:13 +0000869 return SemaCheckStringLiteral(C->getTrueExpr(), TheCall,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000870 HasVAListArg, format_idx, firstDataArg)
Ted Kremenekd30ef872009-01-12 23:09:09 +0000871 && SemaCheckStringLiteral(C->getRHS(), TheCall,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000872 HasVAListArg, format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000873 }
874
875 case Stmt::ImplicitCastExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000876 const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000877 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000878 format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000879 }
880
881 case Stmt::ParenExprClass: {
Ted Kremenek082d9362009-03-20 21:35:28 +0000882 const ParenExpr *Expr = cast<ParenExpr>(E);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000883 return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000884 format_idx, firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000885 }
Mike Stump1eb44332009-09-09 15:08:12 +0000886
Ted Kremenek082d9362009-03-20 21:35:28 +0000887 case Stmt::DeclRefExprClass: {
888 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000889
Ted Kremenek082d9362009-03-20 21:35:28 +0000890 // As an exception, do not flag errors for variables binding to
891 // const string literals.
892 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
893 bool isConstant = false;
894 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +0000895
Ted Kremenek082d9362009-03-20 21:35:28 +0000896 if (const ArrayType *AT = Context.getAsArrayType(T)) {
897 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +0000898 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000899 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +0000900 PT->getPointeeType().isConstant(Context);
901 }
Mike Stump1eb44332009-09-09 15:08:12 +0000902
Ted Kremenek082d9362009-03-20 21:35:28 +0000903 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +0000904 if (const Expr *Init = VD->getAnyInitializer())
Ted Kremenek082d9362009-03-20 21:35:28 +0000905 return SemaCheckStringLiteral(Init, TheCall,
906 HasVAListArg, format_idx, firstDataArg);
907 }
Mike Stump1eb44332009-09-09 15:08:12 +0000908
Anders Carlssond966a552009-06-28 19:55:58 +0000909 // For vprintf* functions (i.e., HasVAListArg==true), we add a
910 // special check to see if the format string is a function parameter
911 // of the function calling the printf function. If the function
912 // has an attribute indicating it is a printf-like function, then we
913 // should suppress warnings concerning non-literals being used in a call
914 // to a vprintf function. For example:
915 //
916 // void
917 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
918 // va_list ap;
919 // va_start(ap, fmt);
920 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
921 // ...
922 //
923 //
924 // FIXME: We don't have full attribute support yet, so just check to see
925 // if the argument is a DeclRefExpr that references a parameter. We'll
926 // add proper support for checking the attribute later.
927 if (HasVAListArg)
928 if (isa<ParmVarDecl>(VD))
929 return true;
Ted Kremenek082d9362009-03-20 21:35:28 +0000930 }
Mike Stump1eb44332009-09-09 15:08:12 +0000931
Ted Kremenek082d9362009-03-20 21:35:28 +0000932 return false;
933 }
Ted Kremenekd30ef872009-01-12 23:09:09 +0000934
Anders Carlsson8f031b32009-06-27 04:05:33 +0000935 case Stmt::CallExprClass: {
936 const CallExpr *CE = cast<CallExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000937 if (const ImplicitCastExpr *ICE
Anders Carlsson8f031b32009-06-27 04:05:33 +0000938 = dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
939 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
940 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
Argyrios Kyrtzidis40b598e2009-06-30 02:34:44 +0000941 if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
Anders Carlsson8f031b32009-06-27 04:05:33 +0000942 unsigned ArgIndex = FA->getFormatIdx();
943 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +0000944
945 return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
Anders Carlsson8f031b32009-06-27 04:05:33 +0000946 format_idx, firstDataArg);
947 }
948 }
949 }
950 }
Mike Stump1eb44332009-09-09 15:08:12 +0000951
Anders Carlsson8f031b32009-06-27 04:05:33 +0000952 return false;
953 }
Ted Kremenek082d9362009-03-20 21:35:28 +0000954 case Stmt::ObjCStringLiteralClass:
955 case Stmt::StringLiteralClass: {
956 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +0000957
Ted Kremenek082d9362009-03-20 21:35:28 +0000958 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +0000959 StrE = ObjCFExpr->getString();
960 else
Ted Kremenek082d9362009-03-20 21:35:28 +0000961 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +0000962
Ted Kremenekd30ef872009-01-12 23:09:09 +0000963 if (StrE) {
Mike Stump1eb44332009-09-09 15:08:12 +0000964 CheckPrintfString(StrE, E, TheCall, HasVAListArg, format_idx,
Douglas Gregor3c385e52009-02-14 18:57:46 +0000965 firstDataArg);
Ted Kremenekd30ef872009-01-12 23:09:09 +0000966 return true;
967 }
Mike Stump1eb44332009-09-09 15:08:12 +0000968
Ted Kremenekd30ef872009-01-12 23:09:09 +0000969 return false;
970 }
Mike Stump1eb44332009-09-09 15:08:12 +0000971
Ted Kremenek082d9362009-03-20 21:35:28 +0000972 default:
973 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +0000974 }
975}
976
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +0000977void
Mike Stump1eb44332009-09-09 15:08:12 +0000978Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
979 const CallExpr *TheCall) {
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +0000980 for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
981 i != e; ++i) {
Chris Lattner12b97ff2009-05-25 18:23:36 +0000982 const Expr *ArgExpr = TheCall->getArg(*i);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +0000983 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +0000984 Expr::NPC_ValueDependentIsNotNull))
Chris Lattner12b97ff2009-05-25 18:23:36 +0000985 Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
986 << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +0000987 }
988}
Ted Kremenekd30ef872009-01-12 23:09:09 +0000989
Chris Lattner59907c42007-08-10 20:18:51 +0000990/// CheckPrintfArguments - Check calls to printf (and similar functions) for
Mike Stump1eb44332009-09-09 15:08:12 +0000991/// correct use of format strings.
Ted Kremenek71895b92007-08-14 17:39:48 +0000992///
993/// HasVAListArg - A predicate indicating whether the printf-like
994/// function is passed an explicit va_arg argument (e.g., vprintf)
995///
996/// format_idx - The index into Args for the format string.
997///
998/// Improper format strings to functions in the printf family can be
999/// the source of bizarre bugs and very serious security holes. A
1000/// good source of information is available in the following paper
1001/// (which includes additional references):
Chris Lattner59907c42007-08-10 20:18:51 +00001002///
1003/// FormatGuard: Automatic Protection From printf Format String
1004/// Vulnerabilities, Proceedings of the 10th USENIX Security Symposium, 2001.
Ted Kremenek71895b92007-08-14 17:39:48 +00001005///
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001006/// TODO:
Ted Kremenek71895b92007-08-14 17:39:48 +00001007/// Functionality implemented:
1008///
1009/// We can statically check the following properties for string
1010/// literal format strings for non v.*printf functions (where the
1011/// arguments are passed directly):
1012//
1013/// (1) Are the number of format conversions equal to the number of
1014/// data arguments?
1015///
1016/// (2) Does each format conversion correctly match the type of the
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001017/// corresponding data argument?
Ted Kremenek71895b92007-08-14 17:39:48 +00001018///
1019/// Moreover, for all printf functions we can:
1020///
1021/// (3) Check for a missing format string (when not caught by type checking).
1022///
1023/// (4) Check for no-operation flags; e.g. using "#" with format
1024/// conversion 'c' (TODO)
1025///
1026/// (5) Check the use of '%n', a major source of security holes.
1027///
1028/// (6) Check for malformed format conversions that don't specify anything.
1029///
1030/// (7) Check for empty format strings. e.g: printf("");
1031///
1032/// (8) Check that the format string is a wide literal.
1033///
1034/// All of these checks can be done by parsing the format string.
1035///
Chris Lattner59907c42007-08-10 20:18:51 +00001036void
Mike Stump1eb44332009-09-09 15:08:12 +00001037Sema::CheckPrintfArguments(const CallExpr *TheCall, bool HasVAListArg,
Douglas Gregor3c385e52009-02-14 18:57:46 +00001038 unsigned format_idx, unsigned firstDataArg) {
Ted Kremenek082d9362009-03-20 21:35:28 +00001039 const Expr *Fn = TheCall->getCallee();
Chris Lattner925e60d2007-12-28 05:29:59 +00001040
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001041 // The way the format attribute works in GCC, the implicit this argument
1042 // of member functions is counted. However, it doesn't appear in our own
1043 // lists, so decrement format_idx in that case.
1044 if (isa<CXXMemberCallExpr>(TheCall)) {
1045 // Catch a format attribute mistakenly referring to the object argument.
1046 if (format_idx == 0)
1047 return;
1048 --format_idx;
1049 if(firstDataArg != 0)
1050 --firstDataArg;
1051 }
1052
Mike Stump1eb44332009-09-09 15:08:12 +00001053 // CHECK: printf-like function is called with no format string.
Chris Lattner925e60d2007-12-28 05:29:59 +00001054 if (format_idx >= TheCall->getNumArgs()) {
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001055 Diag(TheCall->getRParenLoc(), diag::warn_printf_missing_format_string)
1056 << Fn->getSourceRange();
Ted Kremenek71895b92007-08-14 17:39:48 +00001057 return;
1058 }
Mike Stump1eb44332009-09-09 15:08:12 +00001059
Ted Kremenek082d9362009-03-20 21:35:28 +00001060 const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001061
Chris Lattner59907c42007-08-10 20:18:51 +00001062 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001063 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001064 // Dynamically generated format strings are difficult to
1065 // automatically vet at compile time. Requiring that format strings
1066 // are string literals: (1) permits the checking of format strings by
1067 // the compiler and thereby (2) can practically remove the source of
1068 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001069
Mike Stump1eb44332009-09-09 15:08:12 +00001070 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001071 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001072 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001073 // the same format string checking logic for both ObjC and C strings.
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001074 if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
1075 firstDataArg))
1076 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001077
Chris Lattner655f1412009-04-29 04:59:47 +00001078 // If there are no arguments specified, warn with -Wformat-security, otherwise
1079 // warn only with -Wformat-nonliteral.
1080 if (TheCall->getNumArgs() == format_idx+1)
Mike Stump1eb44332009-09-09 15:08:12 +00001081 Diag(TheCall->getArg(format_idx)->getLocStart(),
Chris Lattner655f1412009-04-29 04:59:47 +00001082 diag::warn_printf_nonliteral_noargs)
1083 << OrigFormatExpr->getSourceRange();
1084 else
Mike Stump1eb44332009-09-09 15:08:12 +00001085 Diag(TheCall->getArg(format_idx)->getLocStart(),
Chris Lattner655f1412009-04-29 04:59:47 +00001086 diag::warn_printf_nonliteral)
1087 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001088}
Ted Kremenek71895b92007-08-14 17:39:48 +00001089
Ted Kremeneke0e53132010-01-28 23:39:18 +00001090namespace {
Ted Kremenek74d56a12010-02-04 20:46:58 +00001091class CheckPrintfHandler : public analyze_printf::FormatStringHandler {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001092 Sema &S;
1093 const StringLiteral *FExpr;
1094 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001095 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001096 const unsigned NumDataArgs;
1097 const bool IsObjCLiteral;
1098 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001099 const bool HasVAListArg;
1100 const CallExpr *TheCall;
1101 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001102 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001103 bool usesPositionalArgs;
1104 bool atFirstArg;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001105public:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001106 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001107 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001108 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001109 const char *beg, bool hasVAListArg,
1110 const CallExpr *theCall, unsigned formatIdx)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001111 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001112 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001113 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001114 IsObjCLiteral(isObjCLiteral), Beg(beg),
1115 HasVAListArg(hasVAListArg),
Ted Kremenekefaff192010-02-27 01:41:03 +00001116 TheCall(theCall), FormatIdx(formatIdx),
1117 usesPositionalArgs(false), atFirstArg(true) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001118 CoveredArgs.resize(numDataArgs);
1119 CoveredArgs.reset();
1120 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001121
Ted Kremenek07d161f2010-01-29 01:50:07 +00001122 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001123
Ted Kremenek808015a2010-01-29 03:16:21 +00001124 void HandleIncompleteFormatSpecifier(const char *startSpecifier,
1125 unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001126
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001127 bool
Ted Kremenek74d56a12010-02-04 20:46:58 +00001128 HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1129 const char *startSpecifier,
1130 unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001131
Ted Kremenekefaff192010-02-27 01:41:03 +00001132 virtual void HandleInvalidPosition(const char *startSpecifier,
1133 unsigned specifierLen,
1134 analyze_printf::PositionContext p);
1135
1136 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1137
Ted Kremeneke0e53132010-01-28 23:39:18 +00001138 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001139
Ted Kremeneke0e53132010-01-28 23:39:18 +00001140 bool HandleFormatSpecifier(const analyze_printf::FormatSpecifier &FS,
1141 const char *startSpecifier,
1142 unsigned specifierLen);
1143private:
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001144 SourceRange getFormatStringRange();
1145 SourceRange getFormatSpecifierRange(const char *startSpecifier,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001146 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001147 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001148
Ted Kremenekefaff192010-02-27 01:41:03 +00001149 bool HandleAmount(const analyze_printf::OptionalAmount &Amt, unsigned k,
1150 const char *startSpecifier, unsigned specifierLen);
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001151 void HandleFlags(const analyze_printf::FormatSpecifier &FS,
1152 llvm::StringRef flag, llvm::StringRef cspec,
1153 const char *startSpecifier, unsigned specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001154
Ted Kremenek0d277352010-01-29 01:06:55 +00001155 const Expr *getDataArg(unsigned i) const;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001156};
1157}
1158
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001159SourceRange CheckPrintfHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001160 return OrigFormatExpr->getSourceRange();
1161}
1162
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001163SourceRange CheckPrintfHandler::
1164getFormatSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
1165 return SourceRange(getLocationOfByte(startSpecifier),
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001166 getLocationOfByte(startSpecifier+specifierLen-1));
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001167}
1168
Ted Kremeneke0e53132010-01-28 23:39:18 +00001169SourceLocation CheckPrintfHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001170 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001171}
1172
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001173void CheckPrintfHandler::
Ted Kremenek808015a2010-01-29 03:16:21 +00001174HandleIncompleteFormatSpecifier(const char *startSpecifier,
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001175 unsigned specifierLen) {
Ted Kremenek808015a2010-01-29 03:16:21 +00001176 SourceLocation Loc = getLocationOfByte(startSpecifier);
1177 S.Diag(Loc, diag::warn_printf_incomplete_specifier)
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001178 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek808015a2010-01-29 03:16:21 +00001179}
1180
Ted Kremenekefaff192010-02-27 01:41:03 +00001181void
1182CheckPrintfHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1183 analyze_printf::PositionContext p) {
1184 SourceLocation Loc = getLocationOfByte(startPos);
1185 S.Diag(Loc, diag::warn_printf_invalid_positional_specifier)
1186 << (unsigned) p << getFormatSpecifierRange(startPos, posLen);
1187}
1188
1189void CheckPrintfHandler::HandleZeroPosition(const char *startPos,
1190 unsigned posLen) {
1191 SourceLocation Loc = getLocationOfByte(startPos);
1192 S.Diag(Loc, diag::warn_printf_zero_positional_specifier)
1193 << getFormatSpecifierRange(startPos, posLen);
1194}
1195
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001196bool CheckPrintfHandler::
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001197HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS,
1198 const char *startSpecifier,
1199 unsigned specifierLen) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001200
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001201 unsigned argIndex = FS.getArgIndex();
1202 bool keepGoing = true;
1203 if (argIndex < NumDataArgs) {
1204 // Consider the argument coverered, even though the specifier doesn't
1205 // make sense.
1206 CoveredArgs.set(argIndex);
1207 }
1208 else {
1209 // If argIndex exceeds the number of data arguments we
1210 // don't issue a warning because that is just a cascade of warnings (and
1211 // they may have intended '%%' anyway). We don't want to continue processing
1212 // the format string after this point, however, as we will like just get
1213 // gibberish when trying to match arguments.
1214 keepGoing = false;
1215 }
1216
Ted Kremenek808015a2010-01-29 03:16:21 +00001217 const analyze_printf::ConversionSpecifier &CS =
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001218 FS.getConversionSpecifier();
Ted Kremenek808015a2010-01-29 03:16:21 +00001219 SourceLocation Loc = getLocationOfByte(CS.getStart());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001220 S.Diag(Loc, diag::warn_printf_invalid_conversion)
Ted Kremenek808015a2010-01-29 03:16:21 +00001221 << llvm::StringRef(CS.getStart(), CS.getLength())
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001222 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001223
1224 return keepGoing;
Ted Kremenek26ac2e02010-01-29 02:40:24 +00001225}
1226
Ted Kremeneke0e53132010-01-28 23:39:18 +00001227void CheckPrintfHandler::HandleNullChar(const char *nullCharacter) {
1228 // The presence of a null character is likely an error.
1229 S.Diag(getLocationOfByte(nullCharacter),
1230 diag::warn_printf_format_string_contains_null_char)
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001231 << getFormatStringRange();
Ted Kremeneke0e53132010-01-28 23:39:18 +00001232}
1233
Ted Kremenek0d277352010-01-29 01:06:55 +00001234const Expr *CheckPrintfHandler::getDataArg(unsigned i) const {
Ted Kremenek6ee76532010-03-25 03:59:12 +00001235 return TheCall->getArg(FirstDataArg + i);
Ted Kremenek0d277352010-01-29 01:06:55 +00001236}
1237
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001238void CheckPrintfHandler::HandleFlags(const analyze_printf::FormatSpecifier &FS,
1239 llvm::StringRef flag,
1240 llvm::StringRef cspec,
1241 const char *startSpecifier,
1242 unsigned specifierLen) {
1243 const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier();
1244 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_nonsensical_flag)
1245 << flag << cspec << getFormatSpecifierRange(startSpecifier, specifierLen);
1246}
1247
Ted Kremenek0d277352010-01-29 01:06:55 +00001248bool
1249CheckPrintfHandler::HandleAmount(const analyze_printf::OptionalAmount &Amt,
Ted Kremenekefaff192010-02-27 01:41:03 +00001250 unsigned k, const char *startSpecifier,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001251 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001252
1253 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001254 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001255 unsigned argIndex = Amt.getArgIndex();
1256 if (argIndex >= NumDataArgs) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001257 S.Diag(getLocationOfByte(Amt.getStart()),
1258 diag::warn_printf_asterisk_missing_arg)
1259 << k << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001260 // Don't do any more checking. We will just emit
1261 // spurious errors.
1262 return false;
1263 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001264
Ted Kremenek0d277352010-01-29 01:06:55 +00001265 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00001266 // Although not in conformance with C99, we also allow the argument to be
1267 // an 'unsigned int' as that is a reasonably safe case. GCC also
1268 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001269 CoveredArgs.set(argIndex);
1270 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00001271 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001272
1273 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
1274 assert(ATR.isValid());
1275
1276 if (!ATR.matchesType(S.Context, T)) {
Ted Kremenekefaff192010-02-27 01:41:03 +00001277 S.Diag(getLocationOfByte(Amt.getStart()),
1278 diag::warn_printf_asterisk_wrong_type)
1279 << k
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001280 << ATR.getRepresentativeType(S.Context) << T
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001281 << getFormatSpecifierRange(startSpecifier, specifierLen)
1282 << Arg->getSourceRange();
Ted Kremenek0d277352010-01-29 01:06:55 +00001283 // Don't do any more checking. We will just emit
1284 // spurious errors.
1285 return false;
1286 }
1287 }
1288 }
1289 return true;
1290}
Ted Kremenek0d277352010-01-29 01:06:55 +00001291
Ted Kremeneke0e53132010-01-28 23:39:18 +00001292bool
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001293CheckPrintfHandler::HandleFormatSpecifier(const analyze_printf::FormatSpecifier
1294 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001295 const char *startSpecifier,
1296 unsigned specifierLen) {
1297
Ted Kremenekefaff192010-02-27 01:41:03 +00001298 using namespace analyze_printf;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001299 const ConversionSpecifier &CS = FS.getConversionSpecifier();
1300
Ted Kremenekefaff192010-02-27 01:41:03 +00001301 if (atFirstArg) {
1302 atFirstArg = false;
1303 usesPositionalArgs = FS.usesPositionalArg();
1304 }
1305 else if (usesPositionalArgs != FS.usesPositionalArg()) {
1306 // Cannot mix-and-match positional and non-positional arguments.
1307 S.Diag(getLocationOfByte(CS.getStart()),
1308 diag::warn_printf_mix_positional_nonpositional_args)
1309 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremenek0d277352010-01-29 01:06:55 +00001310 return false;
1311 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001312
Ted Kremenekefaff192010-02-27 01:41:03 +00001313 // First check if the field width, precision, and conversion specifier
1314 // have matching data arguments.
1315 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
1316 startSpecifier, specifierLen)) {
1317 return false;
1318 }
1319
1320 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
1321 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00001322 return false;
1323 }
1324
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001325 if (!CS.consumesDataArgument()) {
1326 // FIXME: Technically specifying a precision or field width here
1327 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001328 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001329 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001330
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001331 // Consume the argument.
1332 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00001333 if (argIndex < NumDataArgs) {
1334 // The check to see if the argIndex is valid will come later.
1335 // We set the bit here because we may exit early from this
1336 // function if we encounter some other error.
1337 CoveredArgs.set(argIndex);
1338 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001339
1340 // Check for using an Objective-C specific conversion specifier
1341 // in a non-ObjC literal.
1342 if (!IsObjCLiteral && CS.isObjCArg()) {
1343 return HandleInvalidConversionSpecifier(FS, startSpecifier, specifierLen);
1344 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001345
Ted Kremeneke82d8042010-01-29 01:35:25 +00001346 // Are we using '%n'? Issue a warning about this being
1347 // a possible security issue.
1348 if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) {
1349 S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001350 << getFormatSpecifierRange(startSpecifier, specifierLen);
Ted Kremeneke82d8042010-01-29 01:35:25 +00001351 // Continue checking the other format specifiers.
1352 return true;
1353 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001354
1355 if (CS.getKind() == ConversionSpecifier::VoidPtrArg) {
1356 if (FS.getPrecision().getHowSpecified() != OptionalAmount::NotSpecified)
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001357 S.Diag(getLocationOfByte(CS.getStart()),
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001358 diag::warn_printf_nonsensical_precision)
1359 << CS.getCharacters()
1360 << getFormatSpecifierRange(startSpecifier, specifierLen);
1361 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001362 if (CS.getKind() == ConversionSpecifier::VoidPtrArg ||
1363 CS.getKind() == ConversionSpecifier::CStrArg) {
Ted Kremenek5c41ee82010-02-11 09:27:41 +00001364 // FIXME: Instead of using "0", "+", etc., eventually get them from
1365 // the FormatSpecifier.
1366 if (FS.hasLeadingZeros())
1367 HandleFlags(FS, "0", CS.getCharacters(), startSpecifier, specifierLen);
1368 if (FS.hasPlusPrefix())
1369 HandleFlags(FS, "+", CS.getCharacters(), startSpecifier, specifierLen);
1370 if (FS.hasSpacePrefix())
1371 HandleFlags(FS, " ", CS.getCharacters(), startSpecifier, specifierLen);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001372 }
1373
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001374 // The remaining checks depend on the data arguments.
1375 if (HasVAListArg)
1376 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001377
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001378 if (argIndex >= NumDataArgs) {
Ted Kremenek6ee76532010-03-25 03:59:12 +00001379 if (FS.usesPositionalArg()) {
1380 S.Diag(getLocationOfByte(CS.getStart()),
1381 diag::warn_printf_positional_arg_exceeds_data_args)
1382 << (argIndex+1) << NumDataArgs
1383 << getFormatSpecifierRange(startSpecifier, specifierLen);
1384 }
1385 else {
1386 S.Diag(getLocationOfByte(CS.getStart()),
1387 diag::warn_printf_insufficient_data_args)
1388 << getFormatSpecifierRange(startSpecifier, specifierLen);
1389 }
1390
Ted Kremenekda51f0d2010-01-29 01:43:31 +00001391 // Don't do any more checking.
1392 return false;
1393 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001394
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001395 // Now type check the data expression that matches the
1396 // format specifier.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001397 const Expr *Ex = getDataArg(argIndex);
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001398 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001399 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
1400 // Check if we didn't match because of an implicit cast from a 'char'
1401 // or 'short' to an 'int'. This is done because printf is a varargs
1402 // function.
1403 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
1404 if (ICE->getType() == S.Context.IntTy)
1405 if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
1406 return true;
Ted Kremenek105d41c2010-02-01 19:38:10 +00001407
Tom Care3bfc5f42010-06-09 04:11:11 +00001408 // We may be able to offer a FixItHint if it is a supported type.
1409 FormatSpecifier fixedFS = FS;
1410 bool success = fixedFS.fixType(Ex->getType());
1411
1412 if (success) {
1413 // Get the fix string from the fixed format specifier
1414 llvm::SmallString<128> buf;
1415 llvm::raw_svector_ostream os(buf);
1416 fixedFS.toString(os);
1417
1418 S.Diag(getLocationOfByte(CS.getStart()),
1419 diag::warn_printf_conversion_argument_type_mismatch)
1420 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1421 << getFormatSpecifierRange(startSpecifier, specifierLen)
1422 << Ex->getSourceRange()
1423 << FixItHint::CreateReplacement(
1424 getFormatSpecifierRange(startSpecifier, specifierLen),
1425 os.str());
1426 }
1427 else {
1428 S.Diag(getLocationOfByte(CS.getStart()),
1429 diag::warn_printf_conversion_argument_type_mismatch)
1430 << ATR.getRepresentativeType(S.Context) << Ex->getType()
1431 << getFormatSpecifierRange(startSpecifier, specifierLen)
1432 << Ex->getSourceRange();
1433 }
Ted Kremenekd635c5f2010-01-30 00:49:51 +00001434 }
Ted Kremeneke0e53132010-01-28 23:39:18 +00001435
1436 return true;
1437}
1438
Ted Kremenek07d161f2010-01-29 01:50:07 +00001439void CheckPrintfHandler::DoneProcessing() {
1440 // Does the number of data arguments exceed the number of
1441 // format conversions in the format string?
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001442 if (!HasVAListArg) {
1443 // Find any arguments that weren't covered.
1444 CoveredArgs.flip();
1445 signed notCoveredArg = CoveredArgs.find_first();
1446 if (notCoveredArg >= 0) {
1447 assert((unsigned)notCoveredArg < NumDataArgs);
1448 S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
1449 diag::warn_printf_data_arg_not_used)
1450 << getFormatStringRange();
1451 }
1452 }
Ted Kremenek07d161f2010-01-29 01:50:07 +00001453}
Ted Kremeneke0e53132010-01-28 23:39:18 +00001454
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001455void Sema::CheckPrintfString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00001456 const Expr *OrigFormatExpr,
1457 const CallExpr *TheCall, bool HasVAListArg,
1458 unsigned format_idx, unsigned firstDataArg) {
1459
Ted Kremeneke0e53132010-01-28 23:39:18 +00001460 // CHECK: is the format string a wide literal?
1461 if (FExpr->isWide()) {
1462 Diag(FExpr->getLocStart(),
1463 diag::warn_printf_format_string_is_wide_literal)
1464 << OrigFormatExpr->getSourceRange();
1465 return;
1466 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001467
Ted Kremeneke0e53132010-01-28 23:39:18 +00001468 // Str - The format string. NOTE: this is NOT null-terminated!
1469 const char *Str = FExpr->getStrData();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001470
Ted Kremeneke0e53132010-01-28 23:39:18 +00001471 // CHECK: empty format string?
1472 unsigned StrLen = FExpr->getByteLength();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001473
Ted Kremeneke0e53132010-01-28 23:39:18 +00001474 if (StrLen == 0) {
1475 Diag(FExpr->getLocStart(), diag::warn_printf_empty_format_string)
1476 << OrigFormatExpr->getSourceRange();
1477 return;
1478 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001479
Ted Kremenek6ee76532010-03-25 03:59:12 +00001480 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001481 TheCall->getNumArgs() - firstDataArg,
Ted Kremenek0d277352010-01-29 01:06:55 +00001482 isa<ObjCStringLiteral>(OrigFormatExpr), Str,
1483 HasVAListArg, TheCall, format_idx);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001484
Ted Kremenek74d56a12010-02-04 20:46:58 +00001485 if (!analyze_printf::ParseFormatString(H, Str, Str + StrLen))
Ted Kremenek808015a2010-01-29 03:16:21 +00001486 H.DoneProcessing();
Ted Kremenekce7024e2010-01-28 01:18:22 +00001487}
1488
Ted Kremenek06de2762007-08-17 16:46:58 +00001489//===--- CHECK: Return Address of Stack Variable --------------------------===//
1490
1491static DeclRefExpr* EvalVal(Expr *E);
1492static DeclRefExpr* EvalAddr(Expr* E);
1493
1494/// CheckReturnStackAddr - Check if a return statement returns the address
1495/// of a stack variable.
1496void
1497Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
1498 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00001499
Ted Kremenek06de2762007-08-17 16:46:58 +00001500 // Perform checking for returned stack addresses.
Steve Naroffdd972f22008-09-05 22:11:13 +00001501 if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001502 if (DeclRefExpr *DR = EvalAddr(RetValExp))
Chris Lattner3c73c412008-11-19 08:23:25 +00001503 Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
Chris Lattner08631c52008-11-23 21:45:46 +00001504 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001505
Steve Naroffc50a4a52008-09-16 22:25:10 +00001506 // Skip over implicit cast expressions when checking for block expressions.
Chris Lattner4ca606e2009-09-08 00:36:37 +00001507 RetValExp = RetValExp->IgnoreParenCasts();
Steve Naroffc50a4a52008-09-16 22:25:10 +00001508
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001509 if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
Mike Stump397195b2009-04-17 00:09:41 +00001510 if (C->hasBlockDeclRefExprs())
1511 Diag(C->getLocStart(), diag::err_ret_local_block)
1512 << C->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001513
Chris Lattner9e6b37a2009-10-30 04:01:58 +00001514 if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
1515 Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
1516 << ALE->getSourceRange();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001517
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001518 } else if (lhsType->isReferenceType()) {
1519 // Perform checking for stack values returned by reference.
Douglas Gregor49badde2008-10-27 19:41:14 +00001520 // Check for a reference to the stack
1521 if (DeclRefExpr *DR = EvalVal(RetValExp))
Chris Lattnerdcd5ef12008-11-19 05:27:50 +00001522 Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
Chris Lattner08631c52008-11-23 21:45:46 +00001523 << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
Ted Kremenek06de2762007-08-17 16:46:58 +00001524 }
1525}
1526
1527/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
1528/// check if the expression in a return statement evaluates to an address
1529/// to a location on the stack. The recursion is used to traverse the
1530/// AST of the return expression, with recursion backtracking when we
1531/// encounter a subexpression that (1) clearly does not lead to the address
1532/// of a stack variable or (2) is something we cannot determine leads to
1533/// the address of a stack variable based on such local checking.
1534///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001535/// EvalAddr processes expressions that are pointers that are used as
1536/// references (and not L-values). EvalVal handles all other values.
Mike Stump1eb44332009-09-09 15:08:12 +00001537/// At the base case of the recursion is a check for a DeclRefExpr* in
Ted Kremenek06de2762007-08-17 16:46:58 +00001538/// the refers to a stack variable.
1539///
1540/// This implementation handles:
1541///
1542/// * pointer-to-pointer casts
1543/// * implicit conversions from array references to pointers
1544/// * taking the address of fields
1545/// * arbitrary interplay between "&" and "*" operators
1546/// * pointer arithmetic from an address of a stack variable
1547/// * taking the address of an array element where the array is on the stack
1548static DeclRefExpr* EvalAddr(Expr *E) {
Ted Kremenek06de2762007-08-17 16:46:58 +00001549 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00001550 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00001551 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00001552 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001553 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00001554
Ted Kremenek06de2762007-08-17 16:46:58 +00001555 // Our "symbolic interpreter" is just a dispatch off the currently
1556 // viewed AST node. We then recursively traverse the AST by calling
1557 // EvalAddr and EvalVal appropriately.
1558 switch (E->getStmtClass()) {
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001559 case Stmt::ParenExprClass:
1560 // Ignore parentheses.
1561 return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
Ted Kremenek06de2762007-08-17 16:46:58 +00001562
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001563 case Stmt::UnaryOperatorClass: {
1564 // The only unary operator that make sense to handle here
1565 // is AddrOf. All others don't make sense as pointers.
1566 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001567
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001568 if (U->getOpcode() == UnaryOperator::AddrOf)
1569 return EvalVal(U->getSubExpr());
1570 else
Ted Kremenek06de2762007-08-17 16:46:58 +00001571 return NULL;
1572 }
Mike Stump1eb44332009-09-09 15:08:12 +00001573
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001574 case Stmt::BinaryOperatorClass: {
1575 // Handle pointer arithmetic. All other binary operators are not valid
1576 // in this context.
1577 BinaryOperator *B = cast<BinaryOperator>(E);
1578 BinaryOperator::Opcode op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00001579
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001580 if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
1581 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001582
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001583 Expr *Base = B->getLHS();
1584
1585 // Determine which argument is the real pointer base. It could be
1586 // the RHS argument instead of the LHS.
1587 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00001588
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001589 assert (Base->getType()->isPointerType());
1590 return EvalAddr(Base);
1591 }
Steve Naroff61f40a22008-09-10 19:17:48 +00001592
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001593 // For conditional operators we need to see if either the LHS or RHS are
1594 // valid DeclRefExpr*s. If one of them is valid, we return it.
1595 case Stmt::ConditionalOperatorClass: {
1596 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001597
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001598 // Handle the GNU extension for missing LHS.
1599 if (Expr *lhsExpr = C->getLHS())
1600 if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
1601 return LHS;
1602
1603 return EvalAddr(C->getRHS());
1604 }
Mike Stump1eb44332009-09-09 15:08:12 +00001605
Ted Kremenek54b52742008-08-07 00:49:01 +00001606 // For casts, we need to handle conversions from arrays to
1607 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00001608 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00001609 case Stmt::CStyleCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001610 case Stmt::CXXFunctionalCastExprClass: {
Argyrios Kyrtzidis0835a3c2008-08-18 23:01:59 +00001611 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
Ted Kremenek54b52742008-08-07 00:49:01 +00001612 QualType T = SubExpr->getType();
Mike Stump1eb44332009-09-09 15:08:12 +00001613
Steve Naroffdd972f22008-09-05 22:11:13 +00001614 if (SubExpr->getType()->isPointerType() ||
1615 SubExpr->getType()->isBlockPointerType() ||
1616 SubExpr->getType()->isObjCQualifiedIdType())
Ted Kremenek54b52742008-08-07 00:49:01 +00001617 return EvalAddr(SubExpr);
1618 else if (T->isArrayType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001619 return EvalVal(SubExpr);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001620 else
Ted Kremenek54b52742008-08-07 00:49:01 +00001621 return 0;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001622 }
Mike Stump1eb44332009-09-09 15:08:12 +00001623
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001624 // C++ casts. For dynamic casts, static casts, and const casts, we
1625 // are always converting from a pointer-to-pointer, so we just blow
Douglas Gregor49badde2008-10-27 19:41:14 +00001626 // through the cast. In the case the dynamic cast doesn't fail (and
1627 // return NULL), we take the conservative route and report cases
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001628 // where we return the address of a stack variable. For Reinterpre
Douglas Gregor49badde2008-10-27 19:41:14 +00001629 // FIXME: The comment about is wrong; we're not always converting
1630 // from pointer to pointer. I'm guessing that this code should also
Mike Stump1eb44332009-09-09 15:08:12 +00001631 // handle references to objects.
1632 case Stmt::CXXStaticCastExprClass:
1633 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00001634 case Stmt::CXXConstCastExprClass:
1635 case Stmt::CXXReinterpretCastExprClass: {
1636 Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
Steve Naroffdd972f22008-09-05 22:11:13 +00001637 if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001638 return EvalAddr(S);
1639 else
1640 return NULL;
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001641 }
Mike Stump1eb44332009-09-09 15:08:12 +00001642
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00001643 // Everything else: we simply don't reason about them.
1644 default:
1645 return NULL;
1646 }
Ted Kremenek06de2762007-08-17 16:46:58 +00001647}
Mike Stump1eb44332009-09-09 15:08:12 +00001648
Ted Kremenek06de2762007-08-17 16:46:58 +00001649
1650/// EvalVal - This function is complements EvalAddr in the mutual recursion.
1651/// See the comments for EvalAddr for more details.
1652static DeclRefExpr* EvalVal(Expr *E) {
Mike Stump1eb44332009-09-09 15:08:12 +00001653
Ted Kremeneke8c600f2007-08-28 17:02:55 +00001654 // We should only be called for evaluating non-pointer expressions, or
1655 // expressions with a pointer type that are not used as references but instead
1656 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00001657
Ted Kremenek06de2762007-08-17 16:46:58 +00001658 // Our "symbolic interpreter" is just a dispatch off the currently
1659 // viewed AST node. We then recursively traverse the AST by calling
1660 // EvalAddr and EvalVal appropriately.
1661 switch (E->getStmtClass()) {
Douglas Gregora2813ce2009-10-23 18:54:35 +00001662 case Stmt::DeclRefExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001663 // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
1664 // at code that refers to a variable's name. We check if it has local
1665 // storage within the function, and if so, return the expression.
1666 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001667
Ted Kremenek06de2762007-08-17 16:46:58 +00001668 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
Mike Stump1eb44332009-09-09 15:08:12 +00001669 if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
1670
Ted Kremenek06de2762007-08-17 16:46:58 +00001671 return NULL;
1672 }
Mike Stump1eb44332009-09-09 15:08:12 +00001673
Ted Kremenek06de2762007-08-17 16:46:58 +00001674 case Stmt::ParenExprClass:
1675 // Ignore parentheses.
1676 return EvalVal(cast<ParenExpr>(E)->getSubExpr());
Mike Stump1eb44332009-09-09 15:08:12 +00001677
Ted Kremenek06de2762007-08-17 16:46:58 +00001678 case Stmt::UnaryOperatorClass: {
1679 // The only unary operator that make sense to handle here
1680 // is Deref. All others don't resolve to a "name." This includes
1681 // handling all sorts of rvalues passed to a unary operator.
1682 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001683
Ted Kremenek06de2762007-08-17 16:46:58 +00001684 if (U->getOpcode() == UnaryOperator::Deref)
1685 return EvalAddr(U->getSubExpr());
1686
1687 return NULL;
1688 }
Mike Stump1eb44332009-09-09 15:08:12 +00001689
Ted Kremenek06de2762007-08-17 16:46:58 +00001690 case Stmt::ArraySubscriptExprClass: {
1691 // Array subscripts are potential references to data on the stack. We
1692 // retrieve the DeclRefExpr* for the array variable if it indeed
1693 // has local storage.
Ted Kremenek23245122007-08-20 16:18:38 +00001694 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
Ted Kremenek06de2762007-08-17 16:46:58 +00001695 }
Mike Stump1eb44332009-09-09 15:08:12 +00001696
Ted Kremenek06de2762007-08-17 16:46:58 +00001697 case Stmt::ConditionalOperatorClass: {
1698 // For conditional operators we need to see if either the LHS or RHS are
1699 // non-NULL DeclRefExpr's. If one is non-NULL, we return it.
1700 ConditionalOperator *C = cast<ConditionalOperator>(E);
1701
Anders Carlsson39073232007-11-30 19:04:31 +00001702 // Handle the GNU extension for missing LHS.
1703 if (Expr *lhsExpr = C->getLHS())
1704 if (DeclRefExpr *LHS = EvalVal(lhsExpr))
1705 return LHS;
1706
1707 return EvalVal(C->getRHS());
Ted Kremenek06de2762007-08-17 16:46:58 +00001708 }
Mike Stump1eb44332009-09-09 15:08:12 +00001709
Ted Kremenek06de2762007-08-17 16:46:58 +00001710 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00001711 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00001712 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001713
Ted Kremenek06de2762007-08-17 16:46:58 +00001714 // Check for indirect access. We only want direct field accesses.
1715 if (!M->isArrow())
1716 return EvalVal(M->getBase());
1717 else
1718 return NULL;
1719 }
Mike Stump1eb44332009-09-09 15:08:12 +00001720
Ted Kremenek06de2762007-08-17 16:46:58 +00001721 // Everything else: we simply don't reason about them.
1722 default:
1723 return NULL;
1724 }
1725}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001726
1727//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
1728
1729/// Check for comparisons of floating point operands using != and ==.
1730/// Issue a warning if these are no self-comparisons, as they are not likely
1731/// to do what the programmer intended.
1732void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
1733 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00001734
Ted Kremenek4e99a5f2008-01-17 16:57:34 +00001735 Expr* LeftExprSansParen = lex->IgnoreParens();
Ted Kremenek32e97b62008-01-17 17:55:13 +00001736 Expr* RightExprSansParen = rex->IgnoreParens();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001737
1738 // Special case: check for x == x (which is OK).
1739 // Do not emit warnings for such cases.
1740 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
1741 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
1742 if (DRL->getDecl() == DRR->getDecl())
1743 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001744
1745
Ted Kremenek1b500bb2007-11-29 00:59:04 +00001746 // Special case: check for comparisons against literals that can be exactly
1747 // represented by APFloat. In such cases, do not emit a warning. This
1748 // is a heuristic: often comparison against such literals are used to
1749 // detect if a value in a variable has not changed. This clearly can
1750 // lead to false negatives.
1751 if (EmitWarning) {
1752 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
1753 if (FLL->isExact())
1754 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001755 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00001756 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
1757 if (FLR->isExact())
1758 EmitWarning = false;
1759 }
1760 }
Mike Stump1eb44332009-09-09 15:08:12 +00001761
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001762 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00001763 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001764 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00001765 if (CL->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001766 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001767
Sebastian Redl0eb23302009-01-19 00:08:26 +00001768 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001769 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Douglas Gregor3c385e52009-02-14 18:57:46 +00001770 if (CR->isBuiltinCall(Context))
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001771 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00001772
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001773 // Emit the diagnostic.
1774 if (EmitWarning)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001775 Diag(loc, diag::warn_floatingpoint_eq)
1776 << lex->getSourceRange() << rex->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00001777}
John McCallba26e582010-01-04 23:21:16 +00001778
John McCallf2370c92010-01-06 05:24:50 +00001779//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
1780//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00001781
John McCallf2370c92010-01-06 05:24:50 +00001782namespace {
John McCallba26e582010-01-04 23:21:16 +00001783
John McCallf2370c92010-01-06 05:24:50 +00001784/// Structure recording the 'active' range of an integer-valued
1785/// expression.
1786struct IntRange {
1787 /// The number of bits active in the int.
1788 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00001789
John McCallf2370c92010-01-06 05:24:50 +00001790 /// True if the int is known not to have negative values.
1791 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00001792
John McCallf2370c92010-01-06 05:24:50 +00001793 IntRange() {}
1794 IntRange(unsigned Width, bool NonNegative)
1795 : Width(Width), NonNegative(NonNegative)
1796 {}
John McCallba26e582010-01-04 23:21:16 +00001797
John McCallf2370c92010-01-06 05:24:50 +00001798 // Returns the range of the bool type.
1799 static IntRange forBoolType() {
1800 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00001801 }
1802
John McCallf2370c92010-01-06 05:24:50 +00001803 // Returns the range of an integral type.
1804 static IntRange forType(ASTContext &C, QualType T) {
1805 return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00001806 }
1807
John McCallf2370c92010-01-06 05:24:50 +00001808 // Returns the range of an integeral type based on its canonical
1809 // representation.
1810 static IntRange forCanonicalType(ASTContext &C, const Type *T) {
1811 assert(T->isCanonicalUnqualified());
1812
1813 if (const VectorType *VT = dyn_cast<VectorType>(T))
1814 T = VT->getElementType().getTypePtr();
1815 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
1816 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00001817
1818 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
1819 EnumDecl *Enum = ET->getDecl();
1820 unsigned NumPositive = Enum->getNumPositiveBits();
1821 unsigned NumNegative = Enum->getNumNegativeBits();
1822
1823 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
1824 }
John McCallf2370c92010-01-06 05:24:50 +00001825
1826 const BuiltinType *BT = cast<BuiltinType>(T);
1827 assert(BT->isInteger());
1828
1829 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
1830 }
1831
1832 // Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00001833 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00001834 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00001835 L.NonNegative && R.NonNegative);
1836 }
1837
1838 // Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00001839 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00001840 return IntRange(std::min(L.Width, R.Width),
1841 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00001842 }
1843};
1844
1845IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
1846 if (value.isSigned() && value.isNegative())
1847 return IntRange(value.getMinSignedBits(), false);
1848
1849 if (value.getBitWidth() > MaxWidth)
1850 value.trunc(MaxWidth);
1851
1852 // isNonNegative() just checks the sign bit without considering
1853 // signedness.
1854 return IntRange(value.getActiveBits(), true);
1855}
1856
John McCall0acc3112010-01-06 22:57:21 +00001857IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
John McCallf2370c92010-01-06 05:24:50 +00001858 unsigned MaxWidth) {
1859 if (result.isInt())
1860 return GetValueRange(C, result.getInt(), MaxWidth);
1861
1862 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00001863 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
1864 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
1865 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
1866 R = IntRange::join(R, El);
1867 }
John McCallf2370c92010-01-06 05:24:50 +00001868 return R;
1869 }
1870
1871 if (result.isComplexInt()) {
1872 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
1873 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
1874 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00001875 }
1876
1877 // This can happen with lossless casts to intptr_t of "based" lvalues.
1878 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00001879 // FIXME: The only reason we need to pass the type in here is to get
1880 // the sign right on this one case. It would be nice if APValue
1881 // preserved this.
John McCallf2370c92010-01-06 05:24:50 +00001882 assert(result.isLValue());
John McCall0acc3112010-01-06 22:57:21 +00001883 return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
John McCall51313c32010-01-04 23:31:57 +00001884}
John McCallf2370c92010-01-06 05:24:50 +00001885
1886/// Pseudo-evaluate the given integer expression, estimating the
1887/// range of values it might take.
1888///
1889/// \param MaxWidth - the width to which the value will be truncated
1890IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
1891 E = E->IgnoreParens();
1892
1893 // Try a full evaluation first.
1894 Expr::EvalResult result;
1895 if (E->Evaluate(result, C))
John McCall0acc3112010-01-06 22:57:21 +00001896 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00001897
1898 // I think we only want to look through implicit casts here; if the
1899 // user has an explicit widening cast, we should treat the value as
1900 // being of the new, wider type.
1901 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
1902 if (CE->getCastKind() == CastExpr::CK_NoOp)
1903 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
1904
1905 IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
1906
John McCall60fad452010-01-06 22:07:33 +00001907 bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
1908 if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
1909 isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
1910
John McCallf2370c92010-01-06 05:24:50 +00001911 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00001912 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00001913 return OutputTypeRange;
1914
1915 IntRange SubRange
1916 = GetExprRange(C, CE->getSubExpr(),
1917 std::min(MaxWidth, OutputTypeRange.Width));
1918
1919 // Bail out if the subexpr's range is as wide as the cast type.
1920 if (SubRange.Width >= OutputTypeRange.Width)
1921 return OutputTypeRange;
1922
1923 // Otherwise, we take the smaller width, and we're non-negative if
1924 // either the output type or the subexpr is.
1925 return IntRange(SubRange.Width,
1926 SubRange.NonNegative || OutputTypeRange.NonNegative);
1927 }
1928
1929 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
1930 // If we can fold the condition, just take that operand.
1931 bool CondResult;
1932 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
1933 return GetExprRange(C, CondResult ? CO->getTrueExpr()
1934 : CO->getFalseExpr(),
1935 MaxWidth);
1936
1937 // Otherwise, conservatively merge.
1938 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
1939 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
1940 return IntRange::join(L, R);
1941 }
1942
1943 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
1944 switch (BO->getOpcode()) {
1945
1946 // Boolean-valued operations are single-bit and positive.
1947 case BinaryOperator::LAnd:
1948 case BinaryOperator::LOr:
1949 case BinaryOperator::LT:
1950 case BinaryOperator::GT:
1951 case BinaryOperator::LE:
1952 case BinaryOperator::GE:
1953 case BinaryOperator::EQ:
1954 case BinaryOperator::NE:
1955 return IntRange::forBoolType();
1956
John McCallc0cd21d2010-02-23 19:22:29 +00001957 // The type of these compound assignments is the type of the LHS,
1958 // so the RHS is not necessarily an integer.
1959 case BinaryOperator::MulAssign:
1960 case BinaryOperator::DivAssign:
1961 case BinaryOperator::RemAssign:
1962 case BinaryOperator::AddAssign:
1963 case BinaryOperator::SubAssign:
1964 return IntRange::forType(C, E->getType());
1965
John McCallf2370c92010-01-06 05:24:50 +00001966 // Operations with opaque sources are black-listed.
1967 case BinaryOperator::PtrMemD:
1968 case BinaryOperator::PtrMemI:
1969 return IntRange::forType(C, E->getType());
1970
John McCall60fad452010-01-06 22:07:33 +00001971 // Bitwise-and uses the *infinum* of the two source ranges.
1972 case BinaryOperator::And:
John McCallc0cd21d2010-02-23 19:22:29 +00001973 case BinaryOperator::AndAssign:
John McCall60fad452010-01-06 22:07:33 +00001974 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
1975 GetExprRange(C, BO->getRHS(), MaxWidth));
1976
John McCallf2370c92010-01-06 05:24:50 +00001977 // Left shift gets black-listed based on a judgement call.
1978 case BinaryOperator::Shl:
John McCall3aae6092010-04-07 01:14:35 +00001979 // ...except that we want to treat '1 << (blah)' as logically
1980 // positive. It's an important idiom.
1981 if (IntegerLiteral *I
1982 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
1983 if (I->getValue() == 1) {
1984 IntRange R = IntRange::forType(C, E->getType());
1985 return IntRange(R.Width, /*NonNegative*/ true);
1986 }
1987 }
1988 // fallthrough
1989
John McCallc0cd21d2010-02-23 19:22:29 +00001990 case BinaryOperator::ShlAssign:
John McCallf2370c92010-01-06 05:24:50 +00001991 return IntRange::forType(C, E->getType());
1992
John McCall60fad452010-01-06 22:07:33 +00001993 // Right shift by a constant can narrow its left argument.
John McCallc0cd21d2010-02-23 19:22:29 +00001994 case BinaryOperator::Shr:
1995 case BinaryOperator::ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00001996 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
1997
1998 // If the shift amount is a positive constant, drop the width by
1999 // that much.
2000 llvm::APSInt shift;
2001 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
2002 shift.isNonNegative()) {
2003 unsigned zext = shift.getZExtValue();
2004 if (zext >= L.Width)
2005 L.Width = (L.NonNegative ? 0 : 1);
2006 else
2007 L.Width -= zext;
2008 }
2009
2010 return L;
2011 }
2012
2013 // Comma acts as its right operand.
John McCallf2370c92010-01-06 05:24:50 +00002014 case BinaryOperator::Comma:
2015 return GetExprRange(C, BO->getRHS(), MaxWidth);
2016
John McCall60fad452010-01-06 22:07:33 +00002017 // Black-list pointer subtractions.
John McCallf2370c92010-01-06 05:24:50 +00002018 case BinaryOperator::Sub:
2019 if (BO->getLHS()->getType()->isPointerType())
2020 return IntRange::forType(C, E->getType());
2021 // fallthrough
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002022
John McCallf2370c92010-01-06 05:24:50 +00002023 default:
2024 break;
2025 }
2026
2027 // Treat every other operator as if it were closed on the
2028 // narrowest type that encompasses both operands.
2029 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
2030 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
2031 return IntRange::join(L, R);
2032 }
2033
2034 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
2035 switch (UO->getOpcode()) {
2036 // Boolean-valued operations are white-listed.
2037 case UnaryOperator::LNot:
2038 return IntRange::forBoolType();
2039
2040 // Operations with opaque sources are black-listed.
2041 case UnaryOperator::Deref:
2042 case UnaryOperator::AddrOf: // should be impossible
2043 case UnaryOperator::OffsetOf:
2044 return IntRange::forType(C, E->getType());
2045
2046 default:
2047 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
2048 }
2049 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00002050
2051 if (dyn_cast<OffsetOfExpr>(E)) {
2052 IntRange::forType(C, E->getType());
2053 }
John McCallf2370c92010-01-06 05:24:50 +00002054
2055 FieldDecl *BitField = E->getBitField();
2056 if (BitField) {
2057 llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
2058 unsigned BitWidth = BitWidthAP.getZExtValue();
2059
2060 return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
2061 }
2062
2063 return IntRange::forType(C, E->getType());
2064}
John McCall51313c32010-01-04 23:31:57 +00002065
John McCall323ed742010-05-06 08:58:33 +00002066IntRange GetExprRange(ASTContext &C, Expr *E) {
2067 return GetExprRange(C, E, C.getIntWidth(E->getType()));
2068}
2069
John McCall51313c32010-01-04 23:31:57 +00002070/// Checks whether the given value, which currently has the given
2071/// source semantics, has the same value when coerced through the
2072/// target semantics.
John McCallf2370c92010-01-06 05:24:50 +00002073bool IsSameFloatAfterCast(const llvm::APFloat &value,
2074 const llvm::fltSemantics &Src,
2075 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002076 llvm::APFloat truncated = value;
2077
2078 bool ignored;
2079 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
2080 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
2081
2082 return truncated.bitwiseIsEqual(value);
2083}
2084
2085/// Checks whether the given value, which currently has the given
2086/// source semantics, has the same value when coerced through the
2087/// target semantics.
2088///
2089/// The value might be a vector of floats (or a complex number).
John McCallf2370c92010-01-06 05:24:50 +00002090bool IsSameFloatAfterCast(const APValue &value,
2091 const llvm::fltSemantics &Src,
2092 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00002093 if (value.isFloat())
2094 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
2095
2096 if (value.isVector()) {
2097 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
2098 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
2099 return false;
2100 return true;
2101 }
2102
2103 assert(value.isComplexFloat());
2104 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
2105 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
2106}
2107
John McCall323ed742010-05-06 08:58:33 +00002108void AnalyzeImplicitConversions(Sema &S, Expr *E);
2109
2110bool IsZero(Sema &S, Expr *E) {
2111 llvm::APSInt Value;
2112 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
2113}
2114
2115void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
2116 BinaryOperator::Opcode op = E->getOpcode();
2117 if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
2118 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2119 << "< 0" << "false"
2120 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2121 } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
2122 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
2123 << ">= 0" << "true"
2124 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2125 } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
2126 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2127 << "0 >" << "false"
2128 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2129 } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
2130 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
2131 << "0 <=" << "true"
2132 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
2133 }
2134}
2135
2136/// Analyze the operands of the given comparison. Implements the
2137/// fallback case from AnalyzeComparison.
2138void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
2139 AnalyzeImplicitConversions(S, E->getLHS());
2140 AnalyzeImplicitConversions(S, E->getRHS());
2141}
John McCall51313c32010-01-04 23:31:57 +00002142
John McCallba26e582010-01-04 23:21:16 +00002143/// \brief Implements -Wsign-compare.
2144///
2145/// \param lex the left-hand expression
2146/// \param rex the right-hand expression
2147/// \param OpLoc the location of the joining operator
John McCalld1b47bf2010-03-11 19:43:18 +00002148/// \param BinOpc binary opcode or 0
John McCall323ed742010-05-06 08:58:33 +00002149void AnalyzeComparison(Sema &S, BinaryOperator *E) {
2150 // The type the comparison is being performed in.
2151 QualType T = E->getLHS()->getType();
2152 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
2153 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00002154
John McCall323ed742010-05-06 08:58:33 +00002155 // We don't do anything special if this isn't an unsigned integral
2156 // comparison: we're only interested in integral comparisons, and
2157 // signed comparisons only happen in cases we don't care to warn about.
2158 if (!T->isUnsignedIntegerType())
2159 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00002160
John McCall323ed742010-05-06 08:58:33 +00002161 Expr *lex = E->getLHS()->IgnoreParenImpCasts();
2162 Expr *rex = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00002163
John McCall323ed742010-05-06 08:58:33 +00002164 // Check to see if one of the (unmodified) operands is of different
2165 // signedness.
2166 Expr *signedOperand, *unsignedOperand;
2167 if (lex->getType()->isSignedIntegerType()) {
2168 assert(!rex->getType()->isSignedIntegerType() &&
2169 "unsigned comparison between two signed integer expressions?");
2170 signedOperand = lex;
2171 unsignedOperand = rex;
2172 } else if (rex->getType()->isSignedIntegerType()) {
2173 signedOperand = rex;
2174 unsignedOperand = lex;
John McCallba26e582010-01-04 23:21:16 +00002175 } else {
John McCall323ed742010-05-06 08:58:33 +00002176 CheckTrivialUnsignedComparison(S, E);
2177 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002178 }
2179
John McCall323ed742010-05-06 08:58:33 +00002180 // Otherwise, calculate the effective range of the signed operand.
2181 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00002182
John McCall323ed742010-05-06 08:58:33 +00002183 // Go ahead and analyze implicit conversions in the operands. Note
2184 // that we skip the implicit conversions on both sides.
2185 AnalyzeImplicitConversions(S, lex);
2186 AnalyzeImplicitConversions(S, rex);
John McCallba26e582010-01-04 23:21:16 +00002187
John McCall323ed742010-05-06 08:58:33 +00002188 // If the signed range is non-negative, -Wsign-compare won't fire,
2189 // but we should still check for comparisons which are always true
2190 // or false.
2191 if (signedRange.NonNegative)
2192 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00002193
2194 // For (in)equality comparisons, if the unsigned operand is a
2195 // constant which cannot collide with a overflowed signed operand,
2196 // then reinterpreting the signed operand as unsigned will not
2197 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00002198 if (E->isEqualityOp()) {
2199 unsigned comparisonWidth = S.Context.getIntWidth(T);
2200 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00002201
John McCall323ed742010-05-06 08:58:33 +00002202 // We should never be unable to prove that the unsigned operand is
2203 // non-negative.
2204 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
2205
2206 if (unsignedRange.Width < comparisonWidth)
2207 return;
2208 }
2209
2210 S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
2211 << lex->getType() << rex->getType()
2212 << lex->getSourceRange() << rex->getSourceRange();
John McCallba26e582010-01-04 23:21:16 +00002213}
2214
John McCall51313c32010-01-04 23:31:57 +00002215/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
John McCall323ed742010-05-06 08:58:33 +00002216void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
John McCall51313c32010-01-04 23:31:57 +00002217 S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
2218}
2219
John McCall323ed742010-05-06 08:58:33 +00002220void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
2221 bool *ICContext = 0) {
2222 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00002223
John McCall323ed742010-05-06 08:58:33 +00002224 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
2225 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
2226 if (Source == Target) return;
2227 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00002228
2229 // Never diagnose implicit casts to bool.
2230 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
2231 return;
2232
2233 // Strip vector types.
2234 if (isa<VectorType>(Source)) {
2235 if (!isa<VectorType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002236 return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
John McCall51313c32010-01-04 23:31:57 +00002237
2238 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
2239 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
2240 }
2241
2242 // Strip complex types.
2243 if (isa<ComplexType>(Source)) {
2244 if (!isa<ComplexType>(Target))
John McCall323ed742010-05-06 08:58:33 +00002245 return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
John McCall51313c32010-01-04 23:31:57 +00002246
2247 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
2248 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
2249 }
2250
2251 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
2252 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
2253
2254 // If the source is floating point...
2255 if (SourceBT && SourceBT->isFloatingPoint()) {
2256 // ...and the target is floating point...
2257 if (TargetBT && TargetBT->isFloatingPoint()) {
2258 // ...then warn if we're dropping FP rank.
2259
2260 // Builtin FP kinds are ordered by increasing FP rank.
2261 if (SourceBT->getKind() > TargetBT->getKind()) {
2262 // Don't warn about float constants that are precisely
2263 // representable in the target type.
2264 Expr::EvalResult result;
John McCall323ed742010-05-06 08:58:33 +00002265 if (E->Evaluate(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00002266 // Value might be a float, a float vector, or a float complex.
2267 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00002268 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
2269 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00002270 return;
2271 }
2272
John McCall323ed742010-05-06 08:58:33 +00002273 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00002274 }
2275 return;
2276 }
2277
2278 // If the target is integral, always warn.
2279 if ((TargetBT && TargetBT->isInteger()))
2280 // TODO: don't warn for integer values?
John McCall323ed742010-05-06 08:58:33 +00002281 DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
John McCall51313c32010-01-04 23:31:57 +00002282
2283 return;
2284 }
2285
John McCallf2370c92010-01-06 05:24:50 +00002286 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00002287 return;
2288
John McCall323ed742010-05-06 08:58:33 +00002289 IntRange SourceRange = GetExprRange(S.Context, E);
2290 IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00002291
2292 if (SourceRange.Width > TargetRange.Width) {
John McCall51313c32010-01-04 23:31:57 +00002293 // People want to build with -Wshorten-64-to-32 and not -Wconversion
2294 // and by god we'll let them.
John McCallf2370c92010-01-06 05:24:50 +00002295 if (SourceRange.Width == 64 && TargetRange.Width == 32)
John McCall323ed742010-05-06 08:58:33 +00002296 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
2297 return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
2298 }
2299
2300 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
2301 (!TargetRange.NonNegative && SourceRange.NonNegative &&
2302 SourceRange.Width == TargetRange.Width)) {
2303 unsigned DiagID = diag::warn_impcast_integer_sign;
2304
2305 // Traditionally, gcc has warned about this under -Wsign-compare.
2306 // We also want to warn about it in -Wconversion.
2307 // So if -Wconversion is off, use a completely identical diagnostic
2308 // in the sign-compare group.
2309 // The conditional-checking code will
2310 if (ICContext) {
2311 DiagID = diag::warn_impcast_integer_sign_conditional;
2312 *ICContext = true;
2313 }
2314
2315 return DiagnoseImpCast(S, E, T, DiagID);
John McCall51313c32010-01-04 23:31:57 +00002316 }
2317
2318 return;
2319}
2320
John McCall323ed742010-05-06 08:58:33 +00002321void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
2322
2323void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
2324 bool &ICContext) {
2325 E = E->IgnoreParenImpCasts();
2326
2327 if (isa<ConditionalOperator>(E))
2328 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
2329
2330 AnalyzeImplicitConversions(S, E);
2331 if (E->getType() != T)
2332 return CheckImplicitConversion(S, E, T, &ICContext);
2333 return;
2334}
2335
2336void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
2337 AnalyzeImplicitConversions(S, E->getCond());
2338
2339 bool Suspicious = false;
2340 CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
2341 CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
2342
2343 // If -Wconversion would have warned about either of the candidates
2344 // for a signedness conversion to the context type...
2345 if (!Suspicious) return;
2346
2347 // ...but it's currently ignored...
2348 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
2349 return;
2350
2351 // ...and -Wsign-compare isn't...
2352 if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
2353 return;
2354
2355 // ...then check whether it would have warned about either of the
2356 // candidates for a signedness conversion to the condition type.
2357 if (E->getType() != T) {
2358 Suspicious = false;
2359 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
2360 E->getType(), &Suspicious);
2361 if (!Suspicious)
2362 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
2363 E->getType(), &Suspicious);
2364 if (!Suspicious)
2365 return;
2366 }
2367
2368 // If so, emit a diagnostic under -Wsign-compare.
2369 Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
2370 Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
2371 S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
2372 << lex->getType() << rex->getType()
2373 << lex->getSourceRange() << rex->getSourceRange();
2374}
2375
2376/// AnalyzeImplicitConversions - Find and report any interesting
2377/// implicit conversions in the given expression. There are a couple
2378/// of competing diagnostics here, -Wconversion and -Wsign-compare.
2379void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
2380 QualType T = OrigE->getType();
2381 Expr *E = OrigE->IgnoreParenImpCasts();
2382
2383 // For conditional operators, we analyze the arguments as if they
2384 // were being fed directly into the output.
2385 if (isa<ConditionalOperator>(E)) {
2386 ConditionalOperator *CO = cast<ConditionalOperator>(E);
2387 CheckConditionalOperator(S, CO, T);
2388 return;
2389 }
2390
2391 // Go ahead and check any implicit conversions we might have skipped.
2392 // The non-canonical typecheck is just an optimization;
2393 // CheckImplicitConversion will filter out dead implicit conversions.
2394 if (E->getType() != T)
2395 CheckImplicitConversion(S, E, T);
2396
2397 // Now continue drilling into this expression.
2398
2399 // Skip past explicit casts.
2400 if (isa<ExplicitCastExpr>(E)) {
2401 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
2402 return AnalyzeImplicitConversions(S, E);
2403 }
2404
2405 // Do a somewhat different check with comparison operators.
2406 if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
2407 return AnalyzeComparison(S, cast<BinaryOperator>(E));
2408
2409 // These break the otherwise-useful invariant below. Fortunately,
2410 // we don't really need to recurse into them, because any internal
2411 // expressions should have been analyzed already when they were
2412 // built into statements.
2413 if (isa<StmtExpr>(E)) return;
2414
2415 // Don't descend into unevaluated contexts.
2416 if (isa<SizeOfAlignOfExpr>(E)) return;
2417
2418 // Now just recurse over the expression's children.
2419 for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
2420 I != IE; ++I)
2421 AnalyzeImplicitConversions(S, cast<Expr>(*I));
2422}
2423
2424} // end anonymous namespace
2425
2426/// Diagnoses "dangerous" implicit conversions within the given
2427/// expression (which is a full expression). Implements -Wconversion
2428/// and -Wsign-compare.
2429void Sema::CheckImplicitConversions(Expr *E) {
2430 // Don't diagnose in unevaluated contexts.
2431 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
2432 return;
2433
2434 // Don't diagnose for value- or type-dependent expressions.
2435 if (E->isTypeDependent() || E->isValueDependent())
2436 return;
2437
2438 AnalyzeImplicitConversions(*this, E);
2439}
2440
Mike Stumpf8c49212010-01-21 03:59:47 +00002441/// CheckParmsForFunctionDef - Check that the parameters of the given
2442/// function are appropriate for the definition of a function. This
2443/// takes care of any checks that cannot be performed on the
2444/// declaration itself, e.g., that the types of each of the function
2445/// parameters are complete.
2446bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
2447 bool HasInvalidParm = false;
2448 for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
2449 ParmVarDecl *Param = FD->getParamDecl(p);
2450
2451 // C99 6.7.5.3p4: the parameters in a parameter type list in a
2452 // function declarator that is part of a function definition of
2453 // that function shall not have incomplete type.
2454 //
2455 // This is also C++ [dcl.fct]p6.
2456 if (!Param->isInvalidDecl() &&
2457 RequireCompleteType(Param->getLocation(), Param->getType(),
2458 diag::err_typecheck_decl_incomplete_type)) {
2459 Param->setInvalidDecl();
2460 HasInvalidParm = true;
2461 }
2462
2463 // C99 6.9.1p5: If the declarator includes a parameter type list, the
2464 // declaration of each parameter shall include an identifier.
2465 if (Param->getIdentifier() == 0 &&
2466 !Param->isImplicit() &&
2467 !getLangOptions().CPlusPlus)
2468 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00002469
2470 // C99 6.7.5.3p12:
2471 // If the function declarator is not part of a definition of that
2472 // function, parameters may have incomplete type and may use the [*]
2473 // notation in their sequences of declarator specifiers to specify
2474 // variable length array types.
2475 QualType PType = Param->getOriginalType();
2476 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
2477 if (AT->getSizeModifier() == ArrayType::Star) {
2478 // FIXME: This diagnosic should point the the '[*]' if source-location
2479 // information is added for it.
2480 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
2481 }
2482 }
Mike Stumpf8c49212010-01-21 03:59:47 +00002483 }
2484
2485 return HasInvalidParm;
2486}