Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 19 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 25 | #include "clang/Basic/SourceManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 28 | #include "llvm/ADT/STLExtras.h" |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 29 | #include <climits> |
| 30 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 31 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 32 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 33 | |
| 34 | namespace { |
| 35 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 36 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 37 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 38 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | const Stmt *S; |
| 40 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 41 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 43 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 44 | bool isAllocated() const { return K == AllocateUnchecked; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 45 | //bool isFailed() const { return K == AllocateFailed; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 46 | bool isReleased() const { return K == Released; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 47 | //bool isEscaped() const { return K == Escaped; } |
| 48 | //bool isRelinquished() const { return K == Relinquished; } |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 49 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 50 | |
| 51 | bool operator==(const RefState &X) const { |
| 52 | return K == X.K && S == X.S; |
| 53 | } |
| 54 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 55 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 56 | return RefState(AllocateUnchecked, s); |
| 57 | } |
| 58 | static RefState getAllocateFailed() { |
| 59 | return RefState(AllocateFailed, 0); |
| 60 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 61 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 62 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 63 | static RefState getRelinquished(const Stmt *s) { |
| 64 | return RefState(Relinquished, s); |
| 65 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 66 | |
| 67 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 68 | ID.AddInteger(K); |
| 69 | ID.AddPointer(S); |
| 70 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 71 | }; |
| 72 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 73 | struct ReallocPair { |
| 74 | SymbolRef ReallocatedSym; |
| 75 | bool IsFreeOnFailure; |
| 76 | ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {} |
| 77 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 78 | ID.AddInteger(IsFreeOnFailure); |
| 79 | ID.AddPointer(ReallocatedSym); |
| 80 | } |
| 81 | bool operator==(const ReallocPair &X) const { |
| 82 | return ReallocatedSym == X.ReallocatedSym && |
| 83 | IsFreeOnFailure == X.IsFreeOnFailure; |
| 84 | } |
| 85 | }; |
| 86 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 87 | class MallocChecker : public Checker<check::DeadSymbols, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 88 | check::EndPath, |
| 89 | check::PreStmt<ReturnStmt>, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 90 | check::PreStmt<CallExpr>, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 91 | check::PostStmt<CallExpr>, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 92 | check::Location, |
| 93 | check::Bind, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 94 | eval::Assume, |
| 95 | check::RegionChanges> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 96 | { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 97 | mutable OwningPtr<BugType> BT_DoubleFree; |
| 98 | mutable OwningPtr<BugType> BT_Leak; |
| 99 | mutable OwningPtr<BugType> BT_UseFree; |
| 100 | mutable OwningPtr<BugType> BT_BadFree; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 101 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 102 | *II_valloc, *II_reallocf, *II_strndup, *II_strdup; |
| 103 | |
| 104 | static const unsigned InvalidArgIndex = UINT_MAX; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 105 | |
| 106 | public: |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 107 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 108 | II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 109 | |
| 110 | /// In pessimistic mode, the checker assumes that it does not know which |
| 111 | /// functions might free the memory. |
| 112 | struct ChecksFilter { |
| 113 | DefaultBool CMallocPessimistic; |
| 114 | DefaultBool CMallocOptimistic; |
| 115 | }; |
| 116 | |
| 117 | ChecksFilter Filter; |
| 118 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 119 | void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 120 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 121 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 122 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 123 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 124 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 125 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 126 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 127 | CheckerContext &C) const; |
| 128 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 129 | CheckerContext &C) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 130 | ProgramStateRef |
| 131 | checkRegionChanges(ProgramStateRef state, |
| 132 | const StoreManager::InvalidatedSymbols *invalidated, |
| 133 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 134 | ArrayRef<const MemRegion *> Regions, |
| 135 | const CallOrObjCMessage *Call) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 136 | bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| 137 | return true; |
| 138 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 139 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 140 | private: |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 141 | void initIdentifierInfo(ASTContext &C) const; |
| 142 | |
| 143 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 144 | /// pointed to by one of its arguments. |
| 145 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| 146 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 147 | static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 148 | const CallExpr *CE, |
| 149 | const OwnershipAttr* Att); |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 150 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 151 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 152 | ProgramStateRef state) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 153 | return MallocMemAux(C, CE, |
| 154 | state->getSVal(SizeEx, C.getLocationContext()), |
| 155 | Init, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 156 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 157 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 158 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 159 | SVal SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 160 | ProgramStateRef state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 161 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 162 | /// Update the RefState to reflect the new memory allocation. |
| 163 | static ProgramStateRef MallocUpdateRefState(CheckerContext &C, |
| 164 | const CallExpr *CE, |
| 165 | ProgramStateRef state); |
| 166 | |
| 167 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| 168 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 169 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 170 | ProgramStateRef state, unsigned Num, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 171 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 172 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 173 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
| 174 | bool FreesMemOnFailure) const; |
| 175 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 176 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 177 | bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| 178 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 179 | const Stmt *S = 0) const; |
| 180 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 181 | /// Check if the function is not known to us. So, for example, we could |
| 182 | /// conservatively assume it can free/reallocate it's pointer arguments. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 183 | bool doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 184 | ProgramStateRef State) const; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 185 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 186 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 187 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 188 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 189 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 190 | /// Find the location of the allocation for Sym on the path leading to the |
| 191 | /// exploded node N. |
| 192 | const Stmt *getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 193 | CheckerContext &C) const; |
| 194 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 195 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 196 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 197 | /// The bug visitor which allows us to print extra diagnostics along the |
| 198 | /// BugReport path. For example, showing the allocation site of the leaked |
| 199 | /// region. |
| 200 | class MallocBugVisitor : public BugReporterVisitor { |
| 201 | protected: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 202 | enum NotificationMode { |
| 203 | Normal, |
| 204 | Complete, |
| 205 | ReallocationFailed |
| 206 | }; |
| 207 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 208 | // The allocated region symbol tracked by the main analysis. |
| 209 | SymbolRef Sym; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 210 | NotificationMode Mode; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 211 | |
| 212 | public: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 213 | MallocBugVisitor(SymbolRef S) : Sym(S), Mode(Normal) {} |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 214 | virtual ~MallocBugVisitor() {} |
| 215 | |
| 216 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 217 | static int X = 0; |
| 218 | ID.AddPointer(&X); |
| 219 | ID.AddPointer(Sym); |
| 220 | } |
| 221 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 222 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 223 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 224 | // Did not track -> allocated. Other state (released) -> allocated. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 225 | return (Stmt && isa<CallExpr>(Stmt) && |
| 226 | (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 227 | } |
| 228 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 229 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 230 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 231 | // Did not track -> released. Other state (allocated) -> released. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 232 | return (Stmt && isa<CallExpr>(Stmt) && |
| 233 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 234 | } |
| 235 | |
| 236 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 237 | const Stmt *Stmt) { |
| 238 | // If the expression is not a call, and the state change is |
| 239 | // released -> allocated, it must be the realloc return value |
| 240 | // check. If we have to handle more cases here, it might be cleaner just |
| 241 | // to track this extra bit in the state itself. |
| 242 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| 243 | (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 247 | const ExplodedNode *PrevN, |
| 248 | BugReporterContext &BRC, |
| 249 | BugReport &BR); |
| 250 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 251 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 252 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 253 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 254 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 255 | typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 256 | class RegionState {}; |
| 257 | class ReallocPairs {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 258 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 259 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 260 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 261 | struct ProgramStateTrait<RegionState> |
| 262 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 263 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 264 | }; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 265 | |
| 266 | template <> |
| 267 | struct ProgramStateTrait<ReallocPairs> |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 268 | : public ProgramStatePartialTrait<ReallocMap> { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 269 | static void *GDMIndex() { static int x; return &x; } |
| 270 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 271 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 272 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 273 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 274 | namespace { |
| 275 | class StopTrackingCallback : public SymbolVisitor { |
| 276 | ProgramStateRef state; |
| 277 | public: |
| 278 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 279 | ProgramStateRef getState() const { return state; } |
| 280 | |
| 281 | bool VisitSymbol(SymbolRef sym) { |
| 282 | state = state->remove<RegionState>(sym); |
| 283 | return true; |
| 284 | } |
| 285 | }; |
| 286 | } // end anonymous namespace |
| 287 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 288 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 289 | if (!II_malloc) |
| 290 | II_malloc = &Ctx.Idents.get("malloc"); |
| 291 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 292 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 293 | if (!II_realloc) |
| 294 | II_realloc = &Ctx.Idents.get("realloc"); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 295 | if (!II_reallocf) |
| 296 | II_reallocf = &Ctx.Idents.get("reallocf"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 297 | if (!II_calloc) |
| 298 | II_calloc = &Ctx.Idents.get("calloc"); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 299 | if (!II_valloc) |
| 300 | II_valloc = &Ctx.Idents.get("valloc"); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 301 | if (!II_strdup) |
| 302 | II_strdup = &Ctx.Idents.get("strdup"); |
| 303 | if (!II_strndup) |
| 304 | II_strndup = &Ctx.Idents.get("strndup"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 305 | } |
| 306 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 307 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 308 | if (!FD) |
| 309 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 310 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 311 | if (!FunI) |
| 312 | return false; |
| 313 | |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 314 | initIdentifierInfo(C); |
| 315 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 316 | if (FunI == II_malloc || FunI == II_free || FunI == II_realloc || |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 317 | FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc || |
| 318 | FunI == II_strdup || FunI == II_strndup) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 319 | return true; |
| 320 | |
| 321 | if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| 322 | FD->specific_attr_begin<OwnershipAttr>() != |
| 323 | FD->specific_attr_end<OwnershipAttr>()) |
| 324 | return true; |
| 325 | |
| 326 | |
| 327 | return false; |
| 328 | } |
| 329 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 330 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| 331 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 332 | if (!FD) |
| 333 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 334 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 335 | initIdentifierInfo(C.getASTContext()); |
| 336 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 337 | if (!FunI) |
| 338 | return; |
| 339 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 340 | ProgramStateRef State = C.getState(); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 341 | if (FunI == II_malloc || FunI == II_valloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 342 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 343 | } else if (FunI == II_realloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 344 | State = ReallocMem(C, CE, false); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 345 | } else if (FunI == II_reallocf) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 346 | State = ReallocMem(C, CE, true); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 347 | } else if (FunI == II_calloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 348 | State = CallocMem(C, CE); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 349 | } else if (FunI == II_free) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 350 | State = FreeMemAux(C, CE, C.getState(), 0, false); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 351 | } else if (FunI == II_strdup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 352 | State = MallocUpdateRefState(C, CE, State); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 353 | } else if (FunI == II_strndup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 354 | State = MallocUpdateRefState(C, CE, State); |
| 355 | } else if (Filter.CMallocOptimistic) { |
| 356 | // Check all the attributes, if there are any. |
| 357 | // There can be multiple of these attributes. |
| 358 | if (FD->hasAttrs()) |
| 359 | for (specific_attr_iterator<OwnershipAttr> |
| 360 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 361 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 362 | i != e; ++i) { |
| 363 | switch ((*i)->getOwnKind()) { |
| 364 | case OwnershipAttr::Returns: |
| 365 | State = MallocMemReturnsAttr(C, CE, *i); |
| 366 | break; |
| 367 | case OwnershipAttr::Takes: |
| 368 | case OwnershipAttr::Holds: |
| 369 | State = FreeMemAttr(C, CE, *i); |
| 370 | break; |
| 371 | } |
| 372 | } |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 373 | } |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 374 | C.addTransition(State); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 375 | } |
| 376 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 377 | ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C, |
| 378 | const CallExpr *CE, |
| 379 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 380 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 381 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 382 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 383 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 384 | if (I != E) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 385 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 386 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 387 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 388 | } |
| 389 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 390 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 391 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 392 | SVal Size, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 393 | ProgramStateRef state) { |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 394 | // Get the return value. |
| 395 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 396 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 397 | // We expect the malloc functions to return a pointer. |
| 398 | if (!isa<Loc>(retVal)) |
| 399 | return 0; |
| 400 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 401 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 402 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 403 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 404 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 405 | const SymbolicRegion *R = |
| 406 | dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 407 | if (!R) |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 408 | return 0; |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 409 | if (isa<DefinedOrUnknownSVal>(Size)) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 410 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 411 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
| 412 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
| 413 | DefinedOrUnknownSVal extentMatchesSize = |
| 414 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 415 | |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 416 | state = state->assume(extentMatchesSize, true); |
| 417 | assert(state); |
| 418 | } |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 419 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 420 | return MallocUpdateRefState(C, CE, state); |
| 421 | } |
| 422 | |
| 423 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
| 424 | const CallExpr *CE, |
| 425 | ProgramStateRef state) { |
| 426 | // Get the return value. |
| 427 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
| 428 | |
| 429 | // We expect the malloc functions to return a pointer. |
| 430 | if (!isa<Loc>(retVal)) |
| 431 | return 0; |
| 432 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 433 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 434 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 435 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 436 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 437 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 438 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 439 | } |
| 440 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 441 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 442 | const CallExpr *CE, |
| 443 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 444 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 445 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 446 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 447 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 448 | I != E; ++I) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 449 | return FreeMemAux(C, CE, C.getState(), *I, |
| 450 | Att->getOwnKind() == OwnershipAttr::Holds); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 451 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 452 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 453 | } |
| 454 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 455 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 456 | const CallExpr *CE, |
| 457 | ProgramStateRef state, |
| 458 | unsigned Num, |
| 459 | bool Hold) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 460 | const Expr *ArgExpr = CE->getArg(Num); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 461 | SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 462 | if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| 463 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 464 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 465 | |
| 466 | // Check for null dereferences. |
| 467 | if (!isa<Loc>(location)) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 468 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 469 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 470 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 471 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 472 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 473 | if (nullState && !notNullState) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 474 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 475 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 476 | // Unknown values could easily be okay |
| 477 | // Undefined values are handled elsewhere |
| 478 | if (ArgVal.isUnknownOrUndef()) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 479 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 480 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 481 | const MemRegion *R = ArgVal.getAsRegion(); |
| 482 | |
| 483 | // Nonlocs can't be freed, of course. |
| 484 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 485 | if (!R) { |
| 486 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 487 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 488 | } |
| 489 | |
| 490 | R = R->StripCasts(); |
| 491 | |
| 492 | // Blocks might show up as heap data, but should not be free()d |
| 493 | if (isa<BlockDataRegion>(R)) { |
| 494 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 495 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 496 | } |
| 497 | |
| 498 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 499 | |
| 500 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 501 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 502 | // FIXME: at the time this code was written, malloc() regions were |
| 503 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 504 | // This means that there isn't actually anything from HeapSpaceRegion |
| 505 | // that should be freed, even though we allow it here. |
| 506 | // Of course, free() can work on memory allocated outside the current |
| 507 | // function, so UnknownSpaceRegion is always a possibility. |
| 508 | // False negatives are better than false positives. |
| 509 | |
| 510 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 511 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 512 | } |
| 513 | |
| 514 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 515 | // Various cases could lead to non-symbol values here. |
| 516 | // For now, ignore them. |
| 517 | if (!SR) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 518 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 519 | |
| 520 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 521 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 522 | |
| 523 | // If the symbol has not been tracked, return. This is possible when free() is |
| 524 | // called on a pointer that does not get its pointee directly from malloc(). |
| 525 | // Full support of this requires inter-procedural analysis. |
| 526 | if (!RS) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 527 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 528 | |
| 529 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 530 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 531 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 532 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 533 | BT_DoubleFree.reset( |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 534 | new BugType("Double free", "Memory Error")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 535 | BugReport *R = new BugReport(*BT_DoubleFree, |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 536 | "Attempt to free released memory", N); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 537 | R->addRange(ArgExpr->getSourceRange()); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 538 | R->addVisitor(new MallocBugVisitor(Sym)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 539 | C.EmitReport(R); |
| 540 | } |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 541 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 542 | } |
| 543 | |
| 544 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 545 | if (Hold) |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 546 | return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 547 | return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 548 | } |
| 549 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 550 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 551 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 552 | os << "an integer (" << IntVal->getValue() << ")"; |
| 553 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 554 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 555 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 556 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 557 | else |
| 558 | return false; |
| 559 | |
| 560 | return true; |
| 561 | } |
| 562 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 563 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 564 | const MemRegion *MR) { |
| 565 | switch (MR->getKind()) { |
| 566 | case MemRegion::FunctionTextRegionKind: { |
| 567 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 568 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 569 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 570 | else |
| 571 | os << "the address of a function"; |
| 572 | return true; |
| 573 | } |
| 574 | case MemRegion::BlockTextRegionKind: |
| 575 | os << "block text"; |
| 576 | return true; |
| 577 | case MemRegion::BlockDataRegionKind: |
| 578 | // FIXME: where the block came from? |
| 579 | os << "a block"; |
| 580 | return true; |
| 581 | default: { |
| 582 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 583 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 584 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 585 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 586 | const VarDecl *VD; |
| 587 | if (VR) |
| 588 | VD = VR->getDecl(); |
| 589 | else |
| 590 | VD = NULL; |
| 591 | |
| 592 | if (VD) |
| 593 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 594 | else |
| 595 | os << "the address of a local stack variable"; |
| 596 | return true; |
| 597 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 598 | |
| 599 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 600 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 601 | const VarDecl *VD; |
| 602 | if (VR) |
| 603 | VD = VR->getDecl(); |
| 604 | else |
| 605 | VD = NULL; |
| 606 | |
| 607 | if (VD) |
| 608 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 609 | else |
| 610 | os << "the address of a parameter"; |
| 611 | return true; |
| 612 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 613 | |
| 614 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 615 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 616 | const VarDecl *VD; |
| 617 | if (VR) |
| 618 | VD = VR->getDecl(); |
| 619 | else |
| 620 | VD = NULL; |
| 621 | |
| 622 | if (VD) { |
| 623 | if (VD->isStaticLocal()) |
| 624 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 625 | else |
| 626 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 627 | } else |
| 628 | os << "the address of a global variable"; |
| 629 | return true; |
| 630 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 631 | |
| 632 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 633 | } |
| 634 | } |
| 635 | } |
| 636 | |
| 637 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 638 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 639 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 640 | if (!BT_BadFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 641 | BT_BadFree.reset(new BugType("Bad free", "Memory Error")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 642 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 643 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 644 | llvm::raw_svector_ostream os(buf); |
| 645 | |
| 646 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 647 | if (MR) { |
| 648 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 649 | MR = ER->getSuperRegion(); |
| 650 | |
| 651 | // Special case for alloca() |
| 652 | if (isa<AllocaRegion>(MR)) |
| 653 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 654 | else { |
| 655 | os << "Argument to free() is "; |
| 656 | if (SummarizeRegion(os, MR)) |
| 657 | os << ", which is not memory allocated by malloc()"; |
| 658 | else |
| 659 | os << "not memory allocated by malloc()"; |
| 660 | } |
| 661 | } else { |
| 662 | os << "Argument to free() is "; |
| 663 | if (SummarizeValue(os, ArgVal)) |
| 664 | os << ", which is not memory allocated by malloc()"; |
| 665 | else |
| 666 | os << "not memory allocated by malloc()"; |
| 667 | } |
| 668 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 669 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 670 | R->addRange(range); |
| 671 | C.EmitReport(R); |
| 672 | } |
| 673 | } |
| 674 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 675 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 676 | const CallExpr *CE, |
| 677 | bool FreesOnFail) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 678 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 679 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 680 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 681 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| 682 | if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 683 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 684 | DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 685 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 686 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 687 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 688 | DefinedOrUnknownSVal PtrEQ = |
| 689 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 690 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 691 | // Get the size argument. If there is no size arg then give up. |
| 692 | const Expr *Arg1 = CE->getArg(1); |
| 693 | if (!Arg1) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 694 | return 0; |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 695 | |
| 696 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 697 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| 698 | if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 699 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 700 | DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 701 | |
| 702 | // Compare the size argument to 0. |
| 703 | DefinedOrUnknownSVal SizeZero = |
| 704 | svalBuilder.evalEQ(state, Arg1Val, |
| 705 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 706 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 707 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| 708 | llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| 709 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| 710 | llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| 711 | // We only assume exceptional states if they are definitely true; if the |
| 712 | // state is under-constrained, assume regular realloc behavior. |
| 713 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 714 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 715 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 716 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 717 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 718 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 719 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 720 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 721 | return stateMalloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 722 | } |
| 723 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 724 | if (PrtIsNull && SizeIsZero) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 725 | return 0; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 726 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 727 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 728 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 729 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 730 | SVal RetVal = state->getSVal(CE, LCtx); |
| 731 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 732 | if (!FromPtr || !ToPtr) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 733 | return 0; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 734 | |
| 735 | // If the size is 0, free the memory. |
| 736 | if (SizeIsZero) |
| 737 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 738 | // The semantics of the return value are: |
| 739 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
| 740 | // to free() is returned. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 741 | stateFree = stateFree->set<ReallocPairs>(ToPtr, |
| 742 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 743 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 744 | return stateFree; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 745 | } |
| 746 | |
| 747 | // Default behavior. |
| 748 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| 749 | // FIXME: We should copy the content of the original buffer. |
| 750 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 751 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 752 | if (!stateRealloc) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 753 | return 0; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 754 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
| 755 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 756 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 757 | return stateRealloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 758 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 759 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 760 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 761 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 762 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){ |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 763 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 764 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 765 | const LocationContext *LCtx = C.getLocationContext(); |
| 766 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 767 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 768 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 769 | svalBuilder.getContext().getSizeType()); |
| 770 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 771 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 772 | return MallocMemAux(C, CE, TotalSize, zeroVal, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 773 | } |
| 774 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 775 | const Stmt * |
| 776 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 777 | CheckerContext &C) const { |
| 778 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 779 | // the tracked symbol. |
| 780 | const ExplodedNode *AllocNode = N; |
| 781 | |
| 782 | while (N) { |
| 783 | if (!N->getState()->get<RegionState>(Sym)) |
| 784 | break; |
| 785 | AllocNode = N; |
| 786 | N = N->pred_empty() ? NULL : *(N->pred_begin()); |
| 787 | } |
| 788 | |
| 789 | ProgramPoint P = AllocNode->getLocation(); |
| 790 | return cast<clang::PostStmt>(P).getStmt(); |
| 791 | } |
| 792 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 793 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 794 | CheckerContext &C) const { |
| 795 | assert(N); |
| 796 | if (!BT_Leak) { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 797 | BT_Leak.reset(new BugType("Memory leak", "Memory Error")); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 798 | // Leaks should not be reported if they are post-dominated by a sink: |
| 799 | // (1) Sinks are higher importance bugs. |
| 800 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 801 | // with __noreturn functions such as assert() or exit(). We choose not |
| 802 | // to report leaks on such paths. |
| 803 | BT_Leak->setSuppressOnSink(true); |
| 804 | } |
| 805 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 806 | // Most bug reports are cached at the location where they occurred. |
| 807 | // With leaks, we want to unique them by the location where they were |
| 808 | // allocated, and only report a single path. |
| 809 | const Stmt *AllocStmt = getAllocationSite(N, Sym, C); |
| 810 | PathDiagnosticLocation LocUsedForUniqueing = |
| 811 | PathDiagnosticLocation::createBegin(AllocStmt, C.getSourceManager(), |
| 812 | N->getLocationContext()); |
| 813 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 814 | BugReport *R = new BugReport(*BT_Leak, |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 815 | "Memory is never released; potential memory leak", N, LocUsedForUniqueing); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 816 | R->addVisitor(new MallocBugVisitor(Sym)); |
| 817 | C.EmitReport(R); |
| 818 | } |
| 819 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 820 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 821 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 822 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 823 | if (!SymReaper.hasDeadSymbols()) |
| 824 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 825 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 826 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 827 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 828 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 829 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 830 | bool generateReport = false; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 831 | llvm::SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 832 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 833 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 834 | if (I->second.isAllocated()) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 835 | generateReport = true; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 836 | Errors.push_back(I->first); |
| 837 | } |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 838 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 839 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 840 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 841 | } |
| 842 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 843 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 844 | // Cleanup the Realloc Pairs Map. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 845 | ReallocMap RP = state->get<ReallocPairs>(); |
| 846 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 847 | if (SymReaper.isDead(I->first) || |
| 848 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 849 | state = state->remove<ReallocPairs>(I->first); |
| 850 | } |
| 851 | } |
| 852 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 853 | // Generate leak node. |
| 854 | static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak"); |
| 855 | ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 856 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 857 | if (generateReport) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 858 | for (llvm::SmallVector<SymbolRef, 2>::iterator |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 859 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| 860 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 861 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 862 | } |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 863 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 864 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 865 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 866 | void MallocChecker::checkEndPath(CheckerContext &C) const { |
| 867 | ProgramStateRef state = C.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 868 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 869 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 870 | // If inside inlined call, skip it. |
| 871 | if (C.getLocationContext()->getParent() != 0) |
| 872 | return; |
| 873 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 874 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 875 | RefState RS = I->second; |
| 876 | if (RS.isAllocated()) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 877 | ExplodedNode *N = C.addTransition(state); |
| 878 | if (N) |
| 879 | reportLeak(I->first, N, C); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 880 | } |
| 881 | } |
| 882 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 883 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 884 | bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| 885 | CheckerContext &C) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 886 | ProgramStateRef state = C.getState(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 887 | const RefState *RS = state->get<RegionState>(Sym); |
| 888 | if (!RS) |
| 889 | return false; |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 890 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 891 | if (RS->isAllocated()) { |
| 892 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 893 | C.addTransition(state); |
| 894 | return true; |
| 895 | } |
| 896 | return false; |
| 897 | } |
| 898 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 899 | void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| 900 | if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| 901 | return; |
| 902 | |
| 903 | // Check use after free, when a freed pointer is passed to a call. |
| 904 | ProgramStateRef State = C.getState(); |
| 905 | for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| 906 | E = CE->arg_end(); I != E; ++I) { |
| 907 | const Expr *A = *I; |
| 908 | if (A->getType().getTypePtr()->isAnyPointerType()) { |
| 909 | SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| 910 | if (!Sym) |
| 911 | continue; |
| 912 | if (checkUseAfterFree(Sym, C, A)) |
| 913 | return; |
| 914 | } |
| 915 | } |
| 916 | } |
| 917 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 918 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 919 | const Expr *E = S->getRetValue(); |
| 920 | if (!E) |
| 921 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 922 | |
| 923 | // Check if we are returning a symbol. |
Anna Zaks | d9ab7bb | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 924 | SVal RetVal = C.getState()->getSVal(E, C.getLocationContext()); |
| 925 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 926 | if (!Sym) |
| 927 | // If we are returning a field of the allocated struct or an array element, |
| 928 | // the callee could still free the memory. |
| 929 | // TODO: This logic should be a part of generic symbol escape callback. |
| 930 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 931 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 932 | if (const SymbolicRegion *BMR = |
| 933 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 934 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 935 | if (!Sym) |
| 936 | return; |
| 937 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 938 | // Check if we are returning freed memory. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 939 | if (checkUseAfterFree(Sym, C, E)) |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 940 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 941 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 942 | // If this function body is not inlined, check if the symbol is escaping. |
| 943 | if (C.getLocationContext()->getParent() == 0) |
| 944 | checkEscape(Sym, E, C); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 945 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 946 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 947 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 948 | const Stmt *S) const { |
| 949 | assert(Sym); |
| 950 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 951 | if (RS && RS->isReleased()) { |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 952 | if (ExplodedNode *N = C.generateSink()) { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 953 | if (!BT_UseFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 954 | BT_UseFree.reset(new BugType("Use-after-free", "Memory Error")); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 955 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 956 | BugReport *R = new BugReport(*BT_UseFree, |
| 957 | "Use of memory after it is freed",N); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 958 | if (S) |
| 959 | R->addRange(S->getSourceRange()); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 960 | R->addVisitor(new MallocBugVisitor(Sym)); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 961 | C.EmitReport(R); |
| 962 | return true; |
| 963 | } |
| 964 | } |
| 965 | return false; |
| 966 | } |
| 967 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 968 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 969 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 970 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 971 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 972 | if (Sym) |
| 973 | checkUseAfterFree(Sym, C); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 974 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 975 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 976 | //===----------------------------------------------------------------------===// |
| 977 | // Check various ways a symbol can be invalidated. |
| 978 | // TODO: This logic (the next 3 functions) is copied/similar to the |
| 979 | // RetainRelease checker. We might want to factor this out. |
| 980 | //===----------------------------------------------------------------------===// |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 981 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 982 | // Stop tracking symbols when a value escapes as a result of checkBind. |
| 983 | // A value escapes in three possible cases: |
| 984 | // (1) we are binding to something that is not a memory region. |
| 985 | // (2) we are binding to a memregion that does not have stack storage |
| 986 | // (3) we are binding to a memregion with stack storage that the store |
| 987 | // does not understand. |
| 988 | void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| 989 | CheckerContext &C) const { |
| 990 | // Are we storing to something that causes the value to "escape"? |
| 991 | bool escapes = true; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 992 | ProgramStateRef state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 993 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 994 | if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| 995 | escapes = !regionLoc->getRegion()->hasStackStorage(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 996 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 997 | if (!escapes) { |
| 998 | // To test (3), generate a new state with the binding added. If it is |
| 999 | // the same state, then it escapes (since the store cannot represent |
| 1000 | // the binding). |
| 1001 | escapes = (state == (state->bindLoc(*regionLoc, val))); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1002 | } |
Anna Zaks | ac59300 | 2012-02-16 03:40:57 +0000 | [diff] [blame] | 1003 | if (!escapes) { |
| 1004 | // Case 4: We do not currently model what happens when a symbol is |
| 1005 | // assigned to a struct field, so be conservative here and let the symbol |
| 1006 | // go. TODO: This could definitely be improved upon. |
| 1007 | escapes = !isa<VarRegion>(regionLoc->getRegion()); |
| 1008 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1009 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1010 | |
| 1011 | // If our store can represent the binding and we aren't storing to something |
| 1012 | // that doesn't have local storage then just return and have the simulation |
| 1013 | // state continue as is. |
| 1014 | if (!escapes) |
| 1015 | return; |
| 1016 | |
| 1017 | // Otherwise, find all symbols referenced by 'val' that we are tracking |
| 1018 | // and stop tracking them. |
| 1019 | state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| 1020 | C.addTransition(state); |
| 1021 | } |
| 1022 | |
| 1023 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 1024 | // it - assuming that allocation failed on this path. |
| 1025 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 1026 | SVal Cond, |
| 1027 | bool Assumption) const { |
| 1028 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1029 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 1030 | // If the symbol is assumed to NULL or another constant, this will |
| 1031 | // return an APSInt*. |
| 1032 | if (state->getSymVal(I.getKey())) |
| 1033 | state = state->remove<RegionState>(I.getKey()); |
| 1034 | } |
| 1035 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1036 | // Realloc returns 0 when reallocation fails, which means that we should |
| 1037 | // restore the state of the pointer being reallocated. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1038 | ReallocMap RP = state->get<ReallocPairs>(); |
| 1039 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1040 | // If the symbol is assumed to NULL or another constant, this will |
| 1041 | // return an APSInt*. |
| 1042 | if (state->getSymVal(I.getKey())) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1043 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 1044 | const RefState *RS = state->get<RegionState>(ReallocSym); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1045 | if (RS) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1046 | if (RS->isReleased() && ! I.getData().IsFreeOnFailure) |
| 1047 | state = state->set<RegionState>(ReallocSym, |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1048 | RefState::getAllocateUnchecked(RS->getStmt())); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1049 | } |
| 1050 | state = state->remove<ReallocPairs>(I.getKey()); |
| 1051 | } |
| 1052 | } |
| 1053 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1054 | return state; |
| 1055 | } |
| 1056 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1057 | // Check if the function is known to us. So, for example, we could |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1058 | // conservatively assume it can free/reallocate it's pointer arguments. |
| 1059 | // (We assume that the pointers cannot escape through calls to system |
| 1060 | // functions not handled by this checker.) |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1061 | bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 1062 | ProgramStateRef State) const { |
| 1063 | if (!Call) |
| 1064 | return false; |
| 1065 | |
| 1066 | // For now, assume that any C++ call can free memory. |
| 1067 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 1068 | // regions escape to C++ containers. They seem to do that even now, but for |
| 1069 | // mysterious reasons. |
| 1070 | if (Call->isCXXCall()) |
| 1071 | return false; |
| 1072 | |
| 1073 | const Decl *D = Call->getDecl(); |
| 1074 | if (!D) |
| 1075 | return false; |
| 1076 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1077 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 1078 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1079 | // If it's one of the allocation functions we can reason about, we model |
| 1080 | // it's behavior explicitly. |
| 1081 | if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) { |
| 1082 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1083 | } |
| 1084 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1085 | // If it's not a system call, assume it frees memory. |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1086 | SourceManager &SM = ASTC.getSourceManager(); |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1087 | if (!SM.isInSystemHeader(D->getLocation())) |
| 1088 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1089 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1090 | // Process C functions. |
| 1091 | if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D)) { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1092 | // White list the system functions whose arguments escape. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1093 | const IdentifierInfo *II = FD->getIdentifier(); |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1094 | if (II) { |
| 1095 | StringRef FName = II->getName(); |
| 1096 | if (FName.equals("pthread_setspecific")) |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1097 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1098 | } |
| 1099 | |
| 1100 | // Otherwise, assume that the function does not free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1101 | // Most system calls, do not free the memory. |
| 1102 | return true; |
| 1103 | |
| 1104 | // Process ObjC functions. |
| 1105 | } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) { |
| 1106 | Selector S = ObjCD->getSelector(); |
| 1107 | |
| 1108 | // White list the ObjC functions which do free memory. |
| 1109 | // - Anything containing 'freeWhenDone' param set to 1. |
| 1110 | // Ex: dataWithBytesNoCopy:length:freeWhenDone. |
| 1111 | for (unsigned i = 1; i < S.getNumArgs(); ++i) { |
| 1112 | if (S.getNameForSlot(i).equals("freeWhenDone")) { |
| 1113 | if (Call->getArgSVal(i).isConstant(1)) |
| 1114 | return false; |
| 1115 | } |
| 1116 | } |
| 1117 | |
| 1118 | // Otherwise, assume that the function does not free memory. |
| 1119 | // Most system calls, do not free the memory. |
| 1120 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1121 | } |
| 1122 | |
| 1123 | // Otherwise, assume that the function can free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1124 | return false; |
| 1125 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1126 | } |
| 1127 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1128 | // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| 1129 | // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| 1130 | // about it anymore. |
| 1131 | ProgramStateRef |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1132 | MallocChecker::checkRegionChanges(ProgramStateRef State, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1133 | const StoreManager::InvalidatedSymbols *invalidated, |
| 1134 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1135 | ArrayRef<const MemRegion *> Regions, |
| 1136 | const CallOrObjCMessage *Call) const { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1137 | if (!invalidated || invalidated->empty()) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1138 | return State; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1139 | llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1140 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1141 | // If it's a call which might free or reallocate memory, we assume that all |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame^] | 1142 | // regions (explicit and implicit) escaped. |
| 1143 | |
| 1144 | // Otherwise, whitelist explicit pointers; we still can track them. |
| 1145 | if (!Call || doesNotFreeMemory(Call, State)) { |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1146 | for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| 1147 | E = ExplicitRegions.end(); I != E; ++I) { |
| 1148 | if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| 1149 | WhitelistedSymbols.insert(R->getSymbol()); |
| 1150 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1151 | } |
| 1152 | |
| 1153 | for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| 1154 | E = invalidated->end(); I!=E; ++I) { |
| 1155 | SymbolRef sym = *I; |
| 1156 | if (WhitelistedSymbols.count(sym)) |
| 1157 | continue; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1158 | // The symbol escaped. |
| 1159 | if (const RefState *RS = State->get<RegionState>(sym)) |
| 1160 | State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1161 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1162 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1163 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1164 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1165 | PathDiagnosticPiece * |
| 1166 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 1167 | const ExplodedNode *PrevN, |
| 1168 | BugReporterContext &BRC, |
| 1169 | BugReport &BR) { |
| 1170 | const RefState *RS = N->getState()->get<RegionState>(Sym); |
| 1171 | const RefState *RSPrev = PrevN->getState()->get<RegionState>(Sym); |
| 1172 | if (!RS && !RSPrev) |
| 1173 | return 0; |
| 1174 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1175 | const Stmt *S = 0; |
| 1176 | const char *Msg = 0; |
| 1177 | |
| 1178 | // Retrieve the associated statement. |
| 1179 | ProgramPoint ProgLoc = N->getLocation(); |
| 1180 | if (isa<StmtPoint>(ProgLoc)) |
| 1181 | S = cast<StmtPoint>(ProgLoc).getStmt(); |
| 1182 | // If an assumption was made on a branch, it should be caught |
| 1183 | // here by looking at the state transition. |
| 1184 | if (isa<BlockEdge>(ProgLoc)) { |
| 1185 | const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc(); |
| 1186 | S = srcBlk->getTerminator(); |
| 1187 | } |
| 1188 | if (!S) |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1189 | return 0; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1190 | |
| 1191 | // Find out if this is an interesting point and what is the kind. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1192 | if (Mode == Normal) { |
| 1193 | if (isAllocated(RS, RSPrev, S)) |
| 1194 | Msg = "Memory is allocated"; |
| 1195 | else if (isReleased(RS, RSPrev, S)) |
| 1196 | Msg = "Memory is released"; |
| 1197 | else if (isReallocFailedCheck(RS, RSPrev, S)) { |
| 1198 | Mode = ReallocationFailed; |
| 1199 | Msg = "Reallocation failed"; |
| 1200 | } |
| 1201 | |
| 1202 | // We are in a special mode if a reallocation failed later in the path. |
| 1203 | } else if (Mode == ReallocationFailed) { |
| 1204 | // Generate a special diagnostic for the first realloc we find. |
| 1205 | if (!isAllocated(RS, RSPrev, S) && !isReleased(RS, RSPrev, S)) |
| 1206 | return 0; |
| 1207 | |
| 1208 | // Check that the name of the function is realloc. |
| 1209 | const CallExpr *CE = dyn_cast<CallExpr>(S); |
| 1210 | if (!CE) |
| 1211 | return 0; |
| 1212 | const FunctionDecl *funDecl = CE->getDirectCallee(); |
| 1213 | if (!funDecl) |
| 1214 | return 0; |
| 1215 | StringRef FunName = funDecl->getName(); |
| 1216 | if (!(FunName.equals("realloc") || FunName.equals("reallocf"))) |
| 1217 | return 0; |
| 1218 | Msg = "Attempt to reallocate memory"; |
| 1219 | Mode = Normal; |
| 1220 | } |
| 1221 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1222 | if (!Msg) |
| 1223 | return 0; |
| 1224 | |
| 1225 | // Generate the extra diagnostic. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1226 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1227 | N->getLocationContext()); |
| 1228 | return new PathDiagnosticEventPiece(Pos, Msg); |
| 1229 | } |
| 1230 | |
| 1231 | |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1232 | #define REGISTER_CHECKER(name) \ |
| 1233 | void ento::register##name(CheckerManager &mgr) {\ |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 1234 | registerCStringCheckerBasic(mgr); \ |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1235 | mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1236 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1237 | |
| 1238 | REGISTER_CHECKER(MallocPessimistic) |
| 1239 | REGISTER_CHECKER(MallocOptimistic) |