Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 1 | //=- NSAutoreleasePoolChecker.cpp --------------------------------*- C++ -*-==// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines a NSAutoreleasePoolChecker, a small checker that warns |
| 11 | // about subpar uses of NSAutoreleasePool. Note that while the check itself |
| 12 | // (in it's current form) could be written as a flow-insensitive check, in |
| 13 | // can be potentially enhanced in the future with flow-sensitive information. |
| 14 | // It is also a good example of the CheckerVisitor interface. |
| 15 | // |
| 16 | //===----------------------------------------------------------------------===// |
| 17 | |
Argyrios Kyrtzidis | 0b1ba62 | 2011-02-16 01:40:52 +0000 | [diff] [blame] | 18 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | 695fb50 | 2011-02-17 21:39:17 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" |
| 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" |
| 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerVisitor.h" |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 23 | #include "clang/AST/DeclObjC.h" |
| 24 | #include "clang/AST/Decl.h" |
| 25 | |
| 26 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 27 | using namespace ento; |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 28 | |
| 29 | namespace { |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 30 | class NSAutoreleasePoolChecker |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 31 | : public CheckerVisitor<NSAutoreleasePoolChecker> { |
| 32 | |
| 33 | Selector releaseS; |
| 34 | |
| 35 | public: |
| 36 | NSAutoreleasePoolChecker(Selector release_s) : releaseS(release_s) {} |
| 37 | |
| 38 | static void *getTag() { |
| 39 | static int x = 0; |
| 40 | return &x; |
| 41 | } |
| 42 | |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 43 | void preVisitObjCMessage(CheckerContext &C, ObjCMessage msg); |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 44 | }; |
| 45 | |
| 46 | } // end anonymous namespace |
| 47 | |
| 48 | |
Argyrios Kyrtzidis | 695fb50 | 2011-02-17 21:39:17 +0000 | [diff] [blame] | 49 | static void RegisterNSAutoreleasePoolChecker(ExprEngine &Eng) { |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 50 | ASTContext &Ctx = Eng.getContext(); |
| 51 | if (Ctx.getLangOptions().getGCMode() != LangOptions::NonGC) { |
| 52 | Eng.registerCheck(new NSAutoreleasePoolChecker(GetNullarySelector("release", |
| 53 | Ctx))); |
| 54 | } |
| 55 | } |
| 56 | |
Argyrios Kyrtzidis | 695fb50 | 2011-02-17 21:39:17 +0000 | [diff] [blame] | 57 | void ento::registerNSAutoreleasePoolChecker(CheckerManager &mgr) { |
| 58 | mgr.addCheckerRegisterFunction(RegisterNSAutoreleasePoolChecker); |
| 59 | } |
| 60 | |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 61 | void |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 62 | NSAutoreleasePoolChecker::preVisitObjCMessage(CheckerContext &C, |
| 63 | ObjCMessage msg) { |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 64 | |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 65 | const Expr *receiver = msg.getInstanceReceiver(); |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 66 | if (!receiver) |
| 67 | return; |
| 68 | |
| 69 | // FIXME: Enhance with value-tracking information instead of consulting |
| 70 | // the type of the expression. |
| 71 | const ObjCObjectPointerType* PT = |
| 72 | receiver->getType()->getAs<ObjCObjectPointerType>(); |
Ted Kremenek | 71a5e28 | 2009-11-20 00:12:36 +0000 | [diff] [blame] | 73 | |
| 74 | if (!PT) |
| 75 | return; |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 76 | const ObjCInterfaceDecl* OD = PT->getInterfaceDecl(); |
| 77 | if (!OD) |
| 78 | return; |
| 79 | if (!OD->getIdentifier()->getName().equals("NSAutoreleasePool")) |
| 80 | return; |
| 81 | |
| 82 | // Sending 'release' message? |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 83 | if (msg.getSelector() != releaseS) |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 84 | return; |
| 85 | |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 86 | SourceRange R = msg.getSourceRange(); |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 87 | |
| 88 | C.getBugReporter().EmitBasicReport("Use -drain instead of -release", |
| 89 | "API Upgrade (Apple)", |
| 90 | "Use -drain instead of -release when using NSAutoreleasePool " |
Argyrios Kyrtzidis | 432424d | 2011-01-25 00:03:53 +0000 | [diff] [blame] | 91 | "and garbage collection", R.getBegin(), &R, 1); |
Ted Kremenek | 54cb7cc | 2009-11-03 08:03:59 +0000 | [diff] [blame] | 92 | } |