blob: 4eabd7aaf3fcedea97121280354031681bd4cb6d [file] [log] [blame]
Ted Kremenek54cb7cc2009-11-03 08:03:59 +00001//=- NSAutoreleasePoolChecker.cpp --------------------------------*- C++ -*-==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines a NSAutoreleasePoolChecker, a small checker that warns
11// about subpar uses of NSAutoreleasePool. Note that while the check itself
Jordy Rosed1e5a892011-09-02 08:02:59 +000012// (in its current form) could be written as a flow-insensitive check, in
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000013// can be potentially enhanced in the future with flow-sensitive information.
14// It is also a good example of the CheckerVisitor interface.
15//
16//===----------------------------------------------------------------------===//
17
Argyrios Kyrtzidis0b1ba622011-02-16 01:40:52 +000018#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000019#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000020#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000021#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
Jordy Rosed1e5a892011-09-02 08:02:59 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000023#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Jordy Rosed1e5a892011-09-02 08:02:59 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000025#include "clang/AST/DeclObjC.h"
26#include "clang/AST/Decl.h"
27
28using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000029using namespace ento;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000030
31namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +000032class NSAutoreleasePoolChecker
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000033 : public Checker<check::PreObjCMessage> {
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000034
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000035 mutable Selector releaseS;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000036
37public:
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000038 void checkPreObjCMessage(ObjCMessage msg, CheckerContext &C) const;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000039};
40
41} // end anonymous namespace
42
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000043void NSAutoreleasePoolChecker::checkPreObjCMessage(ObjCMessage msg,
44 CheckerContext &C) const {
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000045
Argyrios Kyrtzidis432424d2011-01-25 00:03:53 +000046 const Expr *receiver = msg.getInstanceReceiver();
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000047 if (!receiver)
48 return;
49
50 // FIXME: Enhance with value-tracking information instead of consulting
51 // the type of the expression.
52 const ObjCObjectPointerType* PT =
53 receiver->getType()->getAs<ObjCObjectPointerType>();
Ted Kremenek71a5e282009-11-20 00:12:36 +000054
55 if (!PT)
56 return;
Ted Kremenek9c378f72011-08-12 23:37:29 +000057 const ObjCInterfaceDecl *OD = PT->getInterfaceDecl();
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000058 if (!OD)
59 return;
60 if (!OD->getIdentifier()->getName().equals("NSAutoreleasePool"))
61 return;
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000062
63 if (releaseS.isNull())
64 releaseS = GetNullarySelector("release", C.getASTContext());
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000065 // Sending 'release' message?
Argyrios Kyrtzidis432424d2011-01-25 00:03:53 +000066 if (msg.getSelector() != releaseS)
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000067 return;
68
Argyrios Kyrtzidis432424d2011-01-25 00:03:53 +000069 SourceRange R = msg.getSourceRange();
Anna Zaks590dd8e2011-09-20 21:38:35 +000070 const LocationContext *LC = C.getPredecessor()->getLocationContext();
Anna Zaks6a93bd52011-10-25 19:57:11 +000071 const SourceManager &SM = C.getSourceManager();
Anna Zaks590dd8e2011-09-20 21:38:35 +000072 const Expr *E = msg.getMsgOrPropExpr();
73 PathDiagnosticLocation L = PathDiagnosticLocation::createBegin(E, SM, LC);
Anna Zaks6a93bd52011-10-25 19:57:11 +000074 C.EmitBasicReport("Use -drain instead of -release",
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000075 "API Upgrade (Apple)",
76 "Use -drain instead of -release when using NSAutoreleasePool "
Anna Zaks590dd8e2011-09-20 21:38:35 +000077 "and garbage collection", L, &R, 1);
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000078}
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000079
80void ento::registerNSAutoreleasePoolChecker(CheckerManager &mgr) {
Douglas Gregore289d812011-09-13 17:21:33 +000081 if (mgr.getLangOptions().getGC() != LangOptions::NonGC)
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000082 mgr.registerChecker<NSAutoreleasePoolChecker>();
83}