Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 19 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 25 | #include "clang/Basic/SourceManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 28 | #include "llvm/ADT/STLExtras.h" |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 29 | #include <climits> |
| 30 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 31 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 32 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 33 | |
| 34 | namespace { |
| 35 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 36 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 37 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 38 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | const Stmt *S; |
| 40 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 41 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 43 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 44 | bool isAllocated() const { return K == AllocateUnchecked; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 45 | bool isReleased() const { return K == Released; } |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 46 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 47 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 48 | |
| 49 | bool operator==(const RefState &X) const { |
| 50 | return K == X.K && S == X.S; |
| 51 | } |
| 52 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 53 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 54 | return RefState(AllocateUnchecked, s); |
| 55 | } |
| 56 | static RefState getAllocateFailed() { |
| 57 | return RefState(AllocateFailed, 0); |
| 58 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 59 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 60 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 61 | static RefState getRelinquished(const Stmt *s) { |
| 62 | return RefState(Relinquished, s); |
| 63 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 64 | |
| 65 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 66 | ID.AddInteger(K); |
| 67 | ID.AddPointer(S); |
| 68 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 69 | }; |
| 70 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 71 | struct ReallocPair { |
| 72 | SymbolRef ReallocatedSym; |
| 73 | bool IsFreeOnFailure; |
| 74 | ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {} |
| 75 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 76 | ID.AddInteger(IsFreeOnFailure); |
| 77 | ID.AddPointer(ReallocatedSym); |
| 78 | } |
| 79 | bool operator==(const ReallocPair &X) const { |
| 80 | return ReallocatedSym == X.ReallocatedSym && |
| 81 | IsFreeOnFailure == X.IsFreeOnFailure; |
| 82 | } |
| 83 | }; |
| 84 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 85 | class MallocChecker : public Checker<check::DeadSymbols, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 86 | check::EndPath, |
| 87 | check::PreStmt<ReturnStmt>, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 88 | check::PreStmt<CallExpr>, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 89 | check::PostStmt<CallExpr>, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 90 | check::Location, |
| 91 | check::Bind, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 92 | eval::Assume, |
| 93 | check::RegionChanges> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 94 | { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 95 | mutable OwningPtr<BugType> BT_DoubleFree; |
| 96 | mutable OwningPtr<BugType> BT_Leak; |
| 97 | mutable OwningPtr<BugType> BT_UseFree; |
| 98 | mutable OwningPtr<BugType> BT_BadFree; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 99 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 100 | *II_valloc, *II_reallocf, *II_strndup, *II_strdup; |
| 101 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 102 | public: |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 103 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 104 | II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 105 | |
| 106 | /// In pessimistic mode, the checker assumes that it does not know which |
| 107 | /// functions might free the memory. |
| 108 | struct ChecksFilter { |
| 109 | DefaultBool CMallocPessimistic; |
| 110 | DefaultBool CMallocOptimistic; |
| 111 | }; |
| 112 | |
| 113 | ChecksFilter Filter; |
| 114 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 115 | void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 116 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 117 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 118 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 119 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 120 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 121 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 122 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 123 | CheckerContext &C) const; |
| 124 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 125 | CheckerContext &C) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 126 | ProgramStateRef |
| 127 | checkRegionChanges(ProgramStateRef state, |
| 128 | const StoreManager::InvalidatedSymbols *invalidated, |
| 129 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 130 | ArrayRef<const MemRegion *> Regions, |
| 131 | const CallOrObjCMessage *Call) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 132 | bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| 133 | return true; |
| 134 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 135 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 136 | private: |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 137 | void initIdentifierInfo(ASTContext &C) const; |
| 138 | |
| 139 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 140 | /// pointed to by one of its arguments. |
| 141 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| 142 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 143 | static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 144 | const CallExpr *CE, |
| 145 | const OwnershipAttr* Att); |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 146 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 147 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 148 | ProgramStateRef state) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 149 | return MallocMemAux(C, CE, |
| 150 | state->getSVal(SizeEx, C.getLocationContext()), |
| 151 | Init, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 152 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 153 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 154 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 155 | SVal SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 156 | ProgramStateRef state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 157 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 158 | /// Update the RefState to reflect the new memory allocation. |
| 159 | static ProgramStateRef MallocUpdateRefState(CheckerContext &C, |
| 160 | const CallExpr *CE, |
| 161 | ProgramStateRef state); |
| 162 | |
| 163 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| 164 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 165 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 166 | ProgramStateRef state, unsigned Num, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 167 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 168 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 169 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
| 170 | bool FreesMemOnFailure) const; |
| 171 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 172 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 173 | bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| 174 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 175 | const Stmt *S = 0) const; |
| 176 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 177 | /// Check if the function is not known to us. So, for example, we could |
| 178 | /// conservatively assume it can free/reallocate it's pointer arguments. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 179 | bool doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 180 | ProgramStateRef State) const; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 181 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 182 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 183 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 184 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 185 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 186 | /// Find the location of the allocation for Sym on the path leading to the |
| 187 | /// exploded node N. |
| 188 | const Stmt *getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 189 | CheckerContext &C) const; |
| 190 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 191 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 192 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 193 | /// The bug visitor which allows us to print extra diagnostics along the |
| 194 | /// BugReport path. For example, showing the allocation site of the leaked |
| 195 | /// region. |
| 196 | class MallocBugVisitor : public BugReporterVisitor { |
| 197 | protected: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 198 | enum NotificationMode { |
| 199 | Normal, |
| 200 | Complete, |
| 201 | ReallocationFailed |
| 202 | }; |
| 203 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 204 | // The allocated region symbol tracked by the main analysis. |
| 205 | SymbolRef Sym; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 206 | NotificationMode Mode; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 207 | |
| 208 | public: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 209 | MallocBugVisitor(SymbolRef S) : Sym(S), Mode(Normal) {} |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 210 | virtual ~MallocBugVisitor() {} |
| 211 | |
| 212 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 213 | static int X = 0; |
| 214 | ID.AddPointer(&X); |
| 215 | ID.AddPointer(Sym); |
| 216 | } |
| 217 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 218 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 219 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 220 | // Did not track -> allocated. Other state (released) -> allocated. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 221 | return (Stmt && isa<CallExpr>(Stmt) && |
| 222 | (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 223 | } |
| 224 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 225 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 226 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 227 | // Did not track -> released. Other state (allocated) -> released. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 228 | return (Stmt && isa<CallExpr>(Stmt) && |
| 229 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 230 | } |
| 231 | |
| 232 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 233 | const Stmt *Stmt) { |
| 234 | // If the expression is not a call, and the state change is |
| 235 | // released -> allocated, it must be the realloc return value |
| 236 | // check. If we have to handle more cases here, it might be cleaner just |
| 237 | // to track this extra bit in the state itself. |
| 238 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| 239 | (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 240 | } |
| 241 | |
| 242 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 243 | const ExplodedNode *PrevN, |
| 244 | BugReporterContext &BRC, |
| 245 | BugReport &BR); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 246 | private: |
| 247 | class StackHintGeneratorForReallocationFailed |
| 248 | : public StackHintGeneratorForSymbol { |
| 249 | public: |
| 250 | StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M) |
| 251 | : StackHintGeneratorForSymbol(S, M) {} |
| 252 | |
| 253 | virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) { |
| 254 | SmallString<200> buf; |
| 255 | llvm::raw_svector_ostream os(buf); |
| 256 | |
| 257 | os << "; reallocation of "; |
| 258 | // Printed parameters start at 1, not 0. |
| 259 | printOrdinal(++ArgIndex, os); |
| 260 | os << " parameter failed"; |
| 261 | |
| 262 | return os.str(); |
| 263 | } |
| 264 | |
| 265 | virtual std::string getMessageForReturn(const CallExpr *CallExpr) { |
| 266 | return "; reallocation of returned value failed"; |
| 267 | } |
| 268 | }; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 269 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 270 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 271 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 272 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 273 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 274 | typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 275 | class RegionState {}; |
| 276 | class ReallocPairs {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 277 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 278 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 279 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 280 | struct ProgramStateTrait<RegionState> |
| 281 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 282 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 283 | }; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 284 | |
| 285 | template <> |
| 286 | struct ProgramStateTrait<ReallocPairs> |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 287 | : public ProgramStatePartialTrait<ReallocMap> { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 288 | static void *GDMIndex() { static int x; return &x; } |
| 289 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 290 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 291 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 292 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 293 | namespace { |
| 294 | class StopTrackingCallback : public SymbolVisitor { |
| 295 | ProgramStateRef state; |
| 296 | public: |
| 297 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 298 | ProgramStateRef getState() const { return state; } |
| 299 | |
| 300 | bool VisitSymbol(SymbolRef sym) { |
| 301 | state = state->remove<RegionState>(sym); |
| 302 | return true; |
| 303 | } |
| 304 | }; |
| 305 | } // end anonymous namespace |
| 306 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 307 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 308 | if (!II_malloc) |
| 309 | II_malloc = &Ctx.Idents.get("malloc"); |
| 310 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 311 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 312 | if (!II_realloc) |
| 313 | II_realloc = &Ctx.Idents.get("realloc"); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 314 | if (!II_reallocf) |
| 315 | II_reallocf = &Ctx.Idents.get("reallocf"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 316 | if (!II_calloc) |
| 317 | II_calloc = &Ctx.Idents.get("calloc"); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 318 | if (!II_valloc) |
| 319 | II_valloc = &Ctx.Idents.get("valloc"); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 320 | if (!II_strdup) |
| 321 | II_strdup = &Ctx.Idents.get("strdup"); |
| 322 | if (!II_strndup) |
| 323 | II_strndup = &Ctx.Idents.get("strndup"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 324 | } |
| 325 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 326 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 327 | if (!FD) |
| 328 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 329 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 330 | if (!FunI) |
| 331 | return false; |
| 332 | |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 333 | initIdentifierInfo(C); |
| 334 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 335 | if (FunI == II_malloc || FunI == II_free || FunI == II_realloc || |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 336 | FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc || |
| 337 | FunI == II_strdup || FunI == II_strndup) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 338 | return true; |
| 339 | |
| 340 | if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| 341 | FD->specific_attr_begin<OwnershipAttr>() != |
| 342 | FD->specific_attr_end<OwnershipAttr>()) |
| 343 | return true; |
| 344 | |
| 345 | |
| 346 | return false; |
| 347 | } |
| 348 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 349 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| 350 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 351 | if (!FD) |
| 352 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 353 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 354 | initIdentifierInfo(C.getASTContext()); |
| 355 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 356 | if (!FunI) |
| 357 | return; |
| 358 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 359 | ProgramStateRef State = C.getState(); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 360 | if (FunI == II_malloc || FunI == II_valloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 361 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 362 | } else if (FunI == II_realloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 363 | State = ReallocMem(C, CE, false); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 364 | } else if (FunI == II_reallocf) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 365 | State = ReallocMem(C, CE, true); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 366 | } else if (FunI == II_calloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 367 | State = CallocMem(C, CE); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 368 | } else if (FunI == II_free) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 369 | State = FreeMemAux(C, CE, C.getState(), 0, false); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 370 | } else if (FunI == II_strdup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 371 | State = MallocUpdateRefState(C, CE, State); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 372 | } else if (FunI == II_strndup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 373 | State = MallocUpdateRefState(C, CE, State); |
| 374 | } else if (Filter.CMallocOptimistic) { |
| 375 | // Check all the attributes, if there are any. |
| 376 | // There can be multiple of these attributes. |
| 377 | if (FD->hasAttrs()) |
| 378 | for (specific_attr_iterator<OwnershipAttr> |
| 379 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 380 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 381 | i != e; ++i) { |
| 382 | switch ((*i)->getOwnKind()) { |
| 383 | case OwnershipAttr::Returns: |
| 384 | State = MallocMemReturnsAttr(C, CE, *i); |
| 385 | break; |
| 386 | case OwnershipAttr::Takes: |
| 387 | case OwnershipAttr::Holds: |
| 388 | State = FreeMemAttr(C, CE, *i); |
| 389 | break; |
| 390 | } |
| 391 | } |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 392 | } |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 393 | C.addTransition(State); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 394 | } |
| 395 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 396 | ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C, |
| 397 | const CallExpr *CE, |
| 398 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 399 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 400 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 401 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 402 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 403 | if (I != E) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 404 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 405 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 406 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 407 | } |
| 408 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 409 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 410 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 411 | SVal Size, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 412 | ProgramStateRef state) { |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 413 | // Get the return value. |
| 414 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 415 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 416 | // We expect the malloc functions to return a pointer. |
| 417 | if (!isa<Loc>(retVal)) |
| 418 | return 0; |
| 419 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 420 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 421 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 422 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 423 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 424 | const SymbolicRegion *R = |
| 425 | dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 426 | if (!R) |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 427 | return 0; |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 428 | if (isa<DefinedOrUnknownSVal>(Size)) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 429 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 430 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
| 431 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
| 432 | DefinedOrUnknownSVal extentMatchesSize = |
| 433 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 434 | |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 435 | state = state->assume(extentMatchesSize, true); |
| 436 | assert(state); |
| 437 | } |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 438 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 439 | return MallocUpdateRefState(C, CE, state); |
| 440 | } |
| 441 | |
| 442 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
| 443 | const CallExpr *CE, |
| 444 | ProgramStateRef state) { |
| 445 | // Get the return value. |
| 446 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
| 447 | |
| 448 | // We expect the malloc functions to return a pointer. |
| 449 | if (!isa<Loc>(retVal)) |
| 450 | return 0; |
| 451 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 452 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 453 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 454 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 455 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 456 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 457 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 458 | } |
| 459 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 460 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 461 | const CallExpr *CE, |
| 462 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 463 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 464 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 465 | |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 466 | ProgramStateRef State = C.getState(); |
| 467 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 468 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 469 | I != E; ++I) { |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 470 | ProgramStateRef StateI = FreeMemAux(C, CE, State, *I, |
| 471 | Att->getOwnKind() == OwnershipAttr::Holds); |
| 472 | if (StateI) |
| 473 | State = StateI; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 474 | } |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 475 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 476 | } |
| 477 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 478 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 479 | const CallExpr *CE, |
| 480 | ProgramStateRef state, |
| 481 | unsigned Num, |
| 482 | bool Hold) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 483 | const Expr *ArgExpr = CE->getArg(Num); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 484 | SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 485 | if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| 486 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 487 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 488 | |
| 489 | // Check for null dereferences. |
| 490 | if (!isa<Loc>(location)) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 491 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 492 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 493 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 494 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 495 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 496 | if (nullState && !notNullState) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 497 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 498 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 499 | // Unknown values could easily be okay |
| 500 | // Undefined values are handled elsewhere |
| 501 | if (ArgVal.isUnknownOrUndef()) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 502 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 503 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 504 | const MemRegion *R = ArgVal.getAsRegion(); |
| 505 | |
| 506 | // Nonlocs can't be freed, of course. |
| 507 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 508 | if (!R) { |
| 509 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 510 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 511 | } |
| 512 | |
| 513 | R = R->StripCasts(); |
| 514 | |
| 515 | // Blocks might show up as heap data, but should not be free()d |
| 516 | if (isa<BlockDataRegion>(R)) { |
| 517 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 518 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 519 | } |
| 520 | |
| 521 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 522 | |
| 523 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 524 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 525 | // FIXME: at the time this code was written, malloc() regions were |
| 526 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 527 | // This means that there isn't actually anything from HeapSpaceRegion |
| 528 | // that should be freed, even though we allow it here. |
| 529 | // Of course, free() can work on memory allocated outside the current |
| 530 | // function, so UnknownSpaceRegion is always a possibility. |
| 531 | // False negatives are better than false positives. |
| 532 | |
| 533 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 534 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 535 | } |
| 536 | |
| 537 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 538 | // Various cases could lead to non-symbol values here. |
| 539 | // For now, ignore them. |
| 540 | if (!SR) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 541 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 542 | |
| 543 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 544 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 545 | |
| 546 | // If the symbol has not been tracked, return. This is possible when free() is |
| 547 | // called on a pointer that does not get its pointee directly from malloc(). |
| 548 | // Full support of this requires inter-procedural analysis. |
| 549 | if (!RS) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 550 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 551 | |
| 552 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 553 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 554 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 555 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 556 | BT_DoubleFree.reset( |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 557 | new BugType("Double free", "Memory Error")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 558 | BugReport *R = new BugReport(*BT_DoubleFree, |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 559 | "Attempt to free released memory", N); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 560 | R->addRange(ArgExpr->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 561 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 562 | R->addVisitor(new MallocBugVisitor(Sym)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 563 | C.EmitReport(R); |
| 564 | } |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 565 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 566 | } |
| 567 | |
| 568 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 569 | if (Hold) |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 570 | return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 571 | return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 572 | } |
| 573 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 574 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 575 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 576 | os << "an integer (" << IntVal->getValue() << ")"; |
| 577 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 578 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 579 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 580 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 581 | else |
| 582 | return false; |
| 583 | |
| 584 | return true; |
| 585 | } |
| 586 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 587 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 588 | const MemRegion *MR) { |
| 589 | switch (MR->getKind()) { |
| 590 | case MemRegion::FunctionTextRegionKind: { |
| 591 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 592 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 593 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 594 | else |
| 595 | os << "the address of a function"; |
| 596 | return true; |
| 597 | } |
| 598 | case MemRegion::BlockTextRegionKind: |
| 599 | os << "block text"; |
| 600 | return true; |
| 601 | case MemRegion::BlockDataRegionKind: |
| 602 | // FIXME: where the block came from? |
| 603 | os << "a block"; |
| 604 | return true; |
| 605 | default: { |
| 606 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 607 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 608 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 609 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 610 | const VarDecl *VD; |
| 611 | if (VR) |
| 612 | VD = VR->getDecl(); |
| 613 | else |
| 614 | VD = NULL; |
| 615 | |
| 616 | if (VD) |
| 617 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 618 | else |
| 619 | os << "the address of a local stack variable"; |
| 620 | return true; |
| 621 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 622 | |
| 623 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 624 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 625 | const VarDecl *VD; |
| 626 | if (VR) |
| 627 | VD = VR->getDecl(); |
| 628 | else |
| 629 | VD = NULL; |
| 630 | |
| 631 | if (VD) |
| 632 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 633 | else |
| 634 | os << "the address of a parameter"; |
| 635 | return true; |
| 636 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 637 | |
| 638 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 639 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 640 | const VarDecl *VD; |
| 641 | if (VR) |
| 642 | VD = VR->getDecl(); |
| 643 | else |
| 644 | VD = NULL; |
| 645 | |
| 646 | if (VD) { |
| 647 | if (VD->isStaticLocal()) |
| 648 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 649 | else |
| 650 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 651 | } else |
| 652 | os << "the address of a global variable"; |
| 653 | return true; |
| 654 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 655 | |
| 656 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 657 | } |
| 658 | } |
| 659 | } |
| 660 | |
| 661 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 662 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 663 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 664 | if (!BT_BadFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 665 | BT_BadFree.reset(new BugType("Bad free", "Memory Error")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 666 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 667 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 668 | llvm::raw_svector_ostream os(buf); |
| 669 | |
| 670 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 671 | if (MR) { |
| 672 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 673 | MR = ER->getSuperRegion(); |
| 674 | |
| 675 | // Special case for alloca() |
| 676 | if (isa<AllocaRegion>(MR)) |
| 677 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 678 | else { |
| 679 | os << "Argument to free() is "; |
| 680 | if (SummarizeRegion(os, MR)) |
| 681 | os << ", which is not memory allocated by malloc()"; |
| 682 | else |
| 683 | os << "not memory allocated by malloc()"; |
| 684 | } |
| 685 | } else { |
| 686 | os << "Argument to free() is "; |
| 687 | if (SummarizeValue(os, ArgVal)) |
| 688 | os << ", which is not memory allocated by malloc()"; |
| 689 | else |
| 690 | os << "not memory allocated by malloc()"; |
| 691 | } |
| 692 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 693 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 694 | R->markInteresting(MR); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 695 | R->addRange(range); |
| 696 | C.EmitReport(R); |
| 697 | } |
| 698 | } |
| 699 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 700 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 701 | const CallExpr *CE, |
| 702 | bool FreesOnFail) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 703 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 704 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 705 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 706 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| 707 | if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 708 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 709 | DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 710 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 711 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 712 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 713 | DefinedOrUnknownSVal PtrEQ = |
| 714 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 715 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 716 | // Get the size argument. If there is no size arg then give up. |
| 717 | const Expr *Arg1 = CE->getArg(1); |
| 718 | if (!Arg1) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 719 | return 0; |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 720 | |
| 721 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 722 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| 723 | if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 724 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 725 | DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 726 | |
| 727 | // Compare the size argument to 0. |
| 728 | DefinedOrUnknownSVal SizeZero = |
| 729 | svalBuilder.evalEQ(state, Arg1Val, |
| 730 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 731 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 732 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| 733 | llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| 734 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| 735 | llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| 736 | // We only assume exceptional states if they are definitely true; if the |
| 737 | // state is under-constrained, assume regular realloc behavior. |
| 738 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 739 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 740 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 741 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 742 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 743 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 744 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 745 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 746 | return stateMalloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 747 | } |
| 748 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 749 | if (PrtIsNull && SizeIsZero) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 750 | return 0; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 751 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 752 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 753 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 754 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 755 | SVal RetVal = state->getSVal(CE, LCtx); |
| 756 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 757 | if (!FromPtr || !ToPtr) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 758 | return 0; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 759 | |
| 760 | // If the size is 0, free the memory. |
| 761 | if (SizeIsZero) |
| 762 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 763 | // The semantics of the return value are: |
| 764 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
| 765 | // to free() is returned. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 766 | stateFree = stateFree->set<ReallocPairs>(ToPtr, |
| 767 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 768 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 769 | return stateFree; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 770 | } |
| 771 | |
| 772 | // Default behavior. |
| 773 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| 774 | // FIXME: We should copy the content of the original buffer. |
| 775 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 776 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 777 | if (!stateRealloc) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 778 | return 0; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 779 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
| 780 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 781 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 782 | return stateRealloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 783 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 784 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 785 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 786 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 787 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){ |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 788 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 789 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 790 | const LocationContext *LCtx = C.getLocationContext(); |
| 791 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 792 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 793 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 794 | svalBuilder.getContext().getSizeType()); |
| 795 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 796 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 797 | return MallocMemAux(C, CE, TotalSize, zeroVal, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 798 | } |
| 799 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 800 | const Stmt * |
| 801 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 802 | CheckerContext &C) const { |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 803 | const LocationContext *LeakContext = N->getLocationContext(); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 804 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 805 | // the tracked symbol. |
| 806 | const ExplodedNode *AllocNode = N; |
| 807 | |
| 808 | while (N) { |
| 809 | if (!N->getState()->get<RegionState>(Sym)) |
| 810 | break; |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 811 | // Allocation node, is the last node in the current context in which the |
| 812 | // symbol was tracked. |
| 813 | if (N->getLocationContext() == LeakContext) |
| 814 | AllocNode = N; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 815 | N = N->pred_empty() ? NULL : *(N->pred_begin()); |
| 816 | } |
| 817 | |
| 818 | ProgramPoint P = AllocNode->getLocation(); |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 819 | if (!isa<StmtPoint>(P)) |
| 820 | return 0; |
| 821 | |
| 822 | return cast<StmtPoint>(P).getStmt(); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 823 | } |
| 824 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 825 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 826 | CheckerContext &C) const { |
| 827 | assert(N); |
| 828 | if (!BT_Leak) { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 829 | BT_Leak.reset(new BugType("Memory leak", "Memory Error")); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 830 | // Leaks should not be reported if they are post-dominated by a sink: |
| 831 | // (1) Sinks are higher importance bugs. |
| 832 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 833 | // with __noreturn functions such as assert() or exit(). We choose not |
| 834 | // to report leaks on such paths. |
| 835 | BT_Leak->setSuppressOnSink(true); |
| 836 | } |
| 837 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 838 | // Most bug reports are cached at the location where they occurred. |
| 839 | // With leaks, we want to unique them by the location where they were |
| 840 | // allocated, and only report a single path. |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 841 | PathDiagnosticLocation LocUsedForUniqueing; |
| 842 | if (const Stmt *AllocStmt = getAllocationSite(N, Sym, C)) |
| 843 | LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt, |
| 844 | C.getSourceManager(), N->getLocationContext()); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 845 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 846 | BugReport *R = new BugReport(*BT_Leak, |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 847 | "Memory is never released; potential memory leak", N, LocUsedForUniqueing); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 848 | R->markInteresting(Sym); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 849 | R->addVisitor(new MallocBugVisitor(Sym)); |
| 850 | C.EmitReport(R); |
| 851 | } |
| 852 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 853 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 854 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 855 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 856 | if (!SymReaper.hasDeadSymbols()) |
| 857 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 858 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 859 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 860 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 861 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 862 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 863 | bool generateReport = false; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 864 | llvm::SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 865 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 866 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 867 | if (I->second.isAllocated()) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 868 | generateReport = true; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 869 | Errors.push_back(I->first); |
| 870 | } |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 871 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 872 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 873 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 874 | } |
| 875 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 876 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 877 | // Cleanup the Realloc Pairs Map. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 878 | ReallocMap RP = state->get<ReallocPairs>(); |
| 879 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 880 | if (SymReaper.isDead(I->first) || |
| 881 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 882 | state = state->remove<ReallocPairs>(I->first); |
| 883 | } |
| 884 | } |
| 885 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 886 | // Generate leak node. |
| 887 | static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak"); |
| 888 | ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 889 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 890 | if (generateReport) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 891 | for (llvm::SmallVector<SymbolRef, 2>::iterator |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 892 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| 893 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 894 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 895 | } |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 896 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 897 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 898 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 899 | void MallocChecker::checkEndPath(CheckerContext &C) const { |
| 900 | ProgramStateRef state = C.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 901 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 902 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 903 | // If inside inlined call, skip it. |
| 904 | if (C.getLocationContext()->getParent() != 0) |
| 905 | return; |
| 906 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 907 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 908 | RefState RS = I->second; |
| 909 | if (RS.isAllocated()) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 910 | ExplodedNode *N = C.addTransition(state); |
| 911 | if (N) |
| 912 | reportLeak(I->first, N, C); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 913 | } |
| 914 | } |
| 915 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 916 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 917 | bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| 918 | CheckerContext &C) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 919 | ProgramStateRef state = C.getState(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 920 | const RefState *RS = state->get<RegionState>(Sym); |
| 921 | if (!RS) |
| 922 | return false; |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 923 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 924 | if (RS->isAllocated()) { |
| 925 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 926 | C.addTransition(state); |
| 927 | return true; |
| 928 | } |
| 929 | return false; |
| 930 | } |
| 931 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 932 | void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| 933 | if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| 934 | return; |
| 935 | |
| 936 | // Check use after free, when a freed pointer is passed to a call. |
| 937 | ProgramStateRef State = C.getState(); |
| 938 | for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| 939 | E = CE->arg_end(); I != E; ++I) { |
| 940 | const Expr *A = *I; |
| 941 | if (A->getType().getTypePtr()->isAnyPointerType()) { |
| 942 | SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| 943 | if (!Sym) |
| 944 | continue; |
| 945 | if (checkUseAfterFree(Sym, C, A)) |
| 946 | return; |
| 947 | } |
| 948 | } |
| 949 | } |
| 950 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 951 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 952 | const Expr *E = S->getRetValue(); |
| 953 | if (!E) |
| 954 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 955 | |
| 956 | // Check if we are returning a symbol. |
Anna Zaks | d9ab7bb | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 957 | SVal RetVal = C.getState()->getSVal(E, C.getLocationContext()); |
| 958 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 959 | if (!Sym) |
| 960 | // If we are returning a field of the allocated struct or an array element, |
| 961 | // the callee could still free the memory. |
| 962 | // TODO: This logic should be a part of generic symbol escape callback. |
| 963 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 964 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 965 | if (const SymbolicRegion *BMR = |
| 966 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 967 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 968 | if (!Sym) |
| 969 | return; |
| 970 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 971 | // Check if we are returning freed memory. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 972 | if (checkUseAfterFree(Sym, C, E)) |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 973 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 974 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 975 | // If this function body is not inlined, check if the symbol is escaping. |
| 976 | if (C.getLocationContext()->getParent() == 0) |
| 977 | checkEscape(Sym, E, C); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 978 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 979 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 980 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 981 | const Stmt *S) const { |
| 982 | assert(Sym); |
| 983 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 984 | if (RS && RS->isReleased()) { |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 985 | if (ExplodedNode *N = C.generateSink()) { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 986 | if (!BT_UseFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 987 | BT_UseFree.reset(new BugType("Use-after-free", "Memory Error")); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 988 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 989 | BugReport *R = new BugReport(*BT_UseFree, |
| 990 | "Use of memory after it is freed",N); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 991 | if (S) |
| 992 | R->addRange(S->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 993 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 994 | R->addVisitor(new MallocBugVisitor(Sym)); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 995 | C.EmitReport(R); |
| 996 | return true; |
| 997 | } |
| 998 | } |
| 999 | return false; |
| 1000 | } |
| 1001 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1002 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 1003 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 1004 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1005 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1006 | if (Sym) |
| 1007 | checkUseAfterFree(Sym, C); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1008 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1009 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1010 | //===----------------------------------------------------------------------===// |
| 1011 | // Check various ways a symbol can be invalidated. |
| 1012 | // TODO: This logic (the next 3 functions) is copied/similar to the |
| 1013 | // RetainRelease checker. We might want to factor this out. |
| 1014 | //===----------------------------------------------------------------------===// |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1015 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1016 | // Stop tracking symbols when a value escapes as a result of checkBind. |
| 1017 | // A value escapes in three possible cases: |
| 1018 | // (1) we are binding to something that is not a memory region. |
| 1019 | // (2) we are binding to a memregion that does not have stack storage |
| 1020 | // (3) we are binding to a memregion with stack storage that the store |
| 1021 | // does not understand. |
| 1022 | void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| 1023 | CheckerContext &C) const { |
| 1024 | // Are we storing to something that causes the value to "escape"? |
| 1025 | bool escapes = true; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1026 | ProgramStateRef state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1027 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1028 | if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| 1029 | escapes = !regionLoc->getRegion()->hasStackStorage(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1030 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1031 | if (!escapes) { |
| 1032 | // To test (3), generate a new state with the binding added. If it is |
| 1033 | // the same state, then it escapes (since the store cannot represent |
| 1034 | // the binding). |
| 1035 | escapes = (state == (state->bindLoc(*regionLoc, val))); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1036 | } |
Anna Zaks | ac59300 | 2012-02-16 03:40:57 +0000 | [diff] [blame] | 1037 | if (!escapes) { |
| 1038 | // Case 4: We do not currently model what happens when a symbol is |
| 1039 | // assigned to a struct field, so be conservative here and let the symbol |
| 1040 | // go. TODO: This could definitely be improved upon. |
| 1041 | escapes = !isa<VarRegion>(regionLoc->getRegion()); |
| 1042 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1043 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1044 | |
| 1045 | // If our store can represent the binding and we aren't storing to something |
| 1046 | // that doesn't have local storage then just return and have the simulation |
| 1047 | // state continue as is. |
| 1048 | if (!escapes) |
| 1049 | return; |
| 1050 | |
| 1051 | // Otherwise, find all symbols referenced by 'val' that we are tracking |
| 1052 | // and stop tracking them. |
| 1053 | state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| 1054 | C.addTransition(state); |
| 1055 | } |
| 1056 | |
| 1057 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 1058 | // it - assuming that allocation failed on this path. |
| 1059 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 1060 | SVal Cond, |
| 1061 | bool Assumption) const { |
| 1062 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1063 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 1064 | // If the symbol is assumed to NULL or another constant, this will |
| 1065 | // return an APSInt*. |
| 1066 | if (state->getSymVal(I.getKey())) |
| 1067 | state = state->remove<RegionState>(I.getKey()); |
| 1068 | } |
| 1069 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1070 | // Realloc returns 0 when reallocation fails, which means that we should |
| 1071 | // restore the state of the pointer being reallocated. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1072 | ReallocMap RP = state->get<ReallocPairs>(); |
| 1073 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1074 | // If the symbol is assumed to NULL or another constant, this will |
| 1075 | // return an APSInt*. |
| 1076 | if (state->getSymVal(I.getKey())) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1077 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 1078 | const RefState *RS = state->get<RegionState>(ReallocSym); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1079 | if (RS) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1080 | if (RS->isReleased() && ! I.getData().IsFreeOnFailure) |
| 1081 | state = state->set<RegionState>(ReallocSym, |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1082 | RefState::getAllocateUnchecked(RS->getStmt())); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1083 | } |
| 1084 | state = state->remove<ReallocPairs>(I.getKey()); |
| 1085 | } |
| 1086 | } |
| 1087 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1088 | return state; |
| 1089 | } |
| 1090 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1091 | // Check if the function is known to us. So, for example, we could |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1092 | // conservatively assume it can free/reallocate it's pointer arguments. |
| 1093 | // (We assume that the pointers cannot escape through calls to system |
| 1094 | // functions not handled by this checker.) |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1095 | bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 1096 | ProgramStateRef State) const { |
| 1097 | if (!Call) |
| 1098 | return false; |
| 1099 | |
| 1100 | // For now, assume that any C++ call can free memory. |
| 1101 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 1102 | // regions escape to C++ containers. They seem to do that even now, but for |
| 1103 | // mysterious reasons. |
| 1104 | if (Call->isCXXCall()) |
| 1105 | return false; |
| 1106 | |
| 1107 | const Decl *D = Call->getDecl(); |
| 1108 | if (!D) |
| 1109 | return false; |
| 1110 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1111 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 1112 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1113 | // If it's one of the allocation functions we can reason about, we model |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1114 | // its behavior explicitly. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1115 | if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) { |
| 1116 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1117 | } |
| 1118 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1119 | // If it's not a system call, assume it frees memory. |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1120 | SourceManager &SM = ASTC.getSourceManager(); |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1121 | if (!SM.isInSystemHeader(D->getLocation())) |
| 1122 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1123 | |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1124 | // Process C/ObjC functions. |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1125 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1126 | // White list the system functions whose arguments escape. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1127 | const IdentifierInfo *II = FD->getIdentifier(); |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1128 | if (!II) |
| 1129 | return true; |
| 1130 | StringRef FName = II->getName(); |
| 1131 | |
| 1132 | // White list thread local storage. |
| 1133 | if (FName.equals("pthread_setspecific")) |
| 1134 | return false; |
| 1135 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1136 | // White list the 'XXXNoCopy' ObjC functions. |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1137 | if (FName.endswith("NoCopy")) { |
| 1138 | // Look for the deallocator argument. We know that the memory ownership |
| 1139 | // is not transfered only if the deallocator argument is |
| 1140 | // 'kCFAllocatorNull'. |
| 1141 | for (unsigned i = 1; i < Call->getNumArgs(); ++i) { |
| 1142 | const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts(); |
| 1143 | if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) { |
| 1144 | StringRef DeallocatorName = DE->getFoundDecl()->getName(); |
| 1145 | if (DeallocatorName == "kCFAllocatorNull") |
| 1146 | return true; |
| 1147 | } |
| 1148 | } |
| 1149 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1150 | } |
| 1151 | |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 1152 | // PR12101 |
| 1153 | // Many CoreFoundation and CoreGraphics might allow a tracked object |
| 1154 | // to escape. |
| 1155 | if (Call->isCFCGAllowingEscape(FName)) |
| 1156 | return false; |
| 1157 | |
| 1158 | // Associating streams with malloced buffers. The pointer can escape if |
| 1159 | // 'closefn' is specified (and if that function does free memory). |
| 1160 | // Currently, we do not inspect the 'closefn' function (PR12101). |
| 1161 | if (FName == "funopen") |
| 1162 | if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0)) |
| 1163 | return false; |
| 1164 | |
| 1165 | // Do not warn on pointers passed to 'setbuf' when used with std streams, |
| 1166 | // these leaks might be intentional when setting the buffer for stdio. |
| 1167 | // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer |
| 1168 | if (FName == "setbuf" || FName =="setbuffer" || |
| 1169 | FName == "setlinebuf" || FName == "setvbuf") { |
| 1170 | if (Call->getNumArgs() >= 1) |
| 1171 | if (const DeclRefExpr *Arg = |
| 1172 | dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts())) |
| 1173 | if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl())) |
| 1174 | if (D->getCanonicalDecl()->getName().find("std") |
| 1175 | != StringRef::npos) |
| 1176 | return false; |
| 1177 | } |
| 1178 | |
| 1179 | // A bunch of other functions, which take ownership of a pointer (See retain |
| 1180 | // release checker). Not all the parameters here are invalidated, but the |
| 1181 | // Malloc checker cannot differentiate between them. The right way of doing |
| 1182 | // this would be to implement a pointer escapes callback. |
| 1183 | if (FName == "CVPixelBufferCreateWithBytes" || |
| 1184 | FName == "CGBitmapContextCreateWithData" || |
| 1185 | FName == "CVPixelBufferCreateWithPlanarBytes") { |
| 1186 | return false; |
| 1187 | } |
| 1188 | |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1189 | // Otherwise, assume that the function does not free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1190 | // Most system calls, do not free the memory. |
| 1191 | return true; |
| 1192 | |
| 1193 | // Process ObjC functions. |
| 1194 | } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) { |
| 1195 | Selector S = ObjCD->getSelector(); |
| 1196 | |
| 1197 | // White list the ObjC functions which do free memory. |
| 1198 | // - Anything containing 'freeWhenDone' param set to 1. |
| 1199 | // Ex: dataWithBytesNoCopy:length:freeWhenDone. |
| 1200 | for (unsigned i = 1; i < S.getNumArgs(); ++i) { |
| 1201 | if (S.getNameForSlot(i).equals("freeWhenDone")) { |
| 1202 | if (Call->getArgSVal(i).isConstant(1)) |
| 1203 | return false; |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1204 | else |
| 1205 | return true; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1206 | } |
| 1207 | } |
| 1208 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1209 | // If the first selector ends with NoCopy, assume that the ownership is |
| 1210 | // transfered as well. |
| 1211 | // Ex: [NSData dataWithBytesNoCopy:bytes length:10]; |
| 1212 | if (S.getNameForSlot(0).endswith("NoCopy")) { |
| 1213 | return false; |
| 1214 | } |
| 1215 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1216 | // Otherwise, assume that the function does not free memory. |
| 1217 | // Most system calls, do not free the memory. |
| 1218 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1219 | } |
| 1220 | |
| 1221 | // Otherwise, assume that the function can free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1222 | return false; |
| 1223 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1224 | } |
| 1225 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1226 | // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| 1227 | // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| 1228 | // about it anymore. |
| 1229 | ProgramStateRef |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1230 | MallocChecker::checkRegionChanges(ProgramStateRef State, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1231 | const StoreManager::InvalidatedSymbols *invalidated, |
| 1232 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1233 | ArrayRef<const MemRegion *> Regions, |
| 1234 | const CallOrObjCMessage *Call) const { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1235 | if (!invalidated || invalidated->empty()) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1236 | return State; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1237 | llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1238 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1239 | // If it's a call which might free or reallocate memory, we assume that all |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1240 | // regions (explicit and implicit) escaped. |
| 1241 | |
| 1242 | // Otherwise, whitelist explicit pointers; we still can track them. |
| 1243 | if (!Call || doesNotFreeMemory(Call, State)) { |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1244 | for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| 1245 | E = ExplicitRegions.end(); I != E; ++I) { |
| 1246 | if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| 1247 | WhitelistedSymbols.insert(R->getSymbol()); |
| 1248 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1249 | } |
| 1250 | |
| 1251 | for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| 1252 | E = invalidated->end(); I!=E; ++I) { |
| 1253 | SymbolRef sym = *I; |
| 1254 | if (WhitelistedSymbols.count(sym)) |
| 1255 | continue; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1256 | // The symbol escaped. |
| 1257 | if (const RefState *RS = State->get<RegionState>(sym)) |
| 1258 | State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1259 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1260 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1261 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1262 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1263 | PathDiagnosticPiece * |
| 1264 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 1265 | const ExplodedNode *PrevN, |
| 1266 | BugReporterContext &BRC, |
| 1267 | BugReport &BR) { |
| 1268 | const RefState *RS = N->getState()->get<RegionState>(Sym); |
| 1269 | const RefState *RSPrev = PrevN->getState()->get<RegionState>(Sym); |
| 1270 | if (!RS && !RSPrev) |
| 1271 | return 0; |
| 1272 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1273 | const Stmt *S = 0; |
| 1274 | const char *Msg = 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1275 | StackHintGeneratorForSymbol *StackHint = 0; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1276 | |
| 1277 | // Retrieve the associated statement. |
| 1278 | ProgramPoint ProgLoc = N->getLocation(); |
| 1279 | if (isa<StmtPoint>(ProgLoc)) |
| 1280 | S = cast<StmtPoint>(ProgLoc).getStmt(); |
| 1281 | // If an assumption was made on a branch, it should be caught |
| 1282 | // here by looking at the state transition. |
| 1283 | if (isa<BlockEdge>(ProgLoc)) { |
| 1284 | const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc(); |
| 1285 | S = srcBlk->getTerminator(); |
| 1286 | } |
| 1287 | if (!S) |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1288 | return 0; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1289 | |
| 1290 | // Find out if this is an interesting point and what is the kind. |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1291 | // TODO: Replace 'callee' by the function name. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1292 | if (Mode == Normal) { |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1293 | if (isAllocated(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1294 | Msg = "Memory is allocated"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1295 | StackHint = new StackHintGeneratorForSymbol(Sym, "; allocated memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1296 | } else if (isReleased(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1297 | Msg = "Memory is released"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1298 | StackHint = new StackHintGeneratorForSymbol(Sym, "; released memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1299 | } else if (isReallocFailedCheck(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1300 | Mode = ReallocationFailed; |
| 1301 | Msg = "Reallocation failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1302 | StackHint = new StackHintGeneratorForReallocationFailed(Sym, |
| 1303 | "; reallocation failed"); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1304 | } |
| 1305 | |
| 1306 | // We are in a special mode if a reallocation failed later in the path. |
| 1307 | } else if (Mode == ReallocationFailed) { |
| 1308 | // Generate a special diagnostic for the first realloc we find. |
| 1309 | if (!isAllocated(RS, RSPrev, S) && !isReleased(RS, RSPrev, S)) |
| 1310 | return 0; |
| 1311 | |
| 1312 | // Check that the name of the function is realloc. |
| 1313 | const CallExpr *CE = dyn_cast<CallExpr>(S); |
| 1314 | if (!CE) |
| 1315 | return 0; |
| 1316 | const FunctionDecl *funDecl = CE->getDirectCallee(); |
| 1317 | if (!funDecl) |
| 1318 | return 0; |
| 1319 | StringRef FunName = funDecl->getName(); |
| 1320 | if (!(FunName.equals("realloc") || FunName.equals("reallocf"))) |
| 1321 | return 0; |
| 1322 | Msg = "Attempt to reallocate memory"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1323 | StackHint = new StackHintGeneratorForSymbol(Sym, "; reallocated memory"); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1324 | Mode = Normal; |
| 1325 | } |
| 1326 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1327 | if (!Msg) |
| 1328 | return 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1329 | assert(StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1330 | |
| 1331 | // Generate the extra diagnostic. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1332 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1333 | N->getLocationContext()); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame^] | 1334 | return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1335 | } |
| 1336 | |
| 1337 | |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1338 | #define REGISTER_CHECKER(name) \ |
| 1339 | void ento::register##name(CheckerManager &mgr) {\ |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 1340 | registerCStringCheckerBasic(mgr); \ |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1341 | mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1342 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1343 | |
| 1344 | REGISTER_CHECKER(MallocPessimistic) |
| 1345 | REGISTER_CHECKER(MallocOptimistic) |