Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1 | //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 0bc735f | 2007-12-29 19:59:25 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 10 | // This file implements extra semantic analysis beyond what is enforced |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 11 | // by the C type system. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
| 15 | #include "Sema.h" |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 16 | #include "clang/Analysis/Analyses/FormatString.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 17 | #include "clang/AST/ASTContext.h" |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 18 | #include "clang/AST/CharUnits.h" |
Daniel Dunbar | c4a1dea | 2008-08-11 05:35:13 +0000 | [diff] [blame] | 19 | #include "clang/AST/DeclObjC.h" |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 20 | #include "clang/AST/ExprCXX.h" |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 21 | #include "clang/AST/ExprObjC.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 22 | #include "clang/AST/DeclObjC.h" |
| 23 | #include "clang/AST/StmtCXX.h" |
| 24 | #include "clang/AST/StmtObjC.h" |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 25 | #include "clang/Lex/LiteralSupport.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 26 | #include "clang/Lex/Preprocessor.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/BitVector.h" |
| 28 | #include "llvm/ADT/STLExtras.h" |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 29 | #include "llvm/ADT/StringExtras.h" |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 30 | #include "llvm/Support/raw_ostream.h" |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 31 | #include "clang/Basic/TargetBuiltins.h" |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 32 | #include "clang/Basic/TargetInfo.h" |
Zhongxing Xu | a1f3dba | 2009-05-20 01:55:10 +0000 | [diff] [blame] | 33 | #include <limits> |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 34 | using namespace clang; |
| 35 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 36 | /// getLocationOfStringLiteralByte - Return a source location that points to the |
| 37 | /// specified byte of the specified string literal. |
| 38 | /// |
| 39 | /// Strings are amazingly complex. They can be formed from multiple tokens and |
| 40 | /// can have escape sequences in them in addition to the usual trigraph and |
| 41 | /// escaped newline business. This routine handles this complexity. |
| 42 | /// |
| 43 | SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, |
| 44 | unsigned ByteNo) const { |
| 45 | assert(!SL->isWide() && "This doesn't work for wide strings yet"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 46 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 47 | // Loop over all of the tokens in this string until we find the one that |
| 48 | // contains the byte we're looking for. |
| 49 | unsigned TokNo = 0; |
| 50 | while (1) { |
| 51 | assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!"); |
| 52 | SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 53 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 54 | // Get the spelling of the string so that we can get the data that makes up |
| 55 | // the string literal, not the identifier for the macro it is potentially |
| 56 | // expanded through. |
| 57 | SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc); |
| 58 | |
| 59 | // Re-lex the token to get its length and original spelling. |
| 60 | std::pair<FileID, unsigned> LocInfo = |
| 61 | SourceMgr.getDecomposedLoc(StrTokSpellingLoc); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 62 | bool Invalid = false; |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 63 | llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 64 | if (Invalid) |
Douglas Gregor | aea67db | 2010-03-15 22:54:52 +0000 | [diff] [blame] | 65 | return StrTokSpellingLoc; |
| 66 | |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 67 | const char *StrData = Buffer.data()+LocInfo.second; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 68 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 69 | // Create a langops struct and enable trigraphs. This is sufficient for |
| 70 | // relexing tokens. |
| 71 | LangOptions LangOpts; |
| 72 | LangOpts.Trigraphs = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 73 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 74 | // Create a lexer starting at the beginning of this token. |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 75 | Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData, |
| 76 | Buffer.end()); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 77 | Token TheTok; |
| 78 | TheLexer.LexFromRawLexer(TheTok); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 79 | |
Chris Lattner | 443e53c | 2009-02-18 19:26:42 +0000 | [diff] [blame] | 80 | // Use the StringLiteralParser to compute the length of the string in bytes. |
Douglas Gregor | b90f4b3 | 2010-05-26 05:35:51 +0000 | [diff] [blame] | 81 | StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false); |
Chris Lattner | 443e53c | 2009-02-18 19:26:42 +0000 | [diff] [blame] | 82 | unsigned TokNumBytes = SLP.GetStringLength(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 83 | |
Chris Lattner | 2197c96 | 2009-02-18 18:52:52 +0000 | [diff] [blame] | 84 | // If the byte is in this token, return the location of the byte. |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 85 | if (ByteNo < TokNumBytes || |
| 86 | (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 87 | unsigned Offset = |
Douglas Gregor | b90f4b3 | 2010-05-26 05:35:51 +0000 | [diff] [blame] | 88 | StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP, |
| 89 | /*Complain=*/false); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 90 | |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 91 | // Now that we know the offset of the token in the spelling, use the |
| 92 | // preprocessor to get the offset in the original source. |
| 93 | return PP.AdvanceToTokenCharacter(StrTokLoc, Offset); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 94 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 95 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 96 | // Move to the next string token. |
| 97 | ++TokNo; |
| 98 | ByteNo -= TokNumBytes; |
| 99 | } |
| 100 | } |
| 101 | |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 102 | /// CheckablePrintfAttr - does a function call have a "printf" attribute |
| 103 | /// and arguments that merit checking? |
| 104 | bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { |
| 105 | if (Format->getType() == "printf") return true; |
| 106 | if (Format->getType() == "printf0") { |
| 107 | // printf0 allows null "format" string; if so don't check format/args |
| 108 | unsigned format_idx = Format->getFormatIdx() - 1; |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 109 | // Does the index refer to the implicit object argument? |
| 110 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 111 | if (format_idx == 0) |
| 112 | return false; |
| 113 | --format_idx; |
| 114 | } |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 115 | if (format_idx < TheCall->getNumArgs()) { |
| 116 | Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 117 | if (!Format->isNullPointerConstant(Context, |
| 118 | Expr::NPC_ValueDependentIsNull)) |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 119 | return true; |
| 120 | } |
| 121 | } |
| 122 | return false; |
| 123 | } |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 124 | |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 125 | Action::OwningExprResult |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 126 | Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 127 | OwningExprResult TheCallResult(Owned(TheCall)); |
Douglas Gregor | 2def483 | 2008-11-17 20:34:05 +0000 | [diff] [blame] | 128 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 129 | switch (BuiltinID) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 130 | case Builtin::BI__builtin___CFStringMakeConstantString: |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 131 | assert(TheCall->getNumArgs() == 1 && |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 132 | "Wrong # arguments to builtin CFStringMakeConstantString"); |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 133 | if (CheckObjCString(TheCall->getArg(0))) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 134 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 135 | break; |
Ted Kremenek | 49ff7a1 | 2008-07-09 17:58:53 +0000 | [diff] [blame] | 136 | case Builtin::BI__builtin_stdarg_start: |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 137 | case Builtin::BI__builtin_va_start: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 138 | if (SemaBuiltinVAStart(TheCall)) |
| 139 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 140 | break; |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 141 | case Builtin::BI__builtin_isgreater: |
| 142 | case Builtin::BI__builtin_isgreaterequal: |
| 143 | case Builtin::BI__builtin_isless: |
| 144 | case Builtin::BI__builtin_islessequal: |
| 145 | case Builtin::BI__builtin_islessgreater: |
| 146 | case Builtin::BI__builtin_isunordered: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 147 | if (SemaBuiltinUnorderedCompare(TheCall)) |
| 148 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 149 | break; |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 150 | case Builtin::BI__builtin_fpclassify: |
| 151 | if (SemaBuiltinFPClassification(TheCall, 6)) |
| 152 | return ExprError(); |
| 153 | break; |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 154 | case Builtin::BI__builtin_isfinite: |
| 155 | case Builtin::BI__builtin_isinf: |
| 156 | case Builtin::BI__builtin_isinf_sign: |
| 157 | case Builtin::BI__builtin_isnan: |
| 158 | case Builtin::BI__builtin_isnormal: |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 159 | if (SemaBuiltinFPClassification(TheCall, 1)) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 160 | return ExprError(); |
| 161 | break; |
Eli Friedman | 6cfda23 | 2008-05-20 08:23:37 +0000 | [diff] [blame] | 162 | case Builtin::BI__builtin_return_address: |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 163 | case Builtin::BI__builtin_frame_address: { |
| 164 | llvm::APSInt Result; |
| 165 | if (SemaBuiltinConstantArg(TheCall, 0, Result)) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 166 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 167 | break; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 168 | } |
| 169 | case Builtin::BI__builtin_eh_return_data_regno: { |
| 170 | llvm::APSInt Result; |
| 171 | if (SemaBuiltinConstantArg(TheCall, 0, Result)) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 172 | return ExprError(); |
| 173 | break; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 174 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 175 | case Builtin::BI__builtin_shufflevector: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 176 | return SemaBuiltinShuffleVector(TheCall); |
| 177 | // TheCall will be freed by the smart pointer here, but that's fine, since |
| 178 | // SemaBuiltinShuffleVector guts it, but then doesn't release it. |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 179 | case Builtin::BI__builtin_prefetch: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 180 | if (SemaBuiltinPrefetch(TheCall)) |
| 181 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 182 | break; |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 183 | case Builtin::BI__builtin_object_size: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 184 | if (SemaBuiltinObjectSize(TheCall)) |
| 185 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 186 | break; |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 187 | case Builtin::BI__builtin_longjmp: |
| 188 | if (SemaBuiltinLongjmp(TheCall)) |
| 189 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 190 | break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 191 | case Builtin::BI__sync_fetch_and_add: |
| 192 | case Builtin::BI__sync_fetch_and_sub: |
| 193 | case Builtin::BI__sync_fetch_and_or: |
| 194 | case Builtin::BI__sync_fetch_and_and: |
| 195 | case Builtin::BI__sync_fetch_and_xor: |
| 196 | case Builtin::BI__sync_add_and_fetch: |
| 197 | case Builtin::BI__sync_sub_and_fetch: |
| 198 | case Builtin::BI__sync_and_and_fetch: |
| 199 | case Builtin::BI__sync_or_and_fetch: |
| 200 | case Builtin::BI__sync_xor_and_fetch: |
| 201 | case Builtin::BI__sync_val_compare_and_swap: |
| 202 | case Builtin::BI__sync_bool_compare_and_swap: |
| 203 | case Builtin::BI__sync_lock_test_and_set: |
| 204 | case Builtin::BI__sync_lock_release: |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 205 | return SemaBuiltinAtomicOverloaded(move(TheCallResult)); |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 206 | } |
| 207 | |
| 208 | // Since the target specific builtins for each arch overlap, only check those |
| 209 | // of the arch we are compiling for. |
| 210 | if (BuiltinID >= Builtin::FirstTSBuiltin) { |
| 211 | switch (Context.Target.getTriple().getArch()) { |
| 212 | case llvm::Triple::arm: |
| 213 | case llvm::Triple::thumb: |
| 214 | if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) |
| 215 | return ExprError(); |
| 216 | break; |
| 217 | case llvm::Triple::x86: |
| 218 | case llvm::Triple::x86_64: |
| 219 | if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall)) |
| 220 | return ExprError(); |
| 221 | break; |
| 222 | default: |
| 223 | break; |
| 224 | } |
| 225 | } |
| 226 | |
| 227 | return move(TheCallResult); |
| 228 | } |
| 229 | |
| 230 | bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
| 231 | switch (BuiltinID) { |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 232 | case X86::BI__builtin_ia32_palignr128: |
| 233 | case X86::BI__builtin_ia32_palignr: { |
| 234 | llvm::APSInt Result; |
| 235 | if (SemaBuiltinConstantArg(TheCall, 2, Result)) |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 236 | return true; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 237 | break; |
| 238 | } |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 239 | } |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 240 | return false; |
| 241 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 242 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 243 | // Get the valid immediate range for the specified NEON type code. |
| 244 | static unsigned RFT(unsigned t, bool shift = false) { |
| 245 | bool quad = t & 0x10; |
| 246 | |
| 247 | switch (t & 0x7) { |
| 248 | case 0: // i8 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 249 | return shift ? 7 : (8 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 250 | case 1: // i16 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 251 | return shift ? 15 : (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 252 | case 2: // i32 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 253 | return shift ? 31 : (2 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 254 | case 3: // i64 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 255 | return shift ? 63 : (1 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 256 | case 4: // f32 |
| 257 | assert(!shift && "cannot shift float types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 258 | return (2 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 259 | case 5: // poly8 |
| 260 | assert(!shift && "cannot shift polynomial types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 261 | return (8 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 262 | case 6: // poly16 |
| 263 | assert(!shift && "cannot shift polynomial types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 264 | return (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 265 | case 7: // float16 |
| 266 | assert(!shift && "cannot shift float types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 267 | return (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 268 | } |
| 269 | return 0; |
| 270 | } |
| 271 | |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 272 | bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 273 | llvm::APSInt Result; |
| 274 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 275 | unsigned mask = 0; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 276 | unsigned TV = 0; |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 277 | switch (BuiltinID) { |
Nate Begeman | a23326b | 2010-06-17 04:17:01 +0000 | [diff] [blame] | 278 | #define GET_NEON_OVERLOAD_CHECK |
| 279 | #include "clang/Basic/arm_neon.inc" |
| 280 | #undef GET_NEON_OVERLOAD_CHECK |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 281 | } |
| 282 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 283 | // For NEON intrinsics which are overloaded on vector element type, validate |
| 284 | // the immediate which specifies which variant to emit. |
| 285 | if (mask) { |
| 286 | unsigned ArgNo = TheCall->getNumArgs()-1; |
| 287 | if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) |
| 288 | return true; |
| 289 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 290 | TV = Result.getLimitedValue(32); |
| 291 | if ((TV > 31) || (mask & (1 << TV)) == 0) |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 292 | return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) |
| 293 | << TheCall->getArg(ArgNo)->getSourceRange(); |
| 294 | } |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 295 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 296 | // For NEON intrinsics which take an immediate value as part of the |
| 297 | // instruction, range check them here. |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 298 | unsigned i = 0, l = 0, u = 0; |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 299 | switch (BuiltinID) { |
| 300 | default: return false; |
Nate Begeman | a23326b | 2010-06-17 04:17:01 +0000 | [diff] [blame] | 301 | #define GET_NEON_IMMEDIATE_CHECK |
| 302 | #include "clang/Basic/arm_neon.inc" |
| 303 | #undef GET_NEON_IMMEDIATE_CHECK |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 304 | }; |
| 305 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 306 | // Check that the immediate argument is actually a constant. |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 307 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 308 | return true; |
| 309 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 310 | // Range check against the upper/lower values for this isntruction. |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 311 | unsigned Val = Result.getZExtValue(); |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 312 | if (Val < l || Val > (u + l)) |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 313 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 314 | << llvm::utostr(l) << llvm::utostr(u+l) |
| 315 | << TheCall->getArg(i)->getSourceRange(); |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 316 | |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 317 | return false; |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 318 | } |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 319 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 320 | /// CheckFunctionCall - Check a direct function call for various correctness |
| 321 | /// and safety properties not strictly enforced by the C type system. |
| 322 | bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { |
| 323 | // Get the IdentifierInfo* for the called function. |
| 324 | IdentifierInfo *FnInfo = FDecl->getIdentifier(); |
| 325 | |
| 326 | // None of the checks below are needed for functions that don't have |
| 327 | // simple names (e.g., C++ conversion functions). |
| 328 | if (!FnInfo) |
| 329 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 330 | |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 331 | // FIXME: This mechanism should be abstracted to be less fragile and |
| 332 | // more efficient. For example, just map function ids to custom |
| 333 | // handlers. |
| 334 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 335 | // Printf checking. |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 336 | if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 337 | const bool b = Format->getType() == "scanf"; |
| 338 | if (b || CheckablePrintfAttr(Format, TheCall)) { |
Ted Kremenek | 3d692df | 2009-02-27 17:58:43 +0000 | [diff] [blame] | 339 | bool HasVAListArg = Format->getFirstArg() == 0; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 340 | CheckPrintfScanfArguments(TheCall, HasVAListArg, |
| 341 | Format->getFormatIdx() - 1, |
| 342 | HasVAListArg ? 0 : Format->getFirstArg() - 1, |
| 343 | !b); |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 344 | } |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 345 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 346 | |
| 347 | for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull; |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 348 | NonNull = NonNull->getNext<NonNullAttr>()) |
| 349 | CheckNonNullArguments(NonNull, TheCall); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 350 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 351 | return false; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 352 | } |
| 353 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 354 | bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 355 | // Printf checking. |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 356 | const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 357 | if (!Format) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 358 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 359 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 360 | const VarDecl *V = dyn_cast<VarDecl>(NDecl); |
| 361 | if (!V) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 362 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 363 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 364 | QualType Ty = V->getType(); |
| 365 | if (!Ty->isBlockPointerType()) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 366 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 367 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 368 | const bool b = Format->getType() == "scanf"; |
| 369 | if (!b && !CheckablePrintfAttr(Format, TheCall)) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 370 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 371 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 372 | bool HasVAListArg = Format->getFirstArg() == 0; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 373 | CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, |
| 374 | HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 375 | |
| 376 | return false; |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 377 | } |
| 378 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 379 | /// SemaBuiltinAtomicOverloaded - We have a call to a function like |
| 380 | /// __sync_fetch_and_add, which is an overloaded function based on the pointer |
| 381 | /// type of its first argument. The main ActOnCallExpr routines have already |
| 382 | /// promoted the types of arguments because all of these calls are prototyped as |
| 383 | /// void(...). |
| 384 | /// |
| 385 | /// This function goes through and does final semantic checking for these |
| 386 | /// builtins, |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 387 | Sema::OwningExprResult |
| 388 | Sema::SemaBuiltinAtomicOverloaded(OwningExprResult TheCallResult) { |
| 389 | CallExpr *TheCall = (CallExpr *)TheCallResult.get(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 390 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 391 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 392 | |
| 393 | // Ensure that we have at least one argument to do type inference from. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 394 | if (TheCall->getNumArgs() < 1) { |
| 395 | Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) |
| 396 | << 0 << 1 << TheCall->getNumArgs() |
| 397 | << TheCall->getCallee()->getSourceRange(); |
| 398 | return ExprError(); |
| 399 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 400 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 401 | // Inspect the first argument of the atomic builtin. This should always be |
| 402 | // a pointer type, whose element is an integral scalar or pointer type. |
| 403 | // Because it is a pointer type, we don't have to worry about any implicit |
| 404 | // casts here. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 405 | // FIXME: We don't allow floating point scalars as input. |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 406 | Expr *FirstArg = TheCall->getArg(0); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 407 | if (!FirstArg->getType()->isPointerType()) { |
| 408 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) |
| 409 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 410 | return ExprError(); |
| 411 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 412 | |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 413 | QualType ValType = |
| 414 | FirstArg->getType()->getAs<PointerType>()->getPointeeType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 415 | if (!ValType->isIntegerType() && !ValType->isPointerType() && |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 416 | !ValType->isBlockPointerType()) { |
| 417 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) |
| 418 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 419 | return ExprError(); |
| 420 | } |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 421 | |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 422 | // The majority of builtins return a value, but a few have special return |
| 423 | // types, so allow them to override appropriately below. |
| 424 | QualType ResultType = ValType; |
| 425 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 426 | // We need to figure out which concrete builtin this maps onto. For example, |
| 427 | // __sync_fetch_and_add with a 2 byte object turns into |
| 428 | // __sync_fetch_and_add_2. |
| 429 | #define BUILTIN_ROW(x) \ |
| 430 | { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ |
| 431 | Builtin::BI##x##_8, Builtin::BI##x##_16 } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 432 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 433 | static const unsigned BuiltinIndices[][5] = { |
| 434 | BUILTIN_ROW(__sync_fetch_and_add), |
| 435 | BUILTIN_ROW(__sync_fetch_and_sub), |
| 436 | BUILTIN_ROW(__sync_fetch_and_or), |
| 437 | BUILTIN_ROW(__sync_fetch_and_and), |
| 438 | BUILTIN_ROW(__sync_fetch_and_xor), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 439 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 440 | BUILTIN_ROW(__sync_add_and_fetch), |
| 441 | BUILTIN_ROW(__sync_sub_and_fetch), |
| 442 | BUILTIN_ROW(__sync_and_and_fetch), |
| 443 | BUILTIN_ROW(__sync_or_and_fetch), |
| 444 | BUILTIN_ROW(__sync_xor_and_fetch), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 445 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 446 | BUILTIN_ROW(__sync_val_compare_and_swap), |
| 447 | BUILTIN_ROW(__sync_bool_compare_and_swap), |
| 448 | BUILTIN_ROW(__sync_lock_test_and_set), |
| 449 | BUILTIN_ROW(__sync_lock_release) |
| 450 | }; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 451 | #undef BUILTIN_ROW |
| 452 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 453 | // Determine the index of the size. |
| 454 | unsigned SizeIndex; |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 455 | switch (Context.getTypeSizeInChars(ValType).getQuantity()) { |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 456 | case 1: SizeIndex = 0; break; |
| 457 | case 2: SizeIndex = 1; break; |
| 458 | case 4: SizeIndex = 2; break; |
| 459 | case 8: SizeIndex = 3; break; |
| 460 | case 16: SizeIndex = 4; break; |
| 461 | default: |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 462 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) |
| 463 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 464 | return ExprError(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 465 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 466 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 467 | // Each of these builtins has one pointer argument, followed by some number of |
| 468 | // values (0, 1 or 2) followed by a potentially empty varags list of stuff |
| 469 | // that we ignore. Find out which row of BuiltinIndices to read from as well |
| 470 | // as the number of fixed args. |
Douglas Gregor | 7814e6d | 2009-09-12 00:22:50 +0000 | [diff] [blame] | 471 | unsigned BuiltinID = FDecl->getBuiltinID(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 472 | unsigned BuiltinIndex, NumFixed = 1; |
| 473 | switch (BuiltinID) { |
| 474 | default: assert(0 && "Unknown overloaded atomic builtin!"); |
| 475 | case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; |
| 476 | case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; |
| 477 | case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; |
| 478 | case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; |
| 479 | case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 480 | |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 481 | case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; |
| 482 | case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; |
| 483 | case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; |
| 484 | case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; |
| 485 | case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 486 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 487 | case Builtin::BI__sync_val_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 488 | BuiltinIndex = 10; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 489 | NumFixed = 2; |
| 490 | break; |
| 491 | case Builtin::BI__sync_bool_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 492 | BuiltinIndex = 11; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 493 | NumFixed = 2; |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 494 | ResultType = Context.BoolTy; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 495 | break; |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 496 | case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 497 | case Builtin::BI__sync_lock_release: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 498 | BuiltinIndex = 13; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 499 | NumFixed = 0; |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 500 | ResultType = Context.VoidTy; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 501 | break; |
| 502 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 503 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 504 | // Now that we know how many fixed arguments we expect, first check that we |
| 505 | // have at least that many. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 506 | if (TheCall->getNumArgs() < 1+NumFixed) { |
| 507 | Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) |
| 508 | << 0 << 1+NumFixed << TheCall->getNumArgs() |
| 509 | << TheCall->getCallee()->getSourceRange(); |
| 510 | return ExprError(); |
| 511 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 512 | |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 513 | // Get the decl for the concrete builtin from this, we can tell what the |
| 514 | // concrete integer type we should convert to is. |
| 515 | unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; |
| 516 | const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); |
| 517 | IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 518 | FunctionDecl *NewBuiltinDecl = |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 519 | cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, |
| 520 | TUScope, false, DRE->getLocStart())); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 521 | |
Chandler Carruth | db4325b | 2010-07-18 07:23:17 +0000 | [diff] [blame] | 522 | // The first argument is by definition correct, we use it's type as the type |
| 523 | // of the entire operation. Walk the remaining arguments promoting them to |
| 524 | // the deduced value type. |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 525 | for (unsigned i = 0; i != NumFixed; ++i) { |
| 526 | Expr *Arg = TheCall->getArg(i+1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 527 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 528 | // If the argument is an implicit cast, then there was a promotion due to |
| 529 | // "...", just remove it now. |
| 530 | if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { |
| 531 | Arg = ICE->getSubExpr(); |
| 532 | ICE->setSubExpr(0); |
| 533 | ICE->Destroy(Context); |
| 534 | TheCall->setArg(i+1, Arg); |
| 535 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 536 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 537 | // GCC does an implicit conversion to the pointer or integer ValType. This |
| 538 | // can fail in some cases (1i -> int**), check for this error case now. |
Anders Carlsson | cdb6197 | 2009-08-07 22:21:05 +0000 | [diff] [blame] | 539 | CastExpr::CastKind Kind = CastExpr::CK_Unknown; |
Anders Carlsson | 5cf86ba | 2010-04-24 19:06:50 +0000 | [diff] [blame] | 540 | CXXBaseSpecifierArray BasePath; |
| 541 | if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath)) |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 542 | return ExprError(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 543 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 544 | // Okay, we have something that *can* be converted to the right type. Check |
| 545 | // to see if there is a potentially weird extension going on here. This can |
| 546 | // happen when you do an atomic operation on something like an char* and |
| 547 | // pass in 42. The 42 gets converted to char. This is even more strange |
| 548 | // for things like 45.123 -> char, etc. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 549 | // FIXME: Do this check. |
Anders Carlsson | 80971bd | 2010-04-24 16:36:20 +0000 | [diff] [blame] | 550 | ImpCastExprToType(Arg, ValType, Kind); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 551 | TheCall->setArg(i+1, Arg); |
| 552 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 553 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 554 | // Switch the DeclRefExpr to refer to the new decl. |
| 555 | DRE->setDecl(NewBuiltinDecl); |
| 556 | DRE->setType(NewBuiltinDecl->getType()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 557 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 558 | // Set the callee in the CallExpr. |
| 559 | // FIXME: This leaks the original parens and implicit casts. |
| 560 | Expr *PromotedCall = DRE; |
| 561 | UsualUnaryConversions(PromotedCall); |
| 562 | TheCall->setCallee(PromotedCall); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 563 | |
Chandler Carruth | db4325b | 2010-07-18 07:23:17 +0000 | [diff] [blame] | 564 | // Change the result type of the call to match the original value type. This |
| 565 | // is arbitrary, but the codegen for these builtins ins design to handle it |
| 566 | // gracefully. |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 567 | TheCall->setType(ResultType); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 568 | |
| 569 | return move(TheCallResult); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 570 | } |
| 571 | |
| 572 | |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 573 | /// CheckObjCString - Checks that the argument to the builtin |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 574 | /// CFString constructor is correct |
Steve Naroff | fd94262 | 2009-04-13 20:26:29 +0000 | [diff] [blame] | 575 | /// FIXME: GCC currently emits the following warning: |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 576 | /// "warning: input conversion stopped due to an input byte that does not |
Steve Naroff | fd94262 | 2009-04-13 20:26:29 +0000 | [diff] [blame] | 577 | /// belong to the input codeset UTF-8" |
| 578 | /// Note: It might also make sense to do the UTF-16 conversion here (would |
| 579 | /// simplify the backend). |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 580 | bool Sema::CheckObjCString(Expr *Arg) { |
Chris Lattner | 56f3494 | 2008-02-13 01:02:39 +0000 | [diff] [blame] | 581 | Arg = Arg->IgnoreParenCasts(); |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 582 | StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); |
| 583 | |
| 584 | if (!Literal || Literal->isWide()) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 585 | Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) |
| 586 | << Arg->getSourceRange(); |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 587 | return true; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 588 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 589 | |
Daniel Dunbar | f015b03 | 2009-09-22 10:03:52 +0000 | [diff] [blame] | 590 | const char *Data = Literal->getStrData(); |
| 591 | unsigned Length = Literal->getByteLength(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 592 | |
Daniel Dunbar | f015b03 | 2009-09-22 10:03:52 +0000 | [diff] [blame] | 593 | for (unsigned i = 0; i < Length; ++i) { |
| 594 | if (!Data[i]) { |
| 595 | Diag(getLocationOfStringLiteralByte(Literal, i), |
| 596 | diag::warn_cfstring_literal_contains_nul_character) |
| 597 | << Arg->getSourceRange(); |
| 598 | break; |
| 599 | } |
| 600 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 601 | |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 602 | return false; |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 603 | } |
| 604 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 605 | /// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. |
| 606 | /// Emit an error and return true on failure, return false on success. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 607 | bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { |
| 608 | Expr *Fn = TheCall->getCallee(); |
| 609 | if (TheCall->getNumArgs() > 2) { |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 610 | Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 611 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 612 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
| 613 | << Fn->getSourceRange() |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 614 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 615 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 616 | return true; |
| 617 | } |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 618 | |
| 619 | if (TheCall->getNumArgs() < 2) { |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 620 | return Diag(TheCall->getLocEnd(), |
| 621 | diag::err_typecheck_call_too_few_args_at_least) |
| 622 | << 0 /*function call*/ << 2 << TheCall->getNumArgs(); |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 623 | } |
| 624 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 625 | // Determine whether the current function is variadic or not. |
Douglas Gregor | 9ea9bdb | 2010-03-01 23:15:13 +0000 | [diff] [blame] | 626 | BlockScopeInfo *CurBlock = getCurBlock(); |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 627 | bool isVariadic; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 628 | if (CurBlock) |
John McCall | c71a491 | 2010-06-04 19:02:56 +0000 | [diff] [blame] | 629 | isVariadic = CurBlock->TheDecl->isVariadic(); |
Ted Kremenek | 9498d38 | 2010-04-29 16:49:01 +0000 | [diff] [blame] | 630 | else if (FunctionDecl *FD = getCurFunctionDecl()) |
| 631 | isVariadic = FD->isVariadic(); |
| 632 | else |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 633 | isVariadic = getCurMethodDecl()->isVariadic(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 634 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 635 | if (!isVariadic) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 636 | Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); |
| 637 | return true; |
| 638 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 639 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 640 | // Verify that the second argument to the builtin is the last argument of the |
| 641 | // current function or method. |
| 642 | bool SecondArgIsLastNamedArgument = false; |
Anders Carlsson | e2c1410 | 2008-02-13 01:22:59 +0000 | [diff] [blame] | 643 | const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 644 | |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 645 | if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { |
| 646 | if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 647 | // FIXME: This isn't correct for methods (results in bogus warning). |
| 648 | // Get the last formal in the current function. |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 649 | const ParmVarDecl *LastArg; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 650 | if (CurBlock) |
| 651 | LastArg = *(CurBlock->TheDecl->param_end()-1); |
| 652 | else if (FunctionDecl *FD = getCurFunctionDecl()) |
Chris Lattner | 371f258 | 2008-12-04 23:50:19 +0000 | [diff] [blame] | 653 | LastArg = *(FD->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 654 | else |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 655 | LastArg = *(getCurMethodDecl()->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 656 | SecondArgIsLastNamedArgument = PV == LastArg; |
| 657 | } |
| 658 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 659 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 660 | if (!SecondArgIsLastNamedArgument) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 661 | Diag(TheCall->getArg(1)->getLocStart(), |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 662 | diag::warn_second_parameter_of_va_start_not_last_named_argument); |
| 663 | return false; |
Eli Friedman | 6cfda23 | 2008-05-20 08:23:37 +0000 | [diff] [blame] | 664 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 665 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 666 | /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and |
| 667 | /// friends. This is declared to take (...), so we have to check everything. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 668 | bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { |
| 669 | if (TheCall->getNumArgs() < 2) |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 670 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 671 | << 0 << 2 << TheCall->getNumArgs()/*function call*/; |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 672 | if (TheCall->getNumArgs() > 2) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 673 | return Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 674 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 675 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 676 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
| 677 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 678 | |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 679 | Expr *OrigArg0 = TheCall->getArg(0); |
| 680 | Expr *OrigArg1 = TheCall->getArg(1); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 681 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 682 | // Do standard promotions between the two arguments, returning their common |
| 683 | // type. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 684 | QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); |
Daniel Dunbar | 403bc2b | 2009-02-19 19:28:43 +0000 | [diff] [blame] | 685 | |
| 686 | // Make sure any conversions are pushed back into the call; this is |
| 687 | // type safe since unordered compare builtins are declared as "_Bool |
| 688 | // foo(...)". |
| 689 | TheCall->setArg(0, OrigArg0); |
| 690 | TheCall->setArg(1, OrigArg1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 691 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 692 | if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) |
| 693 | return false; |
| 694 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 695 | // If the common type isn't a real floating type, then the arguments were |
| 696 | // invalid for this operation. |
| 697 | if (!Res->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 698 | return Diag(OrigArg0->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 699 | diag::err_typecheck_call_invalid_ordered_compare) |
Chris Lattner | d162584 | 2008-11-24 06:25:27 +0000 | [diff] [blame] | 700 | << OrigArg0->getType() << OrigArg1->getType() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 701 | << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 702 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 703 | return false; |
| 704 | } |
| 705 | |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 706 | /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like |
| 707 | /// __builtin_isnan and friends. This is declared to take (...), so we have |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 708 | /// to check everything. We expect the last argument to be a floating point |
| 709 | /// value. |
| 710 | bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { |
| 711 | if (TheCall->getNumArgs() < NumArgs) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 712 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 713 | << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 714 | if (TheCall->getNumArgs() > NumArgs) |
| 715 | return Diag(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 716 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 717 | << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 718 | << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 719 | (*(TheCall->arg_end()-1))->getLocEnd()); |
| 720 | |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 721 | Expr *OrigArg = TheCall->getArg(NumArgs-1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 722 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 723 | if (OrigArg->isTypeDependent()) |
| 724 | return false; |
| 725 | |
Chris Lattner | 81368fb | 2010-05-06 05:50:07 +0000 | [diff] [blame] | 726 | // This operation requires a non-_Complex floating-point number. |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 727 | if (!OrigArg->getType()->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 728 | return Diag(OrigArg->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 729 | diag::err_typecheck_call_invalid_unary_fp) |
| 730 | << OrigArg->getType() << OrigArg->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 731 | |
Chris Lattner | 81368fb | 2010-05-06 05:50:07 +0000 | [diff] [blame] | 732 | // If this is an implicit conversion from float -> double, remove it. |
| 733 | if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { |
| 734 | Expr *CastArg = Cast->getSubExpr(); |
| 735 | if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { |
| 736 | assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && |
| 737 | "promotion from float to double is the only expected cast here"); |
| 738 | Cast->setSubExpr(0); |
| 739 | Cast->Destroy(Context); |
| 740 | TheCall->setArg(NumArgs-1, CastArg); |
| 741 | OrigArg = CastArg; |
| 742 | } |
| 743 | } |
| 744 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 745 | return false; |
| 746 | } |
| 747 | |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 748 | /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. |
| 749 | // This is declared to take (...), so we have to check everything. |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 750 | Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 751 | if (TheCall->getNumArgs() < 2) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 752 | return ExprError(Diag(TheCall->getLocEnd(), |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 753 | diag::err_typecheck_call_too_few_args_at_least) |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 754 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 755 | << TheCall->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 756 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 757 | // Determine which of the following types of shufflevector we're checking: |
| 758 | // 1) unary, vector mask: (lhs, mask) |
| 759 | // 2) binary, vector mask: (lhs, rhs, mask) |
| 760 | // 3) binary, scalar mask: (lhs, rhs, index, ..., index) |
| 761 | QualType resType = TheCall->getArg(0)->getType(); |
| 762 | unsigned numElements = 0; |
| 763 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 764 | if (!TheCall->getArg(0)->isTypeDependent() && |
| 765 | !TheCall->getArg(1)->isTypeDependent()) { |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 766 | QualType LHSType = TheCall->getArg(0)->getType(); |
| 767 | QualType RHSType = TheCall->getArg(1)->getType(); |
| 768 | |
| 769 | if (!LHSType->isVectorType() || !RHSType->isVectorType()) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 770 | Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 771 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 772 | TheCall->getArg(1)->getLocEnd()); |
| 773 | return ExprError(); |
| 774 | } |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 775 | |
| 776 | numElements = LHSType->getAs<VectorType>()->getNumElements(); |
| 777 | unsigned numResElements = TheCall->getNumArgs() - 2; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 778 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 779 | // Check to see if we have a call with 2 vector arguments, the unary shuffle |
| 780 | // with mask. If so, verify that RHS is an integer vector type with the |
| 781 | // same number of elts as lhs. |
| 782 | if (TheCall->getNumArgs() == 2) { |
| 783 | if (!RHSType->isIntegerType() || |
| 784 | RHSType->getAs<VectorType>()->getNumElements() != numElements) |
| 785 | Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) |
| 786 | << SourceRange(TheCall->getArg(1)->getLocStart(), |
| 787 | TheCall->getArg(1)->getLocEnd()); |
| 788 | numResElements = numElements; |
| 789 | } |
| 790 | else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 791 | Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 792 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 793 | TheCall->getArg(1)->getLocEnd()); |
| 794 | return ExprError(); |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 795 | } else if (numElements != numResElements) { |
| 796 | QualType eltType = LHSType->getAs<VectorType>()->getElementType(); |
Chris Lattner | 788b0fd | 2010-06-23 06:00:24 +0000 | [diff] [blame] | 797 | resType = Context.getVectorType(eltType, numResElements, |
| 798 | VectorType::NotAltiVec); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 799 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 800 | } |
| 801 | |
| 802 | for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 803 | if (TheCall->getArg(i)->isTypeDependent() || |
| 804 | TheCall->getArg(i)->isValueDependent()) |
| 805 | continue; |
| 806 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 807 | llvm::APSInt Result(32); |
| 808 | if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) |
| 809 | return ExprError(Diag(TheCall->getLocStart(), |
| 810 | diag::err_shufflevector_nonconstant_argument) |
| 811 | << TheCall->getArg(i)->getSourceRange()); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 812 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 813 | if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 814 | return ExprError(Diag(TheCall->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 815 | diag::err_shufflevector_argument_too_large) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 816 | << TheCall->getArg(i)->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 817 | } |
| 818 | |
| 819 | llvm::SmallVector<Expr*, 32> exprs; |
| 820 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 821 | for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 822 | exprs.push_back(TheCall->getArg(i)); |
| 823 | TheCall->setArg(i, 0); |
| 824 | } |
| 825 | |
Nate Begeman | a88dc30 | 2009-08-12 02:10:25 +0000 | [diff] [blame] | 826 | return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 827 | exprs.size(), resType, |
Ted Kremenek | 8189cde | 2009-02-07 01:47:29 +0000 | [diff] [blame] | 828 | TheCall->getCallee()->getLocStart(), |
| 829 | TheCall->getRParenLoc())); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 830 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 831 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 832 | /// SemaBuiltinPrefetch - Handle __builtin_prefetch. |
| 833 | // This is declared to take (const void*, ...) and can take two |
| 834 | // optional constant int args. |
| 835 | bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 836 | unsigned NumArgs = TheCall->getNumArgs(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 837 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 838 | if (NumArgs > 3) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 839 | return Diag(TheCall->getLocEnd(), |
| 840 | diag::err_typecheck_call_too_many_args_at_most) |
| 841 | << 0 /*function call*/ << 3 << NumArgs |
| 842 | << TheCall->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 843 | |
| 844 | // Argument 0 is checked for us and the remaining arguments must be |
| 845 | // constant integers. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 846 | for (unsigned i = 1; i != NumArgs; ++i) { |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 847 | Expr *Arg = TheCall->getArg(i); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 848 | |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 849 | llvm::APSInt Result; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 850 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 851 | return true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 852 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 853 | // FIXME: gcc issues a warning and rewrites these to 0. These |
| 854 | // seems especially odd for the third argument since the default |
| 855 | // is 3. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 856 | if (i == 1) { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 857 | if (Result.getLimitedValue() > 1) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 858 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 859 | << "0" << "1" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 860 | } else { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 861 | if (Result.getLimitedValue() > 3) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 862 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 863 | << "0" << "3" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 864 | } |
| 865 | } |
| 866 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 867 | return false; |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 868 | } |
| 869 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 870 | /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr |
| 871 | /// TheCall is a constant expression. |
| 872 | bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, |
| 873 | llvm::APSInt &Result) { |
| 874 | Expr *Arg = TheCall->getArg(ArgNum); |
| 875 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 876 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 877 | |
| 878 | if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; |
| 879 | |
| 880 | if (!Arg->isIntegerConstantExpr(Result, Context)) |
| 881 | return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) |
Eric Christopher | 5e89655 | 2010-04-19 18:23:02 +0000 | [diff] [blame] | 882 | << FDecl->getDeclName() << Arg->getSourceRange(); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 883 | |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 884 | return false; |
| 885 | } |
| 886 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 887 | /// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, |
| 888 | /// int type). This simply type checks that type is one of the defined |
| 889 | /// constants (0-3). |
Eric Christopher | fee667f | 2009-12-23 03:49:37 +0000 | [diff] [blame] | 890 | // For compatability check 0-3, llvm only handles 0 and 2. |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 891 | bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 892 | llvm::APSInt Result; |
| 893 | |
| 894 | // Check constant-ness first. |
| 895 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 896 | return true; |
| 897 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 898 | Expr *Arg = TheCall->getArg(1); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 899 | if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 900 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
| 901 | << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 902 | } |
| 903 | |
| 904 | return false; |
| 905 | } |
| 906 | |
Eli Friedman | 586d6a8 | 2009-05-03 06:04:26 +0000 | [diff] [blame] | 907 | /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 908 | /// This checks that val is a constant 1. |
| 909 | bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { |
| 910 | Expr *Arg = TheCall->getArg(1); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 911 | llvm::APSInt Result; |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 912 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 913 | // TODO: This is less than ideal. Overload this to take a value. |
| 914 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 915 | return true; |
| 916 | |
| 917 | if (Result != 1) |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 918 | return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) |
| 919 | << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
| 920 | |
| 921 | return false; |
| 922 | } |
| 923 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 924 | // Handle i > 1 ? "x" : "y", recursivelly |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 925 | bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, |
| 926 | bool HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 927 | unsigned format_idx, unsigned firstDataArg, |
| 928 | bool isPrintf) { |
| 929 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 930 | if (E->isTypeDependent() || E->isValueDependent()) |
| 931 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 932 | |
| 933 | switch (E->getStmtClass()) { |
| 934 | case Stmt::ConditionalOperatorClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 935 | const ConditionalOperator *C = cast<ConditionalOperator>(E); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 936 | return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, |
| 937 | format_idx, firstDataArg, isPrintf) |
| 938 | && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg, |
| 939 | format_idx, firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 940 | } |
| 941 | |
| 942 | case Stmt::ImplicitCastExprClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 943 | const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 944 | return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 945 | format_idx, firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | case Stmt::ParenExprClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 949 | const ParenExpr *Expr = cast<ParenExpr>(E); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 950 | return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 951 | format_idx, firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 952 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 953 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 954 | case Stmt::DeclRefExprClass: { |
| 955 | const DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 956 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 957 | // As an exception, do not flag errors for variables binding to |
| 958 | // const string literals. |
| 959 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 960 | bool isConstant = false; |
| 961 | QualType T = DR->getType(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 962 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 963 | if (const ArrayType *AT = Context.getAsArrayType(T)) { |
| 964 | isConstant = AT->getElementType().isConstant(Context); |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 965 | } else if (const PointerType *PT = T->getAs<PointerType>()) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 966 | isConstant = T.isConstant(Context) && |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 967 | PT->getPointeeType().isConstant(Context); |
| 968 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 969 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 970 | if (isConstant) { |
Sebastian Redl | 31310a2 | 2010-02-01 20:16:42 +0000 | [diff] [blame] | 971 | if (const Expr *Init = VD->getAnyInitializer()) |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 972 | return SemaCheckStringLiteral(Init, TheCall, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 973 | HasVAListArg, format_idx, firstDataArg, |
| 974 | isPrintf); |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 975 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 976 | |
Anders Carlsson | d966a55 | 2009-06-28 19:55:58 +0000 | [diff] [blame] | 977 | // For vprintf* functions (i.e., HasVAListArg==true), we add a |
| 978 | // special check to see if the format string is a function parameter |
| 979 | // of the function calling the printf function. If the function |
| 980 | // has an attribute indicating it is a printf-like function, then we |
| 981 | // should suppress warnings concerning non-literals being used in a call |
| 982 | // to a vprintf function. For example: |
| 983 | // |
| 984 | // void |
| 985 | // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ |
| 986 | // va_list ap; |
| 987 | // va_start(ap, fmt); |
| 988 | // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". |
| 989 | // ... |
| 990 | // |
| 991 | // |
| 992 | // FIXME: We don't have full attribute support yet, so just check to see |
| 993 | // if the argument is a DeclRefExpr that references a parameter. We'll |
| 994 | // add proper support for checking the attribute later. |
| 995 | if (HasVAListArg) |
| 996 | if (isa<ParmVarDecl>(VD)) |
| 997 | return true; |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 998 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 999 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1000 | return false; |
| 1001 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1002 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1003 | case Stmt::CallExprClass: { |
| 1004 | const CallExpr *CE = cast<CallExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1005 | if (const ImplicitCastExpr *ICE |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1006 | = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { |
| 1007 | if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { |
| 1008 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 1009 | if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1010 | unsigned ArgIndex = FA->getFormatIdx(); |
| 1011 | const Expr *Arg = CE->getArg(ArgIndex - 1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1012 | |
| 1013 | return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1014 | format_idx, firstDataArg, isPrintf); |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1015 | } |
| 1016 | } |
| 1017 | } |
| 1018 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1019 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1020 | return false; |
| 1021 | } |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1022 | case Stmt::ObjCStringLiteralClass: |
| 1023 | case Stmt::StringLiteralClass: { |
| 1024 | const StringLiteral *StrE = NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1025 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1026 | if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1027 | StrE = ObjCFExpr->getString(); |
| 1028 | else |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1029 | StrE = cast<StringLiteral>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1030 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1031 | if (StrE) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1032 | CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, |
| 1033 | firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1034 | return true; |
| 1035 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1036 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1037 | return false; |
| 1038 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1039 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1040 | default: |
| 1041 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1042 | } |
| 1043 | } |
| 1044 | |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1045 | void |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1046 | Sema::CheckNonNullArguments(const NonNullAttr *NonNull, |
| 1047 | const CallExpr *TheCall) { |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1048 | for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end(); |
| 1049 | i != e; ++i) { |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 1050 | const Expr *ArgExpr = TheCall->getArg(*i); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1051 | if (ArgExpr->isNullPointerConstant(Context, |
Douglas Gregor | ce94049 | 2009-09-25 04:25:58 +0000 | [diff] [blame] | 1052 | Expr::NPC_ValueDependentIsNotNull)) |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 1053 | Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) |
| 1054 | << ArgExpr->getSourceRange(); |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1055 | } |
| 1056 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1057 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1058 | /// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar |
| 1059 | /// functions) for correct use of format strings. |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1060 | void |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1061 | Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, |
| 1062 | unsigned format_idx, unsigned firstDataArg, |
| 1063 | bool isPrintf) { |
| 1064 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1065 | const Expr *Fn = TheCall->getCallee(); |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 1066 | |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 1067 | // The way the format attribute works in GCC, the implicit this argument |
| 1068 | // of member functions is counted. However, it doesn't appear in our own |
| 1069 | // lists, so decrement format_idx in that case. |
| 1070 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 1071 | // Catch a format attribute mistakenly referring to the object argument. |
| 1072 | if (format_idx == 0) |
| 1073 | return; |
| 1074 | --format_idx; |
| 1075 | if(firstDataArg != 0) |
| 1076 | --firstDataArg; |
| 1077 | } |
| 1078 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1079 | // CHECK: printf/scanf-like function is called with no format string. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 1080 | if (format_idx >= TheCall->getNumArgs()) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1081 | Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 1082 | << Fn->getSourceRange(); |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1083 | return; |
| 1084 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1085 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1086 | const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1087 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1088 | // CHECK: format string is not a string literal. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1089 | // |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1090 | // Dynamically generated format strings are difficult to |
| 1091 | // automatically vet at compile time. Requiring that format strings |
| 1092 | // are string literals: (1) permits the checking of format strings by |
| 1093 | // the compiler and thereby (2) can practically remove the source of |
| 1094 | // many format string exploits. |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1095 | |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1096 | // Format string can be either ObjC string (e.g. @"%d") or |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1097 | // C string (e.g. "%d") |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1098 | // ObjC string uses the same format specifiers as C string, so we can use |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1099 | // the same format string checking logic for both ObjC and C strings. |
Chris Lattner | 1cd3e1f | 2009-04-29 04:49:34 +0000 | [diff] [blame] | 1100 | if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1101 | firstDataArg, isPrintf)) |
Chris Lattner | 1cd3e1f | 2009-04-29 04:49:34 +0000 | [diff] [blame] | 1102 | return; // Literal format string found, check done! |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1103 | |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1104 | // If there are no arguments specified, warn with -Wformat-security, otherwise |
| 1105 | // warn only with -Wformat-nonliteral. |
| 1106 | if (TheCall->getNumArgs() == format_idx+1) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1107 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1108 | diag::warn_format_nonliteral_noargs) |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1109 | << OrigFormatExpr->getSourceRange(); |
| 1110 | else |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1111 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1112 | diag::warn_format_nonliteral) |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1113 | << OrigFormatExpr->getSourceRange(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1114 | } |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1115 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1116 | namespace { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1117 | class CheckFormatHandler : public analyze_format_string::FormatStringHandler { |
| 1118 | protected: |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1119 | Sema &S; |
| 1120 | const StringLiteral *FExpr; |
| 1121 | const Expr *OrigFormatExpr; |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1122 | const unsigned FirstDataArg; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1123 | const unsigned NumDataArgs; |
| 1124 | const bool IsObjCLiteral; |
| 1125 | const char *Beg; // Start of format string. |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1126 | const bool HasVAListArg; |
| 1127 | const CallExpr *TheCall; |
| 1128 | unsigned FormatIdx; |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1129 | llvm::BitVector CoveredArgs; |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1130 | bool usesPositionalArgs; |
| 1131 | bool atFirstArg; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1132 | public: |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1133 | CheckFormatHandler(Sema &s, const StringLiteral *fexpr, |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1134 | const Expr *origFormatExpr, unsigned firstDataArg, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1135 | unsigned numDataArgs, bool isObjCLiteral, |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1136 | const char *beg, bool hasVAListArg, |
| 1137 | const CallExpr *theCall, unsigned formatIdx) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1138 | : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1139 | FirstDataArg(firstDataArg), |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1140 | NumDataArgs(numDataArgs), |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1141 | IsObjCLiteral(isObjCLiteral), Beg(beg), |
| 1142 | HasVAListArg(hasVAListArg), |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1143 | TheCall(theCall), FormatIdx(formatIdx), |
| 1144 | usesPositionalArgs(false), atFirstArg(true) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1145 | CoveredArgs.resize(numDataArgs); |
| 1146 | CoveredArgs.reset(); |
| 1147 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1148 | |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1149 | void DoneProcessing(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1150 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1151 | void HandleIncompleteSpecifier(const char *startSpecifier, |
| 1152 | unsigned specifierLen); |
| 1153 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1154 | virtual void HandleInvalidPosition(const char *startSpecifier, |
| 1155 | unsigned specifierLen, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1156 | analyze_format_string::PositionContext p); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1157 | |
| 1158 | virtual void HandleZeroPosition(const char *startPos, unsigned posLen); |
| 1159 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1160 | void HandleNullChar(const char *nullCharacter); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1161 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1162 | protected: |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1163 | bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, |
| 1164 | const char *startSpec, |
| 1165 | unsigned specifierLen, |
| 1166 | const char *csStart, unsigned csLen); |
| 1167 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1168 | SourceRange getFormatStringRange(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1169 | CharSourceRange getSpecifierRange(const char *startSpecifier, |
| 1170 | unsigned specifierLen); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1171 | SourceLocation getLocationOfByte(const char *x); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1172 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1173 | const Expr *getDataArg(unsigned i) const; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1174 | }; |
| 1175 | } |
| 1176 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1177 | SourceRange CheckFormatHandler::getFormatStringRange() { |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1178 | return OrigFormatExpr->getSourceRange(); |
| 1179 | } |
| 1180 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1181 | CharSourceRange CheckFormatHandler:: |
| 1182 | getSpecifierRange(const char *startSpecifier, unsigned specifierLen) { |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1183 | SourceLocation Start = getLocationOfByte(startSpecifier); |
| 1184 | SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); |
| 1185 | |
| 1186 | // Advance the end SourceLocation by one due to half-open ranges. |
| 1187 | End = End.getFileLocWithOffset(1); |
| 1188 | |
| 1189 | return CharSourceRange::getCharRange(Start, End); |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1190 | } |
| 1191 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1192 | SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1193 | return S.getLocationOfStringLiteralByte(FExpr, x - Beg); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1194 | } |
| 1195 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1196 | void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, |
| 1197 | unsigned specifierLen){ |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1198 | SourceLocation Loc = getLocationOfByte(startSpecifier); |
| 1199 | S.Diag(Loc, diag::warn_printf_incomplete_specifier) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1200 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1201 | } |
| 1202 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1203 | void |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1204 | CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, |
| 1205 | analyze_format_string::PositionContext p) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1206 | SourceLocation Loc = getLocationOfByte(startPos); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1207 | S.Diag(Loc, diag::warn_format_invalid_positional_specifier) |
| 1208 | << (unsigned) p << getSpecifierRange(startPos, posLen); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1209 | } |
| 1210 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1211 | void CheckFormatHandler::HandleZeroPosition(const char *startPos, |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1212 | unsigned posLen) { |
| 1213 | SourceLocation Loc = getLocationOfByte(startPos); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1214 | S.Diag(Loc, diag::warn_format_zero_positional_specifier) |
| 1215 | << getSpecifierRange(startPos, posLen); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1216 | } |
| 1217 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1218 | void CheckFormatHandler::HandleNullChar(const char *nullCharacter) { |
| 1219 | // The presence of a null character is likely an error. |
| 1220 | S.Diag(getLocationOfByte(nullCharacter), |
| 1221 | diag::warn_printf_format_string_contains_null_char) |
| 1222 | << getFormatStringRange(); |
| 1223 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1224 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1225 | const Expr *CheckFormatHandler::getDataArg(unsigned i) const { |
| 1226 | return TheCall->getArg(FirstDataArg + i); |
| 1227 | } |
| 1228 | |
| 1229 | void CheckFormatHandler::DoneProcessing() { |
| 1230 | // Does the number of data arguments exceed the number of |
| 1231 | // format conversions in the format string? |
| 1232 | if (!HasVAListArg) { |
| 1233 | // Find any arguments that weren't covered. |
| 1234 | CoveredArgs.flip(); |
| 1235 | signed notCoveredArg = CoveredArgs.find_first(); |
| 1236 | if (notCoveredArg >= 0) { |
| 1237 | assert((unsigned)notCoveredArg < NumDataArgs); |
| 1238 | S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), |
| 1239 | diag::warn_printf_data_arg_not_used) |
| 1240 | << getFormatStringRange(); |
| 1241 | } |
| 1242 | } |
| 1243 | } |
| 1244 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1245 | bool |
| 1246 | CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, |
| 1247 | SourceLocation Loc, |
| 1248 | const char *startSpec, |
| 1249 | unsigned specifierLen, |
| 1250 | const char *csStart, |
| 1251 | unsigned csLen) { |
| 1252 | |
| 1253 | bool keepGoing = true; |
| 1254 | if (argIndex < NumDataArgs) { |
| 1255 | // Consider the argument coverered, even though the specifier doesn't |
| 1256 | // make sense. |
| 1257 | CoveredArgs.set(argIndex); |
| 1258 | } |
| 1259 | else { |
| 1260 | // If argIndex exceeds the number of data arguments we |
| 1261 | // don't issue a warning because that is just a cascade of warnings (and |
| 1262 | // they may have intended '%%' anyway). We don't want to continue processing |
| 1263 | // the format string after this point, however, as we will like just get |
| 1264 | // gibberish when trying to match arguments. |
| 1265 | keepGoing = false; |
| 1266 | } |
| 1267 | |
| 1268 | S.Diag(Loc, diag::warn_format_invalid_conversion) |
| 1269 | << llvm::StringRef(csStart, csLen) |
| 1270 | << getSpecifierRange(startSpec, specifierLen); |
| 1271 | |
| 1272 | return keepGoing; |
| 1273 | } |
| 1274 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1275 | //===--- CHECK: Printf format string checking ------------------------------===// |
| 1276 | |
| 1277 | namespace { |
| 1278 | class CheckPrintfHandler : public CheckFormatHandler { |
| 1279 | public: |
| 1280 | CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, |
| 1281 | const Expr *origFormatExpr, unsigned firstDataArg, |
| 1282 | unsigned numDataArgs, bool isObjCLiteral, |
| 1283 | const char *beg, bool hasVAListArg, |
| 1284 | const CallExpr *theCall, unsigned formatIdx) |
| 1285 | : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, |
| 1286 | numDataArgs, isObjCLiteral, beg, hasVAListArg, |
| 1287 | theCall, formatIdx) {} |
| 1288 | |
| 1289 | |
| 1290 | bool HandleInvalidPrintfConversionSpecifier( |
| 1291 | const analyze_printf::PrintfSpecifier &FS, |
| 1292 | const char *startSpecifier, |
| 1293 | unsigned specifierLen); |
| 1294 | |
| 1295 | bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, |
| 1296 | const char *startSpecifier, |
| 1297 | unsigned specifierLen); |
| 1298 | |
| 1299 | bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, |
| 1300 | const char *startSpecifier, unsigned specifierLen); |
| 1301 | void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, |
| 1302 | const analyze_printf::OptionalAmount &Amt, |
| 1303 | unsigned type, |
| 1304 | const char *startSpecifier, unsigned specifierLen); |
| 1305 | void HandleFlag(const analyze_printf::PrintfSpecifier &FS, |
| 1306 | const analyze_printf::OptionalFlag &flag, |
| 1307 | const char *startSpecifier, unsigned specifierLen); |
| 1308 | void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, |
| 1309 | const analyze_printf::OptionalFlag &ignoredFlag, |
| 1310 | const analyze_printf::OptionalFlag &flag, |
| 1311 | const char *startSpecifier, unsigned specifierLen); |
| 1312 | }; |
| 1313 | } |
| 1314 | |
| 1315 | bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( |
| 1316 | const analyze_printf::PrintfSpecifier &FS, |
| 1317 | const char *startSpecifier, |
| 1318 | unsigned specifierLen) { |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1319 | const analyze_printf::PrintfConversionSpecifier &CS = |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1320 | FS.getConversionSpecifier(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1321 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1322 | return HandleInvalidConversionSpecifier(FS.getArgIndex(), |
| 1323 | getLocationOfByte(CS.getStart()), |
| 1324 | startSpecifier, specifierLen, |
| 1325 | CS.getStart(), CS.getLength()); |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1326 | } |
| 1327 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1328 | bool CheckPrintfHandler::HandleAmount( |
| 1329 | const analyze_format_string::OptionalAmount &Amt, |
| 1330 | unsigned k, const char *startSpecifier, |
| 1331 | unsigned specifierLen) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1332 | |
| 1333 | if (Amt.hasDataArgument()) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1334 | if (!HasVAListArg) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1335 | unsigned argIndex = Amt.getArgIndex(); |
| 1336 | if (argIndex >= NumDataArgs) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1337 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1338 | diag::warn_printf_asterisk_missing_arg) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1339 | << k << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1340 | // Don't do any more checking. We will just emit |
| 1341 | // spurious errors. |
| 1342 | return false; |
| 1343 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1344 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1345 | // Type check the data argument. It should be an 'int'. |
Ted Kremenek | 31f8e32 | 2010-01-29 23:32:22 +0000 | [diff] [blame] | 1346 | // Although not in conformance with C99, we also allow the argument to be |
| 1347 | // an 'unsigned int' as that is a reasonably safe case. GCC also |
| 1348 | // doesn't emit a warning for that case. |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1349 | CoveredArgs.set(argIndex); |
| 1350 | const Expr *Arg = getDataArg(argIndex); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1351 | QualType T = Arg->getType(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1352 | |
| 1353 | const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); |
| 1354 | assert(ATR.isValid()); |
| 1355 | |
| 1356 | if (!ATR.matchesType(S.Context, T)) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1357 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1358 | diag::warn_printf_asterisk_wrong_type) |
| 1359 | << k |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1360 | << ATR.getRepresentativeType(S.Context) << T |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1361 | << getSpecifierRange(startSpecifier, specifierLen) |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1362 | << Arg->getSourceRange(); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1363 | // Don't do any more checking. We will just emit |
| 1364 | // spurious errors. |
| 1365 | return false; |
| 1366 | } |
| 1367 | } |
| 1368 | } |
| 1369 | return true; |
| 1370 | } |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1371 | |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1372 | void CheckPrintfHandler::HandleInvalidAmount( |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1373 | const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1374 | const analyze_printf::OptionalAmount &Amt, |
| 1375 | unsigned type, |
| 1376 | const char *startSpecifier, |
| 1377 | unsigned specifierLen) { |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1378 | const analyze_printf::PrintfConversionSpecifier &CS = |
| 1379 | FS.getConversionSpecifier(); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1380 | switch (Amt.getHowSpecified()) { |
| 1381 | case analyze_printf::OptionalAmount::Constant: |
| 1382 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1383 | diag::warn_printf_nonsensical_optional_amount) |
| 1384 | << type |
| 1385 | << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1386 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1387 | << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1388 | Amt.getConstantLength())); |
| 1389 | break; |
| 1390 | |
| 1391 | default: |
| 1392 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1393 | diag::warn_printf_nonsensical_optional_amount) |
| 1394 | << type |
| 1395 | << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1396 | << getSpecifierRange(startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1397 | break; |
| 1398 | } |
| 1399 | } |
| 1400 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1401 | void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1402 | const analyze_printf::OptionalFlag &flag, |
| 1403 | const char *startSpecifier, |
| 1404 | unsigned specifierLen) { |
| 1405 | // Warn about pointless flag with a fixit removal. |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1406 | const analyze_printf::PrintfConversionSpecifier &CS = |
| 1407 | FS.getConversionSpecifier(); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1408 | S.Diag(getLocationOfByte(flag.getPosition()), |
| 1409 | diag::warn_printf_nonsensical_flag) |
| 1410 | << flag.toString() << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1411 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1412 | << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1413 | } |
| 1414 | |
| 1415 | void CheckPrintfHandler::HandleIgnoredFlag( |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1416 | const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1417 | const analyze_printf::OptionalFlag &ignoredFlag, |
| 1418 | const analyze_printf::OptionalFlag &flag, |
| 1419 | const char *startSpecifier, |
| 1420 | unsigned specifierLen) { |
| 1421 | // Warn about ignored flag with a fixit removal. |
| 1422 | S.Diag(getLocationOfByte(ignoredFlag.getPosition()), |
| 1423 | diag::warn_printf_ignored_flag) |
| 1424 | << ignoredFlag.toString() << flag.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1425 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1426 | << FixItHint::CreateRemoval(getSpecifierRange( |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1427 | ignoredFlag.getPosition(), 1)); |
| 1428 | } |
| 1429 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1430 | bool |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1431 | CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1432 | &FS, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1433 | const char *startSpecifier, |
| 1434 | unsigned specifierLen) { |
| 1435 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1436 | using namespace analyze_format_string; |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1437 | using namespace analyze_printf; |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1438 | const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1439 | |
Ted Kremenek | baa4006 | 2010-07-19 22:01:06 +0000 | [diff] [blame] | 1440 | if (FS.consumesDataArgument()) { |
| 1441 | if (atFirstArg) { |
| 1442 | atFirstArg = false; |
| 1443 | usesPositionalArgs = FS.usesPositionalArg(); |
| 1444 | } |
| 1445 | else if (usesPositionalArgs != FS.usesPositionalArg()) { |
| 1446 | // Cannot mix-and-match positional and non-positional arguments. |
| 1447 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1448 | diag::warn_format_mix_positional_nonpositional_args) |
| 1449 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1450 | return false; |
| 1451 | } |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1452 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1453 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1454 | // First check if the field width, precision, and conversion specifier |
| 1455 | // have matching data arguments. |
| 1456 | if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, |
| 1457 | startSpecifier, specifierLen)) { |
| 1458 | return false; |
| 1459 | } |
| 1460 | |
| 1461 | if (!HandleAmount(FS.getPrecision(), /* precision */ 1, |
| 1462 | startSpecifier, specifierLen)) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1463 | return false; |
| 1464 | } |
| 1465 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1466 | if (!CS.consumesDataArgument()) { |
| 1467 | // FIXME: Technically specifying a precision or field width here |
| 1468 | // makes no sense. Worth issuing a warning at some point. |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1469 | return true; |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1470 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1471 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1472 | // Consume the argument. |
| 1473 | unsigned argIndex = FS.getArgIndex(); |
Ted Kremenek | e3fc547 | 2010-02-27 08:34:51 +0000 | [diff] [blame] | 1474 | if (argIndex < NumDataArgs) { |
| 1475 | // The check to see if the argIndex is valid will come later. |
| 1476 | // We set the bit here because we may exit early from this |
| 1477 | // function if we encounter some other error. |
| 1478 | CoveredArgs.set(argIndex); |
| 1479 | } |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1480 | |
| 1481 | // Check for using an Objective-C specific conversion specifier |
| 1482 | // in a non-ObjC literal. |
| 1483 | if (!IsObjCLiteral && CS.isObjCArg()) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1484 | return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, |
| 1485 | specifierLen); |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1486 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1487 | |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1488 | // Check for invalid use of field width |
| 1489 | if (!FS.hasValidFieldWidth()) { |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1490 | HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1491 | startSpecifier, specifierLen); |
| 1492 | } |
| 1493 | |
| 1494 | // Check for invalid use of precision |
| 1495 | if (!FS.hasValidPrecision()) { |
| 1496 | HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, |
| 1497 | startSpecifier, specifierLen); |
| 1498 | } |
| 1499 | |
| 1500 | // Check each flag does not conflict with any other component. |
| 1501 | if (!FS.hasValidLeadingZeros()) |
| 1502 | HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); |
| 1503 | if (!FS.hasValidPlusPrefix()) |
| 1504 | HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1505 | if (!FS.hasValidSpacePrefix()) |
| 1506 | HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1507 | if (!FS.hasValidAlternativeForm()) |
| 1508 | HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); |
| 1509 | if (!FS.hasValidLeftJustified()) |
| 1510 | HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); |
| 1511 | |
| 1512 | // Check that flags are not ignored by another flag |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1513 | if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' |
| 1514 | HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), |
| 1515 | startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1516 | if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' |
| 1517 | HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), |
| 1518 | startSpecifier, specifierLen); |
| 1519 | |
| 1520 | // Check the length modifier is valid with the given conversion specifier. |
| 1521 | const LengthModifier &LM = FS.getLengthModifier(); |
| 1522 | if (!FS.hasValidLengthModifier()) |
| 1523 | S.Diag(getLocationOfByte(LM.getStart()), |
Ted Kremenek | 649aecf | 2010-07-20 20:03:43 +0000 | [diff] [blame] | 1524 | diag::warn_format_nonsensical_length) |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1525 | << LM.toString() << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1526 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1527 | << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1528 | LM.getLength())); |
| 1529 | |
| 1530 | // Are we using '%n'? |
Ted Kremenek | 35d353b | 2010-07-20 20:04:10 +0000 | [diff] [blame] | 1531 | if (CS.getKind() == ConversionSpecifier::nArg) { |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1532 | // Issue a warning about this being a possible security issue. |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1533 | S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1534 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1535 | // Continue checking the other format specifiers. |
| 1536 | return true; |
| 1537 | } |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1538 | |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1539 | // The remaining checks depend on the data arguments. |
| 1540 | if (HasVAListArg) |
| 1541 | return true; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1542 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1543 | if (argIndex >= NumDataArgs) { |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1544 | if (FS.usesPositionalArg()) { |
| 1545 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1546 | diag::warn_printf_positional_arg_exceeds_data_args) |
| 1547 | << (argIndex+1) << NumDataArgs |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1548 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1549 | } |
| 1550 | else { |
| 1551 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1552 | diag::warn_printf_insufficient_data_args) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1553 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1554 | } |
| 1555 | |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1556 | // Don't do any more checking. |
| 1557 | return false; |
| 1558 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1559 | |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1560 | // Now type check the data expression that matches the |
| 1561 | // format specifier. |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1562 | const Expr *Ex = getDataArg(argIndex); |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1563 | const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1564 | if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { |
| 1565 | // Check if we didn't match because of an implicit cast from a 'char' |
| 1566 | // or 'short' to an 'int'. This is done because printf is a varargs |
| 1567 | // function. |
| 1568 | if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) |
| 1569 | if (ICE->getType() == S.Context.IntTy) |
| 1570 | if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType())) |
| 1571 | return true; |
Ted Kremenek | 105d41c | 2010-02-01 19:38:10 +0000 | [diff] [blame] | 1572 | |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 1573 | // We may be able to offer a FixItHint if it is a supported type. |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1574 | PrintfSpecifier fixedFS = FS; |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 1575 | bool success = fixedFS.fixType(Ex->getType()); |
| 1576 | |
| 1577 | if (success) { |
| 1578 | // Get the fix string from the fixed format specifier |
| 1579 | llvm::SmallString<128> buf; |
| 1580 | llvm::raw_svector_ostream os(buf); |
| 1581 | fixedFS.toString(os); |
| 1582 | |
| 1583 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1584 | diag::warn_printf_conversion_argument_type_mismatch) |
| 1585 | << ATR.getRepresentativeType(S.Context) << Ex->getType() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1586 | << getSpecifierRange(startSpecifier, specifierLen) |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 1587 | << Ex->getSourceRange() |
| 1588 | << FixItHint::CreateReplacement( |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1589 | getSpecifierRange(startSpecifier, specifierLen), |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 1590 | os.str()); |
| 1591 | } |
| 1592 | else { |
| 1593 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1594 | diag::warn_printf_conversion_argument_type_mismatch) |
| 1595 | << ATR.getRepresentativeType(S.Context) << Ex->getType() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1596 | << getSpecifierRange(startSpecifier, specifierLen) |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 1597 | << Ex->getSourceRange(); |
| 1598 | } |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1599 | } |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1600 | |
| 1601 | return true; |
| 1602 | } |
| 1603 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1604 | //===--- CHECK: Scanf format string checking ------------------------------===// |
| 1605 | |
| 1606 | namespace { |
| 1607 | class CheckScanfHandler : public CheckFormatHandler { |
| 1608 | public: |
| 1609 | CheckScanfHandler(Sema &s, const StringLiteral *fexpr, |
| 1610 | const Expr *origFormatExpr, unsigned firstDataArg, |
| 1611 | unsigned numDataArgs, bool isObjCLiteral, |
| 1612 | const char *beg, bool hasVAListArg, |
| 1613 | const CallExpr *theCall, unsigned formatIdx) |
| 1614 | : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, |
| 1615 | numDataArgs, isObjCLiteral, beg, hasVAListArg, |
| 1616 | theCall, formatIdx) {} |
| 1617 | |
| 1618 | bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, |
| 1619 | const char *startSpecifier, |
| 1620 | unsigned specifierLen); |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1621 | |
| 1622 | bool HandleInvalidScanfConversionSpecifier( |
| 1623 | const analyze_scanf::ScanfSpecifier &FS, |
| 1624 | const char *startSpecifier, |
| 1625 | unsigned specifierLen); |
Ted Kremenek | b7c2101 | 2010-07-16 18:28:03 +0000 | [diff] [blame] | 1626 | |
| 1627 | void HandleIncompleteScanList(const char *start, const char *end); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1628 | }; |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1629 | } |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1630 | |
Ted Kremenek | b7c2101 | 2010-07-16 18:28:03 +0000 | [diff] [blame] | 1631 | void CheckScanfHandler::HandleIncompleteScanList(const char *start, |
| 1632 | const char *end) { |
| 1633 | S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) |
| 1634 | << getSpecifierRange(start, end - start); |
| 1635 | } |
| 1636 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1637 | bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( |
| 1638 | const analyze_scanf::ScanfSpecifier &FS, |
| 1639 | const char *startSpecifier, |
| 1640 | unsigned specifierLen) { |
| 1641 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1642 | const analyze_scanf::ScanfConversionSpecifier &CS = |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1643 | FS.getConversionSpecifier(); |
| 1644 | |
| 1645 | return HandleInvalidConversionSpecifier(FS.getArgIndex(), |
| 1646 | getLocationOfByte(CS.getStart()), |
| 1647 | startSpecifier, specifierLen, |
| 1648 | CS.getStart(), CS.getLength()); |
| 1649 | } |
| 1650 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1651 | bool CheckScanfHandler::HandleScanfSpecifier( |
| 1652 | const analyze_scanf::ScanfSpecifier &FS, |
| 1653 | const char *startSpecifier, |
| 1654 | unsigned specifierLen) { |
| 1655 | |
| 1656 | using namespace analyze_scanf; |
| 1657 | using namespace analyze_format_string; |
| 1658 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame^] | 1659 | const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1660 | |
Ted Kremenek | baa4006 | 2010-07-19 22:01:06 +0000 | [diff] [blame] | 1661 | // Handle case where '%' and '*' don't consume an argument. These shouldn't |
| 1662 | // be used to decide if we are using positional arguments consistently. |
| 1663 | if (FS.consumesDataArgument()) { |
| 1664 | if (atFirstArg) { |
| 1665 | atFirstArg = false; |
| 1666 | usesPositionalArgs = FS.usesPositionalArg(); |
| 1667 | } |
| 1668 | else if (usesPositionalArgs != FS.usesPositionalArg()) { |
| 1669 | // Cannot mix-and-match positional and non-positional arguments. |
| 1670 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1671 | diag::warn_format_mix_positional_nonpositional_args) |
| 1672 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1673 | return false; |
| 1674 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1675 | } |
| 1676 | |
| 1677 | // Check if the field with is non-zero. |
| 1678 | const OptionalAmount &Amt = FS.getFieldWidth(); |
| 1679 | if (Amt.getHowSpecified() == OptionalAmount::Constant) { |
| 1680 | if (Amt.getConstantAmount() == 0) { |
| 1681 | const CharSourceRange &R = getSpecifierRange(Amt.getStart(), |
| 1682 | Amt.getConstantLength()); |
| 1683 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1684 | diag::warn_scanf_nonzero_width) |
| 1685 | << R << FixItHint::CreateRemoval(R); |
| 1686 | } |
| 1687 | } |
| 1688 | |
| 1689 | if (!FS.consumesDataArgument()) { |
| 1690 | // FIXME: Technically specifying a precision or field width here |
| 1691 | // makes no sense. Worth issuing a warning at some point. |
| 1692 | return true; |
| 1693 | } |
| 1694 | |
| 1695 | // Consume the argument. |
| 1696 | unsigned argIndex = FS.getArgIndex(); |
| 1697 | if (argIndex < NumDataArgs) { |
| 1698 | // The check to see if the argIndex is valid will come later. |
| 1699 | // We set the bit here because we may exit early from this |
| 1700 | // function if we encounter some other error. |
| 1701 | CoveredArgs.set(argIndex); |
| 1702 | } |
| 1703 | |
| 1704 | // FIXME: Check that the length modifier is valid with the given |
| 1705 | // conversion specifier. |
| 1706 | |
| 1707 | // The remaining checks depend on the data arguments. |
| 1708 | if (HasVAListArg) |
| 1709 | return true; |
| 1710 | |
| 1711 | if (argIndex >= NumDataArgs) { |
| 1712 | if (FS.usesPositionalArg()) { |
| 1713 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1714 | diag::warn_printf_positional_arg_exceeds_data_args) |
| 1715 | << (argIndex+1) << NumDataArgs |
| 1716 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1717 | } |
| 1718 | else { |
| 1719 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1720 | diag::warn_printf_insufficient_data_args) |
| 1721 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1722 | } |
| 1723 | |
| 1724 | // Don't do any more checking. |
| 1725 | return false; |
| 1726 | } |
| 1727 | |
| 1728 | // FIXME: Check that the argument type matches the format specifier. |
| 1729 | |
| 1730 | return true; |
| 1731 | } |
| 1732 | |
| 1733 | void Sema::CheckFormatString(const StringLiteral *FExpr, |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1734 | const Expr *OrigFormatExpr, |
| 1735 | const CallExpr *TheCall, bool HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1736 | unsigned format_idx, unsigned firstDataArg, |
| 1737 | bool isPrintf) { |
| 1738 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1739 | // CHECK: is the format string a wide literal? |
| 1740 | if (FExpr->isWide()) { |
| 1741 | Diag(FExpr->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1742 | diag::warn_format_string_is_wide_literal) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1743 | << OrigFormatExpr->getSourceRange(); |
| 1744 | return; |
| 1745 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1746 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1747 | // Str - The format string. NOTE: this is NOT null-terminated! |
| 1748 | const char *Str = FExpr->getStrData(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1749 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1750 | // CHECK: empty format string? |
| 1751 | unsigned StrLen = FExpr->getByteLength(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1752 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1753 | if (StrLen == 0) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1754 | Diag(FExpr->getLocStart(), diag::warn_empty_format_string) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1755 | << OrigFormatExpr->getSourceRange(); |
| 1756 | return; |
| 1757 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1758 | |
| 1759 | if (isPrintf) { |
| 1760 | CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, |
| 1761 | TheCall->getNumArgs() - firstDataArg, |
| 1762 | isa<ObjCStringLiteral>(OrigFormatExpr), Str, |
| 1763 | HasVAListArg, TheCall, format_idx); |
| 1764 | |
| 1765 | if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) |
| 1766 | H.DoneProcessing(); |
| 1767 | } |
| 1768 | else { |
| 1769 | CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, |
| 1770 | TheCall->getNumArgs() - firstDataArg, |
| 1771 | isa<ObjCStringLiteral>(OrigFormatExpr), Str, |
| 1772 | HasVAListArg, TheCall, format_idx); |
| 1773 | |
| 1774 | if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) |
| 1775 | H.DoneProcessing(); |
| 1776 | } |
Ted Kremenek | ce7024e | 2010-01-28 01:18:22 +0000 | [diff] [blame] | 1777 | } |
| 1778 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1779 | //===--- CHECK: Return Address of Stack Variable --------------------------===// |
| 1780 | |
| 1781 | static DeclRefExpr* EvalVal(Expr *E); |
| 1782 | static DeclRefExpr* EvalAddr(Expr* E); |
| 1783 | |
| 1784 | /// CheckReturnStackAddr - Check if a return statement returns the address |
| 1785 | /// of a stack variable. |
| 1786 | void |
| 1787 | Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, |
| 1788 | SourceLocation ReturnLoc) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1789 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1790 | // Perform checking for returned stack addresses. |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1791 | if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1792 | if (DeclRefExpr *DR = EvalAddr(RetValExp)) |
Chris Lattner | 3c73c41 | 2008-11-19 08:23:25 +0000 | [diff] [blame] | 1793 | Diag(DR->getLocStart(), diag::warn_ret_stack_addr) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1794 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1795 | |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1796 | // Skip over implicit cast expressions when checking for block expressions. |
Chris Lattner | 4ca606e | 2009-09-08 00:36:37 +0000 | [diff] [blame] | 1797 | RetValExp = RetValExp->IgnoreParenCasts(); |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1798 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1799 | if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp)) |
Mike Stump | 397195b | 2009-04-17 00:09:41 +0000 | [diff] [blame] | 1800 | if (C->hasBlockDeclRefExprs()) |
| 1801 | Diag(C->getLocStart(), diag::err_ret_local_block) |
| 1802 | << C->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1803 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1804 | if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp)) |
| 1805 | Diag(ALE->getLocStart(), diag::warn_ret_addr_label) |
| 1806 | << ALE->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1807 | |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 1808 | } else if (lhsType->isReferenceType()) { |
| 1809 | // Perform checking for stack values returned by reference. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1810 | // Check for a reference to the stack |
| 1811 | if (DeclRefExpr *DR = EvalVal(RetValExp)) |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 1812 | Diag(DR->getLocStart(), diag::warn_ret_stack_ref) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1813 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1814 | } |
| 1815 | } |
| 1816 | |
| 1817 | /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that |
| 1818 | /// check if the expression in a return statement evaluates to an address |
| 1819 | /// to a location on the stack. The recursion is used to traverse the |
| 1820 | /// AST of the return expression, with recursion backtracking when we |
| 1821 | /// encounter a subexpression that (1) clearly does not lead to the address |
| 1822 | /// of a stack variable or (2) is something we cannot determine leads to |
| 1823 | /// the address of a stack variable based on such local checking. |
| 1824 | /// |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1825 | /// EvalAddr processes expressions that are pointers that are used as |
| 1826 | /// references (and not L-values). EvalVal handles all other values. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1827 | /// At the base case of the recursion is a check for a DeclRefExpr* in |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1828 | /// the refers to a stack variable. |
| 1829 | /// |
| 1830 | /// This implementation handles: |
| 1831 | /// |
| 1832 | /// * pointer-to-pointer casts |
| 1833 | /// * implicit conversions from array references to pointers |
| 1834 | /// * taking the address of fields |
| 1835 | /// * arbitrary interplay between "&" and "*" operators |
| 1836 | /// * pointer arithmetic from an address of a stack variable |
| 1837 | /// * taking the address of an array element where the array is on the stack |
| 1838 | static DeclRefExpr* EvalAddr(Expr *E) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1839 | // We should only be called for evaluating pointer expressions. |
David Chisnall | 0f43656 | 2009-08-17 16:35:33 +0000 | [diff] [blame] | 1840 | assert((E->getType()->isAnyPointerType() || |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1841 | E->getType()->isBlockPointerType() || |
Ted Kremenek | a526c5c | 2008-01-07 19:49:32 +0000 | [diff] [blame] | 1842 | E->getType()->isObjCQualifiedIdType()) && |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1843 | "EvalAddr only works on pointers"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1844 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1845 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1846 | // viewed AST node. We then recursively traverse the AST by calling |
| 1847 | // EvalAddr and EvalVal appropriately. |
| 1848 | switch (E->getStmtClass()) { |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1849 | case Stmt::ParenExprClass: |
| 1850 | // Ignore parentheses. |
| 1851 | return EvalAddr(cast<ParenExpr>(E)->getSubExpr()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1852 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1853 | case Stmt::UnaryOperatorClass: { |
| 1854 | // The only unary operator that make sense to handle here |
| 1855 | // is AddrOf. All others don't make sense as pointers. |
| 1856 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1857 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1858 | if (U->getOpcode() == UnaryOperator::AddrOf) |
| 1859 | return EvalVal(U->getSubExpr()); |
| 1860 | else |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1861 | return NULL; |
| 1862 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1863 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1864 | case Stmt::BinaryOperatorClass: { |
| 1865 | // Handle pointer arithmetic. All other binary operators are not valid |
| 1866 | // in this context. |
| 1867 | BinaryOperator *B = cast<BinaryOperator>(E); |
| 1868 | BinaryOperator::Opcode op = B->getOpcode(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1869 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1870 | if (op != BinaryOperator::Add && op != BinaryOperator::Sub) |
| 1871 | return NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1872 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1873 | Expr *Base = B->getLHS(); |
| 1874 | |
| 1875 | // Determine which argument is the real pointer base. It could be |
| 1876 | // the RHS argument instead of the LHS. |
| 1877 | if (!Base->getType()->isPointerType()) Base = B->getRHS(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1878 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1879 | assert (Base->getType()->isPointerType()); |
| 1880 | return EvalAddr(Base); |
| 1881 | } |
Steve Naroff | 61f40a2 | 2008-09-10 19:17:48 +0000 | [diff] [blame] | 1882 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1883 | // For conditional operators we need to see if either the LHS or RHS are |
| 1884 | // valid DeclRefExpr*s. If one of them is valid, we return it. |
| 1885 | case Stmt::ConditionalOperatorClass: { |
| 1886 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1887 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1888 | // Handle the GNU extension for missing LHS. |
| 1889 | if (Expr *lhsExpr = C->getLHS()) |
| 1890 | if (DeclRefExpr* LHS = EvalAddr(lhsExpr)) |
| 1891 | return LHS; |
| 1892 | |
| 1893 | return EvalAddr(C->getRHS()); |
| 1894 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1895 | |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1896 | // For casts, we need to handle conversions from arrays to |
| 1897 | // pointer values, and pointer-to-pointer conversions. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1898 | case Stmt::ImplicitCastExprClass: |
Douglas Gregor | 6eec8e8 | 2008-10-28 15:36:24 +0000 | [diff] [blame] | 1899 | case Stmt::CStyleCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1900 | case Stmt::CXXFunctionalCastExprClass: { |
Argyrios Kyrtzidis | 0835a3c | 2008-08-18 23:01:59 +0000 | [diff] [blame] | 1901 | Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1902 | QualType T = SubExpr->getType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1903 | |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1904 | if (SubExpr->getType()->isPointerType() || |
| 1905 | SubExpr->getType()->isBlockPointerType() || |
| 1906 | SubExpr->getType()->isObjCQualifiedIdType()) |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1907 | return EvalAddr(SubExpr); |
| 1908 | else if (T->isArrayType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1909 | return EvalVal(SubExpr); |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1910 | else |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1911 | return 0; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1912 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1913 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1914 | // C++ casts. For dynamic casts, static casts, and const casts, we |
| 1915 | // are always converting from a pointer-to-pointer, so we just blow |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1916 | // through the cast. In the case the dynamic cast doesn't fail (and |
| 1917 | // return NULL), we take the conservative route and report cases |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1918 | // where we return the address of a stack variable. For Reinterpre |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1919 | // FIXME: The comment about is wrong; we're not always converting |
| 1920 | // from pointer to pointer. I'm guessing that this code should also |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1921 | // handle references to objects. |
| 1922 | case Stmt::CXXStaticCastExprClass: |
| 1923 | case Stmt::CXXDynamicCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1924 | case Stmt::CXXConstCastExprClass: |
| 1925 | case Stmt::CXXReinterpretCastExprClass: { |
| 1926 | Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1927 | if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1928 | return EvalAddr(S); |
| 1929 | else |
| 1930 | return NULL; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1931 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1932 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1933 | // Everything else: we simply don't reason about them. |
| 1934 | default: |
| 1935 | return NULL; |
| 1936 | } |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1937 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1938 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1939 | |
| 1940 | /// EvalVal - This function is complements EvalAddr in the mutual recursion. |
| 1941 | /// See the comments for EvalAddr for more details. |
| 1942 | static DeclRefExpr* EvalVal(Expr *E) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1943 | |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1944 | // We should only be called for evaluating non-pointer expressions, or |
| 1945 | // expressions with a pointer type that are not used as references but instead |
| 1946 | // are l-values (e.g., DeclRefExpr with a pointer type). |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1947 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1948 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1949 | // viewed AST node. We then recursively traverse the AST by calling |
| 1950 | // EvalAddr and EvalVal appropriately. |
| 1951 | switch (E->getStmtClass()) { |
Douglas Gregor | a2813ce | 2009-10-23 18:54:35 +0000 | [diff] [blame] | 1952 | case Stmt::DeclRefExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1953 | // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking |
| 1954 | // at code that refers to a variable's name. We check if it has local |
| 1955 | // storage within the function, and if so, return the expression. |
| 1956 | DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1957 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1958 | if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1959 | if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR; |
| 1960 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1961 | return NULL; |
| 1962 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1963 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1964 | case Stmt::ParenExprClass: |
| 1965 | // Ignore parentheses. |
| 1966 | return EvalVal(cast<ParenExpr>(E)->getSubExpr()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1967 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1968 | case Stmt::UnaryOperatorClass: { |
| 1969 | // The only unary operator that make sense to handle here |
| 1970 | // is Deref. All others don't resolve to a "name." This includes |
| 1971 | // handling all sorts of rvalues passed to a unary operator. |
| 1972 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1973 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1974 | if (U->getOpcode() == UnaryOperator::Deref) |
| 1975 | return EvalAddr(U->getSubExpr()); |
| 1976 | |
| 1977 | return NULL; |
| 1978 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1979 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1980 | case Stmt::ArraySubscriptExprClass: { |
| 1981 | // Array subscripts are potential references to data on the stack. We |
| 1982 | // retrieve the DeclRefExpr* for the array variable if it indeed |
| 1983 | // has local storage. |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 1984 | return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1985 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1986 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1987 | case Stmt::ConditionalOperatorClass: { |
| 1988 | // For conditional operators we need to see if either the LHS or RHS are |
| 1989 | // non-NULL DeclRefExpr's. If one is non-NULL, we return it. |
| 1990 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
| 1991 | |
Anders Carlsson | 3907323 | 2007-11-30 19:04:31 +0000 | [diff] [blame] | 1992 | // Handle the GNU extension for missing LHS. |
| 1993 | if (Expr *lhsExpr = C->getLHS()) |
| 1994 | if (DeclRefExpr *LHS = EvalVal(lhsExpr)) |
| 1995 | return LHS; |
| 1996 | |
| 1997 | return EvalVal(C->getRHS()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1998 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1999 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2000 | // Accesses to members are potential references to data on the stack. |
Douglas Gregor | 83f6faf | 2009-08-31 23:41:50 +0000 | [diff] [blame] | 2001 | case Stmt::MemberExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2002 | MemberExpr *M = cast<MemberExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2003 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2004 | // Check for indirect access. We only want direct field accesses. |
| 2005 | if (!M->isArrow()) |
| 2006 | return EvalVal(M->getBase()); |
| 2007 | else |
| 2008 | return NULL; |
| 2009 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2010 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2011 | // Everything else: we simply don't reason about them. |
| 2012 | default: |
| 2013 | return NULL; |
| 2014 | } |
| 2015 | } |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2016 | |
| 2017 | //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// |
| 2018 | |
| 2019 | /// Check for comparisons of floating point operands using != and ==. |
| 2020 | /// Issue a warning if these are no self-comparisons, as they are not likely |
| 2021 | /// to do what the programmer intended. |
| 2022 | void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { |
| 2023 | bool EmitWarning = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2024 | |
Ted Kremenek | 4e99a5f | 2008-01-17 16:57:34 +0000 | [diff] [blame] | 2025 | Expr* LeftExprSansParen = lex->IgnoreParens(); |
Ted Kremenek | 32e97b6 | 2008-01-17 17:55:13 +0000 | [diff] [blame] | 2026 | Expr* RightExprSansParen = rex->IgnoreParens(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2027 | |
| 2028 | // Special case: check for x == x (which is OK). |
| 2029 | // Do not emit warnings for such cases. |
| 2030 | if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) |
| 2031 | if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) |
| 2032 | if (DRL->getDecl() == DRR->getDecl()) |
| 2033 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2034 | |
| 2035 | |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 2036 | // Special case: check for comparisons against literals that can be exactly |
| 2037 | // represented by APFloat. In such cases, do not emit a warning. This |
| 2038 | // is a heuristic: often comparison against such literals are used to |
| 2039 | // detect if a value in a variable has not changed. This clearly can |
| 2040 | // lead to false negatives. |
| 2041 | if (EmitWarning) { |
| 2042 | if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { |
| 2043 | if (FLL->isExact()) |
| 2044 | EmitWarning = false; |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 2045 | } else |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 2046 | if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ |
| 2047 | if (FLR->isExact()) |
| 2048 | EmitWarning = false; |
| 2049 | } |
| 2050 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2051 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2052 | // Check for comparisons with builtin types. |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 2053 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2054 | if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 2055 | if (CL->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2056 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2057 | |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 2058 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2059 | if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 2060 | if (CR->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2061 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2062 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2063 | // Emit the diagnostic. |
| 2064 | if (EmitWarning) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 2065 | Diag(loc, diag::warn_floatingpoint_eq) |
| 2066 | << lex->getSourceRange() << rex->getSourceRange(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2067 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2068 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2069 | //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// |
| 2070 | //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2071 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2072 | namespace { |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2073 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2074 | /// Structure recording the 'active' range of an integer-valued |
| 2075 | /// expression. |
| 2076 | struct IntRange { |
| 2077 | /// The number of bits active in the int. |
| 2078 | unsigned Width; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2079 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2080 | /// True if the int is known not to have negative values. |
| 2081 | bool NonNegative; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2082 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2083 | IntRange() {} |
| 2084 | IntRange(unsigned Width, bool NonNegative) |
| 2085 | : Width(Width), NonNegative(NonNegative) |
| 2086 | {} |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2087 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2088 | // Returns the range of the bool type. |
| 2089 | static IntRange forBoolType() { |
| 2090 | return IntRange(1, true); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2091 | } |
| 2092 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2093 | // Returns the range of an integral type. |
| 2094 | static IntRange forType(ASTContext &C, QualType T) { |
| 2095 | return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2096 | } |
| 2097 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2098 | // Returns the range of an integeral type based on its canonical |
| 2099 | // representation. |
| 2100 | static IntRange forCanonicalType(ASTContext &C, const Type *T) { |
| 2101 | assert(T->isCanonicalUnqualified()); |
| 2102 | |
| 2103 | if (const VectorType *VT = dyn_cast<VectorType>(T)) |
| 2104 | T = VT->getElementType().getTypePtr(); |
| 2105 | if (const ComplexType *CT = dyn_cast<ComplexType>(T)) |
| 2106 | T = CT->getElementType().getTypePtr(); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2107 | |
| 2108 | if (const EnumType *ET = dyn_cast<EnumType>(T)) { |
| 2109 | EnumDecl *Enum = ET->getDecl(); |
| 2110 | unsigned NumPositive = Enum->getNumPositiveBits(); |
| 2111 | unsigned NumNegative = Enum->getNumNegativeBits(); |
| 2112 | |
| 2113 | return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); |
| 2114 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2115 | |
| 2116 | const BuiltinType *BT = cast<BuiltinType>(T); |
| 2117 | assert(BT->isInteger()); |
| 2118 | |
| 2119 | return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); |
| 2120 | } |
| 2121 | |
| 2122 | // Returns the supremum of two ranges: i.e. their conservative merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2123 | static IntRange join(IntRange L, IntRange R) { |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2124 | return IntRange(std::max(L.Width, R.Width), |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2125 | L.NonNegative && R.NonNegative); |
| 2126 | } |
| 2127 | |
| 2128 | // Returns the infinum of two ranges: i.e. their aggressive merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2129 | static IntRange meet(IntRange L, IntRange R) { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2130 | return IntRange(std::min(L.Width, R.Width), |
| 2131 | L.NonNegative || R.NonNegative); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2132 | } |
| 2133 | }; |
| 2134 | |
| 2135 | IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { |
| 2136 | if (value.isSigned() && value.isNegative()) |
| 2137 | return IntRange(value.getMinSignedBits(), false); |
| 2138 | |
| 2139 | if (value.getBitWidth() > MaxWidth) |
| 2140 | value.trunc(MaxWidth); |
| 2141 | |
| 2142 | // isNonNegative() just checks the sign bit without considering |
| 2143 | // signedness. |
| 2144 | return IntRange(value.getActiveBits(), true); |
| 2145 | } |
| 2146 | |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2147 | IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2148 | unsigned MaxWidth) { |
| 2149 | if (result.isInt()) |
| 2150 | return GetValueRange(C, result.getInt(), MaxWidth); |
| 2151 | |
| 2152 | if (result.isVector()) { |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2153 | IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); |
| 2154 | for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { |
| 2155 | IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); |
| 2156 | R = IntRange::join(R, El); |
| 2157 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2158 | return R; |
| 2159 | } |
| 2160 | |
| 2161 | if (result.isComplexInt()) { |
| 2162 | IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); |
| 2163 | IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); |
| 2164 | return IntRange::join(R, I); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2165 | } |
| 2166 | |
| 2167 | // This can happen with lossless casts to intptr_t of "based" lvalues. |
| 2168 | // Assume it might use arbitrary bits. |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2169 | // FIXME: The only reason we need to pass the type in here is to get |
| 2170 | // the sign right on this one case. It would be nice if APValue |
| 2171 | // preserved this. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2172 | assert(result.isLValue()); |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2173 | return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2174 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2175 | |
| 2176 | /// Pseudo-evaluate the given integer expression, estimating the |
| 2177 | /// range of values it might take. |
| 2178 | /// |
| 2179 | /// \param MaxWidth - the width to which the value will be truncated |
| 2180 | IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { |
| 2181 | E = E->IgnoreParens(); |
| 2182 | |
| 2183 | // Try a full evaluation first. |
| 2184 | Expr::EvalResult result; |
| 2185 | if (E->Evaluate(result, C)) |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2186 | return GetValueRange(C, result.Val, E->getType(), MaxWidth); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2187 | |
| 2188 | // I think we only want to look through implicit casts here; if the |
| 2189 | // user has an explicit widening cast, we should treat the value as |
| 2190 | // being of the new, wider type. |
| 2191 | if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { |
| 2192 | if (CE->getCastKind() == CastExpr::CK_NoOp) |
| 2193 | return GetExprRange(C, CE->getSubExpr(), MaxWidth); |
| 2194 | |
| 2195 | IntRange OutputTypeRange = IntRange::forType(C, CE->getType()); |
| 2196 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2197 | bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast); |
| 2198 | if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown) |
| 2199 | isIntegerCast = CE->getSubExpr()->getType()->isIntegerType(); |
| 2200 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2201 | // Assume that non-integer casts can span the full range of the type. |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2202 | if (!isIntegerCast) |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2203 | return OutputTypeRange; |
| 2204 | |
| 2205 | IntRange SubRange |
| 2206 | = GetExprRange(C, CE->getSubExpr(), |
| 2207 | std::min(MaxWidth, OutputTypeRange.Width)); |
| 2208 | |
| 2209 | // Bail out if the subexpr's range is as wide as the cast type. |
| 2210 | if (SubRange.Width >= OutputTypeRange.Width) |
| 2211 | return OutputTypeRange; |
| 2212 | |
| 2213 | // Otherwise, we take the smaller width, and we're non-negative if |
| 2214 | // either the output type or the subexpr is. |
| 2215 | return IntRange(SubRange.Width, |
| 2216 | SubRange.NonNegative || OutputTypeRange.NonNegative); |
| 2217 | } |
| 2218 | |
| 2219 | if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { |
| 2220 | // If we can fold the condition, just take that operand. |
| 2221 | bool CondResult; |
| 2222 | if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) |
| 2223 | return GetExprRange(C, CondResult ? CO->getTrueExpr() |
| 2224 | : CO->getFalseExpr(), |
| 2225 | MaxWidth); |
| 2226 | |
| 2227 | // Otherwise, conservatively merge. |
| 2228 | IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); |
| 2229 | IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); |
| 2230 | return IntRange::join(L, R); |
| 2231 | } |
| 2232 | |
| 2233 | if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { |
| 2234 | switch (BO->getOpcode()) { |
| 2235 | |
| 2236 | // Boolean-valued operations are single-bit and positive. |
| 2237 | case BinaryOperator::LAnd: |
| 2238 | case BinaryOperator::LOr: |
| 2239 | case BinaryOperator::LT: |
| 2240 | case BinaryOperator::GT: |
| 2241 | case BinaryOperator::LE: |
| 2242 | case BinaryOperator::GE: |
| 2243 | case BinaryOperator::EQ: |
| 2244 | case BinaryOperator::NE: |
| 2245 | return IntRange::forBoolType(); |
| 2246 | |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2247 | // The type of these compound assignments is the type of the LHS, |
| 2248 | // so the RHS is not necessarily an integer. |
| 2249 | case BinaryOperator::MulAssign: |
| 2250 | case BinaryOperator::DivAssign: |
| 2251 | case BinaryOperator::RemAssign: |
| 2252 | case BinaryOperator::AddAssign: |
| 2253 | case BinaryOperator::SubAssign: |
| 2254 | return IntRange::forType(C, E->getType()); |
| 2255 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2256 | // Operations with opaque sources are black-listed. |
| 2257 | case BinaryOperator::PtrMemD: |
| 2258 | case BinaryOperator::PtrMemI: |
| 2259 | return IntRange::forType(C, E->getType()); |
| 2260 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2261 | // Bitwise-and uses the *infinum* of the two source ranges. |
| 2262 | case BinaryOperator::And: |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2263 | case BinaryOperator::AndAssign: |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2264 | return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), |
| 2265 | GetExprRange(C, BO->getRHS(), MaxWidth)); |
| 2266 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2267 | // Left shift gets black-listed based on a judgement call. |
| 2268 | case BinaryOperator::Shl: |
John McCall | 3aae609 | 2010-04-07 01:14:35 +0000 | [diff] [blame] | 2269 | // ...except that we want to treat '1 << (blah)' as logically |
| 2270 | // positive. It's an important idiom. |
| 2271 | if (IntegerLiteral *I |
| 2272 | = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { |
| 2273 | if (I->getValue() == 1) { |
| 2274 | IntRange R = IntRange::forType(C, E->getType()); |
| 2275 | return IntRange(R.Width, /*NonNegative*/ true); |
| 2276 | } |
| 2277 | } |
| 2278 | // fallthrough |
| 2279 | |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2280 | case BinaryOperator::ShlAssign: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2281 | return IntRange::forType(C, E->getType()); |
| 2282 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2283 | // Right shift by a constant can narrow its left argument. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2284 | case BinaryOperator::Shr: |
| 2285 | case BinaryOperator::ShrAssign: { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2286 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 2287 | |
| 2288 | // If the shift amount is a positive constant, drop the width by |
| 2289 | // that much. |
| 2290 | llvm::APSInt shift; |
| 2291 | if (BO->getRHS()->isIntegerConstantExpr(shift, C) && |
| 2292 | shift.isNonNegative()) { |
| 2293 | unsigned zext = shift.getZExtValue(); |
| 2294 | if (zext >= L.Width) |
| 2295 | L.Width = (L.NonNegative ? 0 : 1); |
| 2296 | else |
| 2297 | L.Width -= zext; |
| 2298 | } |
| 2299 | |
| 2300 | return L; |
| 2301 | } |
| 2302 | |
| 2303 | // Comma acts as its right operand. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2304 | case BinaryOperator::Comma: |
| 2305 | return GetExprRange(C, BO->getRHS(), MaxWidth); |
| 2306 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2307 | // Black-list pointer subtractions. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2308 | case BinaryOperator::Sub: |
| 2309 | if (BO->getLHS()->getType()->isPointerType()) |
| 2310 | return IntRange::forType(C, E->getType()); |
| 2311 | // fallthrough |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 2312 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2313 | default: |
| 2314 | break; |
| 2315 | } |
| 2316 | |
| 2317 | // Treat every other operator as if it were closed on the |
| 2318 | // narrowest type that encompasses both operands. |
| 2319 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 2320 | IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); |
| 2321 | return IntRange::join(L, R); |
| 2322 | } |
| 2323 | |
| 2324 | if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { |
| 2325 | switch (UO->getOpcode()) { |
| 2326 | // Boolean-valued operations are white-listed. |
| 2327 | case UnaryOperator::LNot: |
| 2328 | return IntRange::forBoolType(); |
| 2329 | |
| 2330 | // Operations with opaque sources are black-listed. |
| 2331 | case UnaryOperator::Deref: |
| 2332 | case UnaryOperator::AddrOf: // should be impossible |
| 2333 | case UnaryOperator::OffsetOf: |
| 2334 | return IntRange::forType(C, E->getType()); |
| 2335 | |
| 2336 | default: |
| 2337 | return GetExprRange(C, UO->getSubExpr(), MaxWidth); |
| 2338 | } |
| 2339 | } |
Douglas Gregor | 8ecdb65 | 2010-04-28 22:16:22 +0000 | [diff] [blame] | 2340 | |
| 2341 | if (dyn_cast<OffsetOfExpr>(E)) { |
| 2342 | IntRange::forType(C, E->getType()); |
| 2343 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2344 | |
| 2345 | FieldDecl *BitField = E->getBitField(); |
| 2346 | if (BitField) { |
| 2347 | llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); |
| 2348 | unsigned BitWidth = BitWidthAP.getZExtValue(); |
| 2349 | |
| 2350 | return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); |
| 2351 | } |
| 2352 | |
| 2353 | return IntRange::forType(C, E->getType()); |
| 2354 | } |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2355 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2356 | IntRange GetExprRange(ASTContext &C, Expr *E) { |
| 2357 | return GetExprRange(C, E, C.getIntWidth(E->getType())); |
| 2358 | } |
| 2359 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2360 | /// Checks whether the given value, which currently has the given |
| 2361 | /// source semantics, has the same value when coerced through the |
| 2362 | /// target semantics. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2363 | bool IsSameFloatAfterCast(const llvm::APFloat &value, |
| 2364 | const llvm::fltSemantics &Src, |
| 2365 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2366 | llvm::APFloat truncated = value; |
| 2367 | |
| 2368 | bool ignored; |
| 2369 | truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 2370 | truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 2371 | |
| 2372 | return truncated.bitwiseIsEqual(value); |
| 2373 | } |
| 2374 | |
| 2375 | /// Checks whether the given value, which currently has the given |
| 2376 | /// source semantics, has the same value when coerced through the |
| 2377 | /// target semantics. |
| 2378 | /// |
| 2379 | /// The value might be a vector of floats (or a complex number). |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2380 | bool IsSameFloatAfterCast(const APValue &value, |
| 2381 | const llvm::fltSemantics &Src, |
| 2382 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2383 | if (value.isFloat()) |
| 2384 | return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); |
| 2385 | |
| 2386 | if (value.isVector()) { |
| 2387 | for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) |
| 2388 | if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) |
| 2389 | return false; |
| 2390 | return true; |
| 2391 | } |
| 2392 | |
| 2393 | assert(value.isComplexFloat()); |
| 2394 | return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && |
| 2395 | IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); |
| 2396 | } |
| 2397 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2398 | void AnalyzeImplicitConversions(Sema &S, Expr *E); |
| 2399 | |
| 2400 | bool IsZero(Sema &S, Expr *E) { |
| 2401 | llvm::APSInt Value; |
| 2402 | return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; |
| 2403 | } |
| 2404 | |
| 2405 | void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { |
| 2406 | BinaryOperator::Opcode op = E->getOpcode(); |
| 2407 | if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) { |
| 2408 | S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) |
| 2409 | << "< 0" << "false" |
| 2410 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
| 2411 | } else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) { |
| 2412 | S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) |
| 2413 | << ">= 0" << "true" |
| 2414 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
| 2415 | } else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) { |
| 2416 | S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) |
| 2417 | << "0 >" << "false" |
| 2418 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
| 2419 | } else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) { |
| 2420 | S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) |
| 2421 | << "0 <=" << "true" |
| 2422 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
| 2423 | } |
| 2424 | } |
| 2425 | |
| 2426 | /// Analyze the operands of the given comparison. Implements the |
| 2427 | /// fallback case from AnalyzeComparison. |
| 2428 | void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { |
| 2429 | AnalyzeImplicitConversions(S, E->getLHS()); |
| 2430 | AnalyzeImplicitConversions(S, E->getRHS()); |
| 2431 | } |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2432 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2433 | /// \brief Implements -Wsign-compare. |
| 2434 | /// |
| 2435 | /// \param lex the left-hand expression |
| 2436 | /// \param rex the right-hand expression |
| 2437 | /// \param OpLoc the location of the joining operator |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2438 | /// \param BinOpc binary opcode or 0 |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2439 | void AnalyzeComparison(Sema &S, BinaryOperator *E) { |
| 2440 | // The type the comparison is being performed in. |
| 2441 | QualType T = E->getLHS()->getType(); |
| 2442 | assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) |
| 2443 | && "comparison with mismatched types"); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2444 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2445 | // We don't do anything special if this isn't an unsigned integral |
| 2446 | // comparison: we're only interested in integral comparisons, and |
| 2447 | // signed comparisons only happen in cases we don't care to warn about. |
| 2448 | if (!T->isUnsignedIntegerType()) |
| 2449 | return AnalyzeImpConvsInComparison(S, E); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2450 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2451 | Expr *lex = E->getLHS()->IgnoreParenImpCasts(); |
| 2452 | Expr *rex = E->getRHS()->IgnoreParenImpCasts(); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2453 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2454 | // Check to see if one of the (unmodified) operands is of different |
| 2455 | // signedness. |
| 2456 | Expr *signedOperand, *unsignedOperand; |
| 2457 | if (lex->getType()->isSignedIntegerType()) { |
| 2458 | assert(!rex->getType()->isSignedIntegerType() && |
| 2459 | "unsigned comparison between two signed integer expressions?"); |
| 2460 | signedOperand = lex; |
| 2461 | unsignedOperand = rex; |
| 2462 | } else if (rex->getType()->isSignedIntegerType()) { |
| 2463 | signedOperand = rex; |
| 2464 | unsignedOperand = lex; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2465 | } else { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2466 | CheckTrivialUnsignedComparison(S, E); |
| 2467 | return AnalyzeImpConvsInComparison(S, E); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2468 | } |
| 2469 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2470 | // Otherwise, calculate the effective range of the signed operand. |
| 2471 | IntRange signedRange = GetExprRange(S.Context, signedOperand); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2472 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2473 | // Go ahead and analyze implicit conversions in the operands. Note |
| 2474 | // that we skip the implicit conversions on both sides. |
| 2475 | AnalyzeImplicitConversions(S, lex); |
| 2476 | AnalyzeImplicitConversions(S, rex); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2477 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2478 | // If the signed range is non-negative, -Wsign-compare won't fire, |
| 2479 | // but we should still check for comparisons which are always true |
| 2480 | // or false. |
| 2481 | if (signedRange.NonNegative) |
| 2482 | return CheckTrivialUnsignedComparison(S, E); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2483 | |
| 2484 | // For (in)equality comparisons, if the unsigned operand is a |
| 2485 | // constant which cannot collide with a overflowed signed operand, |
| 2486 | // then reinterpreting the signed operand as unsigned will not |
| 2487 | // change the result of the comparison. |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2488 | if (E->isEqualityOp()) { |
| 2489 | unsigned comparisonWidth = S.Context.getIntWidth(T); |
| 2490 | IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2491 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2492 | // We should never be unable to prove that the unsigned operand is |
| 2493 | // non-negative. |
| 2494 | assert(unsignedRange.NonNegative && "unsigned range includes negative?"); |
| 2495 | |
| 2496 | if (unsignedRange.Width < comparisonWidth) |
| 2497 | return; |
| 2498 | } |
| 2499 | |
| 2500 | S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) |
| 2501 | << lex->getType() << rex->getType() |
| 2502 | << lex->getSourceRange() << rex->getSourceRange(); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2503 | } |
| 2504 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2505 | /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2506 | void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2507 | S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange(); |
| 2508 | } |
| 2509 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2510 | void CheckImplicitConversion(Sema &S, Expr *E, QualType T, |
| 2511 | bool *ICContext = 0) { |
| 2512 | if (E->isTypeDependent() || E->isValueDependent()) return; |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2513 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2514 | const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); |
| 2515 | const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); |
| 2516 | if (Source == Target) return; |
| 2517 | if (Target->isDependentType()) return; |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2518 | |
| 2519 | // Never diagnose implicit casts to bool. |
| 2520 | if (Target->isSpecificBuiltinType(BuiltinType::Bool)) |
| 2521 | return; |
| 2522 | |
| 2523 | // Strip vector types. |
| 2524 | if (isa<VectorType>(Source)) { |
| 2525 | if (!isa<VectorType>(Target)) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2526 | return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2527 | |
| 2528 | Source = cast<VectorType>(Source)->getElementType().getTypePtr(); |
| 2529 | Target = cast<VectorType>(Target)->getElementType().getTypePtr(); |
| 2530 | } |
| 2531 | |
| 2532 | // Strip complex types. |
| 2533 | if (isa<ComplexType>(Source)) { |
| 2534 | if (!isa<ComplexType>(Target)) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2535 | return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2536 | |
| 2537 | Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); |
| 2538 | Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); |
| 2539 | } |
| 2540 | |
| 2541 | const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); |
| 2542 | const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); |
| 2543 | |
| 2544 | // If the source is floating point... |
| 2545 | if (SourceBT && SourceBT->isFloatingPoint()) { |
| 2546 | // ...and the target is floating point... |
| 2547 | if (TargetBT && TargetBT->isFloatingPoint()) { |
| 2548 | // ...then warn if we're dropping FP rank. |
| 2549 | |
| 2550 | // Builtin FP kinds are ordered by increasing FP rank. |
| 2551 | if (SourceBT->getKind() > TargetBT->getKind()) { |
| 2552 | // Don't warn about float constants that are precisely |
| 2553 | // representable in the target type. |
| 2554 | Expr::EvalResult result; |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2555 | if (E->Evaluate(result, S.Context)) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2556 | // Value might be a float, a float vector, or a float complex. |
| 2557 | if (IsSameFloatAfterCast(result.Val, |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2558 | S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), |
| 2559 | S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2560 | return; |
| 2561 | } |
| 2562 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2563 | DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2564 | } |
| 2565 | return; |
| 2566 | } |
| 2567 | |
| 2568 | // If the target is integral, always warn. |
| 2569 | if ((TargetBT && TargetBT->isInteger())) |
| 2570 | // TODO: don't warn for integer values? |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2571 | DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2572 | |
| 2573 | return; |
| 2574 | } |
| 2575 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2576 | if (!Source->isIntegerType() || !Target->isIntegerType()) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2577 | return; |
| 2578 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2579 | IntRange SourceRange = GetExprRange(S.Context, E); |
| 2580 | IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2581 | |
| 2582 | if (SourceRange.Width > TargetRange.Width) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2583 | // People want to build with -Wshorten-64-to-32 and not -Wconversion |
| 2584 | // and by god we'll let them. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2585 | if (SourceRange.Width == 64 && TargetRange.Width == 32) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2586 | return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32); |
| 2587 | return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision); |
| 2588 | } |
| 2589 | |
| 2590 | if ((TargetRange.NonNegative && !SourceRange.NonNegative) || |
| 2591 | (!TargetRange.NonNegative && SourceRange.NonNegative && |
| 2592 | SourceRange.Width == TargetRange.Width)) { |
| 2593 | unsigned DiagID = diag::warn_impcast_integer_sign; |
| 2594 | |
| 2595 | // Traditionally, gcc has warned about this under -Wsign-compare. |
| 2596 | // We also want to warn about it in -Wconversion. |
| 2597 | // So if -Wconversion is off, use a completely identical diagnostic |
| 2598 | // in the sign-compare group. |
| 2599 | // The conditional-checking code will |
| 2600 | if (ICContext) { |
| 2601 | DiagID = diag::warn_impcast_integer_sign_conditional; |
| 2602 | *ICContext = true; |
| 2603 | } |
| 2604 | |
| 2605 | return DiagnoseImpCast(S, E, T, DiagID); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2606 | } |
| 2607 | |
| 2608 | return; |
| 2609 | } |
| 2610 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2611 | void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); |
| 2612 | |
| 2613 | void CheckConditionalOperand(Sema &S, Expr *E, QualType T, |
| 2614 | bool &ICContext) { |
| 2615 | E = E->IgnoreParenImpCasts(); |
| 2616 | |
| 2617 | if (isa<ConditionalOperator>(E)) |
| 2618 | return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); |
| 2619 | |
| 2620 | AnalyzeImplicitConversions(S, E); |
| 2621 | if (E->getType() != T) |
| 2622 | return CheckImplicitConversion(S, E, T, &ICContext); |
| 2623 | return; |
| 2624 | } |
| 2625 | |
| 2626 | void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { |
| 2627 | AnalyzeImplicitConversions(S, E->getCond()); |
| 2628 | |
| 2629 | bool Suspicious = false; |
| 2630 | CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious); |
| 2631 | CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious); |
| 2632 | |
| 2633 | // If -Wconversion would have warned about either of the candidates |
| 2634 | // for a signedness conversion to the context type... |
| 2635 | if (!Suspicious) return; |
| 2636 | |
| 2637 | // ...but it's currently ignored... |
| 2638 | if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional)) |
| 2639 | return; |
| 2640 | |
| 2641 | // ...and -Wsign-compare isn't... |
| 2642 | if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional)) |
| 2643 | return; |
| 2644 | |
| 2645 | // ...then check whether it would have warned about either of the |
| 2646 | // candidates for a signedness conversion to the condition type. |
| 2647 | if (E->getType() != T) { |
| 2648 | Suspicious = false; |
| 2649 | CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), |
| 2650 | E->getType(), &Suspicious); |
| 2651 | if (!Suspicious) |
| 2652 | CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), |
| 2653 | E->getType(), &Suspicious); |
| 2654 | if (!Suspicious) |
| 2655 | return; |
| 2656 | } |
| 2657 | |
| 2658 | // If so, emit a diagnostic under -Wsign-compare. |
| 2659 | Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); |
| 2660 | Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); |
| 2661 | S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) |
| 2662 | << lex->getType() << rex->getType() |
| 2663 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2664 | } |
| 2665 | |
| 2666 | /// AnalyzeImplicitConversions - Find and report any interesting |
| 2667 | /// implicit conversions in the given expression. There are a couple |
| 2668 | /// of competing diagnostics here, -Wconversion and -Wsign-compare. |
| 2669 | void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) { |
| 2670 | QualType T = OrigE->getType(); |
| 2671 | Expr *E = OrigE->IgnoreParenImpCasts(); |
| 2672 | |
| 2673 | // For conditional operators, we analyze the arguments as if they |
| 2674 | // were being fed directly into the output. |
| 2675 | if (isa<ConditionalOperator>(E)) { |
| 2676 | ConditionalOperator *CO = cast<ConditionalOperator>(E); |
| 2677 | CheckConditionalOperator(S, CO, T); |
| 2678 | return; |
| 2679 | } |
| 2680 | |
| 2681 | // Go ahead and check any implicit conversions we might have skipped. |
| 2682 | // The non-canonical typecheck is just an optimization; |
| 2683 | // CheckImplicitConversion will filter out dead implicit conversions. |
| 2684 | if (E->getType() != T) |
| 2685 | CheckImplicitConversion(S, E, T); |
| 2686 | |
| 2687 | // Now continue drilling into this expression. |
| 2688 | |
| 2689 | // Skip past explicit casts. |
| 2690 | if (isa<ExplicitCastExpr>(E)) { |
| 2691 | E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); |
| 2692 | return AnalyzeImplicitConversions(S, E); |
| 2693 | } |
| 2694 | |
| 2695 | // Do a somewhat different check with comparison operators. |
| 2696 | if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp()) |
| 2697 | return AnalyzeComparison(S, cast<BinaryOperator>(E)); |
| 2698 | |
| 2699 | // These break the otherwise-useful invariant below. Fortunately, |
| 2700 | // we don't really need to recurse into them, because any internal |
| 2701 | // expressions should have been analyzed already when they were |
| 2702 | // built into statements. |
| 2703 | if (isa<StmtExpr>(E)) return; |
| 2704 | |
| 2705 | // Don't descend into unevaluated contexts. |
| 2706 | if (isa<SizeOfAlignOfExpr>(E)) return; |
| 2707 | |
| 2708 | // Now just recurse over the expression's children. |
| 2709 | for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end(); |
| 2710 | I != IE; ++I) |
| 2711 | AnalyzeImplicitConversions(S, cast<Expr>(*I)); |
| 2712 | } |
| 2713 | |
| 2714 | } // end anonymous namespace |
| 2715 | |
| 2716 | /// Diagnoses "dangerous" implicit conversions within the given |
| 2717 | /// expression (which is a full expression). Implements -Wconversion |
| 2718 | /// and -Wsign-compare. |
| 2719 | void Sema::CheckImplicitConversions(Expr *E) { |
| 2720 | // Don't diagnose in unevaluated contexts. |
| 2721 | if (ExprEvalContexts.back().Context == Sema::Unevaluated) |
| 2722 | return; |
| 2723 | |
| 2724 | // Don't diagnose for value- or type-dependent expressions. |
| 2725 | if (E->isTypeDependent() || E->isValueDependent()) |
| 2726 | return; |
| 2727 | |
| 2728 | AnalyzeImplicitConversions(*this, E); |
| 2729 | } |
| 2730 | |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2731 | /// CheckParmsForFunctionDef - Check that the parameters of the given |
| 2732 | /// function are appropriate for the definition of a function. This |
| 2733 | /// takes care of any checks that cannot be performed on the |
| 2734 | /// declaration itself, e.g., that the types of each of the function |
| 2735 | /// parameters are complete. |
| 2736 | bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) { |
| 2737 | bool HasInvalidParm = false; |
| 2738 | for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) { |
| 2739 | ParmVarDecl *Param = FD->getParamDecl(p); |
| 2740 | |
| 2741 | // C99 6.7.5.3p4: the parameters in a parameter type list in a |
| 2742 | // function declarator that is part of a function definition of |
| 2743 | // that function shall not have incomplete type. |
| 2744 | // |
| 2745 | // This is also C++ [dcl.fct]p6. |
| 2746 | if (!Param->isInvalidDecl() && |
| 2747 | RequireCompleteType(Param->getLocation(), Param->getType(), |
| 2748 | diag::err_typecheck_decl_incomplete_type)) { |
| 2749 | Param->setInvalidDecl(); |
| 2750 | HasInvalidParm = true; |
| 2751 | } |
| 2752 | |
| 2753 | // C99 6.9.1p5: If the declarator includes a parameter type list, the |
| 2754 | // declaration of each parameter shall include an identifier. |
| 2755 | if (Param->getIdentifier() == 0 && |
| 2756 | !Param->isImplicit() && |
| 2757 | !getLangOptions().CPlusPlus) |
| 2758 | Diag(Param->getLocation(), diag::err_parameter_name_omitted); |
Sam Weinig | d17e340 | 2010-02-01 05:02:49 +0000 | [diff] [blame] | 2759 | |
| 2760 | // C99 6.7.5.3p12: |
| 2761 | // If the function declarator is not part of a definition of that |
| 2762 | // function, parameters may have incomplete type and may use the [*] |
| 2763 | // notation in their sequences of declarator specifiers to specify |
| 2764 | // variable length array types. |
| 2765 | QualType PType = Param->getOriginalType(); |
| 2766 | if (const ArrayType *AT = Context.getAsArrayType(PType)) { |
| 2767 | if (AT->getSizeModifier() == ArrayType::Star) { |
| 2768 | // FIXME: This diagnosic should point the the '[*]' if source-location |
| 2769 | // information is added for it. |
| 2770 | Diag(Param->getLocation(), diag::err_array_star_in_function_definition); |
| 2771 | } |
| 2772 | } |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2773 | } |
| 2774 | |
| 2775 | return HasInvalidParm; |
| 2776 | } |