blob: a86f586d1de537b383e3a4f8b9ff49da77b58f6d [file] [log] [blame]
Ted Kremenek54cb7cc2009-11-03 08:03:59 +00001//=- NSAutoreleasePoolChecker.cpp --------------------------------*- C++ -*-==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines a NSAutoreleasePoolChecker, a small checker that warns
11// about subpar uses of NSAutoreleasePool. Note that while the check itself
Jordy Rosed1e5a892011-09-02 08:02:59 +000012// (in its current form) could be written as a flow-insensitive check, in
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000013// can be potentially enhanced in the future with flow-sensitive information.
14// It is also a good example of the CheckerVisitor interface.
15//
16//===----------------------------------------------------------------------===//
17
Argyrios Kyrtzidis0b1ba622011-02-16 01:40:52 +000018#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000019#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000020#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000021#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
Anna Zaks48468df2011-10-26 21:06:39 +000022#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordy Rosed1e5a892011-09-02 08:02:59 +000023#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Jordy Rosed1e5a892011-09-02 08:02:59 +000025#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000026#include "clang/AST/DeclObjC.h"
27#include "clang/AST/Decl.h"
28
29using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000030using namespace ento;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000031
32namespace {
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +000033class NSAutoreleasePoolChecker
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000034 : public Checker<check::PreObjCMessage> {
Anna Zaks48468df2011-10-26 21:06:39 +000035 mutable llvm::OwningPtr<BugType> BT;
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000036 mutable Selector releaseS;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000037
38public:
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000039 void checkPreObjCMessage(ObjCMessage msg, CheckerContext &C) const;
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000040};
41
42} // end anonymous namespace
43
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000044void NSAutoreleasePoolChecker::checkPreObjCMessage(ObjCMessage msg,
45 CheckerContext &C) const {
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000046
Argyrios Kyrtzidis432424d2011-01-25 00:03:53 +000047 const Expr *receiver = msg.getInstanceReceiver();
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000048 if (!receiver)
49 return;
50
51 // FIXME: Enhance with value-tracking information instead of consulting
52 // the type of the expression.
53 const ObjCObjectPointerType* PT =
54 receiver->getType()->getAs<ObjCObjectPointerType>();
Ted Kremenek71a5e282009-11-20 00:12:36 +000055
56 if (!PT)
57 return;
Ted Kremenek9c378f72011-08-12 23:37:29 +000058 const ObjCInterfaceDecl *OD = PT->getInterfaceDecl();
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000059 if (!OD)
60 return;
61 if (!OD->getIdentifier()->getName().equals("NSAutoreleasePool"))
62 return;
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000063
64 if (releaseS.isNull())
65 releaseS = GetNullarySelector("release", C.getASTContext());
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000066 // Sending 'release' message?
Argyrios Kyrtzidis432424d2011-01-25 00:03:53 +000067 if (msg.getSelector() != releaseS)
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000068 return;
Anna Zaks48468df2011-10-26 21:06:39 +000069
70 if (!BT)
71 BT.reset(new BugType("Use -drain instead of -release",
72 "API Upgrade (Apple)"));
73
74 ExplodedNode *N = C.addTransition();
75 if (!N) {
76 assert(0);
77 return;
78 }
79
80 BugReport *Report = new BugReport(*BT, "Use -drain instead of -release when "
81 "using NSAutoreleasePool and garbage collection", N);
82 Report->addRange(msg.getSourceRange());
83 C.EmitReport(Report);
Ted Kremenek54cb7cc2009-11-03 08:03:59 +000084}
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000085
86void ento::registerNSAutoreleasePoolChecker(CheckerManager &mgr) {
Douglas Gregore289d812011-09-13 17:21:33 +000087 if (mgr.getLangOptions().getGC() != LangOptions::NonGC)
Argyrios Kyrtzidis45d9b4e2011-02-23 07:19:18 +000088 mgr.registerChecker<NSAutoreleasePoolChecker>();
89}