blob: 81a27451cbaab9b4df1c49cb8ad0325e8b238186 [file] [log] [blame]
Ted Kremenekbc3a0212009-10-30 17:24:47 +00001//== NullDerefChecker.cpp - Null dereference checker ------------*- C++ -*--==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
Argyrios Kyrtzidisd2592a32010-12-22 18:53:44 +000010// This defines NullDerefChecker, a builtin check in ExprEngine that performs
Ted Kremenekbc3a0212009-10-30 17:24:47 +000011// checks for null pointers at loads and stores.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000015#include "ClangSACheckers.h"
Benjamin Kramerc35fb7d2012-01-28 12:06:22 +000016#include "clang/AST/ExprObjC.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000021#include "llvm/ADT/SmallString.h"
Ted Kremenekbc3a0212009-10-30 17:24:47 +000022
23using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000024using namespace ento;
Ted Kremenekbc3a0212009-10-30 17:24:47 +000025
Ted Kremenekb4b817d2009-11-11 03:26:34 +000026namespace {
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000027class DereferenceChecker
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000028 : public Checker< check::Location,
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000029 EventDispatcher<ImplicitNullDerefEvent> > {
Dylan Noblesmith6f42b622012-02-05 02:12:40 +000030 mutable OwningPtr<BuiltinBug> BT_null;
31 mutable OwningPtr<BuiltinBug> BT_undef;
Ted Kremenek452b84d2010-03-23 01:11:38 +000032
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000033public:
Anna Zaks390909c2011-10-06 00:43:15 +000034 void checkLocation(SVal location, bool isLoad, const Stmt* S,
35 CheckerContext &C) const;
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000036
Ted Kremenek76aadc32012-03-09 01:13:14 +000037 static const MemRegion *AddDerefSource(raw_ostream &os,
Chris Lattner5f9e2722011-07-23 10:55:15 +000038 SmallVectorImpl<SourceRange> &Ranges,
Ted Kremenek76aadc32012-03-09 01:13:14 +000039 const Expr *Ex, const ProgramState *state,
40 const LocationContext *LCtx,
41 bool loadedFrom = false);
Ted Kremenekb4b817d2009-11-11 03:26:34 +000042};
43} // end anonymous namespace
44
Ted Kremenek76aadc32012-03-09 01:13:14 +000045const MemRegion *
46DereferenceChecker::AddDerefSource(raw_ostream &os,
47 SmallVectorImpl<SourceRange> &Ranges,
48 const Expr *Ex,
49 const ProgramState *state,
50 const LocationContext *LCtx,
51 bool loadedFrom) {
John McCallf6a16482010-12-04 03:47:34 +000052 Ex = Ex->IgnoreParenLValueCasts();
Ted Kremenek76aadc32012-03-09 01:13:14 +000053 const MemRegion *sourceR = 0;
Ted Kremenek646c3c32010-10-26 00:06:13 +000054 switch (Ex->getStmtClass()) {
55 default:
Ted Kremenek76aadc32012-03-09 01:13:14 +000056 break;
Ted Kremenek646c3c32010-10-26 00:06:13 +000057 case Stmt::DeclRefExprClass: {
58 const DeclRefExpr *DR = cast<DeclRefExpr>(Ex);
59 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
60 os << " (" << (loadedFrom ? "loaded from" : "from")
61 << " variable '" << VD->getName() << "')";
62 Ranges.push_back(DR->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +000063 sourceR = state->getLValue(VD, LCtx).getAsRegion();
Ted Kremenek646c3c32010-10-26 00:06:13 +000064 }
Ted Kremenek76aadc32012-03-09 01:13:14 +000065 break;
Ted Kremenek646c3c32010-10-26 00:06:13 +000066 }
67 case Stmt::MemberExprClass: {
68 const MemberExpr *ME = cast<MemberExpr>(Ex);
69 os << " (" << (loadedFrom ? "loaded from" : "via")
70 << " field '" << ME->getMemberNameInfo() << "')";
71 SourceLocation L = ME->getMemberLoc();
72 Ranges.push_back(SourceRange(L, L));
73 break;
74 }
75 }
Ted Kremenek76aadc32012-03-09 01:13:14 +000076 return sourceR;
Ted Kremenek646c3c32010-10-26 00:06:13 +000077}
78
Anna Zaks390909c2011-10-06 00:43:15 +000079void DereferenceChecker::checkLocation(SVal l, bool isLoad, const Stmt* S,
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000080 CheckerContext &C) const {
Ted Kremenekb4b817d2009-11-11 03:26:34 +000081 // Check for dereference of an undefined value.
82 if (l.isUndef()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +000083 if (ExplodedNode *N = C.generateSink()) {
Ted Kremenekb4b817d2009-11-11 03:26:34 +000084 if (!BT_undef)
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +000085 BT_undef.reset(new BuiltinBug("Dereference of undefined pointer value"));
Ted Kremenek452b84d2010-03-23 01:11:38 +000086
Anna Zakse172e8b2011-08-17 23:00:25 +000087 BugReport *report =
88 new BugReport(*BT_undef, BT_undef->getDescription(), N);
Anna Zaks50bbc162011-08-19 22:33:38 +000089 report->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N,
Ted Kremenek76aadc32012-03-09 01:13:14 +000090 bugreporter::GetDerefExpr(N), report));
Ted Kremenekb4b817d2009-11-11 03:26:34 +000091 C.EmitReport(report);
92 }
93 return;
94 }
Ted Kremenek452b84d2010-03-23 01:11:38 +000095
Ted Kremenekb4b817d2009-11-11 03:26:34 +000096 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(l);
Ted Kremenek452b84d2010-03-23 01:11:38 +000097
98 // Check for null dereferences.
Ted Kremenekb4b817d2009-11-11 03:26:34 +000099 if (!isa<Loc>(location))
100 return;
Ted Kremenek452b84d2010-03-23 01:11:38 +0000101
Ted Kremenek8bef8232012-01-26 21:29:00 +0000102 ProgramStateRef state = C.getState();
Ted Kremenek76aadc32012-03-09 01:13:14 +0000103 const LocationContext *LCtx = C.getLocationContext();
Ted Kremenek8bef8232012-01-26 21:29:00 +0000104 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000105 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenek452b84d2010-03-23 01:11:38 +0000106
Ted Kremenekb4b817d2009-11-11 03:26:34 +0000107 // The explicit NULL case.
108 if (nullState) {
Ted Kremenek452b84d2010-03-23 01:11:38 +0000109 if (!notNullState) {
Ted Kremenek78d722f2009-11-21 01:50:48 +0000110 // Generate an error node.
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000111 ExplodedNode *N = C.generateSink(nullState);
Ted Kremenek78d722f2009-11-21 01:50:48 +0000112 if (!N)
Ted Kremenekb4b817d2009-11-11 03:26:34 +0000113 return;
Ted Kremenek452b84d2010-03-23 01:11:38 +0000114
Ted Kremenek78d722f2009-11-21 01:50:48 +0000115 // We know that 'location' cannot be non-null. This is what
Ted Kremenek452b84d2010-03-23 01:11:38 +0000116 // we call an "explicit" null dereference.
Ted Kremenek78d722f2009-11-21 01:50:48 +0000117 if (!BT_null)
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +0000118 BT_null.reset(new BuiltinBug("Dereference of null pointer"));
Ted Kremenek452b84d2010-03-23 01:11:38 +0000119
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000120 SmallString<100> buf;
Chris Lattner5f9e2722011-07-23 10:55:15 +0000121 SmallVector<SourceRange, 2> Ranges;
Ted Kremenek892697d2010-12-16 07:46:53 +0000122
123 // Walk through lvalue casts to get the original expression
124 // that syntactically caused the load.
125 if (const Expr *expr = dyn_cast<Expr>(S))
126 S = expr->IgnoreParenLValueCasts();
Ted Kremenek76aadc32012-03-09 01:13:14 +0000127
128 const MemRegion *sourceR = 0;
Ted Kremeneke576af22009-11-24 01:33:10 +0000129
130 switch (S->getStmtClass()) {
Ted Kremenek646c3c32010-10-26 00:06:13 +0000131 case Stmt::ArraySubscriptExprClass: {
132 llvm::raw_svector_ostream os(buf);
133 os << "Array access";
134 const ArraySubscriptExpr *AE = cast<ArraySubscriptExpr>(S);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000135 sourceR =
136 AddDerefSource(os, Ranges, AE->getBase()->IgnoreParenCasts(),
137 state.getPtr(), LCtx);
Ted Kremenek646c3c32010-10-26 00:06:13 +0000138 os << " results in a null pointer dereference";
139 break;
140 }
Ted Kremeneke576af22009-11-24 01:33:10 +0000141 case Stmt::UnaryOperatorClass: {
Ted Kremenek646c3c32010-10-26 00:06:13 +0000142 llvm::raw_svector_ostream os(buf);
143 os << "Dereference of null pointer";
Ted Kremeneke576af22009-11-24 01:33:10 +0000144 const UnaryOperator *U = cast<UnaryOperator>(S);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000145 sourceR =
146 AddDerefSource(os, Ranges, U->getSubExpr()->IgnoreParens(),
147 state.getPtr(), LCtx, true);
Ted Kremenek452b84d2010-03-23 01:11:38 +0000148 break;
149 }
150 case Stmt::MemberExprClass: {
151 const MemberExpr *M = cast<MemberExpr>(S);
Ted Kremenek646c3c32010-10-26 00:06:13 +0000152 if (M->isArrow()) {
153 llvm::raw_svector_ostream os(buf);
154 os << "Access to field '" << M->getMemberNameInfo()
155 << "' results in a dereference of a null pointer";
Ted Kremenek76aadc32012-03-09 01:13:14 +0000156 sourceR =
157 AddDerefSource(os, Ranges, M->getBase()->IgnoreParenCasts(),
158 state.getPtr(), LCtx, true);
Ted Kremenek646c3c32010-10-26 00:06:13 +0000159 }
Ted Kremenek452b84d2010-03-23 01:11:38 +0000160 break;
Ted Kremeneke576af22009-11-24 01:33:10 +0000161 }
Ted Kremenek0853c7f2010-09-10 20:20:49 +0000162 case Stmt::ObjCIvarRefExprClass: {
163 const ObjCIvarRefExpr *IV = cast<ObjCIvarRefExpr>(S);
164 if (const DeclRefExpr *DR =
165 dyn_cast<DeclRefExpr>(IV->getBase()->IgnoreParenCasts())) {
166 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
167 llvm::raw_svector_ostream os(buf);
168 os << "Instance variable access (via '" << VD->getName()
169 << "') results in a null pointer dereference";
170 }
171 }
172 Ranges.push_back(IV->getSourceRange());
173 break;
174 }
Ted Kremeneke576af22009-11-24 01:33:10 +0000175 default:
176 break;
177 }
Ted Kremenek2c791bd2009-11-06 00:44:32 +0000178
Anna Zakse172e8b2011-08-17 23:00:25 +0000179 BugReport *report =
180 new BugReport(*BT_null,
Ted Kremeneke576af22009-11-24 01:33:10 +0000181 buf.empty() ? BT_null->getDescription():buf.str(),
182 N);
183
Anna Zaks50bbc162011-08-19 22:33:38 +0000184 report->addVisitor(bugreporter::getTrackNullOrUndefValueVisitor(N,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000185 bugreporter::GetDerefExpr(N), report));
Ted Kremenek452b84d2010-03-23 01:11:38 +0000186
Chris Lattner5f9e2722011-07-23 10:55:15 +0000187 for (SmallVectorImpl<SourceRange>::iterator
Ted Kremenek452b84d2010-03-23 01:11:38 +0000188 I = Ranges.begin(), E = Ranges.end(); I!=E; ++I)
189 report->addRange(*I);
190
Ted Kremenek76aadc32012-03-09 01:13:14 +0000191 if (sourceR) {
192 report->markInteresting(sourceR);
193 report->markInteresting(state->getRawSVal(loc::MemRegionVal(sourceR)));
194 }
195
Ted Kremenek78d722f2009-11-21 01:50:48 +0000196 C.EmitReport(report);
197 return;
198 }
199 else {
Ted Kremenekb4b817d2009-11-11 03:26:34 +0000200 // Otherwise, we have the case where the location could either be
201 // null or not-null. Record the error node as an "implicit" null
Ted Kremenek452b84d2010-03-23 01:11:38 +0000202 // dereference.
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +0000203 if (ExplodedNode *N = C.generateSink(nullState)) {
204 ImplicitNullDerefEvent event = { l, isLoad, N, &C.getBugReporter() };
205 dispatchEvent(event);
206 }
Ted Kremenekbc3a0212009-10-30 17:24:47 +0000207 }
208 }
Ted Kremenek452b84d2010-03-23 01:11:38 +0000209
Ted Kremenekb4b817d2009-11-11 03:26:34 +0000210 // From this point forward, we know that the location is not null.
Anna Zaks0bd6b112011-10-26 21:06:34 +0000211 C.addTransition(notNullState);
Ted Kremenekbc3a0212009-10-30 17:24:47 +0000212}
Argyrios Kyrtzidisb3d74da2011-02-28 17:36:18 +0000213
214void ento::registerDereferenceChecker(CheckerManager &mgr) {
215 mgr.registerChecker<DereferenceChecker>();
216}