Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 19 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 25 | #include "clang/Basic/SourceManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 28 | #include "llvm/ADT/STLExtras.h" |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 29 | #include <climits> |
| 30 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 31 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 32 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 33 | |
| 34 | namespace { |
| 35 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 36 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 37 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 38 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | const Stmt *S; |
| 40 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 41 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 43 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 44 | bool isAllocated() const { return K == AllocateUnchecked; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 45 | bool isReleased() const { return K == Released; } |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 46 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 47 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 48 | |
| 49 | bool operator==(const RefState &X) const { |
| 50 | return K == X.K && S == X.S; |
| 51 | } |
| 52 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 53 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 54 | return RefState(AllocateUnchecked, s); |
| 55 | } |
| 56 | static RefState getAllocateFailed() { |
| 57 | return RefState(AllocateFailed, 0); |
| 58 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 59 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 60 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 61 | static RefState getRelinquished(const Stmt *s) { |
| 62 | return RefState(Relinquished, s); |
| 63 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 64 | |
| 65 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 66 | ID.AddInteger(K); |
| 67 | ID.AddPointer(S); |
| 68 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 69 | }; |
| 70 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 71 | struct ReallocPair { |
| 72 | SymbolRef ReallocatedSym; |
| 73 | bool IsFreeOnFailure; |
| 74 | ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {} |
| 75 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 76 | ID.AddInteger(IsFreeOnFailure); |
| 77 | ID.AddPointer(ReallocatedSym); |
| 78 | } |
| 79 | bool operator==(const ReallocPair &X) const { |
| 80 | return ReallocatedSym == X.ReallocatedSym && |
| 81 | IsFreeOnFailure == X.IsFreeOnFailure; |
| 82 | } |
| 83 | }; |
| 84 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 85 | typedef std::pair<const Stmt*, const MemRegion*> LeakInfo; |
| 86 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 87 | class MallocChecker : public Checker<check::DeadSymbols, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 88 | check::EndPath, |
| 89 | check::PreStmt<ReturnStmt>, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 90 | check::PreStmt<CallExpr>, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 91 | check::PostStmt<CallExpr>, |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 92 | check::PostStmt<BlockExpr>, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 93 | check::Location, |
| 94 | check::Bind, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 95 | eval::Assume, |
| 96 | check::RegionChanges> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 97 | { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 98 | mutable OwningPtr<BugType> BT_DoubleFree; |
| 99 | mutable OwningPtr<BugType> BT_Leak; |
| 100 | mutable OwningPtr<BugType> BT_UseFree; |
| 101 | mutable OwningPtr<BugType> BT_BadFree; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 102 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 103 | *II_valloc, *II_reallocf, *II_strndup, *II_strdup; |
| 104 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 105 | public: |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 106 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 107 | II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 108 | |
| 109 | /// In pessimistic mode, the checker assumes that it does not know which |
| 110 | /// functions might free the memory. |
| 111 | struct ChecksFilter { |
| 112 | DefaultBool CMallocPessimistic; |
| 113 | DefaultBool CMallocOptimistic; |
| 114 | }; |
| 115 | |
| 116 | ChecksFilter Filter; |
| 117 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 118 | void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 119 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 120 | void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 121 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 122 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 123 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 124 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 125 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 126 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 127 | CheckerContext &C) const; |
| 128 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 129 | CheckerContext &C) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 130 | ProgramStateRef |
| 131 | checkRegionChanges(ProgramStateRef state, |
| 132 | const StoreManager::InvalidatedSymbols *invalidated, |
| 133 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 134 | ArrayRef<const MemRegion *> Regions, |
| 135 | const CallOrObjCMessage *Call) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 136 | bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| 137 | return true; |
| 138 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 139 | |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 140 | void printState(raw_ostream &Out, ProgramStateRef State, |
| 141 | const char *NL, const char *Sep) const; |
| 142 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 143 | private: |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 144 | void initIdentifierInfo(ASTContext &C) const; |
| 145 | |
| 146 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 147 | /// pointed to by one of its arguments. |
| 148 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| 149 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 150 | static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 151 | const CallExpr *CE, |
| 152 | const OwnershipAttr* Att); |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 153 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 154 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 155 | ProgramStateRef state) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 156 | return MallocMemAux(C, CE, |
| 157 | state->getSVal(SizeEx, C.getLocationContext()), |
| 158 | Init, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 159 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 160 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 161 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 162 | SVal SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 163 | ProgramStateRef state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 164 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 165 | /// Update the RefState to reflect the new memory allocation. |
| 166 | static ProgramStateRef MallocUpdateRefState(CheckerContext &C, |
| 167 | const CallExpr *CE, |
| 168 | ProgramStateRef state); |
| 169 | |
| 170 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| 171 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 172 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 173 | ProgramStateRef state, unsigned Num, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 174 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 175 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 176 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
| 177 | bool FreesMemOnFailure) const; |
| 178 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 179 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 180 | bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| 181 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 182 | const Stmt *S = 0) const; |
| 183 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 184 | /// Check if the function is not known to us. So, for example, we could |
| 185 | /// conservatively assume it can free/reallocate it's pointer arguments. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 186 | bool doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 187 | ProgramStateRef State) const; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 188 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 189 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 190 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 191 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 192 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 193 | /// Find the location of the allocation for Sym on the path leading to the |
| 194 | /// exploded node N. |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 195 | LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 196 | CheckerContext &C) const; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 197 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 198 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 199 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 200 | /// The bug visitor which allows us to print extra diagnostics along the |
| 201 | /// BugReport path. For example, showing the allocation site of the leaked |
| 202 | /// region. |
Jordy Rose | 0115349 | 2012-03-24 02:45:35 +0000 | [diff] [blame] | 203 | class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 204 | protected: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 205 | enum NotificationMode { |
| 206 | Normal, |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 207 | ReallocationFailed |
| 208 | }; |
| 209 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 210 | // The allocated region symbol tracked by the main analysis. |
| 211 | SymbolRef Sym; |
| 212 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame^] | 213 | // The mode we are in, i.e. what kind of diagnostics will be emitted. |
| 214 | NotificationMode Mode; |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 215 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame^] | 216 | // A symbol from when the primary region should have been reallocated. |
| 217 | SymbolRef FailedReallocSymbol; |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 218 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame^] | 219 | bool IsLeak; |
| 220 | |
| 221 | public: |
| 222 | MallocBugVisitor(SymbolRef S, bool isLeak = false) |
| 223 | : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {} |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 224 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 225 | virtual ~MallocBugVisitor() {} |
| 226 | |
| 227 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 228 | static int X = 0; |
| 229 | ID.AddPointer(&X); |
| 230 | ID.AddPointer(Sym); |
| 231 | } |
| 232 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 233 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 234 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 235 | // Did not track -> allocated. Other state (released) -> allocated. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 236 | return (Stmt && isa<CallExpr>(Stmt) && |
| 237 | (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 238 | } |
| 239 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 240 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 241 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 242 | // Did not track -> released. Other state (allocated) -> released. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 243 | return (Stmt && isa<CallExpr>(Stmt) && |
| 244 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 245 | } |
| 246 | |
| 247 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 248 | const Stmt *Stmt) { |
| 249 | // If the expression is not a call, and the state change is |
| 250 | // released -> allocated, it must be the realloc return value |
| 251 | // check. If we have to handle more cases here, it might be cleaner just |
| 252 | // to track this extra bit in the state itself. |
| 253 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| 254 | (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 255 | } |
| 256 | |
| 257 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 258 | const ExplodedNode *PrevN, |
| 259 | BugReporterContext &BRC, |
| 260 | BugReport &BR); |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame^] | 261 | |
| 262 | PathDiagnosticPiece* getEndPath(BugReporterContext &BRC, |
| 263 | const ExplodedNode *EndPathNode, |
| 264 | BugReport &BR) { |
| 265 | if (!IsLeak) |
| 266 | return 0; |
| 267 | |
| 268 | PathDiagnosticLocation L = |
| 269 | PathDiagnosticLocation::createEndOfPath(EndPathNode, |
| 270 | BRC.getSourceManager()); |
| 271 | // Do not add the statement itself as a range in case of leak. |
| 272 | return new PathDiagnosticEventPiece(L, BR.getDescription(), false); |
| 273 | } |
| 274 | |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 275 | private: |
| 276 | class StackHintGeneratorForReallocationFailed |
| 277 | : public StackHintGeneratorForSymbol { |
| 278 | public: |
| 279 | StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M) |
| 280 | : StackHintGeneratorForSymbol(S, M) {} |
| 281 | |
| 282 | virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) { |
| 283 | SmallString<200> buf; |
| 284 | llvm::raw_svector_ostream os(buf); |
| 285 | |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 286 | os << "Reallocation of "; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 287 | // Printed parameters start at 1, not 0. |
| 288 | printOrdinal(++ArgIndex, os); |
| 289 | os << " parameter failed"; |
| 290 | |
| 291 | return os.str(); |
| 292 | } |
| 293 | |
| 294 | virtual std::string getMessageForReturn(const CallExpr *CallExpr) { |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 295 | return "Reallocation of returned value failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 296 | } |
| 297 | }; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 298 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 299 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 300 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 301 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 302 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 303 | typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 304 | class RegionState {}; |
| 305 | class ReallocPairs {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 306 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 307 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 308 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 309 | struct ProgramStateTrait<RegionState> |
| 310 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 311 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 312 | }; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 313 | |
| 314 | template <> |
| 315 | struct ProgramStateTrait<ReallocPairs> |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 316 | : public ProgramStatePartialTrait<ReallocMap> { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 317 | static void *GDMIndex() { static int x; return &x; } |
| 318 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 319 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 320 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 321 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 322 | namespace { |
| 323 | class StopTrackingCallback : public SymbolVisitor { |
| 324 | ProgramStateRef state; |
| 325 | public: |
| 326 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 327 | ProgramStateRef getState() const { return state; } |
| 328 | |
| 329 | bool VisitSymbol(SymbolRef sym) { |
| 330 | state = state->remove<RegionState>(sym); |
| 331 | return true; |
| 332 | } |
| 333 | }; |
| 334 | } // end anonymous namespace |
| 335 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 336 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 337 | if (!II_malloc) |
| 338 | II_malloc = &Ctx.Idents.get("malloc"); |
| 339 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 340 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 341 | if (!II_realloc) |
| 342 | II_realloc = &Ctx.Idents.get("realloc"); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 343 | if (!II_reallocf) |
| 344 | II_reallocf = &Ctx.Idents.get("reallocf"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 345 | if (!II_calloc) |
| 346 | II_calloc = &Ctx.Idents.get("calloc"); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 347 | if (!II_valloc) |
| 348 | II_valloc = &Ctx.Idents.get("valloc"); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 349 | if (!II_strdup) |
| 350 | II_strdup = &Ctx.Idents.get("strdup"); |
| 351 | if (!II_strndup) |
| 352 | II_strndup = &Ctx.Idents.get("strndup"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 353 | } |
| 354 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 355 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 356 | if (!FD) |
| 357 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 358 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 359 | if (!FunI) |
| 360 | return false; |
| 361 | |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 362 | initIdentifierInfo(C); |
| 363 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 364 | if (FunI == II_malloc || FunI == II_free || FunI == II_realloc || |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 365 | FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc || |
| 366 | FunI == II_strdup || FunI == II_strndup) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 367 | return true; |
| 368 | |
| 369 | if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| 370 | FD->specific_attr_begin<OwnershipAttr>() != |
| 371 | FD->specific_attr_end<OwnershipAttr>()) |
| 372 | return true; |
| 373 | |
| 374 | |
| 375 | return false; |
| 376 | } |
| 377 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 378 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| 379 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 380 | if (!FD) |
| 381 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 382 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 383 | initIdentifierInfo(C.getASTContext()); |
| 384 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 385 | if (!FunI) |
| 386 | return; |
| 387 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 388 | ProgramStateRef State = C.getState(); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 389 | if (FunI == II_malloc || FunI == II_valloc) { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 390 | if (CE->getNumArgs() < 1) |
| 391 | return; |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 392 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 393 | } else if (FunI == II_realloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 394 | State = ReallocMem(C, CE, false); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 395 | } else if (FunI == II_reallocf) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 396 | State = ReallocMem(C, CE, true); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 397 | } else if (FunI == II_calloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 398 | State = CallocMem(C, CE); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 399 | } else if (FunI == II_free) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 400 | State = FreeMemAux(C, CE, C.getState(), 0, false); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 401 | } else if (FunI == II_strdup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 402 | State = MallocUpdateRefState(C, CE, State); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 403 | } else if (FunI == II_strndup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 404 | State = MallocUpdateRefState(C, CE, State); |
| 405 | } else if (Filter.CMallocOptimistic) { |
| 406 | // Check all the attributes, if there are any. |
| 407 | // There can be multiple of these attributes. |
| 408 | if (FD->hasAttrs()) |
| 409 | for (specific_attr_iterator<OwnershipAttr> |
| 410 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 411 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 412 | i != e; ++i) { |
| 413 | switch ((*i)->getOwnKind()) { |
| 414 | case OwnershipAttr::Returns: |
| 415 | State = MallocMemReturnsAttr(C, CE, *i); |
| 416 | break; |
| 417 | case OwnershipAttr::Takes: |
| 418 | case OwnershipAttr::Holds: |
| 419 | State = FreeMemAttr(C, CE, *i); |
| 420 | break; |
| 421 | } |
| 422 | } |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 423 | } |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 424 | C.addTransition(State); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 425 | } |
| 426 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 427 | ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C, |
| 428 | const CallExpr *CE, |
| 429 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 430 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 431 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 432 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 433 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 434 | if (I != E) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 435 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 436 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 437 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 438 | } |
| 439 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 440 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 441 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 442 | SVal Size, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 443 | ProgramStateRef state) { |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 444 | // Get the return value. |
| 445 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 446 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 447 | // We expect the malloc functions to return a pointer. |
| 448 | if (!isa<Loc>(retVal)) |
| 449 | return 0; |
| 450 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 451 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 452 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 453 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 454 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 455 | const SymbolicRegion *R = |
| 456 | dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 457 | if (!R) |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 458 | return 0; |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 459 | if (isa<DefinedOrUnknownSVal>(Size)) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 460 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 461 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
| 462 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
| 463 | DefinedOrUnknownSVal extentMatchesSize = |
| 464 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 465 | |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 466 | state = state->assume(extentMatchesSize, true); |
| 467 | assert(state); |
| 468 | } |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 469 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 470 | return MallocUpdateRefState(C, CE, state); |
| 471 | } |
| 472 | |
| 473 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
| 474 | const CallExpr *CE, |
| 475 | ProgramStateRef state) { |
| 476 | // Get the return value. |
| 477 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
| 478 | |
| 479 | // We expect the malloc functions to return a pointer. |
| 480 | if (!isa<Loc>(retVal)) |
| 481 | return 0; |
| 482 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 483 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 484 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 485 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 486 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 487 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 488 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 489 | } |
| 490 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 491 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 492 | const CallExpr *CE, |
| 493 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 494 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 495 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 496 | |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 497 | ProgramStateRef State = C.getState(); |
| 498 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 499 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 500 | I != E; ++I) { |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 501 | ProgramStateRef StateI = FreeMemAux(C, CE, State, *I, |
| 502 | Att->getOwnKind() == OwnershipAttr::Holds); |
| 503 | if (StateI) |
| 504 | State = StateI; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 505 | } |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 506 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 507 | } |
| 508 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 509 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 510 | const CallExpr *CE, |
| 511 | ProgramStateRef state, |
| 512 | unsigned Num, |
| 513 | bool Hold) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 514 | if (CE->getNumArgs() < (Num + 1)) |
| 515 | return 0; |
| 516 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 517 | const Expr *ArgExpr = CE->getArg(Num); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 518 | SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 519 | if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| 520 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 521 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 522 | |
| 523 | // Check for null dereferences. |
| 524 | if (!isa<Loc>(location)) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 525 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 526 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 527 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 528 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 529 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 530 | if (nullState && !notNullState) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 531 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 532 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 533 | // Unknown values could easily be okay |
| 534 | // Undefined values are handled elsewhere |
| 535 | if (ArgVal.isUnknownOrUndef()) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 536 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 537 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 538 | const MemRegion *R = ArgVal.getAsRegion(); |
| 539 | |
| 540 | // Nonlocs can't be freed, of course. |
| 541 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 542 | if (!R) { |
| 543 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 544 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 545 | } |
| 546 | |
| 547 | R = R->StripCasts(); |
| 548 | |
| 549 | // Blocks might show up as heap data, but should not be free()d |
| 550 | if (isa<BlockDataRegion>(R)) { |
| 551 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 552 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 553 | } |
| 554 | |
| 555 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 556 | |
| 557 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 558 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 559 | // FIXME: at the time this code was written, malloc() regions were |
| 560 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 561 | // This means that there isn't actually anything from HeapSpaceRegion |
| 562 | // that should be freed, even though we allow it here. |
| 563 | // Of course, free() can work on memory allocated outside the current |
| 564 | // function, so UnknownSpaceRegion is always a possibility. |
| 565 | // False negatives are better than false positives. |
| 566 | |
| 567 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 568 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 569 | } |
| 570 | |
| 571 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 572 | // Various cases could lead to non-symbol values here. |
| 573 | // For now, ignore them. |
| 574 | if (!SR) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 575 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 576 | |
| 577 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 578 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 579 | |
| 580 | // If the symbol has not been tracked, return. This is possible when free() is |
| 581 | // called on a pointer that does not get its pointee directly from malloc(). |
| 582 | // Full support of this requires inter-procedural analysis. |
| 583 | if (!RS) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 584 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 585 | |
| 586 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 587 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 588 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 589 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 590 | BT_DoubleFree.reset( |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 591 | new BugType("Double free", "Memory Error")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 592 | BugReport *R = new BugReport(*BT_DoubleFree, |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 593 | "Attempt to free released memory", N); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 594 | R->addRange(ArgExpr->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 595 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 596 | R->addVisitor(new MallocBugVisitor(Sym)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 597 | C.EmitReport(R); |
| 598 | } |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 599 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 600 | } |
| 601 | |
| 602 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 603 | if (Hold) |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 604 | return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 605 | return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 606 | } |
| 607 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 608 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 609 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 610 | os << "an integer (" << IntVal->getValue() << ")"; |
| 611 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 612 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 613 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 614 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 615 | else |
| 616 | return false; |
| 617 | |
| 618 | return true; |
| 619 | } |
| 620 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 621 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 622 | const MemRegion *MR) { |
| 623 | switch (MR->getKind()) { |
| 624 | case MemRegion::FunctionTextRegionKind: { |
| 625 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 626 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 627 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 628 | else |
| 629 | os << "the address of a function"; |
| 630 | return true; |
| 631 | } |
| 632 | case MemRegion::BlockTextRegionKind: |
| 633 | os << "block text"; |
| 634 | return true; |
| 635 | case MemRegion::BlockDataRegionKind: |
| 636 | // FIXME: where the block came from? |
| 637 | os << "a block"; |
| 638 | return true; |
| 639 | default: { |
| 640 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 641 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 642 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 643 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 644 | const VarDecl *VD; |
| 645 | if (VR) |
| 646 | VD = VR->getDecl(); |
| 647 | else |
| 648 | VD = NULL; |
| 649 | |
| 650 | if (VD) |
| 651 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 652 | else |
| 653 | os << "the address of a local stack variable"; |
| 654 | return true; |
| 655 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 656 | |
| 657 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 658 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 659 | const VarDecl *VD; |
| 660 | if (VR) |
| 661 | VD = VR->getDecl(); |
| 662 | else |
| 663 | VD = NULL; |
| 664 | |
| 665 | if (VD) |
| 666 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 667 | else |
| 668 | os << "the address of a parameter"; |
| 669 | return true; |
| 670 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 671 | |
| 672 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 673 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 674 | const VarDecl *VD; |
| 675 | if (VR) |
| 676 | VD = VR->getDecl(); |
| 677 | else |
| 678 | VD = NULL; |
| 679 | |
| 680 | if (VD) { |
| 681 | if (VD->isStaticLocal()) |
| 682 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 683 | else |
| 684 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 685 | } else |
| 686 | os << "the address of a global variable"; |
| 687 | return true; |
| 688 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 689 | |
| 690 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 691 | } |
| 692 | } |
| 693 | } |
| 694 | |
| 695 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 696 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 697 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 698 | if (!BT_BadFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 699 | BT_BadFree.reset(new BugType("Bad free", "Memory Error")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 700 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 701 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 702 | llvm::raw_svector_ostream os(buf); |
| 703 | |
| 704 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 705 | if (MR) { |
| 706 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 707 | MR = ER->getSuperRegion(); |
| 708 | |
| 709 | // Special case for alloca() |
| 710 | if (isa<AllocaRegion>(MR)) |
| 711 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 712 | else { |
| 713 | os << "Argument to free() is "; |
| 714 | if (SummarizeRegion(os, MR)) |
| 715 | os << ", which is not memory allocated by malloc()"; |
| 716 | else |
| 717 | os << "not memory allocated by malloc()"; |
| 718 | } |
| 719 | } else { |
| 720 | os << "Argument to free() is "; |
| 721 | if (SummarizeValue(os, ArgVal)) |
| 722 | os << ", which is not memory allocated by malloc()"; |
| 723 | else |
| 724 | os << "not memory allocated by malloc()"; |
| 725 | } |
| 726 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 727 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 728 | R->markInteresting(MR); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 729 | R->addRange(range); |
| 730 | C.EmitReport(R); |
| 731 | } |
| 732 | } |
| 733 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 734 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 735 | const CallExpr *CE, |
| 736 | bool FreesOnFail) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 737 | if (CE->getNumArgs() < 2) |
| 738 | return 0; |
| 739 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 740 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 741 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 742 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 743 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| 744 | if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 745 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 746 | DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 747 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 748 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 749 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 750 | DefinedOrUnknownSVal PtrEQ = |
| 751 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 752 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 753 | // Get the size argument. If there is no size arg then give up. |
| 754 | const Expr *Arg1 = CE->getArg(1); |
| 755 | if (!Arg1) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 756 | return 0; |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 757 | |
| 758 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 759 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| 760 | if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 761 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 762 | DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 763 | |
| 764 | // Compare the size argument to 0. |
| 765 | DefinedOrUnknownSVal SizeZero = |
| 766 | svalBuilder.evalEQ(state, Arg1Val, |
| 767 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 768 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 769 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| 770 | llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| 771 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| 772 | llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| 773 | // We only assume exceptional states if they are definitely true; if the |
| 774 | // state is under-constrained, assume regular realloc behavior. |
| 775 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 776 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 777 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 778 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 779 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 780 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 781 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 782 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 783 | return stateMalloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 784 | } |
| 785 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 786 | if (PrtIsNull && SizeIsZero) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 787 | return 0; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 788 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 789 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 790 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 791 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 792 | SVal RetVal = state->getSVal(CE, LCtx); |
| 793 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 794 | if (!FromPtr || !ToPtr) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 795 | return 0; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 796 | |
| 797 | // If the size is 0, free the memory. |
| 798 | if (SizeIsZero) |
| 799 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 800 | // The semantics of the return value are: |
| 801 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
| 802 | // to free() is returned. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 803 | stateFree = stateFree->set<ReallocPairs>(ToPtr, |
| 804 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 805 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 806 | return stateFree; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 807 | } |
| 808 | |
| 809 | // Default behavior. |
| 810 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| 811 | // FIXME: We should copy the content of the original buffer. |
| 812 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 813 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 814 | if (!stateRealloc) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 815 | return 0; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 816 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
| 817 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 818 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 819 | return stateRealloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 820 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 821 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 822 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 823 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 824 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){ |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 825 | if (CE->getNumArgs() < 2) |
| 826 | return 0; |
| 827 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 828 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 829 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 830 | const LocationContext *LCtx = C.getLocationContext(); |
| 831 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 832 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 833 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 834 | svalBuilder.getContext().getSizeType()); |
| 835 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 836 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 837 | return MallocMemAux(C, CE, TotalSize, zeroVal, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 838 | } |
| 839 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 840 | LeakInfo |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 841 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 842 | CheckerContext &C) const { |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 843 | const LocationContext *LeakContext = N->getLocationContext(); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 844 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 845 | // the tracked symbol. |
| 846 | const ExplodedNode *AllocNode = N; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 847 | const MemRegion *ReferenceRegion = 0; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 848 | |
| 849 | while (N) { |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 850 | ProgramStateRef State = N->getState(); |
| 851 | if (!State->get<RegionState>(Sym)) |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 852 | break; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 853 | |
| 854 | // Find the most recent expression bound to the symbol in the current |
| 855 | // context. |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 856 | if (!ReferenceRegion) { |
Benjamin Kramer | 850f1b1 | 2012-03-21 21:03:48 +0000 | [diff] [blame] | 857 | if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) { |
| 858 | SVal Val = State->getSVal(MR); |
| 859 | if (Val.getAsLocSymbol() == Sym) |
| 860 | ReferenceRegion = MR; |
| 861 | } |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 862 | } |
| 863 | |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 864 | // Allocation node, is the last node in the current context in which the |
| 865 | // symbol was tracked. |
| 866 | if (N->getLocationContext() == LeakContext) |
| 867 | AllocNode = N; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 868 | N = N->pred_empty() ? NULL : *(N->pred_begin()); |
| 869 | } |
| 870 | |
| 871 | ProgramPoint P = AllocNode->getLocation(); |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 872 | const Stmt *AllocationStmt = 0; |
| 873 | if (isa<StmtPoint>(P)) |
| 874 | AllocationStmt = cast<StmtPoint>(P).getStmt(); |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 875 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 876 | return LeakInfo(AllocationStmt, ReferenceRegion); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 877 | } |
| 878 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 879 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 880 | CheckerContext &C) const { |
| 881 | assert(N); |
| 882 | if (!BT_Leak) { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 883 | BT_Leak.reset(new BugType("Memory leak", "Memory Error")); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 884 | // Leaks should not be reported if they are post-dominated by a sink: |
| 885 | // (1) Sinks are higher importance bugs. |
| 886 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 887 | // with __noreturn functions such as assert() or exit(). We choose not |
| 888 | // to report leaks on such paths. |
| 889 | BT_Leak->setSuppressOnSink(true); |
| 890 | } |
| 891 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 892 | // Most bug reports are cached at the location where they occurred. |
| 893 | // With leaks, we want to unique them by the location where they were |
| 894 | // allocated, and only report a single path. |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 895 | PathDiagnosticLocation LocUsedForUniqueing; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 896 | const Stmt *AllocStmt = 0; |
| 897 | const MemRegion *Region = 0; |
| 898 | llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C); |
| 899 | if (AllocStmt) |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 900 | LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt, |
| 901 | C.getSourceManager(), N->getLocationContext()); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 902 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 903 | SmallString<200> buf; |
| 904 | llvm::raw_svector_ostream os(buf); |
| 905 | os << "Memory is never released; potential leak"; |
| 906 | if (Region) { |
| 907 | os << " of memory pointed to by '"; |
| 908 | Region->dumpPretty(os); |
| 909 | os <<'\''; |
| 910 | } |
| 911 | |
| 912 | BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 913 | R->markInteresting(Sym); |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame^] | 914 | R->addVisitor(new MallocBugVisitor(Sym, true)); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 915 | C.EmitReport(R); |
| 916 | } |
| 917 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 918 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 919 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 920 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 921 | if (!SymReaper.hasDeadSymbols()) |
| 922 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 923 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 924 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 925 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 926 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 927 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 928 | bool generateReport = false; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 929 | llvm::SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 930 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 931 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 932 | if (I->second.isAllocated()) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 933 | generateReport = true; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 934 | Errors.push_back(I->first); |
| 935 | } |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 936 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 937 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 938 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 939 | } |
| 940 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 941 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 942 | // Cleanup the Realloc Pairs Map. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 943 | ReallocMap RP = state->get<ReallocPairs>(); |
| 944 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 945 | if (SymReaper.isDead(I->first) || |
| 946 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 947 | state = state->remove<ReallocPairs>(I->first); |
| 948 | } |
| 949 | } |
| 950 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 951 | // Generate leak node. |
| 952 | static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak"); |
| 953 | ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 954 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 955 | if (generateReport) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 956 | for (llvm::SmallVector<SymbolRef, 2>::iterator |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 957 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| 958 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 959 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 960 | } |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 961 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 962 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 963 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 964 | void MallocChecker::checkEndPath(CheckerContext &C) const { |
| 965 | ProgramStateRef state = C.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 966 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 967 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 968 | // If inside inlined call, skip it. |
| 969 | if (C.getLocationContext()->getParent() != 0) |
| 970 | return; |
| 971 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 972 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 973 | RefState RS = I->second; |
| 974 | if (RS.isAllocated()) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 975 | ExplodedNode *N = C.addTransition(state); |
| 976 | if (N) |
| 977 | reportLeak(I->first, N, C); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 978 | } |
| 979 | } |
| 980 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 981 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 982 | bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| 983 | CheckerContext &C) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 984 | ProgramStateRef state = C.getState(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 985 | const RefState *RS = state->get<RegionState>(Sym); |
| 986 | if (!RS) |
| 987 | return false; |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 988 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 989 | if (RS->isAllocated()) { |
| 990 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 991 | C.addTransition(state); |
| 992 | return true; |
| 993 | } |
| 994 | return false; |
| 995 | } |
| 996 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 997 | void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| 998 | if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| 999 | return; |
| 1000 | |
| 1001 | // Check use after free, when a freed pointer is passed to a call. |
| 1002 | ProgramStateRef State = C.getState(); |
| 1003 | for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| 1004 | E = CE->arg_end(); I != E; ++I) { |
| 1005 | const Expr *A = *I; |
| 1006 | if (A->getType().getTypePtr()->isAnyPointerType()) { |
| 1007 | SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| 1008 | if (!Sym) |
| 1009 | continue; |
| 1010 | if (checkUseAfterFree(Sym, C, A)) |
| 1011 | return; |
| 1012 | } |
| 1013 | } |
| 1014 | } |
| 1015 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1016 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 1017 | const Expr *E = S->getRetValue(); |
| 1018 | if (!E) |
| 1019 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1020 | |
| 1021 | // Check if we are returning a symbol. |
Anna Zaks | d9ab7bb | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 1022 | SVal RetVal = C.getState()->getSVal(E, C.getLocationContext()); |
| 1023 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 1024 | if (!Sym) |
| 1025 | // If we are returning a field of the allocated struct or an array element, |
| 1026 | // the callee could still free the memory. |
| 1027 | // TODO: This logic should be a part of generic symbol escape callback. |
| 1028 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 1029 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 1030 | if (const SymbolicRegion *BMR = |
| 1031 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 1032 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 1033 | if (!Sym) |
| 1034 | return; |
| 1035 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1036 | // Check if we are returning freed memory. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1037 | if (checkUseAfterFree(Sym, C, E)) |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 1038 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1039 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 1040 | // If this function body is not inlined, check if the symbol is escaping. |
| 1041 | if (C.getLocationContext()->getParent() == 0) |
| 1042 | checkEscape(Sym, E, C); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 1043 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 1044 | |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 1045 | // TODO: Blocks should be either inlined or should call invalidate regions |
| 1046 | // upon invocation. After that's in place, special casing here will not be |
| 1047 | // needed. |
| 1048 | void MallocChecker::checkPostStmt(const BlockExpr *BE, |
| 1049 | CheckerContext &C) const { |
| 1050 | |
| 1051 | // Scan the BlockDecRefExprs for any object the retain count checker |
| 1052 | // may be tracking. |
| 1053 | if (!BE->getBlockDecl()->hasCaptures()) |
| 1054 | return; |
| 1055 | |
| 1056 | ProgramStateRef state = C.getState(); |
| 1057 | const BlockDataRegion *R = |
| 1058 | cast<BlockDataRegion>(state->getSVal(BE, |
| 1059 | C.getLocationContext()).getAsRegion()); |
| 1060 | |
| 1061 | BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(), |
| 1062 | E = R->referenced_vars_end(); |
| 1063 | |
| 1064 | if (I == E) |
| 1065 | return; |
| 1066 | |
| 1067 | SmallVector<const MemRegion*, 10> Regions; |
| 1068 | const LocationContext *LC = C.getLocationContext(); |
| 1069 | MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager(); |
| 1070 | |
| 1071 | for ( ; I != E; ++I) { |
| 1072 | const VarRegion *VR = *I; |
| 1073 | if (VR->getSuperRegion() == R) { |
| 1074 | VR = MemMgr.getVarRegion(VR->getDecl(), LC); |
| 1075 | } |
| 1076 | Regions.push_back(VR); |
| 1077 | } |
| 1078 | |
| 1079 | state = |
| 1080 | state->scanReachableSymbols<StopTrackingCallback>(Regions.data(), |
| 1081 | Regions.data() + Regions.size()).getState(); |
| 1082 | C.addTransition(state); |
| 1083 | } |
| 1084 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1085 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 1086 | const Stmt *S) const { |
| 1087 | assert(Sym); |
| 1088 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 1089 | if (RS && RS->isReleased()) { |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 1090 | if (ExplodedNode *N = C.generateSink()) { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1091 | if (!BT_UseFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 1092 | BT_UseFree.reset(new BugType("Use-after-free", "Memory Error")); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1093 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 1094 | BugReport *R = new BugReport(*BT_UseFree, |
| 1095 | "Use of memory after it is freed",N); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1096 | if (S) |
| 1097 | R->addRange(S->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 1098 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1099 | R->addVisitor(new MallocBugVisitor(Sym)); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1100 | C.EmitReport(R); |
| 1101 | return true; |
| 1102 | } |
| 1103 | } |
| 1104 | return false; |
| 1105 | } |
| 1106 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1107 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 1108 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 1109 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1110 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1111 | if (Sym) |
| 1112 | checkUseAfterFree(Sym, C); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1113 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1114 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1115 | //===----------------------------------------------------------------------===// |
| 1116 | // Check various ways a symbol can be invalidated. |
| 1117 | // TODO: This logic (the next 3 functions) is copied/similar to the |
| 1118 | // RetainRelease checker. We might want to factor this out. |
| 1119 | //===----------------------------------------------------------------------===// |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1120 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1121 | // Stop tracking symbols when a value escapes as a result of checkBind. |
| 1122 | // A value escapes in three possible cases: |
| 1123 | // (1) we are binding to something that is not a memory region. |
| 1124 | // (2) we are binding to a memregion that does not have stack storage |
| 1125 | // (3) we are binding to a memregion with stack storage that the store |
| 1126 | // does not understand. |
| 1127 | void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| 1128 | CheckerContext &C) const { |
| 1129 | // Are we storing to something that causes the value to "escape"? |
| 1130 | bool escapes = true; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1131 | ProgramStateRef state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1132 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1133 | if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| 1134 | escapes = !regionLoc->getRegion()->hasStackStorage(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1135 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1136 | if (!escapes) { |
| 1137 | // To test (3), generate a new state with the binding added. If it is |
| 1138 | // the same state, then it escapes (since the store cannot represent |
| 1139 | // the binding). |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 1140 | // Do this only if we know that the store is not supposed to generate the |
| 1141 | // same state. |
| 1142 | SVal StoredVal = state->getSVal(regionLoc->getRegion()); |
| 1143 | if (StoredVal != val) |
| 1144 | escapes = (state == (state->bindLoc(*regionLoc, val))); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1145 | } |
Anna Zaks | ac59300 | 2012-02-16 03:40:57 +0000 | [diff] [blame] | 1146 | if (!escapes) { |
| 1147 | // Case 4: We do not currently model what happens when a symbol is |
| 1148 | // assigned to a struct field, so be conservative here and let the symbol |
| 1149 | // go. TODO: This could definitely be improved upon. |
| 1150 | escapes = !isa<VarRegion>(regionLoc->getRegion()); |
| 1151 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1152 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1153 | |
| 1154 | // If our store can represent the binding and we aren't storing to something |
| 1155 | // that doesn't have local storage then just return and have the simulation |
| 1156 | // state continue as is. |
| 1157 | if (!escapes) |
| 1158 | return; |
| 1159 | |
| 1160 | // Otherwise, find all symbols referenced by 'val' that we are tracking |
| 1161 | // and stop tracking them. |
| 1162 | state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| 1163 | C.addTransition(state); |
| 1164 | } |
| 1165 | |
| 1166 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 1167 | // it - assuming that allocation failed on this path. |
| 1168 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 1169 | SVal Cond, |
| 1170 | bool Assumption) const { |
| 1171 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1172 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 1173 | // If the symbol is assumed to NULL or another constant, this will |
| 1174 | // return an APSInt*. |
| 1175 | if (state->getSymVal(I.getKey())) |
| 1176 | state = state->remove<RegionState>(I.getKey()); |
| 1177 | } |
| 1178 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1179 | // Realloc returns 0 when reallocation fails, which means that we should |
| 1180 | // restore the state of the pointer being reallocated. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1181 | ReallocMap RP = state->get<ReallocPairs>(); |
| 1182 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1183 | // If the symbol is assumed to NULL or another constant, this will |
| 1184 | // return an APSInt*. |
| 1185 | if (state->getSymVal(I.getKey())) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1186 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 1187 | const RefState *RS = state->get<RegionState>(ReallocSym); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1188 | if (RS) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1189 | if (RS->isReleased() && ! I.getData().IsFreeOnFailure) |
| 1190 | state = state->set<RegionState>(ReallocSym, |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1191 | RefState::getAllocateUnchecked(RS->getStmt())); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1192 | } |
| 1193 | state = state->remove<ReallocPairs>(I.getKey()); |
| 1194 | } |
| 1195 | } |
| 1196 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1197 | return state; |
| 1198 | } |
| 1199 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1200 | // Check if the function is known to us. So, for example, we could |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1201 | // conservatively assume it can free/reallocate it's pointer arguments. |
| 1202 | // (We assume that the pointers cannot escape through calls to system |
| 1203 | // functions not handled by this checker.) |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1204 | bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 1205 | ProgramStateRef State) const { |
| 1206 | if (!Call) |
| 1207 | return false; |
| 1208 | |
| 1209 | // For now, assume that any C++ call can free memory. |
| 1210 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 1211 | // regions escape to C++ containers. They seem to do that even now, but for |
| 1212 | // mysterious reasons. |
| 1213 | if (Call->isCXXCall()) |
| 1214 | return false; |
| 1215 | |
| 1216 | const Decl *D = Call->getDecl(); |
| 1217 | if (!D) |
| 1218 | return false; |
| 1219 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1220 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 1221 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1222 | // If it's one of the allocation functions we can reason about, we model |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1223 | // its behavior explicitly. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1224 | if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) { |
| 1225 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1226 | } |
| 1227 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1228 | // If it's not a system call, assume it frees memory. |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1229 | SourceManager &SM = ASTC.getSourceManager(); |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1230 | if (!SM.isInSystemHeader(D->getLocation())) |
| 1231 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1232 | |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1233 | // Process C/ObjC functions. |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1234 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1235 | // White list the system functions whose arguments escape. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1236 | const IdentifierInfo *II = FD->getIdentifier(); |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1237 | if (!II) |
| 1238 | return true; |
| 1239 | StringRef FName = II->getName(); |
| 1240 | |
| 1241 | // White list thread local storage. |
| 1242 | if (FName.equals("pthread_setspecific")) |
| 1243 | return false; |
| 1244 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1245 | // White list the 'XXXNoCopy' ObjC functions. |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1246 | if (FName.endswith("NoCopy")) { |
| 1247 | // Look for the deallocator argument. We know that the memory ownership |
| 1248 | // is not transfered only if the deallocator argument is |
| 1249 | // 'kCFAllocatorNull'. |
| 1250 | for (unsigned i = 1; i < Call->getNumArgs(); ++i) { |
| 1251 | const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts(); |
| 1252 | if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) { |
| 1253 | StringRef DeallocatorName = DE->getFoundDecl()->getName(); |
| 1254 | if (DeallocatorName == "kCFAllocatorNull") |
| 1255 | return true; |
| 1256 | } |
| 1257 | } |
| 1258 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1259 | } |
| 1260 | |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 1261 | // PR12101 |
| 1262 | // Many CoreFoundation and CoreGraphics might allow a tracked object |
| 1263 | // to escape. |
| 1264 | if (Call->isCFCGAllowingEscape(FName)) |
| 1265 | return false; |
| 1266 | |
| 1267 | // Associating streams with malloced buffers. The pointer can escape if |
| 1268 | // 'closefn' is specified (and if that function does free memory). |
| 1269 | // Currently, we do not inspect the 'closefn' function (PR12101). |
| 1270 | if (FName == "funopen") |
| 1271 | if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0)) |
| 1272 | return false; |
| 1273 | |
| 1274 | // Do not warn on pointers passed to 'setbuf' when used with std streams, |
| 1275 | // these leaks might be intentional when setting the buffer for stdio. |
| 1276 | // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer |
| 1277 | if (FName == "setbuf" || FName =="setbuffer" || |
| 1278 | FName == "setlinebuf" || FName == "setvbuf") { |
| 1279 | if (Call->getNumArgs() >= 1) |
| 1280 | if (const DeclRefExpr *Arg = |
| 1281 | dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts())) |
| 1282 | if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl())) |
| 1283 | if (D->getCanonicalDecl()->getName().find("std") |
| 1284 | != StringRef::npos) |
| 1285 | return false; |
| 1286 | } |
| 1287 | |
| 1288 | // A bunch of other functions, which take ownership of a pointer (See retain |
| 1289 | // release checker). Not all the parameters here are invalidated, but the |
| 1290 | // Malloc checker cannot differentiate between them. The right way of doing |
| 1291 | // this would be to implement a pointer escapes callback. |
| 1292 | if (FName == "CVPixelBufferCreateWithBytes" || |
| 1293 | FName == "CGBitmapContextCreateWithData" || |
Anna Zaks | 4cd7edf | 2012-03-26 18:18:39 +0000 | [diff] [blame] | 1294 | FName == "CVPixelBufferCreateWithPlanarBytes" || |
| 1295 | FName == "OSAtomicEnqueue") { |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 1296 | return false; |
| 1297 | } |
| 1298 | |
Anna Zaks | 62a5c34 | 2012-03-30 05:48:16 +0000 | [diff] [blame] | 1299 | // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can |
| 1300 | // be deallocated by NSMapRemove. |
| 1301 | if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos)) |
| 1302 | return false; |
| 1303 | |
Anna Zaks | aca0ac5 | 2012-05-03 23:50:28 +0000 | [diff] [blame] | 1304 | // If the call has a callback as an argument, assume the memory |
| 1305 | // can be freed. |
| 1306 | if (Call->hasNonZeroCallbackArg()) |
| 1307 | return false; |
| 1308 | |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1309 | // Otherwise, assume that the function does not free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1310 | // Most system calls, do not free the memory. |
| 1311 | return true; |
| 1312 | |
| 1313 | // Process ObjC functions. |
| 1314 | } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) { |
| 1315 | Selector S = ObjCD->getSelector(); |
| 1316 | |
| 1317 | // White list the ObjC functions which do free memory. |
| 1318 | // - Anything containing 'freeWhenDone' param set to 1. |
| 1319 | // Ex: dataWithBytesNoCopy:length:freeWhenDone. |
| 1320 | for (unsigned i = 1; i < S.getNumArgs(); ++i) { |
| 1321 | if (S.getNameForSlot(i).equals("freeWhenDone")) { |
| 1322 | if (Call->getArgSVal(i).isConstant(1)) |
| 1323 | return false; |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1324 | else |
| 1325 | return true; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1326 | } |
| 1327 | } |
| 1328 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1329 | // If the first selector ends with NoCopy, assume that the ownership is |
| 1330 | // transfered as well. |
| 1331 | // Ex: [NSData dataWithBytesNoCopy:bytes length:10]; |
| 1332 | if (S.getNameForSlot(0).endswith("NoCopy")) { |
| 1333 | return false; |
| 1334 | } |
| 1335 | |
Anna Zaks | aca0ac5 | 2012-05-03 23:50:28 +0000 | [diff] [blame] | 1336 | // If the call has a callback as an argument, assume the memory |
| 1337 | // can be freed. |
| 1338 | if (Call->hasNonZeroCallbackArg()) |
| 1339 | return false; |
| 1340 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1341 | // Otherwise, assume that the function does not free memory. |
| 1342 | // Most system calls, do not free the memory. |
| 1343 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1344 | } |
| 1345 | |
| 1346 | // Otherwise, assume that the function can free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1347 | return false; |
| 1348 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1349 | } |
| 1350 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1351 | // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| 1352 | // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| 1353 | // about it anymore. |
| 1354 | ProgramStateRef |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1355 | MallocChecker::checkRegionChanges(ProgramStateRef State, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1356 | const StoreManager::InvalidatedSymbols *invalidated, |
| 1357 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1358 | ArrayRef<const MemRegion *> Regions, |
| 1359 | const CallOrObjCMessage *Call) const { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1360 | if (!invalidated || invalidated->empty()) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1361 | return State; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1362 | llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1363 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1364 | // If it's a call which might free or reallocate memory, we assume that all |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1365 | // regions (explicit and implicit) escaped. |
| 1366 | |
| 1367 | // Otherwise, whitelist explicit pointers; we still can track them. |
| 1368 | if (!Call || doesNotFreeMemory(Call, State)) { |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1369 | for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| 1370 | E = ExplicitRegions.end(); I != E; ++I) { |
| 1371 | if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| 1372 | WhitelistedSymbols.insert(R->getSymbol()); |
| 1373 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1374 | } |
| 1375 | |
| 1376 | for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| 1377 | E = invalidated->end(); I!=E; ++I) { |
| 1378 | SymbolRef sym = *I; |
| 1379 | if (WhitelistedSymbols.count(sym)) |
| 1380 | continue; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1381 | // The symbol escaped. |
| 1382 | if (const RefState *RS = State->get<RegionState>(sym)) |
| 1383 | State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1384 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1385 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1386 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1387 | |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1388 | static SymbolRef findFailedReallocSymbol(ProgramStateRef currState, |
| 1389 | ProgramStateRef prevState) { |
| 1390 | ReallocMap currMap = currState->get<ReallocPairs>(); |
| 1391 | ReallocMap prevMap = prevState->get<ReallocPairs>(); |
| 1392 | |
| 1393 | for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end(); |
| 1394 | I != E; ++I) { |
| 1395 | SymbolRef sym = I.getKey(); |
| 1396 | if (!currMap.lookup(sym)) |
| 1397 | return sym; |
| 1398 | } |
| 1399 | |
| 1400 | return NULL; |
| 1401 | } |
| 1402 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1403 | PathDiagnosticPiece * |
| 1404 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 1405 | const ExplodedNode *PrevN, |
| 1406 | BugReporterContext &BRC, |
| 1407 | BugReport &BR) { |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1408 | ProgramStateRef state = N->getState(); |
| 1409 | ProgramStateRef statePrev = PrevN->getState(); |
| 1410 | |
| 1411 | const RefState *RS = state->get<RegionState>(Sym); |
| 1412 | const RefState *RSPrev = statePrev->get<RegionState>(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1413 | if (!RS && !RSPrev) |
| 1414 | return 0; |
| 1415 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1416 | const Stmt *S = 0; |
| 1417 | const char *Msg = 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1418 | StackHintGeneratorForSymbol *StackHint = 0; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1419 | |
| 1420 | // Retrieve the associated statement. |
| 1421 | ProgramPoint ProgLoc = N->getLocation(); |
| 1422 | if (isa<StmtPoint>(ProgLoc)) |
| 1423 | S = cast<StmtPoint>(ProgLoc).getStmt(); |
| 1424 | // If an assumption was made on a branch, it should be caught |
| 1425 | // here by looking at the state transition. |
| 1426 | if (isa<BlockEdge>(ProgLoc)) { |
| 1427 | const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc(); |
| 1428 | S = srcBlk->getTerminator(); |
| 1429 | } |
| 1430 | if (!S) |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1431 | return 0; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1432 | |
| 1433 | // Find out if this is an interesting point and what is the kind. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1434 | if (Mode == Normal) { |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1435 | if (isAllocated(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1436 | Msg = "Memory is allocated"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1437 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1438 | "Returned allocated memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1439 | } else if (isReleased(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1440 | Msg = "Memory is released"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1441 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1442 | "Returned released memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1443 | } else if (isReallocFailedCheck(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1444 | Mode = ReallocationFailed; |
| 1445 | Msg = "Reallocation failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1446 | StackHint = new StackHintGeneratorForReallocationFailed(Sym, |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1447 | "Reallocation failed"); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1448 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1449 | if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) { |
| 1450 | // Is it possible to fail two reallocs WITHOUT testing in between? |
| 1451 | assert((!FailedReallocSymbol || FailedReallocSymbol == sym) && |
| 1452 | "We only support one failed realloc at a time."); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1453 | BR.markInteresting(sym); |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1454 | FailedReallocSymbol = sym; |
| 1455 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1456 | } |
| 1457 | |
| 1458 | // We are in a special mode if a reallocation failed later in the path. |
| 1459 | } else if (Mode == ReallocationFailed) { |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1460 | assert(FailedReallocSymbol && "No symbol to look for."); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1461 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1462 | // Is this is the first appearance of the reallocated symbol? |
| 1463 | if (!statePrev->get<RegionState>(FailedReallocSymbol)) { |
| 1464 | // If we ever hit this assert, that means BugReporter has decided to skip |
| 1465 | // node pairs or visit them out of order. |
| 1466 | assert(state->get<RegionState>(FailedReallocSymbol) && |
| 1467 | "Missed the reallocation point"); |
| 1468 | |
| 1469 | // We're at the reallocation point. |
| 1470 | Msg = "Attempt to reallocate memory"; |
| 1471 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1472 | "Returned reallocated memory"); |
| 1473 | FailedReallocSymbol = NULL; |
| 1474 | Mode = Normal; |
| 1475 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1476 | } |
| 1477 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1478 | if (!Msg) |
| 1479 | return 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1480 | assert(StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1481 | |
| 1482 | // Generate the extra diagnostic. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1483 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1484 | N->getLocationContext()); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1485 | return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1486 | } |
| 1487 | |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 1488 | void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State, |
| 1489 | const char *NL, const char *Sep) const { |
| 1490 | |
| 1491 | RegionStateTy RS = State->get<RegionState>(); |
| 1492 | |
| 1493 | if (!RS.isEmpty()) |
| 1494 | Out << "Has Malloc data" << NL; |
| 1495 | } |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1496 | |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1497 | #define REGISTER_CHECKER(name) \ |
| 1498 | void ento::register##name(CheckerManager &mgr) {\ |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 1499 | registerCStringCheckerBasic(mgr); \ |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1500 | mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1501 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1502 | |
| 1503 | REGISTER_CHECKER(MallocPessimistic) |
| 1504 | REGISTER_CHECKER(MallocOptimistic) |