blob: 4df77a845eb68f7f9bd3ce7ca062510aaa48db65 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Anna Zaks66c40402012-02-14 21:55:24 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Ted Kremenekdde201b2010-08-06 21:12:55 +000037 enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped,
38 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000039 const Stmt *S;
40
Zhongxing Xu7fb14642009-12-11 00:55:44 +000041public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000042 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
43
Zhongxing Xub94b81a2009-12-31 06:13:07 +000044 bool isAllocated() const { return K == AllocateUnchecked; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000045 bool isReleased() const { return K == Released; }
Anna Zaksca23eb22012-02-29 18:42:47 +000046
Anna Zaksc8bb3be2012-02-13 18:05:39 +000047 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000048
49 bool operator==(const RefState &X) const {
50 return K == X.K && S == X.S;
51 }
52
Zhongxing Xub94b81a2009-12-31 06:13:07 +000053 static RefState getAllocateUnchecked(const Stmt *s) {
54 return RefState(AllocateUnchecked, s);
55 }
56 static RefState getAllocateFailed() {
57 return RefState(AllocateFailed, 0);
58 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000059 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
60 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000061 static RefState getRelinquished(const Stmt *s) {
62 return RefState(Relinquished, s);
63 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000064
65 void Profile(llvm::FoldingSetNodeID &ID) const {
66 ID.AddInteger(K);
67 ID.AddPointer(S);
68 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000069};
70
Anna Zaks40add292012-02-15 00:11:25 +000071struct ReallocPair {
72 SymbolRef ReallocatedSym;
73 bool IsFreeOnFailure;
74 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
75 void Profile(llvm::FoldingSetNodeID &ID) const {
76 ID.AddInteger(IsFreeOnFailure);
77 ID.AddPointer(ReallocatedSym);
78 }
79 bool operator==(const ReallocPair &X) const {
80 return ReallocatedSym == X.ReallocatedSym &&
81 IsFreeOnFailure == X.IsFreeOnFailure;
82 }
83};
84
Anna Zaks3d7c44e2012-03-21 19:45:08 +000085typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
86
Anna Zaksb319e022012-02-08 20:13:28 +000087class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000088 check::EndPath,
89 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000090 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +000091 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +000092 check::PostStmt<BlockExpr>,
Ted Kremeneke3659a72012-01-04 23:48:37 +000093 check::Location,
94 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +000095 eval::Assume,
96 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +000097{
Anna Zaksfebdc322012-02-16 22:26:12 +000098 mutable OwningPtr<BugType> BT_DoubleFree;
99 mutable OwningPtr<BugType> BT_Leak;
100 mutable OwningPtr<BugType> BT_UseFree;
101 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000102 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000103 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
104
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000105public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000106 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000107 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000108
109 /// In pessimistic mode, the checker assumes that it does not know which
110 /// functions might free the memory.
111 struct ChecksFilter {
112 DefaultBool CMallocPessimistic;
113 DefaultBool CMallocOptimistic;
114 };
115
116 ChecksFilter Filter;
117
Anna Zaks66c40402012-02-14 21:55:24 +0000118 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000119 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000120 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000121 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000122 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000123 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000124 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000125 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000126 void checkLocation(SVal l, bool isLoad, const Stmt *S,
127 CheckerContext &C) const;
128 void checkBind(SVal location, SVal val, const Stmt*S,
129 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000130 ProgramStateRef
131 checkRegionChanges(ProgramStateRef state,
132 const StoreManager::InvalidatedSymbols *invalidated,
133 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000134 ArrayRef<const MemRegion *> Regions,
135 const CallOrObjCMessage *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000136 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
137 return true;
138 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000139
Anna Zaks93c5a242012-05-02 00:05:20 +0000140 void printState(raw_ostream &Out, ProgramStateRef State,
141 const char *NL, const char *Sep) const;
142
Zhongxing Xu7b760962009-11-13 07:25:27 +0000143private:
Anna Zaks66c40402012-02-14 21:55:24 +0000144 void initIdentifierInfo(ASTContext &C) const;
145
146 /// Check if this is one of the functions which can allocate/reallocate memory
147 /// pointed to by one of its arguments.
148 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
149
Anna Zaks87cb5be2012-02-22 19:24:52 +0000150 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
151 const CallExpr *CE,
152 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000153 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000154 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000155 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000156 return MallocMemAux(C, CE,
157 state->getSVal(SizeEx, C.getLocationContext()),
158 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000159 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000160
Ted Kremenek8bef8232012-01-26 21:29:00 +0000161 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000162 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000163 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000164
Anna Zaks87cb5be2012-02-22 19:24:52 +0000165 /// Update the RefState to reflect the new memory allocation.
166 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
167 const CallExpr *CE,
168 ProgramStateRef state);
169
170 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
171 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000172 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
173 ProgramStateRef state, unsigned Num,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000174 bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000175
Anna Zaks87cb5be2012-02-22 19:24:52 +0000176 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
177 bool FreesMemOnFailure) const;
178 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000179
Anna Zaks91c2a112012-02-08 23:16:56 +0000180 bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const;
181 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
182 const Stmt *S = 0) const;
183
Anna Zaks66c40402012-02-14 21:55:24 +0000184 /// Check if the function is not known to us. So, for example, we could
185 /// conservatively assume it can free/reallocate it's pointer arguments.
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000186 bool doesNotFreeMemory(const CallOrObjCMessage *Call,
187 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000188
Ted Kremenek9c378f72011-08-12 23:37:29 +0000189 static bool SummarizeValue(raw_ostream &os, SVal V);
190 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000191 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000192
Anna Zaksca8e36e2012-02-23 21:38:21 +0000193 /// Find the location of the allocation for Sym on the path leading to the
194 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000195 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
196 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000197
Anna Zaksda046772012-02-11 21:02:40 +0000198 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
199
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000200 /// The bug visitor which allows us to print extra diagnostics along the
201 /// BugReport path. For example, showing the allocation site of the leaked
202 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000203 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000204 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000205 enum NotificationMode {
206 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000207 ReallocationFailed
208 };
209
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000210 // The allocated region symbol tracked by the main analysis.
211 SymbolRef Sym;
212
Anna Zaks88feba02012-05-10 01:37:40 +0000213 // The mode we are in, i.e. what kind of diagnostics will be emitted.
214 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000215
Anna Zaks88feba02012-05-10 01:37:40 +0000216 // A symbol from when the primary region should have been reallocated.
217 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000218
Anna Zaks88feba02012-05-10 01:37:40 +0000219 bool IsLeak;
220
221 public:
222 MallocBugVisitor(SymbolRef S, bool isLeak = false)
223 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000224
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000225 virtual ~MallocBugVisitor() {}
226
227 void Profile(llvm::FoldingSetNodeID &ID) const {
228 static int X = 0;
229 ID.AddPointer(&X);
230 ID.AddPointer(Sym);
231 }
232
Anna Zaksfe571602012-02-16 22:26:07 +0000233 inline bool isAllocated(const RefState *S, const RefState *SPrev,
234 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000235 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000236 return (Stmt && isa<CallExpr>(Stmt) &&
237 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000238 }
239
Anna Zaksfe571602012-02-16 22:26:07 +0000240 inline bool isReleased(const RefState *S, const RefState *SPrev,
241 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000242 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000243 return (Stmt && isa<CallExpr>(Stmt) &&
244 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
245 }
246
247 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
248 const Stmt *Stmt) {
249 // If the expression is not a call, and the state change is
250 // released -> allocated, it must be the realloc return value
251 // check. If we have to handle more cases here, it might be cleaner just
252 // to track this extra bit in the state itself.
253 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
254 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000255 }
256
257 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
258 const ExplodedNode *PrevN,
259 BugReporterContext &BRC,
260 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000261
262 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
263 const ExplodedNode *EndPathNode,
264 BugReport &BR) {
265 if (!IsLeak)
266 return 0;
267
268 PathDiagnosticLocation L =
269 PathDiagnosticLocation::createEndOfPath(EndPathNode,
270 BRC.getSourceManager());
271 // Do not add the statement itself as a range in case of leak.
272 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
273 }
274
Anna Zaks56a938f2012-03-16 23:24:20 +0000275 private:
276 class StackHintGeneratorForReallocationFailed
277 : public StackHintGeneratorForSymbol {
278 public:
279 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
280 : StackHintGeneratorForSymbol(S, M) {}
281
282 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
283 SmallString<200> buf;
284 llvm::raw_svector_ostream os(buf);
285
Anna Zaksfbd58742012-03-16 23:44:28 +0000286 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000287 // Printed parameters start at 1, not 0.
288 printOrdinal(++ArgIndex, os);
289 os << " parameter failed";
290
291 return os.str();
292 }
293
294 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000295 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000296 }
297 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000298 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000299};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000300} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000301
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000302typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000303typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000304class RegionState {};
305class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000306namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000307namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000308 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000309 struct ProgramStateTrait<RegionState>
310 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000311 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000312 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000313
314 template <>
315 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000316 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000317 static void *GDMIndex() { static int x; return &x; }
318 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000319}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000320}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000321
Anna Zaks4fb54872012-02-11 21:02:35 +0000322namespace {
323class StopTrackingCallback : public SymbolVisitor {
324 ProgramStateRef state;
325public:
326 StopTrackingCallback(ProgramStateRef st) : state(st) {}
327 ProgramStateRef getState() const { return state; }
328
329 bool VisitSymbol(SymbolRef sym) {
330 state = state->remove<RegionState>(sym);
331 return true;
332 }
333};
334} // end anonymous namespace
335
Anna Zaks66c40402012-02-14 21:55:24 +0000336void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000337 if (!II_malloc)
338 II_malloc = &Ctx.Idents.get("malloc");
339 if (!II_free)
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000340 II_free = &Ctx.Idents.get("free");
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000341 if (!II_realloc)
342 II_realloc = &Ctx.Idents.get("realloc");
Anna Zaks40add292012-02-15 00:11:25 +0000343 if (!II_reallocf)
344 II_reallocf = &Ctx.Idents.get("reallocf");
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000345 if (!II_calloc)
346 II_calloc = &Ctx.Idents.get("calloc");
Anna Zaksb16ce452012-02-15 00:11:22 +0000347 if (!II_valloc)
348 II_valloc = &Ctx.Idents.get("valloc");
Anna Zaks60a1fa42012-02-22 03:14:20 +0000349 if (!II_strdup)
350 II_strdup = &Ctx.Idents.get("strdup");
351 if (!II_strndup)
352 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000353}
354
Anna Zaks66c40402012-02-14 21:55:24 +0000355bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000356 if (!FD)
357 return false;
Anna Zaks66c40402012-02-14 21:55:24 +0000358 IdentifierInfo *FunI = FD->getIdentifier();
359 if (!FunI)
360 return false;
361
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000362 initIdentifierInfo(C);
363
Anna Zaks40add292012-02-15 00:11:25 +0000364 if (FunI == II_malloc || FunI == II_free || FunI == II_realloc ||
Anna Zaks60a1fa42012-02-22 03:14:20 +0000365 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
366 FunI == II_strdup || FunI == II_strndup)
Anna Zaks66c40402012-02-14 21:55:24 +0000367 return true;
368
369 if (Filter.CMallocOptimistic && FD->hasAttrs() &&
370 FD->specific_attr_begin<OwnershipAttr>() !=
371 FD->specific_attr_end<OwnershipAttr>())
372 return true;
373
374
375 return false;
376}
377
Anna Zaksb319e022012-02-08 20:13:28 +0000378void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
379 const FunctionDecl *FD = C.getCalleeDecl(CE);
380 if (!FD)
381 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000382
Anna Zaksb16ce452012-02-15 00:11:22 +0000383 initIdentifierInfo(C.getASTContext());
384 IdentifierInfo *FunI = FD->getIdentifier();
385 if (!FunI)
386 return;
387
Anna Zaks87cb5be2012-02-22 19:24:52 +0000388 ProgramStateRef State = C.getState();
Anna Zaksb16ce452012-02-15 00:11:22 +0000389 if (FunI == II_malloc || FunI == II_valloc) {
Anna Zaks259052d2012-04-10 23:41:11 +0000390 if (CE->getNumArgs() < 1)
391 return;
Anna Zaks87cb5be2012-02-22 19:24:52 +0000392 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anna Zaksb16ce452012-02-15 00:11:22 +0000393 } else if (FunI == II_realloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000394 State = ReallocMem(C, CE, false);
Anna Zaks40add292012-02-15 00:11:25 +0000395 } else if (FunI == II_reallocf) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000396 State = ReallocMem(C, CE, true);
Anna Zaksb16ce452012-02-15 00:11:22 +0000397 } else if (FunI == II_calloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000398 State = CallocMem(C, CE);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000399 } else if (FunI == II_free) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000400 State = FreeMemAux(C, CE, C.getState(), 0, false);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000401 } else if (FunI == II_strdup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000402 State = MallocUpdateRefState(C, CE, State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000403 } else if (FunI == II_strndup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000404 State = MallocUpdateRefState(C, CE, State);
405 } else if (Filter.CMallocOptimistic) {
406 // Check all the attributes, if there are any.
407 // There can be multiple of these attributes.
408 if (FD->hasAttrs())
409 for (specific_attr_iterator<OwnershipAttr>
410 i = FD->specific_attr_begin<OwnershipAttr>(),
411 e = FD->specific_attr_end<OwnershipAttr>();
412 i != e; ++i) {
413 switch ((*i)->getOwnKind()) {
414 case OwnershipAttr::Returns:
415 State = MallocMemReturnsAttr(C, CE, *i);
416 break;
417 case OwnershipAttr::Takes:
418 case OwnershipAttr::Holds:
419 State = FreeMemAttr(C, CE, *i);
420 break;
421 }
422 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000423 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000424 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000425}
426
Anna Zaks87cb5be2012-02-22 19:24:52 +0000427ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
428 const CallExpr *CE,
429 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000430 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000431 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000432
Sean Huntcf807c42010-08-18 23:23:40 +0000433 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000434 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000435 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000436 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000437 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000438}
439
Anna Zaksb319e022012-02-08 20:13:28 +0000440ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000441 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000442 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000443 ProgramStateRef state) {
Anna Zaksb319e022012-02-08 20:13:28 +0000444 // Get the return value.
445 SVal retVal = state->getSVal(CE, C.getLocationContext());
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000446
Anna Zaksb16ce452012-02-15 00:11:22 +0000447 // We expect the malloc functions to return a pointer.
448 if (!isa<Loc>(retVal))
449 return 0;
450
Jordy Rose32f26562010-07-04 00:00:41 +0000451 // Fill the region with the initialization value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000452 state = state->bindDefault(retVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000453
Jordy Rose32f26562010-07-04 00:00:41 +0000454 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000455 const SymbolicRegion *R =
456 dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000457 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000458 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000459 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000460 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000461 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
462 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
463 DefinedOrUnknownSVal extentMatchesSize =
464 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000465
Anna Zaks60a1fa42012-02-22 03:14:20 +0000466 state = state->assume(extentMatchesSize, true);
467 assert(state);
468 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000469
Anna Zaks87cb5be2012-02-22 19:24:52 +0000470 return MallocUpdateRefState(C, CE, state);
471}
472
473ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
474 const CallExpr *CE,
475 ProgramStateRef state) {
476 // Get the return value.
477 SVal retVal = state->getSVal(CE, C.getLocationContext());
478
479 // We expect the malloc functions to return a pointer.
480 if (!isa<Loc>(retVal))
481 return 0;
482
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000483 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000484 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000485
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000486 // Set the symbol's state to Allocated.
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000487 return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000488
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000489}
490
Anna Zaks87cb5be2012-02-22 19:24:52 +0000491ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
492 const CallExpr *CE,
493 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000494 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000495 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000496
Anna Zaksb3d72752012-03-01 22:06:06 +0000497 ProgramStateRef State = C.getState();
498
Sean Huntcf807c42010-08-18 23:23:40 +0000499 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
500 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000501 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
502 Att->getOwnKind() == OwnershipAttr::Holds);
503 if (StateI)
504 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000505 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000506 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000507}
508
Ted Kremenek8bef8232012-01-26 21:29:00 +0000509ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000510 const CallExpr *CE,
511 ProgramStateRef state,
512 unsigned Num,
513 bool Hold) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000514 if (CE->getNumArgs() < (Num + 1))
515 return 0;
516
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000517 const Expr *ArgExpr = CE->getArg(Num);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000518 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000519 if (!isa<DefinedOrUnknownSVal>(ArgVal))
520 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000521 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
522
523 // Check for null dereferences.
524 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000525 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000526
Anna Zaksb276bd92012-02-14 00:26:13 +0000527 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000528 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000529 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000530 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000531 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000532
Jordy Rose43859f62010-06-07 19:32:37 +0000533 // Unknown values could easily be okay
534 // Undefined values are handled elsewhere
535 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000536 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000537
Jordy Rose43859f62010-06-07 19:32:37 +0000538 const MemRegion *R = ArgVal.getAsRegion();
539
540 // Nonlocs can't be freed, of course.
541 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
542 if (!R) {
543 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000544 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000545 }
546
547 R = R->StripCasts();
548
549 // Blocks might show up as heap data, but should not be free()d
550 if (isa<BlockDataRegion>(R)) {
551 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000552 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000553 }
554
555 const MemSpaceRegion *MS = R->getMemorySpace();
556
557 // Parameters, locals, statics, and globals shouldn't be freed.
558 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
559 // FIXME: at the time this code was written, malloc() regions were
560 // represented by conjured symbols, which are all in UnknownSpaceRegion.
561 // This means that there isn't actually anything from HeapSpaceRegion
562 // that should be freed, even though we allow it here.
563 // Of course, free() can work on memory allocated outside the current
564 // function, so UnknownSpaceRegion is always a possibility.
565 // False negatives are better than false positives.
566
567 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000568 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000569 }
570
571 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
572 // Various cases could lead to non-symbol values here.
573 // For now, ignore them.
574 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000575 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000576
577 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000578 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000579
580 // If the symbol has not been tracked, return. This is possible when free() is
581 // called on a pointer that does not get its pointee directly from malloc().
582 // Full support of this requires inter-procedural analysis.
583 if (!RS)
Anna Zaksb319e022012-02-08 20:13:28 +0000584 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000585
586 // Check double free.
Zhongxing Xu243fde92009-11-17 07:54:15 +0000587 if (RS->isReleased()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000588 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000589 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000590 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000591 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000592 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaksfebdc322012-02-16 22:26:12 +0000593 "Attempt to free released memory", N);
Anna Zaksfe571602012-02-16 22:26:07 +0000594 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000595 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000596 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000597 C.EmitReport(R);
598 }
Anna Zaksb319e022012-02-08 20:13:28 +0000599 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000600 }
601
602 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000603 if (Hold)
Anna Zaksb276bd92012-02-14 00:26:13 +0000604 return state->set<RegionState>(Sym, RefState::getRelinquished(CE));
605 return state->set<RegionState>(Sym, RefState::getReleased(CE));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000606}
607
Ted Kremenek9c378f72011-08-12 23:37:29 +0000608bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000609 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
610 os << "an integer (" << IntVal->getValue() << ")";
611 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
612 os << "a constant address (" << ConstAddr->getValue() << ")";
613 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000614 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000615 else
616 return false;
617
618 return true;
619}
620
Ted Kremenek9c378f72011-08-12 23:37:29 +0000621bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000622 const MemRegion *MR) {
623 switch (MR->getKind()) {
624 case MemRegion::FunctionTextRegionKind: {
625 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
626 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000627 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000628 else
629 os << "the address of a function";
630 return true;
631 }
632 case MemRegion::BlockTextRegionKind:
633 os << "block text";
634 return true;
635 case MemRegion::BlockDataRegionKind:
636 // FIXME: where the block came from?
637 os << "a block";
638 return true;
639 default: {
640 const MemSpaceRegion *MS = MR->getMemorySpace();
641
Anna Zakseb31a762012-01-04 23:54:01 +0000642 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000643 const VarRegion *VR = dyn_cast<VarRegion>(MR);
644 const VarDecl *VD;
645 if (VR)
646 VD = VR->getDecl();
647 else
648 VD = NULL;
649
650 if (VD)
651 os << "the address of the local variable '" << VD->getName() << "'";
652 else
653 os << "the address of a local stack variable";
654 return true;
655 }
Anna Zakseb31a762012-01-04 23:54:01 +0000656
657 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000658 const VarRegion *VR = dyn_cast<VarRegion>(MR);
659 const VarDecl *VD;
660 if (VR)
661 VD = VR->getDecl();
662 else
663 VD = NULL;
664
665 if (VD)
666 os << "the address of the parameter '" << VD->getName() << "'";
667 else
668 os << "the address of a parameter";
669 return true;
670 }
Anna Zakseb31a762012-01-04 23:54:01 +0000671
672 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000673 const VarRegion *VR = dyn_cast<VarRegion>(MR);
674 const VarDecl *VD;
675 if (VR)
676 VD = VR->getDecl();
677 else
678 VD = NULL;
679
680 if (VD) {
681 if (VD->isStaticLocal())
682 os << "the address of the static variable '" << VD->getName() << "'";
683 else
684 os << "the address of the global variable '" << VD->getName() << "'";
685 } else
686 os << "the address of a global variable";
687 return true;
688 }
Anna Zakseb31a762012-01-04 23:54:01 +0000689
690 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000691 }
692 }
693}
694
695void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000696 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000697 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000698 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000699 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000700
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000701 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000702 llvm::raw_svector_ostream os(buf);
703
704 const MemRegion *MR = ArgVal.getAsRegion();
705 if (MR) {
706 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
707 MR = ER->getSuperRegion();
708
709 // Special case for alloca()
710 if (isa<AllocaRegion>(MR))
711 os << "Argument to free() was allocated by alloca(), not malloc()";
712 else {
713 os << "Argument to free() is ";
714 if (SummarizeRegion(os, MR))
715 os << ", which is not memory allocated by malloc()";
716 else
717 os << "not memory allocated by malloc()";
718 }
719 } else {
720 os << "Argument to free() is ";
721 if (SummarizeValue(os, ArgVal))
722 os << ", which is not memory allocated by malloc()";
723 else
724 os << "not memory allocated by malloc()";
725 }
726
Anna Zakse172e8b2011-08-17 23:00:25 +0000727 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000728 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000729 R->addRange(range);
730 C.EmitReport(R);
731 }
732}
733
Anna Zaks87cb5be2012-02-22 19:24:52 +0000734ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
735 const CallExpr *CE,
736 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000737 if (CE->getNumArgs() < 2)
738 return 0;
739
Ted Kremenek8bef8232012-01-26 21:29:00 +0000740 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000741 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000742 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000743 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
744 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000745 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000746 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000747
Ted Kremenek846eabd2010-12-01 21:28:31 +0000748 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000749
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000750 DefinedOrUnknownSVal PtrEQ =
751 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000752
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000753 // Get the size argument. If there is no size arg then give up.
754 const Expr *Arg1 = CE->getArg(1);
755 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000756 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000757
758 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000759 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
760 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000761 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000762 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000763
764 // Compare the size argument to 0.
765 DefinedOrUnknownSVal SizeZero =
766 svalBuilder.evalEQ(state, Arg1Val,
767 svalBuilder.makeIntValWithPtrWidth(0, false));
768
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000769 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
770 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
771 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
772 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
773 // We only assume exceptional states if they are definitely true; if the
774 // state is under-constrained, assume regular realloc behavior.
775 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
776 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
777
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000778 // If the ptr is NULL and the size is not 0, the call is equivalent to
779 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000780 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000781 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000782 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000783 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000784 }
785
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000786 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000787 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000788
Anna Zaks30838b92012-02-13 20:57:07 +0000789 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000790 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000791 SymbolRef FromPtr = arg0Val.getAsSymbol();
792 SVal RetVal = state->getSVal(CE, LCtx);
793 SymbolRef ToPtr = RetVal.getAsSymbol();
794 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000795 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000796
797 // If the size is 0, free the memory.
798 if (SizeIsZero)
799 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000800 // The semantics of the return value are:
801 // If size was equal to 0, either NULL or a pointer suitable to be passed
802 // to free() is returned.
Anna Zaks40add292012-02-15 00:11:25 +0000803 stateFree = stateFree->set<ReallocPairs>(ToPtr,
804 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000805 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000806 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000807 }
808
809 // Default behavior.
810 if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) {
811 // FIXME: We should copy the content of the original buffer.
812 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
813 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000814 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000815 return 0;
Anna Zaks40add292012-02-15 00:11:25 +0000816 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
817 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000818 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000819 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000820 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000821 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000822}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000823
Anna Zaks87cb5be2012-02-22 19:24:52 +0000824ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000825 if (CE->getNumArgs() < 2)
826 return 0;
827
Ted Kremenek8bef8232012-01-26 21:29:00 +0000828 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000829 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000830 const LocationContext *LCtx = C.getLocationContext();
831 SVal count = state->getSVal(CE->getArg(0), LCtx);
832 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000833 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
834 svalBuilder.getContext().getSizeType());
835 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000836
Anna Zaks87cb5be2012-02-22 19:24:52 +0000837 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000838}
839
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000840LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000841MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
842 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000843 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000844 // Walk the ExplodedGraph backwards and find the first node that referred to
845 // the tracked symbol.
846 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000847 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000848
849 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000850 ProgramStateRef State = N->getState();
851 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000852 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000853
854 // Find the most recent expression bound to the symbol in the current
855 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000856 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000857 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
858 SVal Val = State->getSVal(MR);
859 if (Val.getAsLocSymbol() == Sym)
860 ReferenceRegion = MR;
861 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000862 }
863
Anna Zaks7752d292012-02-27 23:40:55 +0000864 // Allocation node, is the last node in the current context in which the
865 // symbol was tracked.
866 if (N->getLocationContext() == LeakContext)
867 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000868 N = N->pred_empty() ? NULL : *(N->pred_begin());
869 }
870
871 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000872 const Stmt *AllocationStmt = 0;
873 if (isa<StmtPoint>(P))
874 AllocationStmt = cast<StmtPoint>(P).getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000875
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000876 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000877}
878
Anna Zaksda046772012-02-11 21:02:40 +0000879void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
880 CheckerContext &C) const {
881 assert(N);
882 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +0000883 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +0000884 // Leaks should not be reported if they are post-dominated by a sink:
885 // (1) Sinks are higher importance bugs.
886 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
887 // with __noreturn functions such as assert() or exit(). We choose not
888 // to report leaks on such paths.
889 BT_Leak->setSuppressOnSink(true);
890 }
891
Anna Zaksca8e36e2012-02-23 21:38:21 +0000892 // Most bug reports are cached at the location where they occurred.
893 // With leaks, we want to unique them by the location where they were
894 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +0000895 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000896 const Stmt *AllocStmt = 0;
897 const MemRegion *Region = 0;
898 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
899 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +0000900 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
901 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +0000902
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000903 SmallString<200> buf;
904 llvm::raw_svector_ostream os(buf);
905 os << "Memory is never released; potential leak";
906 if (Region) {
907 os << " of memory pointed to by '";
908 Region->dumpPretty(os);
909 os <<'\'';
910 }
911
912 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000913 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +0000914 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +0000915 C.EmitReport(R);
916}
917
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000918void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
919 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000920{
Zhongxing Xu173ff562010-08-15 08:19:57 +0000921 if (!SymReaper.hasDeadSymbols())
922 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000923
Ted Kremenek8bef8232012-01-26 21:29:00 +0000924 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000925 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +0000926 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000927
Ted Kremenek217470e2011-07-28 23:07:51 +0000928 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +0000929 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +0000930 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
931 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +0000932 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +0000933 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +0000934 Errors.push_back(I->first);
935 }
Jordy Rose90760142010-08-18 04:33:47 +0000936 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +0000937 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +0000938
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000939 }
940 }
Ted Kremenek217470e2011-07-28 23:07:51 +0000941
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000942 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +0000943 ReallocMap RP = state->get<ReallocPairs>();
944 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
945 if (SymReaper.isDead(I->first) ||
946 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000947 state = state->remove<ReallocPairs>(I->first);
948 }
949 }
950
Anna Zaksca8e36e2012-02-23 21:38:21 +0000951 // Generate leak node.
952 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
953 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +0000954
Anna Zaksca8e36e2012-02-23 21:38:21 +0000955 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +0000956 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +0000957 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
958 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +0000959 }
Ted Kremenek217470e2011-07-28 23:07:51 +0000960 }
Anna Zaksca8e36e2012-02-23 21:38:21 +0000961 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +0000962}
Zhongxing Xu243fde92009-11-17 07:54:15 +0000963
Anna Zaksda046772012-02-11 21:02:40 +0000964void MallocChecker::checkEndPath(CheckerContext &C) const {
965 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +0000966 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +0000967
Anna Zaksa19581a2012-02-20 22:25:23 +0000968 // If inside inlined call, skip it.
969 if (C.getLocationContext()->getParent() != 0)
970 return;
971
Jordy Rose09cef092010-08-18 04:26:59 +0000972 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000973 RefState RS = I->second;
974 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +0000975 ExplodedNode *N = C.addTransition(state);
976 if (N)
977 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +0000978 }
979 }
980}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000981
Anna Zaks91c2a112012-02-08 23:16:56 +0000982bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S,
983 CheckerContext &C) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +0000984 ProgramStateRef state = C.getState();
Anna Zaks91c2a112012-02-08 23:16:56 +0000985 const RefState *RS = state->get<RegionState>(Sym);
986 if (!RS)
987 return false;
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000988
Anna Zaks91c2a112012-02-08 23:16:56 +0000989 if (RS->isAllocated()) {
990 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
991 C.addTransition(state);
992 return true;
993 }
994 return false;
995}
996
Anna Zaks66c40402012-02-14 21:55:24 +0000997void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
998 if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext()))
999 return;
1000
1001 // Check use after free, when a freed pointer is passed to a call.
1002 ProgramStateRef State = C.getState();
1003 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1004 E = CE->arg_end(); I != E; ++I) {
1005 const Expr *A = *I;
1006 if (A->getType().getTypePtr()->isAnyPointerType()) {
1007 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1008 if (!Sym)
1009 continue;
1010 if (checkUseAfterFree(Sym, C, A))
1011 return;
1012 }
1013 }
1014}
1015
Anna Zaks91c2a112012-02-08 23:16:56 +00001016void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1017 const Expr *E = S->getRetValue();
1018 if (!E)
1019 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001020
1021 // Check if we are returning a symbol.
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001022 SVal RetVal = C.getState()->getSVal(E, C.getLocationContext());
1023 SymbolRef Sym = RetVal.getAsSymbol();
1024 if (!Sym)
1025 // If we are returning a field of the allocated struct or an array element,
1026 // the callee could still free the memory.
1027 // TODO: This logic should be a part of generic symbol escape callback.
1028 if (const MemRegion *MR = RetVal.getAsRegion())
1029 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1030 if (const SymbolicRegion *BMR =
1031 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1032 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001033 if (!Sym)
1034 return;
1035
Anna Zaks0860cd02012-02-11 21:44:39 +00001036 // Check if we are returning freed memory.
Anna Zaksfe571602012-02-16 22:26:07 +00001037 if (checkUseAfterFree(Sym, C, E))
Anna Zaks15d0ae12012-02-11 23:46:36 +00001038 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001039
Anna Zaksa19581a2012-02-20 22:25:23 +00001040 // If this function body is not inlined, check if the symbol is escaping.
1041 if (C.getLocationContext()->getParent() == 0)
1042 checkEscape(Sym, E, C);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001043}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001044
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001045// TODO: Blocks should be either inlined or should call invalidate regions
1046// upon invocation. After that's in place, special casing here will not be
1047// needed.
1048void MallocChecker::checkPostStmt(const BlockExpr *BE,
1049 CheckerContext &C) const {
1050
1051 // Scan the BlockDecRefExprs for any object the retain count checker
1052 // may be tracking.
1053 if (!BE->getBlockDecl()->hasCaptures())
1054 return;
1055
1056 ProgramStateRef state = C.getState();
1057 const BlockDataRegion *R =
1058 cast<BlockDataRegion>(state->getSVal(BE,
1059 C.getLocationContext()).getAsRegion());
1060
1061 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1062 E = R->referenced_vars_end();
1063
1064 if (I == E)
1065 return;
1066
1067 SmallVector<const MemRegion*, 10> Regions;
1068 const LocationContext *LC = C.getLocationContext();
1069 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1070
1071 for ( ; I != E; ++I) {
1072 const VarRegion *VR = *I;
1073 if (VR->getSuperRegion() == R) {
1074 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1075 }
1076 Regions.push_back(VR);
1077 }
1078
1079 state =
1080 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1081 Regions.data() + Regions.size()).getState();
1082 C.addTransition(state);
1083}
1084
Anna Zaks91c2a112012-02-08 23:16:56 +00001085bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1086 const Stmt *S) const {
1087 assert(Sym);
1088 const RefState *RS = C.getState()->get<RegionState>(Sym);
1089 if (RS && RS->isReleased()) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001090 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001091 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001092 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001093
Anna Zaksfebdc322012-02-16 22:26:12 +00001094 BugReport *R = new BugReport(*BT_UseFree,
1095 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001096 if (S)
1097 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001098 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001099 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001100 C.EmitReport(R);
1101 return true;
1102 }
1103 }
1104 return false;
1105}
1106
Zhongxing Xuc8023782010-03-10 04:58:55 +00001107// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001108void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1109 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001110 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001111 if (Sym)
1112 checkUseAfterFree(Sym, C);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001113}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001114
Anna Zaks4fb54872012-02-11 21:02:35 +00001115//===----------------------------------------------------------------------===//
1116// Check various ways a symbol can be invalidated.
1117// TODO: This logic (the next 3 functions) is copied/similar to the
1118// RetainRelease checker. We might want to factor this out.
1119//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001120
Anna Zaks4fb54872012-02-11 21:02:35 +00001121// Stop tracking symbols when a value escapes as a result of checkBind.
1122// A value escapes in three possible cases:
1123// (1) we are binding to something that is not a memory region.
1124// (2) we are binding to a memregion that does not have stack storage
1125// (3) we are binding to a memregion with stack storage that the store
1126// does not understand.
1127void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1128 CheckerContext &C) const {
1129 // Are we storing to something that causes the value to "escape"?
1130 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001131 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001132
Anna Zaks4fb54872012-02-11 21:02:35 +00001133 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1134 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001135
Anna Zaks4fb54872012-02-11 21:02:35 +00001136 if (!escapes) {
1137 // To test (3), generate a new state with the binding added. If it is
1138 // the same state, then it escapes (since the store cannot represent
1139 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001140 // Do this only if we know that the store is not supposed to generate the
1141 // same state.
1142 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1143 if (StoredVal != val)
1144 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001145 }
Anna Zaksac593002012-02-16 03:40:57 +00001146 if (!escapes) {
1147 // Case 4: We do not currently model what happens when a symbol is
1148 // assigned to a struct field, so be conservative here and let the symbol
1149 // go. TODO: This could definitely be improved upon.
1150 escapes = !isa<VarRegion>(regionLoc->getRegion());
1151 }
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001152 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001153
1154 // If our store can represent the binding and we aren't storing to something
1155 // that doesn't have local storage then just return and have the simulation
1156 // state continue as is.
1157 if (!escapes)
1158 return;
1159
1160 // Otherwise, find all symbols referenced by 'val' that we are tracking
1161 // and stop tracking them.
1162 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1163 C.addTransition(state);
1164}
1165
1166// If a symbolic region is assumed to NULL (or another constant), stop tracking
1167// it - assuming that allocation failed on this path.
1168ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1169 SVal Cond,
1170 bool Assumption) const {
1171 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001172 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1173 // If the symbol is assumed to NULL or another constant, this will
1174 // return an APSInt*.
1175 if (state->getSymVal(I.getKey()))
1176 state = state->remove<RegionState>(I.getKey());
1177 }
1178
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001179 // Realloc returns 0 when reallocation fails, which means that we should
1180 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001181 ReallocMap RP = state->get<ReallocPairs>();
1182 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001183 // If the symbol is assumed to NULL or another constant, this will
1184 // return an APSInt*.
1185 if (state->getSymVal(I.getKey())) {
Anna Zaks40add292012-02-15 00:11:25 +00001186 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1187 const RefState *RS = state->get<RegionState>(ReallocSym);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001188 if (RS) {
Anna Zaks40add292012-02-15 00:11:25 +00001189 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1190 state = state->set<RegionState>(ReallocSym,
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001191 RefState::getAllocateUnchecked(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001192 }
1193 state = state->remove<ReallocPairs>(I.getKey());
1194 }
1195 }
1196
Anna Zaks4fb54872012-02-11 21:02:35 +00001197 return state;
1198}
1199
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001200// Check if the function is known to us. So, for example, we could
Anna Zaks66c40402012-02-14 21:55:24 +00001201// conservatively assume it can free/reallocate it's pointer arguments.
1202// (We assume that the pointers cannot escape through calls to system
1203// functions not handled by this checker.)
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001204bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call,
1205 ProgramStateRef State) const {
1206 if (!Call)
1207 return false;
1208
1209 // For now, assume that any C++ call can free memory.
1210 // TODO: If we want to be more optimistic here, we'll need to make sure that
1211 // regions escape to C++ containers. They seem to do that even now, but for
1212 // mysterious reasons.
1213 if (Call->isCXXCall())
1214 return false;
1215
1216 const Decl *D = Call->getDecl();
1217 if (!D)
1218 return false;
1219
Anna Zaks66c40402012-02-14 21:55:24 +00001220 ASTContext &ASTC = State->getStateManager().getContext();
1221
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001222 // If it's one of the allocation functions we can reason about, we model
Jordy Rose257c60f2012-03-06 00:28:20 +00001223 // its behavior explicitly.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001224 if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) {
1225 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001226 }
1227
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001228 // If it's not a system call, assume it frees memory.
Anna Zaks66c40402012-02-14 21:55:24 +00001229 SourceManager &SM = ASTC.getSourceManager();
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001230 if (!SM.isInSystemHeader(D->getLocation()))
1231 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001232
Anna Zaks07d39a42012-02-28 01:54:22 +00001233 // Process C/ObjC functions.
Jordy Rose257c60f2012-03-06 00:28:20 +00001234 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
Anna Zaks0d389b82012-02-23 01:05:27 +00001235 // White list the system functions whose arguments escape.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001236 const IdentifierInfo *II = FD->getIdentifier();
Anna Zaks07d39a42012-02-28 01:54:22 +00001237 if (!II)
1238 return true;
1239 StringRef FName = II->getName();
1240
1241 // White list thread local storage.
1242 if (FName.equals("pthread_setspecific"))
1243 return false;
1244
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001245 // White list the 'XXXNoCopy' ObjC functions.
Anna Zaks07d39a42012-02-28 01:54:22 +00001246 if (FName.endswith("NoCopy")) {
1247 // Look for the deallocator argument. We know that the memory ownership
1248 // is not transfered only if the deallocator argument is
1249 // 'kCFAllocatorNull'.
1250 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1251 const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts();
1252 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1253 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1254 if (DeallocatorName == "kCFAllocatorNull")
1255 return true;
1256 }
1257 }
1258 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001259 }
1260
Anna Zaksca23eb22012-02-29 18:42:47 +00001261 // PR12101
1262 // Many CoreFoundation and CoreGraphics might allow a tracked object
1263 // to escape.
1264 if (Call->isCFCGAllowingEscape(FName))
1265 return false;
1266
1267 // Associating streams with malloced buffers. The pointer can escape if
1268 // 'closefn' is specified (and if that function does free memory).
1269 // Currently, we do not inspect the 'closefn' function (PR12101).
1270 if (FName == "funopen")
1271 if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0))
1272 return false;
1273
1274 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1275 // these leaks might be intentional when setting the buffer for stdio.
1276 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1277 if (FName == "setbuf" || FName =="setbuffer" ||
1278 FName == "setlinebuf" || FName == "setvbuf") {
1279 if (Call->getNumArgs() >= 1)
1280 if (const DeclRefExpr *Arg =
1281 dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts()))
1282 if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl()))
1283 if (D->getCanonicalDecl()->getName().find("std")
1284 != StringRef::npos)
1285 return false;
1286 }
1287
1288 // A bunch of other functions, which take ownership of a pointer (See retain
1289 // release checker). Not all the parameters here are invalidated, but the
1290 // Malloc checker cannot differentiate between them. The right way of doing
1291 // this would be to implement a pointer escapes callback.
1292 if (FName == "CVPixelBufferCreateWithBytes" ||
1293 FName == "CGBitmapContextCreateWithData" ||
Anna Zaks4cd7edf2012-03-26 18:18:39 +00001294 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1295 FName == "OSAtomicEnqueue") {
Anna Zaksca23eb22012-02-29 18:42:47 +00001296 return false;
1297 }
1298
Anna Zaks62a5c342012-03-30 05:48:16 +00001299 // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
1300 // be deallocated by NSMapRemove.
1301 if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos))
1302 return false;
1303
Anna Zaksaca0ac52012-05-03 23:50:28 +00001304 // If the call has a callback as an argument, assume the memory
1305 // can be freed.
1306 if (Call->hasNonZeroCallbackArg())
1307 return false;
1308
Anna Zaks0d389b82012-02-23 01:05:27 +00001309 // Otherwise, assume that the function does not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001310 // Most system calls, do not free the memory.
1311 return true;
1312
1313 // Process ObjC functions.
1314 } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) {
1315 Selector S = ObjCD->getSelector();
1316
1317 // White list the ObjC functions which do free memory.
1318 // - Anything containing 'freeWhenDone' param set to 1.
1319 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
1320 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
1321 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1322 if (Call->getArgSVal(i).isConstant(1))
1323 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001324 else
1325 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001326 }
1327 }
1328
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001329 // If the first selector ends with NoCopy, assume that the ownership is
1330 // transfered as well.
1331 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
1332 if (S.getNameForSlot(0).endswith("NoCopy")) {
1333 return false;
1334 }
1335
Anna Zaksaca0ac52012-05-03 23:50:28 +00001336 // If the call has a callback as an argument, assume the memory
1337 // can be freed.
1338 if (Call->hasNonZeroCallbackArg())
1339 return false;
1340
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001341 // Otherwise, assume that the function does not free memory.
1342 // Most system calls, do not free the memory.
1343 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001344 }
1345
1346 // Otherwise, assume that the function can free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001347 return false;
1348
Anna Zaks66c40402012-02-14 21:55:24 +00001349}
1350
Anna Zaks4fb54872012-02-11 21:02:35 +00001351// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1352// escapes, when we are tracking p), do not track the symbol as we cannot reason
1353// about it anymore.
1354ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001355MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001356 const StoreManager::InvalidatedSymbols *invalidated,
1357 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001358 ArrayRef<const MemRegion *> Regions,
1359 const CallOrObjCMessage *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001360 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001361 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001362 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001363
Anna Zaks66c40402012-02-14 21:55:24 +00001364 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001365 // regions (explicit and implicit) escaped.
1366
1367 // Otherwise, whitelist explicit pointers; we still can track them.
1368 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001369 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1370 E = ExplicitRegions.end(); I != E; ++I) {
1371 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1372 WhitelistedSymbols.insert(R->getSymbol());
1373 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001374 }
1375
1376 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1377 E = invalidated->end(); I!=E; ++I) {
1378 SymbolRef sym = *I;
1379 if (WhitelistedSymbols.count(sym))
1380 continue;
Anna Zaks66c40402012-02-14 21:55:24 +00001381 // The symbol escaped.
1382 if (const RefState *RS = State->get<RegionState>(sym))
1383 State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt()));
Anna Zaks4fb54872012-02-11 21:02:35 +00001384 }
Anna Zaks66c40402012-02-14 21:55:24 +00001385 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001386}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001387
Jordy Rose393f98b2012-03-18 07:43:35 +00001388static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1389 ProgramStateRef prevState) {
1390 ReallocMap currMap = currState->get<ReallocPairs>();
1391 ReallocMap prevMap = prevState->get<ReallocPairs>();
1392
1393 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1394 I != E; ++I) {
1395 SymbolRef sym = I.getKey();
1396 if (!currMap.lookup(sym))
1397 return sym;
1398 }
1399
1400 return NULL;
1401}
1402
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001403PathDiagnosticPiece *
1404MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1405 const ExplodedNode *PrevN,
1406 BugReporterContext &BRC,
1407 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001408 ProgramStateRef state = N->getState();
1409 ProgramStateRef statePrev = PrevN->getState();
1410
1411 const RefState *RS = state->get<RegionState>(Sym);
1412 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001413 if (!RS && !RSPrev)
1414 return 0;
1415
Anna Zaksfe571602012-02-16 22:26:07 +00001416 const Stmt *S = 0;
1417 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001418 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001419
1420 // Retrieve the associated statement.
1421 ProgramPoint ProgLoc = N->getLocation();
1422 if (isa<StmtPoint>(ProgLoc))
1423 S = cast<StmtPoint>(ProgLoc).getStmt();
1424 // If an assumption was made on a branch, it should be caught
1425 // here by looking at the state transition.
1426 if (isa<BlockEdge>(ProgLoc)) {
1427 const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc();
1428 S = srcBlk->getTerminator();
1429 }
1430 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001431 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001432
1433 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001434 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001435 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001436 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001437 StackHint = new StackHintGeneratorForSymbol(Sym,
1438 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001439 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001440 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001441 StackHint = new StackHintGeneratorForSymbol(Sym,
1442 "Returned released memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001443 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001444 Mode = ReallocationFailed;
1445 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001446 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001447 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001448
Jordy Roseb000fb52012-03-24 03:15:09 +00001449 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1450 // Is it possible to fail two reallocs WITHOUT testing in between?
1451 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1452 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001453 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001454 FailedReallocSymbol = sym;
1455 }
Anna Zaksfe571602012-02-16 22:26:07 +00001456 }
1457
1458 // We are in a special mode if a reallocation failed later in the path.
1459 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001460 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001461
Jordy Roseb000fb52012-03-24 03:15:09 +00001462 // Is this is the first appearance of the reallocated symbol?
1463 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
1464 // If we ever hit this assert, that means BugReporter has decided to skip
1465 // node pairs or visit them out of order.
1466 assert(state->get<RegionState>(FailedReallocSymbol) &&
1467 "Missed the reallocation point");
1468
1469 // We're at the reallocation point.
1470 Msg = "Attempt to reallocate memory";
1471 StackHint = new StackHintGeneratorForSymbol(Sym,
1472 "Returned reallocated memory");
1473 FailedReallocSymbol = NULL;
1474 Mode = Normal;
1475 }
Anna Zaksfe571602012-02-16 22:26:07 +00001476 }
1477
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001478 if (!Msg)
1479 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001480 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001481
1482 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001483 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001484 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001485 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001486}
1487
Anna Zaks93c5a242012-05-02 00:05:20 +00001488void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1489 const char *NL, const char *Sep) const {
1490
1491 RegionStateTy RS = State->get<RegionState>();
1492
1493 if (!RS.isEmpty())
1494 Out << "Has Malloc data" << NL;
1495}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001496
Anna Zaks231361a2012-02-08 23:16:52 +00001497#define REGISTER_CHECKER(name) \
1498void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001499 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001500 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001501}
Anna Zaks231361a2012-02-08 23:16:52 +00001502
1503REGISTER_CHECKER(MallocPessimistic)
1504REGISTER_CHECKER(MallocOptimistic)