Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1 | //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 0bc735f | 2007-12-29 19:59:25 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 10 | // This file implements extra semantic analysis beyond what is enforced |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 11 | // by the C type system. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Douglas Gregor | e737f50 | 2010-08-12 20:07:10 +0000 | [diff] [blame] | 15 | #include "clang/Sema/Sema.h" |
John McCall | 2d88708 | 2010-08-25 22:03:47 +0000 | [diff] [blame] | 16 | #include "clang/Sema/SemaInternal.h" |
John McCall | 781472f | 2010-08-25 08:40:02 +0000 | [diff] [blame] | 17 | #include "clang/Sema/ScopeInfo.h" |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 18 | #include "clang/Analysis/Analyses/FormatString.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 19 | #include "clang/AST/ASTContext.h" |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 20 | #include "clang/AST/CharUnits.h" |
John McCall | 384aff8 | 2010-08-25 07:42:41 +0000 | [diff] [blame] | 21 | #include "clang/AST/DeclCXX.h" |
Daniel Dunbar | c4a1dea | 2008-08-11 05:35:13 +0000 | [diff] [blame] | 22 | #include "clang/AST/DeclObjC.h" |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 23 | #include "clang/AST/ExprCXX.h" |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 24 | #include "clang/AST/ExprObjC.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 25 | #include "clang/AST/DeclObjC.h" |
| 26 | #include "clang/AST/StmtCXX.h" |
| 27 | #include "clang/AST/StmtObjC.h" |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 28 | #include "clang/Lex/LiteralSupport.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 29 | #include "clang/Lex/Preprocessor.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 30 | #include "llvm/ADT/BitVector.h" |
| 31 | #include "llvm/ADT/STLExtras.h" |
Tom Care | 3bfc5f4 | 2010-06-09 04:11:11 +0000 | [diff] [blame] | 32 | #include "llvm/Support/raw_ostream.h" |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 33 | #include "clang/Basic/TargetBuiltins.h" |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 34 | #include "clang/Basic/TargetInfo.h" |
Fariborz Jahanian | 7da7102 | 2010-09-07 19:38:13 +0000 | [diff] [blame] | 35 | #include "clang/Basic/ConvertUTF.h" |
| 36 | |
Zhongxing Xu | a1f3dba | 2009-05-20 01:55:10 +0000 | [diff] [blame] | 37 | #include <limits> |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 38 | using namespace clang; |
John McCall | 781472f | 2010-08-25 08:40:02 +0000 | [diff] [blame] | 39 | using namespace sema; |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 40 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 41 | /// getLocationOfStringLiteralByte - Return a source location that points to the |
| 42 | /// specified byte of the specified string literal. |
| 43 | /// |
| 44 | /// Strings are amazingly complex. They can be formed from multiple tokens and |
| 45 | /// can have escape sequences in them in addition to the usual trigraph and |
| 46 | /// escaped newline business. This routine handles this complexity. |
| 47 | /// |
| 48 | SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, |
| 49 | unsigned ByteNo) const { |
| 50 | assert(!SL->isWide() && "This doesn't work for wide strings yet"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 51 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 52 | // Loop over all of the tokens in this string until we find the one that |
| 53 | // contains the byte we're looking for. |
| 54 | unsigned TokNo = 0; |
| 55 | while (1) { |
| 56 | assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!"); |
| 57 | SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 58 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 59 | // Get the spelling of the string so that we can get the data that makes up |
| 60 | // the string literal, not the identifier for the macro it is potentially |
| 61 | // expanded through. |
| 62 | SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc); |
| 63 | |
| 64 | // Re-lex the token to get its length and original spelling. |
| 65 | std::pair<FileID, unsigned> LocInfo = |
| 66 | SourceMgr.getDecomposedLoc(StrTokSpellingLoc); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 67 | bool Invalid = false; |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 68 | llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 69 | if (Invalid) |
Douglas Gregor | aea67db | 2010-03-15 22:54:52 +0000 | [diff] [blame] | 70 | return StrTokSpellingLoc; |
| 71 | |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 72 | const char *StrData = Buffer.data()+LocInfo.second; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 73 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 74 | // Create a langops struct and enable trigraphs. This is sufficient for |
| 75 | // relexing tokens. |
| 76 | LangOptions LangOpts; |
| 77 | LangOpts.Trigraphs = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 78 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 79 | // Create a lexer starting at the beginning of this token. |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 80 | Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData, |
| 81 | Buffer.end()); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 82 | Token TheTok; |
| 83 | TheLexer.LexFromRawLexer(TheTok); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 84 | |
Chris Lattner | 443e53c | 2009-02-18 19:26:42 +0000 | [diff] [blame] | 85 | // Use the StringLiteralParser to compute the length of the string in bytes. |
Douglas Gregor | b90f4b3 | 2010-05-26 05:35:51 +0000 | [diff] [blame] | 86 | StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false); |
Chris Lattner | 443e53c | 2009-02-18 19:26:42 +0000 | [diff] [blame] | 87 | unsigned TokNumBytes = SLP.GetStringLength(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 88 | |
Chris Lattner | 2197c96 | 2009-02-18 18:52:52 +0000 | [diff] [blame] | 89 | // If the byte is in this token, return the location of the byte. |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 90 | if (ByteNo < TokNumBytes || |
| 91 | (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 92 | unsigned Offset = |
Douglas Gregor | b90f4b3 | 2010-05-26 05:35:51 +0000 | [diff] [blame] | 93 | StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP, |
| 94 | /*Complain=*/false); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 95 | |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 96 | // Now that we know the offset of the token in the spelling, use the |
| 97 | // preprocessor to get the offset in the original source. |
| 98 | return PP.AdvanceToTokenCharacter(StrTokLoc, Offset); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 99 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 100 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 101 | // Move to the next string token. |
| 102 | ++TokNo; |
| 103 | ByteNo -= TokNumBytes; |
| 104 | } |
| 105 | } |
| 106 | |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 107 | /// CheckablePrintfAttr - does a function call have a "printf" attribute |
| 108 | /// and arguments that merit checking? |
| 109 | bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { |
| 110 | if (Format->getType() == "printf") return true; |
| 111 | if (Format->getType() == "printf0") { |
| 112 | // printf0 allows null "format" string; if so don't check format/args |
| 113 | unsigned format_idx = Format->getFormatIdx() - 1; |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 114 | // Does the index refer to the implicit object argument? |
| 115 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 116 | if (format_idx == 0) |
| 117 | return false; |
| 118 | --format_idx; |
| 119 | } |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 120 | if (format_idx < TheCall->getNumArgs()) { |
| 121 | Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 122 | if (!Format->isNullPointerConstant(Context, |
| 123 | Expr::NPC_ValueDependentIsNull)) |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 124 | return true; |
| 125 | } |
| 126 | } |
| 127 | return false; |
| 128 | } |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 129 | |
John McCall | 60d7b3a | 2010-08-24 06:29:42 +0000 | [diff] [blame] | 130 | ExprResult |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 131 | Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
John McCall | 60d7b3a | 2010-08-24 06:29:42 +0000 | [diff] [blame] | 132 | ExprResult TheCallResult(Owned(TheCall)); |
Douglas Gregor | 2def483 | 2008-11-17 20:34:05 +0000 | [diff] [blame] | 133 | |
Chris Lattner | 946928f | 2010-10-01 23:23:24 +0000 | [diff] [blame] | 134 | // Find out if any arguments are required to be integer constant expressions. |
| 135 | unsigned ICEArguments = 0; |
| 136 | ASTContext::GetBuiltinTypeError Error; |
| 137 | Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); |
| 138 | if (Error != ASTContext::GE_None) |
| 139 | ICEArguments = 0; // Don't diagnose previously diagnosed errors. |
| 140 | |
| 141 | // If any arguments are required to be ICE's, check and diagnose. |
| 142 | for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { |
| 143 | // Skip arguments not required to be ICE's. |
| 144 | if ((ICEArguments & (1 << ArgNo)) == 0) continue; |
| 145 | |
| 146 | llvm::APSInt Result; |
| 147 | if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) |
| 148 | return true; |
| 149 | ICEArguments &= ~(1 << ArgNo); |
| 150 | } |
| 151 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 152 | switch (BuiltinID) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 153 | case Builtin::BI__builtin___CFStringMakeConstantString: |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 154 | assert(TheCall->getNumArgs() == 1 && |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 155 | "Wrong # arguments to builtin CFStringMakeConstantString"); |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 156 | if (CheckObjCString(TheCall->getArg(0))) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 157 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 158 | break; |
Ted Kremenek | 49ff7a1 | 2008-07-09 17:58:53 +0000 | [diff] [blame] | 159 | case Builtin::BI__builtin_stdarg_start: |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 160 | case Builtin::BI__builtin_va_start: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 161 | if (SemaBuiltinVAStart(TheCall)) |
| 162 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 163 | break; |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 164 | case Builtin::BI__builtin_isgreater: |
| 165 | case Builtin::BI__builtin_isgreaterequal: |
| 166 | case Builtin::BI__builtin_isless: |
| 167 | case Builtin::BI__builtin_islessequal: |
| 168 | case Builtin::BI__builtin_islessgreater: |
| 169 | case Builtin::BI__builtin_isunordered: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 170 | if (SemaBuiltinUnorderedCompare(TheCall)) |
| 171 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 172 | break; |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 173 | case Builtin::BI__builtin_fpclassify: |
| 174 | if (SemaBuiltinFPClassification(TheCall, 6)) |
| 175 | return ExprError(); |
| 176 | break; |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 177 | case Builtin::BI__builtin_isfinite: |
| 178 | case Builtin::BI__builtin_isinf: |
| 179 | case Builtin::BI__builtin_isinf_sign: |
| 180 | case Builtin::BI__builtin_isnan: |
| 181 | case Builtin::BI__builtin_isnormal: |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 182 | if (SemaBuiltinFPClassification(TheCall, 1)) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 183 | return ExprError(); |
| 184 | break; |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 185 | case Builtin::BI__builtin_shufflevector: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 186 | return SemaBuiltinShuffleVector(TheCall); |
| 187 | // TheCall will be freed by the smart pointer here, but that's fine, since |
| 188 | // SemaBuiltinShuffleVector guts it, but then doesn't release it. |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 189 | case Builtin::BI__builtin_prefetch: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 190 | if (SemaBuiltinPrefetch(TheCall)) |
| 191 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 192 | break; |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 193 | case Builtin::BI__builtin_object_size: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 194 | if (SemaBuiltinObjectSize(TheCall)) |
| 195 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 196 | break; |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 197 | case Builtin::BI__builtin_longjmp: |
| 198 | if (SemaBuiltinLongjmp(TheCall)) |
| 199 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 200 | break; |
Chris Lattner | 75c29a0 | 2010-10-12 17:47:42 +0000 | [diff] [blame] | 201 | case Builtin::BI__builtin_constant_p: |
| 202 | if (TheCall->getNumArgs() == 0) |
| 203 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
| 204 | << 0 /*function call*/ << 1 << 0 << TheCall->getSourceRange(); |
| 205 | if (TheCall->getNumArgs() > 1) |
| 206 | return Diag(TheCall->getArg(1)->getLocStart(), |
| 207 | diag::err_typecheck_call_too_many_args) |
| 208 | << 0 /*function call*/ << 1 << TheCall->getNumArgs() |
| 209 | << TheCall->getArg(1)->getSourceRange(); |
| 210 | break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 211 | case Builtin::BI__sync_fetch_and_add: |
| 212 | case Builtin::BI__sync_fetch_and_sub: |
| 213 | case Builtin::BI__sync_fetch_and_or: |
| 214 | case Builtin::BI__sync_fetch_and_and: |
| 215 | case Builtin::BI__sync_fetch_and_xor: |
| 216 | case Builtin::BI__sync_add_and_fetch: |
| 217 | case Builtin::BI__sync_sub_and_fetch: |
| 218 | case Builtin::BI__sync_and_and_fetch: |
| 219 | case Builtin::BI__sync_or_and_fetch: |
| 220 | case Builtin::BI__sync_xor_and_fetch: |
| 221 | case Builtin::BI__sync_val_compare_and_swap: |
| 222 | case Builtin::BI__sync_bool_compare_and_swap: |
| 223 | case Builtin::BI__sync_lock_test_and_set: |
| 224 | case Builtin::BI__sync_lock_release: |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 225 | return SemaBuiltinAtomicOverloaded(move(TheCallResult)); |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 226 | } |
| 227 | |
| 228 | // Since the target specific builtins for each arch overlap, only check those |
| 229 | // of the arch we are compiling for. |
| 230 | if (BuiltinID >= Builtin::FirstTSBuiltin) { |
| 231 | switch (Context.Target.getTriple().getArch()) { |
| 232 | case llvm::Triple::arm: |
| 233 | case llvm::Triple::thumb: |
| 234 | if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) |
| 235 | return ExprError(); |
| 236 | break; |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 237 | default: |
| 238 | break; |
| 239 | } |
| 240 | } |
| 241 | |
| 242 | return move(TheCallResult); |
| 243 | } |
| 244 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 245 | // Get the valid immediate range for the specified NEON type code. |
| 246 | static unsigned RFT(unsigned t, bool shift = false) { |
| 247 | bool quad = t & 0x10; |
| 248 | |
| 249 | switch (t & 0x7) { |
| 250 | case 0: // i8 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 251 | return shift ? 7 : (8 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 252 | case 1: // i16 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 253 | return shift ? 15 : (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 254 | case 2: // i32 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 255 | return shift ? 31 : (2 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 256 | case 3: // i64 |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 257 | return shift ? 63 : (1 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 258 | case 4: // f32 |
| 259 | assert(!shift && "cannot shift float types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 260 | return (2 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 261 | case 5: // poly8 |
| 262 | assert(!shift && "cannot shift polynomial types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 263 | return (8 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 264 | case 6: // poly16 |
| 265 | assert(!shift && "cannot shift polynomial types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 266 | return (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 267 | case 7: // float16 |
| 268 | assert(!shift && "cannot shift float types!"); |
Nate Begeman | d69ec16 | 2010-06-17 02:26:59 +0000 | [diff] [blame] | 269 | return (4 << (int)quad) - 1; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 270 | } |
| 271 | return 0; |
| 272 | } |
| 273 | |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 274 | bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 275 | llvm::APSInt Result; |
| 276 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 277 | unsigned mask = 0; |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 278 | unsigned TV = 0; |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 279 | switch (BuiltinID) { |
Nate Begeman | a23326b | 2010-06-17 04:17:01 +0000 | [diff] [blame] | 280 | #define GET_NEON_OVERLOAD_CHECK |
| 281 | #include "clang/Basic/arm_neon.inc" |
| 282 | #undef GET_NEON_OVERLOAD_CHECK |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 283 | } |
| 284 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 285 | // For NEON intrinsics which are overloaded on vector element type, validate |
| 286 | // the immediate which specifies which variant to emit. |
| 287 | if (mask) { |
| 288 | unsigned ArgNo = TheCall->getNumArgs()-1; |
| 289 | if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) |
| 290 | return true; |
| 291 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 292 | TV = Result.getLimitedValue(32); |
| 293 | if ((TV > 31) || (mask & (1 << TV)) == 0) |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 294 | return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) |
| 295 | << TheCall->getArg(ArgNo)->getSourceRange(); |
| 296 | } |
Nate Begeman | 1c2a88c | 2010-06-09 01:10:23 +0000 | [diff] [blame] | 297 | |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 298 | // For NEON intrinsics which take an immediate value as part of the |
| 299 | // instruction, range check them here. |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 300 | unsigned i = 0, l = 0, u = 0; |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 301 | switch (BuiltinID) { |
| 302 | default: return false; |
Nate Begeman | bb37f50 | 2010-07-29 22:48:34 +0000 | [diff] [blame] | 303 | case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; |
| 304 | case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; |
Nate Begeman | 99c40bb | 2010-08-03 21:32:34 +0000 | [diff] [blame] | 305 | case ARM::BI__builtin_arm_vcvtr_f: |
| 306 | case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; |
Nate Begeman | a23326b | 2010-06-17 04:17:01 +0000 | [diff] [blame] | 307 | #define GET_NEON_IMMEDIATE_CHECK |
| 308 | #include "clang/Basic/arm_neon.inc" |
| 309 | #undef GET_NEON_IMMEDIATE_CHECK |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 310 | }; |
| 311 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 312 | // Check that the immediate argument is actually a constant. |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 313 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 314 | return true; |
| 315 | |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 316 | // Range check against the upper/lower values for this isntruction. |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 317 | unsigned Val = Result.getZExtValue(); |
Nate Begeman | 61eecf5 | 2010-06-14 05:21:25 +0000 | [diff] [blame] | 318 | if (Val < l || Val > (u + l)) |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 319 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Benjamin Kramer | 476d8b8 | 2010-08-11 14:47:12 +0000 | [diff] [blame] | 320 | << l << u+l << TheCall->getArg(i)->getSourceRange(); |
Nate Begeman | 0d15c53 | 2010-06-13 04:47:52 +0000 | [diff] [blame] | 321 | |
Nate Begeman | 99c40bb | 2010-08-03 21:32:34 +0000 | [diff] [blame] | 322 | // FIXME: VFP Intrinsics should error if VFP not present. |
Nate Begeman | 26a3142 | 2010-06-08 02:47:44 +0000 | [diff] [blame] | 323 | return false; |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 324 | } |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 325 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 326 | /// CheckFunctionCall - Check a direct function call for various correctness |
| 327 | /// and safety properties not strictly enforced by the C type system. |
| 328 | bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { |
| 329 | // Get the IdentifierInfo* for the called function. |
| 330 | IdentifierInfo *FnInfo = FDecl->getIdentifier(); |
| 331 | |
| 332 | // None of the checks below are needed for functions that don't have |
| 333 | // simple names (e.g., C++ conversion functions). |
| 334 | if (!FnInfo) |
| 335 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 336 | |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 337 | // FIXME: This mechanism should be abstracted to be less fragile and |
| 338 | // more efficient. For example, just map function ids to custom |
| 339 | // handlers. |
| 340 | |
Ted Kremenek | c82faca | 2010-09-09 04:33:05 +0000 | [diff] [blame] | 341 | // Printf and scanf checking. |
| 342 | for (specific_attr_iterator<FormatAttr> |
| 343 | i = FDecl->specific_attr_begin<FormatAttr>(), |
| 344 | e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { |
| 345 | |
| 346 | const FormatAttr *Format = *i; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 347 | const bool b = Format->getType() == "scanf"; |
| 348 | if (b || CheckablePrintfAttr(Format, TheCall)) { |
Ted Kremenek | 3d692df | 2009-02-27 17:58:43 +0000 | [diff] [blame] | 349 | bool HasVAListArg = Format->getFirstArg() == 0; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 350 | CheckPrintfScanfArguments(TheCall, HasVAListArg, |
| 351 | Format->getFormatIdx() - 1, |
| 352 | HasVAListArg ? 0 : Format->getFirstArg() - 1, |
| 353 | !b); |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 354 | } |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 355 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 356 | |
Ted Kremenek | c82faca | 2010-09-09 04:33:05 +0000 | [diff] [blame] | 357 | for (specific_attr_iterator<NonNullAttr> |
| 358 | i = FDecl->specific_attr_begin<NonNullAttr>(), |
| 359 | e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 360 | CheckNonNullArguments(*i, TheCall); |
Ted Kremenek | c82faca | 2010-09-09 04:33:05 +0000 | [diff] [blame] | 361 | } |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 362 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 363 | return false; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 364 | } |
| 365 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 366 | bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 367 | // Printf checking. |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 368 | const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 369 | if (!Format) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 370 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 371 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 372 | const VarDecl *V = dyn_cast<VarDecl>(NDecl); |
| 373 | if (!V) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 374 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 375 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 376 | QualType Ty = V->getType(); |
| 377 | if (!Ty->isBlockPointerType()) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 378 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 379 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 380 | const bool b = Format->getType() == "scanf"; |
| 381 | if (!b && !CheckablePrintfAttr(Format, TheCall)) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 382 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 383 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 384 | bool HasVAListArg = Format->getFirstArg() == 0; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 385 | CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, |
| 386 | HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 387 | |
| 388 | return false; |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 389 | } |
| 390 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 391 | /// SemaBuiltinAtomicOverloaded - We have a call to a function like |
| 392 | /// __sync_fetch_and_add, which is an overloaded function based on the pointer |
| 393 | /// type of its first argument. The main ActOnCallExpr routines have already |
| 394 | /// promoted the types of arguments because all of these calls are prototyped as |
| 395 | /// void(...). |
| 396 | /// |
| 397 | /// This function goes through and does final semantic checking for these |
| 398 | /// builtins, |
John McCall | 60d7b3a | 2010-08-24 06:29:42 +0000 | [diff] [blame] | 399 | ExprResult |
| 400 | Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 401 | CallExpr *TheCall = (CallExpr *)TheCallResult.get(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 402 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 403 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 404 | |
| 405 | // Ensure that we have at least one argument to do type inference from. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 406 | if (TheCall->getNumArgs() < 1) { |
| 407 | Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) |
| 408 | << 0 << 1 << TheCall->getNumArgs() |
| 409 | << TheCall->getCallee()->getSourceRange(); |
| 410 | return ExprError(); |
| 411 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 412 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 413 | // Inspect the first argument of the atomic builtin. This should always be |
| 414 | // a pointer type, whose element is an integral scalar or pointer type. |
| 415 | // Because it is a pointer type, we don't have to worry about any implicit |
| 416 | // casts here. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 417 | // FIXME: We don't allow floating point scalars as input. |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 418 | Expr *FirstArg = TheCall->getArg(0); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 419 | if (!FirstArg->getType()->isPointerType()) { |
| 420 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) |
| 421 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 422 | return ExprError(); |
| 423 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 424 | |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 425 | QualType ValType = |
| 426 | FirstArg->getType()->getAs<PointerType>()->getPointeeType(); |
Chris Lattner | dd5fa7a | 2010-09-17 21:12:38 +0000 | [diff] [blame] | 427 | if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 428 | !ValType->isBlockPointerType()) { |
| 429 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) |
| 430 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 431 | return ExprError(); |
| 432 | } |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 433 | |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 434 | // The majority of builtins return a value, but a few have special return |
| 435 | // types, so allow them to override appropriately below. |
| 436 | QualType ResultType = ValType; |
| 437 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 438 | // We need to figure out which concrete builtin this maps onto. For example, |
| 439 | // __sync_fetch_and_add with a 2 byte object turns into |
| 440 | // __sync_fetch_and_add_2. |
| 441 | #define BUILTIN_ROW(x) \ |
| 442 | { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ |
| 443 | Builtin::BI##x##_8, Builtin::BI##x##_16 } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 444 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 445 | static const unsigned BuiltinIndices[][5] = { |
| 446 | BUILTIN_ROW(__sync_fetch_and_add), |
| 447 | BUILTIN_ROW(__sync_fetch_and_sub), |
| 448 | BUILTIN_ROW(__sync_fetch_and_or), |
| 449 | BUILTIN_ROW(__sync_fetch_and_and), |
| 450 | BUILTIN_ROW(__sync_fetch_and_xor), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 451 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 452 | BUILTIN_ROW(__sync_add_and_fetch), |
| 453 | BUILTIN_ROW(__sync_sub_and_fetch), |
| 454 | BUILTIN_ROW(__sync_and_and_fetch), |
| 455 | BUILTIN_ROW(__sync_or_and_fetch), |
| 456 | BUILTIN_ROW(__sync_xor_and_fetch), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 457 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 458 | BUILTIN_ROW(__sync_val_compare_and_swap), |
| 459 | BUILTIN_ROW(__sync_bool_compare_and_swap), |
| 460 | BUILTIN_ROW(__sync_lock_test_and_set), |
| 461 | BUILTIN_ROW(__sync_lock_release) |
| 462 | }; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 463 | #undef BUILTIN_ROW |
| 464 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 465 | // Determine the index of the size. |
| 466 | unsigned SizeIndex; |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 467 | switch (Context.getTypeSizeInChars(ValType).getQuantity()) { |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 468 | case 1: SizeIndex = 0; break; |
| 469 | case 2: SizeIndex = 1; break; |
| 470 | case 4: SizeIndex = 2; break; |
| 471 | case 8: SizeIndex = 3; break; |
| 472 | case 16: SizeIndex = 4; break; |
| 473 | default: |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 474 | Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) |
| 475 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 476 | return ExprError(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 477 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 478 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 479 | // Each of these builtins has one pointer argument, followed by some number of |
| 480 | // values (0, 1 or 2) followed by a potentially empty varags list of stuff |
| 481 | // that we ignore. Find out which row of BuiltinIndices to read from as well |
| 482 | // as the number of fixed args. |
Douglas Gregor | 7814e6d | 2009-09-12 00:22:50 +0000 | [diff] [blame] | 483 | unsigned BuiltinID = FDecl->getBuiltinID(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 484 | unsigned BuiltinIndex, NumFixed = 1; |
| 485 | switch (BuiltinID) { |
| 486 | default: assert(0 && "Unknown overloaded atomic builtin!"); |
| 487 | case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; |
| 488 | case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; |
| 489 | case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; |
| 490 | case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; |
| 491 | case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 492 | |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 493 | case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; |
| 494 | case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; |
| 495 | case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; |
| 496 | case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; |
| 497 | case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 498 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 499 | case Builtin::BI__sync_val_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 500 | BuiltinIndex = 10; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 501 | NumFixed = 2; |
| 502 | break; |
| 503 | case Builtin::BI__sync_bool_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 504 | BuiltinIndex = 11; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 505 | NumFixed = 2; |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 506 | ResultType = Context.BoolTy; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 507 | break; |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 508 | case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 509 | case Builtin::BI__sync_lock_release: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 510 | BuiltinIndex = 13; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 511 | NumFixed = 0; |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 512 | ResultType = Context.VoidTy; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 513 | break; |
| 514 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 515 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 516 | // Now that we know how many fixed arguments we expect, first check that we |
| 517 | // have at least that many. |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 518 | if (TheCall->getNumArgs() < 1+NumFixed) { |
| 519 | Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) |
| 520 | << 0 << 1+NumFixed << TheCall->getNumArgs() |
| 521 | << TheCall->getCallee()->getSourceRange(); |
| 522 | return ExprError(); |
| 523 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 524 | |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 525 | // Get the decl for the concrete builtin from this, we can tell what the |
| 526 | // concrete integer type we should convert to is. |
| 527 | unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; |
| 528 | const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); |
| 529 | IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 530 | FunctionDecl *NewBuiltinDecl = |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 531 | cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, |
| 532 | TUScope, false, DRE->getLocStart())); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 533 | |
John McCall | f871d0c | 2010-08-07 06:22:56 +0000 | [diff] [blame] | 534 | // The first argument --- the pointer --- has a fixed type; we |
| 535 | // deduce the types of the rest of the arguments accordingly. Walk |
| 536 | // the remaining arguments, converting them to the deduced value type. |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 537 | for (unsigned i = 0; i != NumFixed; ++i) { |
| 538 | Expr *Arg = TheCall->getArg(i+1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 539 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 540 | // If the argument is an implicit cast, then there was a promotion due to |
| 541 | // "...", just remove it now. |
| 542 | if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { |
| 543 | Arg = ICE->getSubExpr(); |
| 544 | ICE->setSubExpr(0); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 545 | TheCall->setArg(i+1, Arg); |
| 546 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 547 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 548 | // GCC does an implicit conversion to the pointer or integer ValType. This |
| 549 | // can fail in some cases (1i -> int**), check for this error case now. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 550 | CastKind Kind = CK_Unknown; |
John McCall | f871d0c | 2010-08-07 06:22:56 +0000 | [diff] [blame] | 551 | CXXCastPath BasePath; |
Anders Carlsson | 5cf86ba | 2010-04-24 19:06:50 +0000 | [diff] [blame] | 552 | if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath)) |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 553 | return ExprError(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 554 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 555 | // Okay, we have something that *can* be converted to the right type. Check |
| 556 | // to see if there is a potentially weird extension going on here. This can |
| 557 | // happen when you do an atomic operation on something like an char* and |
| 558 | // pass in 42. The 42 gets converted to char. This is even more strange |
| 559 | // for things like 45.123 -> char, etc. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 560 | // FIXME: Do this check. |
John McCall | 5baba9d | 2010-08-25 10:28:54 +0000 | [diff] [blame] | 561 | ImpCastExprToType(Arg, ValType, Kind, VK_RValue, &BasePath); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 562 | TheCall->setArg(i+1, Arg); |
| 563 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 564 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 565 | // Switch the DeclRefExpr to refer to the new decl. |
| 566 | DRE->setDecl(NewBuiltinDecl); |
| 567 | DRE->setType(NewBuiltinDecl->getType()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 568 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 569 | // Set the callee in the CallExpr. |
| 570 | // FIXME: This leaks the original parens and implicit casts. |
| 571 | Expr *PromotedCall = DRE; |
| 572 | UsualUnaryConversions(PromotedCall); |
| 573 | TheCall->setCallee(PromotedCall); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 574 | |
Chandler Carruth | db4325b | 2010-07-18 07:23:17 +0000 | [diff] [blame] | 575 | // Change the result type of the call to match the original value type. This |
| 576 | // is arbitrary, but the codegen for these builtins ins design to handle it |
| 577 | // gracefully. |
Chandler Carruth | 8d13d22 | 2010-07-18 20:54:12 +0000 | [diff] [blame] | 578 | TheCall->setType(ResultType); |
Chandler Carruth | d201457 | 2010-07-09 18:59:35 +0000 | [diff] [blame] | 579 | |
| 580 | return move(TheCallResult); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 581 | } |
| 582 | |
| 583 | |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 584 | /// CheckObjCString - Checks that the argument to the builtin |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 585 | /// CFString constructor is correct |
Steve Naroff | fd94262 | 2009-04-13 20:26:29 +0000 | [diff] [blame] | 586 | /// Note: It might also make sense to do the UTF-16 conversion here (would |
| 587 | /// simplify the backend). |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 588 | bool Sema::CheckObjCString(Expr *Arg) { |
Chris Lattner | 56f3494 | 2008-02-13 01:02:39 +0000 | [diff] [blame] | 589 | Arg = Arg->IgnoreParenCasts(); |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 590 | StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); |
| 591 | |
| 592 | if (!Literal || Literal->isWide()) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 593 | Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) |
| 594 | << Arg->getSourceRange(); |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 595 | return true; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 596 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 597 | |
Benjamin Kramer | 2f4eaef | 2010-08-17 12:54:38 +0000 | [diff] [blame] | 598 | size_t NulPos = Literal->getString().find('\0'); |
| 599 | if (NulPos != llvm::StringRef::npos) { |
| 600 | Diag(getLocationOfStringLiteralByte(Literal, NulPos), |
| 601 | diag::warn_cfstring_literal_contains_nul_character) |
| 602 | << Arg->getSourceRange(); |
Daniel Dunbar | f015b03 | 2009-09-22 10:03:52 +0000 | [diff] [blame] | 603 | } |
Fariborz Jahanian | 7da7102 | 2010-09-07 19:38:13 +0000 | [diff] [blame] | 604 | if (Literal->containsNonAsciiOrNull()) { |
| 605 | llvm::StringRef String = Literal->getString(); |
| 606 | unsigned NumBytes = String.size(); |
| 607 | llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); |
| 608 | const UTF8 *FromPtr = (UTF8 *)String.data(); |
| 609 | UTF16 *ToPtr = &ToBuf[0]; |
| 610 | |
| 611 | ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, |
| 612 | &ToPtr, ToPtr + NumBytes, |
| 613 | strictConversion); |
| 614 | // Check for conversion failure. |
| 615 | if (Result != conversionOK) |
| 616 | Diag(Arg->getLocStart(), |
| 617 | diag::warn_cfstring_truncated) << Arg->getSourceRange(); |
| 618 | } |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 619 | return false; |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 620 | } |
| 621 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 622 | /// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. |
| 623 | /// Emit an error and return true on failure, return false on success. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 624 | bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { |
| 625 | Expr *Fn = TheCall->getCallee(); |
| 626 | if (TheCall->getNumArgs() > 2) { |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 627 | Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 628 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 629 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
| 630 | << Fn->getSourceRange() |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 631 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 632 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 633 | return true; |
| 634 | } |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 635 | |
| 636 | if (TheCall->getNumArgs() < 2) { |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 637 | return Diag(TheCall->getLocEnd(), |
| 638 | diag::err_typecheck_call_too_few_args_at_least) |
| 639 | << 0 /*function call*/ << 2 << TheCall->getNumArgs(); |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 640 | } |
| 641 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 642 | // Determine whether the current function is variadic or not. |
Douglas Gregor | 9ea9bdb | 2010-03-01 23:15:13 +0000 | [diff] [blame] | 643 | BlockScopeInfo *CurBlock = getCurBlock(); |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 644 | bool isVariadic; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 645 | if (CurBlock) |
John McCall | c71a491 | 2010-06-04 19:02:56 +0000 | [diff] [blame] | 646 | isVariadic = CurBlock->TheDecl->isVariadic(); |
Ted Kremenek | 9498d38 | 2010-04-29 16:49:01 +0000 | [diff] [blame] | 647 | else if (FunctionDecl *FD = getCurFunctionDecl()) |
| 648 | isVariadic = FD->isVariadic(); |
| 649 | else |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 650 | isVariadic = getCurMethodDecl()->isVariadic(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 651 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 652 | if (!isVariadic) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 653 | Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); |
| 654 | return true; |
| 655 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 656 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 657 | // Verify that the second argument to the builtin is the last argument of the |
| 658 | // current function or method. |
| 659 | bool SecondArgIsLastNamedArgument = false; |
Anders Carlsson | e2c1410 | 2008-02-13 01:22:59 +0000 | [diff] [blame] | 660 | const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 661 | |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 662 | if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { |
| 663 | if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 664 | // FIXME: This isn't correct for methods (results in bogus warning). |
| 665 | // Get the last formal in the current function. |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 666 | const ParmVarDecl *LastArg; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 667 | if (CurBlock) |
| 668 | LastArg = *(CurBlock->TheDecl->param_end()-1); |
| 669 | else if (FunctionDecl *FD = getCurFunctionDecl()) |
Chris Lattner | 371f258 | 2008-12-04 23:50:19 +0000 | [diff] [blame] | 670 | LastArg = *(FD->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 671 | else |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 672 | LastArg = *(getCurMethodDecl()->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 673 | SecondArgIsLastNamedArgument = PV == LastArg; |
| 674 | } |
| 675 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 676 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 677 | if (!SecondArgIsLastNamedArgument) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 678 | Diag(TheCall->getArg(1)->getLocStart(), |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 679 | diag::warn_second_parameter_of_va_start_not_last_named_argument); |
| 680 | return false; |
Eli Friedman | 6cfda23 | 2008-05-20 08:23:37 +0000 | [diff] [blame] | 681 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 682 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 683 | /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and |
| 684 | /// friends. This is declared to take (...), so we have to check everything. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 685 | bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { |
| 686 | if (TheCall->getNumArgs() < 2) |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 687 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 688 | << 0 << 2 << TheCall->getNumArgs()/*function call*/; |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 689 | if (TheCall->getNumArgs() > 2) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 690 | return Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 691 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 692 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 693 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
| 694 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 695 | |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 696 | Expr *OrigArg0 = TheCall->getArg(0); |
| 697 | Expr *OrigArg1 = TheCall->getArg(1); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 698 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 699 | // Do standard promotions between the two arguments, returning their common |
| 700 | // type. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 701 | QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); |
Daniel Dunbar | 403bc2b | 2009-02-19 19:28:43 +0000 | [diff] [blame] | 702 | |
| 703 | // Make sure any conversions are pushed back into the call; this is |
| 704 | // type safe since unordered compare builtins are declared as "_Bool |
| 705 | // foo(...)". |
| 706 | TheCall->setArg(0, OrigArg0); |
| 707 | TheCall->setArg(1, OrigArg1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 708 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 709 | if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) |
| 710 | return false; |
| 711 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 712 | // If the common type isn't a real floating type, then the arguments were |
| 713 | // invalid for this operation. |
| 714 | if (!Res->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 715 | return Diag(OrigArg0->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 716 | diag::err_typecheck_call_invalid_ordered_compare) |
Chris Lattner | d162584 | 2008-11-24 06:25:27 +0000 | [diff] [blame] | 717 | << OrigArg0->getType() << OrigArg1->getType() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 718 | << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 719 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 720 | return false; |
| 721 | } |
| 722 | |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 723 | /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like |
| 724 | /// __builtin_isnan and friends. This is declared to take (...), so we have |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 725 | /// to check everything. We expect the last argument to be a floating point |
| 726 | /// value. |
| 727 | bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { |
| 728 | if (TheCall->getNumArgs() < NumArgs) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 729 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 730 | << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 731 | if (TheCall->getNumArgs() > NumArgs) |
| 732 | return Diag(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 733 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 734 | << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 735 | << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 736 | (*(TheCall->arg_end()-1))->getLocEnd()); |
| 737 | |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 738 | Expr *OrigArg = TheCall->getArg(NumArgs-1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 739 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 740 | if (OrigArg->isTypeDependent()) |
| 741 | return false; |
| 742 | |
Chris Lattner | 81368fb | 2010-05-06 05:50:07 +0000 | [diff] [blame] | 743 | // This operation requires a non-_Complex floating-point number. |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 744 | if (!OrigArg->getType()->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 745 | return Diag(OrigArg->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 746 | diag::err_typecheck_call_invalid_unary_fp) |
| 747 | << OrigArg->getType() << OrigArg->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 748 | |
Chris Lattner | 81368fb | 2010-05-06 05:50:07 +0000 | [diff] [blame] | 749 | // If this is an implicit conversion from float -> double, remove it. |
| 750 | if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { |
| 751 | Expr *CastArg = Cast->getSubExpr(); |
| 752 | if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { |
| 753 | assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && |
| 754 | "promotion from float to double is the only expected cast here"); |
| 755 | Cast->setSubExpr(0); |
Chris Lattner | 81368fb | 2010-05-06 05:50:07 +0000 | [diff] [blame] | 756 | TheCall->setArg(NumArgs-1, CastArg); |
| 757 | OrigArg = CastArg; |
| 758 | } |
| 759 | } |
| 760 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 761 | return false; |
| 762 | } |
| 763 | |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 764 | /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. |
| 765 | // This is declared to take (...), so we have to check everything. |
John McCall | 60d7b3a | 2010-08-24 06:29:42 +0000 | [diff] [blame] | 766 | ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 767 | if (TheCall->getNumArgs() < 2) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 768 | return ExprError(Diag(TheCall->getLocEnd(), |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 769 | diag::err_typecheck_call_too_few_args_at_least) |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 770 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 771 | << TheCall->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 772 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 773 | // Determine which of the following types of shufflevector we're checking: |
| 774 | // 1) unary, vector mask: (lhs, mask) |
| 775 | // 2) binary, vector mask: (lhs, rhs, mask) |
| 776 | // 3) binary, scalar mask: (lhs, rhs, index, ..., index) |
| 777 | QualType resType = TheCall->getArg(0)->getType(); |
| 778 | unsigned numElements = 0; |
| 779 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 780 | if (!TheCall->getArg(0)->isTypeDependent() && |
| 781 | !TheCall->getArg(1)->isTypeDependent()) { |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 782 | QualType LHSType = TheCall->getArg(0)->getType(); |
| 783 | QualType RHSType = TheCall->getArg(1)->getType(); |
| 784 | |
| 785 | if (!LHSType->isVectorType() || !RHSType->isVectorType()) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 786 | Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 787 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 788 | TheCall->getArg(1)->getLocEnd()); |
| 789 | return ExprError(); |
| 790 | } |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 791 | |
| 792 | numElements = LHSType->getAs<VectorType>()->getNumElements(); |
| 793 | unsigned numResElements = TheCall->getNumArgs() - 2; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 794 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 795 | // Check to see if we have a call with 2 vector arguments, the unary shuffle |
| 796 | // with mask. If so, verify that RHS is an integer vector type with the |
| 797 | // same number of elts as lhs. |
| 798 | if (TheCall->getNumArgs() == 2) { |
Douglas Gregor | f609462 | 2010-07-23 15:58:24 +0000 | [diff] [blame] | 799 | if (!RHSType->hasIntegerRepresentation() || |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 800 | RHSType->getAs<VectorType>()->getNumElements() != numElements) |
| 801 | Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) |
| 802 | << SourceRange(TheCall->getArg(1)->getLocStart(), |
| 803 | TheCall->getArg(1)->getLocEnd()); |
| 804 | numResElements = numElements; |
| 805 | } |
| 806 | else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 807 | Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 808 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 809 | TheCall->getArg(1)->getLocEnd()); |
| 810 | return ExprError(); |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 811 | } else if (numElements != numResElements) { |
| 812 | QualType eltType = LHSType->getAs<VectorType>()->getElementType(); |
Chris Lattner | 788b0fd | 2010-06-23 06:00:24 +0000 | [diff] [blame] | 813 | resType = Context.getVectorType(eltType, numResElements, |
Bob Wilson | e86d78c | 2010-11-10 21:56:12 +0000 | [diff] [blame] | 814 | VectorType::GenericVector); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 815 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 816 | } |
| 817 | |
| 818 | for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 819 | if (TheCall->getArg(i)->isTypeDependent() || |
| 820 | TheCall->getArg(i)->isValueDependent()) |
| 821 | continue; |
| 822 | |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 823 | llvm::APSInt Result(32); |
| 824 | if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) |
| 825 | return ExprError(Diag(TheCall->getLocStart(), |
| 826 | diag::err_shufflevector_nonconstant_argument) |
| 827 | << TheCall->getArg(i)->getSourceRange()); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 828 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 829 | if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 830 | return ExprError(Diag(TheCall->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 831 | diag::err_shufflevector_argument_too_large) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 832 | << TheCall->getArg(i)->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 833 | } |
| 834 | |
| 835 | llvm::SmallVector<Expr*, 32> exprs; |
| 836 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 837 | for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 838 | exprs.push_back(TheCall->getArg(i)); |
| 839 | TheCall->setArg(i, 0); |
| 840 | } |
| 841 | |
Nate Begeman | a88dc30 | 2009-08-12 02:10:25 +0000 | [diff] [blame] | 842 | return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), |
Nate Begeman | 37b6a57 | 2010-06-08 00:16:34 +0000 | [diff] [blame] | 843 | exprs.size(), resType, |
Ted Kremenek | 8189cde | 2009-02-07 01:47:29 +0000 | [diff] [blame] | 844 | TheCall->getCallee()->getLocStart(), |
| 845 | TheCall->getRParenLoc())); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 846 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 847 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 848 | /// SemaBuiltinPrefetch - Handle __builtin_prefetch. |
| 849 | // This is declared to take (const void*, ...) and can take two |
| 850 | // optional constant int args. |
| 851 | bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 852 | unsigned NumArgs = TheCall->getNumArgs(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 853 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 854 | if (NumArgs > 3) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 855 | return Diag(TheCall->getLocEnd(), |
| 856 | diag::err_typecheck_call_too_many_args_at_most) |
| 857 | << 0 /*function call*/ << 3 << NumArgs |
| 858 | << TheCall->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 859 | |
| 860 | // Argument 0 is checked for us and the remaining arguments must be |
| 861 | // constant integers. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 862 | for (unsigned i = 1; i != NumArgs; ++i) { |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 863 | Expr *Arg = TheCall->getArg(i); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 864 | |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 865 | llvm::APSInt Result; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 866 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 867 | return true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 868 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 869 | // FIXME: gcc issues a warning and rewrites these to 0. These |
| 870 | // seems especially odd for the third argument since the default |
| 871 | // is 3. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 872 | if (i == 1) { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 873 | if (Result.getLimitedValue() > 1) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 874 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 875 | << "0" << "1" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 876 | } else { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 877 | if (Result.getLimitedValue() > 3) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 878 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 879 | << "0" << "3" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 880 | } |
| 881 | } |
| 882 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 883 | return false; |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 884 | } |
| 885 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 886 | /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr |
| 887 | /// TheCall is a constant expression. |
| 888 | bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, |
| 889 | llvm::APSInt &Result) { |
| 890 | Expr *Arg = TheCall->getArg(ArgNum); |
| 891 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 892 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 893 | |
| 894 | if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; |
| 895 | |
| 896 | if (!Arg->isIntegerConstantExpr(Result, Context)) |
| 897 | return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) |
Eric Christopher | 5e89655 | 2010-04-19 18:23:02 +0000 | [diff] [blame] | 898 | << FDecl->getDeclName() << Arg->getSourceRange(); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 899 | |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 900 | return false; |
| 901 | } |
| 902 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 903 | /// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, |
| 904 | /// int type). This simply type checks that type is one of the defined |
| 905 | /// constants (0-3). |
Eric Christopher | fee667f | 2009-12-23 03:49:37 +0000 | [diff] [blame] | 906 | // For compatability check 0-3, llvm only handles 0 and 2. |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 907 | bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 908 | llvm::APSInt Result; |
| 909 | |
| 910 | // Check constant-ness first. |
| 911 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 912 | return true; |
| 913 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 914 | Expr *Arg = TheCall->getArg(1); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 915 | if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 916 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
| 917 | << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 918 | } |
| 919 | |
| 920 | return false; |
| 921 | } |
| 922 | |
Eli Friedman | 586d6a8 | 2009-05-03 06:04:26 +0000 | [diff] [blame] | 923 | /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 924 | /// This checks that val is a constant 1. |
| 925 | bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { |
| 926 | Expr *Arg = TheCall->getArg(1); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 927 | llvm::APSInt Result; |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 928 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame] | 929 | // TODO: This is less than ideal. Overload this to take a value. |
| 930 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 931 | return true; |
| 932 | |
| 933 | if (Result != 1) |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 934 | return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) |
| 935 | << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
| 936 | |
| 937 | return false; |
| 938 | } |
| 939 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 940 | // Handle i > 1 ? "x" : "y", recursivelly |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 941 | bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, |
| 942 | bool HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 943 | unsigned format_idx, unsigned firstDataArg, |
| 944 | bool isPrintf) { |
Ted Kremenek | 4fe6441 | 2010-09-09 03:51:39 +0000 | [diff] [blame] | 945 | tryAgain: |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 946 | if (E->isTypeDependent() || E->isValueDependent()) |
| 947 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 948 | |
| 949 | switch (E->getStmtClass()) { |
| 950 | case Stmt::ConditionalOperatorClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 951 | const ConditionalOperator *C = cast<ConditionalOperator>(E); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 952 | return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, |
| 953 | format_idx, firstDataArg, isPrintf) |
| 954 | && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg, |
| 955 | format_idx, firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 956 | } |
| 957 | |
Ted Kremenek | 95355bb | 2010-09-09 03:51:42 +0000 | [diff] [blame] | 958 | case Stmt::IntegerLiteralClass: |
| 959 | // Technically -Wformat-nonliteral does not warn about this case. |
| 960 | // The behavior of printf and friends in this case is implementation |
| 961 | // dependent. Ideally if the format string cannot be null then |
| 962 | // it should have a 'nonnull' attribute in the function prototype. |
| 963 | return true; |
| 964 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 965 | case Stmt::ImplicitCastExprClass: { |
Ted Kremenek | 4fe6441 | 2010-09-09 03:51:39 +0000 | [diff] [blame] | 966 | E = cast<ImplicitCastExpr>(E)->getSubExpr(); |
| 967 | goto tryAgain; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 968 | } |
| 969 | |
| 970 | case Stmt::ParenExprClass: { |
Ted Kremenek | 4fe6441 | 2010-09-09 03:51:39 +0000 | [diff] [blame] | 971 | E = cast<ParenExpr>(E)->getSubExpr(); |
| 972 | goto tryAgain; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 973 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 974 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 975 | case Stmt::DeclRefExprClass: { |
| 976 | const DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 977 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 978 | // As an exception, do not flag errors for variables binding to |
| 979 | // const string literals. |
| 980 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 981 | bool isConstant = false; |
| 982 | QualType T = DR->getType(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 983 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 984 | if (const ArrayType *AT = Context.getAsArrayType(T)) { |
| 985 | isConstant = AT->getElementType().isConstant(Context); |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 986 | } else if (const PointerType *PT = T->getAs<PointerType>()) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 987 | isConstant = T.isConstant(Context) && |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 988 | PT->getPointeeType().isConstant(Context); |
| 989 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 990 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 991 | if (isConstant) { |
Sebastian Redl | 31310a2 | 2010-02-01 20:16:42 +0000 | [diff] [blame] | 992 | if (const Expr *Init = VD->getAnyInitializer()) |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 993 | return SemaCheckStringLiteral(Init, TheCall, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 994 | HasVAListArg, format_idx, firstDataArg, |
| 995 | isPrintf); |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 996 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 997 | |
Anders Carlsson | d966a55 | 2009-06-28 19:55:58 +0000 | [diff] [blame] | 998 | // For vprintf* functions (i.e., HasVAListArg==true), we add a |
| 999 | // special check to see if the format string is a function parameter |
| 1000 | // of the function calling the printf function. If the function |
| 1001 | // has an attribute indicating it is a printf-like function, then we |
| 1002 | // should suppress warnings concerning non-literals being used in a call |
| 1003 | // to a vprintf function. For example: |
| 1004 | // |
| 1005 | // void |
| 1006 | // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ |
| 1007 | // va_list ap; |
| 1008 | // va_start(ap, fmt); |
| 1009 | // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". |
| 1010 | // ... |
| 1011 | // |
| 1012 | // |
| 1013 | // FIXME: We don't have full attribute support yet, so just check to see |
| 1014 | // if the argument is a DeclRefExpr that references a parameter. We'll |
| 1015 | // add proper support for checking the attribute later. |
| 1016 | if (HasVAListArg) |
| 1017 | if (isa<ParmVarDecl>(VD)) |
| 1018 | return true; |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1019 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1020 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1021 | return false; |
| 1022 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1023 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1024 | case Stmt::CallExprClass: { |
| 1025 | const CallExpr *CE = cast<CallExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1026 | if (const ImplicitCastExpr *ICE |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1027 | = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { |
| 1028 | if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { |
| 1029 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 1030 | if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1031 | unsigned ArgIndex = FA->getFormatIdx(); |
| 1032 | const Expr *Arg = CE->getArg(ArgIndex - 1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1033 | |
| 1034 | return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1035 | format_idx, firstDataArg, isPrintf); |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1036 | } |
| 1037 | } |
| 1038 | } |
| 1039 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1040 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 1041 | return false; |
| 1042 | } |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1043 | case Stmt::ObjCStringLiteralClass: |
| 1044 | case Stmt::StringLiteralClass: { |
| 1045 | const StringLiteral *StrE = NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1046 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1047 | if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1048 | StrE = ObjCFExpr->getString(); |
| 1049 | else |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1050 | StrE = cast<StringLiteral>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1051 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1052 | if (StrE) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1053 | CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, |
| 1054 | firstDataArg, isPrintf); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1055 | return true; |
| 1056 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1057 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1058 | return false; |
| 1059 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1060 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1061 | default: |
| 1062 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1063 | } |
| 1064 | } |
| 1065 | |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1066 | void |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1067 | Sema::CheckNonNullArguments(const NonNullAttr *NonNull, |
| 1068 | const CallExpr *TheCall) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 1069 | for (NonNullAttr::args_iterator i = NonNull->args_begin(), |
| 1070 | e = NonNull->args_end(); |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1071 | i != e; ++i) { |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 1072 | const Expr *ArgExpr = TheCall->getArg(*i); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1073 | if (ArgExpr->isNullPointerConstant(Context, |
Douglas Gregor | ce94049 | 2009-09-25 04:25:58 +0000 | [diff] [blame] | 1074 | Expr::NPC_ValueDependentIsNotNull)) |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 1075 | Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) |
| 1076 | << ArgExpr->getSourceRange(); |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 1077 | } |
| 1078 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1079 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1080 | /// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar |
| 1081 | /// functions) for correct use of format strings. |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1082 | void |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1083 | Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, |
| 1084 | unsigned format_idx, unsigned firstDataArg, |
| 1085 | bool isPrintf) { |
| 1086 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1087 | const Expr *Fn = TheCall->getCallee(); |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 1088 | |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 1089 | // The way the format attribute works in GCC, the implicit this argument |
| 1090 | // of member functions is counted. However, it doesn't appear in our own |
| 1091 | // lists, so decrement format_idx in that case. |
| 1092 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 1093 | // Catch a format attribute mistakenly referring to the object argument. |
| 1094 | if (format_idx == 0) |
| 1095 | return; |
| 1096 | --format_idx; |
| 1097 | if(firstDataArg != 0) |
| 1098 | --firstDataArg; |
| 1099 | } |
| 1100 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1101 | // CHECK: printf/scanf-like function is called with no format string. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 1102 | if (format_idx >= TheCall->getNumArgs()) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1103 | Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 1104 | << Fn->getSourceRange(); |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1105 | return; |
| 1106 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1107 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 1108 | const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1109 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1110 | // CHECK: format string is not a string literal. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1111 | // |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1112 | // Dynamically generated format strings are difficult to |
| 1113 | // automatically vet at compile time. Requiring that format strings |
| 1114 | // are string literals: (1) permits the checking of format strings by |
| 1115 | // the compiler and thereby (2) can practically remove the source of |
| 1116 | // many format string exploits. |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1117 | |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1118 | // Format string can be either ObjC string (e.g. @"%d") or |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1119 | // C string (e.g. "%d") |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1120 | // ObjC string uses the same format specifiers as C string, so we can use |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1121 | // the same format string checking logic for both ObjC and C strings. |
Chris Lattner | 1cd3e1f | 2009-04-29 04:49:34 +0000 | [diff] [blame] | 1122 | if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1123 | firstDataArg, isPrintf)) |
Chris Lattner | 1cd3e1f | 2009-04-29 04:49:34 +0000 | [diff] [blame] | 1124 | return; // Literal format string found, check done! |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1125 | |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1126 | // If there are no arguments specified, warn with -Wformat-security, otherwise |
| 1127 | // warn only with -Wformat-nonliteral. |
| 1128 | if (TheCall->getNumArgs() == format_idx+1) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1129 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1130 | diag::warn_format_nonliteral_noargs) |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1131 | << OrigFormatExpr->getSourceRange(); |
| 1132 | else |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1133 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1134 | diag::warn_format_nonliteral) |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1135 | << OrigFormatExpr->getSourceRange(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1136 | } |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1137 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1138 | namespace { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1139 | class CheckFormatHandler : public analyze_format_string::FormatStringHandler { |
| 1140 | protected: |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1141 | Sema &S; |
| 1142 | const StringLiteral *FExpr; |
| 1143 | const Expr *OrigFormatExpr; |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1144 | const unsigned FirstDataArg; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1145 | const unsigned NumDataArgs; |
| 1146 | const bool IsObjCLiteral; |
| 1147 | const char *Beg; // Start of format string. |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1148 | const bool HasVAListArg; |
| 1149 | const CallExpr *TheCall; |
| 1150 | unsigned FormatIdx; |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1151 | llvm::BitVector CoveredArgs; |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1152 | bool usesPositionalArgs; |
| 1153 | bool atFirstArg; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1154 | public: |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1155 | CheckFormatHandler(Sema &s, const StringLiteral *fexpr, |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1156 | const Expr *origFormatExpr, unsigned firstDataArg, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1157 | unsigned numDataArgs, bool isObjCLiteral, |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1158 | const char *beg, bool hasVAListArg, |
| 1159 | const CallExpr *theCall, unsigned formatIdx) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1160 | : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1161 | FirstDataArg(firstDataArg), |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1162 | NumDataArgs(numDataArgs), |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1163 | IsObjCLiteral(isObjCLiteral), Beg(beg), |
| 1164 | HasVAListArg(hasVAListArg), |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1165 | TheCall(theCall), FormatIdx(formatIdx), |
| 1166 | usesPositionalArgs(false), atFirstArg(true) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1167 | CoveredArgs.resize(numDataArgs); |
| 1168 | CoveredArgs.reset(); |
| 1169 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1170 | |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1171 | void DoneProcessing(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1172 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1173 | void HandleIncompleteSpecifier(const char *startSpecifier, |
| 1174 | unsigned specifierLen); |
| 1175 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1176 | virtual void HandleInvalidPosition(const char *startSpecifier, |
| 1177 | unsigned specifierLen, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1178 | analyze_format_string::PositionContext p); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1179 | |
| 1180 | virtual void HandleZeroPosition(const char *startPos, unsigned posLen); |
| 1181 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1182 | void HandleNullChar(const char *nullCharacter); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1183 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1184 | protected: |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1185 | bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, |
| 1186 | const char *startSpec, |
| 1187 | unsigned specifierLen, |
| 1188 | const char *csStart, unsigned csLen); |
| 1189 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1190 | SourceRange getFormatStringRange(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1191 | CharSourceRange getSpecifierRange(const char *startSpecifier, |
| 1192 | unsigned specifierLen); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1193 | SourceLocation getLocationOfByte(const char *x); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1194 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1195 | const Expr *getDataArg(unsigned i) const; |
Ted Kremenek | 666a197 | 2010-07-26 19:45:42 +0000 | [diff] [blame] | 1196 | |
| 1197 | bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, |
| 1198 | const analyze_format_string::ConversionSpecifier &CS, |
| 1199 | const char *startSpecifier, unsigned specifierLen, |
| 1200 | unsigned argIndex); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1201 | }; |
| 1202 | } |
| 1203 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1204 | SourceRange CheckFormatHandler::getFormatStringRange() { |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1205 | return OrigFormatExpr->getSourceRange(); |
| 1206 | } |
| 1207 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1208 | CharSourceRange CheckFormatHandler:: |
| 1209 | getSpecifierRange(const char *startSpecifier, unsigned specifierLen) { |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1210 | SourceLocation Start = getLocationOfByte(startSpecifier); |
| 1211 | SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); |
| 1212 | |
| 1213 | // Advance the end SourceLocation by one due to half-open ranges. |
| 1214 | End = End.getFileLocWithOffset(1); |
| 1215 | |
| 1216 | return CharSourceRange::getCharRange(Start, End); |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1217 | } |
| 1218 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1219 | SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1220 | return S.getLocationOfStringLiteralByte(FExpr, x - Beg); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1221 | } |
| 1222 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1223 | void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, |
| 1224 | unsigned specifierLen){ |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1225 | SourceLocation Loc = getLocationOfByte(startSpecifier); |
| 1226 | S.Diag(Loc, diag::warn_printf_incomplete_specifier) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1227 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1228 | } |
| 1229 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1230 | void |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1231 | CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, |
| 1232 | analyze_format_string::PositionContext p) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1233 | SourceLocation Loc = getLocationOfByte(startPos); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1234 | S.Diag(Loc, diag::warn_format_invalid_positional_specifier) |
| 1235 | << (unsigned) p << getSpecifierRange(startPos, posLen); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1236 | } |
| 1237 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1238 | void CheckFormatHandler::HandleZeroPosition(const char *startPos, |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1239 | unsigned posLen) { |
| 1240 | SourceLocation Loc = getLocationOfByte(startPos); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1241 | S.Diag(Loc, diag::warn_format_zero_positional_specifier) |
| 1242 | << getSpecifierRange(startPos, posLen); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1243 | } |
| 1244 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1245 | void CheckFormatHandler::HandleNullChar(const char *nullCharacter) { |
| 1246 | // The presence of a null character is likely an error. |
| 1247 | S.Diag(getLocationOfByte(nullCharacter), |
| 1248 | diag::warn_printf_format_string_contains_null_char) |
| 1249 | << getFormatStringRange(); |
| 1250 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1251 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1252 | const Expr *CheckFormatHandler::getDataArg(unsigned i) const { |
| 1253 | return TheCall->getArg(FirstDataArg + i); |
| 1254 | } |
| 1255 | |
| 1256 | void CheckFormatHandler::DoneProcessing() { |
| 1257 | // Does the number of data arguments exceed the number of |
| 1258 | // format conversions in the format string? |
| 1259 | if (!HasVAListArg) { |
| 1260 | // Find any arguments that weren't covered. |
| 1261 | CoveredArgs.flip(); |
| 1262 | signed notCoveredArg = CoveredArgs.find_first(); |
| 1263 | if (notCoveredArg >= 0) { |
| 1264 | assert((unsigned)notCoveredArg < NumDataArgs); |
| 1265 | S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), |
| 1266 | diag::warn_printf_data_arg_not_used) |
| 1267 | << getFormatStringRange(); |
| 1268 | } |
| 1269 | } |
| 1270 | } |
| 1271 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1272 | bool |
| 1273 | CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, |
| 1274 | SourceLocation Loc, |
| 1275 | const char *startSpec, |
| 1276 | unsigned specifierLen, |
| 1277 | const char *csStart, |
| 1278 | unsigned csLen) { |
| 1279 | |
| 1280 | bool keepGoing = true; |
| 1281 | if (argIndex < NumDataArgs) { |
| 1282 | // Consider the argument coverered, even though the specifier doesn't |
| 1283 | // make sense. |
| 1284 | CoveredArgs.set(argIndex); |
| 1285 | } |
| 1286 | else { |
| 1287 | // If argIndex exceeds the number of data arguments we |
| 1288 | // don't issue a warning because that is just a cascade of warnings (and |
| 1289 | // they may have intended '%%' anyway). We don't want to continue processing |
| 1290 | // the format string after this point, however, as we will like just get |
| 1291 | // gibberish when trying to match arguments. |
| 1292 | keepGoing = false; |
| 1293 | } |
| 1294 | |
| 1295 | S.Diag(Loc, diag::warn_format_invalid_conversion) |
| 1296 | << llvm::StringRef(csStart, csLen) |
| 1297 | << getSpecifierRange(startSpec, specifierLen); |
| 1298 | |
| 1299 | return keepGoing; |
| 1300 | } |
| 1301 | |
Ted Kremenek | 666a197 | 2010-07-26 19:45:42 +0000 | [diff] [blame] | 1302 | bool |
| 1303 | CheckFormatHandler::CheckNumArgs( |
| 1304 | const analyze_format_string::FormatSpecifier &FS, |
| 1305 | const analyze_format_string::ConversionSpecifier &CS, |
| 1306 | const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { |
| 1307 | |
| 1308 | if (argIndex >= NumDataArgs) { |
| 1309 | if (FS.usesPositionalArg()) { |
| 1310 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1311 | diag::warn_printf_positional_arg_exceeds_data_args) |
| 1312 | << (argIndex+1) << NumDataArgs |
| 1313 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1314 | } |
| 1315 | else { |
| 1316 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1317 | diag::warn_printf_insufficient_data_args) |
| 1318 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1319 | } |
| 1320 | |
| 1321 | return false; |
| 1322 | } |
| 1323 | return true; |
| 1324 | } |
| 1325 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1326 | //===--- CHECK: Printf format string checking ------------------------------===// |
| 1327 | |
| 1328 | namespace { |
| 1329 | class CheckPrintfHandler : public CheckFormatHandler { |
| 1330 | public: |
| 1331 | CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, |
| 1332 | const Expr *origFormatExpr, unsigned firstDataArg, |
| 1333 | unsigned numDataArgs, bool isObjCLiteral, |
| 1334 | const char *beg, bool hasVAListArg, |
| 1335 | const CallExpr *theCall, unsigned formatIdx) |
| 1336 | : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, |
| 1337 | numDataArgs, isObjCLiteral, beg, hasVAListArg, |
| 1338 | theCall, formatIdx) {} |
| 1339 | |
| 1340 | |
| 1341 | bool HandleInvalidPrintfConversionSpecifier( |
| 1342 | const analyze_printf::PrintfSpecifier &FS, |
| 1343 | const char *startSpecifier, |
| 1344 | unsigned specifierLen); |
| 1345 | |
| 1346 | bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, |
| 1347 | const char *startSpecifier, |
| 1348 | unsigned specifierLen); |
| 1349 | |
| 1350 | bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, |
| 1351 | const char *startSpecifier, unsigned specifierLen); |
| 1352 | void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, |
| 1353 | const analyze_printf::OptionalAmount &Amt, |
| 1354 | unsigned type, |
| 1355 | const char *startSpecifier, unsigned specifierLen); |
| 1356 | void HandleFlag(const analyze_printf::PrintfSpecifier &FS, |
| 1357 | const analyze_printf::OptionalFlag &flag, |
| 1358 | const char *startSpecifier, unsigned specifierLen); |
| 1359 | void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, |
| 1360 | const analyze_printf::OptionalFlag &ignoredFlag, |
| 1361 | const analyze_printf::OptionalFlag &flag, |
| 1362 | const char *startSpecifier, unsigned specifierLen); |
| 1363 | }; |
| 1364 | } |
| 1365 | |
| 1366 | bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( |
| 1367 | const analyze_printf::PrintfSpecifier &FS, |
| 1368 | const char *startSpecifier, |
| 1369 | unsigned specifierLen) { |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1370 | const analyze_printf::PrintfConversionSpecifier &CS = |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1371 | FS.getConversionSpecifier(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1372 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1373 | return HandleInvalidConversionSpecifier(FS.getArgIndex(), |
| 1374 | getLocationOfByte(CS.getStart()), |
| 1375 | startSpecifier, specifierLen, |
| 1376 | CS.getStart(), CS.getLength()); |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1377 | } |
| 1378 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1379 | bool CheckPrintfHandler::HandleAmount( |
| 1380 | const analyze_format_string::OptionalAmount &Amt, |
| 1381 | unsigned k, const char *startSpecifier, |
| 1382 | unsigned specifierLen) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1383 | |
| 1384 | if (Amt.hasDataArgument()) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1385 | if (!HasVAListArg) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1386 | unsigned argIndex = Amt.getArgIndex(); |
| 1387 | if (argIndex >= NumDataArgs) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1388 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1389 | diag::warn_printf_asterisk_missing_arg) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1390 | << k << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1391 | // Don't do any more checking. We will just emit |
| 1392 | // spurious errors. |
| 1393 | return false; |
| 1394 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1395 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1396 | // Type check the data argument. It should be an 'int'. |
Ted Kremenek | 31f8e32 | 2010-01-29 23:32:22 +0000 | [diff] [blame] | 1397 | // Although not in conformance with C99, we also allow the argument to be |
| 1398 | // an 'unsigned int' as that is a reasonably safe case. GCC also |
| 1399 | // doesn't emit a warning for that case. |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1400 | CoveredArgs.set(argIndex); |
| 1401 | const Expr *Arg = getDataArg(argIndex); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1402 | QualType T = Arg->getType(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1403 | |
| 1404 | const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); |
| 1405 | assert(ATR.isValid()); |
| 1406 | |
| 1407 | if (!ATR.matchesType(S.Context, T)) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1408 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1409 | diag::warn_printf_asterisk_wrong_type) |
| 1410 | << k |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1411 | << ATR.getRepresentativeType(S.Context) << T |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1412 | << getSpecifierRange(startSpecifier, specifierLen) |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1413 | << Arg->getSourceRange(); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1414 | // Don't do any more checking. We will just emit |
| 1415 | // spurious errors. |
| 1416 | return false; |
| 1417 | } |
| 1418 | } |
| 1419 | } |
| 1420 | return true; |
| 1421 | } |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1422 | |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1423 | void CheckPrintfHandler::HandleInvalidAmount( |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1424 | const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1425 | const analyze_printf::OptionalAmount &Amt, |
| 1426 | unsigned type, |
| 1427 | const char *startSpecifier, |
| 1428 | unsigned specifierLen) { |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1429 | const analyze_printf::PrintfConversionSpecifier &CS = |
| 1430 | FS.getConversionSpecifier(); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1431 | switch (Amt.getHowSpecified()) { |
| 1432 | case analyze_printf::OptionalAmount::Constant: |
| 1433 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1434 | diag::warn_printf_nonsensical_optional_amount) |
| 1435 | << type |
| 1436 | << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1437 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1438 | << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1439 | Amt.getConstantLength())); |
| 1440 | break; |
| 1441 | |
| 1442 | default: |
| 1443 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1444 | diag::warn_printf_nonsensical_optional_amount) |
| 1445 | << type |
| 1446 | << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1447 | << getSpecifierRange(startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1448 | break; |
| 1449 | } |
| 1450 | } |
| 1451 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1452 | void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1453 | const analyze_printf::OptionalFlag &flag, |
| 1454 | const char *startSpecifier, |
| 1455 | unsigned specifierLen) { |
| 1456 | // Warn about pointless flag with a fixit removal. |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1457 | const analyze_printf::PrintfConversionSpecifier &CS = |
| 1458 | FS.getConversionSpecifier(); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1459 | S.Diag(getLocationOfByte(flag.getPosition()), |
| 1460 | diag::warn_printf_nonsensical_flag) |
| 1461 | << flag.toString() << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1462 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1463 | << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1464 | } |
| 1465 | |
| 1466 | void CheckPrintfHandler::HandleIgnoredFlag( |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1467 | const analyze_printf::PrintfSpecifier &FS, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1468 | const analyze_printf::OptionalFlag &ignoredFlag, |
| 1469 | const analyze_printf::OptionalFlag &flag, |
| 1470 | const char *startSpecifier, |
| 1471 | unsigned specifierLen) { |
| 1472 | // Warn about ignored flag with a fixit removal. |
| 1473 | S.Diag(getLocationOfByte(ignoredFlag.getPosition()), |
| 1474 | diag::warn_printf_ignored_flag) |
| 1475 | << ignoredFlag.toString() << flag.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1476 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1477 | << FixItHint::CreateRemoval(getSpecifierRange( |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1478 | ignoredFlag.getPosition(), 1)); |
| 1479 | } |
| 1480 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1481 | bool |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1482 | CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1483 | &FS, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1484 | const char *startSpecifier, |
| 1485 | unsigned specifierLen) { |
| 1486 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1487 | using namespace analyze_format_string; |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1488 | using namespace analyze_printf; |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1489 | const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1490 | |
Ted Kremenek | baa4006 | 2010-07-19 22:01:06 +0000 | [diff] [blame] | 1491 | if (FS.consumesDataArgument()) { |
| 1492 | if (atFirstArg) { |
| 1493 | atFirstArg = false; |
| 1494 | usesPositionalArgs = FS.usesPositionalArg(); |
| 1495 | } |
| 1496 | else if (usesPositionalArgs != FS.usesPositionalArg()) { |
| 1497 | // Cannot mix-and-match positional and non-positional arguments. |
| 1498 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1499 | diag::warn_format_mix_positional_nonpositional_args) |
| 1500 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1501 | return false; |
| 1502 | } |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1503 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1504 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1505 | // First check if the field width, precision, and conversion specifier |
| 1506 | // have matching data arguments. |
| 1507 | if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, |
| 1508 | startSpecifier, specifierLen)) { |
| 1509 | return false; |
| 1510 | } |
| 1511 | |
| 1512 | if (!HandleAmount(FS.getPrecision(), /* precision */ 1, |
| 1513 | startSpecifier, specifierLen)) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1514 | return false; |
| 1515 | } |
| 1516 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1517 | if (!CS.consumesDataArgument()) { |
| 1518 | // FIXME: Technically specifying a precision or field width here |
| 1519 | // makes no sense. Worth issuing a warning at some point. |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1520 | return true; |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1521 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1522 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1523 | // Consume the argument. |
| 1524 | unsigned argIndex = FS.getArgIndex(); |
Ted Kremenek | e3fc547 | 2010-02-27 08:34:51 +0000 | [diff] [blame] | 1525 | if (argIndex < NumDataArgs) { |
| 1526 | // The check to see if the argIndex is valid will come later. |
| 1527 | // We set the bit here because we may exit early from this |
| 1528 | // function if we encounter some other error. |
| 1529 | CoveredArgs.set(argIndex); |
| 1530 | } |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1531 | |
| 1532 | // Check for using an Objective-C specific conversion specifier |
| 1533 | // in a non-ObjC literal. |
| 1534 | if (!IsObjCLiteral && CS.isObjCArg()) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1535 | return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, |
| 1536 | specifierLen); |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1537 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1538 | |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1539 | // Check for invalid use of field width |
| 1540 | if (!FS.hasValidFieldWidth()) { |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1541 | HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1542 | startSpecifier, specifierLen); |
| 1543 | } |
| 1544 | |
| 1545 | // Check for invalid use of precision |
| 1546 | if (!FS.hasValidPrecision()) { |
| 1547 | HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, |
| 1548 | startSpecifier, specifierLen); |
| 1549 | } |
| 1550 | |
| 1551 | // Check each flag does not conflict with any other component. |
| 1552 | if (!FS.hasValidLeadingZeros()) |
| 1553 | HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); |
| 1554 | if (!FS.hasValidPlusPrefix()) |
| 1555 | HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1556 | if (!FS.hasValidSpacePrefix()) |
| 1557 | HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1558 | if (!FS.hasValidAlternativeForm()) |
| 1559 | HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); |
| 1560 | if (!FS.hasValidLeftJustified()) |
| 1561 | HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); |
| 1562 | |
| 1563 | // Check that flags are not ignored by another flag |
Tom Care | 45f9b7e | 2010-06-21 21:21:01 +0000 | [diff] [blame] | 1564 | if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' |
| 1565 | HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), |
| 1566 | startSpecifier, specifierLen); |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1567 | if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' |
| 1568 | HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), |
| 1569 | startSpecifier, specifierLen); |
| 1570 | |
| 1571 | // Check the length modifier is valid with the given conversion specifier. |
| 1572 | const LengthModifier &LM = FS.getLengthModifier(); |
| 1573 | if (!FS.hasValidLengthModifier()) |
| 1574 | S.Diag(getLocationOfByte(LM.getStart()), |
Ted Kremenek | 649aecf | 2010-07-20 20:03:43 +0000 | [diff] [blame] | 1575 | diag::warn_format_nonsensical_length) |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1576 | << LM.toString() << CS.toString() |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1577 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1578 | << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1579 | LM.getLength())); |
| 1580 | |
| 1581 | // Are we using '%n'? |
Ted Kremenek | 35d353b | 2010-07-20 20:04:10 +0000 | [diff] [blame] | 1582 | if (CS.getKind() == ConversionSpecifier::nArg) { |
Tom Care | e4ee966 | 2010-06-17 19:00:27 +0000 | [diff] [blame] | 1583 | // Issue a warning about this being a possible security issue. |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1584 | S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1585 | << getSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1586 | // Continue checking the other format specifiers. |
| 1587 | return true; |
| 1588 | } |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1589 | |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1590 | // The remaining checks depend on the data arguments. |
| 1591 | if (HasVAListArg) |
| 1592 | return true; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1593 | |
Ted Kremenek | 666a197 | 2010-07-26 19:45:42 +0000 | [diff] [blame] | 1594 | if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1595 | return false; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1596 | |
Michael J. Spencer | 96827eb | 2010-07-27 04:46:02 +0000 | [diff] [blame] | 1597 | // Now type check the data expression that matches the |
| 1598 | // format specifier. |
| 1599 | const Expr *Ex = getDataArg(argIndex); |
| 1600 | const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); |
| 1601 | if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { |
| 1602 | // Check if we didn't match because of an implicit cast from a 'char' |
| 1603 | // or 'short' to an 'int'. This is done because printf is a varargs |
| 1604 | // function. |
| 1605 | if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) |
Ted Kremenek | 4d8ae4d | 2010-10-21 04:00:58 +0000 | [diff] [blame] | 1606 | if (ICE->getType() == S.Context.IntTy) { |
| 1607 | // All further checking is done on the subexpression. |
| 1608 | Ex = ICE->getSubExpr(); |
| 1609 | if (ATR.matchesType(S.Context, Ex->getType())) |
Michael J. Spencer | 96827eb | 2010-07-27 04:46:02 +0000 | [diff] [blame] | 1610 | return true; |
Ted Kremenek | 4d8ae4d | 2010-10-21 04:00:58 +0000 | [diff] [blame] | 1611 | } |
Michael J. Spencer | 96827eb | 2010-07-27 04:46:02 +0000 | [diff] [blame] | 1612 | |
| 1613 | // We may be able to offer a FixItHint if it is a supported type. |
| 1614 | PrintfSpecifier fixedFS = FS; |
| 1615 | bool success = fixedFS.fixType(Ex->getType()); |
| 1616 | |
| 1617 | if (success) { |
| 1618 | // Get the fix string from the fixed format specifier |
| 1619 | llvm::SmallString<128> buf; |
| 1620 | llvm::raw_svector_ostream os(buf); |
| 1621 | fixedFS.toString(os); |
| 1622 | |
Ted Kremenek | 9325eaf | 2010-08-24 22:24:51 +0000 | [diff] [blame] | 1623 | // FIXME: getRepresentativeType() perhaps should return a string |
| 1624 | // instead of a QualType to better handle when the representative |
| 1625 | // type is 'wint_t' (which is defined in the system headers). |
Michael J. Spencer | 96827eb | 2010-07-27 04:46:02 +0000 | [diff] [blame] | 1626 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1627 | diag::warn_printf_conversion_argument_type_mismatch) |
| 1628 | << ATR.getRepresentativeType(S.Context) << Ex->getType() |
| 1629 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1630 | << Ex->getSourceRange() |
| 1631 | << FixItHint::CreateReplacement( |
| 1632 | getSpecifierRange(startSpecifier, specifierLen), |
| 1633 | os.str()); |
| 1634 | } |
| 1635 | else { |
| 1636 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1637 | diag::warn_printf_conversion_argument_type_mismatch) |
| 1638 | << ATR.getRepresentativeType(S.Context) << Ex->getType() |
| 1639 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1640 | << Ex->getSourceRange(); |
| 1641 | } |
| 1642 | } |
| 1643 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1644 | return true; |
| 1645 | } |
| 1646 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1647 | //===--- CHECK: Scanf format string checking ------------------------------===// |
| 1648 | |
| 1649 | namespace { |
| 1650 | class CheckScanfHandler : public CheckFormatHandler { |
| 1651 | public: |
| 1652 | CheckScanfHandler(Sema &s, const StringLiteral *fexpr, |
| 1653 | const Expr *origFormatExpr, unsigned firstDataArg, |
| 1654 | unsigned numDataArgs, bool isObjCLiteral, |
| 1655 | const char *beg, bool hasVAListArg, |
| 1656 | const CallExpr *theCall, unsigned formatIdx) |
| 1657 | : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, |
| 1658 | numDataArgs, isObjCLiteral, beg, hasVAListArg, |
| 1659 | theCall, formatIdx) {} |
| 1660 | |
| 1661 | bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, |
| 1662 | const char *startSpecifier, |
| 1663 | unsigned specifierLen); |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1664 | |
| 1665 | bool HandleInvalidScanfConversionSpecifier( |
| 1666 | const analyze_scanf::ScanfSpecifier &FS, |
| 1667 | const char *startSpecifier, |
| 1668 | unsigned specifierLen); |
Ted Kremenek | b7c2101 | 2010-07-16 18:28:03 +0000 | [diff] [blame] | 1669 | |
| 1670 | void HandleIncompleteScanList(const char *start, const char *end); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1671 | }; |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1672 | } |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1673 | |
Ted Kremenek | b7c2101 | 2010-07-16 18:28:03 +0000 | [diff] [blame] | 1674 | void CheckScanfHandler::HandleIncompleteScanList(const char *start, |
| 1675 | const char *end) { |
| 1676 | S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) |
| 1677 | << getSpecifierRange(start, end - start); |
| 1678 | } |
| 1679 | |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1680 | bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( |
| 1681 | const analyze_scanf::ScanfSpecifier &FS, |
| 1682 | const char *startSpecifier, |
| 1683 | unsigned specifierLen) { |
| 1684 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1685 | const analyze_scanf::ScanfConversionSpecifier &CS = |
Ted Kremenek | c09b6a5 | 2010-07-19 21:25:57 +0000 | [diff] [blame] | 1686 | FS.getConversionSpecifier(); |
| 1687 | |
| 1688 | return HandleInvalidConversionSpecifier(FS.getArgIndex(), |
| 1689 | getLocationOfByte(CS.getStart()), |
| 1690 | startSpecifier, specifierLen, |
| 1691 | CS.getStart(), CS.getLength()); |
| 1692 | } |
| 1693 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1694 | bool CheckScanfHandler::HandleScanfSpecifier( |
| 1695 | const analyze_scanf::ScanfSpecifier &FS, |
| 1696 | const char *startSpecifier, |
| 1697 | unsigned specifierLen) { |
| 1698 | |
| 1699 | using namespace analyze_scanf; |
| 1700 | using namespace analyze_format_string; |
| 1701 | |
Ted Kremenek | 6ecb950 | 2010-07-20 20:04:27 +0000 | [diff] [blame] | 1702 | const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1703 | |
Ted Kremenek | baa4006 | 2010-07-19 22:01:06 +0000 | [diff] [blame] | 1704 | // Handle case where '%' and '*' don't consume an argument. These shouldn't |
| 1705 | // be used to decide if we are using positional arguments consistently. |
| 1706 | if (FS.consumesDataArgument()) { |
| 1707 | if (atFirstArg) { |
| 1708 | atFirstArg = false; |
| 1709 | usesPositionalArgs = FS.usesPositionalArg(); |
| 1710 | } |
| 1711 | else if (usesPositionalArgs != FS.usesPositionalArg()) { |
| 1712 | // Cannot mix-and-match positional and non-positional arguments. |
| 1713 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1714 | diag::warn_format_mix_positional_nonpositional_args) |
| 1715 | << getSpecifierRange(startSpecifier, specifierLen); |
| 1716 | return false; |
| 1717 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1718 | } |
| 1719 | |
| 1720 | // Check if the field with is non-zero. |
| 1721 | const OptionalAmount &Amt = FS.getFieldWidth(); |
| 1722 | if (Amt.getHowSpecified() == OptionalAmount::Constant) { |
| 1723 | if (Amt.getConstantAmount() == 0) { |
| 1724 | const CharSourceRange &R = getSpecifierRange(Amt.getStart(), |
| 1725 | Amt.getConstantLength()); |
| 1726 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1727 | diag::warn_scanf_nonzero_width) |
| 1728 | << R << FixItHint::CreateRemoval(R); |
| 1729 | } |
| 1730 | } |
| 1731 | |
| 1732 | if (!FS.consumesDataArgument()) { |
| 1733 | // FIXME: Technically specifying a precision or field width here |
| 1734 | // makes no sense. Worth issuing a warning at some point. |
| 1735 | return true; |
| 1736 | } |
| 1737 | |
| 1738 | // Consume the argument. |
| 1739 | unsigned argIndex = FS.getArgIndex(); |
| 1740 | if (argIndex < NumDataArgs) { |
| 1741 | // The check to see if the argIndex is valid will come later. |
| 1742 | // We set the bit here because we may exit early from this |
| 1743 | // function if we encounter some other error. |
| 1744 | CoveredArgs.set(argIndex); |
| 1745 | } |
| 1746 | |
Ted Kremenek | 1e51c20 | 2010-07-20 20:04:47 +0000 | [diff] [blame] | 1747 | // Check the length modifier is valid with the given conversion specifier. |
| 1748 | const LengthModifier &LM = FS.getLengthModifier(); |
| 1749 | if (!FS.hasValidLengthModifier()) { |
| 1750 | S.Diag(getLocationOfByte(LM.getStart()), |
| 1751 | diag::warn_format_nonsensical_length) |
| 1752 | << LM.toString() << CS.toString() |
| 1753 | << getSpecifierRange(startSpecifier, specifierLen) |
| 1754 | << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), |
| 1755 | LM.getLength())); |
| 1756 | } |
| 1757 | |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1758 | // The remaining checks depend on the data arguments. |
| 1759 | if (HasVAListArg) |
| 1760 | return true; |
| 1761 | |
Ted Kremenek | 666a197 | 2010-07-26 19:45:42 +0000 | [diff] [blame] | 1762 | if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1763 | return false; |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1764 | |
| 1765 | // FIXME: Check that the argument type matches the format specifier. |
| 1766 | |
| 1767 | return true; |
| 1768 | } |
| 1769 | |
| 1770 | void Sema::CheckFormatString(const StringLiteral *FExpr, |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1771 | const Expr *OrigFormatExpr, |
| 1772 | const CallExpr *TheCall, bool HasVAListArg, |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1773 | unsigned format_idx, unsigned firstDataArg, |
| 1774 | bool isPrintf) { |
| 1775 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1776 | // CHECK: is the format string a wide literal? |
| 1777 | if (FExpr->isWide()) { |
| 1778 | Diag(FExpr->getLocStart(), |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1779 | diag::warn_format_string_is_wide_literal) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1780 | << OrigFormatExpr->getSourceRange(); |
| 1781 | return; |
| 1782 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1783 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1784 | // Str - The format string. NOTE: this is NOT null-terminated! |
Benjamin Kramer | 2f4eaef | 2010-08-17 12:54:38 +0000 | [diff] [blame] | 1785 | llvm::StringRef StrRef = FExpr->getString(); |
| 1786 | const char *Str = StrRef.data(); |
| 1787 | unsigned StrLen = StrRef.size(); |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1788 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1789 | // CHECK: empty format string? |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1790 | if (StrLen == 0) { |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1791 | Diag(FExpr->getLocStart(), diag::warn_empty_format_string) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1792 | << OrigFormatExpr->getSourceRange(); |
| 1793 | return; |
| 1794 | } |
Ted Kremenek | 826a345 | 2010-07-16 02:11:22 +0000 | [diff] [blame] | 1795 | |
| 1796 | if (isPrintf) { |
| 1797 | CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, |
| 1798 | TheCall->getNumArgs() - firstDataArg, |
| 1799 | isa<ObjCStringLiteral>(OrigFormatExpr), Str, |
| 1800 | HasVAListArg, TheCall, format_idx); |
| 1801 | |
| 1802 | if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) |
| 1803 | H.DoneProcessing(); |
| 1804 | } |
| 1805 | else { |
| 1806 | CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, |
| 1807 | TheCall->getNumArgs() - firstDataArg, |
| 1808 | isa<ObjCStringLiteral>(OrigFormatExpr), Str, |
| 1809 | HasVAListArg, TheCall, format_idx); |
| 1810 | |
| 1811 | if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) |
| 1812 | H.DoneProcessing(); |
| 1813 | } |
Ted Kremenek | ce7024e | 2010-01-28 01:18:22 +0000 | [diff] [blame] | 1814 | } |
| 1815 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1816 | //===--- CHECK: Return Address of Stack Variable --------------------------===// |
| 1817 | |
| 1818 | static DeclRefExpr* EvalVal(Expr *E); |
| 1819 | static DeclRefExpr* EvalAddr(Expr* E); |
| 1820 | |
| 1821 | /// CheckReturnStackAddr - Check if a return statement returns the address |
| 1822 | /// of a stack variable. |
| 1823 | void |
| 1824 | Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, |
| 1825 | SourceLocation ReturnLoc) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1826 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1827 | // Perform checking for returned stack addresses. |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1828 | if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1829 | if (DeclRefExpr *DR = EvalAddr(RetValExp)) |
Chris Lattner | 3c73c41 | 2008-11-19 08:23:25 +0000 | [diff] [blame] | 1830 | Diag(DR->getLocStart(), diag::warn_ret_stack_addr) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1831 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1832 | |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1833 | // Skip over implicit cast expressions when checking for block expressions. |
Chris Lattner | 4ca606e | 2009-09-08 00:36:37 +0000 | [diff] [blame] | 1834 | RetValExp = RetValExp->IgnoreParenCasts(); |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1835 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1836 | if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp)) |
Mike Stump | 397195b | 2009-04-17 00:09:41 +0000 | [diff] [blame] | 1837 | if (C->hasBlockDeclRefExprs()) |
| 1838 | Diag(C->getLocStart(), diag::err_ret_local_block) |
| 1839 | << C->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1840 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1841 | if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp)) |
| 1842 | Diag(ALE->getLocStart(), diag::warn_ret_addr_label) |
| 1843 | << ALE->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1844 | |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 1845 | } else if (lhsType->isReferenceType()) { |
| 1846 | // Perform checking for stack values returned by reference. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1847 | // Check for a reference to the stack |
| 1848 | if (DeclRefExpr *DR = EvalVal(RetValExp)) |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 1849 | Diag(DR->getLocStart(), diag::warn_ret_stack_ref) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1850 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1851 | } |
| 1852 | } |
| 1853 | |
| 1854 | /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that |
| 1855 | /// check if the expression in a return statement evaluates to an address |
| 1856 | /// to a location on the stack. The recursion is used to traverse the |
| 1857 | /// AST of the return expression, with recursion backtracking when we |
| 1858 | /// encounter a subexpression that (1) clearly does not lead to the address |
| 1859 | /// of a stack variable or (2) is something we cannot determine leads to |
| 1860 | /// the address of a stack variable based on such local checking. |
| 1861 | /// |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1862 | /// EvalAddr processes expressions that are pointers that are used as |
| 1863 | /// references (and not L-values). EvalVal handles all other values. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1864 | /// At the base case of the recursion is a check for a DeclRefExpr* in |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1865 | /// the refers to a stack variable. |
| 1866 | /// |
| 1867 | /// This implementation handles: |
| 1868 | /// |
| 1869 | /// * pointer-to-pointer casts |
| 1870 | /// * implicit conversions from array references to pointers |
| 1871 | /// * taking the address of fields |
| 1872 | /// * arbitrary interplay between "&" and "*" operators |
| 1873 | /// * pointer arithmetic from an address of a stack variable |
| 1874 | /// * taking the address of an array element where the array is on the stack |
| 1875 | static DeclRefExpr* EvalAddr(Expr *E) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1876 | // We should only be called for evaluating pointer expressions. |
David Chisnall | 0f43656 | 2009-08-17 16:35:33 +0000 | [diff] [blame] | 1877 | assert((E->getType()->isAnyPointerType() || |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1878 | E->getType()->isBlockPointerType() || |
Ted Kremenek | a526c5c | 2008-01-07 19:49:32 +0000 | [diff] [blame] | 1879 | E->getType()->isObjCQualifiedIdType()) && |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1880 | "EvalAddr only works on pointers"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1881 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1882 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1883 | // viewed AST node. We then recursively traverse the AST by calling |
| 1884 | // EvalAddr and EvalVal appropriately. |
| 1885 | switch (E->getStmtClass()) { |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1886 | case Stmt::ParenExprClass: |
| 1887 | // Ignore parentheses. |
| 1888 | return EvalAddr(cast<ParenExpr>(E)->getSubExpr()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1889 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1890 | case Stmt::UnaryOperatorClass: { |
| 1891 | // The only unary operator that make sense to handle here |
| 1892 | // is AddrOf. All others don't make sense as pointers. |
| 1893 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1894 | |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 1895 | if (U->getOpcode() == UO_AddrOf) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1896 | return EvalVal(U->getSubExpr()); |
| 1897 | else |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1898 | return NULL; |
| 1899 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1900 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1901 | case Stmt::BinaryOperatorClass: { |
| 1902 | // Handle pointer arithmetic. All other binary operators are not valid |
| 1903 | // in this context. |
| 1904 | BinaryOperator *B = cast<BinaryOperator>(E); |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 1905 | BinaryOperatorKind op = B->getOpcode(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1906 | |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 1907 | if (op != BO_Add && op != BO_Sub) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1908 | return NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1909 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1910 | Expr *Base = B->getLHS(); |
| 1911 | |
| 1912 | // Determine which argument is the real pointer base. It could be |
| 1913 | // the RHS argument instead of the LHS. |
| 1914 | if (!Base->getType()->isPointerType()) Base = B->getRHS(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1915 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1916 | assert (Base->getType()->isPointerType()); |
| 1917 | return EvalAddr(Base); |
| 1918 | } |
Steve Naroff | 61f40a2 | 2008-09-10 19:17:48 +0000 | [diff] [blame] | 1919 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1920 | // For conditional operators we need to see if either the LHS or RHS are |
| 1921 | // valid DeclRefExpr*s. If one of them is valid, we return it. |
| 1922 | case Stmt::ConditionalOperatorClass: { |
| 1923 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1924 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1925 | // Handle the GNU extension for missing LHS. |
Douglas Gregor | 9ee5ee8 | 2010-10-21 16:21:08 +0000 | [diff] [blame] | 1926 | if (Expr *lhsExpr = C->getLHS()) { |
| 1927 | // In C++, we can have a throw-expression, which has 'void' type. |
| 1928 | if (!lhsExpr->getType()->isVoidType()) |
| 1929 | if (DeclRefExpr* LHS = EvalAddr(lhsExpr)) |
| 1930 | return LHS; |
| 1931 | } |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1932 | |
Douglas Gregor | 9ee5ee8 | 2010-10-21 16:21:08 +0000 | [diff] [blame] | 1933 | // In C++, we can have a throw-expression, which has 'void' type. |
| 1934 | if (C->getRHS()->getType()->isVoidType()) |
| 1935 | return NULL; |
| 1936 | |
| 1937 | return EvalAddr(C->getRHS()); |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1938 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1939 | |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1940 | // For casts, we need to handle conversions from arrays to |
| 1941 | // pointer values, and pointer-to-pointer conversions. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1942 | case Stmt::ImplicitCastExprClass: |
Douglas Gregor | 6eec8e8 | 2008-10-28 15:36:24 +0000 | [diff] [blame] | 1943 | case Stmt::CStyleCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1944 | case Stmt::CXXFunctionalCastExprClass: { |
Argyrios Kyrtzidis | 0835a3c | 2008-08-18 23:01:59 +0000 | [diff] [blame] | 1945 | Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1946 | QualType T = SubExpr->getType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1947 | |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1948 | if (SubExpr->getType()->isPointerType() || |
| 1949 | SubExpr->getType()->isBlockPointerType() || |
| 1950 | SubExpr->getType()->isObjCQualifiedIdType()) |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1951 | return EvalAddr(SubExpr); |
| 1952 | else if (T->isArrayType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1953 | return EvalVal(SubExpr); |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1954 | else |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1955 | return 0; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1956 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1957 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1958 | // C++ casts. For dynamic casts, static casts, and const casts, we |
| 1959 | // are always converting from a pointer-to-pointer, so we just blow |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1960 | // through the cast. In the case the dynamic cast doesn't fail (and |
| 1961 | // return NULL), we take the conservative route and report cases |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1962 | // where we return the address of a stack variable. For Reinterpre |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1963 | // FIXME: The comment about is wrong; we're not always converting |
| 1964 | // from pointer to pointer. I'm guessing that this code should also |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1965 | // handle references to objects. |
| 1966 | case Stmt::CXXStaticCastExprClass: |
| 1967 | case Stmt::CXXDynamicCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1968 | case Stmt::CXXConstCastExprClass: |
| 1969 | case Stmt::CXXReinterpretCastExprClass: { |
| 1970 | Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1971 | if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1972 | return EvalAddr(S); |
| 1973 | else |
| 1974 | return NULL; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1975 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1976 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1977 | // Everything else: we simply don't reason about them. |
| 1978 | default: |
| 1979 | return NULL; |
| 1980 | } |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1981 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1982 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1983 | |
| 1984 | /// EvalVal - This function is complements EvalAddr in the mutual recursion. |
| 1985 | /// See the comments for EvalAddr for more details. |
| 1986 | static DeclRefExpr* EvalVal(Expr *E) { |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 1987 | do { |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1988 | // We should only be called for evaluating non-pointer expressions, or |
| 1989 | // expressions with a pointer type that are not used as references but instead |
| 1990 | // are l-values (e.g., DeclRefExpr with a pointer type). |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1991 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1992 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1993 | // viewed AST node. We then recursively traverse the AST by calling |
| 1994 | // EvalAddr and EvalVal appropriately. |
| 1995 | switch (E->getStmtClass()) { |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 1996 | case Stmt::ImplicitCastExprClass: { |
| 1997 | ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); |
John McCall | 5baba9d | 2010-08-25 10:28:54 +0000 | [diff] [blame] | 1998 | if (IE->getValueKind() == VK_LValue) { |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 1999 | E = IE->getSubExpr(); |
| 2000 | continue; |
| 2001 | } |
| 2002 | return NULL; |
| 2003 | } |
| 2004 | |
Douglas Gregor | a2813ce | 2009-10-23 18:54:35 +0000 | [diff] [blame] | 2005 | case Stmt::DeclRefExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2006 | // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking |
| 2007 | // at code that refers to a variable's name. We check if it has local |
| 2008 | // storage within the function, and if so, return the expression. |
| 2009 | DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2010 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2011 | if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2012 | if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR; |
| 2013 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2014 | return NULL; |
| 2015 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2016 | |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 2017 | case Stmt::ParenExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2018 | // Ignore parentheses. |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 2019 | E = cast<ParenExpr>(E)->getSubExpr(); |
| 2020 | continue; |
| 2021 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2022 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2023 | case Stmt::UnaryOperatorClass: { |
| 2024 | // The only unary operator that make sense to handle here |
| 2025 | // is Deref. All others don't resolve to a "name." This includes |
| 2026 | // handling all sorts of rvalues passed to a unary operator. |
| 2027 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2028 | |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2029 | if (U->getOpcode() == UO_Deref) |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2030 | return EvalAddr(U->getSubExpr()); |
| 2031 | |
| 2032 | return NULL; |
| 2033 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2034 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2035 | case Stmt::ArraySubscriptExprClass: { |
| 2036 | // Array subscripts are potential references to data on the stack. We |
| 2037 | // retrieve the DeclRefExpr* for the array variable if it indeed |
| 2038 | // has local storage. |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 2039 | return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2040 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2041 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2042 | case Stmt::ConditionalOperatorClass: { |
| 2043 | // For conditional operators we need to see if either the LHS or RHS are |
| 2044 | // non-NULL DeclRefExpr's. If one is non-NULL, we return it. |
| 2045 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
| 2046 | |
Anders Carlsson | 3907323 | 2007-11-30 19:04:31 +0000 | [diff] [blame] | 2047 | // Handle the GNU extension for missing LHS. |
| 2048 | if (Expr *lhsExpr = C->getLHS()) |
| 2049 | if (DeclRefExpr *LHS = EvalVal(lhsExpr)) |
| 2050 | return LHS; |
| 2051 | |
| 2052 | return EvalVal(C->getRHS()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2053 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2054 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2055 | // Accesses to members are potential references to data on the stack. |
Douglas Gregor | 83f6faf | 2009-08-31 23:41:50 +0000 | [diff] [blame] | 2056 | case Stmt::MemberExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2057 | MemberExpr *M = cast<MemberExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2058 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2059 | // Check for indirect access. We only want direct field accesses. |
Ted Kremenek | a423e81 | 2010-09-02 01:12:13 +0000 | [diff] [blame] | 2060 | if (M->isArrow()) |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2061 | return NULL; |
Ted Kremenek | a423e81 | 2010-09-02 01:12:13 +0000 | [diff] [blame] | 2062 | |
| 2063 | // Check whether the member type is itself a reference, in which case |
| 2064 | // we're not going to refer to the member, but to what the member refers to. |
| 2065 | if (M->getMemberDecl()->getType()->isReferenceType()) |
| 2066 | return NULL; |
| 2067 | |
| 2068 | return EvalVal(M->getBase()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2069 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2070 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2071 | // Everything else: we simply don't reason about them. |
| 2072 | default: |
| 2073 | return NULL; |
| 2074 | } |
Ted Kremenek | 68957a9 | 2010-08-04 20:01:07 +0000 | [diff] [blame] | 2075 | } while (true); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 2076 | } |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2077 | |
| 2078 | //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// |
| 2079 | |
| 2080 | /// Check for comparisons of floating point operands using != and ==. |
| 2081 | /// Issue a warning if these are no self-comparisons, as they are not likely |
| 2082 | /// to do what the programmer intended. |
| 2083 | void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { |
| 2084 | bool EmitWarning = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2085 | |
Ted Kremenek | 4e99a5f | 2008-01-17 16:57:34 +0000 | [diff] [blame] | 2086 | Expr* LeftExprSansParen = lex->IgnoreParens(); |
Ted Kremenek | 32e97b6 | 2008-01-17 17:55:13 +0000 | [diff] [blame] | 2087 | Expr* RightExprSansParen = rex->IgnoreParens(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2088 | |
| 2089 | // Special case: check for x == x (which is OK). |
| 2090 | // Do not emit warnings for such cases. |
| 2091 | if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) |
| 2092 | if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) |
| 2093 | if (DRL->getDecl() == DRR->getDecl()) |
| 2094 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2095 | |
| 2096 | |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 2097 | // Special case: check for comparisons against literals that can be exactly |
| 2098 | // represented by APFloat. In such cases, do not emit a warning. This |
| 2099 | // is a heuristic: often comparison against such literals are used to |
| 2100 | // detect if a value in a variable has not changed. This clearly can |
| 2101 | // lead to false negatives. |
| 2102 | if (EmitWarning) { |
| 2103 | if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { |
| 2104 | if (FLL->isExact()) |
| 2105 | EmitWarning = false; |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 2106 | } else |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 2107 | if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ |
| 2108 | if (FLR->isExact()) |
| 2109 | EmitWarning = false; |
| 2110 | } |
| 2111 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2112 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2113 | // Check for comparisons with builtin types. |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 2114 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2115 | if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 2116 | if (CL->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2117 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2118 | |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 2119 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2120 | if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 2121 | if (CR->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2122 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 2123 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2124 | // Emit the diagnostic. |
| 2125 | if (EmitWarning) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 2126 | Diag(loc, diag::warn_floatingpoint_eq) |
| 2127 | << lex->getSourceRange() << rex->getSourceRange(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 2128 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2129 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2130 | //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// |
| 2131 | //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2132 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2133 | namespace { |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2134 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2135 | /// Structure recording the 'active' range of an integer-valued |
| 2136 | /// expression. |
| 2137 | struct IntRange { |
| 2138 | /// The number of bits active in the int. |
| 2139 | unsigned Width; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2140 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2141 | /// True if the int is known not to have negative values. |
| 2142 | bool NonNegative; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2143 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2144 | IntRange(unsigned Width, bool NonNegative) |
| 2145 | : Width(Width), NonNegative(NonNegative) |
| 2146 | {} |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2147 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2148 | /// Returns the range of the bool type. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2149 | static IntRange forBoolType() { |
| 2150 | return IntRange(1, true); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2151 | } |
| 2152 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2153 | /// Returns the range of an opaque value of the given integral type. |
| 2154 | static IntRange forValueOfType(ASTContext &C, QualType T) { |
| 2155 | return forValueOfCanonicalType(C, |
| 2156 | T->getCanonicalTypeInternal().getTypePtr()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2157 | } |
| 2158 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2159 | /// Returns the range of an opaque value of a canonical integral type. |
| 2160 | static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2161 | assert(T->isCanonicalUnqualified()); |
| 2162 | |
| 2163 | if (const VectorType *VT = dyn_cast<VectorType>(T)) |
| 2164 | T = VT->getElementType().getTypePtr(); |
| 2165 | if (const ComplexType *CT = dyn_cast<ComplexType>(T)) |
| 2166 | T = CT->getElementType().getTypePtr(); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2167 | |
John McCall | 091f23f | 2010-11-09 22:22:12 +0000 | [diff] [blame] | 2168 | // For enum types, use the known bit width of the enumerators. |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2169 | if (const EnumType *ET = dyn_cast<EnumType>(T)) { |
| 2170 | EnumDecl *Enum = ET->getDecl(); |
John McCall | 091f23f | 2010-11-09 22:22:12 +0000 | [diff] [blame] | 2171 | if (!Enum->isDefinition()) |
| 2172 | return IntRange(C.getIntWidth(QualType(T, 0)), false); |
| 2173 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2174 | unsigned NumPositive = Enum->getNumPositiveBits(); |
| 2175 | unsigned NumNegative = Enum->getNumNegativeBits(); |
| 2176 | |
| 2177 | return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); |
| 2178 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2179 | |
| 2180 | const BuiltinType *BT = cast<BuiltinType>(T); |
| 2181 | assert(BT->isInteger()); |
| 2182 | |
| 2183 | return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); |
| 2184 | } |
| 2185 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2186 | /// Returns the "target" range of a canonical integral type, i.e. |
| 2187 | /// the range of values expressible in the type. |
| 2188 | /// |
| 2189 | /// This matches forValueOfCanonicalType except that enums have the |
| 2190 | /// full range of their type, not the range of their enumerators. |
| 2191 | static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { |
| 2192 | assert(T->isCanonicalUnqualified()); |
| 2193 | |
| 2194 | if (const VectorType *VT = dyn_cast<VectorType>(T)) |
| 2195 | T = VT->getElementType().getTypePtr(); |
| 2196 | if (const ComplexType *CT = dyn_cast<ComplexType>(T)) |
| 2197 | T = CT->getElementType().getTypePtr(); |
| 2198 | if (const EnumType *ET = dyn_cast<EnumType>(T)) |
| 2199 | T = ET->getDecl()->getIntegerType().getTypePtr(); |
| 2200 | |
| 2201 | const BuiltinType *BT = cast<BuiltinType>(T); |
| 2202 | assert(BT->isInteger()); |
| 2203 | |
| 2204 | return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); |
| 2205 | } |
| 2206 | |
| 2207 | /// Returns the supremum of two ranges: i.e. their conservative merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2208 | static IntRange join(IntRange L, IntRange R) { |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2209 | return IntRange(std::max(L.Width, R.Width), |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2210 | L.NonNegative && R.NonNegative); |
| 2211 | } |
| 2212 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2213 | /// Returns the infinum of two ranges: i.e. their aggressive merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2214 | static IntRange meet(IntRange L, IntRange R) { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2215 | return IntRange(std::min(L.Width, R.Width), |
| 2216 | L.NonNegative || R.NonNegative); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2217 | } |
| 2218 | }; |
| 2219 | |
| 2220 | IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { |
| 2221 | if (value.isSigned() && value.isNegative()) |
| 2222 | return IntRange(value.getMinSignedBits(), false); |
| 2223 | |
| 2224 | if (value.getBitWidth() > MaxWidth) |
| 2225 | value.trunc(MaxWidth); |
| 2226 | |
| 2227 | // isNonNegative() just checks the sign bit without considering |
| 2228 | // signedness. |
| 2229 | return IntRange(value.getActiveBits(), true); |
| 2230 | } |
| 2231 | |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2232 | IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2233 | unsigned MaxWidth) { |
| 2234 | if (result.isInt()) |
| 2235 | return GetValueRange(C, result.getInt(), MaxWidth); |
| 2236 | |
| 2237 | if (result.isVector()) { |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2238 | IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); |
| 2239 | for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { |
| 2240 | IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); |
| 2241 | R = IntRange::join(R, El); |
| 2242 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2243 | return R; |
| 2244 | } |
| 2245 | |
| 2246 | if (result.isComplexInt()) { |
| 2247 | IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); |
| 2248 | IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); |
| 2249 | return IntRange::join(R, I); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2250 | } |
| 2251 | |
| 2252 | // This can happen with lossless casts to intptr_t of "based" lvalues. |
| 2253 | // Assume it might use arbitrary bits. |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2254 | // FIXME: The only reason we need to pass the type in here is to get |
| 2255 | // the sign right on this one case. It would be nice if APValue |
| 2256 | // preserved this. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2257 | assert(result.isLValue()); |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2258 | return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2259 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2260 | |
| 2261 | /// Pseudo-evaluate the given integer expression, estimating the |
| 2262 | /// range of values it might take. |
| 2263 | /// |
| 2264 | /// \param MaxWidth - the width to which the value will be truncated |
| 2265 | IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { |
| 2266 | E = E->IgnoreParens(); |
| 2267 | |
| 2268 | // Try a full evaluation first. |
| 2269 | Expr::EvalResult result; |
| 2270 | if (E->Evaluate(result, C)) |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 2271 | return GetValueRange(C, result.Val, E->getType(), MaxWidth); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2272 | |
| 2273 | // I think we only want to look through implicit casts here; if the |
| 2274 | // user has an explicit widening cast, we should treat the value as |
| 2275 | // being of the new, wider type. |
| 2276 | if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2277 | if (CE->getCastKind() == CK_NoOp) |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2278 | return GetExprRange(C, CE->getSubExpr(), MaxWidth); |
| 2279 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2280 | IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2281 | |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2282 | bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); |
| 2283 | if (!isIntegerCast && CE->getCastKind() == CK_Unknown) |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2284 | isIntegerCast = CE->getSubExpr()->getType()->isIntegerType(); |
| 2285 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2286 | // Assume that non-integer casts can span the full range of the type. |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2287 | if (!isIntegerCast) |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2288 | return OutputTypeRange; |
| 2289 | |
| 2290 | IntRange SubRange |
| 2291 | = GetExprRange(C, CE->getSubExpr(), |
| 2292 | std::min(MaxWidth, OutputTypeRange.Width)); |
| 2293 | |
| 2294 | // Bail out if the subexpr's range is as wide as the cast type. |
| 2295 | if (SubRange.Width >= OutputTypeRange.Width) |
| 2296 | return OutputTypeRange; |
| 2297 | |
| 2298 | // Otherwise, we take the smaller width, and we're non-negative if |
| 2299 | // either the output type or the subexpr is. |
| 2300 | return IntRange(SubRange.Width, |
| 2301 | SubRange.NonNegative || OutputTypeRange.NonNegative); |
| 2302 | } |
| 2303 | |
| 2304 | if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { |
| 2305 | // If we can fold the condition, just take that operand. |
| 2306 | bool CondResult; |
| 2307 | if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) |
| 2308 | return GetExprRange(C, CondResult ? CO->getTrueExpr() |
| 2309 | : CO->getFalseExpr(), |
| 2310 | MaxWidth); |
| 2311 | |
| 2312 | // Otherwise, conservatively merge. |
| 2313 | IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); |
| 2314 | IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); |
| 2315 | return IntRange::join(L, R); |
| 2316 | } |
| 2317 | |
| 2318 | if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { |
| 2319 | switch (BO->getOpcode()) { |
| 2320 | |
| 2321 | // Boolean-valued operations are single-bit and positive. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2322 | case BO_LAnd: |
| 2323 | case BO_LOr: |
| 2324 | case BO_LT: |
| 2325 | case BO_GT: |
| 2326 | case BO_LE: |
| 2327 | case BO_GE: |
| 2328 | case BO_EQ: |
| 2329 | case BO_NE: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2330 | return IntRange::forBoolType(); |
| 2331 | |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2332 | // The type of these compound assignments is the type of the LHS, |
| 2333 | // so the RHS is not necessarily an integer. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2334 | case BO_MulAssign: |
| 2335 | case BO_DivAssign: |
| 2336 | case BO_RemAssign: |
| 2337 | case BO_AddAssign: |
| 2338 | case BO_SubAssign: |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2339 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 2340 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2341 | // Operations with opaque sources are black-listed. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2342 | case BO_PtrMemD: |
| 2343 | case BO_PtrMemI: |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2344 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2345 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2346 | // Bitwise-and uses the *infinum* of the two source ranges. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2347 | case BO_And: |
| 2348 | case BO_AndAssign: |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2349 | return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), |
| 2350 | GetExprRange(C, BO->getRHS(), MaxWidth)); |
| 2351 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2352 | // Left shift gets black-listed based on a judgement call. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2353 | case BO_Shl: |
John McCall | 3aae609 | 2010-04-07 01:14:35 +0000 | [diff] [blame] | 2354 | // ...except that we want to treat '1 << (blah)' as logically |
| 2355 | // positive. It's an important idiom. |
| 2356 | if (IntegerLiteral *I |
| 2357 | = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { |
| 2358 | if (I->getValue() == 1) { |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2359 | IntRange R = IntRange::forValueOfType(C, E->getType()); |
John McCall | 3aae609 | 2010-04-07 01:14:35 +0000 | [diff] [blame] | 2360 | return IntRange(R.Width, /*NonNegative*/ true); |
| 2361 | } |
| 2362 | } |
| 2363 | // fallthrough |
| 2364 | |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2365 | case BO_ShlAssign: |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2366 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2367 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2368 | // Right shift by a constant can narrow its left argument. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2369 | case BO_Shr: |
| 2370 | case BO_ShrAssign: { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2371 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 2372 | |
| 2373 | // If the shift amount is a positive constant, drop the width by |
| 2374 | // that much. |
| 2375 | llvm::APSInt shift; |
| 2376 | if (BO->getRHS()->isIntegerConstantExpr(shift, C) && |
| 2377 | shift.isNonNegative()) { |
| 2378 | unsigned zext = shift.getZExtValue(); |
| 2379 | if (zext >= L.Width) |
| 2380 | L.Width = (L.NonNegative ? 0 : 1); |
| 2381 | else |
| 2382 | L.Width -= zext; |
| 2383 | } |
| 2384 | |
| 2385 | return L; |
| 2386 | } |
| 2387 | |
| 2388 | // Comma acts as its right operand. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2389 | case BO_Comma: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2390 | return GetExprRange(C, BO->getRHS(), MaxWidth); |
| 2391 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 2392 | // Black-list pointer subtractions. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2393 | case BO_Sub: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2394 | if (BO->getLHS()->getType()->isPointerType()) |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2395 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2396 | // fallthrough |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 2397 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2398 | default: |
| 2399 | break; |
| 2400 | } |
| 2401 | |
| 2402 | // Treat every other operator as if it were closed on the |
| 2403 | // narrowest type that encompasses both operands. |
| 2404 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 2405 | IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); |
| 2406 | return IntRange::join(L, R); |
| 2407 | } |
| 2408 | |
| 2409 | if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { |
| 2410 | switch (UO->getOpcode()) { |
| 2411 | // Boolean-valued operations are white-listed. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2412 | case UO_LNot: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2413 | return IntRange::forBoolType(); |
| 2414 | |
| 2415 | // Operations with opaque sources are black-listed. |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2416 | case UO_Deref: |
| 2417 | case UO_AddrOf: // should be impossible |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2418 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2419 | |
| 2420 | default: |
| 2421 | return GetExprRange(C, UO->getSubExpr(), MaxWidth); |
| 2422 | } |
| 2423 | } |
Douglas Gregor | 8ecdb65 | 2010-04-28 22:16:22 +0000 | [diff] [blame] | 2424 | |
| 2425 | if (dyn_cast<OffsetOfExpr>(E)) { |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2426 | IntRange::forValueOfType(C, E->getType()); |
Douglas Gregor | 8ecdb65 | 2010-04-28 22:16:22 +0000 | [diff] [blame] | 2427 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2428 | |
| 2429 | FieldDecl *BitField = E->getBitField(); |
| 2430 | if (BitField) { |
| 2431 | llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); |
| 2432 | unsigned BitWidth = BitWidthAP.getZExtValue(); |
| 2433 | |
| 2434 | return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); |
| 2435 | } |
| 2436 | |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2437 | return IntRange::forValueOfType(C, E->getType()); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2438 | } |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2439 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2440 | IntRange GetExprRange(ASTContext &C, Expr *E) { |
| 2441 | return GetExprRange(C, E, C.getIntWidth(E->getType())); |
| 2442 | } |
| 2443 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2444 | /// Checks whether the given value, which currently has the given |
| 2445 | /// source semantics, has the same value when coerced through the |
| 2446 | /// target semantics. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2447 | bool IsSameFloatAfterCast(const llvm::APFloat &value, |
| 2448 | const llvm::fltSemantics &Src, |
| 2449 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2450 | llvm::APFloat truncated = value; |
| 2451 | |
| 2452 | bool ignored; |
| 2453 | truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 2454 | truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 2455 | |
| 2456 | return truncated.bitwiseIsEqual(value); |
| 2457 | } |
| 2458 | |
| 2459 | /// Checks whether the given value, which currently has the given |
| 2460 | /// source semantics, has the same value when coerced through the |
| 2461 | /// target semantics. |
| 2462 | /// |
| 2463 | /// The value might be a vector of floats (or a complex number). |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2464 | bool IsSameFloatAfterCast(const APValue &value, |
| 2465 | const llvm::fltSemantics &Src, |
| 2466 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2467 | if (value.isFloat()) |
| 2468 | return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); |
| 2469 | |
| 2470 | if (value.isVector()) { |
| 2471 | for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) |
| 2472 | if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) |
| 2473 | return false; |
| 2474 | return true; |
| 2475 | } |
| 2476 | |
| 2477 | assert(value.isComplexFloat()); |
| 2478 | return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && |
| 2479 | IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); |
| 2480 | } |
| 2481 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2482 | void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2483 | |
Ted Kremenek | e3b159c | 2010-09-23 21:43:44 +0000 | [diff] [blame] | 2484 | static bool IsZero(Sema &S, Expr *E) { |
| 2485 | // Suppress cases where we are comparing against an enum constant. |
| 2486 | if (const DeclRefExpr *DR = |
| 2487 | dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) |
| 2488 | if (isa<EnumConstantDecl>(DR->getDecl())) |
| 2489 | return false; |
| 2490 | |
| 2491 | // Suppress cases where the '0' value is expanded from a macro. |
| 2492 | if (E->getLocStart().isMacroID()) |
| 2493 | return false; |
| 2494 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2495 | llvm::APSInt Value; |
| 2496 | return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; |
| 2497 | } |
| 2498 | |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2499 | static bool HasEnumType(Expr *E) { |
| 2500 | // Strip off implicit integral promotions. |
| 2501 | while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { |
Argyrios Kyrtzidis | 63b57ae | 2010-10-07 21:52:18 +0000 | [diff] [blame] | 2502 | if (ICE->getCastKind() != CK_IntegralCast && |
| 2503 | ICE->getCastKind() != CK_NoOp) |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2504 | break; |
Argyrios Kyrtzidis | 63b57ae | 2010-10-07 21:52:18 +0000 | [diff] [blame] | 2505 | E = ICE->getSubExpr(); |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2506 | } |
| 2507 | |
| 2508 | return E->getType()->isEnumeralType(); |
| 2509 | } |
| 2510 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2511 | void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2512 | BinaryOperatorKind op = E->getOpcode(); |
| 2513 | if (op == BO_LT && IsZero(S, E->getRHS())) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2514 | S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2515 | << "< 0" << "false" << HasEnumType(E->getLHS()) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2516 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2517 | } else if (op == BO_GE && IsZero(S, E->getRHS())) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2518 | S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2519 | << ">= 0" << "true" << HasEnumType(E->getLHS()) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2520 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2521 | } else if (op == BO_GT && IsZero(S, E->getLHS())) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2522 | S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2523 | << "0 >" << "false" << HasEnumType(E->getRHS()) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2524 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
John McCall | 2de56d1 | 2010-08-25 11:45:40 +0000 | [diff] [blame] | 2525 | } else if (op == BO_LE && IsZero(S, E->getLHS())) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2526 | S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) |
John McCall | 372e103 | 2010-10-06 00:25:24 +0000 | [diff] [blame] | 2527 | << "0 <=" << "true" << HasEnumType(E->getRHS()) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2528 | << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); |
| 2529 | } |
| 2530 | } |
| 2531 | |
| 2532 | /// Analyze the operands of the given comparison. Implements the |
| 2533 | /// fallback case from AnalyzeComparison. |
| 2534 | void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2535 | AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); |
| 2536 | AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2537 | } |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2538 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2539 | /// \brief Implements -Wsign-compare. |
| 2540 | /// |
| 2541 | /// \param lex the left-hand expression |
| 2542 | /// \param rex the right-hand expression |
| 2543 | /// \param OpLoc the location of the joining operator |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2544 | /// \param BinOpc binary opcode or 0 |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2545 | void AnalyzeComparison(Sema &S, BinaryOperator *E) { |
| 2546 | // The type the comparison is being performed in. |
| 2547 | QualType T = E->getLHS()->getType(); |
| 2548 | assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) |
| 2549 | && "comparison with mismatched types"); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2550 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2551 | // We don't do anything special if this isn't an unsigned integral |
| 2552 | // comparison: we're only interested in integral comparisons, and |
| 2553 | // signed comparisons only happen in cases we don't care to warn about. |
Douglas Gregor | f609462 | 2010-07-23 15:58:24 +0000 | [diff] [blame] | 2554 | if (!T->hasUnsignedIntegerRepresentation()) |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2555 | return AnalyzeImpConvsInComparison(S, E); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2556 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2557 | Expr *lex = E->getLHS()->IgnoreParenImpCasts(); |
| 2558 | Expr *rex = E->getRHS()->IgnoreParenImpCasts(); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2559 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2560 | // Check to see if one of the (unmodified) operands is of different |
| 2561 | // signedness. |
| 2562 | Expr *signedOperand, *unsignedOperand; |
Douglas Gregor | f609462 | 2010-07-23 15:58:24 +0000 | [diff] [blame] | 2563 | if (lex->getType()->hasSignedIntegerRepresentation()) { |
| 2564 | assert(!rex->getType()->hasSignedIntegerRepresentation() && |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2565 | "unsigned comparison between two signed integer expressions?"); |
| 2566 | signedOperand = lex; |
| 2567 | unsignedOperand = rex; |
Douglas Gregor | f609462 | 2010-07-23 15:58:24 +0000 | [diff] [blame] | 2568 | } else if (rex->getType()->hasSignedIntegerRepresentation()) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2569 | signedOperand = rex; |
| 2570 | unsignedOperand = lex; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2571 | } else { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2572 | CheckTrivialUnsignedComparison(S, E); |
| 2573 | return AnalyzeImpConvsInComparison(S, E); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2574 | } |
| 2575 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2576 | // Otherwise, calculate the effective range of the signed operand. |
| 2577 | IntRange signedRange = GetExprRange(S.Context, signedOperand); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2578 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2579 | // Go ahead and analyze implicit conversions in the operands. Note |
| 2580 | // that we skip the implicit conversions on both sides. |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2581 | AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); |
| 2582 | AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2583 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2584 | // If the signed range is non-negative, -Wsign-compare won't fire, |
| 2585 | // but we should still check for comparisons which are always true |
| 2586 | // or false. |
| 2587 | if (signedRange.NonNegative) |
| 2588 | return CheckTrivialUnsignedComparison(S, E); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2589 | |
| 2590 | // For (in)equality comparisons, if the unsigned operand is a |
| 2591 | // constant which cannot collide with a overflowed signed operand, |
| 2592 | // then reinterpreting the signed operand as unsigned will not |
| 2593 | // change the result of the comparison. |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2594 | if (E->isEqualityOp()) { |
| 2595 | unsigned comparisonWidth = S.Context.getIntWidth(T); |
| 2596 | IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2597 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2598 | // We should never be unable to prove that the unsigned operand is |
| 2599 | // non-negative. |
| 2600 | assert(unsignedRange.NonNegative && "unsigned range includes negative?"); |
| 2601 | |
| 2602 | if (unsignedRange.Width < comparisonWidth) |
| 2603 | return; |
| 2604 | } |
| 2605 | |
| 2606 | S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) |
| 2607 | << lex->getType() << rex->getType() |
| 2608 | << lex->getSourceRange() << rex->getSourceRange(); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2609 | } |
| 2610 | |
John McCall | 15d7d12 | 2010-11-11 03:21:53 +0000 | [diff] [blame] | 2611 | /// Analyzes an attempt to assign the given value to a bitfield. |
| 2612 | /// |
| 2613 | /// Returns true if there was something fishy about the attempt. |
| 2614 | bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, |
| 2615 | SourceLocation InitLoc) { |
| 2616 | assert(Bitfield->isBitField()); |
| 2617 | if (Bitfield->isInvalidDecl()) |
| 2618 | return false; |
| 2619 | |
John McCall | 91b6014 | 2010-11-11 05:33:51 +0000 | [diff] [blame^] | 2620 | // White-list bool bitfields. |
| 2621 | if (Bitfield->getType()->isBooleanType()) |
| 2622 | return false; |
| 2623 | |
John McCall | 15d7d12 | 2010-11-11 03:21:53 +0000 | [diff] [blame] | 2624 | Expr *OriginalInit = Init->IgnoreParenImpCasts(); |
| 2625 | |
| 2626 | llvm::APSInt Width(32); |
| 2627 | Expr::EvalResult InitValue; |
| 2628 | if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || |
John McCall | 91b6014 | 2010-11-11 05:33:51 +0000 | [diff] [blame^] | 2629 | !OriginalInit->Evaluate(InitValue, S.Context) || |
John McCall | 15d7d12 | 2010-11-11 03:21:53 +0000 | [diff] [blame] | 2630 | !InitValue.Val.isInt()) |
| 2631 | return false; |
| 2632 | |
| 2633 | const llvm::APSInt &Value = InitValue.Val.getInt(); |
| 2634 | unsigned OriginalWidth = Value.getBitWidth(); |
| 2635 | unsigned FieldWidth = Width.getZExtValue(); |
| 2636 | |
| 2637 | if (OriginalWidth <= FieldWidth) |
| 2638 | return false; |
| 2639 | |
| 2640 | llvm::APSInt TruncatedValue = Value; |
| 2641 | TruncatedValue.trunc(FieldWidth); |
| 2642 | |
| 2643 | // It's fairly common to write values into signed bitfields |
| 2644 | // that, if sign-extended, would end up becoming a different |
| 2645 | // value. We don't want to warn about that. |
| 2646 | if (Value.isSigned() && Value.isNegative()) |
| 2647 | TruncatedValue.sext(OriginalWidth); |
| 2648 | else |
| 2649 | TruncatedValue.zext(OriginalWidth); |
| 2650 | |
| 2651 | if (Value == TruncatedValue) |
| 2652 | return false; |
| 2653 | |
| 2654 | std::string PrettyValue = Value.toString(10); |
| 2655 | std::string PrettyTrunc = TruncatedValue.toString(10); |
| 2656 | |
| 2657 | S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) |
| 2658 | << PrettyValue << PrettyTrunc << OriginalInit->getType() |
| 2659 | << Init->getSourceRange(); |
| 2660 | |
| 2661 | return true; |
| 2662 | } |
| 2663 | |
John McCall | beb22aa | 2010-11-09 23:24:47 +0000 | [diff] [blame] | 2664 | /// Analyze the given simple or compound assignment for warning-worthy |
| 2665 | /// operations. |
| 2666 | void AnalyzeAssignment(Sema &S, BinaryOperator *E) { |
| 2667 | // Just recurse on the LHS. |
| 2668 | AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); |
| 2669 | |
| 2670 | // We want to recurse on the RHS as normal unless we're assigning to |
| 2671 | // a bitfield. |
| 2672 | if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { |
John McCall | 15d7d12 | 2010-11-11 03:21:53 +0000 | [diff] [blame] | 2673 | if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), |
| 2674 | E->getOperatorLoc())) { |
| 2675 | // Recurse, ignoring any implicit conversions on the RHS. |
| 2676 | return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), |
| 2677 | E->getOperatorLoc()); |
John McCall | beb22aa | 2010-11-09 23:24:47 +0000 | [diff] [blame] | 2678 | } |
| 2679 | } |
| 2680 | |
| 2681 | AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); |
| 2682 | } |
| 2683 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2684 | /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2685 | void DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, |
| 2686 | unsigned diag) { |
| 2687 | S.Diag(E->getExprLoc(), diag) |
| 2688 | << E->getType() << T << E->getSourceRange() << SourceRange(CContext); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2689 | } |
| 2690 | |
John McCall | 091f23f | 2010-11-09 22:22:12 +0000 | [diff] [blame] | 2691 | std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { |
| 2692 | if (!Range.Width) return "0"; |
| 2693 | |
| 2694 | llvm::APSInt ValueInRange = Value; |
| 2695 | ValueInRange.setIsSigned(!Range.NonNegative); |
| 2696 | ValueInRange.trunc(Range.Width); |
| 2697 | return ValueInRange.toString(10); |
| 2698 | } |
| 2699 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2700 | void CheckImplicitConversion(Sema &S, Expr *E, QualType T, |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2701 | SourceLocation CC, bool *ICContext = 0) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2702 | if (E->isTypeDependent() || E->isValueDependent()) return; |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2703 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2704 | const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); |
| 2705 | const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); |
| 2706 | if (Source == Target) return; |
| 2707 | if (Target->isDependentType()) return; |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2708 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2709 | // If the conversion context location is invalid or instantiated |
| 2710 | // from a system macro, don't complain. |
| 2711 | if (CC.isInvalid() || |
| 2712 | (CC.isMacroID() && S.Context.getSourceManager().isInSystemHeader( |
| 2713 | S.Context.getSourceManager().getSpellingLoc(CC)))) |
| 2714 | return; |
| 2715 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2716 | // Never diagnose implicit casts to bool. |
| 2717 | if (Target->isSpecificBuiltinType(BuiltinType::Bool)) |
| 2718 | return; |
| 2719 | |
| 2720 | // Strip vector types. |
| 2721 | if (isa<VectorType>(Source)) { |
| 2722 | if (!isa<VectorType>(Target)) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2723 | return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2724 | |
| 2725 | Source = cast<VectorType>(Source)->getElementType().getTypePtr(); |
| 2726 | Target = cast<VectorType>(Target)->getElementType().getTypePtr(); |
| 2727 | } |
| 2728 | |
| 2729 | // Strip complex types. |
| 2730 | if (isa<ComplexType>(Source)) { |
| 2731 | if (!isa<ComplexType>(Target)) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2732 | return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2733 | |
| 2734 | Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); |
| 2735 | Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); |
| 2736 | } |
| 2737 | |
| 2738 | const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); |
| 2739 | const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); |
| 2740 | |
| 2741 | // If the source is floating point... |
| 2742 | if (SourceBT && SourceBT->isFloatingPoint()) { |
| 2743 | // ...and the target is floating point... |
| 2744 | if (TargetBT && TargetBT->isFloatingPoint()) { |
| 2745 | // ...then warn if we're dropping FP rank. |
| 2746 | |
| 2747 | // Builtin FP kinds are ordered by increasing FP rank. |
| 2748 | if (SourceBT->getKind() > TargetBT->getKind()) { |
| 2749 | // Don't warn about float constants that are precisely |
| 2750 | // representable in the target type. |
| 2751 | Expr::EvalResult result; |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2752 | if (E->Evaluate(result, S.Context)) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2753 | // Value might be a float, a float vector, or a float complex. |
| 2754 | if (IsSameFloatAfterCast(result.Val, |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2755 | S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), |
| 2756 | S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2757 | return; |
| 2758 | } |
| 2759 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2760 | DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2761 | } |
| 2762 | return; |
| 2763 | } |
| 2764 | |
| 2765 | // If the target is integral, always warn. |
| 2766 | if ((TargetBT && TargetBT->isInteger())) |
| 2767 | // TODO: don't warn for integer values? |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2768 | DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2769 | |
| 2770 | return; |
| 2771 | } |
| 2772 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2773 | if (!Source->isIntegerType() || !Target->isIntegerType()) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2774 | return; |
| 2775 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2776 | IntRange SourceRange = GetExprRange(S.Context, E); |
John McCall | 1844a6e | 2010-11-10 23:38:19 +0000 | [diff] [blame] | 2777 | IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2778 | |
| 2779 | if (SourceRange.Width > TargetRange.Width) { |
John McCall | 091f23f | 2010-11-09 22:22:12 +0000 | [diff] [blame] | 2780 | // If the source is a constant, use a default-on diagnostic. |
| 2781 | // TODO: this should happen for bitfield stores, too. |
| 2782 | llvm::APSInt Value(32); |
| 2783 | if (E->isIntegerConstantExpr(Value, S.Context)) { |
| 2784 | std::string PrettySourceValue = Value.toString(10); |
| 2785 | std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); |
| 2786 | |
| 2787 | S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) |
| 2788 | << PrettySourceValue << PrettyTargetValue |
| 2789 | << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); |
| 2790 | return; |
| 2791 | } |
| 2792 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2793 | // People want to build with -Wshorten-64-to-32 and not -Wconversion |
| 2794 | // and by god we'll let them. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2795 | if (SourceRange.Width == 64 && TargetRange.Width == 32) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2796 | return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); |
| 2797 | return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2798 | } |
| 2799 | |
| 2800 | if ((TargetRange.NonNegative && !SourceRange.NonNegative) || |
| 2801 | (!TargetRange.NonNegative && SourceRange.NonNegative && |
| 2802 | SourceRange.Width == TargetRange.Width)) { |
| 2803 | unsigned DiagID = diag::warn_impcast_integer_sign; |
| 2804 | |
| 2805 | // Traditionally, gcc has warned about this under -Wsign-compare. |
| 2806 | // We also want to warn about it in -Wconversion. |
| 2807 | // So if -Wconversion is off, use a completely identical diagnostic |
| 2808 | // in the sign-compare group. |
| 2809 | // The conditional-checking code will |
| 2810 | if (ICContext) { |
| 2811 | DiagID = diag::warn_impcast_integer_sign_conditional; |
| 2812 | *ICContext = true; |
| 2813 | } |
| 2814 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2815 | return DiagnoseImpCast(S, E, T, CC, DiagID); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2816 | } |
| 2817 | |
| 2818 | return; |
| 2819 | } |
| 2820 | |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2821 | void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); |
| 2822 | |
| 2823 | void CheckConditionalOperand(Sema &S, Expr *E, QualType T, |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2824 | SourceLocation CC, bool &ICContext) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2825 | E = E->IgnoreParenImpCasts(); |
| 2826 | |
| 2827 | if (isa<ConditionalOperator>(E)) |
| 2828 | return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); |
| 2829 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2830 | AnalyzeImplicitConversions(S, E, CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2831 | if (E->getType() != T) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2832 | return CheckImplicitConversion(S, E, T, CC, &ICContext); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2833 | return; |
| 2834 | } |
| 2835 | |
| 2836 | void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2837 | SourceLocation CC = E->getQuestionLoc(); |
| 2838 | |
| 2839 | AnalyzeImplicitConversions(S, E->getCond(), CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2840 | |
| 2841 | bool Suspicious = false; |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2842 | CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); |
| 2843 | CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2844 | |
| 2845 | // If -Wconversion would have warned about either of the candidates |
| 2846 | // for a signedness conversion to the context type... |
| 2847 | if (!Suspicious) return; |
| 2848 | |
| 2849 | // ...but it's currently ignored... |
| 2850 | if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional)) |
| 2851 | return; |
| 2852 | |
| 2853 | // ...and -Wsign-compare isn't... |
| 2854 | if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional)) |
| 2855 | return; |
| 2856 | |
| 2857 | // ...then check whether it would have warned about either of the |
| 2858 | // candidates for a signedness conversion to the condition type. |
| 2859 | if (E->getType() != T) { |
| 2860 | Suspicious = false; |
| 2861 | CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2862 | E->getType(), CC, &Suspicious); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2863 | if (!Suspicious) |
| 2864 | CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2865 | E->getType(), CC, &Suspicious); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2866 | if (!Suspicious) |
| 2867 | return; |
| 2868 | } |
| 2869 | |
| 2870 | // If so, emit a diagnostic under -Wsign-compare. |
| 2871 | Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); |
| 2872 | Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); |
| 2873 | S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) |
| 2874 | << lex->getType() << rex->getType() |
| 2875 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2876 | } |
| 2877 | |
| 2878 | /// AnalyzeImplicitConversions - Find and report any interesting |
| 2879 | /// implicit conversions in the given expression. There are a couple |
| 2880 | /// of competing diagnostics here, -Wconversion and -Wsign-compare. |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2881 | void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2882 | QualType T = OrigE->getType(); |
| 2883 | Expr *E = OrigE->IgnoreParenImpCasts(); |
| 2884 | |
| 2885 | // For conditional operators, we analyze the arguments as if they |
| 2886 | // were being fed directly into the output. |
| 2887 | if (isa<ConditionalOperator>(E)) { |
| 2888 | ConditionalOperator *CO = cast<ConditionalOperator>(E); |
| 2889 | CheckConditionalOperator(S, CO, T); |
| 2890 | return; |
| 2891 | } |
| 2892 | |
| 2893 | // Go ahead and check any implicit conversions we might have skipped. |
| 2894 | // The non-canonical typecheck is just an optimization; |
| 2895 | // CheckImplicitConversion will filter out dead implicit conversions. |
| 2896 | if (E->getType() != T) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2897 | CheckImplicitConversion(S, E, T, CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2898 | |
| 2899 | // Now continue drilling into this expression. |
| 2900 | |
| 2901 | // Skip past explicit casts. |
| 2902 | if (isa<ExplicitCastExpr>(E)) { |
| 2903 | E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2904 | return AnalyzeImplicitConversions(S, E, CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2905 | } |
| 2906 | |
John McCall | beb22aa | 2010-11-09 23:24:47 +0000 | [diff] [blame] | 2907 | if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { |
| 2908 | // Do a somewhat different check with comparison operators. |
| 2909 | if (BO->isComparisonOp()) |
| 2910 | return AnalyzeComparison(S, BO); |
| 2911 | |
| 2912 | // And with assignments and compound assignments. |
| 2913 | if (BO->isAssignmentOp()) |
| 2914 | return AnalyzeAssignment(S, BO); |
| 2915 | } |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2916 | |
| 2917 | // These break the otherwise-useful invariant below. Fortunately, |
| 2918 | // we don't really need to recurse into them, because any internal |
| 2919 | // expressions should have been analyzed already when they were |
| 2920 | // built into statements. |
| 2921 | if (isa<StmtExpr>(E)) return; |
| 2922 | |
| 2923 | // Don't descend into unevaluated contexts. |
| 2924 | if (isa<SizeOfAlignOfExpr>(E)) return; |
| 2925 | |
| 2926 | // Now just recurse over the expression's children. |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2927 | CC = E->getExprLoc(); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2928 | for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end(); |
| 2929 | I != IE; ++I) |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2930 | AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2931 | } |
| 2932 | |
| 2933 | } // end anonymous namespace |
| 2934 | |
| 2935 | /// Diagnoses "dangerous" implicit conversions within the given |
| 2936 | /// expression (which is a full expression). Implements -Wconversion |
| 2937 | /// and -Wsign-compare. |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2938 | /// |
| 2939 | /// \param CC the "context" location of the implicit conversion, i.e. |
| 2940 | /// the most location of the syntactic entity requiring the implicit |
| 2941 | /// conversion |
| 2942 | void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2943 | // Don't diagnose in unevaluated contexts. |
| 2944 | if (ExprEvalContexts.back().Context == Sema::Unevaluated) |
| 2945 | return; |
| 2946 | |
| 2947 | // Don't diagnose for value- or type-dependent expressions. |
| 2948 | if (E->isTypeDependent() || E->isValueDependent()) |
| 2949 | return; |
| 2950 | |
John McCall | b4eb64d | 2010-10-08 02:01:28 +0000 | [diff] [blame] | 2951 | // This is not the right CC for (e.g.) a variable initialization. |
| 2952 | AnalyzeImplicitConversions(*this, E, CC); |
John McCall | 323ed74 | 2010-05-06 08:58:33 +0000 | [diff] [blame] | 2953 | } |
| 2954 | |
John McCall | 15d7d12 | 2010-11-11 03:21:53 +0000 | [diff] [blame] | 2955 | void Sema::CheckBitFieldInitialization(SourceLocation InitLoc, |
| 2956 | FieldDecl *BitField, |
| 2957 | Expr *Init) { |
| 2958 | (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); |
| 2959 | } |
| 2960 | |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2961 | /// CheckParmsForFunctionDef - Check that the parameters of the given |
| 2962 | /// function are appropriate for the definition of a function. This |
| 2963 | /// takes care of any checks that cannot be performed on the |
| 2964 | /// declaration itself, e.g., that the types of each of the function |
| 2965 | /// parameters are complete. |
Douglas Gregor | 82aa713 | 2010-11-01 18:37:59 +0000 | [diff] [blame] | 2966 | bool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, |
| 2967 | bool CheckParameterNames) { |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2968 | bool HasInvalidParm = false; |
Douglas Gregor | 82aa713 | 2010-11-01 18:37:59 +0000 | [diff] [blame] | 2969 | for (; P != PEnd; ++P) { |
| 2970 | ParmVarDecl *Param = *P; |
| 2971 | |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2972 | // C99 6.7.5.3p4: the parameters in a parameter type list in a |
| 2973 | // function declarator that is part of a function definition of |
| 2974 | // that function shall not have incomplete type. |
| 2975 | // |
| 2976 | // This is also C++ [dcl.fct]p6. |
| 2977 | if (!Param->isInvalidDecl() && |
| 2978 | RequireCompleteType(Param->getLocation(), Param->getType(), |
| 2979 | diag::err_typecheck_decl_incomplete_type)) { |
| 2980 | Param->setInvalidDecl(); |
| 2981 | HasInvalidParm = true; |
| 2982 | } |
| 2983 | |
| 2984 | // C99 6.9.1p5: If the declarator includes a parameter type list, the |
| 2985 | // declaration of each parameter shall include an identifier. |
Douglas Gregor | 82aa713 | 2010-11-01 18:37:59 +0000 | [diff] [blame] | 2986 | if (CheckParameterNames && |
| 2987 | Param->getIdentifier() == 0 && |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2988 | !Param->isImplicit() && |
| 2989 | !getLangOptions().CPlusPlus) |
| 2990 | Diag(Param->getLocation(), diag::err_parameter_name_omitted); |
Sam Weinig | d17e340 | 2010-02-01 05:02:49 +0000 | [diff] [blame] | 2991 | |
| 2992 | // C99 6.7.5.3p12: |
| 2993 | // If the function declarator is not part of a definition of that |
| 2994 | // function, parameters may have incomplete type and may use the [*] |
| 2995 | // notation in their sequences of declarator specifiers to specify |
| 2996 | // variable length array types. |
| 2997 | QualType PType = Param->getOriginalType(); |
| 2998 | if (const ArrayType *AT = Context.getAsArrayType(PType)) { |
| 2999 | if (AT->getSizeModifier() == ArrayType::Star) { |
| 3000 | // FIXME: This diagnosic should point the the '[*]' if source-location |
| 3001 | // information is added for it. |
| 3002 | Diag(Param->getLocation(), diag::err_array_star_in_function_definition); |
| 3003 | } |
| 3004 | } |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 3005 | } |
| 3006 | |
| 3007 | return HasInvalidParm; |
| 3008 | } |
John McCall | b7f4ffe | 2010-08-12 21:44:57 +0000 | [diff] [blame] | 3009 | |
| 3010 | /// CheckCastAlign - Implements -Wcast-align, which warns when a |
| 3011 | /// pointer cast increases the alignment requirements. |
| 3012 | void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { |
| 3013 | // This is actually a lot of work to potentially be doing on every |
| 3014 | // cast; don't do it if we're ignoring -Wcast_align (as is the default). |
| 3015 | if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align) |
| 3016 | == Diagnostic::Ignored) |
| 3017 | return; |
| 3018 | |
| 3019 | // Ignore dependent types. |
| 3020 | if (T->isDependentType() || Op->getType()->isDependentType()) |
| 3021 | return; |
| 3022 | |
| 3023 | // Require that the destination be a pointer type. |
| 3024 | const PointerType *DestPtr = T->getAs<PointerType>(); |
| 3025 | if (!DestPtr) return; |
| 3026 | |
| 3027 | // If the destination has alignment 1, we're done. |
| 3028 | QualType DestPointee = DestPtr->getPointeeType(); |
| 3029 | if (DestPointee->isIncompleteType()) return; |
| 3030 | CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); |
| 3031 | if (DestAlign.isOne()) return; |
| 3032 | |
| 3033 | // Require that the source be a pointer type. |
| 3034 | const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); |
| 3035 | if (!SrcPtr) return; |
| 3036 | QualType SrcPointee = SrcPtr->getPointeeType(); |
| 3037 | |
| 3038 | // Whitelist casts from cv void*. We already implicitly |
| 3039 | // whitelisted casts to cv void*, since they have alignment 1. |
| 3040 | // Also whitelist casts involving incomplete types, which implicitly |
| 3041 | // includes 'void'. |
| 3042 | if (SrcPointee->isIncompleteType()) return; |
| 3043 | |
| 3044 | CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); |
| 3045 | if (SrcAlign >= DestAlign) return; |
| 3046 | |
| 3047 | Diag(TRange.getBegin(), diag::warn_cast_align) |
| 3048 | << Op->getType() << T |
| 3049 | << static_cast<unsigned>(SrcAlign.getQuantity()) |
| 3050 | << static_cast<unsigned>(DestAlign.getQuantity()) |
| 3051 | << TRange << Op->getSourceRange(); |
| 3052 | } |
| 3053 | |