blob: b3107c84476e8b3da52f27005afe3cbd1f4aa816 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordan Rosef540c542012-07-26 21:39:41 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000037 enum Kind { // Reference to allocated memory.
38 Allocated,
39 // Reference to released/freed memory.
40 Released,
Anna Zaks050cdd72012-06-20 20:57:46 +000041 // The responsibility for freeing resources has transfered from
42 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000043 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000044 const Stmt *S;
45
Zhongxing Xu7fb14642009-12-11 00:55:44 +000046public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000047 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
48
Anna Zaks050cdd72012-06-20 20:57:46 +000049 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000050 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000051 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000052
Anna Zaksc8bb3be2012-02-13 18:05:39 +000053 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000054
55 bool operator==(const RefState &X) const {
56 return K == X.K && S == X.S;
57 }
58
Anna Zaks050cdd72012-06-20 20:57:46 +000059 static RefState getAllocated(const Stmt *s) {
60 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000061 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000062 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000063 static RefState getRelinquished(const Stmt *s) {
64 return RefState(Relinquished, s);
65 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000066
67 void Profile(llvm::FoldingSetNodeID &ID) const {
68 ID.AddInteger(K);
69 ID.AddPointer(S);
70 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000071};
72
Anna Zaks55dd9562012-08-24 02:28:20 +000073/// \class ReallocPair
74/// \brief Stores information about the symbol being reallocated by a call to
75/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaks40add292012-02-15 00:11:25 +000076struct ReallocPair {
Anna Zaks55dd9562012-08-24 02:28:20 +000077 // \brief The symbol which realloc reallocated.
Anna Zaks40add292012-02-15 00:11:25 +000078 SymbolRef ReallocatedSym;
Anna Zaks55dd9562012-08-24 02:28:20 +000079 // \brief The flag is true if the symbol does not need to be freed after
80 // reallocation fails.
Anna Zaks40add292012-02-15 00:11:25 +000081 bool IsFreeOnFailure;
Anna Zaks55dd9562012-08-24 02:28:20 +000082
Anna Zaks40add292012-02-15 00:11:25 +000083 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
84 void Profile(llvm::FoldingSetNodeID &ID) const {
85 ID.AddInteger(IsFreeOnFailure);
86 ID.AddPointer(ReallocatedSym);
87 }
88 bool operator==(const ReallocPair &X) const {
89 return ReallocatedSym == X.ReallocatedSym &&
90 IsFreeOnFailure == X.IsFreeOnFailure;
91 }
92};
93
Anna Zaks3d7c44e2012-03-21 19:45:08 +000094typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
95
Anna Zaksb319e022012-02-08 20:13:28 +000096class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000097 check::EndPath,
98 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000099 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +0000100 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000101 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000102 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000103 check::Location,
104 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000105 eval::Assume,
106 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000107{
Anna Zaksfebdc322012-02-16 22:26:12 +0000108 mutable OwningPtr<BugType> BT_DoubleFree;
109 mutable OwningPtr<BugType> BT_Leak;
110 mutable OwningPtr<BugType> BT_UseFree;
111 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000112 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000113 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
114
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000115public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000116 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000117 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000118
119 /// In pessimistic mode, the checker assumes that it does not know which
120 /// functions might free the memory.
121 struct ChecksFilter {
122 DefaultBool CMallocPessimistic;
123 DefaultBool CMallocOptimistic;
124 };
125
126 ChecksFilter Filter;
127
Anna Zaks66c40402012-02-14 21:55:24 +0000128 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000129 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Jordan Rosede507ea2012-07-02 19:28:04 +0000130 void checkPreObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000131 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000132 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000133 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000134 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000135 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000136 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000137 void checkLocation(SVal l, bool isLoad, const Stmt *S,
138 CheckerContext &C) const;
139 void checkBind(SVal location, SVal val, const Stmt*S,
140 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000141 ProgramStateRef
142 checkRegionChanges(ProgramStateRef state,
143 const StoreManager::InvalidatedSymbols *invalidated,
144 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000145 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +0000146 const CallEvent *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000147 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
148 return true;
149 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000150
Anna Zaks93c5a242012-05-02 00:05:20 +0000151 void printState(raw_ostream &Out, ProgramStateRef State,
152 const char *NL, const char *Sep) const;
153
Zhongxing Xu7b760962009-11-13 07:25:27 +0000154private:
Anna Zaks66c40402012-02-14 21:55:24 +0000155 void initIdentifierInfo(ASTContext &C) const;
156
157 /// Check if this is one of the functions which can allocate/reallocate memory
158 /// pointed to by one of its arguments.
159 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000160 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
161 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000162
Anna Zaks87cb5be2012-02-22 19:24:52 +0000163 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
164 const CallExpr *CE,
165 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000166 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000167 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000168 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000169 return MallocMemAux(C, CE,
170 state->getSVal(SizeEx, C.getLocationContext()),
171 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000172 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000173
Ted Kremenek8bef8232012-01-26 21:29:00 +0000174 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000175 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000176 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000177
Anna Zaks87cb5be2012-02-22 19:24:52 +0000178 /// Update the RefState to reflect the new memory allocation.
179 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
180 const CallExpr *CE,
181 ProgramStateRef state);
182
183 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
184 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000185 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000186 ProgramStateRef state, unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000187 bool Hold,
188 bool &ReleasedAllocated) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000189 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
190 const Expr *ParentExpr,
191 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000192 bool Hold,
193 bool &ReleasedAllocated) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000194
Anna Zaks87cb5be2012-02-22 19:24:52 +0000195 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
196 bool FreesMemOnFailure) const;
197 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000198
Anna Zaks14345182012-05-18 01:16:10 +0000199 ///\brief Check if the memory associated with this symbol was released.
200 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
201
Anna Zaks91c2a112012-02-08 23:16:56 +0000202 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
203 const Stmt *S = 0) const;
204
Anna Zaks66c40402012-02-14 21:55:24 +0000205 /// Check if the function is not known to us. So, for example, we could
206 /// conservatively assume it can free/reallocate it's pointer arguments.
Jordan Rose740d4902012-07-02 19:27:35 +0000207 bool doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000208 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000209
Ted Kremenek9c378f72011-08-12 23:37:29 +0000210 static bool SummarizeValue(raw_ostream &os, SVal V);
211 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000212 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000213
Anna Zaksca8e36e2012-02-23 21:38:21 +0000214 /// Find the location of the allocation for Sym on the path leading to the
215 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000216 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
217 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000218
Anna Zaksda046772012-02-11 21:02:40 +0000219 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
220
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221 /// The bug visitor which allows us to print extra diagnostics along the
222 /// BugReport path. For example, showing the allocation site of the leaked
223 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000224 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000225 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000226 enum NotificationMode {
227 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000228 ReallocationFailed
229 };
230
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000231 // The allocated region symbol tracked by the main analysis.
232 SymbolRef Sym;
233
Anna Zaks88feba02012-05-10 01:37:40 +0000234 // The mode we are in, i.e. what kind of diagnostics will be emitted.
235 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000236
Anna Zaks88feba02012-05-10 01:37:40 +0000237 // A symbol from when the primary region should have been reallocated.
238 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000239
Anna Zaks88feba02012-05-10 01:37:40 +0000240 bool IsLeak;
241
242 public:
243 MallocBugVisitor(SymbolRef S, bool isLeak = false)
244 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000245
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000246 virtual ~MallocBugVisitor() {}
247
248 void Profile(llvm::FoldingSetNodeID &ID) const {
249 static int X = 0;
250 ID.AddPointer(&X);
251 ID.AddPointer(Sym);
252 }
253
Anna Zaksfe571602012-02-16 22:26:07 +0000254 inline bool isAllocated(const RefState *S, const RefState *SPrev,
255 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000256 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000257 return (Stmt && isa<CallExpr>(Stmt) &&
258 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000259 }
260
Anna Zaksfe571602012-02-16 22:26:07 +0000261 inline bool isReleased(const RefState *S, const RefState *SPrev,
262 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000263 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000264 return (Stmt && isa<CallExpr>(Stmt) &&
265 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
266 }
267
Anna Zaks5b7aa342012-06-22 02:04:31 +0000268 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
269 const Stmt *Stmt) {
270 // Did not track -> relinquished. Other state (allocated) -> relinquished.
271 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
272 isa<ObjCPropertyRefExpr>(Stmt)) &&
273 (S && S->isRelinquished()) &&
274 (!SPrev || !SPrev->isRelinquished()));
275 }
276
Anna Zaksfe571602012-02-16 22:26:07 +0000277 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
278 const Stmt *Stmt) {
279 // If the expression is not a call, and the state change is
280 // released -> allocated, it must be the realloc return value
281 // check. If we have to handle more cases here, it might be cleaner just
282 // to track this extra bit in the state itself.
283 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
284 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000285 }
286
287 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
288 const ExplodedNode *PrevN,
289 BugReporterContext &BRC,
290 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000291
292 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
293 const ExplodedNode *EndPathNode,
294 BugReport &BR) {
295 if (!IsLeak)
296 return 0;
297
298 PathDiagnosticLocation L =
299 PathDiagnosticLocation::createEndOfPath(EndPathNode,
300 BRC.getSourceManager());
301 // Do not add the statement itself as a range in case of leak.
302 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
303 }
304
Anna Zaks56a938f2012-03-16 23:24:20 +0000305 private:
306 class StackHintGeneratorForReallocationFailed
307 : public StackHintGeneratorForSymbol {
308 public:
309 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
310 : StackHintGeneratorForSymbol(S, M) {}
311
312 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
313 SmallString<200> buf;
314 llvm::raw_svector_ostream os(buf);
315
Anna Zaksfbd58742012-03-16 23:44:28 +0000316 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000317 // Printed parameters start at 1, not 0.
318 printOrdinal(++ArgIndex, os);
319 os << " parameter failed";
320
321 return os.str();
322 }
323
324 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000325 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000326 }
327 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000328 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000329};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000330} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000331
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000332typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000333typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000334class RegionState {};
335class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000336namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000337namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000338 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000339 struct ProgramStateTrait<RegionState>
340 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000341 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000342 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000343
344 template <>
345 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000346 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000347 static void *GDMIndex() { static int x; return &x; }
348 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000349}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000350}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000351
Anna Zaks4fb54872012-02-11 21:02:35 +0000352namespace {
353class StopTrackingCallback : public SymbolVisitor {
354 ProgramStateRef state;
355public:
356 StopTrackingCallback(ProgramStateRef st) : state(st) {}
357 ProgramStateRef getState() const { return state; }
358
359 bool VisitSymbol(SymbolRef sym) {
360 state = state->remove<RegionState>(sym);
361 return true;
362 }
363};
364} // end anonymous namespace
365
Anna Zaks66c40402012-02-14 21:55:24 +0000366void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000367 if (II_malloc)
368 return;
369 II_malloc = &Ctx.Idents.get("malloc");
370 II_free = &Ctx.Idents.get("free");
371 II_realloc = &Ctx.Idents.get("realloc");
372 II_reallocf = &Ctx.Idents.get("reallocf");
373 II_calloc = &Ctx.Idents.get("calloc");
374 II_valloc = &Ctx.Idents.get("valloc");
375 II_strdup = &Ctx.Idents.get("strdup");
376 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000377}
378
Anna Zaks66c40402012-02-14 21:55:24 +0000379bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000380 if (isFreeFunction(FD, C))
381 return true;
382
383 if (isAllocationFunction(FD, C))
384 return true;
385
386 return false;
387}
388
389bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
390 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000391 if (!FD)
392 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000393
Jordan Rose5ef6e942012-07-10 23:13:01 +0000394 if (FD->getKind() == Decl::Function) {
395 IdentifierInfo *FunI = FD->getIdentifier();
396 initIdentifierInfo(C);
Anna Zaks66c40402012-02-14 21:55:24 +0000397
Jordan Rose5ef6e942012-07-10 23:13:01 +0000398 if (FunI == II_malloc || FunI == II_realloc ||
399 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
400 FunI == II_strdup || FunI == II_strndup)
401 return true;
402 }
Anna Zaks66c40402012-02-14 21:55:24 +0000403
Anna Zaks14345182012-05-18 01:16:10 +0000404 if (Filter.CMallocOptimistic && FD->hasAttrs())
405 for (specific_attr_iterator<OwnershipAttr>
406 i = FD->specific_attr_begin<OwnershipAttr>(),
407 e = FD->specific_attr_end<OwnershipAttr>();
408 i != e; ++i)
409 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
410 return true;
411 return false;
412}
413
414bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
415 if (!FD)
416 return false;
417
Jordan Rose5ef6e942012-07-10 23:13:01 +0000418 if (FD->getKind() == Decl::Function) {
419 IdentifierInfo *FunI = FD->getIdentifier();
420 initIdentifierInfo(C);
Anna Zaks14345182012-05-18 01:16:10 +0000421
Jordan Rose5ef6e942012-07-10 23:13:01 +0000422 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
423 return true;
424 }
Anna Zaks66c40402012-02-14 21:55:24 +0000425
Anna Zaks14345182012-05-18 01:16:10 +0000426 if (Filter.CMallocOptimistic && FD->hasAttrs())
427 for (specific_attr_iterator<OwnershipAttr>
428 i = FD->specific_attr_begin<OwnershipAttr>(),
429 e = FD->specific_attr_end<OwnershipAttr>();
430 i != e; ++i)
431 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
432 (*i)->getOwnKind() == OwnershipAttr::Holds)
433 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000434 return false;
435}
436
Anna Zaksb319e022012-02-08 20:13:28 +0000437void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
438 const FunctionDecl *FD = C.getCalleeDecl(CE);
439 if (!FD)
440 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000441
Anna Zaks87cb5be2012-02-22 19:24:52 +0000442 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000443 bool ReleasedAllocatedMemory = false;
Jordan Rose5ef6e942012-07-10 23:13:01 +0000444
445 if (FD->getKind() == Decl::Function) {
446 initIdentifierInfo(C.getASTContext());
447 IdentifierInfo *FunI = FD->getIdentifier();
448
449 if (FunI == II_malloc || FunI == II_valloc) {
450 if (CE->getNumArgs() < 1)
451 return;
452 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
453 } else if (FunI == II_realloc) {
454 State = ReallocMem(C, CE, false);
455 } else if (FunI == II_reallocf) {
456 State = ReallocMem(C, CE, true);
457 } else if (FunI == II_calloc) {
458 State = CallocMem(C, CE);
459 } else if (FunI == II_free) {
Anna Zaks55dd9562012-08-24 02:28:20 +0000460 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Jordan Rose5ef6e942012-07-10 23:13:01 +0000461 } else if (FunI == II_strdup) {
462 State = MallocUpdateRefState(C, CE, State);
463 } else if (FunI == II_strndup) {
464 State = MallocUpdateRefState(C, CE, State);
465 }
466 }
467
468 if (Filter.CMallocOptimistic) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000469 // Check all the attributes, if there are any.
470 // There can be multiple of these attributes.
471 if (FD->hasAttrs())
472 for (specific_attr_iterator<OwnershipAttr>
473 i = FD->specific_attr_begin<OwnershipAttr>(),
474 e = FD->specific_attr_end<OwnershipAttr>();
475 i != e; ++i) {
476 switch ((*i)->getOwnKind()) {
477 case OwnershipAttr::Returns:
478 State = MallocMemReturnsAttr(C, CE, *i);
479 break;
480 case OwnershipAttr::Takes:
481 case OwnershipAttr::Holds:
482 State = FreeMemAttr(C, CE, *i);
483 break;
484 }
485 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000486 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000487 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000488}
489
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000490static bool isFreeWhenDoneSetToZero(const ObjCMethodCall &Call) {
491 Selector S = Call.getSelector();
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000492 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000493 if (S.getNameForSlot(i).equals("freeWhenDone"))
494 if (Call.getArgSVal(i).isConstant(0))
495 return true;
496
497 return false;
498}
499
Jordan Rosede507ea2012-07-02 19:28:04 +0000500void MallocChecker::checkPreObjCMessage(const ObjCMethodCall &Call,
Jordan Rose740d4902012-07-02 19:27:35 +0000501 CheckerContext &C) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000502 // If the first selector is dataWithBytesNoCopy, assume that the memory will
503 // be released with 'free' by the new object.
504 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
505 // Unless 'freeWhenDone' param set to 0.
506 // TODO: Check that the memory was allocated with malloc.
Anna Zaks55dd9562012-08-24 02:28:20 +0000507 bool ReleasedAllocatedMemory = false;
Jordan Rosede507ea2012-07-02 19:28:04 +0000508 Selector S = Call.getSelector();
Anna Zaks7186dc62012-06-22 22:42:30 +0000509 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
510 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
511 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000512 !isFreeWhenDoneSetToZero(Call)){
Anna Zaks5b7aa342012-06-22 02:04:31 +0000513 unsigned int argIdx = 0;
Jordan Rose740d4902012-07-02 19:27:35 +0000514 C.addTransition(FreeMemAux(C, Call.getArgExpr(argIdx),
Anna Zaks55dd9562012-08-24 02:28:20 +0000515 Call.getOriginExpr(), C.getState(), true,
516 ReleasedAllocatedMemory));
Anna Zaks5b7aa342012-06-22 02:04:31 +0000517 }
518}
519
Anna Zaks87cb5be2012-02-22 19:24:52 +0000520ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
521 const CallExpr *CE,
522 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000523 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000524 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000525
Sean Huntcf807c42010-08-18 23:23:40 +0000526 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000527 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000528 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000529 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000530 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000531}
532
Anna Zaksb319e022012-02-08 20:13:28 +0000533ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000534 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000535 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000536 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000537
538 // Bind the return value to the symbolic value from the heap region.
539 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
540 // side effects other than what we model here.
Ted Kremenek66c486f2012-08-22 06:26:15 +0000541 unsigned Count = C.blockCount();
Anna Zakse17fdb22012-06-07 03:57:32 +0000542 SValBuilder &svalBuilder = C.getSValBuilder();
543 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
544 DefinedSVal RetVal =
545 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
546 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000547
Anna Zaksb16ce452012-02-15 00:11:22 +0000548 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000549 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000550 return 0;
551
Jordy Rose32f26562010-07-04 00:00:41 +0000552 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000553 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000554
Jordy Rose32f26562010-07-04 00:00:41 +0000555 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000556 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000557 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000558 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000559 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000560 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000561 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000562 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
563 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
564 DefinedOrUnknownSVal extentMatchesSize =
565 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000566
Anna Zaks60a1fa42012-02-22 03:14:20 +0000567 state = state->assume(extentMatchesSize, true);
568 assert(state);
569 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000570
Anna Zaks87cb5be2012-02-22 19:24:52 +0000571 return MallocUpdateRefState(C, CE, state);
572}
573
574ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
575 const CallExpr *CE,
576 ProgramStateRef state) {
577 // Get the return value.
578 SVal retVal = state->getSVal(CE, C.getLocationContext());
579
580 // We expect the malloc functions to return a pointer.
581 if (!isa<Loc>(retVal))
582 return 0;
583
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000584 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000585 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000586
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000587 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000588 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000589
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000590}
591
Anna Zaks87cb5be2012-02-22 19:24:52 +0000592ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
593 const CallExpr *CE,
594 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000595 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000596 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000597
Anna Zaksb3d72752012-03-01 22:06:06 +0000598 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000599 bool ReleasedAllocated = false;
Anna Zaksb3d72752012-03-01 22:06:06 +0000600
Sean Huntcf807c42010-08-18 23:23:40 +0000601 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
602 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000603 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
Anna Zaks55dd9562012-08-24 02:28:20 +0000604 Att->getOwnKind() == OwnershipAttr::Holds,
605 ReleasedAllocated);
Anna Zaksb3d72752012-03-01 22:06:06 +0000606 if (StateI)
607 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000608 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000609 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000610}
611
Ted Kremenek8bef8232012-01-26 21:29:00 +0000612ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000613 const CallExpr *CE,
614 ProgramStateRef state,
615 unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000616 bool Hold,
617 bool &ReleasedAllocated) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000618 if (CE->getNumArgs() < (Num + 1))
619 return 0;
620
Anna Zaks55dd9562012-08-24 02:28:20 +0000621 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold, ReleasedAllocated);
Anna Zaks5b7aa342012-06-22 02:04:31 +0000622}
623
624ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
625 const Expr *ArgExpr,
626 const Expr *ParentExpr,
627 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000628 bool Hold,
629 bool &ReleasedAllocated) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000630
Ted Kremenek5eca4822012-01-06 22:09:28 +0000631 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000632 if (!isa<DefinedOrUnknownSVal>(ArgVal))
633 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000634 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
635
636 // Check for null dereferences.
637 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000638 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000639
Anna Zaksb276bd92012-02-14 00:26:13 +0000640 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000641 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000642 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000643 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000644 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000645
Jordy Rose43859f62010-06-07 19:32:37 +0000646 // Unknown values could easily be okay
647 // Undefined values are handled elsewhere
648 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000649 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000650
Jordy Rose43859f62010-06-07 19:32:37 +0000651 const MemRegion *R = ArgVal.getAsRegion();
652
653 // Nonlocs can't be freed, of course.
654 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
655 if (!R) {
656 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000657 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000658 }
659
660 R = R->StripCasts();
661
662 // Blocks might show up as heap data, but should not be free()d
663 if (isa<BlockDataRegion>(R)) {
664 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000665 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000666 }
667
668 const MemSpaceRegion *MS = R->getMemorySpace();
669
670 // Parameters, locals, statics, and globals shouldn't be freed.
671 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
672 // FIXME: at the time this code was written, malloc() regions were
673 // represented by conjured symbols, which are all in UnknownSpaceRegion.
674 // This means that there isn't actually anything from HeapSpaceRegion
675 // that should be freed, even though we allow it here.
676 // Of course, free() can work on memory allocated outside the current
677 // function, so UnknownSpaceRegion is always a possibility.
678 // False negatives are better than false positives.
679
680 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000681 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000682 }
683
684 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
685 // Various cases could lead to non-symbol values here.
686 // For now, ignore them.
687 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000688 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000689
690 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000691 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000692
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000693 // Check double free.
Anna Zaksede875b2012-08-03 18:30:18 +0000694 if (RS && (RS->isReleased() || RS->isRelinquished())) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000695 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000696 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000697 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000698 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000699 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000700 (RS->isReleased() ? "Attempt to free released memory" :
701 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000702 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000703 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000704 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000705 C.EmitReport(R);
706 }
Anna Zaksb319e022012-02-08 20:13:28 +0000707 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000708 }
709
Anna Zaks55dd9562012-08-24 02:28:20 +0000710 ReleasedAllocated = (RS != 0);
711
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000712 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000713 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000714 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
715 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000716}
717
Ted Kremenek9c378f72011-08-12 23:37:29 +0000718bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000719 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
720 os << "an integer (" << IntVal->getValue() << ")";
721 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
722 os << "a constant address (" << ConstAddr->getValue() << ")";
723 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000724 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000725 else
726 return false;
727
728 return true;
729}
730
Ted Kremenek9c378f72011-08-12 23:37:29 +0000731bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000732 const MemRegion *MR) {
733 switch (MR->getKind()) {
734 case MemRegion::FunctionTextRegionKind: {
735 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
736 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000737 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000738 else
739 os << "the address of a function";
740 return true;
741 }
742 case MemRegion::BlockTextRegionKind:
743 os << "block text";
744 return true;
745 case MemRegion::BlockDataRegionKind:
746 // FIXME: where the block came from?
747 os << "a block";
748 return true;
749 default: {
750 const MemSpaceRegion *MS = MR->getMemorySpace();
751
Anna Zakseb31a762012-01-04 23:54:01 +0000752 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000753 const VarRegion *VR = dyn_cast<VarRegion>(MR);
754 const VarDecl *VD;
755 if (VR)
756 VD = VR->getDecl();
757 else
758 VD = NULL;
759
760 if (VD)
761 os << "the address of the local variable '" << VD->getName() << "'";
762 else
763 os << "the address of a local stack variable";
764 return true;
765 }
Anna Zakseb31a762012-01-04 23:54:01 +0000766
767 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000768 const VarRegion *VR = dyn_cast<VarRegion>(MR);
769 const VarDecl *VD;
770 if (VR)
771 VD = VR->getDecl();
772 else
773 VD = NULL;
774
775 if (VD)
776 os << "the address of the parameter '" << VD->getName() << "'";
777 else
778 os << "the address of a parameter";
779 return true;
780 }
Anna Zakseb31a762012-01-04 23:54:01 +0000781
782 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000783 const VarRegion *VR = dyn_cast<VarRegion>(MR);
784 const VarDecl *VD;
785 if (VR)
786 VD = VR->getDecl();
787 else
788 VD = NULL;
789
790 if (VD) {
791 if (VD->isStaticLocal())
792 os << "the address of the static variable '" << VD->getName() << "'";
793 else
794 os << "the address of the global variable '" << VD->getName() << "'";
795 } else
796 os << "the address of a global variable";
797 return true;
798 }
Anna Zakseb31a762012-01-04 23:54:01 +0000799
800 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000801 }
802 }
803}
804
805void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000806 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000807 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000808 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000809 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000810
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000811 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000812 llvm::raw_svector_ostream os(buf);
813
814 const MemRegion *MR = ArgVal.getAsRegion();
815 if (MR) {
816 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
817 MR = ER->getSuperRegion();
818
819 // Special case for alloca()
820 if (isa<AllocaRegion>(MR))
821 os << "Argument to free() was allocated by alloca(), not malloc()";
822 else {
823 os << "Argument to free() is ";
824 if (SummarizeRegion(os, MR))
825 os << ", which is not memory allocated by malloc()";
826 else
827 os << "not memory allocated by malloc()";
828 }
829 } else {
830 os << "Argument to free() is ";
831 if (SummarizeValue(os, ArgVal))
832 os << ", which is not memory allocated by malloc()";
833 else
834 os << "not memory allocated by malloc()";
835 }
836
Anna Zakse172e8b2011-08-17 23:00:25 +0000837 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000838 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000839 R->addRange(range);
840 C.EmitReport(R);
841 }
842}
843
Anna Zaks87cb5be2012-02-22 19:24:52 +0000844ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
845 const CallExpr *CE,
846 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000847 if (CE->getNumArgs() < 2)
848 return 0;
849
Ted Kremenek8bef8232012-01-26 21:29:00 +0000850 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000851 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000852 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000853 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
854 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000855 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000856 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000857
Ted Kremenek846eabd2010-12-01 21:28:31 +0000858 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000859
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000860 DefinedOrUnknownSVal PtrEQ =
861 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000862
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000863 // Get the size argument. If there is no size arg then give up.
864 const Expr *Arg1 = CE->getArg(1);
865 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000866 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000867
868 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000869 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
870 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000871 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000872 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000873
874 // Compare the size argument to 0.
875 DefinedOrUnknownSVal SizeZero =
876 svalBuilder.evalEQ(state, Arg1Val,
877 svalBuilder.makeIntValWithPtrWidth(0, false));
878
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000879 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
880 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
881 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
882 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
883 // We only assume exceptional states if they are definitely true; if the
884 // state is under-constrained, assume regular realloc behavior.
885 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
886 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
887
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000888 // If the ptr is NULL and the size is not 0, the call is equivalent to
889 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000890 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000891 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000892 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000893 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000894 }
895
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000896 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000897 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000898
Anna Zaks30838b92012-02-13 20:57:07 +0000899 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000900 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000901 SymbolRef FromPtr = arg0Val.getAsSymbol();
902 SVal RetVal = state->getSVal(CE, LCtx);
903 SymbolRef ToPtr = RetVal.getAsSymbol();
904 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000905 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000906
Anna Zaks55dd9562012-08-24 02:28:20 +0000907 bool ReleasedAllocated = false;
908
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000909 // If the size is 0, free the memory.
910 if (SizeIsZero)
Anna Zaks55dd9562012-08-24 02:28:20 +0000911 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
912 false, ReleasedAllocated)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000913 // The semantics of the return value are:
914 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaksede875b2012-08-03 18:30:18 +0000915 // to free() is returned. We just free the input pointer and do not add
916 // any constrains on the output pointer.
Anna Zaks87cb5be2012-02-22 19:24:52 +0000917 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000918 }
919
920 // Default behavior.
Anna Zaks55dd9562012-08-24 02:28:20 +0000921 if (ProgramStateRef stateFree =
922 FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) {
923
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000924 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
925 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000926 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000927 return 0;
Anna Zaks55dd9562012-08-24 02:28:20 +0000928
929 // Record the info about the reallocated symbol so that we could properly
930 // process failed reallocation.
Anna Zaks40add292012-02-15 00:11:25 +0000931 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks55dd9562012-08-24 02:28:20 +0000932 ReallocPair(FromPtr, FreesOnFail || !ReleasedAllocated));
933 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksb276bd92012-02-14 00:26:13 +0000934 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000935 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000936 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000937 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000938}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000939
Anna Zaks87cb5be2012-02-22 19:24:52 +0000940ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000941 if (CE->getNumArgs() < 2)
942 return 0;
943
Ted Kremenek8bef8232012-01-26 21:29:00 +0000944 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000945 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000946 const LocationContext *LCtx = C.getLocationContext();
947 SVal count = state->getSVal(CE->getArg(0), LCtx);
948 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000949 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
950 svalBuilder.getContext().getSizeType());
951 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000952
Anna Zaks87cb5be2012-02-22 19:24:52 +0000953 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000954}
955
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000956LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000957MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
958 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000959 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000960 // Walk the ExplodedGraph backwards and find the first node that referred to
961 // the tracked symbol.
962 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000963 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000964
965 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000966 ProgramStateRef State = N->getState();
967 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000968 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000969
970 // Find the most recent expression bound to the symbol in the current
971 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000972 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000973 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
974 SVal Val = State->getSVal(MR);
975 if (Val.getAsLocSymbol() == Sym)
976 ReferenceRegion = MR;
977 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000978 }
979
Anna Zaks7752d292012-02-27 23:40:55 +0000980 // Allocation node, is the last node in the current context in which the
981 // symbol was tracked.
982 if (N->getLocationContext() == LeakContext)
983 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000984 N = N->pred_empty() ? NULL : *(N->pred_begin());
985 }
986
987 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000988 const Stmt *AllocationStmt = 0;
Jordan Rose852aa0d2012-07-10 22:07:52 +0000989 if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&P))
990 AllocationStmt = Exit->getCalleeContext()->getCallSite();
991 else if (StmtPoint *SP = dyn_cast<StmtPoint>(&P))
992 AllocationStmt = SP->getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000993
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000994 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000995}
996
Anna Zaksda046772012-02-11 21:02:40 +0000997void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
998 CheckerContext &C) const {
999 assert(N);
1000 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +00001001 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +00001002 // Leaks should not be reported if they are post-dominated by a sink:
1003 // (1) Sinks are higher importance bugs.
1004 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1005 // with __noreturn functions such as assert() or exit(). We choose not
1006 // to report leaks on such paths.
1007 BT_Leak->setSuppressOnSink(true);
1008 }
1009
Anna Zaksca8e36e2012-02-23 21:38:21 +00001010 // Most bug reports are cached at the location where they occurred.
1011 // With leaks, we want to unique them by the location where they were
1012 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001013 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001014 const Stmt *AllocStmt = 0;
1015 const MemRegion *Region = 0;
1016 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1017 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001018 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1019 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001020
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001021 SmallString<200> buf;
1022 llvm::raw_svector_ostream os(buf);
1023 os << "Memory is never released; potential leak";
Jordan Rose919e8a12012-08-08 18:23:36 +00001024 if (Region && Region->canPrintPretty()) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001025 os << " of memory pointed to by '";
Jordan Rose919e8a12012-08-08 18:23:36 +00001026 Region->printPretty(os);
Jordan Rose0d53ab42012-08-08 18:23:31 +00001027 os << '\'';
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001028 }
1029
1030 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001031 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001032 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +00001033 C.EmitReport(R);
1034}
1035
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001036void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1037 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001038{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001039 if (!SymReaper.hasDeadSymbols())
1040 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001041
Ted Kremenek8bef8232012-01-26 21:29:00 +00001042 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001043 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001044 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001045
Ted Kremenek217470e2011-07-28 23:07:51 +00001046 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001047 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001048 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1049 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001050 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +00001051 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001052 Errors.push_back(I->first);
1053 }
Jordy Rose90760142010-08-18 04:33:47 +00001054 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001055 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001056
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001057 }
1058 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001059
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001060 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +00001061 ReallocMap RP = state->get<ReallocPairs>();
1062 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
1063 if (SymReaper.isDead(I->first) ||
1064 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001065 state = state->remove<ReallocPairs>(I->first);
1066 }
1067 }
1068
Anna Zaksca8e36e2012-02-23 21:38:21 +00001069 // Generate leak node.
1070 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1071 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +00001072
Anna Zaksca8e36e2012-02-23 21:38:21 +00001073 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001074 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +00001075 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
1076 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001077 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001078 }
Anna Zaksca8e36e2012-02-23 21:38:21 +00001079 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001080}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001081
Anna Zaksda046772012-02-11 21:02:40 +00001082void MallocChecker::checkEndPath(CheckerContext &C) const {
1083 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001084 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001085
Anna Zaksa19581a2012-02-20 22:25:23 +00001086 // If inside inlined call, skip it.
1087 if (C.getLocationContext()->getParent() != 0)
1088 return;
1089
Jordy Rose09cef092010-08-18 04:26:59 +00001090 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001091 RefState RS = I->second;
1092 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001093 ExplodedNode *N = C.addTransition(state);
1094 if (N)
1095 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001096 }
1097 }
1098}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001099
Anna Zaks66c40402012-02-14 21:55:24 +00001100void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001101 // We will check for double free in the post visit.
1102 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001103 return;
1104
1105 // Check use after free, when a freed pointer is passed to a call.
1106 ProgramStateRef State = C.getState();
1107 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1108 E = CE->arg_end(); I != E; ++I) {
1109 const Expr *A = *I;
1110 if (A->getType().getTypePtr()->isAnyPointerType()) {
1111 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1112 if (!Sym)
1113 continue;
1114 if (checkUseAfterFree(Sym, C, A))
1115 return;
1116 }
1117 }
1118}
1119
Anna Zaks91c2a112012-02-08 23:16:56 +00001120void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1121 const Expr *E = S->getRetValue();
1122 if (!E)
1123 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001124
1125 // Check if we are returning a symbol.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001126 ProgramStateRef State = C.getState();
1127 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001128 SymbolRef Sym = RetVal.getAsSymbol();
1129 if (!Sym)
1130 // If we are returning a field of the allocated struct or an array element,
1131 // the callee could still free the memory.
1132 // TODO: This logic should be a part of generic symbol escape callback.
1133 if (const MemRegion *MR = RetVal.getAsRegion())
1134 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1135 if (const SymbolicRegion *BMR =
1136 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1137 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001138
Anna Zaks0860cd02012-02-11 21:44:39 +00001139 // Check if we are returning freed memory.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001140 if (Sym)
1141 if (checkUseAfterFree(Sym, C, E))
1142 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001143
Jordan Rose0d53ab42012-08-08 18:23:31 +00001144 // If this function body is not inlined, stop tracking any returned symbols.
1145 if (C.getLocationContext()->getParent() == 0) {
1146 State =
1147 State->scanReachableSymbols<StopTrackingCallback>(RetVal).getState();
1148 C.addTransition(State);
1149 }
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001150}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001151
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001152// TODO: Blocks should be either inlined or should call invalidate regions
1153// upon invocation. After that's in place, special casing here will not be
1154// needed.
1155void MallocChecker::checkPostStmt(const BlockExpr *BE,
1156 CheckerContext &C) const {
1157
1158 // Scan the BlockDecRefExprs for any object the retain count checker
1159 // may be tracking.
1160 if (!BE->getBlockDecl()->hasCaptures())
1161 return;
1162
1163 ProgramStateRef state = C.getState();
1164 const BlockDataRegion *R =
1165 cast<BlockDataRegion>(state->getSVal(BE,
1166 C.getLocationContext()).getAsRegion());
1167
1168 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1169 E = R->referenced_vars_end();
1170
1171 if (I == E)
1172 return;
1173
1174 SmallVector<const MemRegion*, 10> Regions;
1175 const LocationContext *LC = C.getLocationContext();
1176 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1177
1178 for ( ; I != E; ++I) {
1179 const VarRegion *VR = *I;
1180 if (VR->getSuperRegion() == R) {
1181 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1182 }
1183 Regions.push_back(VR);
1184 }
1185
1186 state =
1187 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1188 Regions.data() + Regions.size()).getState();
1189 C.addTransition(state);
1190}
1191
Anna Zaks14345182012-05-18 01:16:10 +00001192bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001193 assert(Sym);
1194 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001195 return (RS && RS->isReleased());
1196}
1197
1198bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1199 const Stmt *S) const {
1200 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001201 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001202 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001203 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001204
Anna Zaksfebdc322012-02-16 22:26:12 +00001205 BugReport *R = new BugReport(*BT_UseFree,
1206 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001207 if (S)
1208 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001209 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001210 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001211 C.EmitReport(R);
1212 return true;
1213 }
1214 }
1215 return false;
1216}
1217
Zhongxing Xuc8023782010-03-10 04:58:55 +00001218// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001219void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1220 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001221 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001222 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001223 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001224}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001225
Anna Zaks4fb54872012-02-11 21:02:35 +00001226//===----------------------------------------------------------------------===//
1227// Check various ways a symbol can be invalidated.
1228// TODO: This logic (the next 3 functions) is copied/similar to the
1229// RetainRelease checker. We might want to factor this out.
1230//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001231
Anna Zaks4fb54872012-02-11 21:02:35 +00001232// Stop tracking symbols when a value escapes as a result of checkBind.
1233// A value escapes in three possible cases:
1234// (1) we are binding to something that is not a memory region.
1235// (2) we are binding to a memregion that does not have stack storage
1236// (3) we are binding to a memregion with stack storage that the store
1237// does not understand.
1238void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1239 CheckerContext &C) const {
1240 // Are we storing to something that causes the value to "escape"?
1241 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001242 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001243
Anna Zaks4fb54872012-02-11 21:02:35 +00001244 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1245 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001246
Anna Zaks4fb54872012-02-11 21:02:35 +00001247 if (!escapes) {
1248 // To test (3), generate a new state with the binding added. If it is
1249 // the same state, then it escapes (since the store cannot represent
1250 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001251 // Do this only if we know that the store is not supposed to generate the
1252 // same state.
1253 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1254 if (StoredVal != val)
1255 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001256 }
1257 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001258
1259 // If our store can represent the binding and we aren't storing to something
1260 // that doesn't have local storage then just return and have the simulation
1261 // state continue as is.
1262 if (!escapes)
1263 return;
1264
1265 // Otherwise, find all symbols referenced by 'val' that we are tracking
1266 // and stop tracking them.
1267 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1268 C.addTransition(state);
1269}
1270
1271// If a symbolic region is assumed to NULL (or another constant), stop tracking
1272// it - assuming that allocation failed on this path.
1273ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1274 SVal Cond,
1275 bool Assumption) const {
1276 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001277 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001278 // If the symbol is assumed to be NULL, remove it from consideration.
1279 if (state->getConstraintManager().isNull(state, I.getKey()).isTrue())
Anna Zaks4fb54872012-02-11 21:02:35 +00001280 state = state->remove<RegionState>(I.getKey());
1281 }
1282
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001283 // Realloc returns 0 when reallocation fails, which means that we should
1284 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001285 ReallocMap RP = state->get<ReallocPairs>();
1286 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001287 // If the symbol is assumed to be NULL, remove it from consideration.
1288 if (state->getConstraintManager().isNull(state, I.getKey()).isTrue()) {
Anna Zaks40add292012-02-15 00:11:25 +00001289 SymbolRef ReallocSym = I.getData().ReallocatedSym;
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001290 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
Anna Zaks40add292012-02-15 00:11:25 +00001291 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1292 state = state->set<RegionState>(ReallocSym,
Anna Zaks050cdd72012-06-20 20:57:46 +00001293 RefState::getAllocated(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001294 }
1295 state = state->remove<ReallocPairs>(I.getKey());
1296 }
1297 }
1298
Anna Zaks4fb54872012-02-11 21:02:35 +00001299 return state;
1300}
1301
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001302// Check if the function is known to us. So, for example, we could
Jordan Rose740d4902012-07-02 19:27:35 +00001303// conservatively assume it can free/reallocate its pointer arguments.
Anna Zaks66c40402012-02-14 21:55:24 +00001304// (We assume that the pointers cannot escape through calls to system
1305// functions not handled by this checker.)
Jordan Rose740d4902012-07-02 19:27:35 +00001306bool MallocChecker::doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001307 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001308 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001309
1310 // For now, assume that any C++ call can free memory.
1311 // TODO: If we want to be more optimistic here, we'll need to make sure that
1312 // regions escape to C++ containers. They seem to do that even now, but for
1313 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001314 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001315 return false;
1316
Jordan Rose740d4902012-07-02 19:27:35 +00001317 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001318 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001319 // If it's not a framework call, or if it takes a callback, assume it
1320 // can free memory.
1321 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001322 return false;
1323
Jordan Rose740d4902012-07-02 19:27:35 +00001324 Selector S = Msg->getSelector();
Anna Zaks52a04812012-06-20 23:35:57 +00001325
Jordan Rose740d4902012-07-02 19:27:35 +00001326 // Whitelist the ObjC methods which do free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001327 // - Anything containing 'freeWhenDone' param set to 1.
1328 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001329 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001330 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1331 if (Call->getArgSVal(i).isConstant(1))
1332 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001333 else
1334 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001335 }
1336 }
1337
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001338 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001339 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001340 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
Jordan Rose740d4902012-07-02 19:27:35 +00001341 StringRef FirstSlot = S.getNameForSlot(0);
1342 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001343 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001344
Anna Zaks5f757682012-06-19 05:10:32 +00001345 // If the first selector starts with addPointer, insertPointer,
1346 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1347 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001348 // that the pointers get freed by following the container itself.
1349 if (FirstSlot.startswith("addPointer") ||
1350 FirstSlot.startswith("insertPointer") ||
1351 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001352 return false;
1353 }
1354
Jordan Rose740d4902012-07-02 19:27:35 +00001355 // Otherwise, assume that the method does not free memory.
1356 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001357 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001358 }
1359
Jordan Rose740d4902012-07-02 19:27:35 +00001360 // At this point the only thing left to handle is straight function calls.
1361 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1362 if (!FD)
1363 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001364
Jordan Rose740d4902012-07-02 19:27:35 +00001365 ASTContext &ASTC = State->getStateManager().getContext();
1366
1367 // If it's one of the allocation functions we can reason about, we model
1368 // its behavior explicitly.
1369 if (isMemFunction(FD, ASTC))
1370 return true;
1371
1372 // If it's not a system call, assume it frees memory.
1373 if (!Call->isInSystemHeader())
1374 return false;
1375
1376 // White list the system functions whose arguments escape.
1377 const IdentifierInfo *II = FD->getIdentifier();
1378 if (!II)
1379 return false;
1380 StringRef FName = II->getName();
1381
Jordan Rose740d4902012-07-02 19:27:35 +00001382 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001383 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001384 if (FName.endswith("NoCopy")) {
1385 // Look for the deallocator argument. We know that the memory ownership
1386 // is not transferred only if the deallocator argument is
1387 // 'kCFAllocatorNull'.
1388 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1389 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1390 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1391 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1392 if (DeallocatorName == "kCFAllocatorNull")
1393 return true;
1394 }
1395 }
1396 return false;
1397 }
1398
Jordan Rose740d4902012-07-02 19:27:35 +00001399 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001400 // 'closefn' is specified (and if that function does free memory),
1401 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001402 // Currently, we do not inspect the 'closefn' function (PR12101).
1403 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001404 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1405 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001406
1407 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1408 // these leaks might be intentional when setting the buffer for stdio.
1409 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1410 if (FName == "setbuf" || FName =="setbuffer" ||
1411 FName == "setlinebuf" || FName == "setvbuf") {
1412 if (Call->getNumArgs() >= 1) {
1413 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1414 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1415 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1416 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1417 return false;
1418 }
1419 }
1420
1421 // A bunch of other functions which either take ownership of a pointer or
1422 // wrap the result up in a struct or object, meaning it can be freed later.
1423 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1424 // but the Malloc checker cannot differentiate between them. The right way
1425 // of doing this would be to implement a pointer escapes callback.
1426 if (FName == "CGBitmapContextCreate" ||
1427 FName == "CGBitmapContextCreateWithData" ||
1428 FName == "CVPixelBufferCreateWithBytes" ||
1429 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1430 FName == "OSAtomicEnqueue") {
1431 return false;
1432 }
1433
Jordan Rose85d7e012012-07-02 19:27:51 +00001434 // Handle cases where we know a buffer's /address/ can escape.
1435 // Note that the above checks handle some special cases where we know that
1436 // even though the address escapes, it's still our responsibility to free the
1437 // buffer.
1438 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001439 return false;
1440
1441 // Otherwise, assume that the function does not free memory.
1442 // Most system calls do not free the memory.
1443 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001444}
1445
Anna Zaks4fb54872012-02-11 21:02:35 +00001446// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1447// escapes, when we are tracking p), do not track the symbol as we cannot reason
1448// about it anymore.
1449ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001450MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001451 const StoreManager::InvalidatedSymbols *invalidated,
1452 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001453 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +00001454 const CallEvent *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001455 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001456 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001457 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001458
Anna Zaks66c40402012-02-14 21:55:24 +00001459 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001460 // regions (explicit and implicit) escaped.
1461
1462 // Otherwise, whitelist explicit pointers; we still can track them.
1463 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001464 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1465 E = ExplicitRegions.end(); I != E; ++I) {
1466 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1467 WhitelistedSymbols.insert(R->getSymbol());
1468 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001469 }
1470
1471 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1472 E = invalidated->end(); I!=E; ++I) {
1473 SymbolRef sym = *I;
1474 if (WhitelistedSymbols.count(sym))
1475 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001476 // The symbol escaped. Note, we assume that if the symbol is released,
1477 // passing it out will result in a use after free. We also keep tracking
1478 // relinquished symbols.
1479 if (const RefState *RS = State->get<RegionState>(sym)) {
1480 if (RS->isAllocated())
Anna Zaks431e35c2012-08-09 00:42:24 +00001481 State = State->remove<RegionState>(sym);
Anna Zaks5b7aa342012-06-22 02:04:31 +00001482 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001483 }
Anna Zaks66c40402012-02-14 21:55:24 +00001484 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001485}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001486
Jordy Rose393f98b2012-03-18 07:43:35 +00001487static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1488 ProgramStateRef prevState) {
1489 ReallocMap currMap = currState->get<ReallocPairs>();
1490 ReallocMap prevMap = prevState->get<ReallocPairs>();
1491
1492 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1493 I != E; ++I) {
1494 SymbolRef sym = I.getKey();
1495 if (!currMap.lookup(sym))
1496 return sym;
1497 }
1498
1499 return NULL;
1500}
1501
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001502PathDiagnosticPiece *
1503MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1504 const ExplodedNode *PrevN,
1505 BugReporterContext &BRC,
1506 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001507 ProgramStateRef state = N->getState();
1508 ProgramStateRef statePrev = PrevN->getState();
1509
1510 const RefState *RS = state->get<RegionState>(Sym);
1511 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksede875b2012-08-03 18:30:18 +00001512 if (!RS)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001513 return 0;
1514
Anna Zaksfe571602012-02-16 22:26:07 +00001515 const Stmt *S = 0;
1516 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001517 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001518
1519 // Retrieve the associated statement.
1520 ProgramPoint ProgLoc = N->getLocation();
Jordan Rose852aa0d2012-07-10 22:07:52 +00001521 if (StmtPoint *SP = dyn_cast<StmtPoint>(&ProgLoc))
1522 S = SP->getStmt();
1523 else if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&ProgLoc))
1524 S = Exit->getCalleeContext()->getCallSite();
Anna Zaksfe571602012-02-16 22:26:07 +00001525 // If an assumption was made on a branch, it should be caught
1526 // here by looking at the state transition.
Jordan Rose852aa0d2012-07-10 22:07:52 +00001527 else if (BlockEdge *Edge = dyn_cast<BlockEdge>(&ProgLoc)) {
1528 const CFGBlock *srcBlk = Edge->getSrc();
Anna Zaksfe571602012-02-16 22:26:07 +00001529 S = srcBlk->getTerminator();
1530 }
1531 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001532 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001533
Jordan Rose28038f32012-07-10 22:07:42 +00001534 // FIXME: We will eventually need to handle non-statement-based events
1535 // (__attribute__((cleanup))).
1536
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001537 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001538 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001539 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001540 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001541 StackHint = new StackHintGeneratorForSymbol(Sym,
1542 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001543 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001544 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001545 StackHint = new StackHintGeneratorForSymbol(Sym,
1546 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001547 } else if (isRelinquished(RS, RSPrev, S)) {
1548 Msg = "Memory ownership is transfered";
1549 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001550 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001551 Mode = ReallocationFailed;
1552 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001553 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001554 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001555
Jordy Roseb000fb52012-03-24 03:15:09 +00001556 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1557 // Is it possible to fail two reallocs WITHOUT testing in between?
1558 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1559 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001560 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001561 FailedReallocSymbol = sym;
1562 }
Anna Zaksfe571602012-02-16 22:26:07 +00001563 }
1564
1565 // We are in a special mode if a reallocation failed later in the path.
1566 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001567 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001568
Jordy Roseb000fb52012-03-24 03:15:09 +00001569 // Is this is the first appearance of the reallocated symbol?
1570 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001571 // We're at the reallocation point.
1572 Msg = "Attempt to reallocate memory";
1573 StackHint = new StackHintGeneratorForSymbol(Sym,
1574 "Returned reallocated memory");
1575 FailedReallocSymbol = NULL;
1576 Mode = Normal;
1577 }
Anna Zaksfe571602012-02-16 22:26:07 +00001578 }
1579
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001580 if (!Msg)
1581 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001582 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001583
1584 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001585 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001586 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001587 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001588}
1589
Anna Zaks93c5a242012-05-02 00:05:20 +00001590void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1591 const char *NL, const char *Sep) const {
1592
1593 RegionStateTy RS = State->get<RegionState>();
1594
1595 if (!RS.isEmpty())
1596 Out << "Has Malloc data" << NL;
1597}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001598
Anna Zaks231361a2012-02-08 23:16:52 +00001599#define REGISTER_CHECKER(name) \
1600void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001601 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001602 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001603}
Anna Zaks231361a2012-02-08 23:16:52 +00001604
1605REGISTER_CHECKER(MallocPessimistic)
1606REGISTER_CHECKER(MallocOptimistic)