Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 1 | //=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--// |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines stack address leak checker, which checks if an invalid |
| 11 | // stack address is stored into a global or heap location. See CERT DCL30-C. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 027a6ab | 2011-02-15 07:42:33 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 695fb50 | 2011-02-17 21:39:17 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
Benjamin Kramer | 9852f58 | 2012-12-01 16:35:25 +0000 | [diff] [blame^] | 21 | #include "clang/AST/ExprCXX.h" |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 22 | #include "clang/Basic/SourceManager.h" |
| 23 | #include "llvm/ADT/SmallString.h" |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 24 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 25 | using namespace ento; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 26 | |
| 27 | namespace { |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 28 | class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 29 | check::EndPath > { |
Dylan Noblesmith | 6f42b62 | 2012-02-05 02:12:40 +0000 | [diff] [blame] | 30 | mutable OwningPtr<BuiltinBug> BT_stackleak; |
| 31 | mutable OwningPtr<BuiltinBug> BT_returnstack; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 32 | |
| 33 | public: |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 34 | void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 35 | void checkEndPath(CheckerContext &Ctx) const; |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 36 | private: |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 37 | void EmitStackError(CheckerContext &C, const MemRegion *R, |
| 38 | const Expr *RetE) const; |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 39 | static SourceRange GenName(raw_ostream &os, const MemRegion *R, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 40 | SourceManager &SM); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 41 | }; |
| 42 | } |
| 43 | |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 44 | SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os, |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 45 | const MemRegion *R, |
| 46 | SourceManager &SM) { |
| 47 | // Get the base region, stripping away fields and elements. |
| 48 | R = R->getBaseRegion(); |
| 49 | SourceRange range; |
| 50 | os << "Address of "; |
| 51 | |
| 52 | // Check if the region is a compound literal. |
| 53 | if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) { |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 54 | const CompoundLiteralExpr *CL = CR->getLiteralExpr(); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 55 | os << "stack memory associated with a compound literal " |
| 56 | "declared on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 57 | << SM.getExpansionLineNumber(CL->getLocStart()) |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 58 | << " returned to caller"; |
| 59 | range = CL->getSourceRange(); |
| 60 | } |
| 61 | else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) { |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 62 | const Expr *ARE = AR->getExpr(); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 63 | SourceLocation L = ARE->getLocStart(); |
| 64 | range = ARE->getSourceRange(); |
| 65 | os << "stack memory allocated by call to alloca() on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 66 | << SM.getExpansionLineNumber(L); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 67 | } |
| 68 | else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) { |
| 69 | const BlockDecl *BD = BR->getCodeRegion()->getDecl(); |
| 70 | SourceLocation L = BD->getLocStart(); |
| 71 | range = BD->getSourceRange(); |
| 72 | os << "stack-allocated block declared on line " |
Chandler Carruth | 6421162 | 2011-07-25 21:09:52 +0000 | [diff] [blame] | 73 | << SM.getExpansionLineNumber(L); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 74 | } |
| 75 | else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) { |
| 76 | os << "stack memory associated with local variable '" |
| 77 | << VR->getString() << '\''; |
| 78 | range = VR->getDecl()->getSourceRange(); |
| 79 | } |
Jeffrey Yasskin | 782f63e | 2011-08-26 00:41:31 +0000 | [diff] [blame] | 80 | else if (const CXXTempObjectRegion *TOR = dyn_cast<CXXTempObjectRegion>(R)) { |
| 81 | os << "stack memory associated with temporary object of type '" |
| 82 | << TOR->getValueType().getAsString() << '\''; |
| 83 | range = TOR->getExpr()->getSourceRange(); |
| 84 | } |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 85 | else { |
David Blaikie | b219cfc | 2011-09-23 05:06:16 +0000 | [diff] [blame] | 86 | llvm_unreachable("Invalid region in ReturnStackAddressChecker."); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 87 | } |
| 88 | |
| 89 | return range; |
| 90 | } |
| 91 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 92 | void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R, |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 93 | const Expr *RetE) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 94 | ExplodedNode *N = C.generateSink(); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 95 | |
| 96 | if (!N) |
| 97 | return; |
| 98 | |
| 99 | if (!BT_returnstack) |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 100 | BT_returnstack.reset( |
| 101 | new BuiltinBug("Return of address to stack-allocated memory")); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 102 | |
| 103 | // Generate a report for this bug. |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 104 | SmallString<512> buf; |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 105 | llvm::raw_svector_ostream os(buf); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 106 | SourceRange range = GenName(os, R, C.getSourceManager()); |
| 107 | os << " returned to caller"; |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 108 | BugReport *report = new BugReport(*BT_returnstack, os.str(), N); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 109 | report->addRange(RetE->getSourceRange()); |
| 110 | if (range.isValid()) |
| 111 | report->addRange(range); |
| 112 | |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 113 | C.emitReport(report); |
Eli Friedman | a7e6845 | 2010-08-22 01:00:03 +0000 | [diff] [blame] | 114 | } |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 115 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 116 | void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS, |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 117 | CheckerContext &C) const { |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 118 | |
| 119 | const Expr *RetE = RS->getRetValue(); |
| 120 | if (!RetE) |
| 121 | return; |
Jordan Rose | 73212df | 2012-08-29 01:11:59 +0000 | [diff] [blame] | 122 | RetE = RetE->IgnoreParens(); |
Jordan Rose | c210cb7 | 2012-08-27 17:50:07 +0000 | [diff] [blame] | 123 | |
| 124 | const LocationContext *LCtx = C.getLocationContext(); |
| 125 | SVal V = C.getState()->getSVal(RetE, LCtx); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 126 | const MemRegion *R = V.getAsRegion(); |
| 127 | |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 128 | if (!R) |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 129 | return; |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 130 | |
| 131 | const StackSpaceRegion *SS = |
| 132 | dyn_cast_or_null<StackSpaceRegion>(R->getMemorySpace()); |
| 133 | |
| 134 | if (!SS) |
| 135 | return; |
| 136 | |
| 137 | // Return stack memory in an ancestor stack frame is fine. |
Jordan Rose | c210cb7 | 2012-08-27 17:50:07 +0000 | [diff] [blame] | 138 | const StackFrameContext *CurFrame = LCtx->getCurrentStackFrame(); |
| 139 | const StackFrameContext *MemFrame = SS->getStackFrame(); |
| 140 | if (MemFrame != CurFrame) |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 141 | return; |
| 142 | |
| 143 | // Automatic reference counting automatically copies blocks. |
David Blaikie | 4e4d084 | 2012-03-11 07:00:24 +0000 | [diff] [blame] | 144 | if (C.getASTContext().getLangOpts().ObjCAutoRefCount && |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 145 | isa<BlockDataRegion>(R)) |
| 146 | return; |
| 147 | |
Jordan Rose | c210cb7 | 2012-08-27 17:50:07 +0000 | [diff] [blame] | 148 | // Returning a record by value is fine. (In this case, the returned |
Jordan Rose | 73212df | 2012-08-29 01:11:59 +0000 | [diff] [blame] | 149 | // expression will be a copy-constructor, possibly wrapped in an |
| 150 | // ExprWithCleanups node.) |
| 151 | if (const ExprWithCleanups *Cleanup = dyn_cast<ExprWithCleanups>(RetE)) |
| 152 | RetE = Cleanup->getSubExpr(); |
Jordan Rose | c210cb7 | 2012-08-27 17:50:07 +0000 | [diff] [blame] | 153 | if (isa<CXXConstructExpr>(RetE) && RetE->getType()->isRecordType()) |
| 154 | return; |
| 155 | |
Ted Kremenek | 7e86783 | 2012-03-03 01:22:03 +0000 | [diff] [blame] | 156 | EmitStackError(C, R, RetE); |
Zhongxing Xu | 9b14683 | 2010-06-09 06:08:24 +0000 | [diff] [blame] | 157 | } |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 158 | |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 159 | void StackAddrEscapeChecker::checkEndPath(CheckerContext &Ctx) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 160 | ProgramStateRef state = Ctx.getState(); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 161 | |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 162 | // Iterate over all bindings to global variables and see if it contains |
| 163 | // a memory region in the stack space. |
| 164 | class CallBack : public StoreManager::BindingsHandler { |
| 165 | private: |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 166 | CheckerContext &Ctx; |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 167 | const StackFrameContext *CurSFC; |
| 168 | public: |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 169 | SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 170 | |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 171 | CallBack(CheckerContext &CC) : |
| 172 | Ctx(CC), |
Anna Zaks | 39ac187 | 2011-10-26 21:06:44 +0000 | [diff] [blame] | 173 | CurSFC(CC.getLocationContext()->getCurrentStackFrame()) |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 174 | {} |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 175 | |
| 176 | bool HandleBinding(StoreManager &SMgr, Store store, |
| 177 | const MemRegion *region, SVal val) { |
| 178 | |
| 179 | if (!isa<GlobalsSpaceRegion>(region->getMemorySpace())) |
| 180 | return true; |
| 181 | |
| 182 | const MemRegion *vR = val.getAsRegion(); |
| 183 | if (!vR) |
| 184 | return true; |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 185 | |
| 186 | // Under automated retain release, it is okay to assign a block |
| 187 | // directly to a global variable. |
David Blaikie | 4e4d084 | 2012-03-11 07:00:24 +0000 | [diff] [blame] | 188 | if (Ctx.getASTContext().getLangOpts().ObjCAutoRefCount && |
John McCall | f85e193 | 2011-06-15 23:02:42 +0000 | [diff] [blame] | 189 | isa<BlockDataRegion>(vR)) |
| 190 | return true; |
| 191 | |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 192 | if (const StackSpaceRegion *SSR = |
| 193 | dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) { |
| 194 | // If the global variable holds a location in the current stack frame, |
| 195 | // record the binding to emit a warning. |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 196 | if (SSR->getStackFrame() == CurSFC) |
| 197 | V.push_back(std::make_pair(region, vR)); |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 198 | } |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 199 | |
| 200 | return true; |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 201 | } |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 202 | }; |
| 203 | |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 204 | CallBack cb(Ctx); |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 205 | state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 206 | |
| 207 | if (cb.V.empty()) |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 208 | return; |
| 209 | |
| 210 | // Generate an error node. |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 211 | ExplodedNode *N = Ctx.addTransition(state); |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 212 | if (!N) |
| 213 | return; |
Ted Kremenek | 551bd1f | 2010-06-17 00:24:44 +0000 | [diff] [blame] | 214 | |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 215 | if (!BT_stackleak) |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 216 | BT_stackleak.reset( |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 217 | new BuiltinBug("Stack address stored into global variable", |
| 218 | "Stack address was saved into a global variable. " |
| 219 | "This is dangerous because the address will become " |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 220 | "invalid after returning from the function")); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 221 | |
| 222 | for (unsigned i = 0, e = cb.V.size(); i != e; ++i) { |
| 223 | // Generate a report for this bug. |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 224 | SmallString<512> buf; |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 225 | llvm::raw_svector_ostream os(buf); |
| 226 | SourceRange range = GenName(os, cb.V[i].second, |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 227 | Ctx.getSourceManager()); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 228 | os << " is still referred to by the global variable '"; |
| 229 | const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion()); |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 230 | os << *VR->getDecl() |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 231 | << "' upon returning to the caller. This will be a dangling reference"; |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 232 | BugReport *report = new BugReport(*BT_stackleak, os.str(), N); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 233 | if (range.isValid()) |
| 234 | report->addRange(range); |
| 235 | |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 236 | Ctx.emitReport(report); |
Ted Kremenek | a816615 | 2010-06-17 04:21:37 +0000 | [diff] [blame] | 237 | } |
Zhongxing Xu | 1622a54 | 2010-06-08 10:00:00 +0000 | [diff] [blame] | 238 | } |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 239 | |
Ted Kremenek | f5d2ef4 | 2011-02-25 22:00:43 +0000 | [diff] [blame] | 240 | void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) { |
| 241 | mgr.registerChecker<StackAddrEscapeChecker>(); |
Argyrios Kyrtzidis | af5800a | 2011-02-23 21:04:54 +0000 | [diff] [blame] | 242 | } |