blob: f353c9a382082178f017708367c2db408f6bd824 [file] [log] [blame]
Ted Kremenekf5d2ef42011-02-25 22:00:43 +00001//=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--//
Zhongxing Xu1622a542010-06-08 10:00:00 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines stack address leak checker, which checks if an invalid
11// stack address is stored into a global or heap location. See CERT DCL30-C.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis027a6ab2011-02-15 07:42:33 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000018#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
Benjamin Kramer9852f582012-12-01 16:35:25 +000021#include "clang/AST/ExprCXX.h"
Zhongxing Xu9b146832010-06-09 06:08:24 +000022#include "clang/Basic/SourceManager.h"
23#include "llvm/ADT/SmallString.h"
Zhongxing Xu1622a542010-06-08 10:00:00 +000024using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000025using namespace ento;
Zhongxing Xu1622a542010-06-08 10:00:00 +000026
27namespace {
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000028class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000029 check::EndPath > {
Dylan Noblesmith6f42b622012-02-05 02:12:40 +000030 mutable OwningPtr<BuiltinBug> BT_stackleak;
31 mutable OwningPtr<BuiltinBug> BT_returnstack;
Zhongxing Xu1622a542010-06-08 10:00:00 +000032
33public:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000034 void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +000035 void checkEndPath(CheckerContext &Ctx) const;
Zhongxing Xu9b146832010-06-09 06:08:24 +000036private:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000037 void EmitStackError(CheckerContext &C, const MemRegion *R,
38 const Expr *RetE) const;
Chris Lattner5f9e2722011-07-23 10:55:15 +000039 static SourceRange GenName(raw_ostream &os, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000040 SourceManager &SM);
Zhongxing Xu1622a542010-06-08 10:00:00 +000041};
42}
43
Chris Lattner5f9e2722011-07-23 10:55:15 +000044SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os,
Ted Kremeneka8166152010-06-17 04:21:37 +000045 const MemRegion *R,
46 SourceManager &SM) {
47 // Get the base region, stripping away fields and elements.
48 R = R->getBaseRegion();
49 SourceRange range;
50 os << "Address of ";
51
52 // Check if the region is a compound literal.
53 if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000054 const CompoundLiteralExpr *CL = CR->getLiteralExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000055 os << "stack memory associated with a compound literal "
56 "declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000057 << SM.getExpansionLineNumber(CL->getLocStart())
Ted Kremeneka8166152010-06-17 04:21:37 +000058 << " returned to caller";
59 range = CL->getSourceRange();
60 }
61 else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000062 const Expr *ARE = AR->getExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000063 SourceLocation L = ARE->getLocStart();
64 range = ARE->getSourceRange();
65 os << "stack memory allocated by call to alloca() on line "
Chandler Carruth64211622011-07-25 21:09:52 +000066 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000067 }
68 else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) {
69 const BlockDecl *BD = BR->getCodeRegion()->getDecl();
70 SourceLocation L = BD->getLocStart();
71 range = BD->getSourceRange();
72 os << "stack-allocated block declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000073 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000074 }
75 else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
76 os << "stack memory associated with local variable '"
77 << VR->getString() << '\'';
78 range = VR->getDecl()->getSourceRange();
79 }
Jeffrey Yasskin782f63e2011-08-26 00:41:31 +000080 else if (const CXXTempObjectRegion *TOR = dyn_cast<CXXTempObjectRegion>(R)) {
81 os << "stack memory associated with temporary object of type '"
82 << TOR->getValueType().getAsString() << '\'';
83 range = TOR->getExpr()->getSourceRange();
84 }
Ted Kremeneka8166152010-06-17 04:21:37 +000085 else {
David Blaikieb219cfc2011-09-23 05:06:16 +000086 llvm_unreachable("Invalid region in ReturnStackAddressChecker.");
Ted Kremeneka8166152010-06-17 04:21:37 +000087 }
88
89 return range;
90}
91
Ted Kremenekf5d2ef42011-02-25 22:00:43 +000092void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000093 const Expr *RetE) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +000094 ExplodedNode *N = C.generateSink();
Zhongxing Xu9b146832010-06-09 06:08:24 +000095
96 if (!N)
97 return;
98
99 if (!BT_returnstack)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000100 BT_returnstack.reset(
101 new BuiltinBug("Return of address to stack-allocated memory"));
Zhongxing Xu9b146832010-06-09 06:08:24 +0000102
103 // Generate a report for this bug.
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000104 SmallString<512> buf;
Zhongxing Xu9b146832010-06-09 06:08:24 +0000105 llvm::raw_svector_ostream os(buf);
Ted Kremeneka8166152010-06-17 04:21:37 +0000106 SourceRange range = GenName(os, R, C.getSourceManager());
107 os << " returned to caller";
Anna Zakse172e8b2011-08-17 23:00:25 +0000108 BugReport *report = new BugReport(*BT_returnstack, os.str(), N);
Zhongxing Xu9b146832010-06-09 06:08:24 +0000109 report->addRange(RetE->getSourceRange());
110 if (range.isValid())
111 report->addRange(range);
112
Jordan Rose785950e2012-11-02 01:53:40 +0000113 C.emitReport(report);
Eli Friedmana7e68452010-08-22 01:00:03 +0000114}
Zhongxing Xu9b146832010-06-09 06:08:24 +0000115
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000116void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS,
Ted Kremenek7e867832012-03-03 01:22:03 +0000117 CheckerContext &C) const {
Zhongxing Xu9b146832010-06-09 06:08:24 +0000118
119 const Expr *RetE = RS->getRetValue();
120 if (!RetE)
121 return;
Jordan Rose73212df2012-08-29 01:11:59 +0000122 RetE = RetE->IgnoreParens();
Jordan Rosec210cb72012-08-27 17:50:07 +0000123
124 const LocationContext *LCtx = C.getLocationContext();
125 SVal V = C.getState()->getSVal(RetE, LCtx);
Zhongxing Xu9b146832010-06-09 06:08:24 +0000126 const MemRegion *R = V.getAsRegion();
127
Ted Kremenek7e867832012-03-03 01:22:03 +0000128 if (!R)
Zhongxing Xu9b146832010-06-09 06:08:24 +0000129 return;
Ted Kremenek7e867832012-03-03 01:22:03 +0000130
131 const StackSpaceRegion *SS =
132 dyn_cast_or_null<StackSpaceRegion>(R->getMemorySpace());
133
134 if (!SS)
135 return;
136
137 // Return stack memory in an ancestor stack frame is fine.
Jordan Rosec210cb72012-08-27 17:50:07 +0000138 const StackFrameContext *CurFrame = LCtx->getCurrentStackFrame();
139 const StackFrameContext *MemFrame = SS->getStackFrame();
140 if (MemFrame != CurFrame)
Ted Kremenek7e867832012-03-03 01:22:03 +0000141 return;
142
143 // Automatic reference counting automatically copies blocks.
David Blaikie4e4d0842012-03-11 07:00:24 +0000144 if (C.getASTContext().getLangOpts().ObjCAutoRefCount &&
Ted Kremenek7e867832012-03-03 01:22:03 +0000145 isa<BlockDataRegion>(R))
146 return;
147
Jordan Rosec210cb72012-08-27 17:50:07 +0000148 // Returning a record by value is fine. (In this case, the returned
Jordan Rose73212df2012-08-29 01:11:59 +0000149 // expression will be a copy-constructor, possibly wrapped in an
150 // ExprWithCleanups node.)
151 if (const ExprWithCleanups *Cleanup = dyn_cast<ExprWithCleanups>(RetE))
152 RetE = Cleanup->getSubExpr();
Jordan Rosec210cb72012-08-27 17:50:07 +0000153 if (isa<CXXConstructExpr>(RetE) && RetE->getType()->isRecordType())
154 return;
155
Ted Kremenek7e867832012-03-03 01:22:03 +0000156 EmitStackError(C, R, RetE);
Zhongxing Xu9b146832010-06-09 06:08:24 +0000157}
Zhongxing Xu1622a542010-06-08 10:00:00 +0000158
Anna Zaksaf498a22011-10-25 19:56:48 +0000159void StackAddrEscapeChecker::checkEndPath(CheckerContext &Ctx) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +0000160 ProgramStateRef state = Ctx.getState();
Zhongxing Xu1622a542010-06-08 10:00:00 +0000161
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000162 // Iterate over all bindings to global variables and see if it contains
163 // a memory region in the stack space.
164 class CallBack : public StoreManager::BindingsHandler {
165 private:
Anna Zaksaf498a22011-10-25 19:56:48 +0000166 CheckerContext &Ctx;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000167 const StackFrameContext *CurSFC;
168 public:
Chris Lattner5f9e2722011-07-23 10:55:15 +0000169 SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000170
Anna Zaksaf498a22011-10-25 19:56:48 +0000171 CallBack(CheckerContext &CC) :
172 Ctx(CC),
Anna Zaks39ac1872011-10-26 21:06:44 +0000173 CurSFC(CC.getLocationContext()->getCurrentStackFrame())
Anna Zaksaf498a22011-10-25 19:56:48 +0000174 {}
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000175
176 bool HandleBinding(StoreManager &SMgr, Store store,
177 const MemRegion *region, SVal val) {
178
179 if (!isa<GlobalsSpaceRegion>(region->getMemorySpace()))
180 return true;
181
182 const MemRegion *vR = val.getAsRegion();
183 if (!vR)
184 return true;
John McCallf85e1932011-06-15 23:02:42 +0000185
186 // Under automated retain release, it is okay to assign a block
187 // directly to a global variable.
David Blaikie4e4d0842012-03-11 07:00:24 +0000188 if (Ctx.getASTContext().getLangOpts().ObjCAutoRefCount &&
John McCallf85e1932011-06-15 23:02:42 +0000189 isa<BlockDataRegion>(vR))
190 return true;
191
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000192 if (const StackSpaceRegion *SSR =
193 dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) {
194 // If the global variable holds a location in the current stack frame,
195 // record the binding to emit a warning.
Ted Kremeneka8166152010-06-17 04:21:37 +0000196 if (SSR->getStackFrame() == CurSFC)
197 V.push_back(std::make_pair(region, vR));
Zhongxing Xu1622a542010-06-08 10:00:00 +0000198 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000199
200 return true;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000201 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000202 };
203
Anna Zaksaf498a22011-10-25 19:56:48 +0000204 CallBack cb(Ctx);
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000205 state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb);
Ted Kremeneka8166152010-06-17 04:21:37 +0000206
207 if (cb.V.empty())
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000208 return;
209
210 // Generate an error node.
Anna Zaks0bd6b112011-10-26 21:06:34 +0000211 ExplodedNode *N = Ctx.addTransition(state);
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000212 if (!N)
213 return;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000214
Ted Kremeneka8166152010-06-17 04:21:37 +0000215 if (!BT_stackleak)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000216 BT_stackleak.reset(
Ted Kremeneka8166152010-06-17 04:21:37 +0000217 new BuiltinBug("Stack address stored into global variable",
218 "Stack address was saved into a global variable. "
219 "This is dangerous because the address will become "
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000220 "invalid after returning from the function"));
Ted Kremeneka8166152010-06-17 04:21:37 +0000221
222 for (unsigned i = 0, e = cb.V.size(); i != e; ++i) {
223 // Generate a report for this bug.
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000224 SmallString<512> buf;
Ted Kremeneka8166152010-06-17 04:21:37 +0000225 llvm::raw_svector_ostream os(buf);
226 SourceRange range = GenName(os, cb.V[i].second,
Anna Zaksaf498a22011-10-25 19:56:48 +0000227 Ctx.getSourceManager());
Ted Kremeneka8166152010-06-17 04:21:37 +0000228 os << " is still referred to by the global variable '";
229 const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion());
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000230 os << *VR->getDecl()
Ted Kremeneka8166152010-06-17 04:21:37 +0000231 << "' upon returning to the caller. This will be a dangling reference";
Anna Zakse172e8b2011-08-17 23:00:25 +0000232 BugReport *report = new BugReport(*BT_stackleak, os.str(), N);
Ted Kremeneka8166152010-06-17 04:21:37 +0000233 if (range.isValid())
234 report->addRange(range);
235
Jordan Rose785950e2012-11-02 01:53:40 +0000236 Ctx.emitReport(report);
Ted Kremeneka8166152010-06-17 04:21:37 +0000237 }
Zhongxing Xu1622a542010-06-08 10:00:00 +0000238}
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000239
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000240void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) {
241 mgr.registerChecker<StackAddrEscapeChecker>();
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000242}