Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 16 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 18 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 24 | #include "clang/Basic/SourceManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 25 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/STLExtras.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 28 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 29 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 30 | |
| 31 | namespace { |
| 32 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 33 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 34 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 35 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 36 | const Stmt *S; |
| 37 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 38 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 40 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 41 | bool isAllocated() const { return K == AllocateUnchecked; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 42 | //bool isFailed() const { return K == AllocateFailed; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 43 | bool isReleased() const { return K == Released; } |
Chris Lattner | fae9622 | 2010-09-03 04:34:38 +0000 | [diff] [blame] | 44 | //bool isEscaped() const { return K == Escaped; } |
| 45 | //bool isRelinquished() const { return K == Relinquished; } |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 46 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 47 | |
| 48 | bool operator==(const RefState &X) const { |
| 49 | return K == X.K && S == X.S; |
| 50 | } |
| 51 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 52 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 53 | return RefState(AllocateUnchecked, s); |
| 54 | } |
| 55 | static RefState getAllocateFailed() { |
| 56 | return RefState(AllocateFailed, 0); |
| 57 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 58 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 59 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 60 | static RefState getRelinquished(const Stmt *s) { |
| 61 | return RefState(Relinquished, s); |
| 62 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 63 | |
| 64 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 65 | ID.AddInteger(K); |
| 66 | ID.AddPointer(S); |
| 67 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 68 | }; |
| 69 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 70 | class MallocChecker : public Checker<check::DeadSymbols, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 71 | check::EndPath, |
| 72 | check::PreStmt<ReturnStmt>, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 73 | check::PreStmt<CallExpr>, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 74 | check::PostStmt<CallExpr>, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 75 | check::Location, |
| 76 | check::Bind, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 77 | eval::Assume, |
| 78 | check::RegionChanges> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 79 | { |
Dylan Noblesmith | 6f42b62 | 2012-02-05 02:12:40 +0000 | [diff] [blame] | 80 | mutable OwningPtr<BuiltinBug> BT_DoubleFree; |
| 81 | mutable OwningPtr<BuiltinBug> BT_Leak; |
| 82 | mutable OwningPtr<BuiltinBug> BT_UseFree; |
| 83 | mutable OwningPtr<BuiltinBug> BT_UseRelinquished; |
| 84 | mutable OwningPtr<BuiltinBug> BT_BadFree; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 85 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
| 86 | *II_valloc; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 87 | |
| 88 | public: |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 89 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
| 90 | II_valloc(0) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 91 | |
| 92 | /// In pessimistic mode, the checker assumes that it does not know which |
| 93 | /// functions might free the memory. |
| 94 | struct ChecksFilter { |
| 95 | DefaultBool CMallocPessimistic; |
| 96 | DefaultBool CMallocOptimistic; |
| 97 | }; |
| 98 | |
| 99 | ChecksFilter Filter; |
| 100 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 101 | void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 102 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 103 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 104 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 105 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 106 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 107 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 108 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 109 | CheckerContext &C) const; |
| 110 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 111 | CheckerContext &C) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 112 | ProgramStateRef |
| 113 | checkRegionChanges(ProgramStateRef state, |
| 114 | const StoreManager::InvalidatedSymbols *invalidated, |
| 115 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 116 | ArrayRef<const MemRegion *> Regions, |
| 117 | const CallOrObjCMessage *Call) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 118 | bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| 119 | return true; |
| 120 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 121 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 122 | private: |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 123 | void initIdentifierInfo(ASTContext &C) const; |
| 124 | |
| 125 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 126 | /// pointed to by one of its arguments. |
| 127 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| 128 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 129 | static void MallocMem(CheckerContext &C, const CallExpr *CE); |
| 130 | static void MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 131 | const OwnershipAttr* Att); |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 132 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 133 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 134 | ProgramStateRef state) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 135 | return MallocMemAux(C, CE, |
| 136 | state->getSVal(SizeEx, C.getLocationContext()), |
| 137 | Init, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 138 | } |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 139 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 140 | SVal SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 141 | ProgramStateRef state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 142 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 143 | void FreeMem(CheckerContext &C, const CallExpr *CE) const; |
Jordy Rose | 2a47992 | 2010-08-12 08:54:03 +0000 | [diff] [blame] | 144 | void FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 145 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 146 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 147 | ProgramStateRef state, unsigned Num, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 148 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 149 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 150 | void ReallocMem(CheckerContext &C, const CallExpr *CE) const; |
| 151 | static void CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 152 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 153 | bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| 154 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 155 | const Stmt *S = 0) const; |
| 156 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 157 | /// Check if the function is not known to us. So, for example, we could |
| 158 | /// conservatively assume it can free/reallocate it's pointer arguments. |
| 159 | bool hasUnknownBehavior(const FunctionDecl *FD, ProgramStateRef State) const; |
| 160 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 161 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 162 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 163 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 164 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 165 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 166 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 167 | /// The bug visitor which allows us to print extra diagnostics along the |
| 168 | /// BugReport path. For example, showing the allocation site of the leaked |
| 169 | /// region. |
| 170 | class MallocBugVisitor : public BugReporterVisitor { |
| 171 | protected: |
| 172 | // The allocated region symbol tracked by the main analysis. |
| 173 | SymbolRef Sym; |
| 174 | |
| 175 | public: |
| 176 | MallocBugVisitor(SymbolRef S) : Sym(S) {} |
| 177 | virtual ~MallocBugVisitor() {} |
| 178 | |
| 179 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 180 | static int X = 0; |
| 181 | ID.AddPointer(&X); |
| 182 | ID.AddPointer(Sym); |
| 183 | } |
| 184 | |
| 185 | inline bool isAllocated(const RefState *S, const RefState *SPrev) { |
| 186 | // Did not track -> allocated. Other state (released) -> allocated. |
| 187 | return ((S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
| 188 | } |
| 189 | |
| 190 | inline bool isReleased(const RefState *S, const RefState *SPrev) { |
| 191 | // Did not track -> released. Other state (allocated) -> released. |
| 192 | return ((S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 193 | } |
| 194 | |
| 195 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 196 | const ExplodedNode *PrevN, |
| 197 | BugReporterContext &BRC, |
| 198 | BugReport &BR); |
| 199 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 200 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 201 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 202 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 203 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 204 | typedef llvm::ImmutableMap<SymbolRef, SymbolRef> SymRefToSymRefTy; |
| 205 | class RegionState {}; |
| 206 | class ReallocPairs {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 207 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 208 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 209 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 210 | struct ProgramStateTrait<RegionState> |
| 211 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 212 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 213 | }; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 214 | |
| 215 | template <> |
| 216 | struct ProgramStateTrait<ReallocPairs> |
| 217 | : public ProgramStatePartialTrait<SymRefToSymRefTy> { |
| 218 | static void *GDMIndex() { static int x; return &x; } |
| 219 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 220 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 221 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 222 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 223 | namespace { |
| 224 | class StopTrackingCallback : public SymbolVisitor { |
| 225 | ProgramStateRef state; |
| 226 | public: |
| 227 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 228 | ProgramStateRef getState() const { return state; } |
| 229 | |
| 230 | bool VisitSymbol(SymbolRef sym) { |
| 231 | state = state->remove<RegionState>(sym); |
| 232 | return true; |
| 233 | } |
| 234 | }; |
| 235 | } // end anonymous namespace |
| 236 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 237 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 238 | if (!II_malloc) |
| 239 | II_malloc = &Ctx.Idents.get("malloc"); |
| 240 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 241 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 242 | if (!II_realloc) |
| 243 | II_realloc = &Ctx.Idents.get("realloc"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 244 | if (!II_calloc) |
| 245 | II_calloc = &Ctx.Idents.get("calloc"); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 246 | if (!II_valloc) |
| 247 | II_valloc = &Ctx.Idents.get("valloc"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 248 | } |
| 249 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 250 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
| 251 | initIdentifierInfo(C); |
| 252 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 253 | if (!FunI) |
| 254 | return false; |
| 255 | |
| 256 | // TODO: Add more here : ex: reallocf! |
| 257 | if (FunI == II_malloc || FunI == II_free || |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 258 | FunI == II_realloc || FunI == II_calloc || FunI == II_valloc) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 259 | return true; |
| 260 | |
| 261 | if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| 262 | FD->specific_attr_begin<OwnershipAttr>() != |
| 263 | FD->specific_attr_end<OwnershipAttr>()) |
| 264 | return true; |
| 265 | |
| 266 | |
| 267 | return false; |
| 268 | } |
| 269 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 270 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| 271 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 272 | if (!FD) |
| 273 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 274 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 275 | initIdentifierInfo(C.getASTContext()); |
| 276 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 277 | if (!FunI) |
| 278 | return; |
| 279 | |
| 280 | if (FunI == II_malloc || FunI == II_valloc) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 281 | MallocMem(C, CE); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 282 | return; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 283 | } else if (FunI == II_realloc) { |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 284 | ReallocMem(C, CE); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 285 | return; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 286 | } else if (FunI == II_calloc) { |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 287 | CallocMem(C, CE); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 288 | return; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 289 | }else if (FunI == II_free) { |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 290 | FreeMem(C, CE); |
| 291 | return; |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 292 | } |
| 293 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 294 | if (Filter.CMallocOptimistic) |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 295 | // Check all the attributes, if there are any. |
| 296 | // There can be multiple of these attributes. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 297 | if (FD->hasAttrs()) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 298 | for (specific_attr_iterator<OwnershipAttr> |
| 299 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 300 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 301 | i != e; ++i) { |
| 302 | switch ((*i)->getOwnKind()) { |
| 303 | case OwnershipAttr::Returns: { |
| 304 | MallocMemReturnsAttr(C, CE, *i); |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 305 | return; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 306 | } |
| 307 | case OwnershipAttr::Takes: |
| 308 | case OwnershipAttr::Holds: { |
| 309 | FreeMemAttr(C, CE, *i); |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 310 | return; |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 311 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 312 | } |
| 313 | } |
| 314 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 315 | } |
| 316 | |
| 317 | void MallocChecker::MallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 318 | ProgramStateRef state = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 319 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 320 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 321 | } |
| 322 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 323 | void MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 324 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 325 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 326 | return; |
| 327 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 328 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 329 | if (I != E) { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 330 | ProgramStateRef state = |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 331 | MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 332 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 333 | return; |
| 334 | } |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 335 | ProgramStateRef state = MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 336 | C.getState()); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 337 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 338 | } |
| 339 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 340 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 341 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 342 | SVal Size, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 343 | ProgramStateRef state) { |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 344 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 345 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 346 | // Get the return value. |
| 347 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 348 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame^] | 349 | // We expect the malloc functions to return a pointer. |
| 350 | if (!isa<Loc>(retVal)) |
| 351 | return 0; |
| 352 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 353 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 354 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 355 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 356 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 357 | const SymbolicRegion *R = |
| 358 | dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
| 359 | if (!R || !isa<DefinedOrUnknownSVal>(Size)) |
| 360 | return 0; |
| 361 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 362 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 363 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 364 | DefinedOrUnknownSVal extentMatchesSize = |
Ted Kremenek | 9c14953 | 2010-12-01 21:57:22 +0000 | [diff] [blame] | 365 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 366 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 367 | state = state->assume(extentMatchesSize, true); |
| 368 | assert(state); |
| 369 | |
| 370 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 371 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 372 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 373 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 374 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 375 | } |
| 376 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 377 | void MallocChecker::FreeMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 378 | ProgramStateRef state = FreeMemAux(C, CE, C.getState(), 0, false); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 379 | |
| 380 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 381 | C.addTransition(state); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 382 | } |
| 383 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 384 | void MallocChecker::FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 385 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 386 | if (Att->getModule() != "malloc") |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 387 | return; |
| 388 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 389 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 390 | I != E; ++I) { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 391 | ProgramStateRef state = |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 392 | FreeMemAux(C, CE, C.getState(), *I, |
| 393 | Att->getOwnKind() == OwnershipAttr::Holds); |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 394 | if (state) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 395 | C.addTransition(state); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 396 | } |
| 397 | } |
| 398 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 399 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 400 | const CallExpr *CE, |
| 401 | ProgramStateRef state, |
| 402 | unsigned Num, |
| 403 | bool Hold) const { |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 404 | const Expr *ArgExpr = CE->getArg(Num); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 405 | SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 406 | if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| 407 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 408 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 409 | |
| 410 | // Check for null dereferences. |
| 411 | if (!isa<Loc>(location)) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 412 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 413 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 414 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 415 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 416 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 417 | if (nullState && !notNullState) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 418 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 419 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 420 | // Unknown values could easily be okay |
| 421 | // Undefined values are handled elsewhere |
| 422 | if (ArgVal.isUnknownOrUndef()) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 423 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 424 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 425 | const MemRegion *R = ArgVal.getAsRegion(); |
| 426 | |
| 427 | // Nonlocs can't be freed, of course. |
| 428 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 429 | if (!R) { |
| 430 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 431 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 432 | } |
| 433 | |
| 434 | R = R->StripCasts(); |
| 435 | |
| 436 | // Blocks might show up as heap data, but should not be free()d |
| 437 | if (isa<BlockDataRegion>(R)) { |
| 438 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 439 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 440 | } |
| 441 | |
| 442 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 443 | |
| 444 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 445 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 446 | // FIXME: at the time this code was written, malloc() regions were |
| 447 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 448 | // This means that there isn't actually anything from HeapSpaceRegion |
| 449 | // that should be freed, even though we allow it here. |
| 450 | // Of course, free() can work on memory allocated outside the current |
| 451 | // function, so UnknownSpaceRegion is always a possibility. |
| 452 | // False negatives are better than false positives. |
| 453 | |
| 454 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 455 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 456 | } |
| 457 | |
| 458 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 459 | // Various cases could lead to non-symbol values here. |
| 460 | // For now, ignore them. |
| 461 | if (!SR) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 462 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 463 | |
| 464 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 465 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 466 | |
| 467 | // If the symbol has not been tracked, return. This is possible when free() is |
| 468 | // called on a pointer that does not get its pointee directly from malloc(). |
| 469 | // Full support of this requires inter-procedural analysis. |
| 470 | if (!RS) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 471 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 472 | |
| 473 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 474 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 475 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 476 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 477 | BT_DoubleFree.reset( |
| 478 | new BuiltinBug("Double free", |
| 479 | "Try to free a memory block that has been released")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 480 | BugReport *R = new BugReport(*BT_DoubleFree, |
Benjamin Kramer | d02e232 | 2009-11-14 12:08:24 +0000 | [diff] [blame] | 481 | BT_DoubleFree->getDescription(), N); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 482 | R->addVisitor(new MallocBugVisitor(Sym)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 483 | C.EmitReport(R); |
| 484 | } |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 485 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 486 | } |
| 487 | |
| 488 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 489 | if (Hold) |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 490 | return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 491 | return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 492 | } |
| 493 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 494 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 495 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 496 | os << "an integer (" << IntVal->getValue() << ")"; |
| 497 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 498 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 499 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 500 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 501 | else |
| 502 | return false; |
| 503 | |
| 504 | return true; |
| 505 | } |
| 506 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 507 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 508 | const MemRegion *MR) { |
| 509 | switch (MR->getKind()) { |
| 510 | case MemRegion::FunctionTextRegionKind: { |
| 511 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 512 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 513 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 514 | else |
| 515 | os << "the address of a function"; |
| 516 | return true; |
| 517 | } |
| 518 | case MemRegion::BlockTextRegionKind: |
| 519 | os << "block text"; |
| 520 | return true; |
| 521 | case MemRegion::BlockDataRegionKind: |
| 522 | // FIXME: where the block came from? |
| 523 | os << "a block"; |
| 524 | return true; |
| 525 | default: { |
| 526 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 527 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 528 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 529 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 530 | const VarDecl *VD; |
| 531 | if (VR) |
| 532 | VD = VR->getDecl(); |
| 533 | else |
| 534 | VD = NULL; |
| 535 | |
| 536 | if (VD) |
| 537 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 538 | else |
| 539 | os << "the address of a local stack variable"; |
| 540 | return true; |
| 541 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 542 | |
| 543 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 544 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 545 | const VarDecl *VD; |
| 546 | if (VR) |
| 547 | VD = VR->getDecl(); |
| 548 | else |
| 549 | VD = NULL; |
| 550 | |
| 551 | if (VD) |
| 552 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 553 | else |
| 554 | os << "the address of a parameter"; |
| 555 | return true; |
| 556 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 557 | |
| 558 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 559 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 560 | const VarDecl *VD; |
| 561 | if (VR) |
| 562 | VD = VR->getDecl(); |
| 563 | else |
| 564 | VD = NULL; |
| 565 | |
| 566 | if (VD) { |
| 567 | if (VD->isStaticLocal()) |
| 568 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 569 | else |
| 570 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 571 | } else |
| 572 | os << "the address of a global variable"; |
| 573 | return true; |
| 574 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 575 | |
| 576 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 577 | } |
| 578 | } |
| 579 | } |
| 580 | |
| 581 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 582 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 583 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 584 | if (!BT_BadFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 585 | BT_BadFree.reset(new BuiltinBug("Bad free")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 586 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 587 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 588 | llvm::raw_svector_ostream os(buf); |
| 589 | |
| 590 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 591 | if (MR) { |
| 592 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 593 | MR = ER->getSuperRegion(); |
| 594 | |
| 595 | // Special case for alloca() |
| 596 | if (isa<AllocaRegion>(MR)) |
| 597 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 598 | else { |
| 599 | os << "Argument to free() is "; |
| 600 | if (SummarizeRegion(os, MR)) |
| 601 | os << ", which is not memory allocated by malloc()"; |
| 602 | else |
| 603 | os << "not memory allocated by malloc()"; |
| 604 | } |
| 605 | } else { |
| 606 | os << "Argument to free() is "; |
| 607 | if (SummarizeValue(os, ArgVal)) |
| 608 | os << ", which is not memory allocated by malloc()"; |
| 609 | else |
| 610 | os << "not memory allocated by malloc()"; |
| 611 | } |
| 612 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 613 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 614 | R->addRange(range); |
| 615 | C.EmitReport(R); |
| 616 | } |
| 617 | } |
| 618 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 619 | void MallocChecker::ReallocMem(CheckerContext &C, const CallExpr *CE) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 620 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 621 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 622 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 623 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| 624 | if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
| 625 | return; |
| 626 | DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 627 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 628 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 629 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 630 | DefinedOrUnknownSVal PtrEQ = |
| 631 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 632 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 633 | // Get the size argument. If there is no size arg then give up. |
| 634 | const Expr *Arg1 = CE->getArg(1); |
| 635 | if (!Arg1) |
| 636 | return; |
| 637 | |
| 638 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 639 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| 640 | if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
| 641 | return; |
| 642 | DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 643 | |
| 644 | // Compare the size argument to 0. |
| 645 | DefinedOrUnknownSVal SizeZero = |
| 646 | svalBuilder.evalEQ(state, Arg1Val, |
| 647 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 648 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 649 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| 650 | llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| 651 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| 652 | llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| 653 | // We only assume exceptional states if they are definitely true; if the |
| 654 | // state is under-constrained, assume regular realloc behavior. |
| 655 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 656 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 657 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 658 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 659 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 660 | if ( PrtIsNull && !SizeIsZero) { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 661 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 662 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 663 | C.addTransition(stateMalloc); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 664 | return; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 665 | } |
| 666 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 667 | if (PrtIsNull && SizeIsZero) |
| 668 | return; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 669 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 670 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 671 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 672 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 673 | SVal RetVal = state->getSVal(CE, LCtx); |
| 674 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 675 | if (!FromPtr || !ToPtr) |
| 676 | return; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 677 | |
| 678 | // If the size is 0, free the memory. |
| 679 | if (SizeIsZero) |
| 680 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 681 | // The semantics of the return value are: |
| 682 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
| 683 | // to free() is returned. |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 684 | stateFree = stateFree->set<ReallocPairs>(ToPtr, FromPtr); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 685 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 686 | C.addTransition(stateFree); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 687 | return; |
| 688 | } |
| 689 | |
| 690 | // Default behavior. |
| 691 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| 692 | // FIXME: We should copy the content of the original buffer. |
| 693 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 694 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 695 | if (!stateRealloc) |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 696 | return; |
| 697 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, FromPtr); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 698 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 699 | C.addTransition(stateRealloc); |
| 700 | return; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 701 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 702 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 703 | |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 704 | void MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE) { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 705 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 706 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 707 | const LocationContext *LCtx = C.getLocationContext(); |
| 708 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 709 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 710 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 711 | svalBuilder.getContext().getSizeType()); |
| 712 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 713 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 714 | C.addTransition(MallocMemAux(C, CE, TotalSize, zeroVal, state)); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 715 | } |
| 716 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 717 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 718 | CheckerContext &C) const { |
| 719 | assert(N); |
| 720 | if (!BT_Leak) { |
| 721 | BT_Leak.reset(new BuiltinBug("Memory leak", |
| 722 | "Allocated memory never released. Potential memory leak.")); |
| 723 | // Leaks should not be reported if they are post-dominated by a sink: |
| 724 | // (1) Sinks are higher importance bugs. |
| 725 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 726 | // with __noreturn functions such as assert() or exit(). We choose not |
| 727 | // to report leaks on such paths. |
| 728 | BT_Leak->setSuppressOnSink(true); |
| 729 | } |
| 730 | |
| 731 | BugReport *R = new BugReport(*BT_Leak, BT_Leak->getDescription(), N); |
| 732 | R->addVisitor(new MallocBugVisitor(Sym)); |
| 733 | C.EmitReport(R); |
| 734 | } |
| 735 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 736 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 737 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 738 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 739 | if (!SymReaper.hasDeadSymbols()) |
| 740 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 741 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 742 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 743 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 744 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 745 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 746 | bool generateReport = false; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 747 | llvm::SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 748 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 749 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 750 | if (I->second.isAllocated()) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 751 | generateReport = true; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 752 | Errors.push_back(I->first); |
| 753 | } |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 754 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 755 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 756 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 757 | } |
| 758 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 759 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 760 | // Cleanup the Realloc Pairs Map. |
| 761 | SymRefToSymRefTy RP = state->get<ReallocPairs>(); |
| 762 | for (SymRefToSymRefTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 763 | if (SymReaper.isDead(I->first) || SymReaper.isDead(I->second)) { |
| 764 | state = state->remove<ReallocPairs>(I->first); |
| 765 | } |
| 766 | } |
| 767 | |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 768 | ExplodedNode *N = C.addTransition(state->set<RegionState>(RS)); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 769 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 770 | if (N && generateReport) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 771 | for (llvm::SmallVector<SymbolRef, 2>::iterator |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 772 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| 773 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 774 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 775 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 776 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 777 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 778 | void MallocChecker::checkEndPath(CheckerContext &C) const { |
| 779 | ProgramStateRef state = C.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 780 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 781 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 782 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 783 | RefState RS = I->second; |
| 784 | if (RS.isAllocated()) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 785 | ExplodedNode *N = C.addTransition(state); |
| 786 | if (N) |
| 787 | reportLeak(I->first, N, C); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 788 | } |
| 789 | } |
| 790 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 791 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 792 | bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| 793 | CheckerContext &C) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 794 | ProgramStateRef state = C.getState(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 795 | const RefState *RS = state->get<RegionState>(Sym); |
| 796 | if (!RS) |
| 797 | return false; |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 798 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 799 | if (RS->isAllocated()) { |
| 800 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 801 | C.addTransition(state); |
| 802 | return true; |
| 803 | } |
| 804 | return false; |
| 805 | } |
| 806 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 807 | void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| 808 | if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| 809 | return; |
| 810 | |
| 811 | // Check use after free, when a freed pointer is passed to a call. |
| 812 | ProgramStateRef State = C.getState(); |
| 813 | for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| 814 | E = CE->arg_end(); I != E; ++I) { |
| 815 | const Expr *A = *I; |
| 816 | if (A->getType().getTypePtr()->isAnyPointerType()) { |
| 817 | SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| 818 | if (!Sym) |
| 819 | continue; |
| 820 | if (checkUseAfterFree(Sym, C, A)) |
| 821 | return; |
| 822 | } |
| 823 | } |
| 824 | } |
| 825 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 826 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 827 | const Expr *E = S->getRetValue(); |
| 828 | if (!E) |
| 829 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 830 | |
| 831 | // Check if we are returning a symbol. |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 832 | SymbolRef Sym = C.getState()->getSVal(E, C.getLocationContext()).getAsSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 833 | if (!Sym) |
| 834 | return; |
| 835 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 836 | // Check if we are returning freed memory. |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 837 | if (checkUseAfterFree(Sym, C, S)) |
| 838 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 839 | |
| 840 | // Check if the symbol is escaping. |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 841 | checkEscape(Sym, S, C); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 842 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 843 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 844 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 845 | const Stmt *S) const { |
| 846 | assert(Sym); |
| 847 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 848 | if (RS && RS->isReleased()) { |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 849 | if (ExplodedNode *N = C.generateSink()) { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 850 | if (!BT_UseFree) |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 851 | BT_UseFree.reset(new BuiltinBug("Use of dynamically allocated memory " |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 852 | "after it is freed.")); |
| 853 | |
| 854 | BugReport *R = new BugReport(*BT_UseFree, BT_UseFree->getDescription(),N); |
| 855 | if (S) |
| 856 | R->addRange(S->getSourceRange()); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 857 | R->addVisitor(new MallocBugVisitor(Sym)); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 858 | C.EmitReport(R); |
| 859 | return true; |
| 860 | } |
| 861 | } |
| 862 | return false; |
| 863 | } |
| 864 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 865 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 866 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 867 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 868 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 869 | if (Sym) |
| 870 | checkUseAfterFree(Sym, C); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 871 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 872 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 873 | //===----------------------------------------------------------------------===// |
| 874 | // Check various ways a symbol can be invalidated. |
| 875 | // TODO: This logic (the next 3 functions) is copied/similar to the |
| 876 | // RetainRelease checker. We might want to factor this out. |
| 877 | //===----------------------------------------------------------------------===// |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 878 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 879 | // Stop tracking symbols when a value escapes as a result of checkBind. |
| 880 | // A value escapes in three possible cases: |
| 881 | // (1) we are binding to something that is not a memory region. |
| 882 | // (2) we are binding to a memregion that does not have stack storage |
| 883 | // (3) we are binding to a memregion with stack storage that the store |
| 884 | // does not understand. |
| 885 | void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| 886 | CheckerContext &C) const { |
| 887 | // Are we storing to something that causes the value to "escape"? |
| 888 | bool escapes = true; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 889 | ProgramStateRef state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 890 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 891 | if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| 892 | escapes = !regionLoc->getRegion()->hasStackStorage(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 893 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 894 | if (!escapes) { |
| 895 | // To test (3), generate a new state with the binding added. If it is |
| 896 | // the same state, then it escapes (since the store cannot represent |
| 897 | // the binding). |
| 898 | escapes = (state == (state->bindLoc(*regionLoc, val))); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 899 | } |
| 900 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 901 | |
| 902 | // If our store can represent the binding and we aren't storing to something |
| 903 | // that doesn't have local storage then just return and have the simulation |
| 904 | // state continue as is. |
| 905 | if (!escapes) |
| 906 | return; |
| 907 | |
| 908 | // Otherwise, find all symbols referenced by 'val' that we are tracking |
| 909 | // and stop tracking them. |
| 910 | state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| 911 | C.addTransition(state); |
| 912 | } |
| 913 | |
| 914 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 915 | // it - assuming that allocation failed on this path. |
| 916 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 917 | SVal Cond, |
| 918 | bool Assumption) const { |
| 919 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 920 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 921 | // If the symbol is assumed to NULL or another constant, this will |
| 922 | // return an APSInt*. |
| 923 | if (state->getSymVal(I.getKey())) |
| 924 | state = state->remove<RegionState>(I.getKey()); |
| 925 | } |
| 926 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 927 | // Realloc returns 0 when reallocation fails, which means that we should |
| 928 | // restore the state of the pointer being reallocated. |
| 929 | SymRefToSymRefTy RP = state->get<ReallocPairs>(); |
| 930 | for (SymRefToSymRefTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 931 | // If the symbol is assumed to NULL or another constant, this will |
| 932 | // return an APSInt*. |
| 933 | if (state->getSymVal(I.getKey())) { |
| 934 | const RefState *RS = state->get<RegionState>(I.getData()); |
| 935 | if (RS) { |
| 936 | if (RS->isReleased()) |
| 937 | state = state->set<RegionState>(I.getData(), |
| 938 | RefState::getAllocateUnchecked(RS->getStmt())); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 939 | else if (RS->isAllocated()) |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 940 | state = state->set<RegionState>(I.getData(), |
| 941 | RefState::getReleased(RS->getStmt())); |
| 942 | } |
| 943 | state = state->remove<ReallocPairs>(I.getKey()); |
| 944 | } |
| 945 | } |
| 946 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 947 | return state; |
| 948 | } |
| 949 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 950 | // Check if the function is not known to us. So, for example, we could |
| 951 | // conservatively assume it can free/reallocate it's pointer arguments. |
| 952 | // (We assume that the pointers cannot escape through calls to system |
| 953 | // functions not handled by this checker.) |
| 954 | bool MallocChecker::hasUnknownBehavior(const FunctionDecl *FD, |
| 955 | ProgramStateRef State) const { |
| 956 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 957 | |
| 958 | // If it's one of the allocation functions we can reason about, we model it's |
| 959 | // behavior explicitly. |
| 960 | if (isMemFunction(FD, ASTC)) { |
| 961 | return false; |
| 962 | } |
| 963 | |
| 964 | // If it's a system call, we know it does not free the memory. |
| 965 | SourceManager &SM = ASTC.getSourceManager(); |
| 966 | if (SM.isInSystemHeader(FD->getLocation())) { |
| 967 | return false; |
| 968 | } |
| 969 | |
| 970 | // Otherwise, assume that the function can free memory. |
| 971 | return true; |
| 972 | } |
| 973 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 974 | // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| 975 | // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| 976 | // about it anymore. |
| 977 | ProgramStateRef |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 978 | MallocChecker::checkRegionChanges(ProgramStateRef State, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 979 | const StoreManager::InvalidatedSymbols *invalidated, |
| 980 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 981 | ArrayRef<const MemRegion *> Regions, |
| 982 | const CallOrObjCMessage *Call) const { |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 983 | if (!invalidated) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 984 | return State; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 985 | llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 986 | |
| 987 | const FunctionDecl *FD = (Call ? dyn_cast<FunctionDecl>(Call->getDecl()) : 0); |
| 988 | |
| 989 | // If it's a call which might free or reallocate memory, we assume that all |
| 990 | // regions (explicit and implicit) escaped. Otherwise, whitelist explicit |
| 991 | // pointers; we still can track them. |
| 992 | if (!(FD && hasUnknownBehavior(FD, State))) { |
| 993 | for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| 994 | E = ExplicitRegions.end(); I != E; ++I) { |
| 995 | if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| 996 | WhitelistedSymbols.insert(R->getSymbol()); |
| 997 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 998 | } |
| 999 | |
| 1000 | for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| 1001 | E = invalidated->end(); I!=E; ++I) { |
| 1002 | SymbolRef sym = *I; |
| 1003 | if (WhitelistedSymbols.count(sym)) |
| 1004 | continue; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1005 | // The symbol escaped. |
| 1006 | if (const RefState *RS = State->get<RegionState>(sym)) |
| 1007 | State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1008 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1009 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1010 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1011 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1012 | PathDiagnosticPiece * |
| 1013 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 1014 | const ExplodedNode *PrevN, |
| 1015 | BugReporterContext &BRC, |
| 1016 | BugReport &BR) { |
| 1017 | const RefState *RS = N->getState()->get<RegionState>(Sym); |
| 1018 | const RefState *RSPrev = PrevN->getState()->get<RegionState>(Sym); |
| 1019 | if (!RS && !RSPrev) |
| 1020 | return 0; |
| 1021 | |
| 1022 | // We expect the interesting locations be StmtPoints corresponding to call |
| 1023 | // expressions. We do not support indirect function calls as of now. |
| 1024 | const CallExpr *CE = 0; |
| 1025 | if (isa<StmtPoint>(N->getLocation())) |
| 1026 | CE = dyn_cast<CallExpr>(cast<StmtPoint>(N->getLocation()).getStmt()); |
| 1027 | if (!CE) |
| 1028 | return 0; |
| 1029 | const FunctionDecl *funDecl = CE->getDirectCallee(); |
| 1030 | if (!funDecl) |
| 1031 | return 0; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1032 | |
| 1033 | // Find out if this is an interesting point and what is the kind. |
| 1034 | const char *Msg = 0; |
| 1035 | if (isAllocated(RS, RSPrev)) |
| 1036 | Msg = "Memory is allocated here"; |
| 1037 | else if (isReleased(RS, RSPrev)) |
| 1038 | Msg = "Memory is released here"; |
| 1039 | if (!Msg) |
| 1040 | return 0; |
| 1041 | |
| 1042 | // Generate the extra diagnostic. |
| 1043 | PathDiagnosticLocation Pos(CE, BRC.getSourceManager(), |
| 1044 | N->getLocationContext()); |
| 1045 | return new PathDiagnosticEventPiece(Pos, Msg); |
| 1046 | } |
| 1047 | |
| 1048 | |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1049 | #define REGISTER_CHECKER(name) \ |
| 1050 | void ento::register##name(CheckerManager &mgr) {\ |
| 1051 | mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1052 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1053 | |
| 1054 | REGISTER_CHECKER(MallocPessimistic) |
| 1055 | REGISTER_CHECKER(MallocOptimistic) |