Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 19 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 23 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 25 | #include "clang/Basic/SourceManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 26 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 28 | #include "llvm/ADT/STLExtras.h" |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 29 | #include <climits> |
| 30 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 31 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 32 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 33 | |
| 34 | namespace { |
| 35 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 36 | class RefState { |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 37 | enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped, |
| 38 | Relinquished } K; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 39 | const Stmt *S; |
| 40 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 41 | public: |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 42 | RefState(Kind k, const Stmt *s) : K(k), S(s) {} |
| 43 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 44 | bool isAllocated() const { return K == AllocateUnchecked; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 45 | bool isReleased() const { return K == Released; } |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 46 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 47 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 48 | |
| 49 | bool operator==(const RefState &X) const { |
| 50 | return K == X.K && S == X.S; |
| 51 | } |
| 52 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 53 | static RefState getAllocateUnchecked(const Stmt *s) { |
| 54 | return RefState(AllocateUnchecked, s); |
| 55 | } |
| 56 | static RefState getAllocateFailed() { |
| 57 | return RefState(AllocateFailed, 0); |
| 58 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 59 | static RefState getReleased(const Stmt *s) { return RefState(Released, s); } |
| 60 | static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); } |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 61 | static RefState getRelinquished(const Stmt *s) { |
| 62 | return RefState(Relinquished, s); |
| 63 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 64 | |
| 65 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 66 | ID.AddInteger(K); |
| 67 | ID.AddPointer(S); |
| 68 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 69 | }; |
| 70 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 71 | struct ReallocPair { |
| 72 | SymbolRef ReallocatedSym; |
| 73 | bool IsFreeOnFailure; |
| 74 | ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {} |
| 75 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 76 | ID.AddInteger(IsFreeOnFailure); |
| 77 | ID.AddPointer(ReallocatedSym); |
| 78 | } |
| 79 | bool operator==(const ReallocPair &X) const { |
| 80 | return ReallocatedSym == X.ReallocatedSym && |
| 81 | IsFreeOnFailure == X.IsFreeOnFailure; |
| 82 | } |
| 83 | }; |
| 84 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 85 | typedef std::pair<const Stmt*, const MemRegion*> LeakInfo; |
| 86 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 87 | class MallocChecker : public Checker<check::DeadSymbols, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 88 | check::EndPath, |
| 89 | check::PreStmt<ReturnStmt>, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 90 | check::PreStmt<CallExpr>, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 91 | check::PostStmt<CallExpr>, |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 92 | check::PostStmt<BlockExpr>, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 93 | check::Location, |
| 94 | check::Bind, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 95 | eval::Assume, |
| 96 | check::RegionChanges> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 97 | { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 98 | mutable OwningPtr<BugType> BT_DoubleFree; |
| 99 | mutable OwningPtr<BugType> BT_Leak; |
| 100 | mutable OwningPtr<BugType> BT_UseFree; |
| 101 | mutable OwningPtr<BugType> BT_BadFree; |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 102 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 103 | *II_valloc, *II_reallocf, *II_strndup, *II_strdup; |
| 104 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 105 | public: |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 106 | MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0), |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 107 | II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 108 | |
| 109 | /// In pessimistic mode, the checker assumes that it does not know which |
| 110 | /// functions might free the memory. |
| 111 | struct ChecksFilter { |
| 112 | DefaultBool CMallocPessimistic; |
| 113 | DefaultBool CMallocOptimistic; |
| 114 | }; |
| 115 | |
| 116 | ChecksFilter Filter; |
| 117 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 118 | void checkPreStmt(const CallExpr *S, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 119 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 120 | void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 121 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Anna Zaks | af498a2 | 2011-10-25 19:56:48 +0000 | [diff] [blame] | 122 | void checkEndPath(CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 123 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 124 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 125 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 126 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 127 | CheckerContext &C) const; |
| 128 | void checkBind(SVal location, SVal val, const Stmt*S, |
| 129 | CheckerContext &C) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 130 | ProgramStateRef |
| 131 | checkRegionChanges(ProgramStateRef state, |
| 132 | const StoreManager::InvalidatedSymbols *invalidated, |
| 133 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 134 | ArrayRef<const MemRegion *> Regions, |
| 135 | const CallOrObjCMessage *Call) const; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 136 | bool wantsRegionChangeUpdate(ProgramStateRef state) const { |
| 137 | return true; |
| 138 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 139 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 140 | private: |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 141 | void initIdentifierInfo(ASTContext &C) const; |
| 142 | |
| 143 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 144 | /// pointed to by one of its arguments. |
| 145 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
| 146 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 147 | static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 148 | const CallExpr *CE, |
| 149 | const OwnershipAttr* Att); |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 150 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 151 | const Expr *SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 152 | ProgramStateRef state) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 153 | return MallocMemAux(C, CE, |
| 154 | state->getSVal(SizeEx, C.getLocationContext()), |
| 155 | Init, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 156 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 157 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 158 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 159 | SVal SizeEx, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 160 | ProgramStateRef state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 161 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 162 | /// Update the RefState to reflect the new memory allocation. |
| 163 | static ProgramStateRef MallocUpdateRefState(CheckerContext &C, |
| 164 | const CallExpr *CE, |
| 165 | ProgramStateRef state); |
| 166 | |
| 167 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| 168 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 169 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
| 170 | ProgramStateRef state, unsigned Num, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 171 | bool Hold) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 172 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 173 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
| 174 | bool FreesMemOnFailure) const; |
| 175 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 176 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 177 | bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const; |
| 178 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 179 | const Stmt *S = 0) const; |
| 180 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 181 | /// Check if the function is not known to us. So, for example, we could |
| 182 | /// conservatively assume it can free/reallocate it's pointer arguments. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 183 | bool doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 184 | ProgramStateRef State) const; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 185 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 186 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 187 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 188 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 189 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 190 | /// Find the location of the allocation for Sym on the path leading to the |
| 191 | /// exploded node N. |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 192 | LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 193 | CheckerContext &C) const; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 194 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 195 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 196 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 197 | /// The bug visitor which allows us to print extra diagnostics along the |
| 198 | /// BugReport path. For example, showing the allocation site of the leaked |
| 199 | /// region. |
Jordy Rose | 0115349 | 2012-03-24 02:45:35 +0000 | [diff] [blame] | 200 | class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 201 | protected: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 202 | enum NotificationMode { |
| 203 | Normal, |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 204 | ReallocationFailed |
| 205 | }; |
| 206 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 207 | // The allocated region symbol tracked by the main analysis. |
| 208 | SymbolRef Sym; |
| 209 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 210 | // The mode we are in, i.e. what kind of diagnostics will be emitted. |
| 211 | NotificationMode Mode; |
| 212 | |
| 213 | // A symbol from when the primary region should have been reallocated. |
| 214 | SymbolRef FailedReallocSymbol; |
| 215 | |
| 216 | public: |
| 217 | MallocBugVisitor(SymbolRef S) |
| 218 | : Sym(S), Mode(Normal), FailedReallocSymbol(0) {} |
| 219 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 220 | virtual ~MallocBugVisitor() {} |
| 221 | |
| 222 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 223 | static int X = 0; |
| 224 | ID.AddPointer(&X); |
| 225 | ID.AddPointer(Sym); |
| 226 | } |
| 227 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 228 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 229 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 230 | // Did not track -> allocated. Other state (released) -> allocated. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 231 | return (Stmt && isa<CallExpr>(Stmt) && |
| 232 | (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 233 | } |
| 234 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 235 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 236 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 237 | // Did not track -> released. Other state (allocated) -> released. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 238 | return (Stmt && isa<CallExpr>(Stmt) && |
| 239 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 240 | } |
| 241 | |
| 242 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 243 | const Stmt *Stmt) { |
| 244 | // If the expression is not a call, and the state change is |
| 245 | // released -> allocated, it must be the realloc return value |
| 246 | // check. If we have to handle more cases here, it might be cleaner just |
| 247 | // to track this extra bit in the state itself. |
| 248 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| 249 | (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 250 | } |
| 251 | |
| 252 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 253 | const ExplodedNode *PrevN, |
| 254 | BugReporterContext &BRC, |
| 255 | BugReport &BR); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 256 | private: |
| 257 | class StackHintGeneratorForReallocationFailed |
| 258 | : public StackHintGeneratorForSymbol { |
| 259 | public: |
| 260 | StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M) |
| 261 | : StackHintGeneratorForSymbol(S, M) {} |
| 262 | |
| 263 | virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) { |
| 264 | SmallString<200> buf; |
| 265 | llvm::raw_svector_ostream os(buf); |
| 266 | |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 267 | os << "Reallocation of "; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 268 | // Printed parameters start at 1, not 0. |
| 269 | printOrdinal(++ArgIndex, os); |
| 270 | os << " parameter failed"; |
| 271 | |
| 272 | return os.str(); |
| 273 | } |
| 274 | |
| 275 | virtual std::string getMessageForReturn(const CallExpr *CallExpr) { |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 276 | return "Reallocation of returned value failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 277 | } |
| 278 | }; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 279 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 280 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 281 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 282 | |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 283 | typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 284 | typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 285 | class RegionState {}; |
| 286 | class ReallocPairs {}; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 287 | namespace clang { |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 288 | namespace ento { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 289 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 290 | struct ProgramStateTrait<RegionState> |
| 291 | : public ProgramStatePartialTrait<RegionStateTy> { |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 292 | static void *GDMIndex() { static int x; return &x; } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 293 | }; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 294 | |
| 295 | template <> |
| 296 | struct ProgramStateTrait<ReallocPairs> |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 297 | : public ProgramStatePartialTrait<ReallocMap> { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 298 | static void *GDMIndex() { static int x; return &x; } |
| 299 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 300 | } |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame] | 301 | } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 302 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 303 | namespace { |
| 304 | class StopTrackingCallback : public SymbolVisitor { |
| 305 | ProgramStateRef state; |
| 306 | public: |
| 307 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 308 | ProgramStateRef getState() const { return state; } |
| 309 | |
| 310 | bool VisitSymbol(SymbolRef sym) { |
| 311 | state = state->remove<RegionState>(sym); |
| 312 | return true; |
| 313 | } |
| 314 | }; |
| 315 | } // end anonymous namespace |
| 316 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 317 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 318 | if (!II_malloc) |
| 319 | II_malloc = &Ctx.Idents.get("malloc"); |
| 320 | if (!II_free) |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 321 | II_free = &Ctx.Idents.get("free"); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 322 | if (!II_realloc) |
| 323 | II_realloc = &Ctx.Idents.get("realloc"); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 324 | if (!II_reallocf) |
| 325 | II_reallocf = &Ctx.Idents.get("reallocf"); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 326 | if (!II_calloc) |
| 327 | II_calloc = &Ctx.Idents.get("calloc"); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 328 | if (!II_valloc) |
| 329 | II_valloc = &Ctx.Idents.get("valloc"); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 330 | if (!II_strdup) |
| 331 | II_strdup = &Ctx.Idents.get("strdup"); |
| 332 | if (!II_strndup) |
| 333 | II_strndup = &Ctx.Idents.get("strndup"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 334 | } |
| 335 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 336 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 337 | if (!FD) |
| 338 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 339 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 340 | if (!FunI) |
| 341 | return false; |
| 342 | |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 343 | initIdentifierInfo(C); |
| 344 | |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 345 | if (FunI == II_malloc || FunI == II_free || FunI == II_realloc || |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 346 | FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc || |
| 347 | FunI == II_strdup || FunI == II_strndup) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 348 | return true; |
| 349 | |
| 350 | if (Filter.CMallocOptimistic && FD->hasAttrs() && |
| 351 | FD->specific_attr_begin<OwnershipAttr>() != |
| 352 | FD->specific_attr_end<OwnershipAttr>()) |
| 353 | return true; |
| 354 | |
| 355 | |
| 356 | return false; |
| 357 | } |
| 358 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 359 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
| 360 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 361 | if (!FD) |
| 362 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 363 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 364 | initIdentifierInfo(C.getASTContext()); |
| 365 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 366 | if (!FunI) |
| 367 | return; |
| 368 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 369 | ProgramStateRef State = C.getState(); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 370 | if (FunI == II_malloc || FunI == II_valloc) { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 371 | if (CE->getNumArgs() < 1) |
| 372 | return; |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 373 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 374 | } else if (FunI == II_realloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 375 | State = ReallocMem(C, CE, false); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 376 | } else if (FunI == II_reallocf) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 377 | State = ReallocMem(C, CE, true); |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 378 | } else if (FunI == II_calloc) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 379 | State = CallocMem(C, CE); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 380 | } else if (FunI == II_free) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 381 | State = FreeMemAux(C, CE, C.getState(), 0, false); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 382 | } else if (FunI == II_strdup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 383 | State = MallocUpdateRefState(C, CE, State); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 384 | } else if (FunI == II_strndup) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 385 | State = MallocUpdateRefState(C, CE, State); |
| 386 | } else if (Filter.CMallocOptimistic) { |
| 387 | // Check all the attributes, if there are any. |
| 388 | // There can be multiple of these attributes. |
| 389 | if (FD->hasAttrs()) |
| 390 | for (specific_attr_iterator<OwnershipAttr> |
| 391 | i = FD->specific_attr_begin<OwnershipAttr>(), |
| 392 | e = FD->specific_attr_end<OwnershipAttr>(); |
| 393 | i != e; ++i) { |
| 394 | switch ((*i)->getOwnKind()) { |
| 395 | case OwnershipAttr::Returns: |
| 396 | State = MallocMemReturnsAttr(C, CE, *i); |
| 397 | break; |
| 398 | case OwnershipAttr::Takes: |
| 399 | case OwnershipAttr::Holds: |
| 400 | State = FreeMemAttr(C, CE, *i); |
| 401 | break; |
| 402 | } |
| 403 | } |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 404 | } |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 405 | C.addTransition(State); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 406 | } |
| 407 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 408 | ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C, |
| 409 | const CallExpr *CE, |
| 410 | const OwnershipAttr* Att) { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 411 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 412 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 413 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 414 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 415 | if (I != E) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 416 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 417 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 418 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 419 | } |
| 420 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 421 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 422 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 423 | SVal Size, SVal Init, |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 424 | ProgramStateRef state) { |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 425 | // Get the return value. |
| 426 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 427 | |
Anna Zaks | b16ce45 | 2012-02-15 00:11:22 +0000 | [diff] [blame] | 428 | // We expect the malloc functions to return a pointer. |
| 429 | if (!isa<Loc>(retVal)) |
| 430 | return 0; |
| 431 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 432 | // Fill the region with the initialization value. |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 433 | state = state->bindDefault(retVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 434 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 435 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 436 | const SymbolicRegion *R = |
| 437 | dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion()); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 438 | if (!R) |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 439 | return 0; |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 440 | if (isa<DefinedOrUnknownSVal>(Size)) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 441 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 442 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
| 443 | DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size); |
| 444 | DefinedOrUnknownSVal extentMatchesSize = |
| 445 | svalBuilder.evalEQ(state, Extent, DefinedSize); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 446 | |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 447 | state = state->assume(extentMatchesSize, true); |
| 448 | assert(state); |
| 449 | } |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 450 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 451 | return MallocUpdateRefState(C, CE, state); |
| 452 | } |
| 453 | |
| 454 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
| 455 | const CallExpr *CE, |
| 456 | ProgramStateRef state) { |
| 457 | // Get the return value. |
| 458 | SVal retVal = state->getSVal(CE, C.getLocationContext()); |
| 459 | |
| 460 | // We expect the malloc functions to return a pointer. |
| 461 | if (!isa<Loc>(retVal)) |
| 462 | return 0; |
| 463 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 464 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 465 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 466 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 467 | // Set the symbol's state to Allocated. |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 468 | return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE)); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 469 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 470 | } |
| 471 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 472 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 473 | const CallExpr *CE, |
| 474 | const OwnershipAttr* Att) const { |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 475 | if (Att->getModule() != "malloc") |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 476 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 477 | |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 478 | ProgramStateRef State = C.getState(); |
| 479 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 480 | for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
| 481 | I != E; ++I) { |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 482 | ProgramStateRef StateI = FreeMemAux(C, CE, State, *I, |
| 483 | Att->getOwnKind() == OwnershipAttr::Holds); |
| 484 | if (StateI) |
| 485 | State = StateI; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 486 | } |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 487 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 488 | } |
| 489 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 490 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 491 | const CallExpr *CE, |
| 492 | ProgramStateRef state, |
| 493 | unsigned Num, |
| 494 | bool Hold) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 495 | if (CE->getNumArgs() < (Num + 1)) |
| 496 | return 0; |
| 497 | |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 498 | const Expr *ArgExpr = CE->getArg(Num); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 499 | SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext()); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 500 | if (!isa<DefinedOrUnknownSVal>(ArgVal)) |
| 501 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 502 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal); |
| 503 | |
| 504 | // Check for null dereferences. |
| 505 | if (!isa<Loc>(location)) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 506 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 507 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 508 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 509 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 510 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 511 | if (nullState && !notNullState) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 512 | return 0; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 513 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 514 | // Unknown values could easily be okay |
| 515 | // Undefined values are handled elsewhere |
| 516 | if (ArgVal.isUnknownOrUndef()) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 517 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 518 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 519 | const MemRegion *R = ArgVal.getAsRegion(); |
| 520 | |
| 521 | // Nonlocs can't be freed, of course. |
| 522 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 523 | if (!R) { |
| 524 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 525 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 526 | } |
| 527 | |
| 528 | R = R->StripCasts(); |
| 529 | |
| 530 | // Blocks might show up as heap data, but should not be free()d |
| 531 | if (isa<BlockDataRegion>(R)) { |
| 532 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 533 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 534 | } |
| 535 | |
| 536 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 537 | |
| 538 | // Parameters, locals, statics, and globals shouldn't be freed. |
| 539 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 540 | // FIXME: at the time this code was written, malloc() regions were |
| 541 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 542 | // This means that there isn't actually anything from HeapSpaceRegion |
| 543 | // that should be freed, even though we allow it here. |
| 544 | // Of course, free() can work on memory allocated outside the current |
| 545 | // function, so UnknownSpaceRegion is always a possibility. |
| 546 | // False negatives are better than false positives. |
| 547 | |
| 548 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange()); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 549 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 550 | } |
| 551 | |
| 552 | const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); |
| 553 | // Various cases could lead to non-symbol values here. |
| 554 | // For now, ignore them. |
| 555 | if (!SR) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 556 | return 0; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 557 | |
| 558 | SymbolRef Sym = SR->getSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 559 | const RefState *RS = state->get<RegionState>(Sym); |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 560 | |
| 561 | // If the symbol has not been tracked, return. This is possible when free() is |
| 562 | // called on a pointer that does not get its pointee directly from malloc(). |
| 563 | // Full support of this requires inter-procedural analysis. |
| 564 | if (!RS) |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 565 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 566 | |
| 567 | // Check double free. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 568 | if (RS->isReleased()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 569 | if (ExplodedNode *N = C.generateSink()) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 570 | if (!BT_DoubleFree) |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 571 | BT_DoubleFree.reset( |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 572 | new BugType("Double free", "Memory Error")); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 573 | BugReport *R = new BugReport(*BT_DoubleFree, |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 574 | "Attempt to free released memory", N); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 575 | R->addRange(ArgExpr->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 576 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 577 | R->addVisitor(new MallocBugVisitor(Sym)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 578 | C.EmitReport(R); |
| 579 | } |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 580 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 581 | } |
| 582 | |
| 583 | // Normal free. |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 584 | if (Hold) |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 585 | return state->set<RegionState>(Sym, RefState::getRelinquished(CE)); |
| 586 | return state->set<RegionState>(Sym, RefState::getReleased(CE)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 587 | } |
| 588 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 589 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 590 | if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V)) |
| 591 | os << "an integer (" << IntVal->getValue() << ")"; |
| 592 | else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V)) |
| 593 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
| 594 | else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V)) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 595 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 596 | else |
| 597 | return false; |
| 598 | |
| 599 | return true; |
| 600 | } |
| 601 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 602 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 603 | const MemRegion *MR) { |
| 604 | switch (MR->getKind()) { |
| 605 | case MemRegion::FunctionTextRegionKind: { |
| 606 | const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
| 607 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 608 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 609 | else |
| 610 | os << "the address of a function"; |
| 611 | return true; |
| 612 | } |
| 613 | case MemRegion::BlockTextRegionKind: |
| 614 | os << "block text"; |
| 615 | return true; |
| 616 | case MemRegion::BlockDataRegionKind: |
| 617 | // FIXME: where the block came from? |
| 618 | os << "a block"; |
| 619 | return true; |
| 620 | default: { |
| 621 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 622 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 623 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 624 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 625 | const VarDecl *VD; |
| 626 | if (VR) |
| 627 | VD = VR->getDecl(); |
| 628 | else |
| 629 | VD = NULL; |
| 630 | |
| 631 | if (VD) |
| 632 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 633 | else |
| 634 | os << "the address of a local stack variable"; |
| 635 | return true; |
| 636 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 637 | |
| 638 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 639 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 640 | const VarDecl *VD; |
| 641 | if (VR) |
| 642 | VD = VR->getDecl(); |
| 643 | else |
| 644 | VD = NULL; |
| 645 | |
| 646 | if (VD) |
| 647 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 648 | else |
| 649 | os << "the address of a parameter"; |
| 650 | return true; |
| 651 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 652 | |
| 653 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 654 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 655 | const VarDecl *VD; |
| 656 | if (VR) |
| 657 | VD = VR->getDecl(); |
| 658 | else |
| 659 | VD = NULL; |
| 660 | |
| 661 | if (VD) { |
| 662 | if (VD->isStaticLocal()) |
| 663 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 664 | else |
| 665 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 666 | } else |
| 667 | os << "the address of a global variable"; |
| 668 | return true; |
| 669 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 670 | |
| 671 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 672 | } |
| 673 | } |
| 674 | } |
| 675 | |
| 676 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 677 | SourceRange range) const { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 678 | if (ExplodedNode *N = C.generateSink()) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 679 | if (!BT_BadFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 680 | BT_BadFree.reset(new BugType("Bad free", "Memory Error")); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 681 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 682 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 683 | llvm::raw_svector_ostream os(buf); |
| 684 | |
| 685 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 686 | if (MR) { |
| 687 | while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR)) |
| 688 | MR = ER->getSuperRegion(); |
| 689 | |
| 690 | // Special case for alloca() |
| 691 | if (isa<AllocaRegion>(MR)) |
| 692 | os << "Argument to free() was allocated by alloca(), not malloc()"; |
| 693 | else { |
| 694 | os << "Argument to free() is "; |
| 695 | if (SummarizeRegion(os, MR)) |
| 696 | os << ", which is not memory allocated by malloc()"; |
| 697 | else |
| 698 | os << "not memory allocated by malloc()"; |
| 699 | } |
| 700 | } else { |
| 701 | os << "Argument to free() is "; |
| 702 | if (SummarizeValue(os, ArgVal)) |
| 703 | os << ", which is not memory allocated by malloc()"; |
| 704 | else |
| 705 | os << "not memory allocated by malloc()"; |
| 706 | } |
| 707 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 708 | BugReport *R = new BugReport(*BT_BadFree, os.str(), N); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 709 | R->markInteresting(MR); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 710 | R->addRange(range); |
| 711 | C.EmitReport(R); |
| 712 | } |
| 713 | } |
| 714 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 715 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 716 | const CallExpr *CE, |
| 717 | bool FreesOnFail) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 718 | if (CE->getNumArgs() < 2) |
| 719 | return 0; |
| 720 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 721 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 722 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 723 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 724 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
| 725 | if (!isa<DefinedOrUnknownSVal>(Arg0Val)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 726 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 727 | DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 728 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 729 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 730 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 731 | DefinedOrUnknownSVal PtrEQ = |
| 732 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 733 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 734 | // Get the size argument. If there is no size arg then give up. |
| 735 | const Expr *Arg1 = CE->getArg(1); |
| 736 | if (!Arg1) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 737 | return 0; |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 738 | |
| 739 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 740 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
| 741 | if (!isa<DefinedOrUnknownSVal>(Arg1ValG)) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 742 | return 0; |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 743 | DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 744 | |
| 745 | // Compare the size argument to 0. |
| 746 | DefinedOrUnknownSVal SizeZero = |
| 747 | svalBuilder.evalEQ(state, Arg1Val, |
| 748 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 749 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 750 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
| 751 | llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
| 752 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
| 753 | llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
| 754 | // We only assume exceptional states if they are definitely true; if the |
| 755 | // state is under-constrained, assume regular realloc behavior. |
| 756 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 757 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 758 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 759 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 760 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 761 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 762 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 763 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 764 | return stateMalloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 765 | } |
| 766 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 767 | if (PrtIsNull && SizeIsZero) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 768 | return 0; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 769 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 770 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 771 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 772 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 773 | SVal RetVal = state->getSVal(CE, LCtx); |
| 774 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 775 | if (!FromPtr || !ToPtr) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 776 | return 0; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 777 | |
| 778 | // If the size is 0, free the memory. |
| 779 | if (SizeIsZero) |
| 780 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 781 | // The semantics of the return value are: |
| 782 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
| 783 | // to free() is returned. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 784 | stateFree = stateFree->set<ReallocPairs>(ToPtr, |
| 785 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 786 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 787 | return stateFree; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 788 | } |
| 789 | |
| 790 | // Default behavior. |
| 791 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) { |
| 792 | // FIXME: We should copy the content of the original buffer. |
| 793 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 794 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 795 | if (!stateRealloc) |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 796 | return 0; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 797 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
| 798 | ReallocPair(FromPtr, FreesOnFail)); |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 799 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 800 | return stateRealloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 801 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 802 | return 0; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 803 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 804 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 805 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){ |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 806 | if (CE->getNumArgs() < 2) |
| 807 | return 0; |
| 808 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 809 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 810 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 811 | const LocationContext *LCtx = C.getLocationContext(); |
| 812 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 813 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 814 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 815 | svalBuilder.getContext().getSizeType()); |
| 816 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 817 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 818 | return MallocMemAux(C, CE, TotalSize, zeroVal, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 819 | } |
| 820 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 821 | LeakInfo |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 822 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 823 | CheckerContext &C) const { |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 824 | const LocationContext *LeakContext = N->getLocationContext(); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 825 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 826 | // the tracked symbol. |
| 827 | const ExplodedNode *AllocNode = N; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 828 | const MemRegion *ReferenceRegion = 0; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 829 | |
| 830 | while (N) { |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 831 | ProgramStateRef State = N->getState(); |
| 832 | if (!State->get<RegionState>(Sym)) |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 833 | break; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 834 | |
| 835 | // Find the most recent expression bound to the symbol in the current |
| 836 | // context. |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 837 | if (!ReferenceRegion) { |
Benjamin Kramer | 850f1b1 | 2012-03-21 21:03:48 +0000 | [diff] [blame] | 838 | if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) { |
| 839 | SVal Val = State->getSVal(MR); |
| 840 | if (Val.getAsLocSymbol() == Sym) |
| 841 | ReferenceRegion = MR; |
| 842 | } |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 843 | } |
| 844 | |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 845 | // Allocation node, is the last node in the current context in which the |
| 846 | // symbol was tracked. |
| 847 | if (N->getLocationContext() == LeakContext) |
| 848 | AllocNode = N; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 849 | N = N->pred_empty() ? NULL : *(N->pred_begin()); |
| 850 | } |
| 851 | |
| 852 | ProgramPoint P = AllocNode->getLocation(); |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 853 | const Stmt *AllocationStmt = 0; |
| 854 | if (isa<StmtPoint>(P)) |
| 855 | AllocationStmt = cast<StmtPoint>(P).getStmt(); |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 856 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 857 | return LeakInfo(AllocationStmt, ReferenceRegion); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 858 | } |
| 859 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 860 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 861 | CheckerContext &C) const { |
| 862 | assert(N); |
| 863 | if (!BT_Leak) { |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 864 | BT_Leak.reset(new BugType("Memory leak", "Memory Error")); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 865 | // Leaks should not be reported if they are post-dominated by a sink: |
| 866 | // (1) Sinks are higher importance bugs. |
| 867 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 868 | // with __noreturn functions such as assert() or exit(). We choose not |
| 869 | // to report leaks on such paths. |
| 870 | BT_Leak->setSuppressOnSink(true); |
| 871 | } |
| 872 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 873 | // Most bug reports are cached at the location where they occurred. |
| 874 | // With leaks, we want to unique them by the location where they were |
| 875 | // allocated, and only report a single path. |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 876 | PathDiagnosticLocation LocUsedForUniqueing; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 877 | const Stmt *AllocStmt = 0; |
| 878 | const MemRegion *Region = 0; |
| 879 | llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C); |
| 880 | if (AllocStmt) |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 881 | LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt, |
| 882 | C.getSourceManager(), N->getLocationContext()); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 883 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 884 | SmallString<200> buf; |
| 885 | llvm::raw_svector_ostream os(buf); |
| 886 | os << "Memory is never released; potential leak"; |
| 887 | if (Region) { |
| 888 | os << " of memory pointed to by '"; |
| 889 | Region->dumpPretty(os); |
| 890 | os <<'\''; |
| 891 | } |
| 892 | |
| 893 | BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 894 | R->markInteresting(Sym); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 895 | R->addVisitor(new MallocBugVisitor(Sym)); |
| 896 | C.EmitReport(R); |
| 897 | } |
| 898 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 899 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 900 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 901 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 902 | if (!SymReaper.hasDeadSymbols()) |
| 903 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 904 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 905 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 906 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 907 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 908 | |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 909 | bool generateReport = false; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 910 | llvm::SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 911 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 912 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 913 | if (I->second.isAllocated()) { |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 914 | generateReport = true; |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 915 | Errors.push_back(I->first); |
| 916 | } |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 917 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 918 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 919 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 920 | } |
| 921 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 922 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 923 | // Cleanup the Realloc Pairs Map. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 924 | ReallocMap RP = state->get<ReallocPairs>(); |
| 925 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
| 926 | if (SymReaper.isDead(I->first) || |
| 927 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 928 | state = state->remove<ReallocPairs>(I->first); |
| 929 | } |
| 930 | } |
| 931 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 932 | // Generate leak node. |
| 933 | static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak"); |
| 934 | ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 935 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 936 | if (generateReport) { |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 937 | for (llvm::SmallVector<SymbolRef, 2>::iterator |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 938 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
| 939 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 940 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 941 | } |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 942 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 943 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 944 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 945 | void MallocChecker::checkEndPath(CheckerContext &C) const { |
| 946 | ProgramStateRef state = C.getState(); |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 947 | RegionStateTy M = state->get<RegionState>(); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 948 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 949 | // If inside inlined call, skip it. |
| 950 | if (C.getLocationContext()->getParent() != 0) |
| 951 | return; |
| 952 | |
Jordy Rose | 09cef09 | 2010-08-18 04:26:59 +0000 | [diff] [blame] | 953 | for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) { |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 954 | RefState RS = I->second; |
| 955 | if (RS.isAllocated()) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 956 | ExplodedNode *N = C.addTransition(state); |
| 957 | if (N) |
| 958 | reportLeak(I->first, N, C); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 959 | } |
| 960 | } |
| 961 | } |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 962 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 963 | bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S, |
| 964 | CheckerContext &C) const { |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 965 | ProgramStateRef state = C.getState(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 966 | const RefState *RS = state->get<RegionState>(Sym); |
| 967 | if (!RS) |
| 968 | return false; |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 969 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 970 | if (RS->isAllocated()) { |
| 971 | state = state->set<RegionState>(Sym, RefState::getEscaped(S)); |
| 972 | C.addTransition(state); |
| 973 | return true; |
| 974 | } |
| 975 | return false; |
| 976 | } |
| 977 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 978 | void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const { |
| 979 | if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext())) |
| 980 | return; |
| 981 | |
| 982 | // Check use after free, when a freed pointer is passed to a call. |
| 983 | ProgramStateRef State = C.getState(); |
| 984 | for (CallExpr::const_arg_iterator I = CE->arg_begin(), |
| 985 | E = CE->arg_end(); I != E; ++I) { |
| 986 | const Expr *A = *I; |
| 987 | if (A->getType().getTypePtr()->isAnyPointerType()) { |
| 988 | SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol(); |
| 989 | if (!Sym) |
| 990 | continue; |
| 991 | if (checkUseAfterFree(Sym, C, A)) |
| 992 | return; |
| 993 | } |
| 994 | } |
| 995 | } |
| 996 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 997 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 998 | const Expr *E = S->getRetValue(); |
| 999 | if (!E) |
| 1000 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1001 | |
| 1002 | // Check if we are returning a symbol. |
Anna Zaks | d9ab7bb | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 1003 | SVal RetVal = C.getState()->getSVal(E, C.getLocationContext()); |
| 1004 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 1005 | if (!Sym) |
| 1006 | // If we are returning a field of the allocated struct or an array element, |
| 1007 | // the callee could still free the memory. |
| 1008 | // TODO: This logic should be a part of generic symbol escape callback. |
| 1009 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 1010 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 1011 | if (const SymbolicRegion *BMR = |
| 1012 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 1013 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 1014 | if (!Sym) |
| 1015 | return; |
| 1016 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1017 | // Check if we are returning freed memory. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1018 | if (checkUseAfterFree(Sym, C, E)) |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 1019 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1020 | |
Anna Zaks | a19581a | 2012-02-20 22:25:23 +0000 | [diff] [blame] | 1021 | // If this function body is not inlined, check if the symbol is escaping. |
| 1022 | if (C.getLocationContext()->getParent() == 0) |
| 1023 | checkEscape(Sym, E, C); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 1024 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 1025 | |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 1026 | // TODO: Blocks should be either inlined or should call invalidate regions |
| 1027 | // upon invocation. After that's in place, special casing here will not be |
| 1028 | // needed. |
| 1029 | void MallocChecker::checkPostStmt(const BlockExpr *BE, |
| 1030 | CheckerContext &C) const { |
| 1031 | |
| 1032 | // Scan the BlockDecRefExprs for any object the retain count checker |
| 1033 | // may be tracking. |
| 1034 | if (!BE->getBlockDecl()->hasCaptures()) |
| 1035 | return; |
| 1036 | |
| 1037 | ProgramStateRef state = C.getState(); |
| 1038 | const BlockDataRegion *R = |
| 1039 | cast<BlockDataRegion>(state->getSVal(BE, |
| 1040 | C.getLocationContext()).getAsRegion()); |
| 1041 | |
| 1042 | BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(), |
| 1043 | E = R->referenced_vars_end(); |
| 1044 | |
| 1045 | if (I == E) |
| 1046 | return; |
| 1047 | |
| 1048 | SmallVector<const MemRegion*, 10> Regions; |
| 1049 | const LocationContext *LC = C.getLocationContext(); |
| 1050 | MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager(); |
| 1051 | |
| 1052 | for ( ; I != E; ++I) { |
| 1053 | const VarRegion *VR = *I; |
| 1054 | if (VR->getSuperRegion() == R) { |
| 1055 | VR = MemMgr.getVarRegion(VR->getDecl(), LC); |
| 1056 | } |
| 1057 | Regions.push_back(VR); |
| 1058 | } |
| 1059 | |
| 1060 | state = |
| 1061 | state->scanReachableSymbols<StopTrackingCallback>(Regions.data(), |
| 1062 | Regions.data() + Regions.size()).getState(); |
| 1063 | C.addTransition(state); |
| 1064 | } |
| 1065 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1066 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 1067 | const Stmt *S) const { |
| 1068 | assert(Sym); |
| 1069 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 1070 | if (RS && RS->isReleased()) { |
Anna Zaks | 15d0ae1 | 2012-02-11 23:46:36 +0000 | [diff] [blame] | 1071 | if (ExplodedNode *N = C.generateSink()) { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1072 | if (!BT_UseFree) |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 1073 | BT_UseFree.reset(new BugType("Use-after-free", "Memory Error")); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1074 | |
Anna Zaks | febdc32 | 2012-02-16 22:26:12 +0000 | [diff] [blame] | 1075 | BugReport *R = new BugReport(*BT_UseFree, |
| 1076 | "Use of memory after it is freed",N); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1077 | if (S) |
| 1078 | R->addRange(S->getSourceRange()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 1079 | R->markInteresting(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1080 | R->addVisitor(new MallocBugVisitor(Sym)); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1081 | C.EmitReport(R); |
| 1082 | return true; |
| 1083 | } |
| 1084 | } |
| 1085 | return false; |
| 1086 | } |
| 1087 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1088 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 1089 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 1090 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1091 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1092 | if (Sym) |
| 1093 | checkUseAfterFree(Sym, C); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 1094 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1095 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1096 | //===----------------------------------------------------------------------===// |
| 1097 | // Check various ways a symbol can be invalidated. |
| 1098 | // TODO: This logic (the next 3 functions) is copied/similar to the |
| 1099 | // RetainRelease checker. We might want to factor this out. |
| 1100 | //===----------------------------------------------------------------------===// |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1101 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1102 | // Stop tracking symbols when a value escapes as a result of checkBind. |
| 1103 | // A value escapes in three possible cases: |
| 1104 | // (1) we are binding to something that is not a memory region. |
| 1105 | // (2) we are binding to a memregion that does not have stack storage |
| 1106 | // (3) we are binding to a memregion with stack storage that the store |
| 1107 | // does not understand. |
| 1108 | void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S, |
| 1109 | CheckerContext &C) const { |
| 1110 | // Are we storing to something that causes the value to "escape"? |
| 1111 | bool escapes = true; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1112 | ProgramStateRef state = C.getState(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1113 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1114 | if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) { |
| 1115 | escapes = !regionLoc->getRegion()->hasStackStorage(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1116 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1117 | if (!escapes) { |
| 1118 | // To test (3), generate a new state with the binding added. If it is |
| 1119 | // the same state, then it escapes (since the store cannot represent |
| 1120 | // the binding). |
| 1121 | escapes = (state == (state->bindLoc(*regionLoc, val))); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1122 | } |
Anna Zaks | ac59300 | 2012-02-16 03:40:57 +0000 | [diff] [blame] | 1123 | if (!escapes) { |
| 1124 | // Case 4: We do not currently model what happens when a symbol is |
| 1125 | // assigned to a struct field, so be conservative here and let the symbol |
| 1126 | // go. TODO: This could definitely be improved upon. |
| 1127 | escapes = !isa<VarRegion>(regionLoc->getRegion()); |
| 1128 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1129 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1130 | |
| 1131 | // If our store can represent the binding and we aren't storing to something |
| 1132 | // that doesn't have local storage then just return and have the simulation |
| 1133 | // state continue as is. |
| 1134 | if (!escapes) |
| 1135 | return; |
| 1136 | |
| 1137 | // Otherwise, find all symbols referenced by 'val' that we are tracking |
| 1138 | // and stop tracking them. |
| 1139 | state = state->scanReachableSymbols<StopTrackingCallback>(val).getState(); |
| 1140 | C.addTransition(state); |
| 1141 | } |
| 1142 | |
| 1143 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 1144 | // it - assuming that allocation failed on this path. |
| 1145 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 1146 | SVal Cond, |
| 1147 | bool Assumption) const { |
| 1148 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1149 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 1150 | // If the symbol is assumed to NULL or another constant, this will |
| 1151 | // return an APSInt*. |
| 1152 | if (state->getSymVal(I.getKey())) |
| 1153 | state = state->remove<RegionState>(I.getKey()); |
| 1154 | } |
| 1155 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1156 | // Realloc returns 0 when reallocation fails, which means that we should |
| 1157 | // restore the state of the pointer being reallocated. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1158 | ReallocMap RP = state->get<ReallocPairs>(); |
| 1159 | for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1160 | // If the symbol is assumed to NULL or another constant, this will |
| 1161 | // return an APSInt*. |
| 1162 | if (state->getSymVal(I.getKey())) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1163 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 1164 | const RefState *RS = state->get<RegionState>(ReallocSym); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1165 | if (RS) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1166 | if (RS->isReleased() && ! I.getData().IsFreeOnFailure) |
| 1167 | state = state->set<RegionState>(ReallocSym, |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1168 | RefState::getAllocateUnchecked(RS->getStmt())); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1169 | } |
| 1170 | state = state->remove<ReallocPairs>(I.getKey()); |
| 1171 | } |
| 1172 | } |
| 1173 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1174 | return state; |
| 1175 | } |
| 1176 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1177 | // Check if the function is known to us. So, for example, we could |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1178 | // conservatively assume it can free/reallocate it's pointer arguments. |
| 1179 | // (We assume that the pointers cannot escape through calls to system |
| 1180 | // functions not handled by this checker.) |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1181 | bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call, |
| 1182 | ProgramStateRef State) const { |
| 1183 | if (!Call) |
| 1184 | return false; |
| 1185 | |
| 1186 | // For now, assume that any C++ call can free memory. |
| 1187 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 1188 | // regions escape to C++ containers. They seem to do that even now, but for |
| 1189 | // mysterious reasons. |
| 1190 | if (Call->isCXXCall()) |
| 1191 | return false; |
| 1192 | |
| 1193 | const Decl *D = Call->getDecl(); |
| 1194 | if (!D) |
| 1195 | return false; |
| 1196 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1197 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 1198 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1199 | // If it's one of the allocation functions we can reason about, we model |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1200 | // its behavior explicitly. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1201 | if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) { |
| 1202 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1203 | } |
| 1204 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1205 | // If it's not a system call, assume it frees memory. |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1206 | SourceManager &SM = ASTC.getSourceManager(); |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1207 | if (!SM.isInSystemHeader(D->getLocation())) |
| 1208 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1209 | |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1210 | // Process C/ObjC functions. |
Jordy Rose | 257c60f | 2012-03-06 00:28:20 +0000 | [diff] [blame] | 1211 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1212 | // White list the system functions whose arguments escape. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1213 | const IdentifierInfo *II = FD->getIdentifier(); |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1214 | if (!II) |
| 1215 | return true; |
| 1216 | StringRef FName = II->getName(); |
| 1217 | |
| 1218 | // White list thread local storage. |
| 1219 | if (FName.equals("pthread_setspecific")) |
| 1220 | return false; |
| 1221 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1222 | // White list the 'XXXNoCopy' ObjC functions. |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 1223 | if (FName.endswith("NoCopy")) { |
| 1224 | // Look for the deallocator argument. We know that the memory ownership |
| 1225 | // is not transfered only if the deallocator argument is |
| 1226 | // 'kCFAllocatorNull'. |
| 1227 | for (unsigned i = 1; i < Call->getNumArgs(); ++i) { |
| 1228 | const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts(); |
| 1229 | if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) { |
| 1230 | StringRef DeallocatorName = DE->getFoundDecl()->getName(); |
| 1231 | if (DeallocatorName == "kCFAllocatorNull") |
| 1232 | return true; |
| 1233 | } |
| 1234 | } |
| 1235 | return false; |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1236 | } |
| 1237 | |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 1238 | // PR12101 |
| 1239 | // Many CoreFoundation and CoreGraphics might allow a tracked object |
| 1240 | // to escape. |
| 1241 | if (Call->isCFCGAllowingEscape(FName)) |
| 1242 | return false; |
| 1243 | |
| 1244 | // Associating streams with malloced buffers. The pointer can escape if |
| 1245 | // 'closefn' is specified (and if that function does free memory). |
| 1246 | // Currently, we do not inspect the 'closefn' function (PR12101). |
| 1247 | if (FName == "funopen") |
| 1248 | if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0)) |
| 1249 | return false; |
| 1250 | |
| 1251 | // Do not warn on pointers passed to 'setbuf' when used with std streams, |
| 1252 | // these leaks might be intentional when setting the buffer for stdio. |
| 1253 | // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer |
| 1254 | if (FName == "setbuf" || FName =="setbuffer" || |
| 1255 | FName == "setlinebuf" || FName == "setvbuf") { |
| 1256 | if (Call->getNumArgs() >= 1) |
| 1257 | if (const DeclRefExpr *Arg = |
| 1258 | dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts())) |
| 1259 | if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl())) |
| 1260 | if (D->getCanonicalDecl()->getName().find("std") |
| 1261 | != StringRef::npos) |
| 1262 | return false; |
| 1263 | } |
| 1264 | |
| 1265 | // A bunch of other functions, which take ownership of a pointer (See retain |
| 1266 | // release checker). Not all the parameters here are invalidated, but the |
| 1267 | // Malloc checker cannot differentiate between them. The right way of doing |
| 1268 | // this would be to implement a pointer escapes callback. |
| 1269 | if (FName == "CVPixelBufferCreateWithBytes" || |
| 1270 | FName == "CGBitmapContextCreateWithData" || |
Anna Zaks | 4cd7edf | 2012-03-26 18:18:39 +0000 | [diff] [blame] | 1271 | FName == "CVPixelBufferCreateWithPlanarBytes" || |
| 1272 | FName == "OSAtomicEnqueue") { |
Anna Zaks | ca23eb2 | 2012-02-29 18:42:47 +0000 | [diff] [blame] | 1273 | return false; |
| 1274 | } |
| 1275 | |
Anna Zaks | 62a5c34 | 2012-03-30 05:48:16 +0000 | [diff] [blame] | 1276 | // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can |
| 1277 | // be deallocated by NSMapRemove. |
| 1278 | if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos)) |
| 1279 | return false; |
| 1280 | |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1281 | // Otherwise, assume that the function does not free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1282 | // Most system calls, do not free the memory. |
| 1283 | return true; |
| 1284 | |
| 1285 | // Process ObjC functions. |
| 1286 | } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) { |
| 1287 | Selector S = ObjCD->getSelector(); |
| 1288 | |
| 1289 | // White list the ObjC functions which do free memory. |
| 1290 | // - Anything containing 'freeWhenDone' param set to 1. |
| 1291 | // Ex: dataWithBytesNoCopy:length:freeWhenDone. |
| 1292 | for (unsigned i = 1; i < S.getNumArgs(); ++i) { |
| 1293 | if (S.getNameForSlot(i).equals("freeWhenDone")) { |
| 1294 | if (Call->getArgSVal(i).isConstant(1)) |
| 1295 | return false; |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1296 | else |
| 1297 | return true; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1298 | } |
| 1299 | } |
| 1300 | |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 1301 | // If the first selector ends with NoCopy, assume that the ownership is |
| 1302 | // transfered as well. |
| 1303 | // Ex: [NSData dataWithBytesNoCopy:bytes length:10]; |
| 1304 | if (S.getNameForSlot(0).endswith("NoCopy")) { |
| 1305 | return false; |
| 1306 | } |
| 1307 | |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1308 | // Otherwise, assume that the function does not free memory. |
| 1309 | // Most system calls, do not free the memory. |
| 1310 | return true; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1311 | } |
| 1312 | |
| 1313 | // Otherwise, assume that the function can free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1314 | return false; |
| 1315 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1316 | } |
| 1317 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1318 | // If the symbol we are tracking is invalidated, but not explicitly (ex: the &p |
| 1319 | // escapes, when we are tracking p), do not track the symbol as we cannot reason |
| 1320 | // about it anymore. |
| 1321 | ProgramStateRef |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1322 | MallocChecker::checkRegionChanges(ProgramStateRef State, |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1323 | const StoreManager::InvalidatedSymbols *invalidated, |
| 1324 | ArrayRef<const MemRegion *> ExplicitRegions, |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1325 | ArrayRef<const MemRegion *> Regions, |
| 1326 | const CallOrObjCMessage *Call) const { |
Anna Zaks | 0d389b8 | 2012-02-23 01:05:27 +0000 | [diff] [blame] | 1327 | if (!invalidated || invalidated->empty()) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1328 | return State; |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1329 | llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1330 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1331 | // If it's a call which might free or reallocate memory, we assume that all |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 1332 | // regions (explicit and implicit) escaped. |
| 1333 | |
| 1334 | // Otherwise, whitelist explicit pointers; we still can track them. |
| 1335 | if (!Call || doesNotFreeMemory(Call, State)) { |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1336 | for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(), |
| 1337 | E = ExplicitRegions.end(); I != E; ++I) { |
| 1338 | if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>()) |
| 1339 | WhitelistedSymbols.insert(R->getSymbol()); |
| 1340 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1341 | } |
| 1342 | |
| 1343 | for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(), |
| 1344 | E = invalidated->end(); I!=E; ++I) { |
| 1345 | SymbolRef sym = *I; |
| 1346 | if (WhitelistedSymbols.count(sym)) |
| 1347 | continue; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1348 | // The symbol escaped. |
| 1349 | if (const RefState *RS = State->get<RegionState>(sym)) |
| 1350 | State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt())); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 1351 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1352 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1353 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1354 | |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1355 | static SymbolRef findFailedReallocSymbol(ProgramStateRef currState, |
| 1356 | ProgramStateRef prevState) { |
| 1357 | ReallocMap currMap = currState->get<ReallocPairs>(); |
| 1358 | ReallocMap prevMap = prevState->get<ReallocPairs>(); |
| 1359 | |
| 1360 | for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end(); |
| 1361 | I != E; ++I) { |
| 1362 | SymbolRef sym = I.getKey(); |
| 1363 | if (!currMap.lookup(sym)) |
| 1364 | return sym; |
| 1365 | } |
| 1366 | |
| 1367 | return NULL; |
| 1368 | } |
| 1369 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1370 | PathDiagnosticPiece * |
| 1371 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 1372 | const ExplodedNode *PrevN, |
| 1373 | BugReporterContext &BRC, |
| 1374 | BugReport &BR) { |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1375 | ProgramStateRef state = N->getState(); |
| 1376 | ProgramStateRef statePrev = PrevN->getState(); |
| 1377 | |
| 1378 | const RefState *RS = state->get<RegionState>(Sym); |
| 1379 | const RefState *RSPrev = statePrev->get<RegionState>(Sym); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1380 | if (!RS && !RSPrev) |
| 1381 | return 0; |
| 1382 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1383 | const Stmt *S = 0; |
| 1384 | const char *Msg = 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1385 | StackHintGeneratorForSymbol *StackHint = 0; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1386 | |
| 1387 | // Retrieve the associated statement. |
| 1388 | ProgramPoint ProgLoc = N->getLocation(); |
| 1389 | if (isa<StmtPoint>(ProgLoc)) |
| 1390 | S = cast<StmtPoint>(ProgLoc).getStmt(); |
| 1391 | // If an assumption was made on a branch, it should be caught |
| 1392 | // here by looking at the state transition. |
| 1393 | if (isa<BlockEdge>(ProgLoc)) { |
| 1394 | const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc(); |
| 1395 | S = srcBlk->getTerminator(); |
| 1396 | } |
| 1397 | if (!S) |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1398 | return 0; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1399 | |
| 1400 | // Find out if this is an interesting point and what is the kind. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1401 | if (Mode == Normal) { |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1402 | if (isAllocated(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1403 | Msg = "Memory is allocated"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1404 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1405 | "Returned allocated memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1406 | } else if (isReleased(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1407 | Msg = "Memory is released"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1408 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1409 | "Returned released memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 1410 | } else if (isReallocFailedCheck(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1411 | Mode = ReallocationFailed; |
| 1412 | Msg = "Reallocation failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1413 | StackHint = new StackHintGeneratorForReallocationFailed(Sym, |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 1414 | "Reallocation failed"); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1415 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1416 | if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) { |
| 1417 | // Is it possible to fail two reallocs WITHOUT testing in between? |
| 1418 | assert((!FailedReallocSymbol || FailedReallocSymbol == sym) && |
| 1419 | "We only support one failed realloc at a time."); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 1420 | BR.markInteresting(sym); |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1421 | FailedReallocSymbol = sym; |
| 1422 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1423 | } |
| 1424 | |
| 1425 | // We are in a special mode if a reallocation failed later in the path. |
| 1426 | } else if (Mode == ReallocationFailed) { |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1427 | assert(FailedReallocSymbol && "No symbol to look for."); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1428 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 1429 | // Is this is the first appearance of the reallocated symbol? |
| 1430 | if (!statePrev->get<RegionState>(FailedReallocSymbol)) { |
| 1431 | // If we ever hit this assert, that means BugReporter has decided to skip |
| 1432 | // node pairs or visit them out of order. |
| 1433 | assert(state->get<RegionState>(FailedReallocSymbol) && |
| 1434 | "Missed the reallocation point"); |
| 1435 | |
| 1436 | // We're at the reallocation point. |
| 1437 | Msg = "Attempt to reallocate memory"; |
| 1438 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 1439 | "Returned reallocated memory"); |
| 1440 | FailedReallocSymbol = NULL; |
| 1441 | Mode = Normal; |
| 1442 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1443 | } |
| 1444 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1445 | if (!Msg) |
| 1446 | return 0; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1447 | assert(StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1448 | |
| 1449 | // Generate the extra diagnostic. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 1450 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1451 | N->getLocationContext()); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 1452 | return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 1453 | } |
| 1454 | |
| 1455 | |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1456 | #define REGISTER_CHECKER(name) \ |
| 1457 | void ento::register##name(CheckerManager &mgr) {\ |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 1458 | registerCStringCheckerBasic(mgr); \ |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1459 | mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\ |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1460 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 1461 | |
| 1462 | REGISTER_CHECKER(MallocPessimistic) |
| 1463 | REGISTER_CHECKER(MallocOptimistic) |