Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 1 | //==- UninitializedValuesV2.cpp - Find Uninitialized Values -----*- C++ --*-==// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file implements uninitialized values analysis for source-level CFGs. |
| 11 | // |
| 12 | //===----------------------------------------------------------------------===// |
| 13 | |
| 14 | #include "llvm/ADT/Optional.h" |
| 15 | #include "llvm/ADT/SmallVector.h" |
| 16 | #include "llvm/ADT/BitVector.h" |
| 17 | #include "llvm/ADT/DenseMap.h" |
| 18 | #include "clang/AST/Decl.h" |
| 19 | #include "clang/Analysis/CFG.h" |
| 20 | #include "clang/Analysis/Visitors/CFGRecStmtDeclVisitor.h" |
| 21 | #include "clang/Analysis/Analyses/UninitializedValuesV2.h" |
| 22 | |
| 23 | using namespace clang; |
| 24 | |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 25 | static bool isTrackedVar(const VarDecl *vd) { |
| 26 | return vd->isLocalVarDecl() && !vd->hasGlobalStorage() && |
| 27 | vd->getType()->isScalarType(); |
| 28 | } |
| 29 | |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 30 | //------------------------------------------------------------------------====// |
| 31 | // DeclToBit: a mapping from Decls we track to bitvector indices. |
| 32 | //====------------------------------------------------------------------------// |
| 33 | |
| 34 | namespace { |
| 35 | class DeclToBit { |
| 36 | llvm::DenseMap<const VarDecl *, unsigned> map; |
| 37 | public: |
| 38 | DeclToBit() {} |
| 39 | |
| 40 | /// Compute the actual mapping from declarations to bits. |
| 41 | void computeMap(const DeclContext &dc); |
| 42 | |
| 43 | /// Return the number of declarations in the map. |
| 44 | unsigned size() const { return map.size(); } |
| 45 | |
| 46 | /// Returns the bit vector index for a given declaration. |
| 47 | llvm::Optional<unsigned> getBitVectorIndex(const VarDecl *d); |
| 48 | }; |
| 49 | } |
| 50 | |
| 51 | void DeclToBit::computeMap(const DeclContext &dc) { |
| 52 | unsigned count = 0; |
| 53 | DeclContext::specific_decl_iterator<VarDecl> I(dc.decls_begin()), |
| 54 | E(dc.decls_end()); |
| 55 | for ( ; I != E; ++I) { |
| 56 | const VarDecl *vd = *I; |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 57 | if (isTrackedVar(vd)) |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 58 | map[vd] = count++; |
| 59 | } |
| 60 | } |
| 61 | |
| 62 | llvm::Optional<unsigned> DeclToBit::getBitVectorIndex(const VarDecl *d) { |
| 63 | llvm::DenseMap<const VarDecl *, unsigned>::iterator I = map.find(d); |
| 64 | if (I == map.end()) |
| 65 | return llvm::Optional<unsigned>(); |
| 66 | return I->second; |
| 67 | } |
| 68 | |
| 69 | //------------------------------------------------------------------------====// |
| 70 | // CFGBlockValues: dataflow values for CFG blocks. |
| 71 | //====------------------------------------------------------------------------// |
| 72 | |
| 73 | namespace { |
| 74 | class CFGBlockValues { |
| 75 | const CFG &cfg; |
| 76 | llvm::BitVector **vals; |
| 77 | llvm::BitVector scratch; |
| 78 | DeclToBit declToBit; |
| 79 | public: |
| 80 | CFGBlockValues(const CFG &cfg); |
| 81 | ~CFGBlockValues(); |
| 82 | |
| 83 | void computeSetOfDeclarations(const DeclContext &dc); |
| 84 | llvm::BitVector &getBitVector(const CFGBlock *block); |
| 85 | void mergeIntoScratch(llvm::BitVector const &source, bool isFirst); |
| 86 | bool updateBitVectorWithScratch(const CFGBlock *block); |
| 87 | |
| 88 | bool hasNoDeclarations() const { |
| 89 | return declToBit.size() == 0; |
| 90 | } |
| 91 | |
| 92 | void resetScratch(); |
| 93 | llvm::BitVector::reference operator[](const VarDecl *vd); |
| 94 | }; |
| 95 | } |
| 96 | |
| 97 | CFGBlockValues::CFGBlockValues(const CFG &c) : cfg(c), vals(0) { |
| 98 | unsigned n = cfg.getNumBlockIDs(); |
| 99 | if (!n) |
| 100 | return; |
| 101 | vals = new llvm::BitVector*[n]; |
Francois Pichet | 2d78c37 | 2011-01-15 13:27:47 +0000 | [diff] [blame] | 102 | memset(vals, 0, sizeof(*vals) * n); |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 103 | } |
| 104 | |
| 105 | CFGBlockValues::~CFGBlockValues() { |
| 106 | unsigned n = cfg.getNumBlockIDs(); |
| 107 | if (n == 0) |
| 108 | return; |
| 109 | for (unsigned i = 0; i < n; ++i) |
| 110 | delete vals[i]; |
| 111 | delete [] vals; |
| 112 | } |
| 113 | |
| 114 | void CFGBlockValues::computeSetOfDeclarations(const DeclContext &dc) { |
| 115 | declToBit.computeMap(dc); |
| 116 | scratch.resize(declToBit.size()); |
| 117 | } |
| 118 | |
| 119 | llvm::BitVector &CFGBlockValues::getBitVector(const CFGBlock *block) { |
| 120 | unsigned idx = block->getBlockID(); |
| 121 | llvm::BitVector *bv = vals[idx]; |
| 122 | if (!bv) { |
| 123 | bv = new llvm::BitVector(declToBit.size()); |
| 124 | vals[idx] = bv; |
| 125 | } |
| 126 | return *bv; |
| 127 | } |
| 128 | |
| 129 | void CFGBlockValues::mergeIntoScratch(llvm::BitVector const &source, |
| 130 | bool isFirst) { |
| 131 | if (isFirst) |
| 132 | scratch = source; |
| 133 | else |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 134 | scratch |= source; |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 135 | } |
| 136 | |
| 137 | bool CFGBlockValues::updateBitVectorWithScratch(const CFGBlock *block) { |
| 138 | llvm::BitVector &dst = getBitVector(block); |
| 139 | bool changed = (dst != scratch); |
| 140 | if (changed) |
| 141 | dst = scratch; |
| 142 | return changed; |
| 143 | } |
| 144 | |
| 145 | void CFGBlockValues::resetScratch() { |
| 146 | scratch.reset(); |
| 147 | } |
| 148 | |
| 149 | llvm::BitVector::reference CFGBlockValues::operator[](const VarDecl *vd) { |
| 150 | const llvm::Optional<unsigned> &idx = declToBit.getBitVectorIndex(vd); |
| 151 | assert(idx.hasValue()); |
| 152 | return scratch[idx.getValue()]; |
| 153 | } |
| 154 | |
| 155 | //------------------------------------------------------------------------====// |
| 156 | // Worklist: worklist for dataflow analysis. |
| 157 | //====------------------------------------------------------------------------// |
| 158 | |
| 159 | namespace { |
| 160 | class DataflowWorklist { |
| 161 | llvm::SmallVector<const CFGBlock *, 20> worklist; |
| 162 | llvm::BitVector enqueuedBlocks; |
| 163 | public: |
| 164 | DataflowWorklist(const CFG &cfg) : enqueuedBlocks(cfg.getNumBlockIDs()) {} |
| 165 | |
| 166 | void enqueue(const CFGBlock *block); |
| 167 | void enqueueSuccessors(const CFGBlock *block); |
| 168 | const CFGBlock *dequeue(); |
| 169 | |
| 170 | }; |
| 171 | } |
| 172 | |
| 173 | void DataflowWorklist::enqueue(const CFGBlock *block) { |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 174 | if (!block) |
| 175 | return; |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 176 | unsigned idx = block->getBlockID(); |
| 177 | if (enqueuedBlocks[idx]) |
| 178 | return; |
| 179 | worklist.push_back(block); |
| 180 | enqueuedBlocks[idx] = true; |
| 181 | } |
| 182 | |
| 183 | void DataflowWorklist::enqueueSuccessors(const clang::CFGBlock *block) { |
| 184 | for (CFGBlock::const_succ_iterator I = block->succ_begin(), |
| 185 | E = block->succ_end(); I != E; ++I) { |
| 186 | enqueue(*I); |
| 187 | } |
| 188 | } |
| 189 | |
| 190 | const CFGBlock *DataflowWorklist::dequeue() { |
| 191 | if (worklist.empty()) |
| 192 | return 0; |
| 193 | const CFGBlock *b = worklist.back(); |
| 194 | worklist.pop_back(); |
| 195 | enqueuedBlocks[b->getBlockID()] = false; |
| 196 | return b; |
| 197 | } |
| 198 | |
| 199 | //------------------------------------------------------------------------====// |
| 200 | // Transfer function for uninitialized values analysis. |
| 201 | //====------------------------------------------------------------------------// |
| 202 | |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 203 | static const bool Initialized = false; |
| 204 | static const bool Uninitialized = true; |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 205 | |
| 206 | namespace { |
| 207 | class FindVarResult { |
| 208 | const VarDecl *vd; |
| 209 | const DeclRefExpr *dr; |
| 210 | public: |
| 211 | FindVarResult(VarDecl *vd, DeclRefExpr *dr) : vd(vd), dr(dr) {} |
| 212 | |
| 213 | const DeclRefExpr *getDeclRefExpr() const { return dr; } |
| 214 | const VarDecl *getDecl() const { return vd; } |
| 215 | }; |
| 216 | |
| 217 | class TransferFunctions : public CFGRecStmtVisitor<TransferFunctions> { |
| 218 | CFGBlockValues &vals; |
| 219 | const CFG &cfg; |
| 220 | UninitVariablesHandler *handler; |
| 221 | public: |
| 222 | TransferFunctions(CFGBlockValues &vals, const CFG &cfg, |
| 223 | UninitVariablesHandler *handler) |
| 224 | : vals(vals), cfg(cfg), handler(handler) {} |
| 225 | |
| 226 | const CFG &getCFG() { return cfg; } |
| 227 | void reportUninit(const DeclRefExpr *ex, const VarDecl *vd); |
| 228 | |
| 229 | void VisitDeclStmt(DeclStmt *ds); |
| 230 | void VisitUnaryOperator(UnaryOperator *uo); |
| 231 | void VisitBinaryOperator(BinaryOperator *bo); |
| 232 | void VisitCastExpr(CastExpr *ce); |
| 233 | }; |
| 234 | } |
| 235 | |
| 236 | void TransferFunctions::reportUninit(const DeclRefExpr *ex, |
| 237 | const VarDecl *vd) { |
| 238 | if (handler) handler->handleUseOfUninitVariable(ex, vd); |
| 239 | } |
| 240 | |
| 241 | void TransferFunctions::VisitDeclStmt(DeclStmt *ds) { |
| 242 | for (DeclStmt::decl_iterator DI = ds->decl_begin(), DE = ds->decl_end(); |
| 243 | DI != DE; ++DI) { |
| 244 | if (VarDecl *vd = dyn_cast<VarDecl>(*DI)) { |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 245 | if (isTrackedVar(vd)) |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 246 | if (Stmt *init = vd->getInit()) { |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 247 | Visit(init); |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 248 | vals[vd] = Initialized; |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 249 | } |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 250 | } |
| 251 | } |
| 252 | } |
| 253 | |
| 254 | static FindVarResult findBlockVarDecl(Expr* ex) { |
| 255 | if (DeclRefExpr* dr = dyn_cast<DeclRefExpr>(ex->IgnoreParenCasts())) |
| 256 | if (VarDecl *vd = dyn_cast<VarDecl>(dr->getDecl())) |
Ted Kremenek | c104e53 | 2011-01-18 04:53:25 +0000 | [diff] [blame^] | 257 | if (isTrackedVar(vd)) |
Ted Kremenek | 610068c | 2011-01-15 02:58:47 +0000 | [diff] [blame] | 258 | return FindVarResult(vd, dr); |
| 259 | |
| 260 | return FindVarResult(0, 0); |
| 261 | } |
| 262 | |
| 263 | void TransferFunctions::VisitBinaryOperator(clang::BinaryOperator *bo) { |
| 264 | Visit(bo->getRHS()); |
| 265 | Visit(bo->getLHS()); |
| 266 | if (bo->isAssignmentOp()) { |
| 267 | const FindVarResult &res = findBlockVarDecl(bo->getLHS()); |
| 268 | if (const VarDecl* vd = res.getDecl()) { |
| 269 | llvm::BitVector::reference bit = vals[vd]; |
| 270 | if (bit == Uninitialized) { |
| 271 | if (bo->getOpcode() != BO_Assign) |
| 272 | reportUninit(res.getDeclRefExpr(), vd); |
| 273 | bit = Initialized; |
| 274 | } |
| 275 | } |
| 276 | } |
| 277 | } |
| 278 | |
| 279 | void TransferFunctions::VisitUnaryOperator(clang::UnaryOperator *uo) { |
| 280 | Visit(uo->getSubExpr()); |
| 281 | switch (uo->getOpcode()) { |
| 282 | case clang::UO_AddrOf: |
| 283 | if (const VarDecl *vd = findBlockVarDecl(uo->getSubExpr()).getDecl()) |
| 284 | vals[vd] = Initialized; |
| 285 | break; |
| 286 | case clang::UO_PostDec: |
| 287 | case clang::UO_PostInc: |
| 288 | case clang::UO_PreDec: |
| 289 | case clang::UO_PreInc: { |
| 290 | const FindVarResult &res = findBlockVarDecl(uo->getSubExpr()); |
| 291 | if (const VarDecl *vd = res.getDecl()) { |
| 292 | llvm::BitVector::reference bit = vals[vd]; |
| 293 | if (bit == Uninitialized) { |
| 294 | reportUninit(res.getDeclRefExpr(), vd); |
| 295 | bit = Initialized; |
| 296 | } |
| 297 | } |
| 298 | break; |
| 299 | } |
| 300 | default: |
| 301 | break; |
| 302 | } |
| 303 | } |
| 304 | |
| 305 | void TransferFunctions::VisitCastExpr(clang::CastExpr *ce) { |
| 306 | Visit(ce->getSubExpr()); |
| 307 | if (ce->getCastKind() == CK_LValueToRValue) { |
| 308 | const FindVarResult &res = findBlockVarDecl(ce->getSubExpr()); |
| 309 | if (const VarDecl *vd = res.getDecl()) |
| 310 | if (vals[vd] == Uninitialized) |
| 311 | reportUninit(res.getDeclRefExpr(), vd); |
| 312 | } |
| 313 | } |
| 314 | |
| 315 | //------------------------------------------------------------------------====// |
| 316 | // High-level "driver" logic for uninitialized values analysis. |
| 317 | //====------------------------------------------------------------------------// |
| 318 | |
| 319 | static void runOnBlock(const CFGBlock *block, const CFG &cfg, |
| 320 | CFGBlockValues &vals, |
| 321 | UninitVariablesHandler *handler = 0) { |
| 322 | // Merge in values of predecessor blocks. |
| 323 | vals.resetScratch(); |
| 324 | bool isFirst = true; |
| 325 | for (CFGBlock::const_pred_iterator I = block->pred_begin(), |
| 326 | E = block->pred_end(); I != E; ++I) { |
| 327 | vals.mergeIntoScratch(vals.getBitVector(*I), isFirst); |
| 328 | isFirst = false; |
| 329 | } |
| 330 | // Apply the transfer function. |
| 331 | TransferFunctions tf(vals, cfg, handler); |
| 332 | for (CFGBlock::const_iterator I = block->begin(), E = block->end(); |
| 333 | I != E; ++I) { |
| 334 | if (const CFGStmt *cs = dyn_cast<CFGStmt>(&*I)) { |
| 335 | tf.BlockStmt_Visit(cs->getStmt()); |
| 336 | } |
| 337 | } |
| 338 | } |
| 339 | |
| 340 | void clang::runUninitializedVariablesAnalysis(const DeclContext &dc, |
| 341 | const CFG &cfg, |
| 342 | UninitVariablesHandler &handler) { |
| 343 | CFGBlockValues vals(cfg); |
| 344 | vals.computeSetOfDeclarations(dc); |
| 345 | if (vals.hasNoDeclarations()) |
| 346 | return; |
| 347 | DataflowWorklist worklist(cfg); |
| 348 | llvm::BitVector previouslyVisited(cfg.getNumBlockIDs()); |
| 349 | |
| 350 | worklist.enqueueSuccessors(&cfg.getEntry()); |
| 351 | |
| 352 | while (const CFGBlock *block = worklist.dequeue()) { |
| 353 | runOnBlock(block, cfg, vals); |
| 354 | // Did the block change? |
| 355 | bool changed = vals.updateBitVectorWithScratch(block); |
| 356 | if (changed || !previouslyVisited[block->getBlockID()]) |
| 357 | worklist.enqueueSuccessors(block); |
| 358 | previouslyVisited[block->getBlockID()] = true; |
| 359 | } |
| 360 | |
| 361 | // Run through the blocks one more time, and report uninitialized variabes. |
| 362 | for (CFG::const_iterator BI = cfg.begin(), BE = cfg.end(); BI != BE; ++BI) { |
| 363 | runOnBlock(*BI, cfg, vals, &handler); |
| 364 | } |
| 365 | } |
| 366 | |
| 367 | UninitVariablesHandler::~UninitVariablesHandler() {} |
| 368 | |