blob: 1a6e250321c8146e6ab4af88600efda9710d24cb [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordan Rosef540c542012-07-26 21:39:41 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Jordan Rose615a0922012-09-22 01:24:42 +000029#include "llvm/ADT/StringExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000030#include <climits>
31
Zhongxing Xu589c0f22009-11-12 08:38:56 +000032using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000033using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000034
35namespace {
36
Zhongxing Xu7fb14642009-12-11 00:55:44 +000037class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000038 enum Kind { // Reference to allocated memory.
39 Allocated,
40 // Reference to released/freed memory.
41 Released,
Anna Zaks050cdd72012-06-20 20:57:46 +000042 // The responsibility for freeing resources has transfered from
43 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000044 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000045 const Stmt *S;
46
Zhongxing Xu7fb14642009-12-11 00:55:44 +000047public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000048 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
49
Anna Zaks050cdd72012-06-20 20:57:46 +000050 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000051 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000052 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000053
Anna Zaksc8bb3be2012-02-13 18:05:39 +000054 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000055
56 bool operator==(const RefState &X) const {
57 return K == X.K && S == X.S;
58 }
59
Anna Zaks050cdd72012-06-20 20:57:46 +000060 static RefState getAllocated(const Stmt *s) {
61 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000062 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000063 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000064 static RefState getRelinquished(const Stmt *s) {
65 return RefState(Relinquished, s);
66 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000067
68 void Profile(llvm::FoldingSetNodeID &ID) const {
69 ID.AddInteger(K);
70 ID.AddPointer(S);
71 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000072};
73
Anna Zaks9dc298b2012-09-12 22:57:34 +000074enum ReallocPairKind {
75 RPToBeFreedAfterFailure,
76 // The symbol has been freed when reallocation failed.
77 RPIsFreeOnFailure,
78 // The symbol does not need to be freed after reallocation fails.
79 RPDoNotTrackAfterFailure
80};
81
Anna Zaks55dd9562012-08-24 02:28:20 +000082/// \class ReallocPair
83/// \brief Stores information about the symbol being reallocated by a call to
84/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaks40add292012-02-15 00:11:25 +000085struct ReallocPair {
Anna Zaks55dd9562012-08-24 02:28:20 +000086 // \brief The symbol which realloc reallocated.
Anna Zaks40add292012-02-15 00:11:25 +000087 SymbolRef ReallocatedSym;
Anna Zaks9dc298b2012-09-12 22:57:34 +000088 ReallocPairKind Kind;
Anna Zaks55dd9562012-08-24 02:28:20 +000089
Anna Zaks9dc298b2012-09-12 22:57:34 +000090 ReallocPair(SymbolRef S, ReallocPairKind K) :
91 ReallocatedSym(S), Kind(K) {}
Anna Zaks40add292012-02-15 00:11:25 +000092 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks9dc298b2012-09-12 22:57:34 +000093 ID.AddInteger(Kind);
Anna Zaks40add292012-02-15 00:11:25 +000094 ID.AddPointer(ReallocatedSym);
95 }
96 bool operator==(const ReallocPair &X) const {
97 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks9dc298b2012-09-12 22:57:34 +000098 Kind == X.Kind;
Anna Zaks40add292012-02-15 00:11:25 +000099 }
100};
101
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000102typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
103
Anna Zaksb319e022012-02-08 20:13:28 +0000104class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000105 check::EndPath,
106 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +0000107 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +0000108 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000109 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000110 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000111 check::Location,
112 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000113 eval::Assume,
114 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000115{
Anna Zaksfebdc322012-02-16 22:26:12 +0000116 mutable OwningPtr<BugType> BT_DoubleFree;
117 mutable OwningPtr<BugType> BT_Leak;
118 mutable OwningPtr<BugType> BT_UseFree;
119 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000120 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000121 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
122
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000123public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000124 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000125 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000126
127 /// In pessimistic mode, the checker assumes that it does not know which
128 /// functions might free the memory.
129 struct ChecksFilter {
130 DefaultBool CMallocPessimistic;
131 DefaultBool CMallocOptimistic;
132 };
133
134 ChecksFilter Filter;
135
Anna Zaks66c40402012-02-14 21:55:24 +0000136 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000137 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Jordan Rosede507ea2012-07-02 19:28:04 +0000138 void checkPreObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000139 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000140 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000141 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000142 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000143 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000144 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000145 void checkLocation(SVal l, bool isLoad, const Stmt *S,
146 CheckerContext &C) const;
147 void checkBind(SVal location, SVal val, const Stmt*S,
148 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000149 ProgramStateRef
150 checkRegionChanges(ProgramStateRef state,
151 const StoreManager::InvalidatedSymbols *invalidated,
152 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000153 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +0000154 const CallEvent *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000155 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
156 return true;
157 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000158
Anna Zaks93c5a242012-05-02 00:05:20 +0000159 void printState(raw_ostream &Out, ProgramStateRef State,
160 const char *NL, const char *Sep) const;
161
Zhongxing Xu7b760962009-11-13 07:25:27 +0000162private:
Anna Zaks66c40402012-02-14 21:55:24 +0000163 void initIdentifierInfo(ASTContext &C) const;
164
165 /// Check if this is one of the functions which can allocate/reallocate memory
166 /// pointed to by one of its arguments.
167 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000168 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
169 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000170
Anna Zaks87cb5be2012-02-22 19:24:52 +0000171 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
172 const CallExpr *CE,
173 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000174 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000175 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000176 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000177 return MallocMemAux(C, CE,
178 state->getSVal(SizeEx, C.getLocationContext()),
179 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000180 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000181
Ted Kremenek8bef8232012-01-26 21:29:00 +0000182 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000183 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000184 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000185
Anna Zaks87cb5be2012-02-22 19:24:52 +0000186 /// Update the RefState to reflect the new memory allocation.
187 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
188 const CallExpr *CE,
189 ProgramStateRef state);
190
191 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
192 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000193 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000194 ProgramStateRef state, unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000195 bool Hold,
196 bool &ReleasedAllocated) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000197 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
198 const Expr *ParentExpr,
199 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000200 bool Hold,
201 bool &ReleasedAllocated) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000202
Anna Zaks87cb5be2012-02-22 19:24:52 +0000203 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
204 bool FreesMemOnFailure) const;
205 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000206
Anna Zaks14345182012-05-18 01:16:10 +0000207 ///\brief Check if the memory associated with this symbol was released.
208 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
209
Anna Zaks91c2a112012-02-08 23:16:56 +0000210 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
211 const Stmt *S = 0) const;
212
Anna Zaks66c40402012-02-14 21:55:24 +0000213 /// Check if the function is not known to us. So, for example, we could
214 /// conservatively assume it can free/reallocate it's pointer arguments.
Jordan Rose740d4902012-07-02 19:27:35 +0000215 bool doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000216 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000217
Ted Kremenek9c378f72011-08-12 23:37:29 +0000218 static bool SummarizeValue(raw_ostream &os, SVal V);
219 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000220 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221
Anna Zaksca8e36e2012-02-23 21:38:21 +0000222 /// Find the location of the allocation for Sym on the path leading to the
223 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000224 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
225 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000226
Anna Zaksda046772012-02-11 21:02:40 +0000227 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
228
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000229 /// The bug visitor which allows us to print extra diagnostics along the
230 /// BugReport path. For example, showing the allocation site of the leaked
231 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000232 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000233 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000234 enum NotificationMode {
235 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000236 ReallocationFailed
237 };
238
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000239 // The allocated region symbol tracked by the main analysis.
240 SymbolRef Sym;
241
Anna Zaks88feba02012-05-10 01:37:40 +0000242 // The mode we are in, i.e. what kind of diagnostics will be emitted.
243 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000244
Anna Zaks88feba02012-05-10 01:37:40 +0000245 // A symbol from when the primary region should have been reallocated.
246 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000247
Anna Zaks88feba02012-05-10 01:37:40 +0000248 bool IsLeak;
249
250 public:
251 MallocBugVisitor(SymbolRef S, bool isLeak = false)
252 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000253
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000254 virtual ~MallocBugVisitor() {}
255
256 void Profile(llvm::FoldingSetNodeID &ID) const {
257 static int X = 0;
258 ID.AddPointer(&X);
259 ID.AddPointer(Sym);
260 }
261
Anna Zaksfe571602012-02-16 22:26:07 +0000262 inline bool isAllocated(const RefState *S, const RefState *SPrev,
263 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000264 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000265 return (Stmt && isa<CallExpr>(Stmt) &&
266 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000267 }
268
Anna Zaksfe571602012-02-16 22:26:07 +0000269 inline bool isReleased(const RefState *S, const RefState *SPrev,
270 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000271 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000272 return (Stmt && isa<CallExpr>(Stmt) &&
273 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
274 }
275
Anna Zaks5b7aa342012-06-22 02:04:31 +0000276 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
277 const Stmt *Stmt) {
278 // Did not track -> relinquished. Other state (allocated) -> relinquished.
279 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
280 isa<ObjCPropertyRefExpr>(Stmt)) &&
281 (S && S->isRelinquished()) &&
282 (!SPrev || !SPrev->isRelinquished()));
283 }
284
Anna Zaksfe571602012-02-16 22:26:07 +0000285 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
286 const Stmt *Stmt) {
287 // If the expression is not a call, and the state change is
288 // released -> allocated, it must be the realloc return value
289 // check. If we have to handle more cases here, it might be cleaner just
290 // to track this extra bit in the state itself.
291 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
292 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000293 }
294
295 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
296 const ExplodedNode *PrevN,
297 BugReporterContext &BRC,
298 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000299
300 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
301 const ExplodedNode *EndPathNode,
302 BugReport &BR) {
303 if (!IsLeak)
304 return 0;
305
306 PathDiagnosticLocation L =
307 PathDiagnosticLocation::createEndOfPath(EndPathNode,
308 BRC.getSourceManager());
309 // Do not add the statement itself as a range in case of leak.
310 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
311 }
312
Anna Zaks56a938f2012-03-16 23:24:20 +0000313 private:
314 class StackHintGeneratorForReallocationFailed
315 : public StackHintGeneratorForSymbol {
316 public:
317 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
318 : StackHintGeneratorForSymbol(S, M) {}
319
320 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
Jordan Rose615a0922012-09-22 01:24:42 +0000321 // Printed parameters start at 1, not 0.
322 ++ArgIndex;
323
Anna Zaks56a938f2012-03-16 23:24:20 +0000324 SmallString<200> buf;
325 llvm::raw_svector_ostream os(buf);
326
Jordan Rose615a0922012-09-22 01:24:42 +0000327 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
328 << " parameter failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000329
330 return os.str();
331 }
332
333 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000334 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000335 }
336 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000337 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000339} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000340
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000341typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000342typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000343class RegionState {};
344class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000345namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000346namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000347 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000348 struct ProgramStateTrait<RegionState>
349 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000350 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000351 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000352
353 template <>
354 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000355 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000356 static void *GDMIndex() { static int x; return &x; }
357 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000358}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000359}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000360
Anna Zaks4fb54872012-02-11 21:02:35 +0000361namespace {
362class StopTrackingCallback : public SymbolVisitor {
363 ProgramStateRef state;
364public:
365 StopTrackingCallback(ProgramStateRef st) : state(st) {}
366 ProgramStateRef getState() const { return state; }
367
368 bool VisitSymbol(SymbolRef sym) {
369 state = state->remove<RegionState>(sym);
370 return true;
371 }
372};
373} // end anonymous namespace
374
Anna Zaks66c40402012-02-14 21:55:24 +0000375void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000376 if (II_malloc)
377 return;
378 II_malloc = &Ctx.Idents.get("malloc");
379 II_free = &Ctx.Idents.get("free");
380 II_realloc = &Ctx.Idents.get("realloc");
381 II_reallocf = &Ctx.Idents.get("reallocf");
382 II_calloc = &Ctx.Idents.get("calloc");
383 II_valloc = &Ctx.Idents.get("valloc");
384 II_strdup = &Ctx.Idents.get("strdup");
385 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000386}
387
Anna Zaks66c40402012-02-14 21:55:24 +0000388bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000389 if (isFreeFunction(FD, C))
390 return true;
391
392 if (isAllocationFunction(FD, C))
393 return true;
394
395 return false;
396}
397
398bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
399 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000400 if (!FD)
401 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000402
Jordan Rose5ef6e942012-07-10 23:13:01 +0000403 if (FD->getKind() == Decl::Function) {
404 IdentifierInfo *FunI = FD->getIdentifier();
405 initIdentifierInfo(C);
Anna Zaks66c40402012-02-14 21:55:24 +0000406
Jordan Rose5ef6e942012-07-10 23:13:01 +0000407 if (FunI == II_malloc || FunI == II_realloc ||
408 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
409 FunI == II_strdup || FunI == II_strndup)
410 return true;
411 }
Anna Zaks66c40402012-02-14 21:55:24 +0000412
Anna Zaks14345182012-05-18 01:16:10 +0000413 if (Filter.CMallocOptimistic && FD->hasAttrs())
414 for (specific_attr_iterator<OwnershipAttr>
415 i = FD->specific_attr_begin<OwnershipAttr>(),
416 e = FD->specific_attr_end<OwnershipAttr>();
417 i != e; ++i)
418 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
419 return true;
420 return false;
421}
422
423bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
424 if (!FD)
425 return false;
426
Jordan Rose5ef6e942012-07-10 23:13:01 +0000427 if (FD->getKind() == Decl::Function) {
428 IdentifierInfo *FunI = FD->getIdentifier();
429 initIdentifierInfo(C);
Anna Zaks14345182012-05-18 01:16:10 +0000430
Jordan Rose5ef6e942012-07-10 23:13:01 +0000431 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
432 return true;
433 }
Anna Zaks66c40402012-02-14 21:55:24 +0000434
Anna Zaks14345182012-05-18 01:16:10 +0000435 if (Filter.CMallocOptimistic && FD->hasAttrs())
436 for (specific_attr_iterator<OwnershipAttr>
437 i = FD->specific_attr_begin<OwnershipAttr>(),
438 e = FD->specific_attr_end<OwnershipAttr>();
439 i != e; ++i)
440 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
441 (*i)->getOwnKind() == OwnershipAttr::Holds)
442 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000443 return false;
444}
445
Anna Zaksb319e022012-02-08 20:13:28 +0000446void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosec20c7272012-09-20 01:55:32 +0000447 if (C.wasInlined)
448 return;
449
Anna Zaksb319e022012-02-08 20:13:28 +0000450 const FunctionDecl *FD = C.getCalleeDecl(CE);
451 if (!FD)
452 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000453
Anna Zaks87cb5be2012-02-22 19:24:52 +0000454 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000455 bool ReleasedAllocatedMemory = false;
Jordan Rose5ef6e942012-07-10 23:13:01 +0000456
457 if (FD->getKind() == Decl::Function) {
458 initIdentifierInfo(C.getASTContext());
459 IdentifierInfo *FunI = FD->getIdentifier();
460
461 if (FunI == II_malloc || FunI == II_valloc) {
462 if (CE->getNumArgs() < 1)
463 return;
464 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
465 } else if (FunI == II_realloc) {
466 State = ReallocMem(C, CE, false);
467 } else if (FunI == II_reallocf) {
468 State = ReallocMem(C, CE, true);
469 } else if (FunI == II_calloc) {
470 State = CallocMem(C, CE);
471 } else if (FunI == II_free) {
Anna Zaks55dd9562012-08-24 02:28:20 +0000472 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Jordan Rose5ef6e942012-07-10 23:13:01 +0000473 } else if (FunI == II_strdup) {
474 State = MallocUpdateRefState(C, CE, State);
475 } else if (FunI == II_strndup) {
476 State = MallocUpdateRefState(C, CE, State);
477 }
478 }
479
480 if (Filter.CMallocOptimistic) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000481 // Check all the attributes, if there are any.
482 // There can be multiple of these attributes.
483 if (FD->hasAttrs())
484 for (specific_attr_iterator<OwnershipAttr>
485 i = FD->specific_attr_begin<OwnershipAttr>(),
486 e = FD->specific_attr_end<OwnershipAttr>();
487 i != e; ++i) {
488 switch ((*i)->getOwnKind()) {
489 case OwnershipAttr::Returns:
490 State = MallocMemReturnsAttr(C, CE, *i);
491 break;
492 case OwnershipAttr::Takes:
493 case OwnershipAttr::Holds:
494 State = FreeMemAttr(C, CE, *i);
495 break;
496 }
497 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000498 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000499 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000500}
501
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000502static bool isFreeWhenDoneSetToZero(const ObjCMethodCall &Call) {
503 Selector S = Call.getSelector();
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000504 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000505 if (S.getNameForSlot(i).equals("freeWhenDone"))
506 if (Call.getArgSVal(i).isConstant(0))
507 return true;
508
509 return false;
510}
511
Jordan Rosede507ea2012-07-02 19:28:04 +0000512void MallocChecker::checkPreObjCMessage(const ObjCMethodCall &Call,
Jordan Rose740d4902012-07-02 19:27:35 +0000513 CheckerContext &C) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000514 // If the first selector is dataWithBytesNoCopy, assume that the memory will
515 // be released with 'free' by the new object.
516 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
517 // Unless 'freeWhenDone' param set to 0.
518 // TODO: Check that the memory was allocated with malloc.
Anna Zaks55dd9562012-08-24 02:28:20 +0000519 bool ReleasedAllocatedMemory = false;
Jordan Rosede507ea2012-07-02 19:28:04 +0000520 Selector S = Call.getSelector();
Anna Zaks7186dc62012-06-22 22:42:30 +0000521 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
522 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
523 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000524 !isFreeWhenDoneSetToZero(Call)){
Anna Zaks5b7aa342012-06-22 02:04:31 +0000525 unsigned int argIdx = 0;
Jordan Rose740d4902012-07-02 19:27:35 +0000526 C.addTransition(FreeMemAux(C, Call.getArgExpr(argIdx),
Anna Zaks55dd9562012-08-24 02:28:20 +0000527 Call.getOriginExpr(), C.getState(), true,
528 ReleasedAllocatedMemory));
Anna Zaks5b7aa342012-06-22 02:04:31 +0000529 }
530}
531
Anna Zaks87cb5be2012-02-22 19:24:52 +0000532ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
533 const CallExpr *CE,
534 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000535 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000536 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000537
Sean Huntcf807c42010-08-18 23:23:40 +0000538 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000539 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000540 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000541 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000542 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000543}
544
Anna Zaksb319e022012-02-08 20:13:28 +0000545ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000546 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000547 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000548 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000549
550 // Bind the return value to the symbolic value from the heap region.
551 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
552 // side effects other than what we model here.
Ted Kremenek66c486f2012-08-22 06:26:15 +0000553 unsigned Count = C.blockCount();
Anna Zakse17fdb22012-06-07 03:57:32 +0000554 SValBuilder &svalBuilder = C.getSValBuilder();
555 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
556 DefinedSVal RetVal =
557 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
558 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000559
Anna Zaksb16ce452012-02-15 00:11:22 +0000560 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000561 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000562 return 0;
563
Jordy Rose32f26562010-07-04 00:00:41 +0000564 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000565 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000566
Jordy Rose32f26562010-07-04 00:00:41 +0000567 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000568 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000569 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000570 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000571 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000572 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000573 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000574 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
575 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
576 DefinedOrUnknownSVal extentMatchesSize =
577 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000578
Anna Zaks60a1fa42012-02-22 03:14:20 +0000579 state = state->assume(extentMatchesSize, true);
580 assert(state);
581 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000582
Anna Zaks87cb5be2012-02-22 19:24:52 +0000583 return MallocUpdateRefState(C, CE, state);
584}
585
586ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
587 const CallExpr *CE,
588 ProgramStateRef state) {
589 // Get the return value.
590 SVal retVal = state->getSVal(CE, C.getLocationContext());
591
592 // We expect the malloc functions to return a pointer.
593 if (!isa<Loc>(retVal))
594 return 0;
595
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000596 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000597 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000598
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000599 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000600 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000601
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000602}
603
Anna Zaks87cb5be2012-02-22 19:24:52 +0000604ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
605 const CallExpr *CE,
606 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000607 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000608 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000609
Anna Zaksb3d72752012-03-01 22:06:06 +0000610 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000611 bool ReleasedAllocated = false;
Anna Zaksb3d72752012-03-01 22:06:06 +0000612
Sean Huntcf807c42010-08-18 23:23:40 +0000613 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
614 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000615 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
Anna Zaks55dd9562012-08-24 02:28:20 +0000616 Att->getOwnKind() == OwnershipAttr::Holds,
617 ReleasedAllocated);
Anna Zaksb3d72752012-03-01 22:06:06 +0000618 if (StateI)
619 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000620 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000621 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000622}
623
Ted Kremenek8bef8232012-01-26 21:29:00 +0000624ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000625 const CallExpr *CE,
626 ProgramStateRef state,
627 unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000628 bool Hold,
629 bool &ReleasedAllocated) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000630 if (CE->getNumArgs() < (Num + 1))
631 return 0;
632
Anna Zaks55dd9562012-08-24 02:28:20 +0000633 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold, ReleasedAllocated);
Anna Zaks5b7aa342012-06-22 02:04:31 +0000634}
635
636ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
637 const Expr *ArgExpr,
638 const Expr *ParentExpr,
639 ProgramStateRef state,
Anna Zaks55dd9562012-08-24 02:28:20 +0000640 bool Hold,
641 bool &ReleasedAllocated) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000642
Ted Kremenek5eca4822012-01-06 22:09:28 +0000643 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000644 if (!isa<DefinedOrUnknownSVal>(ArgVal))
645 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000646 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
647
648 // Check for null dereferences.
649 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000650 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000651
Anna Zaksb276bd92012-02-14 00:26:13 +0000652 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000653 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000654 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000655 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000656 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000657
Jordy Rose43859f62010-06-07 19:32:37 +0000658 // Unknown values could easily be okay
659 // Undefined values are handled elsewhere
660 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000661 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000662
Jordy Rose43859f62010-06-07 19:32:37 +0000663 const MemRegion *R = ArgVal.getAsRegion();
664
665 // Nonlocs can't be freed, of course.
666 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
667 if (!R) {
668 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000669 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000670 }
671
672 R = R->StripCasts();
673
674 // Blocks might show up as heap data, but should not be free()d
675 if (isa<BlockDataRegion>(R)) {
676 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000677 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000678 }
679
680 const MemSpaceRegion *MS = R->getMemorySpace();
681
682 // Parameters, locals, statics, and globals shouldn't be freed.
683 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
684 // FIXME: at the time this code was written, malloc() regions were
685 // represented by conjured symbols, which are all in UnknownSpaceRegion.
686 // This means that there isn't actually anything from HeapSpaceRegion
687 // that should be freed, even though we allow it here.
688 // Of course, free() can work on memory allocated outside the current
689 // function, so UnknownSpaceRegion is always a possibility.
690 // False negatives are better than false positives.
691
692 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000693 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000694 }
695
696 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
697 // Various cases could lead to non-symbol values here.
698 // For now, ignore them.
699 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000700 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000701
702 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000703 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000704
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000705 // Check double free.
Anna Zaksede875b2012-08-03 18:30:18 +0000706 if (RS && (RS->isReleased() || RS->isRelinquished())) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000707 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000708 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000709 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000710 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000711 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000712 (RS->isReleased() ? "Attempt to free released memory" :
713 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000714 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000715 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000716 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000717 C.EmitReport(R);
718 }
Anna Zaksb319e022012-02-08 20:13:28 +0000719 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000720 }
721
Anna Zaks55dd9562012-08-24 02:28:20 +0000722 ReleasedAllocated = (RS != 0);
723
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000724 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000725 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000726 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
727 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000728}
729
Ted Kremenek9c378f72011-08-12 23:37:29 +0000730bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000731 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
732 os << "an integer (" << IntVal->getValue() << ")";
733 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
734 os << "a constant address (" << ConstAddr->getValue() << ")";
735 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000736 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000737 else
738 return false;
739
740 return true;
741}
742
Ted Kremenek9c378f72011-08-12 23:37:29 +0000743bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000744 const MemRegion *MR) {
745 switch (MR->getKind()) {
746 case MemRegion::FunctionTextRegionKind: {
Anna Zaks5fc1d0c2012-09-17 19:13:56 +0000747 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Rose43859f62010-06-07 19:32:37 +0000748 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000749 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000750 else
751 os << "the address of a function";
752 return true;
753 }
754 case MemRegion::BlockTextRegionKind:
755 os << "block text";
756 return true;
757 case MemRegion::BlockDataRegionKind:
758 // FIXME: where the block came from?
759 os << "a block";
760 return true;
761 default: {
762 const MemSpaceRegion *MS = MR->getMemorySpace();
763
Anna Zakseb31a762012-01-04 23:54:01 +0000764 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000765 const VarRegion *VR = dyn_cast<VarRegion>(MR);
766 const VarDecl *VD;
767 if (VR)
768 VD = VR->getDecl();
769 else
770 VD = NULL;
771
772 if (VD)
773 os << "the address of the local variable '" << VD->getName() << "'";
774 else
775 os << "the address of a local stack variable";
776 return true;
777 }
Anna Zakseb31a762012-01-04 23:54:01 +0000778
779 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000780 const VarRegion *VR = dyn_cast<VarRegion>(MR);
781 const VarDecl *VD;
782 if (VR)
783 VD = VR->getDecl();
784 else
785 VD = NULL;
786
787 if (VD)
788 os << "the address of the parameter '" << VD->getName() << "'";
789 else
790 os << "the address of a parameter";
791 return true;
792 }
Anna Zakseb31a762012-01-04 23:54:01 +0000793
794 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000795 const VarRegion *VR = dyn_cast<VarRegion>(MR);
796 const VarDecl *VD;
797 if (VR)
798 VD = VR->getDecl();
799 else
800 VD = NULL;
801
802 if (VD) {
803 if (VD->isStaticLocal())
804 os << "the address of the static variable '" << VD->getName() << "'";
805 else
806 os << "the address of the global variable '" << VD->getName() << "'";
807 } else
808 os << "the address of a global variable";
809 return true;
810 }
Anna Zakseb31a762012-01-04 23:54:01 +0000811
812 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000813 }
814 }
815}
816
817void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000818 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000819 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000820 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000821 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000822
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000823 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000824 llvm::raw_svector_ostream os(buf);
825
826 const MemRegion *MR = ArgVal.getAsRegion();
827 if (MR) {
828 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
829 MR = ER->getSuperRegion();
830
831 // Special case for alloca()
832 if (isa<AllocaRegion>(MR))
833 os << "Argument to free() was allocated by alloca(), not malloc()";
834 else {
835 os << "Argument to free() is ";
836 if (SummarizeRegion(os, MR))
837 os << ", which is not memory allocated by malloc()";
838 else
839 os << "not memory allocated by malloc()";
840 }
841 } else {
842 os << "Argument to free() is ";
843 if (SummarizeValue(os, ArgVal))
844 os << ", which is not memory allocated by malloc()";
845 else
846 os << "not memory allocated by malloc()";
847 }
848
Anna Zakse172e8b2011-08-17 23:00:25 +0000849 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000850 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000851 R->addRange(range);
852 C.EmitReport(R);
853 }
854}
855
Anna Zaks87cb5be2012-02-22 19:24:52 +0000856ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
857 const CallExpr *CE,
858 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000859 if (CE->getNumArgs() < 2)
860 return 0;
861
Ted Kremenek8bef8232012-01-26 21:29:00 +0000862 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000863 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000864 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000865 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
866 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000867 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000868 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000869
Ted Kremenek846eabd2010-12-01 21:28:31 +0000870 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000871
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000872 DefinedOrUnknownSVal PtrEQ =
873 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000874
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000875 // Get the size argument. If there is no size arg then give up.
876 const Expr *Arg1 = CE->getArg(1);
877 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000878 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000879
880 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000881 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
882 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000883 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000884 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000885
886 // Compare the size argument to 0.
887 DefinedOrUnknownSVal SizeZero =
888 svalBuilder.evalEQ(state, Arg1Val,
889 svalBuilder.makeIntValWithPtrWidth(0, false));
890
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000891 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
892 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
893 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
894 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
895 // We only assume exceptional states if they are definitely true; if the
896 // state is under-constrained, assume regular realloc behavior.
897 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
898 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
899
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000900 // If the ptr is NULL and the size is not 0, the call is equivalent to
901 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000902 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000903 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000904 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000905 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000906 }
907
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000908 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000909 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000910
Anna Zaks30838b92012-02-13 20:57:07 +0000911 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000912 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000913 SymbolRef FromPtr = arg0Val.getAsSymbol();
914 SVal RetVal = state->getSVal(CE, LCtx);
915 SymbolRef ToPtr = RetVal.getAsSymbol();
916 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000917 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000918
Anna Zaks55dd9562012-08-24 02:28:20 +0000919 bool ReleasedAllocated = false;
920
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000921 // If the size is 0, free the memory.
922 if (SizeIsZero)
Anna Zaks55dd9562012-08-24 02:28:20 +0000923 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
924 false, ReleasedAllocated)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000925 // The semantics of the return value are:
926 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaksede875b2012-08-03 18:30:18 +0000927 // to free() is returned. We just free the input pointer and do not add
928 // any constrains on the output pointer.
Anna Zaks87cb5be2012-02-22 19:24:52 +0000929 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000930 }
931
932 // Default behavior.
Anna Zaks55dd9562012-08-24 02:28:20 +0000933 if (ProgramStateRef stateFree =
934 FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) {
935
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000936 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
937 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000938 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000939 return 0;
Anna Zaks55dd9562012-08-24 02:28:20 +0000940
Anna Zaks9dc298b2012-09-12 22:57:34 +0000941 ReallocPairKind Kind = RPToBeFreedAfterFailure;
942 if (FreesOnFail)
943 Kind = RPIsFreeOnFailure;
944 else if (!ReleasedAllocated)
945 Kind = RPDoNotTrackAfterFailure;
946
Anna Zaks55dd9562012-08-24 02:28:20 +0000947 // Record the info about the reallocated symbol so that we could properly
948 // process failed reallocation.
Anna Zaks40add292012-02-15 00:11:25 +0000949 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks9dc298b2012-09-12 22:57:34 +0000950 ReallocPair(FromPtr, Kind));
Anna Zaks55dd9562012-08-24 02:28:20 +0000951 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksb276bd92012-02-14 00:26:13 +0000952 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000953 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000954 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000955 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000956}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000957
Anna Zaks87cb5be2012-02-22 19:24:52 +0000958ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000959 if (CE->getNumArgs() < 2)
960 return 0;
961
Ted Kremenek8bef8232012-01-26 21:29:00 +0000962 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000963 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000964 const LocationContext *LCtx = C.getLocationContext();
965 SVal count = state->getSVal(CE->getArg(0), LCtx);
966 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000967 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
968 svalBuilder.getContext().getSizeType());
969 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000970
Anna Zaks87cb5be2012-02-22 19:24:52 +0000971 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000972}
973
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000974LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000975MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
976 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000977 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000978 // Walk the ExplodedGraph backwards and find the first node that referred to
979 // the tracked symbol.
980 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000981 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000982
983 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000984 ProgramStateRef State = N->getState();
985 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000986 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000987
988 // Find the most recent expression bound to the symbol in the current
989 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000990 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000991 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
992 SVal Val = State->getSVal(MR);
993 if (Val.getAsLocSymbol() == Sym)
994 ReferenceRegion = MR;
995 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000996 }
997
Anna Zaks7752d292012-02-27 23:40:55 +0000998 // Allocation node, is the last node in the current context in which the
999 // symbol was tracked.
1000 if (N->getLocationContext() == LeakContext)
1001 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +00001002 N = N->pred_empty() ? NULL : *(N->pred_begin());
1003 }
1004
1005 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001006 const Stmt *AllocationStmt = 0;
Jordan Rose852aa0d2012-07-10 22:07:52 +00001007 if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&P))
1008 AllocationStmt = Exit->getCalleeContext()->getCallSite();
1009 else if (StmtPoint *SP = dyn_cast<StmtPoint>(&P))
1010 AllocationStmt = SP->getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +00001011
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001012 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +00001013}
1014
Anna Zaksda046772012-02-11 21:02:40 +00001015void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
1016 CheckerContext &C) const {
1017 assert(N);
1018 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +00001019 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +00001020 // Leaks should not be reported if they are post-dominated by a sink:
1021 // (1) Sinks are higher importance bugs.
1022 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1023 // with __noreturn functions such as assert() or exit(). We choose not
1024 // to report leaks on such paths.
1025 BT_Leak->setSuppressOnSink(true);
1026 }
1027
Anna Zaksca8e36e2012-02-23 21:38:21 +00001028 // Most bug reports are cached at the location where they occurred.
1029 // With leaks, we want to unique them by the location where they were
1030 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001031 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001032 const Stmt *AllocStmt = 0;
1033 const MemRegion *Region = 0;
1034 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1035 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001036 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1037 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001038
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001039 SmallString<200> buf;
1040 llvm::raw_svector_ostream os(buf);
1041 os << "Memory is never released; potential leak";
Jordan Rose919e8a12012-08-08 18:23:36 +00001042 if (Region && Region->canPrintPretty()) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001043 os << " of memory pointed to by '";
Jordan Rose919e8a12012-08-08 18:23:36 +00001044 Region->printPretty(os);
Jordan Rose0d53ab42012-08-08 18:23:31 +00001045 os << '\'';
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001046 }
1047
1048 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001049 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001050 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +00001051 C.EmitReport(R);
1052}
1053
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001054void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1055 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001056{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001057 if (!SymReaper.hasDeadSymbols())
1058 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001059
Ted Kremenek8bef8232012-01-26 21:29:00 +00001060 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001061 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001062 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001063
Anna Zaksf8c17b72012-02-09 06:48:19 +00001064 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001065 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1066 if (SymReaper.isDead(I->first)) {
Anna Zaks54458702012-10-29 22:51:54 +00001067 if (I->second.isAllocated())
Anna Zaksf8c17b72012-02-09 06:48:19 +00001068 Errors.push_back(I->first);
Jordy Rose90760142010-08-18 04:33:47 +00001069 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001070 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001071
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001072 }
1073 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001074
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001075 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +00001076 ReallocMap RP = state->get<ReallocPairs>();
1077 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
1078 if (SymReaper.isDead(I->first) ||
1079 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001080 state = state->remove<ReallocPairs>(I->first);
1081 }
1082 }
1083
Anna Zaksca8e36e2012-02-23 21:38:21 +00001084 // Generate leak node.
Anna Zaks54458702012-10-29 22:51:54 +00001085 ExplodedNode *N = C.getPredecessor();
1086 if (!Errors.empty()) {
1087 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1088 N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001089 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaks54458702012-10-29 22:51:54 +00001090 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Anna Zaksda046772012-02-11 21:02:40 +00001091 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001092 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001093 }
Anna Zaks54458702012-10-29 22:51:54 +00001094
Anna Zaksca8e36e2012-02-23 21:38:21 +00001095 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001096}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001097
Anna Zaksda046772012-02-11 21:02:40 +00001098void MallocChecker::checkEndPath(CheckerContext &C) const {
1099 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001100 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001101
Anna Zaksa19581a2012-02-20 22:25:23 +00001102 // If inside inlined call, skip it.
1103 if (C.getLocationContext()->getParent() != 0)
1104 return;
1105
Jordy Rose09cef092010-08-18 04:26:59 +00001106 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001107 RefState RS = I->second;
1108 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001109 ExplodedNode *N = C.addTransition(state);
1110 if (N)
1111 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001112 }
1113 }
1114}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001115
Anna Zaks66c40402012-02-14 21:55:24 +00001116void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001117 // We will check for double free in the post visit.
1118 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001119 return;
1120
1121 // Check use after free, when a freed pointer is passed to a call.
1122 ProgramStateRef State = C.getState();
1123 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1124 E = CE->arg_end(); I != E; ++I) {
1125 const Expr *A = *I;
1126 if (A->getType().getTypePtr()->isAnyPointerType()) {
1127 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1128 if (!Sym)
1129 continue;
1130 if (checkUseAfterFree(Sym, C, A))
1131 return;
1132 }
1133 }
1134}
1135
Anna Zaks91c2a112012-02-08 23:16:56 +00001136void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1137 const Expr *E = S->getRetValue();
1138 if (!E)
1139 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001140
1141 // Check if we are returning a symbol.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001142 ProgramStateRef State = C.getState();
1143 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001144 SymbolRef Sym = RetVal.getAsSymbol();
1145 if (!Sym)
1146 // If we are returning a field of the allocated struct or an array element,
1147 // the callee could still free the memory.
1148 // TODO: This logic should be a part of generic symbol escape callback.
1149 if (const MemRegion *MR = RetVal.getAsRegion())
1150 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1151 if (const SymbolicRegion *BMR =
1152 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1153 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001154
Anna Zaks0860cd02012-02-11 21:44:39 +00001155 // Check if we are returning freed memory.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001156 if (Sym)
1157 if (checkUseAfterFree(Sym, C, E))
1158 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001159
Jordan Rose0d53ab42012-08-08 18:23:31 +00001160 // If this function body is not inlined, stop tracking any returned symbols.
1161 if (C.getLocationContext()->getParent() == 0) {
1162 State =
1163 State->scanReachableSymbols<StopTrackingCallback>(RetVal).getState();
1164 C.addTransition(State);
1165 }
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001166}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001167
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001168// TODO: Blocks should be either inlined or should call invalidate regions
1169// upon invocation. After that's in place, special casing here will not be
1170// needed.
1171void MallocChecker::checkPostStmt(const BlockExpr *BE,
1172 CheckerContext &C) const {
1173
1174 // Scan the BlockDecRefExprs for any object the retain count checker
1175 // may be tracking.
1176 if (!BE->getBlockDecl()->hasCaptures())
1177 return;
1178
1179 ProgramStateRef state = C.getState();
1180 const BlockDataRegion *R =
1181 cast<BlockDataRegion>(state->getSVal(BE,
1182 C.getLocationContext()).getAsRegion());
1183
1184 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1185 E = R->referenced_vars_end();
1186
1187 if (I == E)
1188 return;
1189
1190 SmallVector<const MemRegion*, 10> Regions;
1191 const LocationContext *LC = C.getLocationContext();
1192 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1193
1194 for ( ; I != E; ++I) {
1195 const VarRegion *VR = *I;
1196 if (VR->getSuperRegion() == R) {
1197 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1198 }
1199 Regions.push_back(VR);
1200 }
1201
1202 state =
1203 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1204 Regions.data() + Regions.size()).getState();
1205 C.addTransition(state);
1206}
1207
Anna Zaks14345182012-05-18 01:16:10 +00001208bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001209 assert(Sym);
1210 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001211 return (RS && RS->isReleased());
1212}
1213
1214bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1215 const Stmt *S) const {
1216 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001217 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001218 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001219 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001220
Anna Zaksfebdc322012-02-16 22:26:12 +00001221 BugReport *R = new BugReport(*BT_UseFree,
1222 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001223 if (S)
1224 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001225 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001226 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001227 C.EmitReport(R);
1228 return true;
1229 }
1230 }
1231 return false;
1232}
1233
Zhongxing Xuc8023782010-03-10 04:58:55 +00001234// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001235void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1236 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001237 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001238 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001239 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001240}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001241
Anna Zaks4fb54872012-02-11 21:02:35 +00001242//===----------------------------------------------------------------------===//
1243// Check various ways a symbol can be invalidated.
1244// TODO: This logic (the next 3 functions) is copied/similar to the
1245// RetainRelease checker. We might want to factor this out.
1246//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001247
Anna Zaks4fb54872012-02-11 21:02:35 +00001248// Stop tracking symbols when a value escapes as a result of checkBind.
1249// A value escapes in three possible cases:
1250// (1) we are binding to something that is not a memory region.
1251// (2) we are binding to a memregion that does not have stack storage
1252// (3) we are binding to a memregion with stack storage that the store
1253// does not understand.
1254void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1255 CheckerContext &C) const {
1256 // Are we storing to something that causes the value to "escape"?
1257 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001258 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001259
Anna Zaks4fb54872012-02-11 21:02:35 +00001260 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1261 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001262
Anna Zaks4fb54872012-02-11 21:02:35 +00001263 if (!escapes) {
1264 // To test (3), generate a new state with the binding added. If it is
1265 // the same state, then it escapes (since the store cannot represent
1266 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001267 // Do this only if we know that the store is not supposed to generate the
1268 // same state.
1269 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1270 if (StoredVal != val)
1271 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001272 }
1273 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001274
1275 // If our store can represent the binding and we aren't storing to something
1276 // that doesn't have local storage then just return and have the simulation
1277 // state continue as is.
1278 if (!escapes)
1279 return;
1280
1281 // Otherwise, find all symbols referenced by 'val' that we are tracking
1282 // and stop tracking them.
1283 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1284 C.addTransition(state);
1285}
1286
1287// If a symbolic region is assumed to NULL (or another constant), stop tracking
1288// it - assuming that allocation failed on this path.
1289ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1290 SVal Cond,
1291 bool Assumption) const {
1292 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001293 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001294 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001295 ConstraintManager &CMgr = state->getConstraintManager();
1296 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1297 if (AllocFailed.isConstrainedTrue())
Anna Zaks4fb54872012-02-11 21:02:35 +00001298 state = state->remove<RegionState>(I.getKey());
1299 }
1300
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001301 // Realloc returns 0 when reallocation fails, which means that we should
1302 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001303 ReallocMap RP = state->get<ReallocPairs>();
1304 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001305 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001306 ConstraintManager &CMgr = state->getConstraintManager();
1307 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1308 if (AllocFailed.isConstrainedTrue())
Anna Zaks9dc298b2012-09-12 22:57:34 +00001309 continue;
Jordan Roseec8d4202012-11-01 00:18:27 +00001310
Anna Zaks9dc298b2012-09-12 22:57:34 +00001311 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1312 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
1313 if (RS->isReleased()) {
1314 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaks40add292012-02-15 00:11:25 +00001315 state = state->set<RegionState>(ReallocSym,
Anna Zaks9dc298b2012-09-12 22:57:34 +00001316 RefState::getAllocated(RS->getStmt()));
1317 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
1318 state = state->remove<RegionState>(ReallocSym);
1319 else
1320 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001321 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001322 }
Anna Zaks9dc298b2012-09-12 22:57:34 +00001323 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001324 }
1325
Anna Zaks4fb54872012-02-11 21:02:35 +00001326 return state;
1327}
1328
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001329// Check if the function is known to us. So, for example, we could
Jordan Rose740d4902012-07-02 19:27:35 +00001330// conservatively assume it can free/reallocate its pointer arguments.
Anna Zaks66c40402012-02-14 21:55:24 +00001331// (We assume that the pointers cannot escape through calls to system
1332// functions not handled by this checker.)
Jordan Rose740d4902012-07-02 19:27:35 +00001333bool MallocChecker::doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001334 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001335 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001336
1337 // For now, assume that any C++ call can free memory.
1338 // TODO: If we want to be more optimistic here, we'll need to make sure that
1339 // regions escape to C++ containers. They seem to do that even now, but for
1340 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001341 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001342 return false;
1343
Jordan Rose740d4902012-07-02 19:27:35 +00001344 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001345 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001346 // If it's not a framework call, or if it takes a callback, assume it
1347 // can free memory.
1348 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001349 return false;
1350
Jordan Rose740d4902012-07-02 19:27:35 +00001351 Selector S = Msg->getSelector();
Anna Zaks52a04812012-06-20 23:35:57 +00001352
Jordan Rose740d4902012-07-02 19:27:35 +00001353 // Whitelist the ObjC methods which do free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001354 // - Anything containing 'freeWhenDone' param set to 1.
1355 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001356 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001357 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1358 if (Call->getArgSVal(i).isConstant(1))
1359 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001360 else
1361 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001362 }
1363 }
1364
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001365 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001366 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001367 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
Jordan Rose740d4902012-07-02 19:27:35 +00001368 StringRef FirstSlot = S.getNameForSlot(0);
1369 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001370 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001371
Anna Zaks5f757682012-06-19 05:10:32 +00001372 // If the first selector starts with addPointer, insertPointer,
1373 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1374 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001375 // that the pointers get freed by following the container itself.
1376 if (FirstSlot.startswith("addPointer") ||
1377 FirstSlot.startswith("insertPointer") ||
1378 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001379 return false;
1380 }
1381
Jordan Rose740d4902012-07-02 19:27:35 +00001382 // Otherwise, assume that the method does not free memory.
1383 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001384 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001385 }
1386
Jordan Rose740d4902012-07-02 19:27:35 +00001387 // At this point the only thing left to handle is straight function calls.
1388 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1389 if (!FD)
1390 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001391
Jordan Rose740d4902012-07-02 19:27:35 +00001392 ASTContext &ASTC = State->getStateManager().getContext();
1393
1394 // If it's one of the allocation functions we can reason about, we model
1395 // its behavior explicitly.
1396 if (isMemFunction(FD, ASTC))
1397 return true;
1398
1399 // If it's not a system call, assume it frees memory.
1400 if (!Call->isInSystemHeader())
1401 return false;
1402
1403 // White list the system functions whose arguments escape.
1404 const IdentifierInfo *II = FD->getIdentifier();
1405 if (!II)
1406 return false;
1407 StringRef FName = II->getName();
1408
Jordan Rose740d4902012-07-02 19:27:35 +00001409 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001410 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001411 if (FName.endswith("NoCopy")) {
1412 // Look for the deallocator argument. We know that the memory ownership
1413 // is not transferred only if the deallocator argument is
1414 // 'kCFAllocatorNull'.
1415 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1416 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1417 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1418 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1419 if (DeallocatorName == "kCFAllocatorNull")
1420 return true;
1421 }
1422 }
1423 return false;
1424 }
1425
Jordan Rose740d4902012-07-02 19:27:35 +00001426 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001427 // 'closefn' is specified (and if that function does free memory),
1428 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001429 // Currently, we do not inspect the 'closefn' function (PR12101).
1430 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001431 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1432 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001433
1434 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1435 // these leaks might be intentional when setting the buffer for stdio.
1436 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1437 if (FName == "setbuf" || FName =="setbuffer" ||
1438 FName == "setlinebuf" || FName == "setvbuf") {
1439 if (Call->getNumArgs() >= 1) {
1440 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1441 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1442 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1443 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1444 return false;
1445 }
1446 }
1447
1448 // A bunch of other functions which either take ownership of a pointer or
1449 // wrap the result up in a struct or object, meaning it can be freed later.
1450 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1451 // but the Malloc checker cannot differentiate between them. The right way
1452 // of doing this would be to implement a pointer escapes callback.
1453 if (FName == "CGBitmapContextCreate" ||
1454 FName == "CGBitmapContextCreateWithData" ||
1455 FName == "CVPixelBufferCreateWithBytes" ||
1456 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1457 FName == "OSAtomicEnqueue") {
1458 return false;
1459 }
1460
Jordan Rose85d7e012012-07-02 19:27:51 +00001461 // Handle cases where we know a buffer's /address/ can escape.
1462 // Note that the above checks handle some special cases where we know that
1463 // even though the address escapes, it's still our responsibility to free the
1464 // buffer.
1465 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001466 return false;
1467
1468 // Otherwise, assume that the function does not free memory.
1469 // Most system calls do not free the memory.
1470 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001471}
1472
Anna Zaks4fb54872012-02-11 21:02:35 +00001473// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1474// escapes, when we are tracking p), do not track the symbol as we cannot reason
1475// about it anymore.
1476ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001477MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001478 const StoreManager::InvalidatedSymbols *invalidated,
1479 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001480 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +00001481 const CallEvent *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001482 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001483 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001484 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001485
Anna Zaks66c40402012-02-14 21:55:24 +00001486 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001487 // regions (explicit and implicit) escaped.
1488
1489 // Otherwise, whitelist explicit pointers; we still can track them.
1490 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001491 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1492 E = ExplicitRegions.end(); I != E; ++I) {
1493 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1494 WhitelistedSymbols.insert(R->getSymbol());
1495 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001496 }
1497
1498 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1499 E = invalidated->end(); I!=E; ++I) {
1500 SymbolRef sym = *I;
1501 if (WhitelistedSymbols.count(sym))
1502 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001503 // The symbol escaped. Note, we assume that if the symbol is released,
1504 // passing it out will result in a use after free. We also keep tracking
1505 // relinquished symbols.
1506 if (const RefState *RS = State->get<RegionState>(sym)) {
1507 if (RS->isAllocated())
Anna Zaks431e35c2012-08-09 00:42:24 +00001508 State = State->remove<RegionState>(sym);
Anna Zaks5b7aa342012-06-22 02:04:31 +00001509 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001510 }
Anna Zaks66c40402012-02-14 21:55:24 +00001511 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001512}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001513
Jordy Rose393f98b2012-03-18 07:43:35 +00001514static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1515 ProgramStateRef prevState) {
1516 ReallocMap currMap = currState->get<ReallocPairs>();
1517 ReallocMap prevMap = prevState->get<ReallocPairs>();
1518
1519 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1520 I != E; ++I) {
1521 SymbolRef sym = I.getKey();
1522 if (!currMap.lookup(sym))
1523 return sym;
1524 }
1525
1526 return NULL;
1527}
1528
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001529PathDiagnosticPiece *
1530MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1531 const ExplodedNode *PrevN,
1532 BugReporterContext &BRC,
1533 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001534 ProgramStateRef state = N->getState();
1535 ProgramStateRef statePrev = PrevN->getState();
1536
1537 const RefState *RS = state->get<RegionState>(Sym);
1538 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksede875b2012-08-03 18:30:18 +00001539 if (!RS)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001540 return 0;
1541
Anna Zaksfe571602012-02-16 22:26:07 +00001542 const Stmt *S = 0;
1543 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001544 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001545
1546 // Retrieve the associated statement.
1547 ProgramPoint ProgLoc = N->getLocation();
Jordan Rose852aa0d2012-07-10 22:07:52 +00001548 if (StmtPoint *SP = dyn_cast<StmtPoint>(&ProgLoc))
1549 S = SP->getStmt();
1550 else if (CallExitEnd *Exit = dyn_cast<CallExitEnd>(&ProgLoc))
1551 S = Exit->getCalleeContext()->getCallSite();
Anna Zaksfe571602012-02-16 22:26:07 +00001552 // If an assumption was made on a branch, it should be caught
1553 // here by looking at the state transition.
Jordan Rose852aa0d2012-07-10 22:07:52 +00001554 else if (BlockEdge *Edge = dyn_cast<BlockEdge>(&ProgLoc)) {
1555 const CFGBlock *srcBlk = Edge->getSrc();
Anna Zaksfe571602012-02-16 22:26:07 +00001556 S = srcBlk->getTerminator();
1557 }
1558 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001559 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001560
Jordan Rose28038f32012-07-10 22:07:42 +00001561 // FIXME: We will eventually need to handle non-statement-based events
1562 // (__attribute__((cleanup))).
1563
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001564 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001565 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001566 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001567 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001568 StackHint = new StackHintGeneratorForSymbol(Sym,
1569 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001570 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001571 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001572 StackHint = new StackHintGeneratorForSymbol(Sym,
1573 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001574 } else if (isRelinquished(RS, RSPrev, S)) {
1575 Msg = "Memory ownership is transfered";
1576 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001577 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001578 Mode = ReallocationFailed;
1579 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001580 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001581 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001582
Jordy Roseb000fb52012-03-24 03:15:09 +00001583 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1584 // Is it possible to fail two reallocs WITHOUT testing in between?
1585 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1586 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001587 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001588 FailedReallocSymbol = sym;
1589 }
Anna Zaksfe571602012-02-16 22:26:07 +00001590 }
1591
1592 // We are in a special mode if a reallocation failed later in the path.
1593 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001594 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001595
Jordy Roseb000fb52012-03-24 03:15:09 +00001596 // Is this is the first appearance of the reallocated symbol?
1597 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001598 // We're at the reallocation point.
1599 Msg = "Attempt to reallocate memory";
1600 StackHint = new StackHintGeneratorForSymbol(Sym,
1601 "Returned reallocated memory");
1602 FailedReallocSymbol = NULL;
1603 Mode = Normal;
1604 }
Anna Zaksfe571602012-02-16 22:26:07 +00001605 }
1606
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001607 if (!Msg)
1608 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001609 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001610
1611 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001612 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001613 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001614 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001615}
1616
Anna Zaks93c5a242012-05-02 00:05:20 +00001617void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1618 const char *NL, const char *Sep) const {
1619
1620 RegionStateTy RS = State->get<RegionState>();
1621
1622 if (!RS.isEmpty())
1623 Out << "Has Malloc data" << NL;
1624}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001625
Anna Zaks231361a2012-02-08 23:16:52 +00001626#define REGISTER_CHECKER(name) \
1627void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001628 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001629 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001630}
Anna Zaks231361a2012-02-08 23:16:52 +00001631
1632REGISTER_CHECKER(MallocPessimistic)
1633REGISTER_CHECKER(MallocOptimistic)