Fix shellcheck warnings.
diff --git a/scripts/run_integration.sh b/scripts/run_integration.sh
index b66521b..23755ef 100755
--- a/scripts/run_integration.sh
+++ b/scripts/run_integration.sh
@@ -2,15 +2,15 @@
readonly SCRIPT_FOLDER=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
readonly PROJECT_FOLDER="${SCRIPT_FOLDER}/.."
-readonly ARCHIVE_FOLDER=~/archives
+readonly ARCHIVE_FOLDER=~/cpu_features_archives
readonly QEMU_INSTALL=${ARCHIVE_FOLDER}/qemu
readonly DEFAULT_CMAKE_ARGS=" -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON"
function extract() {
case $1 in
- *.tar.bz2) tar xjf $1 ;;
- *.tar.xz) tar xJf $1 ;;
- *.tar.gz) tar xzf $1 ;;
+ *.tar.bz2) tar xjf "$1" ;;
+ *.tar.xz) tar xJf "$1" ;;
+ *.tar.gz) tar xzf "$1" ;;
*)
echo "don't know how to extract '$1'..."
exit 1
@@ -18,21 +18,22 @@
}
function unpackifnotexists() {
- mkdir -p ${ARCHIVE_FOLDER}
- cd ${ARCHIVE_FOLDER}
+ mkdir -p "${ARCHIVE_FOLDER}"
+ cd "${ARCHIVE_FOLDER}" || exit
local URL=$1
- local DESTINATION=`pwd`/$2
+ local RELATIVE_FOLDER=$2
+ local DESTINATION="${ARCHIVE_FOLDER}/${RELATIVE_FOLDER}"
if [[ ! -d "${DESTINATION}" ]] ; then
- local ARCHIVE_NAME=`echo ${URL} | sed 's/.*\///'`
- test -f ${ARCHIVE_NAME} || wget ${URL}
- extract ${ARCHIVE_NAME}
+ local ARCHIVE_NAME=$(echo ${URL} | sed 's/.*\///')
+ test -f "${ARCHIVE_NAME}" || wget -q "${URL}"
+ extract "${ARCHIVE_NAME}"
fi
}
function installqemuifneeded() {
local VERSION=${QEMU_VERSION:=2.11.1}
local ARCHES=${QEMU_ARCHES:=arm aarch64 i386 x86_64 mips mipsel}
- local TARGETS=${QEMU_TARGETS:=$(echo $ARCHES | sed 's#$# #;s#\([^ ]*\) #\1-linux-user #g')}
+ local TARGETS=${QEMU_TARGETS:=$(echo "$ARCHES" | sed 's#$# #;s#\([^ ]*\) #\1-linux-user #g')}
if echo "${VERSION} ${TARGETS}" | cmp --silent ${QEMU_INSTALL}/.build -; then
echo "qemu ${VERSION} up to date!"
@@ -48,7 +49,7 @@
local QEMU_URL="http://wiki.qemu-project.org/download/qemu-${VERSION}.tar.xz"
local QEMU_FOLDER="qemu-${VERSION}"
unpackifnotexists ${QEMU_URL} ${QEMU_FOLDER}
- cd ${QEMU_FOLDER}
+ cd ${QEMU_FOLDER} || exit
./configure \
--prefix="${QEMU_INSTALL}" \
@@ -70,13 +71,13 @@
function assert_defined(){
local VALUE=${1}
- : ${VALUE?"${1} needs to be defined"}
+ : "${VALUE?"${1} needs to be defined"}"
}
function integrate() {
- cd ${PROJECT_FOLDER}
- cmake -H. -B${BUILD_DIR} ${DEFAULT_CMAKE_ARGS} ${CMAKE_ADDITIONAL_ARGS}
- cmake --build ${BUILD_DIR} --target all
+ cd "${PROJECT_FOLDER}" || exit
+ cmake -H. -B"${BUILD_DIR}" ${DEFAULT_CMAKE_ARGS} ${CMAKE_ADDITIONAL_ARGS}
+ cmake --build "${BUILD_DIR}" --target all
if [[ -n "${QEMU_ARCH}" ]]; then
if [[ "${QEMU_ARCH}" == "DISABLED" ]]; then
@@ -91,7 +92,7 @@
# Run tests
for test_binary in ${BUILD_DIR}/test/*_test; do ${QEMU} ${test_binary}; done
# Run demo program
- ${QEMU} ${BUILD_DIR}/list_cpu_features
+ ${QEMU} "${BUILD_DIR}/list_cpu_features"
}
function expand_linaro_config() {
@@ -99,12 +100,12 @@
local LINARO_ROOT_URL=https://releases.linaro.org/components/toolchain/binaries/7.2-2017.11
local GCC_URL=${LINARO_ROOT_URL}/${TARGET}/gcc-linaro-7.2.1-2017.11-x86_64_${TARGET}.tar.xz
- local GCC_RELATIVE_FOLDER=gcc-linaro-7.2.1-2017.11-x86_64_${TARGET}
- unpackifnotexists ${GCC_URL} ${GCC_RELATIVE_FOLDER}
+ local GCC_RELATIVE_FOLDER="gcc-linaro-7.2.1-2017.11-x86_64_${TARGET}"
+ unpackifnotexists "${GCC_URL}" "${GCC_RELATIVE_FOLDER}"
local SYSROOT_URL=${LINARO_ROOT_URL}/${TARGET}/sysroot-glibc-linaro-2.25-2017.11-${TARGET}.tar.xz
local SYSROOT_RELATIVE_FOLDER=sysroot-glibc-linaro-2.25-2017.11-${TARGET}
- unpackifnotexists ${SYSROOT_URL} ${SYSROOT_RELATIVE_FOLDER}
+ unpackifnotexists "${SYSROOT_URL}" "${SYSROOT_RELATIVE_FOLDER}"
local SYSROOT_FOLDER=${ARCHIVE_FOLDER}/${SYSROOT_RELATIVE_FOLDER}
local GCC_FOLDER=${ARCHIVE_FOLDER}/${GCC_RELATIVE_FOLDER}
@@ -129,11 +130,11 @@
local GCC_URL=${CODESCAPE_URL}
local GCC_RELATIVE_FOLDER=${TARGET}/${DATE}
- unpackifnotexists ${GCC_URL} ${GCC_RELATIVE_FOLDER}
+ unpackifnotexists "${GCC_URL}" "${GCC_RELATIVE_FOLDER}"
local SYSROOT_URL=${CODESCAPE_URL}
local SYSROOT_FOLDER=${ARCHIVE_FOLDER}/${GCC_RELATIVE_FOLDER}/sysroot/${FLAVOUR}
- unpackifnotexists ${SYSROOT_URL} ${SYSROOT_RELATIVE_FOLDER}
+ unpackifnotexists "${SYSROOT_URL}" "${SYSROOT_RELATIVE_FOLDER}"
CMAKE_ADDITIONAL_ARGS+=" -DENABLE_MSA=1"
CMAKE_ADDITIONAL_ARGS+=" -DMIPS_CPU=p5600"
@@ -151,7 +152,7 @@
assert_defined TARGET
BUILD_DIR="${PROJECT_FOLDER}/cmake_build/${TARGET}"
- mkdir -p ${BUILD_DIR}
+ mkdir -p "${BUILD_DIR}"
CMAKE_ADDITIONAL_ARGS=""
QEMU_ARGS=""