Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / crosvm / 91019884bbe889b882c48e0901006306241c16c3
commit91019884bbe889b882c48e0901006306241c16c3[log] [tgz]
authorKeiichi Watanabe <keiichiw@chromium.org>Thu Nov 18 00:34:09 2021 +0900
committerCommit Bot <commit-bot@chromium.org>Fri Nov 26 14:28:28 2021 +0000
treea5bf71b2987580ff2db8c2b6623ad3677d186a60
parent2533dd15bf8b0aebcc7ac54b9862539538453b01 [diff]
sys_util: Replace unsafe use of iovecs

`sys_util::recv_iovecs_with_fds` was implemented as a safe function, but
it was actually unsafe because it assumed that the caller would give a
slice of `libc::iovec` where each `iov_base` points a valid memory
region with `iov_len`.

To make the function truly safe, it should take a slice of IoSliceMut
instead.

BUG=none
TEST=cargo test in sys_util/vmm_vhost
TEST=vhost-user block still works

Change-Id: I45458ee4545af13ce7e0955fb67b3703b147e7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3288733
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
7 files changed
tree: a5bf71b2987580ff2db8c2b6623ad3677d186a60
  1. .cargo/
  2. .devcontainer/
  3. .github/
  4. aarch64/
  5. acpi_tables/
  6. arch/
  7. bin/
  8. bit_field/
  9. ci/
  10. common/
  11. crosvm-fuzz/
  12. crosvm_plugin/
  13. devices/
  14. disk/
  15. docs/
  16. fuse/
  17. gpu_display/
  18. hypervisor/
  19. integration_tests/
  20. kernel_cmdline/
  21. kernel_loader/
  22. kvm/
  23. kvm_sys/
  24. libcras_stub/
  25. libcrosvm_control/
  26. libvda/
  27. linux_input_sys/
  28. logo/
  29. net_sys/
  30. net_util/
  31. power_monitor/
  32. protos/
  33. qcow_utils/
  34. resources/
  35. rutabaga_gfx/
  36. seccomp/
  37. src/
  38. system_api_stub/
  39. tests/
  40. third_party/
  41. tools/
  42. tpm2/
  43. tpm2-sys/
  44. usb_sys/
  45. usb_util/
  46. vfio_sys/
  47. vhost/
  48. virtio_sys/
  49. vm_control/
  50. vm_memory/
  51. x86_64/
  52. .dockerignore
  53. .gitignore
  54. .gitmodules
  55. .rustfmt.toml
  56. ARCHITECTURE.md
  57. Cargo.toml
  58. CONTRIBUTING.md
  59. LICENSE
  60. navbar.md
  61. OWNERS
  62. README.md
  63. run_tests
  64. rust-toolchain
  65. setup_cros_cargo.sh
  66. test_all
  67. unblocked_terms.txt
README.md

crosvm - The Chrome OS Virtual Machine Monitor

crosvm is a virtual machine monitor (VMM) based on Linux’s KVM hypervisor, with a focus on simplicity, security, and speed. crosvm is intended to run Linux guests, originally as a security boundary for running native applications on the Chrome OS platform. Compared to QEMU, crosvm doesn’t emulate architectures or real hardware, instead concentrating on paravirtualized devices, such as the virtio standard.

crosvm is currently used to run Linux/Android guests on Chrome OS devices.

Logo