Change getComponentMethodExpression to getComponentMethodImplementation
This was a pending TODO that will be needed for scoped PMBEs because the codeblock will need to control when it returns its value. In particular, the current implementation does not allow for expressions of more than 1 statement. However, this scoped bindings will inline DCL, so we will need to be able to have expressions with multiple statements.
Another option would be to break the DCL into a separate method instead of reusing the component method, but I think we are trying to avoid that unnecessary indirection.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=173263605
diff --git a/java/dagger/internal/codegen/ComponentBindingExpressions.java b/java/dagger/internal/codegen/ComponentBindingExpressions.java
index 11a1bd6..6972965 100644
--- a/java/dagger/internal/codegen/ComponentBindingExpressions.java
+++ b/java/dagger/internal/codegen/ComponentBindingExpressions.java
@@ -22,6 +22,7 @@
import com.google.common.collect.FluentIterable;
import com.google.common.collect.ImmutableList;
import com.squareup.javapoet.ClassName;
+import com.squareup.javapoet.CodeBlock;
import java.util.HashMap;
import java.util.Map;
import javax.lang.model.type.TypeMirror;
@@ -123,9 +124,9 @@
* @throws IllegalStateException if there is no binding expression that satisfies the dependency
* request
*/
- Expression getComponentMethodExpression(DependencyRequest request, ClassName requestingClass) {
+ CodeBlock getComponentMethodImplementation(DependencyRequest request, ClassName requestingClass) {
return getBindingExpression(request.bindingKey())
- .getComponentMethodExpression(request, requestingClass);
+ .getComponentMethodImplementation(request, requestingClass);
}
private BindingExpression getBindingExpression(BindingKey bindingKey) {