Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / dagger2 / 895e731052ddd1e2281a5ed3294794d9ca07cdc1
  1. 895e731 Make generated code deterministic by cushon · 6 years ago
  2. dc169da Migrate users from the old, deprecated Subject.fail* methods to the new Subject.fail* methods or, in some cases, to Subject.check. by cpovirk · 6 years ago
  3. a0e29d6 Simplify some JavaPoet code by running a new set of Refaster templates by ronshapiro · 6 years ago
  4. add5a74 Rename moduleBindingValidation to fullBindingGraphValidation. The old name continues to work as an alias. by dpb · 6 years ago
  5. 5821e87 Use c.g.c.base.Optional.asSet().forEach() instead of toJavaUtil().ifPresent(). by ronshapiro · 6 years ago
  6. 530b4c8 Migrate from is(Not)SameAs to is(Not)SameInstanceAs. by cpovirk · 6 years ago
  7. 298dea8 Only public components should have public generated components by ronshapiro · 6 years ago
  8. d3ed46d Extract a BindingElementValidator type from BindingMethodValidator by ronshapiro · 6 years ago
  9. e6c6a9f Automated rollback of 16734557b96f38b79efcb4764fef4e08aa44c305 by ronshapiro · 6 years ago
  10. 1673455 Only public components should have public generated components by ronshapiro · 6 years ago
  11. 6054ba5 Migrate from assertThat(foo).named("foo") to assertWithMessage("foo").that(foo). by cpovirk · 6 years ago
  12. 2f0fd1a Simple refactoring of a commonly used frameworkTypeUsageStatement pattern in ProducerFactoryGenerator by ronshapiro · 6 years ago
  13. 5d8ba7e Remove unused method by ronshapiro · 6 years ago
  14. 8b5136c Use transformValues() + copyOf() instead of collecting to a builder by ronshapiro · 6 years ago
  15. 4e5c54b Change test instructions to use `bazel test`. by cpovirk · 6 years ago
  16. 14efb8f Migrate from isNotSameAs to isNotSameInstanceAs. by cpovirk · 6 years ago
  17. 1bc0423 Break after the statement in method proxies by ronshapiro · 6 years ago
  18. ec3145b Get rid of some uses of FrameworkDependency for simpler code by ronshapiro · 6 years ago
  19. a9bf86d Migrate Truth subjects from the old fail(String, Object) to the new failWithActual(String, Object), tweaking verbs for the new grammar. by cpovirk · 6 years ago
  20. d460522 Update to new bazel_common to pick up Truth 0.44 -- and Guava 27.1. by cpovirk · 6 years ago
  21. 0d8a856 Refactor ComponentCreatorValidator to avoid the need to pass around so many parameters. by cgdecker · 6 years ago
  22. fd231d9 Fix typo. by dpb · 6 years ago
  23. 15d20f8 Do full binding graph validation for components and subcomponents. by dpb · 6 years ago
  24. 5d6fa23 Enable GoodTime-API for Dagger by kak · 6 years ago
  25. 49c072d Add @FormatMethod to a format method. by cgdecker · 6 years ago
  26. 7e374b5 Pass SubcomponentDeclarations instead of TypeElements to SubcomponentCreatorBindingEdgeImpl. by ronshapiro · 6 years ago
  27. fcd069c Don't format generated code by default by ronshapiro · 6 years ago
  28. 19f768d Add instructions to set up a dev environment by Pierre-Yves Ricau · 6 years ago
  29. 177809c Configure travis builds to run on ubuntu trusty (from precise) so that we get GLIBC 2.17, which Bazel 0.24.1 requires. by ronshapiro · 6 years ago
  30. f1d4925 Update to Bazel 0.24.1 and fix a few things that came up during upgrading by ronshapiro · 6 years ago
  31. 645f5d7 Make parseOption methods non-static so they can cache their results, so we don't report an error more than once per option. by dpb · 6 years ago
  32. 3dcff26 Add a simple framework to collect Dagger codebase stats using ErrorProne by ronshapiro · 6 years ago
  33. 89a31a7 Fix typo in Javadoc. by dpb · 6 years ago
  34. 5a610e0 Refactor ModuleBindingValidationTest some more to prepare for applying full binding graph validation to components and subcomponents. by dpb · 6 years ago
  35. bb1a466 Serialize metadata about the binding graph in abstract component implementations by ronshapiro · 6 years ago
  36. 4f4dc41 Replace AutoValue-based CompilerOptions with one that parses the options on demand. Simplifies compiler options code. by dpb · 6 years ago
  37. 2117957 Simplify ModuleBindingValidationTest by splitting out the cases instead of looking at several errors for one compilation. by dpb · 6 years ago
  38. 6b51a67 Allow Dagger options to be set using an annotation, @DaggerOptions. by bcorso · 6 years ago
  39. 70210e2 Replace simple_jar.sh with @bazel_tools//zip:zipper, avoiding the need to do filesystem scanning to find a the enclosing directory of the srcs by thaidn · 6 years ago
  40. 81e4fc9 Refactor and expose module and component annotations as static final fields. by bcorso · 6 years ago
  41. 188160a Make Java 7 compatibility work-arounds conditional on the source version by cushon · 6 years ago
  42. 8051d28 Fix an issue where @BindsInstance on a Builder setter method's parameter caused a failure in codegen if the parameter had a different name than the setter method. by cgdecker · 6 years ago
  43. dc3bf5c Small test file cleanup by ronshapiro · 6 years ago
  44. d68e8ba Refactor CompilerOptions in advance of supporting option aliases (for a renaming). by dpb · 6 years ago
  45. 5e9bc77 Change ComponentCreatorAnnotation into an enum for simplification. (Reduces use of ComponentKind enum.) by dpb · 6 years ago
  46. 3c83f5f Simple refactoring of ComponentProcessingStep in advance of another CL to add full binding graph validation for subcomponents and components. by dpb · 6 years ago
  47. 60dc2a6 Allow @BindsInstance on parameters of builder methods, with the same results as putting the annotation on the method itself. @BindsInstance may not be present on both the method and the parameter; users must choose one or the other (not checking for consistency between different methods, though). by cgdecker · 6 years ago
  48. 61a77a9 Replace ComponentMethodDescriptor.kind() (and the enum) with subcomponent() for subcomponent factory or creator methods. Simplifies a bunch of code. by dpb · 6 years ago
  49. cb64548 Replace static methods in ConfigurationAnnotations with a ComponentAnnotation type representing information in a @Component, @ProductionComponent, @Subcomponent, or @ProductionSubcomponent annotation, as well as the fictional component annotations generated from module annotations. by dpb · 6 years ago
  50. f985e9b Add @since 2.22 to @Component.Factory and friends. by cgdecker · 6 years ago
  51. 51a3375 Reorder a condition in InjectBindingRegistryImpl by ronshapiro · 6 years ago
  52. 650f3c1 Fix BindingGraphPlugin#initElements javadoc. by ruli · 6 years ago
  53. 0df1816 Cleanup refactorings to test code. by dpb · 6 years ago
  54. a647c14 Don't check visibility of includes on module types that are public, but not effectively public (because they're nested in a non-public type). by cgdecker · 6 years ago
  55. d26e073 Refactor exception-message assertions to use ThrowableSubject.hasMessageThat(). This replaces assertions of the form assertThat(e).hasMessage(...) and assertThat(e.getMessage()) with assertThat(e).hasMessageThat(). by diamondm · 6 years ago
  56. 9924ac4 Index BindingGraph nodes by Class so that we don't need to loop over each repeatedly each time. by ronshapiro · 6 years ago
  57. 13882a0 Fix Github access token for deploying Javadoc to gh-pages. by cgdecker · 6 years ago
  58. 2c0b7a0 Begin to use @Subcomponent.Factory in dagger.android by ronshapiro · 6 years ago
  59. 4709119 Small ternary simplification by ronshapiro · 6 years ago
  60. 8996cfd Use the ComponentDescriptor directly instead of going through the BindingGraph. by ronshapiro · 6 years ago
  61. 623bab9 github.com/google/kythe -> github.com/kythe/kythe by justinbuchanan · 6 years ago
  62. bfdecad Allow public modules to include non-public modules when those included modules do not require an instance: that is, they only have abstract and/or static binding methods. by cgdecker · 6 years ago
  63. 3ddfa8b Small change to logic for ComponentRequirement.requiresAPassedInstance. by cgdecker · 6 years ago
  64. dbfd1cd Create a factory methods for ComponentImplementations instead of calling constructors directly. by ronshapiro · 6 years ago
  65. a5b7273 Don't create MethodSpecs with bodies for methods that are modifiable and do not have a base class implementation. by ronshapiro · 6 years ago
  66. e845df9 Remove usage of weird formatErrorMessage() in (Producer)ModuleFactoryGeneratorTest. It added more characters than it saved and didn't seem to serve any purpose. by cgdecker · 6 years ago
  67. 7392f8b Extract a method to make a future refactoring simpler by ronshapiro · 6 years ago
  68. 1ea36ec Fix some weird logic in ModuleValidator. by cgdecker · 6 years ago
  69. e75b52c Move possiblyNecessaryComponentRequirements from BindingGraph to ComponentDescriptor. by ronshapiro · 6 years ago
  70. c9d9659 Add a method to DiagnosticReporter to allow plugins to report elementless diagnostics by ronshapiro · 6 years ago
  71. 9582bc3 Report an error for scopes on @Multibinds methods. We may at some point want to allow this, but until we have an implementation, we should report an error so that users don't have mismatched expectations. by ronshapiro · 6 years ago
  72. 5164247 Remove stale comment by ronshapiro · 6 years ago
  73. 9e0baea Ensure that all parameters to a factory method (other than nullable @BindsInstance parameters) are required to be non-null, even if the parameter is for a module that isn't required/used when constructing the component. by cgdecker · 6 years ago
  74. ddbb975 Separate out the AOT logic from addInterfaceMethods so that it's clear what happens when AOT is not on. It wasn't clear to me what happened in that case, and you have to parse AOT logic to understand it. by ronshapiro · 6 years ago
  75. 408dac7 Track reimplemented methods in ModifiableBindingMethods too by ronshapiro · 6 years ago
  76. b473db2 Add some functional tests for factories and fix a few issues: by cgdecker · 6 years ago
  77. 3bba076 Make the values of ComponentImplementation.multibindingContributionsMade Keys instead of DependencyRequests. This will help a later CL that attempts to serialize aspects of the ComponentImplementation, as it's easier to (de)serialize a Key than a full DependencyRequest. by ronshapiro · 6 years ago
  78. c760386 Format all bzl files by ronshapiro · 6 years ago
  79. a202b4e Add runtime retention and @Documented to @ContributesAndroidInjector by jakew · 6 years ago
  80. a6a2c95 Remove annotation which was part of releasable references by jakew · 6 years ago
  81. 31a5e36 Retain Builder and Factory annotations for reflective access by jakew · 6 years ago
  82. dfce9bf Don't assume auto-value is on the processorpath by jakew · 6 years ago
  83. 82f10d4 Don't bother looking for @GenerationOptions if we're not in AOTS mode. by dpb · 6 years ago
  84. 969f532 Don't recompute top-level ComponentImplementation instances if we already have created one in the same round. by ronshapiro · 6 years ago
  85. d309cac For each ProcessingStep implementation class Dagger uses, record the duration of each processing round for that step in the build statistics. by cgdecker · 6 years ago
  86. d38a489 Remove ResolvedBindings.resolvingComponent() by ronshapiro · 6 years ago
  87. c7b0f12 Optimizations to ResolvedBindings by ronshapiro · 6 years ago
  88. ff2db63 When naming the key of a nested class type, use the enclosing class name if the nested type's simple name is very common (like "Builder", "Factory", etc). by ronshapiro · 6 years ago
  89. 1efadd4 Lambda -> method reference by ronshapiro · 6 years ago
  90. be0c9ff Move DaggerBuildStatistics from JavaBuilder's codebase into Dagger's codebase. by dpb · 6 years ago
  91. 4e1dc54 Add visitVariableAsParameter. @BindsInstance parameters on component factory methods trigger that codepath and currently crash. by gak · 6 years ago
  92. 51e63e9 Updating dagger.model.Key.toString() to provide stable string for binding annotations with parameters specified in a different order. Currently @Blah(a = "a", b = "b") and @Blah(b = "b", a = "a") will produce different toString() results. by idk · 6 years ago
  93. 3e9fcf1 Simplify simple_jar's bash code a bit. by dpb · 6 years ago
  94. b4c417e Add test for case where all files are in the wrong package. by dpb · 6 years ago
  95. c366dc2 Add unit test for simple_jar.sh. by dpb · 6 years ago
  96. 2ed6c50 Split up DaggerStatistics into a data class, a collector, and an interface for recording the collected data. by cgdecker · 6 years ago
  97. e4d1847 Use Bash regular expression matching instead of grep -P. by dpb · 6 years ago
  98. f38517b Extract simple_jar.sh from simple_jar.bzl. by dpb · 6 years ago
  99. 8186a1b Tokenize javacopts by cushon · 6 years ago
  100. 5960719 Don't reimplement provision requests for production bindings that replace modifiable methods by ronshapiro · 6 years ago