commit 4e11b615db145e32796641d864cf5c37700fdda3
author John Kessenich <cepheus@frii.com> Thu Aug 30 16:56:59 2018 -0600
committer John Kessenich <cepheus@frii.com> Thu Aug 30 16:59:13 2018 -0600
tree fa6e92153305f5406eec8c93a85ae44960cf1727
parent a4dfede4cc2eb3d5ae896d7d3a7cfced7a06dc4f

SPV: Turn off the default validation done by the SPIRV-Tools optimizer.

Also use the glslang namespace qualifier consistently and validate after
legalization, not before. (But most tests don't legalize.)

SPIRV/GlslangToSpv.cpp

diff --git a/SPIRV/GlslangToSpv.cpp b/SPIRV/GlslangToSpv.cpp
index 164fa23..cffeb20 100755
--- a/SPIRV/GlslangToSpv.cpp
+++ b/SPIRV/GlslangToSpv.cpp
@@ -6962,7 +6962,7 @@
     if (out.fail())
         printf("ERROR: Failed to open file: %s\n", baseName);
     out << "\t// " << 
-        glslang::GetSpirvGeneratorVersion() << "." << GLSLANG_MINOR_VERSION << "." << GLSLANG_PATCH_LEVEL <<
+        GetSpirvGeneratorVersion() << "." << GLSLANG_MINOR_VERSION << "." << GLSLANG_PATCH_LEVEL <<
         std::endl;
     if (varName != nullptr) {
         out << "\t #pragma once" << std::endl;
@@ -6989,13 +6989,13 @@
 //
 // Set up the glslang traversal
 //
-void GlslangToSpv(const glslang::TIntermediate& intermediate, std::vector<unsigned int>& spirv, SpvOptions* options)
+void GlslangToSpv(const TIntermediate& intermediate, std::vector<unsigned int>& spirv, SpvOptions* options)
 {
     spv::SpvBuildLogger logger;
     GlslangToSpv(intermediate, spirv, &logger, options);
 }
 
-void GlslangToSpv(const glslang::TIntermediate& intermediate, std::vector<unsigned int>& spirv,
+void GlslangToSpv(const TIntermediate& intermediate, std::vector<unsigned int>& spirv,
                   spv::SpvBuildLogger* logger, SpvOptions* options)
 {
     TIntermNode* root = intermediate.getTreeRoot();
@@ -7003,11 +7003,11 @@
     if (root == 0)
         return;
 
-    glslang::SpvOptions defaultOptions;
+    SpvOptions defaultOptions;
     if (options == nullptr)
         options = &defaultOptions;
 
-    glslang::GetThreadPoolAllocator().push();
+    GetThreadPoolAllocator().push();
 
     TGlslangToSpvTraverser it(intermediate.getSpv().spv, &intermediate, logger, *options);
     root->traverse(&it);
@@ -7015,20 +7015,20 @@
     it.dumpSpv(spirv);
 
 #if ENABLE_OPT
-    if (options->validate)
-        SpirvToolsValidate(intermediate, spirv, logger);
-
     // If from HLSL, run spirv-opt to "legalize" the SPIR-V for Vulkan
     // eg. forward and remove memory writes of opaque types.
     if ((intermediate.getSource() == EShSourceHlsl || options->optimizeSize) && !options->disableOptimizer)
         SpirvToolsLegalize(intermediate, spirv, logger, options);
 
+    if (options->validate)
+        SpirvToolsValidate(intermediate, spirv, logger);
+
     if (options->disassemble)
-        glslang::SpirvToolsDisassemble(std::cout, spirv);
+        SpirvToolsDisassemble(std::cout, spirv);
 
 #endif
 
-    glslang::GetThreadPoolAllocator().pop();
+    GetThreadPoolAllocator().pop();
 }
 
 }; // end namespace glslang