commit 18e13427fa32a5464f1678be31512c0e0fec59c7
author Roland McGrath <roland@redhat.com> Mon Aug 15 08:01:25 2005 +0000
committer Roland McGrath <roland@redhat.com> Mon Aug 15 08:01:25 2005 +0000
tree 217788939d8b9732b6da4f5b975edb28897a7441
parent 0f6abbbc08ee259a1a702e7dd3be3e2c6b82305e

2005-08-14  Roland McGrath  <roland@redhat.com>

	* elflint.c (check_sections): Use ebl_section_type_name and allow any
	sh_type it recognizes.

	* elflint.c (check_sections): Print unknown flags in hex, don't
	truncate high bits.  Print section number and name for unknown type.

src/ChangeLog

diff --git a/src/ChangeLog b/src/ChangeLog
index 5dd61f2..a95f5c5 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,11 @@
+2005-08-14  Roland McGrath  <roland@redhat.com>
+
+	* elflint.c (check_sections): Use ebl_section_type_name and allow any
+	sh_type it recognizes.
+
+	* elflint.c (check_sections): Print unknown flags in hex, don't
+	truncate high bits.  Print section number and name for unknown type.
+
 2005-08-13  Roland McGrath  <roland@redhat.com>
 
 	* elflint.c (check_program_header): Use ebl_segment_type_name and

src/elflint.c

diff --git a/src/elflint.c b/src/elflint.c
index 65b3fb7..53abf84 100644
--- a/src/elflint.c
+++ b/src/elflint.c
@@ -678,7 +678,8 @@
       else
 	xndx = sym->st_shndx;
 
-      if (GELF_ST_TYPE (sym->st_info) >= STT_NUM)
+      if (GELF_ST_TYPE (sym->st_info) >= STT_NUM
+	  && !ebl_symbol_type_name (ebl, GELF_ST_TYPE (sym->st_info), NULL, 0))
 	ERROR (gettext ("section [%2d] '%s': symbol %zu: unknown type\n"),
 	       idx, section_name (ebl, idx), cnt);
 
@@ -2708,16 +2709,20 @@
 	  && shdr->sh_type != SHT_CHECKSUM
 	  && shdr->sh_type != SHT_GNU_verdef
 	  && shdr->sh_type != SHT_GNU_verneed
-	  && shdr->sh_type != SHT_GNU_versym)
-	ERROR (gettext ("unsupported section type %d\n"), (int) shdr->sh_type);
+	  && shdr->sh_type != SHT_GNU_versym
+	  && ebl_section_type_name (ebl, shdr->sh_type, NULL, 0) == NULL)
+	ERROR (gettext ("section [%2zu] '%s' has unsupported type %d\n"),
+	       cnt, section_name (ebl, cnt),
+	       (int) shdr->sh_type);
 
 #define ALL_SH_FLAGS (SHF_WRITE | SHF_ALLOC | SHF_EXECINSTR | SHF_MERGE \
 		      | SHF_STRINGS | SHF_INFO_LINK | SHF_LINK_ORDER \
 		      | SHF_OS_NONCONFORMING | SHF_GROUP | SHF_TLS)
       if (shdr->sh_flags & ~ALL_SH_FLAGS)
-	ERROR (gettext ("section [%2zu] '%s' contain unknown flag(s) %d\n"),
+	ERROR (gettext ("section [%2zu] '%s' contains unknown flag(s)"
+			" %#" PRIx64 "\n"),
 	       cnt, section_name (ebl, cnt),
-	       (int) shdr->sh_flags & ~ALL_SH_FLAGS);
+	       (uint64_t) shdr->sh_flags & ~(uint64_t) ALL_SH_FLAGS);
       else if (shdr->sh_flags & SHF_TLS)
 	{
 	  // XXX Correct?