commit c435a33811428ebad7b8d420821d0b8e10cd84d2
author Omar Sandoval <osandov@fb.com> Wed Dec 11 16:23:27 2019 -0800
committer Mark Wielaard <mark@klomp.org> Thu Dec 12 12:08:51 2019 +0100
tree 80918bbe939e54bd260c8ae0434ff037a2c07f32
parent ef99c782042ea6f1d47b94a511dbf667b0d474cb

configure: Fix -D_FORTIFY_SOURCE=2 check when CFLAGS contains -Wno-error

If CFLAGS contains -Wno-error, then the check for -D_FORTIFY_SOURCE=2
won't fail when appropriate. E.g., compiling with:

  ./configure CFLAGS='-Wno-error -O0' &&

Results in a flood of "_FORTIFY_SOURCE requires compiling with
optimization (-O)" warnings.

Make sure we add -Werror after the user-defined CFLAGS.

Signed-off-by: Omar Sandoval <osandov@fb.com>

configure.ac

diff --git a/configure.ac b/configure.ac
index 36a6b6c..25555d0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -273,7 +273,7 @@
     ;;
   *)
     save_CFLAGS="$CFLAGS"
-    CFLAGS="-D_FORTIFY_SOURCE=2 -Werror $CFLAGS"
+    CFLAGS="-D_FORTIFY_SOURCE=2 $CFLAGS -Werror"
     AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
       #include <string.h>
       int main() { return 0; }