[PATCH] Potential overflow and unused variable
'tmpbuf' was unused. Limit [name] entry to 255 chars to avoid
overflowing the buffer.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
diff --git a/init.c b/init.c
index 2cfa6d2..732cceb 100644
--- a/init.c
+++ b/init.c
@@ -843,7 +843,7 @@
{
unsigned int global;
struct thread_data *td;
- char *string, *name, *tmpbuf;
+ char *string, *name;
fpos_t off;
FILE *f;
char *p;
@@ -857,7 +857,7 @@
string = malloc(4096);
name = malloc(256);
- tmpbuf = malloc(4096);
+ memset(name, 0, 256);
stonewall = stonewall_flag;
while ((p = fgets(string, 4096, f)) != NULL) {
@@ -865,7 +865,7 @@
break;
if (is_empty_or_comment(p))
continue;
- if (sscanf(p, "[%s]", name) != 1)
+ if (sscanf(p, "[%255s]", name) != 1)
continue;
global = !strncmp(name, "global", 6);
@@ -916,7 +916,6 @@
free(string);
free(name);
- free(tmpbuf);
fclose(f);
return ret;
}