Fix some cppcheck reports
* src/libFLAC/metadata_iterators.c:3247: (error) va_list `va` was opened
but not closed with va_end().
* src/share/grabbag/snprintf.c:66: (error) va_list `va` was opened but
not closed with va_end().
* src/utils/flactimer/main.cpp:84: (warning) Either the condition `!fout`
is redundant or there is possible null pointer dereference.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Closes: https://github.com/xiph/flac/pull/8
diff --git a/src/libFLAC/metadata_iterators.c b/src/libFLAC/metadata_iterators.c
index 4fd58c8..9356416 100644
--- a/src/libFLAC/metadata_iterators.c
+++ b/src/libFLAC/metadata_iterators.c
@@ -3240,11 +3240,14 @@
va_list va;
int rc;
- va_start (va, fmt);
-
#if defined _MSC_VER
if (size == 0)
return 1024;
+#endif
+
+ va_start (va, fmt);
+
+#if defined _MSC_VER
rc = vsnprintf_s (str, size, _TRUNCATE, fmt, va);
if (rc < 0)
rc = size - 1;